Re: [josm-dev] Automatic tag correction
Dirk Stöcker schrieb: You are not up-to-date. Revision 764. :-) Oops! Thanks :-) Robin ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Automatic tag correction
On Sun, 3 Aug 2008, Robin Rattay wrote:
here is a small update of the TagCorrector. Some code cleanup and
addition of the key prefixes/suffixes forward and backward.
This does not work:
+ return applyCorrections(
+ tagCorrections,
+ way,
+ tr(When reverting this way + nameVisitor.name
+ + , following changes to the properties are
suggested
+ + in order to maintain data consistency.));
You cannot join translatable strings.
Use {0} for arguments. tr( {0} yyy {1}..., arg1, arg2);
Ciao
--
http://www.dstoecker.eu/ (PGP key available)
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Automatic tag correction
Dirk Stöcker schrieb: Did you fix your problems. The reload is easy: You need to emit the correct signal. Don't ask me which one or how :-) Yes, I've got it. I'll post a new patch tomorrow. P.S. I used your src/org/openstreetmap/josm/data/osm/OSMUtils.java as OsmUtils.java in my changes, so this part of the patch is no longer required :-) Great :-) Robin ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Automatic tag correction
Raphael Mack schrieb: Am Sonntag, 6. Juli 2008 schrieben Sie: You mean I should use public fields? Well, the access methods *is* the correct way :-) but on the other hand it's such a simple record class so public fields are probably ok here. No, actually not. I do think we should clean up josm code sooner or later. I really encourage to use the proper java way and completely omit public fields ;-) Ah, ok. Unfortunatly there is not opposite to that. If my feature catches on, then we could define tags like cycleway:left=lane that can be corrected to cycleway:right=lane. I would prefer such a much cleaner tagging style, but it's not in use actually.. Actually my suggestion is bad, since it's confusing when differentiating between right-hand and left-hand driving. I considered that, but I prefered to keep all the corrector classes together. Maybe it just should be moved out of the data package. I don't know. I would have put it into the gui package, that's all. I perfectly can live with it all together. My problem is, that only part of the corrector is actualy gui. There is some logic in there that doesn't really belong into gui. Maybe I'd need to separate logic und gui more. Robin ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Automatic tag correction
Hi, Am Sonntag, 6. Juli 2008 schrieb Robin Rattay: That's why I've attemped implement a tag corrector feature, that I really like that feature and think we should include it. I've set it up in a way that allows to use the functionalty elsewhere, [...] A next step would be to have corrections of relations in a simular manner. Yes, but I fear, this is not possible in such a easy and straight forward manner. About your patch: Class TagCorrection, is not the way data structures are implemented in JOSM so far (atm there are public fields everywhere!), but I really like the suggestion. The TagCorrections don't seem to be undoable, right? - this should be implemented. There are some tags like cycleway=opposite_lane, these should be adapted similar. Maybe TagCorrectionTable should better be placed in the gui subpackage. Rapha ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Automatic tag correction
On Sun, 6 Jul 2008, Robin Rattay wrote: I've attached a patch, with the hope that someone could give their opinion on the idea in general and my implementation in particular. Idea in general is very nice. Implementation probably has some problems to be fixed, but I'm not yet the one to comment on these :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
