Re: [josm-dev] Changeset Upload Policy/Strategy
Hi, yes, there is a difference. Strategy is used for http://josm.openstreetmap.de/browser/trunk/src/org/openstreetmap/josm/gui/io/UploadStrategy.java Policy is used for http://josm.openstreetmap.de/browser/trunk/src/org/openstreetmap/josm/gui/io/MaxChangesetSizeExceededPolicy.java The two concepts are orthogonal and have to be named differently. I've chosen strategy for the former because it represents three possible approaches to run uploads. The later is called a policy because it represents three possible decisions to be taken in case an upload hits the size limit for a changeset. But feel free to change the names in whatever suits you better. Don't forget to update the online help too, though. http://josm.openstreetmap.de/wiki/Help/Action/Upload Regards Karl Am 03.01.2010 13:17, schrieb Frederik Ramm: Hi, while working on translations I encountered some confusion in the source, namely it seems to me that the words changeset upload strategy and changeset upload policy are used interchangeably. I wanted to fix that but found that this would require renaming a number of methods and classes, so I refrained from it for the time being, not wanting to break anything - but could someone confirm that there is indeed no conceptual difference between the two, and ideally rename stuff (to strategy, I would suggest)? Or have I misread the situation and there is a difference? Bye Frederik ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Changeset Upload Policy/Strategy
Hi, Karl Guggisberg wrote: The two concepts are orthogonal and have to be named differently. I've chosen strategy for the former because it represents three possible approaches to run uploads. The later is called a policy because it represents three possible decisions to be taken in case an upload hits the size limit for a changeset. Hm. It seems I'll have to review my translations then. (Maybe when writing translations I should stop thinking will the user understand this and simply translate the messages ;-) Bye Frederik -- Frederik Ramm ## eMail frede...@remote.org ## N49°00'09 E008°23'33 ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Changeset Upload Policy/Strategy
On Sun, 3 Jan 2010, Frederik Ramm wrote: The two concepts are orthogonal and have to be named differently. I've chosen strategy for the former because it represents three possible approaches to run uploads. The later is called a policy because it represents three possible decisions to be taken in case an upload hits the size limit for a changeset. Hm. It seems I'll have to review my translations then. (Maybe when writing translations I should stop thinking will the user understand this and simply translate the messages ;-) No. Some of the internal messages aren't really understandable and rather should be fixed than translated as is. Generally the rule is: When it needs to be explained, then it probably also needs to be fixed (which not necessary means the fix would be easy :-). P.S. One note Frederik: Die deutsche Übersetzung nutzt immer Passivkonstruktionen, wo im englischen teilweise die Software etwas tut: Nicht Lade xxx herunter, sondern xxx herunterladen. Das hat damals Claudius (denke ich) eingeführt und es hat den Dialogen sehr gut getan. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
