Re: [josm-dev] JOSM adds double ways to relations?

2009-07-25 Thread Apollinaris Schoell

On Jul 25, 2009, at 12:53 AM, Karl Guggisberg wrote:

>
>> I only realised that there was two delete buttons last night.
>> I think that there needs to be a better tooltop message,
> Any proposals for better messages?

make them consistent in the terms used

1) Remove all members of currently selected object from relation
should match this tooltip
2) Remove this member .

Is there a difference between object and primitive? otherwise use the  
same for all add/remove tool tips.


>
>> ... and icon to denote all or just that instance.
> Proposals for better icons would be appreciated too.
>

icon on the right side to remove all members should be similar to the  
add to icons with a arrow from left to right or just a arrow.

>> Why do the two buttons need to be so far apart?
> Before there were two delete buttons in the botom row an we've got  
> several
> tickets in JOSM trac because
> it wasn't clear enough in what sense they were different.
> They are no so far apart  because they are placed in their  
> "context". The
> button on the left is close
> to the list of members. It deletes *all selected members*.
> The button on the right is close to the list of *selected  
> primitives*. It
> deletes all members referring
> to one of the selected primitives.
> If I have to *explain* why they are placed where they are placed now  
> the
> idea is obviously not intuitive enough, though.
> Any alternative proposals?
>

I think the left button is what most want to use. the right one should  
be the exception and it does something non intuitive.
idea 1: make this button really look dangerous e.g. in red

idea 2: remove the right button completely. instead make it possible  
to select all members of the same primitive
now clicking a object in the left list selects a primitive in the  
layout and adds it in the right list. this can be done also from right  
to left list. simply clicking may interfere with the selection  
behavior in the layout especially when multiple objects are selected.  
So it might be better to have a menu on right click where you can  
select deselect all members of an object


good work so far functionality is really great now!

> -- Karl
>
>
> -Ursprüngliche Nachricht-
> Von: josm-dev-boun...@openstreetmap.org
> [mailto:josm-dev-boun...@openstreetmap.org] Im Auftrag von Shaun  
> McDonald
> Gesendet: Samstag, 25. Juli 2009 01:36
> An: Lennard
> Cc: josm-dev
> Betreff: Re: [josm-dev] JOSM adds double ways to relations?
>
>
> On 24 Jul 2009, at 19:50, Lennard wrote:
>
>> Maarten Deen wrote:
>>
>>> That's a serious issue. I've seen that all the double ways appear in
>>> the "edit relation" box with "->->" or "<-<-" in the "linked"  
>>> column.
>>> But if I then remove one of those lines, both ways get removed from
>>> the relation.
>>> Surely that is not intentional?
>>
>> I got bitten by that before, and the answer I got was: "You're using
>> the wrong delete button". I kid you not, I never noticed the other
>> Delete button before that. :-)
>
> I only realised that there was two delete buttons last night. I think
> that there needs to be a better tooltop message, and icon to denote  
> all or
> just that instance. Why do the two buttons need to be so far apart?
>
>>
>> But the relation editor received a major overhaul in the past weeks,
>> so some things may not work as before, yet.
>>
>>> Has someone already though of a "distinct" feature in the relation
>>> editor?
>>> Either a "remove double entries" or also a button "add selected
>>> distinct entries"?
>>
>> PS: s/double/duplicate/
>>
>>
>> --
>> Lennard
>>
>> ___
>> josm-dev mailing list
>> josm-dev@openstreetmap.org
>> http://lists.openstreetmap.org/listinfo/josm-dev
>
>
> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev
>
>
> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] JOSM adds double ways to relations?

2009-07-25 Thread Karl Guggisberg

> I only realised that there was two delete buttons last night. 
> I think that there needs to be a better tooltop message, 
Any proposals for better messages? 

> ... and icon to denote all or just that instance. 
Proposals for better icons would be appreciated too.

> Why do the two buttons need to be so far apart?
Before there were two delete buttons in the botom row an we've got several
tickets in JOSM trac because 
it wasn't clear enough in what sense they were different. 
They are no so far apart  because they are placed in their "context". The
button on the left is close
to the list of members. It deletes *all selected members*.
The button on the right is close to the list of *selected primitives*. It
deletes all members referring
to one of the selected primitives. 
If I have to *explain* why they are placed where they are placed now the
idea is obviously not intuitive enough, though.
Any alternative proposals? 

-- Karl


-Ursprüngliche Nachricht-
Von: josm-dev-boun...@openstreetmap.org
[mailto:josm-dev-boun...@openstreetmap.org] Im Auftrag von Shaun McDonald
Gesendet: Samstag, 25. Juli 2009 01:36
An: Lennard
Cc: josm-dev
Betreff: Re: [josm-dev] JOSM adds double ways to relations?


On 24 Jul 2009, at 19:50, Lennard wrote:

> Maarten Deen wrote:
>
>> That's a serious issue. I've seen that all the double ways appear in 
>> the "edit relation" box with "->->" or "<-<-" in the "linked" column. 
>> But if I then remove one of those lines, both ways get removed from 
>> the relation.
>> Surely that is not intentional?
>
> I got bitten by that before, and the answer I got was: "You're using 
> the wrong delete button". I kid you not, I never noticed the other 
> Delete button before that. :-)

I only realised that there was two delete buttons last night. I think   
that there needs to be a better tooltop message, and icon to denote all or
just that instance. Why do the two buttons need to be so far apart?

>
> But the relation editor received a major overhaul in the past weeks, 
> so some things may not work as before, yet.
>
>> Has someone already though of a "distinct" feature in the relation 
>> editor?
>> Either a "remove double entries" or also a button "add selected 
>> distinct entries"?
>
> PS: s/double/duplicate/
>
>
> --
> Lennard
>
> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] JOSM adds double ways to relations?

2009-07-24 Thread Shaun McDonald

On 24 Jul 2009, at 19:50, Lennard wrote:

> Maarten Deen wrote:
>
>> That's a serious issue. I've seen that all the double ways appear  
>> in the "edit
>> relation" box with "->->" or "<-<-" in the "linked" column. But if  
>> I then remove
>> one of those lines, both ways get removed from the relation.
>> Surely that is not intentional?
>
> I got bitten by that before, and the answer I got was: "You're using  
> the
> wrong delete button". I kid you not, I never noticed the other Delete
> button before that. :-)

I only realised that there was two delete buttons last night. I think   
that there needs to be a better tooltop message, and icon to denote  
all or just that instance. Why do the two buttons need to be so far  
apart?

>
> But the relation editor received a major overhaul in the past weeks,  
> so
> some things may not work as before, yet.
>
>> Has someone already though of a "distinct" feature in the relation  
>> editor?
>> Either a "remove double entries" or also a button "add selected  
>> distinct entries"?
>
> PS: s/double/duplicate/
>
>
> -- 
> Lennard
>
> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] JOSM adds double ways to relations?

2009-07-24 Thread Stefan Bethke
Am 24.07.2009 um 18:34 schrieb Maarten Deen:

> I admit I haven't used relations in a while, so I'm quite surprised  
> to see that
> JOSM now adds a way to a relation again if it was already in the  
> relation.
> Previously, ways that were already in a relation did not get added  
> again.
> I this an intentional change?
>
> So now I've ended up with a relation with almost all ways double. Is  
> there a
> quick and easy way to get all double ways removed from this relation?


It's rather annoying, I find as well.  With the old relation editor,  
you could select all (suspect) ways (which also selects them in the  
main window, remove them, and then add the selection again.  When re- 
adding the selection, each way is only added once.  Of course, you  
lose the role for each way, so it's not perfect.

I just looked at the new relation editor, and I can't say whether that  
method still works.


HTH,
Stefan

-- 
Stefan BethkeFon +49 151 14070811





___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] JOSM adds double ways to relations?

2009-07-24 Thread Lennard
Maarten Deen wrote:

> That's a serious issue. I've seen that all the double ways appear in the 
> "edit 
> relation" box with "->->" or "<-<-" in the "linked" column. But if I then 
> remove 
> one of those lines, both ways get removed from the relation.
> Surely that is not intentional?

I got bitten by that before, and the answer I got was: "You're using the 
wrong delete button". I kid you not, I never noticed the other Delete 
button before that. :-)

But the relation editor received a major overhaul in the past weeks, so 
some things may not work as before, yet.

> Has someone already though of a "distinct" feature in the relation editor? 
> Either a "remove double entries" or also a button "add selected distinct 
> entries"?

PS: s/double/duplicate/


-- 
Lennard

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] JOSM adds double ways to relations?

2009-07-24 Thread Maarten Deen
Frederik Ramm wrote:
> Hi,
> 
> Maarten Deen wrote:
>> I admit I haven't used relations in a while, so I'm quite surprised to see 
>> that 
>> JOSM now adds a way to a relation again if it was already in the relation. 
>> Previously, ways that were already in a relation did not get added again.
>> I this an intentional change?
> 
> Yes, this is because since 0.6 OpenStreetMap allows the same way to be 
> in the same relation twice (needed e.g. for a bus route that goes down a 
> spur and comes back).
> 
>> So now I've ended up with a relation with almost all ways double. Is there a 
>> quick and easy way to get all double ways removed from this relation?
> 
> Not yet I'm afraid.

That's a serious issue. I've seen that all the double ways appear in the "edit 
relation" box with "->->" or "<-<-" in the "linked" column. But if I then 
remove 
one of those lines, both ways get removed from the relation.
Surely that is not intentional?

Has someone already though of a "distinct" feature in the relation editor? 
Either a "remove double entries" or also a button "add selected distinct 
entries"?

I've managed to hack them out. The easy way I guess: select all ways in the 
relation, add some bogus tag, remove all ways from the segment, select all ways 
with the bogus tag and add them to the relation.
But I don't think that should be the way forward.

Maarten

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] JOSM adds double ways to relations?

2009-07-24 Thread Frederik Ramm
Hi,

Maarten Deen wrote:
> I admit I haven't used relations in a while, so I'm quite surprised to see 
> that 
> JOSM now adds a way to a relation again if it was already in the relation. 
> Previously, ways that were already in a relation did not get added again.
> I this an intentional change?

Yes, this is because since 0.6 OpenStreetMap allows the same way to be 
in the same relation twice (needed e.g. for a bus route that goes down a 
spur and comes back).

> So now I've ended up with a relation with almost all ways double. Is there a 
> quick and easy way to get all double ways removed from this relation?

Not yet I'm afraid.

Bye
Frederik

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


[josm-dev] JOSM adds double ways to relations?

2009-07-24 Thread Maarten Deen
I admit I haven't used relations in a while, so I'm quite surprised to see that 
JOSM now adds a way to a relation again if it was already in the relation. 
Previously, ways that were already in a relation did not get added again.
I this an intentional change?

So now I've ended up with a relation with almost all ways double. Is there a 
quick and easy way to get all double ways removed from this relation?

Regards,
Maarten

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev