[jQuery] Re: Autocomplte plugin status

2007-04-14 Thread Jörn Zaefferer


Klaus Hartl schrieb:
After all, I think scratch that tabbing... it really seems it is not 
expected behavior!
Ok Klaus. Anything else you had on your mind? Does the formatRow option 
suffice to change the size of certain results, or did you do any 
modifications for that?


--
Jörn Zaefferer

http://bassistance.de



[jQuery] Re: Autocomplte plugin status

2007-04-12 Thread [EMAIL PROTECTED]


I don't believe using tab to iterate through an auto-complete list
would be the expected behavior.  In my opinion, an auto-complete list
should mirror the behavior of a regular select element, whereby
hitting tab would select the currently high-lighted list option and
move to the next form field.  Anything else would seem disjointed to
the user.  What key would get you to the next field?  Enter, and
_then_ tab?  That's an unnecesary step considering you'd have to use
the up-arrow to go backwards in the list anyway.  If you are already
going to use one arrow why not use them both?

-khoker



On Apr 12, 12:32 am, Klaus Hartl [EMAIL PROTECTED] wrote:
 Jörn Zaefferer schrieb:



  Hi folks,

  I've achieved some progress on the autocomplte plugin. The features
  added by Dan Switzer to Dylan's initial plugin are now merged with
  modifications for completing multiple values, like in the gmail
  recpient-field.

  I made some minor API changes, changed a lot of default values to
  provide nice behaviour without specifying any options and refactored
  quite a lot of code to be able to fix the bugs I most likely introduced.
  I switched to event delegation for the select box, possibly improving
  performance a bit. Though Dylan's and Dan's caching code is already
  providing fast-as-hell autocompletition.

  There is one major issue I want to solve before publishing a first
  release of that rewrite. Until then the code can be found in jQuery's
  repository[1], if anyone is interested in testing: You're welcome!

  [1] svn://jquery.com/trunk/plugins/autocomplete

 Jörn, thanks for this. One question: I once modified Dylan's
 autocomplete a bit, so that if the autocomplete list is shown, tabbing
 would tab through the list instead of to the next form element. Is it
 possible to take into account?

 Have a look here:http://plazes.com/plazesand type something into the
 Where field.

 I think I also modified the behavior for arrow up/down keys a bit...

 -- Klaus



[jQuery] Re: Autocomplte plugin status

2007-04-12 Thread Dan G. Switzer, II

Klaus/Jörn,

Jörn, thanks for this. One question: I once modified Dylan's
autocomplete a bit, so that if the autocomplete list is shown, tabbing
would tab through the list instead of to the next form element. Is it
possible to take into account?

Have a look here: http://plazes.com/plazes and type something into the
Where field.

I think I also modified the behavior for arrow up/down keys a bit...

It looks like Jörn's already modified the source code so you can change the
default event.keyCode mappings. 

However, I noticed in your mod, the up/down keys still moved the highlighted
option and the tab key emulated the down key. Perhaps the mappings need to
allow for multiple keys.

On a personal note though, the Autocomplete functionality built in to
Firefox and IE works the same way as the default behavior--and that's
pressing the [TAB] key in the drop down selects the items and moves to the
next field. So, my personal opinion is that will be the expected behavior.

-Dan



[jQuery] Re: Autocomplte plugin status

2007-04-11 Thread Dan G. Switzer, II

Jörn,

I've achieved some progress on the autocomplte plugin. The features
added by Dan Switzer to Dylan's initial plugin are now merged with
modifications for completing multiple values, like in the gmail
recpient-field.

I made some minor API changes, changed a lot of default values to
provide nice behaviour without specifying any options and refactored
quite a lot of code to be able to fix the bugs I most likely introduced.
I switched to event delegation for the select box, possibly improving
performance a bit. Though Dylan's and Dan's caching code is already
providing fast-as-hell autocompletition.

There is one major issue I want to solve before publishing a first
release of that rewrite. Until then the code can be found in jQuery's
repository[1], if anyone is interested in testing: You're welcome!

One issue I noticed by looking at the code is that the findValue() won't
work with multi-selects. I actually started adding the code and removed it,
because I realized this would be tricky w/the current code structure.

The findValue() callback should probably return an array of all the matches
found. 

-Dan



[jQuery] Re: Autocomplte plugin status

2007-04-11 Thread Klaus Hartl


Jörn Zaefferer schrieb:


Hi folks,

I've achieved some progress on the autocomplte plugin. The features 
added by Dan Switzer to Dylan's initial plugin are now merged with 
modifications for completing multiple values, like in the gmail 
recpient-field.


I made some minor API changes, changed a lot of default values to 
provide nice behaviour without specifying any options and refactored 
quite a lot of code to be able to fix the bugs I most likely introduced. 
I switched to event delegation for the select box, possibly improving 
performance a bit. Though Dylan's and Dan's caching code is already 
providing fast-as-hell autocompletition.


There is one major issue I want to solve before publishing a first 
release of that rewrite. Until then the code can be found in jQuery's 
repository[1], if anyone is interested in testing: You're welcome!


[1] svn://jquery.com/trunk/plugins/autocomplete



Jörn, thanks for this. One question: I once modified Dylan's 
autocomplete a bit, so that if the autocomplete list is shown, tabbing 
would tab through the list instead of to the next form element. Is it 
possible to take into account?


Have a look here: http://plazes.com/plazes and type something into the 
Where field.


I think I also modified the behavior for arrow up/down keys a bit...


-- Klaus