[jQuery] Re: element.attr() bug in jquery 1.2.6?

2008-05-30 Thread Phil Christensen

On May 29, 5:55 pm, John Resig [EMAIL PROTECTED] wrote:
 I'm confused - you're getting and modifying the onclick attribute?
 That seems... strange.

Yeah, now that I think about it, it's pretty ridiculous. Ah, the
fruits of a rushed deployment...

I guess I tend to manipulate the DOM by default for most actions, but
in this case, I think I need to rework this to change handlers via
javascript.

On May 29, 7:02 pm, Ariel Flesler [EMAIL PROTECTED] wrote:
 Copied from the ticket itself:

 The patch about should modify attr() so that it supports this
 situation. It won't be applied for now for 2 reasons:

 1- The demo you showed doesn't work cross browser. As far as I tested,
 IE doesn't fire handlers set as strings with javascript. So there's no
 point in supporting that. 2- It needs a lot more of testing. Our test
 runner doesn't fail with this patch, but as attr() went to many
 changes lately, we'll give it special attention before modifying it
 again.

I think I had chosen to ignore that issue ;-)...I was fortunate to be
using this in an internal application where I got to insist on
Firefox...

Anyways, thanks for taking the time to look into it, even though it
was the wrong way to do it.

-phil


[jQuery] Re: element.attr() bug in jquery 1.2.6?

2008-05-29 Thread John Resig

I'm confused - you're getting and modifying the onclick attribute?
That seems... strange.

--John

On Thu, May 29, 2008 at 7:48 PM, Phil Christensen [EMAIL PROTECTED] wrote:

 Hi all,

 I've run into a strange issue that I believe is a bug in jQuery 1.2.6.
 I've posted a ticket along with a test HTML file at:

http://dev.jquery.com/ticket/2959

 As far as I can tell, attr() is not properly updating the value of a
 form attribute, although prior versions had worked fine.

 Any help in resolving this, or providing a workaround would be greatly
 appreciated.

 Thanks in advance,

 -phil



[jQuery] Re: element.attr() bug in jquery 1.2.6?

2008-05-29 Thread Ariel Flesler

Copied from the ticket itself:

The patch about should modify attr() so that it supports this
situation. It won't be applied for now for 2 reasons:

1- The demo you showed doesn't work cross browser. As far as I tested,
IE doesn't fire handlers set as strings with javascript. So there's no
point in supporting that. 2- It needs a lot more of testing. Our test
runner doesn't fail with this patch, but as attr() went to many
changes lately, we'll give it special attention before modifying it
again.

Thanks for reporting. 

Cheers
--
Ariel Flesler
http://flesler.blogspot.com

On 29 mayo, 18:55, John Resig [EMAIL PROTECTED] wrote:
 I'm confused - you're getting and modifying the onclick attribute?
 That seems... strange.

 --John



 On Thu, May 29, 2008 at 7:48 PM, Phil Christensen [EMAIL PROTECTED] wrote:

  Hi all,

  I've run into a strange issue that I believe is a bug in jQuery 1.2.6.
  I've posted a ticket along with a test HTML file at:

     http://dev.jquery.com/ticket/2959

  As far as I can tell, attr() is not properly updating the value of a
  form attribute, although prior versions had worked fine.

  Any help in resolving this, or providing a workaround would be greatly
  appreciated.

  Thanks in advance,

  -phil- Ocultar texto de la cita -

 - Mostrar texto de la cita -