[Review Queue] Openbook

2015-01-23 Thread Kevin Monroe
Openbook is a cloud billing solution from Talligent.  They charmed it up
and are proposing it for inclusion in the charm store.

The charm is really well documented and relates to mariadb and tomcat.
While peer reviewing with Cory, we noticed the relation to tomcat was over
the implicit juju-info.  Though this is common for subordinate charms
relating to tomcat, it isn't ideal -- it makes openbook capable of
colocating on any unit (since all units provide juju-info). See Cory's RQ
note from this morning for more info.  When tomcat is updated, we'll circle
back to all tomcat subordinates and suggest an updated relation.

Back to openbook -- following the readme was simple, and deployment went
smoothly.  This charm didn't include tests, so we can't recommend it in the
store just yet.  I proposed a simple test for inclusion and offered
suggestions in case they want to expand on mine.  I look forward to
re-reviewing once tests fall into place.

https://bugs.launchpad.net/charms/+bug/1411402

Thanks,
-Kevin
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju


Re: Multi user account management in juju

2015-01-23 Thread Mark Shuttleworth
On 22/01/15 14:28, Mark Shuttleworth wrote:
  * those users can then create environments as and when they need them
* each environment has its own cloud credentials

My mistake, looks like the multiple-environments-per-server option is
targeted to 1.22! Looking forward to it.

Mark


-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju


[Review Queue] Tomcat interface improvement, and MySQL test additions

2015-01-23 Thread Cory Johns
While helping with the OpenBook review, we discovered that the Tomcat
charm was did not have clearly described ways for ingesting Java
webapps, so I decided to submit a patch[1] to improve that.

I also reviewed two test submissions to the trusty MySQL charm, one of
which passed easily[2], and the other of which unfortunately has a
failure[3].


1: 
https://code.launchpad.net/~johnsca/charms/trusty/tomcat/explicit/+merge/247363
2: 
https://code.launchpad.net/~nicopace/charms/trusty/mysql/deploy-test/+merge/245425
3: 
https://code.launchpad.net/~nicopace/charms/trusty/mysql/scaling-test/+merge/245433

-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju