Re: [JPP-Devel] Combine and Explode Layers
Very good Larry! --- Mer 9/7/08, Nacho Uve [EMAIL PROTECTED] ha scritto: Da: Nacho Uve [EMAIL PROTECTED] Oggetto: Re: [JPP-Devel] Combine and Explode Layers A: OpenJump develop and use jump-pilot-devel@lists.sourceforge.net Data: Mercoledì 9 luglio 2008, 23:55 2008/7/9 Larry Becker [EMAIL PROTECTED]: and add the capability to explode a layer by attribute value. Useful!- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel Posta, news, sport, oroscopo: tutto in una sola pagina. Crea l#39;home page che piace a te! www.yahoo.it/latuapagina - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Combine and Explode Layers
Lary wrote: Explode Layer would include the existing Edit-Extract Layers by Geometry Type functionality, and add the capability to explode a layer by attribute value. That is, it would create a new layer for each unique value of a given attribute. This sounds pretty cool. You might want to pop up a warning if the user chooses an attribute that has a bunch of different values. I can see a user running the plug-in and inadvertently creating 3000 layers. :] You wrote: Combine Selected Layers would allow you to combine LineString, Point, and Polygon shapefile layers into a single layer to save as GML or other multi-geometry tolerant format. Attributes would, of course, be preserved. Preservation of BasicStyle information is also possible with a kind of auto-theming. How would you handle layers with different feature schemas? Can you explain more about how auto-theming would work? I'm just curious. Your idea sounds very useful. Landon On Wed, Jul 9, 2008 at 11:43 PM, Giuseppe Aruta [EMAIL PROTECTED] wrote: Very good Larry! --- Mer 9/7/08, Nacho Uve [EMAIL PROTECTED] ha scritto: Da: Nacho Uve [EMAIL PROTECTED] Oggetto: Re: [JPP-Devel] Combine and Explode Layers A: OpenJump develop and use jump-pilot-devel@lists.sourceforge.net Data: Mercoledì 9 luglio 2008, 23:55 2008/7/9 Larry Becker [EMAIL PROTECTED]: and add the capability to explode a layer by attribute value. Useful!- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel Posta, news, sport, oroscopo: tutto in una sola pagina. Crea l#39;home page che piace a te! www.yahoo.it/latuapagina - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Combine and Explode Layers
Hi SS, On Thu, Jul 10, 2008 at 9:39 AM, Sunburned Surveyor [EMAIL PROTECTED] wrote: Lary wrote: Explode Layer would include the existing Edit-Extract Layers by Geometry Type functionality, and add the capability to explode a layer by attribute value. That is, it would create a new layer for each unique value of a given attribute. This sounds pretty cool. You might want to pop up a warning if the user chooses an attribute that has a bunch of different values. I can see a user running the plug-in and inadvertently creating 3000 layers. :] Good point! You wrote: Combine Selected Layers would allow you to combine LineString, Point, and Polygon shapefile layers into a single layer to save as GML or other multi-geometry tolerant format. Attributes would, of course, be preserved. Preservation of BasicStyle information is also possible with a kind of auto-theming. How would you handle layers with different feature schemas? Merge the schemas with null values for missing attriubtes. Can you explain more about how auto-theming would work? Copy layer's BasicStyle as a custom colour theme. regards, Larry I'm just curious. Your idea sounds very useful. Landon On Wed, Jul 9, 2008 at 11:43 PM, Giuseppe Aruta [EMAIL PROTECTED] wrote: Very good Larry! --- Mer 9/7/08, Nacho Uve [EMAIL PROTECTED] ha scritto: Da: Nacho Uve [EMAIL PROTECTED] Oggetto: Re: [JPP-Devel] Combine and Explode Layers A: OpenJump develop and use jump-pilot-devel@lists.sourceforge.net Data: Mercoledì 9 luglio 2008, 23:55 2008/7/9 Larry Becker [EMAIL PROTECTED]: and add the capability to explode a layer by attribute value. Useful!- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel Posta, news, sport, oroscopo: tutto in una sola pagina. Crea l#39;home page che piace a te! www.yahoo.it/latuapagina - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- http://amusingprogrammer.blogspot.com/ - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Combine and Explode Layers
On Jul 10, 2008, at 2:43:16:PM, Larry Becker wrote:Hi SS,On Thu, Jul 10, 2008 at 9:39 AM, Sunburned Surveyor [EMAIL PROTECTED] wrote: Lary wrote: "Explode Layer would include the existing "Edit-Extract Layers by Geometry Type" functionality, and add the capability to explode a layer by attribute value. That is, it would create a new layer for each unique value of a given attribute." This sounds pretty cool. You might want to pop up a warning if the user chooses an attribute that has a bunch of different values. I can see a user running the plug-in and inadvertently creating 3000 layers. :] Good point! You wrote: "Combine Selected Layers would allow you to combine LineString, Point, and Polygon shapefile layers into a single layer to save as GML or other multi-geometry tolerant format. Attributes would, of course, be preserved. Preservation of BasicStyle information is also possible with a kind of auto-theming." How would you handle layers with different feature schemas? Merge the schemas with null values for missing attriubtes.better to allow user to keep old/keep new, keep both. Can you explain more about how auto-theming would work? Copy layer's BasicStyle as a custom colour theme.regards,Larry I'm just curious. Your idea sounds very useful. Landon On Wed, Jul 9, 2008 at 11:43 PM, Giuseppe Aruta [EMAIL PROTECTED] wrote: Very good Larry! --- Mer 9/7/08, Nacho Uve [EMAIL PROTECTED] ha scritto: Da: Nacho Uve [EMAIL PROTECTED] Oggetto: Re: [JPP-Devel] Combine and Explode Layers A: "OpenJump develop and use" jump-pilot-devel@lists.sourceforge.net Data: Mercoledì 9 luglio 2008, 23:55 2008/7/9 Larry Becker [EMAIL PROTECTED]:and add the capability to explode a layer by attribute value. Useful!- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel Posta, news, sport, oroscopo: tutto in una sola pagina. Crea l#39;home page che piace a te! www.yahoo.it/latuapagina- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- http://amusingprogrammer.blogspot.com/ -Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!Studies have shown that voting for your favorite open source project,along with a healthy diet, reduces your potential for chronic lamenessand boredom. Vote Now at http://www.sourceforge.net/community/cca08___Jump-pilot-devel mailing listJump-pilot-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/jump-pilot-devel Eric Jarvies - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] Report on First Code Review of JTin
I just completed my first code review of the JTin SoC project that Chris Demars has been working on. I wanted to include the mailing list on my comments to Chris, as I know there are more experienced programmers listening that can offer Chris there own suggestions on his design. I must say that Chris took an interesting approach to the design of JTin, and one that was a lot different from the approach I would have taken. However, I think Chris' design will be much quicker and more memory efficient. His professional programming background is evident in the work. I tend to get lazy when I program, creating objects for every little thing. JTin looks like it was written by a C programmer. All the data structures are concise and fairly low-level. Here are some of my questions and comments for Chris: - I like that the TinFace objects, braklines, and boundaries in ImmutableTin points to a common Coordinate array to eliminated duplicated Coordinate references. Did you think about using a CoordinateSequence instead of a Coordinate array? - Why did we choose STRtree and not QuadTree for the spatial index? I know very little about both classes, and STRtree may indeed be the better choice. Maybe Martin Davis will take a few minutes to educate me. - Is the int in the first element of the int[][] triTable argument for the ImmutableTin class constructor the identifier of the Tin Face, while the in in the second element is the ID of the vertex? - I'm not sure about storing the nieghbor TinFaces in the actual TinFace object. I almost wonder if having a separate class to manage TIN topology would be better. For example, how do you set references to a TinFace object's neighbors when creating the first TinFace in an ImmutableTin? I guess you could go back and set the neighbors for each TinFace after the TIN was constructed, but it looks like your only constructor for this class requires int arguments identifying the neighbors. You probably have good reason for this design, I just didn't pick up on it. - Let's get that JTF format documented in JTFLayout class into an external document, prefereably PDF or HTML. We can then introduce the rest of the FOSS GIS community to the format. This will encourage broad adoption of the format. Chris has done great work. I didn't go trough his code with a fine tooth comb, as there is quite a bit of material there, but I look forward to learning more about the library as I work with it. If others have a time to browse the JTin source I know that Chris and I would both appreciate it. Please feel free to respond to my questions and comments for Chris in this e-mail. Landon - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Report on First Code Review of JTin
STRtree is general at least twice as fast as Quadtree. Perhaps that's why it was chosen? Sunburned Surveyor wrote: I just completed my first code review of the JTin SoC project that Chris Demars has been working on. I wanted to include the mailing list on my comments to Chris, as I know there are more experienced programmers listening that can offer Chris there own suggestions on his design. I must say that Chris took an interesting approach to the design of JTin, and one that was a lot different from the approach I would have taken. However, I think Chris' design will be much quicker and more memory efficient. His professional programming background is evident in the work. I tend to get lazy when I program, creating objects for every little thing. JTin looks like it was written by a C programmer. All the data structures are concise and fairly low-level. Here are some of my questions and comments for Chris: - I like that the TinFace objects, braklines, and boundaries in ImmutableTin points to a common Coordinate array to eliminated duplicated Coordinate references. Did you think about using a CoordinateSequence instead of a Coordinate array? - Why did we choose STRtree and not QuadTree for the spatial index? I know very little about both classes, and STRtree may indeed be the better choice. Maybe Martin Davis will take a few minutes to educate me. - Is the int in the first element of the int[][] triTable argument for the ImmutableTin class constructor the identifier of the Tin Face, while the in in the second element is the ID of the vertex? - I'm not sure about storing the nieghbor TinFaces in the actual TinFace object. I almost wonder if having a separate class to manage TIN topology would be better. For example, how do you set references to a TinFace object's neighbors when creating the first TinFace in an ImmutableTin? I guess you could go back and set the neighbors for each TinFace after the TIN was constructed, but it looks like your only constructor for this class requires int arguments identifying the neighbors. You probably have good reason for this design, I just didn't pick up on it. - Let's get that JTF format documented in JTFLayout class into an external document, prefereably PDF or HTML. We can then introduce the rest of the FOSS GIS community to the format. This will encourage broad adoption of the format. Chris has done great work. I didn't go trough his code with a fine tooth comb, as there is quite a bit of material there, but I look forward to learning more about the library as I work with it. If others have a time to browse the JTin source I know that Chris and I would both appreciate it. Please feel free to respond to my questions and comments for Chris in this e-mail. Landon - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Martin Davis Senior Technical Architect Refractions Research, Inc. (250) 383-3022 - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Report on First Code Review of JTin
--- On Thu, 7/10/08, Martin Davis [EMAIL PROTECTED] wrote: STRtree is general at least twice as fast as Quadtree. Perhaps that's why it was chosen? Yep. The only downside to STRtree is that it is read only, and since I was designing the TIN class as immutable, it seemed the best fit. I'll respond more fully to SS's comments later on this evening or next morning when I have more time to compose a longer response. --Christopher - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] question on intersection of polygons and re-unioning of boundary elements
Hei, Today I started some work on analysing and later generalising (i.e. simplification) of polygon layers where the polygons form a mosaic (tesselation). So any operation on the boundaries requires that topologic neighbourhood must be observed. I.e. to simplify an outline I need to simplify the common boundary of two polygons. I have now written a polygon neighborhood graph and try now to extract the common boundary. Unfortunately the Jts intersection command results in linestrings that are rather line segments. So I need to paste them together again. Does anybody knows a function for that? I tested union, and it seems to create again a MultiLineStrings instead of a unified line. The only tool that comes to my mind so far is Larry's /ISA's blend lines. Any other suggestions? Stefan - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] question on intersection of polygons and re-unioning of boundary elements
Hi Stefan, How about com.vividsolutions.jts.operation.polygonize? That seems to be what it was intended to do. regards, Larry On Thu, Jul 10, 2008 at 7:21 PM, Stefan Steiniger [EMAIL PROTECTED] wrote: Hei, Today I started some work on analysing and later generalising (i.e. simplification) of polygon layers where the polygons form a mosaic (tesselation). So any operation on the boundaries requires that topologic neighbourhood must be observed. I.e. to simplify an outline I need to simplify the common boundary of two polygons. I have now written a polygon neighborhood graph and try now to extract the common boundary. Unfortunately the Jts intersection command results in linestrings that are rather line segments. So I need to paste them together again. Does anybody knows a function for that? I tested union, and it seems to create again a MultiLineStrings instead of a unified line. The only tool that comes to my mind so far is Larry's /ISA's blend lines. Any other suggestions? Stefan - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- http://amusingprogrammer.blogspot.com/ - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] question on intersection of polygons and re-unioning of boundary elements
Hei Larry, mhm.. maybe I could not really express what I want to do. I have already polygons - and want to derive the common boundary between two polygon as one Linestring. So I need to concatenate the pieces that intersection() does return. Or are you proposing to simply work with the (out-)lines instead of the complete polygon? Not sure if that would be an advantage, as I also need to clean up the data from double edges. Not sure... Stefan Larry Becker wrote: Hi Stefan, How about com.vividsolutions.jts.operation.polygonize? That seems to be what it was intended to do. regards, Larry On Thu, Jul 10, 2008 at 7:21 PM, Stefan Steiniger [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Hei, Today I started some work on analysing and later generalising (i.e. simplification) of polygon layers where the polygons form a mosaic (tesselation). So any operation on the boundaries requires that topologic neighbourhood must be observed. I.e. to simplify an outline I need to simplify the common boundary of two polygons. I have now written a polygon neighborhood graph and try now to extract the common boundary. Unfortunately the Jts intersection command results in linestrings that are rather line segments. So I need to paste them together again. Does anybody knows a function for that? I tested union, and it seems to create again a MultiLineStrings instead of a unified line. The only tool that comes to my mind so far is Larry's /ISA's blend lines. Any other suggestions? Stefan - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net mailto:Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- http://amusingprogrammer.blogspot.com/ - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.
Hei Landon, a few comments on your changes [personal thoughts] However, I think there is a reasonable solution: I'll keep all of my changes in my own fork. I'll regularly present these changes to the OpenJUMP programming community. I'll clearly identify those changes that I think are necessary to avoid bugs to to enable a critical new function in the program. this is good This type of change will be distinguished from changes which are cosmetic or very minor. Then we can let the changes be approved and adopted by the group on there own merit. (I'll try not to get my feelings hurt when something doesn't get in.) :] that is better :) Let's look at my TaskFrame/Workbench Context changes as an example: Critical Changes: Call CursorTool.cancelGesture method when closing a TaskFrame. I know you may have pointed out why you did that, but why would you do that? What happens then? The mouse pointer changes? Remove TaskFrame.setTask method and modify WorkbenchContext.addTaskFrame method to no longer use ComponentFactory. What was the reason for this change? to avoid the use of the component Factory? Here I would leave the factory as I would assume that there is a reason why they used that. To remove a method sounds dangerous to me (usually one starts with introducing a depricated label.. but as it is your personel edition) Cosmetic Changes: Group all public, protected, and private methods together in class file. this makes things messy in a repository in terms of tracing and comparing old and new code. so I would avoid that in general for released code. Implement InternalFrameListener instead of using hidden InternalFrameAdapter class. not sure about this. It sounds logic from my side. And as it is hidden it would not break any access method. So from my non-programmers perspective I would go with that change. Add isAClone member variable, setIsAClone public method. Adding something is ok. But you should outline why do you add this? Add Javadoc comments for all public methods. this is always! appreciated :) Would we be interested in any of the cosmetic changes? my 2 cents: in general no cosemtic changes on old code if it is not necessary to make things work or fix a bug. The only exception to is javadoc. We need this as there are (unfortunately) only a few wizards in our group (Paul, Martin, Andreas, ...). I want to point out that if we take a more assertive stance on unit testing JUMP cosmetic changes to the core would be less of a risk...Maybe I'll start working on some unit tasks for key classes in the core. if you want and can write tests then go ahead with this (However, for the stuff I programm, i.e. data analysis, I feel it is almost impossible to use unit tests... but I have also never programmed them) - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] R: disable/deactivate menu with plugin?
Hei, I moved all advanced plugin functionality to the default-plugins.xml file that originates from the OpenJUMP team. Basic functionality (such as file i/o, viewing and styling) is still loaded from the OpenJumpConfiguration file. Next step will be to move the original JUMP plugins. However, I recognized that this can become tricky, as menu positions, the initialization of sub-menus and also the introduction of separators may change. So it could be necessary to leave some stuff (from the Tools menu?) in JUMPConfiguration as well. Need to check that. Then.. the next step is to go through Peppes menu change-proposals (but I can't say when this time comes) I hope that is becomes now not too messy, having now two Init classes (JUMP+OpenJUMP) and two property files (default-plugin.xml, and for those who need, like me: workbench-properties.xml). The latter are loaded only using the appropriate command line options [that are set by default] ;) cheers, Stefan - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
