Re: [JPP-Devel] Selectionstyle Patch

[Larry Becker]

Hi Matthias,

  I had some problems applying the patch.  I was only able to get the
AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse wouldn't
create the new files for some reason.

  Looking at the changes to AbstractSelectionRenderer, I do have some
concerns about efficiency since I have recently made changes there to speed
things up.  I suggest that you move references to the blackboard outside of
AbstractSelectionRenderer, and add vertexStyle as a class variable settable
by a public set method.  You should probably have a default constructor for
VertexStyle that gives the legacy behavior.

You should be able to call repaint() from LayerViewPanel.

regards,
Larry Becker

On Fri, Jun 18, 2010 at 3:43 PM, Matthias Scholz  wrote:

> Hi,
>
> the attached patch are a first version of my selectionstyle enhancement.
> You can change the selectionstyle with a new tab in the optionsdialog. The
> stylings are stored in the persistent Blackboard -> workbench-state.xml.
>
> Please take a look at my code and tell me your opinion. It would be nice if
> you can integrate the code into the project.
>
> Can anybody tell me how i can do a "repaint" after the OK button was
> pressed(SelectionStyllingOptionsPanel.okPressed()). In the actual version
> you must move or zoom the map that you see the new styling setting. It would
> be better if you see the changes immediately.
>
> Matthias
>
>
>
> --
> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parental unit.  See the prize list and enter to win:
> http://p.sf.net/sfu/thinkgeek-promo
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] Selectionstyle Patch

[Larry Becker]

Hi Matthias,

My concern about code efficiency is that this is a very low level routine in
AbstractSelectionRenderer that is potentially called millions of times per
session.  Everything possible (like blackboard access and object creation)
needs to be moved outside of it.

Also, if the user does not select your new selection rendering option, OJ
should continue to render using the old method.  Currently, it defaults to a
new rendering method.

One of the limitations of OJ that I would like to overcome is that it runs
out of memory just selecting a million points.  The reason for that is the
large overhead of selection feedback graphics.  Now that you have created an
options panel for selection feedback it could be  possible to turn off
selection feedback completely!  This would be a solution for unusually large
datasets.

I hope you understand that since this modification is to the core classes,
it needs to meet higher standards than something an optional plugin.

regards,
Larry

On Sat, Jun 19, 2010 at 12:48 AM, Matthias Scholz  wrote:

> Hi Larry!
>
>  Hi Matthias,
>>
>>  I had some problems applying the patch.  I was only able to get the
>> AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse wouldn't
>> create the new files for some reason.
>>
> It seems that my Netbeans use an other diff format as Eclipse... i have
> attached a zip file.
>
>
>>  Looking at the changes to AbstractSelectionRenderer, I do have some
>> concerns about efficiency since I have recently made changes there to speed
>> things up.  I suggest that you move references to the blackboard outside of
>> AbstractSelectionRenderer, and add vertexStyle as a class variable settable
>> by a public set method.  You should
>>
> I'm sorry i do not understand what you mean exactly :-( Can you explain
> this a little bit more?
>
>  probably have a default constructor for VertexStyle that gives the legacy
>> behavior.
>>
> The com.vividsolutions.jump.workbench.ui.renderer.style.VertexStyle class
> doesn't have  a public default constructor, you must use the
> VertexStylesFactory for that.
>
>
>> You should be able to call repaint() from LayerViewPanel.
>>
> Thank you, it runs :-)
>
> Matthias
>
>>
>> regards,
>> Larry Becker
>>
>>
>> On Fri, Jun 18, 2010 at 3:43 PM, Matthias Scholz > m...@jammerhund.de>> wrote:
>>
>>Hi,
>>
>>the attached patch are a first version of my selectionstyle
>>enhancement. You can change the selectionstyle with a new tab in
>>the optionsdialog. The stylings are stored in the persistent
>>Blackboard -> workbench-state.xml.
>>
>>Please take a look at my code and tell me your opinion. It would
>>be nice if you can integrate the code into the project.
>>
>>Can anybody tell me how i can do a "repaint" after the OK button
>>was pressed(SelectionStyllingOptionsPanel.okPressed()). In the
>>actual version you must move or zoom the map that you see the new
>>styling setting. It would be better if you see the changes
>>immediately.
>>
>>Matthias
>>
>>
>>
>>  
>> --
>>ThinkGeek and WIRED's GeekDad team up for the Ultimate
>>GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
>>lucky parental unit.  See the prize list and enter to win:
>>http://p.sf.net/sfu/thinkgeek-promo
>>___
>>Jump-pilot-devel mailing list
>>Jump-pilot-devel@lists.sourceforge.net
>>
>>
>>https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>>
>> 
>>
>>
>>
>> --
>> ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's
>> Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit.  See the prize
>> list and enter to win: http://p.sf.net/sfu/thinkgeek-promo
>> 
>>
>> ___
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>>
>
>
>
> --
> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parental unit.  See the prize list and enter to win:
> http://p.sf.net/sfu/thinkgeek-promo
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See th

Re: [JPP-Devel] Selectionstyle Patch

[Sunburned Surveyor]

I haven't looked at the code Mathias provided. It sounds like Larry's
provided some great comments. I hope the changes can be made so
Mathias code can be integrated.

If Mathias needs help making the mods Larry has suggested, he can let me know.

The Sunburned Surveyor

On Mon, Jun 21, 2010 at 6:28 AM, Larry Becker  wrote:
> Hi Matthias,
>
> My concern about code efficiency is that this is a very low level routine in
> AbstractSelectionRenderer that is potentially called millions of times per
> session.  Everything possible (like blackboard access and object creation)
> needs to be moved outside of it.
>
> Also, if the user does not select your new selection rendering option, OJ
> should continue to render using the old method.  Currently, it defaults to a
> new rendering method.
>
> One of the limitations of OJ that I would like to overcome is that it runs
> out of memory just selecting a million points.  The reason for that is the
> large overhead of selection feedback graphics.  Now that you have created an
> options panel for selection feedback it could be  possible to turn off
> selection feedback completely!  This would be a solution for unusually large
> datasets.
>
> I hope you understand that since this modification is to the core classes,
> it needs to meet higher standards than something an optional plugin.
>
> regards,
> Larry
>
> On Sat, Jun 19, 2010 at 12:48 AM, Matthias Scholz  wrote:
>>
>> Hi Larry!
>>>
>>> Hi Matthias,
>>>
>>>  I had some problems applying the patch.  I was only able to get the
>>> AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse wouldn't
>>> create the new files for some reason.
>>
>> It seems that my Netbeans use an other diff format as Eclipse... i have
>> attached a zip file.
>>>
>>>  Looking at the changes to AbstractSelectionRenderer, I do have some
>>> concerns about efficiency since I have recently made changes there to speed
>>> things up.  I suggest that you move references to the blackboard outside of
>>> AbstractSelectionRenderer, and add vertexStyle as a class variable settable
>>> by a public set method.  You should
>>
>> I'm sorry i do not understand what you mean exactly :-( Can you explain
>> this a little bit more?
>>>
>>> probably have a default constructor for VertexStyle that gives the legacy
>>> behavior.
>>
>> The com.vividsolutions.jump.workbench.ui.renderer.style.VertexStyle class
>> doesn't have  a public default constructor, you must use the
>> VertexStylesFactory for that.
>>>
>>> You should be able to call repaint() from LayerViewPanel.
>>
>> Thank you, it runs :-)
>>
>> Matthias
>>>
>>> regards,
>>> Larry Becker
>>>
>>> On Fri, Jun 18, 2010 at 3:43 PM, Matthias Scholz >> > wrote:
>>>
>>>    Hi,
>>>
>>>    the attached patch are a first version of my selectionstyle
>>>    enhancement. You can change the selectionstyle with a new tab in
>>>    the optionsdialog. The stylings are stored in the persistent
>>>    Blackboard -> workbench-state.xml.
>>>
>>>    Please take a look at my code and tell me your opinion. It would
>>>    be nice if you can integrate the code into the project.
>>>
>>>    Can anybody tell me how i can do a "repaint" after the OK button
>>>    was pressed(SelectionStyllingOptionsPanel.okPressed()). In the
>>>    actual version you must move or zoom the map that you see the new
>>>    styling setting. It would be better if you see the changes
>>>    immediately.
>>>
>>>    Matthias
>>>
>>>
>>>
>>>  --
>>>    ThinkGeek and WIRED's GeekDad team up for the Ultimate
>>>    GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
>>>    lucky parental unit.  See the prize list and enter to win:
>>>    http://p.sf.net/sfu/thinkgeek-promo
>>>    ___
>>>    Jump-pilot-devel mailing list
>>>    jump-pilot-de...@lists.sourceforge.net
>>>    
>>>    https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>
>>>
>>> 
>>>
>>>
>>> --
>>> ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's
>>> Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit.  See the prize
>>> list and enter to win: http://p.sf.net/sfu/thinkgeek-promo
>>> 
>>>
>>> ___
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>
>>
>>
>>
>> --
>> ThinkGeek and WIRED's GeekDad team up for the Ultimate
>> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
>> lucky parental unit.  See the prize list and enter to win:

Re: [JPP-Devel] Selectionstyle Patch

[Matthias Scholz]

Hi Sunburned Surveyor and Larry,

sorry for my late reply, but i had no time to code last week :-(

I agree with Larry's remarks. My question went toward the concrete 
implementation, as I currently do not have enough knowledge about the 
internals of OJ. At the beginning I would to build a plugin, but I do 
not know how to "tell" the AbstractSelectionRenderer, how he should 
render with my settings or with the old default one. So actually I have 
no idea how to integrate the plugin in the rendering process? At this 
point I need your help. I hope you understand my terrible english ;-)

Matthias

> I haven't looked at the code Mathias provided. It sounds like Larry's
> provided some great comments. I hope the changes can be made so
> Mathias code can be integrated.
>
> If Mathias needs help making the mods Larry has suggested, he can let me know.
>
> The Sunburned Surveyor
>
> On Mon, Jun 21, 2010 at 6:28 AM, Larry Becker  wrote:
>   
>> Hi Matthias,
>>
>> My concern about code efficiency is that this is a very low level routine in
>> AbstractSelectionRenderer that is potentially called millions of times per
>> session.  Everything possible (like blackboard access and object creation)
>> needs to be moved outside of it.
>>
>> Also, if the user does not select your new selection rendering option, OJ
>> should continue to render using the old method.  Currently, it defaults to a
>> new rendering method.
>>
>> One of the limitations of OJ that I would like to overcome is that it runs
>> out of memory just selecting a million points.  The reason for that is the
>> large overhead of selection feedback graphics.  Now that you have created an
>> options panel for selection feedback it could be  possible to turn off
>> selection feedback completely!  This would be a solution for unusually large
>> datasets.
>>
>> I hope you understand that since this modification is to the core classes,
>> it needs to meet higher standards than something an optional plugin.
>>
>> regards,
>> Larry
>>
>> On Sat, Jun 19, 2010 at 12:48 AM, Matthias Scholz  wrote:
>> 
>>> Hi Larry!
>>>   
 Hi Matthias,

  I had some problems applying the patch.  I was only able to get the
 AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse wouldn't
 create the new files for some reason.
 
>>> It seems that my Netbeans use an other diff format as Eclipse... i have
>>> attached a zip file.
>>>   
  Looking at the changes to AbstractSelectionRenderer, I do have some
 concerns about efficiency since I have recently made changes there to speed
 things up.  I suggest that you move references to the blackboard outside of
 AbstractSelectionRenderer, and add vertexStyle as a class variable settable
 by a public set method.  You should
 
>>> I'm sorry i do not understand what you mean exactly :-( Can you explain
>>> this a little bit more?
>>>   
 probably have a default constructor for VertexStyle that gives the legacy
 behavior.
 
>>> The com.vividsolutions.jump.workbench.ui.renderer.style.VertexStyle class
>>> doesn't have  a public default constructor, you must use the
>>> VertexStylesFactory for that.
>>>   
 You should be able to call repaint() from LayerViewPanel.
 
>>> Thank you, it runs :-)
>>>
>>> Matthias
>>>   
 regards,
 Larry Becker

 On Fri, Jun 18, 2010 at 3:43 PM, Matthias Scholz >>> > wrote:

Hi,

the attached patch are a first version of my selectionstyle
enhancement. You can change the selectionstyle with a new tab in
the optionsdialog. The stylings are stored in the persistent
Blackboard -> workbench-state.xml.

Please take a look at my code and tell me your opinion. It would
be nice if you can integrate the code into the project.

Can anybody tell me how i can do a "repaint" after the OK button
was pressed(SelectionStyllingOptionsPanel.okPressed()). In the
actual version you must move or zoom the map that you see the new
styling setting. It would be better if you see the changes
immediately.

Matthias



  
 --
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit.  See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


 


 --

Re: [JPP-Devel] Selectionstyle Patch

[Larry Becker]

I don't see an obvious solution.  For one thing, it is unclear how your
plugin would affect the interoperability of SelectionBackgroundRenderer,
PartSelectionRenderer, and LineStringSelectionRenderer which uses
constructors to select different feedback mechanisms.

Larry

On Sun, Jun 27, 2010 at 3:00 PM, Matthias Scholz  wrote:

> Hi Sunburned Surveyor and Larry,
>
> sorry for my late reply, but i had no time to code last week :-(
>
> I agree with Larry's remarks. My question went toward the concrete
> implementation, as I currently do not have enough knowledge about the
> internals of OJ. At the beginning I would to build a plugin, but I do
> not know how to "tell" the AbstractSelectionRenderer, how he should
> render with my settings or with the old default one. So actually I have
> no idea how to integrate the plugin in the rendering process? At this
> point I need your help. I hope you understand my terrible english ;-)
>
> Matthias
>
> > I haven't looked at the code Mathias provided. It sounds like Larry's
> > provided some great comments. I hope the changes can be made so
> > Mathias code can be integrated.
> >
> > If Mathias needs help making the mods Larry has suggested, he can let me
> know.
> >
> > The Sunburned Surveyor
> >
> > On Mon, Jun 21, 2010 at 6:28 AM, Larry Becker 
> wrote:
> >
> >> Hi Matthias,
> >>
> >> My concern about code efficiency is that this is a very low level
> routine in
> >> AbstractSelectionRenderer that is potentially called millions of times
> per
> >> session.  Everything possible (like blackboard access and object
> creation)
> >> needs to be moved outside of it.
> >>
> >> Also, if the user does not select your new selection rendering option,
> OJ
> >> should continue to render using the old method.  Currently, it defaults
> to a
> >> new rendering method.
> >>
> >> One of the limitations of OJ that I would like to overcome is that it
> runs
> >> out of memory just selecting a million points.  The reason for that is
> the
> >> large overhead of selection feedback graphics.  Now that you have
> created an
> >> options panel for selection feedback it could be  possible to turn off
> >> selection feedback completely!  This would be a solution for unusually
> large
> >> datasets.
> >>
> >> I hope you understand that since this modification is to the core
> classes,
> >> it needs to meet higher standards than something an optional plugin.
> >>
> >> regards,
> >> Larry
> >>
> >> On Sat, Jun 19, 2010 at 12:48 AM, Matthias Scholz 
> wrote:
> >>
> >>> Hi Larry!
> >>>
>  Hi Matthias,
> 
>   I had some problems applying the patch.  I was only able to get the
>  AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse wouldn't
>  create the new files for some reason.
> 
> >>> It seems that my Netbeans use an other diff format as Eclipse... i have
> >>> attached a zip file.
> >>>
>   Looking at the changes to AbstractSelectionRenderer, I do have some
>  concerns about efficiency since I have recently made changes there to
> speed
>  things up.  I suggest that you move references to the blackboard
> outside of
>  AbstractSelectionRenderer, and add vertexStyle as a class variable
> settable
>  by a public set method.  You should
> 
> >>> I'm sorry i do not understand what you mean exactly :-( Can you explain
> >>> this a little bit more?
> >>>
>  probably have a default constructor for VertexStyle that gives the
> legacy
>  behavior.
> 
> >>> The com.vividsolutions.jump.workbench.ui.renderer.style.VertexStyle
> class
> >>> doesn't have  a public default constructor, you must use the
> >>> VertexStylesFactory for that.
> >>>
>  You should be able to call repaint() from LayerViewPanel.
> 
> >>> Thank you, it runs :-)
> >>>
> >>> Matthias
> >>>
>  regards,
>  Larry Becker
> 
>  On Fri, Jun 18, 2010 at 3:43 PM, Matthias Scholz   > wrote:
> 
> Hi,
> 
> the attached patch are a first version of my selectionstyle
> enhancement. You can change the selectionstyle with a new tab in
> the optionsdialog. The stylings are stored in the persistent
> Blackboard -> workbench-state.xml.
> 
> Please take a look at my code and tell me your opinion. It would
> be nice if you can integrate the code into the project.
> 
> Can anybody tell me how i can do a "repaint" after the OK button
> was pressed(SelectionStyllingOptionsPanel.okPressed()). In the
> actual version you must move or zoom the map that you see the new
> styling setting. It would be better if you see the changes
> immediately.
> 
> Matthias
> 
> 
> 
> 
>  
> --
> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parent

Re: [JPP-Devel] Selectionstyle Patch

[Stefan Steiniger]

mhm.. as a side note.
the SRID Plugin[1] adds some listeners.. maybe that a way for a plugin?

stefan

[1] EnsureAllLayersHaveSRIDStylePlugIn.java

Larry Becker schrieb:
> I don't see an obvious solution.  For one thing, it is unclear how your 
> plugin would affect the interoperability of SelectionBackgroundRenderer, 
> PartSelectionRenderer, and LineStringSelectionRenderer which uses 
> constructors to select different feedback mechanisms.
> 
> Larry
> 
> On Sun, Jun 27, 2010 at 3:00 PM, Matthias Scholz  > wrote:
> 
> Hi Sunburned Surveyor and Larry,
> 
> sorry for my late reply, but i had no time to code last week :-(
> 
> I agree with Larry's remarks. My question went toward the concrete
> implementation, as I currently do not have enough knowledge about the
> internals of OJ. At the beginning I would to build a plugin, but I do
> not know how to "tell" the AbstractSelectionRenderer, how he should
> render with my settings or with the old default one. So actually I have
> no idea how to integrate the plugin in the rendering process? At this
> point I need your help. I hope you understand my terrible english ;-)
> 
> Matthias
> 
>  > I haven't looked at the code Mathias provided. It sounds like Larry's
>  > provided some great comments. I hope the changes can be made so
>  > Mathias code can be integrated.
>  >
>  > If Mathias needs help making the mods Larry has suggested, he can
> let me know.
>  >
>  > The Sunburned Surveyor
>  >
>  > On Mon, Jun 21, 2010 at 6:28 AM, Larry Becker
> mailto:becker.la...@gmail.com>> wrote:
>  >
>  >> Hi Matthias,
>  >>
>  >> My concern about code efficiency is that this is a very low
> level routine in
>  >> AbstractSelectionRenderer that is potentially called millions of
> times per
>  >> session.  Everything possible (like blackboard access and object
> creation)
>  >> needs to be moved outside of it.
>  >>
>  >> Also, if the user does not select your new selection rendering
> option, OJ
>  >> should continue to render using the old method.  Currently, it
> defaults to a
>  >> new rendering method.
>  >>
>  >> One of the limitations of OJ that I would like to overcome is
> that it runs
>  >> out of memory just selecting a million points.  The reason for
> that is the
>  >> large overhead of selection feedback graphics.  Now that you
> have created an
>  >> options panel for selection feedback it could be  possible to
> turn off
>  >> selection feedback completely!  This would be a solution for
> unusually large
>  >> datasets.
>  >>
>  >> I hope you understand that since this modification is to the
> core classes,
>  >> it needs to meet higher standards than something an optional plugin.
>  >>
>  >> regards,
>  >> Larry
>  >>
>  >> On Sat, Jun 19, 2010 at 12:48 AM, Matthias Scholz
> mailto:m...@jammerhund.de>> wrote:
>  >>
>  >>> Hi Larry!
>  >>>
>   Hi Matthias,
>  
>    I had some problems applying the patch.  I was only able to
> get the
>   AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse
> wouldn't
>   create the new files for some reason.
>  
>  >>> It seems that my Netbeans use an other diff format as
> Eclipse... i have
>  >>> attached a zip file.
>  >>>
>    Looking at the changes to AbstractSelectionRenderer, I do
> have some
>   concerns about efficiency since I have recently made changes
> there to speed
>   things up.  I suggest that you move references to the
> blackboard outside of
>   AbstractSelectionRenderer, and add vertexStyle as a class
> variable settable
>   by a public set method.  You should
>  
>  >>> I'm sorry i do not understand what you mean exactly :-( Can you
> explain
>  >>> this a little bit more?
>  >>>
>   probably have a default constructor for VertexStyle that gives
> the legacy
>   behavior.
>  
>  >>> The
> com.vividsolutions.jump.workbench.ui.renderer.style.VertexStyle class
>  >>> doesn't have  a public default constructor, you must use the
>  >>> VertexStylesFactory for that.
>  >>>
>   You should be able to call repaint() from LayerViewPanel.
>  
>  >>> Thank you, it runs :-)
>  >>>
>  >>> Matthias
>  >>>
>   regards,
>   Larry Becker
>  
>   On Fri, Jun 18, 2010 at 3:43 PM, Matthias Scholz
> mailto:m...@jammerhund.de>
>   >> wrote:
>  
>  Hi,
>  
>  the attached patch are a first version of my selectionstyle
>  enhancement. You can change the selectionstyle with a new

Re: [JPP-Devel] Selectionstyle Patch

[Matthias Scholz]

Hi Larry,

can we do the following?

- add some setSelectionLineColor, setSelectionPointSize and 
setSelectionPointForm to 
com.vividsolutions.jump.workbench.ui.renderer.Renderer interface
- implement simple setter in 
com.vividsolutions.jump.workbench.ui.renderer.FeatureCollectionRenderer, 
wich is the parent of AbstractSelectionRenderer which is the parent of 
FeatureSelectionRenderer, SelectionBackgroundRenderer, 
PartSelectionRenderer, LineStringSelectionRenderer
- change the AbstractSelectionRenderer for using this variables while 
paint()
- in a PlugIn in the OptionsPanel I can get the Renderer with 
context.getLayerViewPanel().getRenderingManager().getRenderer() call and 
the I can change the values whith the setter

I'm not sure if the Renderer interface is the right place for the setter 
methods???

Please tell me your opinion, before I start. Any other suggestions are 
welcome!

Regards Matthias

> I don't see an obvious solution.  For one thing, it is unclear how 
> your plugin would affect the interoperability of 
> SelectionBackgroundRenderer, PartSelectionRenderer, and 
> LineStringSelectionRenderer which uses constructors to select 
> different feedback mechanisms.
>
> Larry
>
> On Sun, Jun 27, 2010 at 3:00 PM, Matthias Scholz  > wrote:
>
> Hi Sunburned Surveyor and Larry,
>
> sorry for my late reply, but i had no time to code last week :-(
>
> I agree with Larry's remarks. My question went toward the concrete
> implementation, as I currently do not have enough knowledge about the
> internals of OJ. At the beginning I would to build a plugin, but I do
> not know how to "tell" the AbstractSelectionRenderer, how he should
> render with my settings or with the old default one. So actually I
> have
> no idea how to integrate the plugin in the rendering process? At this
> point I need your help. I hope you understand my terrible english ;-)
>
> Matthias
>
> > I haven't looked at the code Mathias provided. It sounds like
> Larry's
> > provided some great comments. I hope the changes can be made so
> > Mathias code can be integrated.
> >
> > If Mathias needs help making the mods Larry has suggested, he
> can let me know.
> >
> > The Sunburned Surveyor
> >
> > On Mon, Jun 21, 2010 at 6:28 AM, Larry Becker
> mailto:becker.la...@gmail.com>> wrote:
> >
> >> Hi Matthias,
> >>
> >> My concern about code efficiency is that this is a very low
> level routine in
> >> AbstractSelectionRenderer that is potentially called millions
> of times per
> >> session.  Everything possible (like blackboard access and
> object creation)
> >> needs to be moved outside of it.
> >>
> >> Also, if the user does not select your new selection rendering
> option, OJ
> >> should continue to render using the old method.  Currently, it
> defaults to a
> >> new rendering method.
> >>
> >> One of the limitations of OJ that I would like to overcome is
> that it runs
> >> out of memory just selecting a million points.  The reason for
> that is the
> >> large overhead of selection feedback graphics.  Now that you
> have created an
> >> options panel for selection feedback it could be  possible to
> turn off
> >> selection feedback completely!  This would be a solution for
> unusually large
> >> datasets.
> >>
> >> I hope you understand that since this modification is to the
> core classes,
> >> it needs to meet higher standards than something an optional
> plugin.
> >>
> >> regards,
> >> Larry
> >>
> >> On Sat, Jun 19, 2010 at 12:48 AM, Matthias Scholz
> mailto:m...@jammerhund.de>> wrote:
> >>
> >>> Hi Larry!
> >>>
>  Hi Matthias,
> 
>   I had some problems applying the patch.  I was only able to
> get the
>  AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse
> wouldn't
>  create the new files for some reason.
> 
> >>> It seems that my Netbeans use an other diff format as
> Eclipse... i have
> >>> attached a zip file.
> >>>
>   Looking at the changes to AbstractSelectionRenderer, I do
> have some
>  concerns about efficiency since I have recently made changes
> there to speed
>  things up.  I suggest that you move references to the
> blackboard outside of
>  AbstractSelectionRenderer, and add vertexStyle as a class
> variable settable
>  by a public set method.  You should
> 
> >>> I'm sorry i do not understand what you mean exactly :-( Can
> you explain
> >>> this a little bit more?
> >>>
>  probably have a default constructor for VertexStyle that
> gives the legacy
>  behavior.
> 
> >>> The
> com.vividsolutions.jump.workbench.ui.renderer.style.VertexStyle cl

Re: [JPP-Devel] Selectionstyle Patch

[Larry Becker]

Hi Matthias,

  I'm pretty sure that the right place to add setSelectionLineColor,
setSelectionPointSize and
setSelectionPointForm is AbstractSelectionRenderer since that is where the
associated variables are declared.  You will have to remove *final *from
HANDLE_WIDTH.  The real trick is getting the reference to
FeatureSelectionRenderer to use the sets.  I think this can be done with
RenderManager  by passing FeatureSelectionRenderer.CONTENT_ID.to
RenderManager.getRenderer().

regards,
Larry

On Sun, Jul 11, 2010 at 7:58 AM, Matthias Scholz  wrote:

> Hi Larry,
>
> can we do the following?
>
> - add some setSelectionLineColor, setSelectionPointSize and
> setSelectionPointForm to
> com.vividsolutions.jump.workbench.ui.renderer.Renderer interface
> - implement simple setter in
> com.vividsolutions.jump.workbench.ui.renderer.FeatureCollectionRenderer,
> wich is the parent of AbstractSelectionRenderer which is the parent of
> FeatureSelectionRenderer, SelectionBackgroundRenderer,
> PartSelectionRenderer, LineStringSelectionRenderer
> - change the AbstractSelectionRenderer for using this variables while
> paint()
> - in a PlugIn in the OptionsPanel I can get the Renderer with
> context.getLayerViewPanel().getRenderingManager().getRenderer() call and
> the I can change the values whith the setter
>
> I'm not sure if the Renderer interface is the right place for the setter
> methods???
>
> Please tell me your opinion, before I start. Any other suggestions are
> welcome!
>
> Regards Matthias
>
> > I don't see an obvious solution.  For one thing, it is unclear how
> > your plugin would affect the interoperability of
> > SelectionBackgroundRenderer, PartSelectionRenderer, and
> > LineStringSelectionRenderer which uses constructors to select
> > different feedback mechanisms.
> >
> > Larry
> >
> > On Sun, Jun 27, 2010 at 3:00 PM, Matthias Scholz  > > wrote:
> >
> > Hi Sunburned Surveyor and Larry,
> >
> > sorry for my late reply, but i had no time to code last week :-(
> >
> > I agree with Larry's remarks. My question went toward the concrete
> > implementation, as I currently do not have enough knowledge about the
> > internals of OJ. At the beginning I would to build a plugin, but I do
> > not know how to "tell" the AbstractSelectionRenderer, how he should
> > render with my settings or with the old default one. So actually I
> > have
> > no idea how to integrate the plugin in the rendering process? At this
> > point I need your help. I hope you understand my terrible english ;-)
> >
> > Matthias
> >
> > > I haven't looked at the code Mathias provided. It sounds like
> > Larry's
> > > provided some great comments. I hope the changes can be made so
> > > Mathias code can be integrated.
> > >
> > > If Mathias needs help making the mods Larry has suggested, he
> > can let me know.
> > >
> > > The Sunburned Surveyor
> > >
> > > On Mon, Jun 21, 2010 at 6:28 AM, Larry Becker
> > mailto:becker.la...@gmail.com>> wrote:
> > >
> > >> Hi Matthias,
> > >>
> > >> My concern about code efficiency is that this is a very low
> > level routine in
> > >> AbstractSelectionRenderer that is potentially called millions
> > of times per
> > >> session.  Everything possible (like blackboard access and
> > object creation)
> > >> needs to be moved outside of it.
> > >>
> > >> Also, if the user does not select your new selection rendering
> > option, OJ
> > >> should continue to render using the old method.  Currently, it
> > defaults to a
> > >> new rendering method.
> > >>
> > >> One of the limitations of OJ that I would like to overcome is
> > that it runs
> > >> out of memory just selecting a million points.  The reason for
> > that is the
> > >> large overhead of selection feedback graphics.  Now that you
> > have created an
> > >> options panel for selection feedback it could be  possible to
> > turn off
> > >> selection feedback completely!  This would be a solution for
> > unusually large
> > >> datasets.
> > >>
> > >> I hope you understand that since this modification is to the
> > core classes,
> > >> it needs to meet higher standards than something an optional
> > plugin.
> > >>
> > >> regards,
> > >> Larry
> > >>
> > >> On Sat, Jun 19, 2010 at 12:48 AM, Matthias Scholz
> > mailto:m...@jammerhund.de>> wrote:
> > >>
> > >>> Hi Larry!
> > >>>
> >  Hi Matthias,
> > 
> >   I had some problems applying the patch.  I was only able to
> > get the
> >  AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse
> > wouldn't
> >  create the new files for some reason.
> > 
> > >>> It seems that my Netbeans use an other diff format as
> > Eclipse... i have
> > >>> attached a zip file.
> > 

Re: [JPP-Devel] Selectionstyle Patch

[Larry Becker]

Hi Matthias,

  Sorry I've been unable to get back to you.  I have been on travel, both
vacation and business, but I should be able to get back to my normal
schedule sometime next week.

regards,
Larry

On Fri, Jul 30, 2010 at 11:34 AM, Matthias Scholz  wrote:

> Hi,
>
> please can Larry  or any other check my modifications again? Now I've
> solved the problem that the previous saved settings are restored from
> blackboard. The modifications in the AbstractSelectionRenderer should now
> smart enough, so that we have no performance problems and can set the
> properties with setter methods.
>
> It would be nice and important for my users if we can integrate the patch
> in the upcoming release.
>
> Regards
>
> Matthias
>
>  Hi Larry,
>>
>> please see the attached file. There is one problem at the moment. After
>> loading a file or project the AbstractSelectionRenderer use the default
>> settings. So you must go to the options an click OK in the
>> SelectionStyllingOptionsPanel. This is because during construction of the
>> SelectionStyllingOptionsPanel instance there is no LayerViewPanel instance
>> an so on no RenderingManager available. Is there a Listener which is fired
>> if the RenderingManager is available or if a layer was added or a file was
>> loaded???
>>
>> Regards
>>
>> Matthias
>>
>>  Hi Matthias,
>>>
>>>  I'm pretty sure that the right place to add setSelectionLineColor,
>>> setSelectionPointSize and
>>> setSelectionPointForm is AbstractSelectionRenderer since that is where
>>> the associated variables are declared.  You will have to remove /final /from
>>> HANDLE_WIDTH.  The real trick is getting the reference to
>>> FeatureSelectionRenderer to use the sets.  I think this can be done with
>>> RenderManager  by passing 
>>> FeatureSelectionRenderer.CONTENT_ID.toRenderManager.getRenderer().
>>>
>>> regards,
>>> Larry
>>>
>>> On Sun, Jul 11, 2010 at 7:58 AM, Matthias Scholz >> m...@jammerhund.de>> wrote:
>>>
>>>Hi Larry,
>>>
>>>can we do the following?
>>>
>>>- add some setSelectionLineColor, setSelectionPointSize and
>>>setSelectionPointForm to
>>>com.vividsolutions.jump.workbench.ui.renderer.Renderer interface
>>>- implement simple setter in
>>>
>>>  com.vividsolutions.jump.workbench.ui.renderer.FeatureCollectionRenderer,
>>>wich is the parent of AbstractSelectionRenderer which is the parent of
>>>FeatureSelectionRenderer, SelectionBackgroundRenderer,
>>>PartSelectionRenderer, LineStringSelectionRenderer
>>>- change the AbstractSelectionRenderer for using this variables while
>>>paint()
>>>- in a PlugIn in the OptionsPanel I can get the Renderer with
>>>context.getLayerViewPanel().getRenderingManager().getRenderer()
>>>call and
>>>the I can change the values whith the setter
>>>
>>>I'm not sure if the Renderer interface is the right place for the
>>>setter
>>>methods???
>>>
>>>Please tell me your opinion, before I start. Any other suggestions are
>>>welcome!
>>>
>>>Regards Matthias
>>>
>>>> I don't see an obvious solution.  For one thing, it is unclear how
>>>> your plugin would affect the interoperability of
>>>> SelectionBackgroundRenderer, PartSelectionRenderer, and
>>>> LineStringSelectionRenderer which uses constructors to select
>>>> different feedback mechanisms.
>>>>
>>>> Larry
>>>>
>>>> On Sun, Jun 27, 2010 at 3:00 PM, Matthias Scholz
>>>mailto:m...@jammerhund.de>
>>>> >> wrote:
>>>>
>>>> Hi Sunburned Surveyor and Larry,
>>>>
>>>> sorry for my late reply, but i had no time to code last week :-(
>>>>
>>>> I agree with Larry's remarks. My question went toward the
>>>concrete
>>>> implementation, as I currently do not have enough knowledge
>>>about the
>>>> internals of OJ. At the beginning I would to build a plugin,
>>>but I do
>>>> not know how to "tell" the AbstractSelectionRenderer, how he
>>>should
>>>> render with my settings or with the old default one. So
>>>actually I
>>>> have
>>>> no idea how to integrate the plugin in the rendering
>>>process? At this
>>>> point I need your help. I hope you understand my terrible
>>>english ;-)
>>>>
>>>> Matthias
>>>>
>>>> > I haven't looked at the code Mathias provided. It sounds like
>>>> Larry's
>>>> > provided some great comments. I hope the changes can be
>>>made so
>>>> > Mathias code can be integrated.
>>>> >
>>>> > If Mathias needs help making the mods Larry has suggested, he
>>>> can let me know.
>>>> >
>>>> > The Sunburned Surveyor
>>>> >
>>>> > On Mon, Jun 21, 2010 at 6:28 AM, Larry Becker
>>>> mailto:becker.la...@gmail.com>
>>>>>
>>>wrote:
>>>> >

Re: [JPP-Devel] Selectionstyle Patch

[Larry Becker]

Hi Matthias,

  The code does indeed look much more efficient, however it still doesn't
default to the old selection behavior, so I'm not sure how users outside
your organization are going to react to the change. I don't like it as well
as the current method which outlines the handles.   Also there seems to be a
problem with point selection feedback.  Selected points just seem to
disappear for me.

regards,
Larry

On Fri, Jul 30, 2010 at 11:34 AM, Matthias Scholz  wrote:

> Hi,
>
> please can Larry  or any other check my modifications again? Now I've
> solved the problem that the previous saved settings are restored from
> blackboard. The modifications in the AbstractSelectionRenderer should now
> smart enough, so that we have no performance problems and can set the
> properties with setter methods.
>
> It would be nice and important for my users if we can integrate the patch
> in the upcoming release.
>
> Regards
>
> Matthias
>
>  Hi Larry,
>>
>> please see the attached file. There is one problem at the moment. After
>> loading a file or project the AbstractSelectionRenderer use the default
>> settings. So you must go to the options an click OK in the
>> SelectionStyllingOptionsPanel. This is because during construction of the
>> SelectionStyllingOptionsPanel instance there is no LayerViewPanel instance
>> an so on no RenderingManager available. Is there a Listener which is fired
>> if the RenderingManager is available or if a layer was added or a file was
>> loaded???
>>
>> Regards
>>
>> Matthias
>>
>>  Hi Matthias,
>>>
>>>  I'm pretty sure that the right place to add setSelectionLineColor,
>>> setSelectionPointSize and
>>> setSelectionPointForm is AbstractSelectionRenderer since that is where
>>> the associated variables are declared.  You will have to remove /final /from
>>> HANDLE_WIDTH.  The real trick is getting the reference to
>>> FeatureSelectionRenderer to use the sets.  I think this can be done with
>>> RenderManager  by passing 
>>> FeatureSelectionRenderer.CONTENT_ID.toRenderManager.getRenderer().
>>>
>>> regards,
>>> Larry
>>>
>>> On Sun, Jul 11, 2010 at 7:58 AM, Matthias Scholz >> m...@jammerhund.de>> wrote:
>>>
>>>Hi Larry,
>>>
>>>can we do the following?
>>>
>>>- add some setSelectionLineColor, setSelectionPointSize and
>>>setSelectionPointForm to
>>>com.vividsolutions.jump.workbench.ui.renderer.Renderer interface
>>>- implement simple setter in
>>>
>>>  com.vividsolutions.jump.workbench.ui.renderer.FeatureCollectionRenderer,
>>>wich is the parent of AbstractSelectionRenderer which is the parent of
>>>FeatureSelectionRenderer, SelectionBackgroundRenderer,
>>>PartSelectionRenderer, LineStringSelectionRenderer
>>>- change the AbstractSelectionRenderer for using this variables while
>>>paint()
>>>- in a PlugIn in the OptionsPanel I can get the Renderer with
>>>context.getLayerViewPanel().getRenderingManager().getRenderer()
>>>call and
>>>the I can change the values whith the setter
>>>
>>>I'm not sure if the Renderer interface is the right place for the
>>>setter
>>>methods???
>>>
>>>Please tell me your opinion, before I start. Any other suggestions are
>>>welcome!
>>>
>>>Regards Matthias
>>>
>>>> I don't see an obvious solution.  For one thing, it is unclear how
>>>> your plugin would affect the interoperability of
>>>> SelectionBackgroundRenderer, PartSelectionRenderer, and
>>>> LineStringSelectionRenderer which uses constructors to select
>>>> different feedback mechanisms.
>>>>
>>>> Larry
>>>>
>>>> On Sun, Jun 27, 2010 at 3:00 PM, Matthias Scholz
>>>mailto:m...@jammerhund.de>
>>>> >> wrote:
>>>>
>>>> Hi Sunburned Surveyor and Larry,
>>>>
>>>> sorry for my late reply, but i had no time to code last week :-(
>>>>
>>>> I agree with Larry's remarks. My question went toward the
>>>concrete
>>>> implementation, as I currently do not have enough knowledge
>>>about the
>>>> internals of OJ. At the beginning I would to build a plugin,
>>>but I do
>>>> not know how to "tell" the AbstractSelectionRenderer, how he
>>>should
>>>> render with my settings or with the old default one. So
>>>actually I
>>>> have
>>>> no idea how to integrate the plugin in the rendering
>>>process? At this
>>>> point I need your help. I hope you understand my terrible
>>>english ;-)
>>>>
>>>> Matthias
>>>>
>>>> > I haven't looked at the code Mathias provided. It sounds like
>>>> Larry's
>>>> > provided some great comments. I hope the changes can be
>>>made so
>>>> > Mathias code can be integrated.
>>>> >
>>>> > If Mathias needs help making the mods Larry has suggested, he
>>>> can let me know.
>>>> >
>>>> > The Sunburned Surveyor
>>>  

Re: [JPP-Devel] Selectionstyle Patch

[Matthias Scholz]

Hi Larry,

i know the difference of handle outline drawing. This seems to be a
problem in the VertexStyle classes. You get the same mistake if you
switch on the vertices in the layer styling dialog. I can try to find
the problem in the VertexStyle classes.
What do you mean with the button in the options dialog? Should the
button reset/delete the blackboard values for selection styling to the
old defaults?

Regards

Matthias
> Hi Matthias,
>
>   Thanks for your patience.  You are almost there.  After I deleted my
> workbench-state.xml file, your latest code very nearly duplicated the
> old selection method's look and feel.  See the attached jpegs for the
> difference, which seems to be in the details of handle outline drawing. 
>
>   I did benchmarks which verified that selection of 35 points
> completes in approximately the same amount of time and memory as before.
>
>   It would be nice if you could add a button to the option dialog to
> restore the legacy settings so that users who try other settings and
> want to go back, can do so easily.
>
> regards,
>
> Larry
>
> On Tue, Aug 10, 2010 at 2:27 PM, Matthias Scholz  > wrote:
>
> Hi Larry,
>
> the patch use the old default setting for selectionrendering. If
> you nothing change in the optionspanel, you get the old behavior.
> The point selection problem is fixed. The problem was the alpha
> channel setting of the VertexStyle.
>
>
> Regards
>
> Matthias
>
> Hi Matthias,
>
>  The code does indeed look much more efficient, however it
> still doesn't default to the old selection behavior, so I'm
> not sure how users outside your organization are going to
> react to the change. I don't like it as well as the current
> method which outlines the handles.   Also there seems to be a
> problem with point selection feedback.  Selected points just
> seem to disappear for me.
>
> regards,
> Larry
>
> On Fri, Jul 30, 2010 at 11:34 AM, Matthias Scholz
> mailto:m...@jammerhund.de>
> >> wrote:
>
>Hi,
>
>please can Larry  or any other check my modifications
> again? Now
>I've solved the problem that the previous saved settings are
>restored from blackboard. The modifications in the
>AbstractSelectionRenderer should now smart enough, so that
> we have
>no performance problems and can set the properties with setter
>methods.
>
>It would be nice and important for my users if we can integrate
>the patch in the upcoming release.
>
>Regards
>
>Matthias
>
>Hi Larry,
>
>please see the attached file. There is one problem at the
>moment. After loading a file or project the
>AbstractSelectionRenderer use the default settings. So you
>must go to the options an click OK in the
>SelectionStyllingOptionsPanel. This is because during
>construction of the SelectionStyllingOptionsPanel instance
>there is no LayerViewPanel instance an so on no
>RenderingManager available. Is there a Listener which
> is fired
>if the RenderingManager is available or if a layer was
> added
>or a file was loaded???
>
>Regards
>
>Matthias
>
>Hi Matthias,
>
> I'm pretty sure that the right place to add
>setSelectionLineColor, setSelectionPointSize and
>setSelectionPointForm is AbstractSelectionRenderer
> since
>that is where the associated variables are
> declared.  You
>will have to remove /final /from HANDLE_WIDTH.  The
> real
>trick is getting the reference to
> FeatureSelectionRenderer
>to use the sets.  I think this can be done with
>RenderManager  by passing
>FeatureSelectionRenderer.CONTENT_ID.to
> 
>
>
>RenderManager.getRenderer().
>
>regards,
>Larry
>
>On Sun, Jul 11, 2010 at 7:58 AM, Matthias Scholz
>mailto:m...@jammerhund.de>
> >
>
> 
>   Hi Larry,
>
>   can we do the following?
>
>   - add some setSelectionLineCol

Re: [JPP-Devel] Selectionstyle Patch

[Matthias Scholz]

Hi,

I don't if Stefan have forgotten me or have no time, but it would be 
nice if Larry or any other can commit my patch.

Regards

Matthias
> No objections from me, but we should wait to hear from Stefan. I know
> he gets busy, so I copied him directly.
>
> The Sunburned Surveyor
>
> On Thu, Aug 12, 2010 at 6:19 AM, Larry Becker  wrote:
>   
>> Hi Matthias,
>>
>>   The new selection style now looks and works great!  I would suggest to
>> Stefan and the others that you be granted OJ project commit privileges.
>>
>> regards,
>> Larry
>>
>> On Thu, Aug 12, 2010 at 1:34 AM, Matthias Scholz  wrote:
>> 
>>> Hi Larry,
>>>
>>> please take a look at my changes.
>>> I've added a restore button in the optionsdialog.  The outline drawing
>>> problem is fixed in the VertexStyle.render(Graphics2D g) method. The
>>> solution was quit simple. You must first fill and then draw the outline. If
>>> you do that in other way around, you get a wrong view. Through this change
>>> is the vertex representation of geometries correct too :-)
>>>
>>> Regard
>>>
>>> Matthias
>>>   
> Should the button reset/delete the blackboard values for selection
> styling to the old defaults?
>   
 Yes.  I suggest that it be called "Restore default settings" in english.

 regards,

 Larry

 On Wed, Aug 11, 2010 at 1:07 AM, Matthias Scholz >>> > wrote:

Hi Larry,

i know the difference of handle outline drawing. This seems to be a
problem in the VertexStyle classes. You get the same mistake if you
switch on the vertices in the layer styling dialog. I can try to find
the problem in the VertexStyle classes.
What do you mean with the button in the options dialog? Should the
button reset/delete the blackboard values for selection styling to the
old defaults?

Regards

Matthias
> Hi Matthias,
>
>   Thanks for your patience.  You are almost there.  After I
deleted my
> workbench-state.xml file, your latest code very nearly
duplicated the
> old selection method's look and feel.  See the attached jpegs
for the
> difference, which seems to be in the details of handle outline
drawing.
>
>   I did benchmarks which verified that selection of 35 points
> completes in approximately the same amount of time and memory as
before.
>
>   It would be nice if you could add a button to the option dialog to
> restore the legacy settings so that users who try other settings and
> want to go back, can do so easily.
>
> regards,
>
> Larry
>
> On Tue, Aug 10, 2010 at 2:27 PM, Matthias Scholz
mailto:m...@jammerhund.de>
> >> wrote:
>
> Hi Larry,
>
> the patch use the old default setting for selectionrendering. If
> you nothing change in the optionspanel, you get the old
behavior.
> The point selection problem is fixed. The problem was the alpha
> channel setting of the VertexStyle.
>
>
> Regards
>
> Matthias
>
> Hi Matthias,
>
>  The code does indeed look much more efficient, however it
> still doesn't default to the old selection behavior, so I'm
> not sure how users outside your organization are going to
> react to the change. I don't like it as well as the current
> method which outlines the handles.   Also there seems to
be a
> problem with point selection feedback.  Selected points just
> seem to disappear for me.
>
> regards,
> Larry
>
> On Fri, Jul 30, 2010 at 11:34 AM, Matthias Scholz
> mailto:m...@jammerhund.de>
>
> 

>Hi,
>
>please can Larry  or any other check my modifications
> again? Now
>I've solved the problem that the previous saved
settings are
>restored from blackboard. The modifications in the
>AbstractSelectionRenderer should now smart enough, so
that
> we have
>no performance problems and can set the properties
with setter
>methods.
>
>It would be nice and important for my users if we can
integrate
>

Re: [JPP-Devel] Selectionstyle Patch

[Matthias Scholz]

Hi,

just now I have commited my selection style changes. Thanks to Larry for 
his help!
It would be nice if the language contributors can update the language 
files. I've only changed the german translation. The following keys must 
be changed:
ui.plugin.OptionsPlugIn.selection-style
ui.SelectionStyllingOptionsPanel.LineColor
ui.SelectionStyllingOptionsPanel.PointStyle
ui.SelectionStyllingOptionsPanel.PointSize
ui.SelectionStyllingOptionsPanel.RestoreDefaultsSettings
Please take look at the default jump.properties file.

Now OJ have a new panel in the options, from where you can change the 
settings.

Regards

Matthias

--
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] Selectionstyle Patch

[Larry Becker]

Thanks for your patience Matthias.  Selection Style is a nice addition to
OJ.

regards,

Larry

On Fri, Sep 3, 2010 at 2:18 AM, Matthias Scholz  wrote:

> Hi,
>
> just now I have commited my selection style changes. Thanks to Larry for
> his help!
> It would be nice if the language contributors can update the language
> files. I've only changed the german translation. The following keys must
> be changed:
> ui.plugin.OptionsPlugIn.selection-style
> ui.SelectionStyllingOptionsPanel.LineColor
> ui.SelectionStyllingOptionsPanel.PointStyle
> ui.SelectionStyllingOptionsPanel.PointSize
> ui.SelectionStyllingOptionsPanel.RestoreDefaultsSettings
> Please take look at the default jump.properties file.
>
> Now OJ have a new panel in the options, from where you can change the
> settings.
>
> Regards
>
> Matthias
>
>
> --
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
--
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] Selectionstyle Patch

[Sunburned Surveyor]

I'll see if I can take a look at the English I18N file. Did you have
English translations of the German words I can use? Or is the English
file already done?

The Sunburned Surveyor

On Fri, Sep 3, 2010 at 6:12 AM, Larry Becker  wrote:
> Thanks for your patience Matthias.  Selection Style is a nice addition to
> OJ.
>
> regards,
>
> Larry
>
> On Fri, Sep 3, 2010 at 2:18 AM, Matthias Scholz  wrote:
>>
>> Hi,
>>
>> just now I have commited my selection style changes. Thanks to Larry for
>> his help!
>> It would be nice if the language contributors can update the language
>> files. I've only changed the german translation. The following keys must
>> be changed:
>> ui.plugin.OptionsPlugIn.selection-style
>> ui.SelectionStyllingOptionsPanel.LineColor
>> ui.SelectionStyllingOptionsPanel.PointStyle
>> ui.SelectionStyllingOptionsPanel.PointSize
>> ui.SelectionStyllingOptionsPanel.RestoreDefaultsSettings
>> Please take look at the default jump.properties file.
>>
>> Now OJ have a new panel in the options, from where you can change the
>> settings.
>>
>> Regards
>>
>> Matthias
>>
>>
>> --
>> This SF.net Dev2Dev email is sponsored by:
>>
>> Show off your parallel programming skills.
>> Enter the Intel(R) Threading Challenge 2010.
>> http://p.sf.net/sfu/intel-thread-sfd
>> ___
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>
> --
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>

--
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] Selectionstyle Patch

[Michaël Michaud]

  Hi Matthias,

Just tested the new selection options. It works great. Thank you.

I'll try to have a look at language files this week-end.

Michaël



Le 03/09/2010 23:02, Sunburned Surveyor a écrit :
> I'll see if I can take a look at the English I18N file. Did you have
> English translations of the German words I can use? Or is the English
> file already done?
>
> The Sunburned Surveyor
>
> On Fri, Sep 3, 2010 at 6:12 AM, Larry Becker  wrote:
>> Thanks for your patience Matthias.  Selection Style is a nice addition to
>> OJ.
>>
>> regards,
>>
>> Larry
>>
>> On Fri, Sep 3, 2010 at 2:18 AM, Matthias Scholz  wrote:
>>> Hi,
>>>
>>> just now I have commited my selection style changes. Thanks to Larry for
>>> his help!
>>> It would be nice if the language contributors can update the language
>>> files. I've only changed the german translation. The following keys must
>>> be changed:
>>> ui.plugin.OptionsPlugIn.selection-style
>>> ui.SelectionStyllingOptionsPanel.LineColor
>>> ui.SelectionStyllingOptionsPanel.PointStyle
>>> ui.SelectionStyllingOptionsPanel.PointSize
>>> ui.SelectionStyllingOptionsPanel.RestoreDefaultsSettings
>>> Please take look at the default jump.properties file.
>>>
>>> Now OJ have a new panel in the options, from where you can change the
>>> settings.
>>>
>>> Regards
>>>
>>> Matthias
>>>
>>>
>>> --
>>> This SF.net Dev2Dev email is sponsored by:
>>>
>>> Show off your parallel programming skills.
>>> Enter the Intel(R) Threading Challenge 2010.
>>> http://p.sf.net/sfu/intel-thread-sfd
>>> ___
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>> --
>> This SF.net Dev2Dev email is sponsored by:
>>
>> Show off your parallel programming skills.
>> Enter the Intel(R) Threading Challenge 2010.
>> http://p.sf.net/sfu/intel-thread-sfd
>> ___
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>>
> --
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>


--
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] Selectionstyle Patch

[Matthias Scholz]

Hi Landon,

sorry for my delay, but my internet connection was down at the weekend :-(

I've done the german and english translation in jump_de and 
jump_en.properties.

Matthias
> I'll see if I can take a look at the English I18N file. Did you have
> English translations of the German words I can use? Or is the English
> file already done?
>
> The Sunburned Surveyor
>
> On Fri, Sep 3, 2010 at 6:12 AM, Larry Becker  wrote:
>   
>> Thanks for your patience Matthias.  Selection Style is a nice addition to
>> OJ.
>>
>> regards,
>>
>> Larry
>>
>> On Fri, Sep 3, 2010 at 2:18 AM, Matthias Scholz  wrote:
>> 
>>> Hi,
>>>
>>> just now I have commited my selection style changes. Thanks to Larry for
>>> his help!
>>> It would be nice if the language contributors can update the language
>>> files. I've only changed the german translation. The following keys must
>>> be changed:
>>> ui.plugin.OptionsPlugIn.selection-style
>>> ui.SelectionStyllingOptionsPanel.LineColor
>>> ui.SelectionStyllingOptionsPanel.PointStyle
>>> ui.SelectionStyllingOptionsPanel.PointSize
>>> ui.SelectionStyllingOptionsPanel.RestoreDefaultsSettings
>>> Please take look at the default jump.properties file.
>>>
>>> Now OJ have a new panel in the options, from where you can change the
>>> settings.
>>>
>>> Regards
>>>
>>> Matthias
>>>
>>>
>>> --
>>> This SF.net Dev2Dev email is sponsored by:
>>>
>>> Show off your parallel programming skills.
>>> Enter the Intel(R) Threading Challenge 2010.
>>> http://p.sf.net/sfu/intel-thread-sfd
>>> ___
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>   
>> --
>> This SF.net Dev2Dev email is sponsored by:
>>
>> Show off your parallel programming skills.
>> Enter the Intel(R) Threading Challenge 2010.
>> http://p.sf.net/sfu/intel-thread-sfd
>> ___
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>>
>> 
>
> --
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>   


--
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] Selectionstyle Patch

[Sunburned Surveyor]

Thanks Matthias. I was going to translate the English file, but sounds
like you've already done that.

Landon

On Mon, Sep 6, 2010 at 12:29 PM, Matthias Scholz  wrote:
> Hi Landon,
>
> sorry for my delay, but my internet connection was down at the weekend :-(
>
> I've done the german and english translation in jump_de and
> jump_en.properties.
>
> Matthias
>> I'll see if I can take a look at the English I18N file. Did you have
>> English translations of the German words I can use? Or is the English
>> file already done?
>>
>> The Sunburned Surveyor
>>
>> On Fri, Sep 3, 2010 at 6:12 AM, Larry Becker  wrote:
>>
>>> Thanks for your patience Matthias.  Selection Style is a nice addition to
>>> OJ.
>>>
>>> regards,
>>>
>>> Larry
>>>
>>> On Fri, Sep 3, 2010 at 2:18 AM, Matthias Scholz  wrote:
>>>
 Hi,

 just now I have commited my selection style changes. Thanks to Larry for
 his help!
 It would be nice if the language contributors can update the language
 files. I've only changed the german translation. The following keys must
 be changed:
 ui.plugin.OptionsPlugIn.selection-style
 ui.SelectionStyllingOptionsPanel.LineColor
 ui.SelectionStyllingOptionsPanel.PointStyle
 ui.SelectionStyllingOptionsPanel.PointSize
 ui.SelectionStyllingOptionsPanel.RestoreDefaultsSettings
 Please take look at the default jump.properties file.

 Now OJ have a new panel in the options, from where you can change the
 settings.

 Regards

 Matthias


 --
 This SF.net Dev2Dev email is sponsored by:

 Show off your parallel programming skills.
 Enter the Intel(R) Threading Challenge 2010.
 http://p.sf.net/sfu/intel-thread-sfd
 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

>>> --
>>> This SF.net Dev2Dev email is sponsored by:
>>>
>>> Show off your parallel programming skills.
>>> Enter the Intel(R) Threading Challenge 2010.
>>> http://p.sf.net/sfu/intel-thread-sfd
>>> ___
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>
>>>
>>>
>>
>> --
>> This SF.net Dev2Dev email is sponsored by:
>>
>> Show off your parallel programming skills.
>> Enter the Intel(R) Threading Challenge 2010.
>> http://p.sf.net/sfu/intel-thread-sfd
>> ___
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>
>
> --
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>

--
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel