[kwayland-integration] [Bug 447538] On Wayland, Kate doesn't prefer opening files in an instance on the current virtual desktop

2024-03-05 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=447538

--- Comment #4 from Ahmad Samir  ---
I don't know much about Wayland; so here is an observation, assuming there is a
kate instance on the current virtual desktop, and focus stealing prevention is
set to none:
- Ctrl+Clicking in konsole opens the file in that kate instance and activates
the window
- From that konsole window, using `kate /path/to/some/file`, the file is opened
in kate, but the window isn't activated, and the task manager highlights the
kate window as requesting attention

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 473425] LSP doesn't detect methods used in SIGNAL()/SLOT() macros when searching for references

2023-08-18 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=473425

--- Comment #4 from Ahmad Samir  ---
(In reply to Waqar Ahmed from comment #3)
> clangd provides AST in an xml like format which you can use to get more info
> about the current file and maybe do some extra operations on it. Maybe
> that's how qtcreator is able to achieve this. But afair, qtcreator has a
> third cplusplus backend based on a small c++ parser so maybe it's using that.
> 
> For the issue itself, I generally use search plugin and it works nicely for
> finding refs even in SIGNAL()/SLOT() macros or
> QMetaObject::invokeMethod("stringMethod") stuff.

Yeah, same here I use the search plugin; but sometimes while refactoring code I
might forget, or the code supports multiple platforms with the help of #ifdefS,
so I want to only see the parts relevant to Linux ...etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 473425] LSP doesn't detect methods used in SIGNAL()/SLOT() macros when searching for references

2023-08-18 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=473425

--- Comment #2 from Ahmad Samir  ---
I see; I thought since Qt Creator has switched to clangd (instead of libclang
backend) that this works with clangd too; perhaps they have another way of
listing references to methods wrapped in SIGNAL/SLOT.

Sorry for the noise.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 473425] New: LSP doesn't detect methods used in SIGNAL()/SLOT() macros when searching for references

2023-08-15 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=473425

Bug ID: 473425
   Summary: LSP doesn't detect methods used in SIGNAL()/SLOT()
macros when searching for references
Classification: Applications
   Product: kate
   Version: Git
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: application
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: a.samir...@gmail.com
  Target Milestone: ---

When using "find references" with a method marked as a Qt signal, instances
that are wrapped in the SIGNAL() macro in a QObject::connect() call aren't
detected.

It looks like Qt Creator special-cases SIGNAL/SLOT macros to find those
references, see:
https://codereview.qt-project.org/c/qt-creator/qt-creator/+/227189

(I am not familiar enough with the LSP plugin code in Kate, otherwise I would
have tried to create a patch).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 453197] When window maximized vertically it vertical size becomes not maximized after maximize and unmaximize

2023-01-18 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=453197

--- Comment #8 from Ahmad Samir  ---
So, can KWin, instead of setting the maximize-vertically property (or whatever
it's called in XCB/X11 land) on the window, calculate that height and "resize"
the window instead? (I am not talking about the
app-started-maximized-vertically use-case, rather the one in my previous
comment). Of course, it could well be that would cause other issues, e.g.
moving the window from one screen to another with a different size, if the
maximized-vertically property isn't set, it's going go keep the height...
window management is tough. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 437692] Dolpin Version > 20.12.3 does not start in Firefox/Opera by clicking "open containing Folder"

2022-12-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=437692

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com,
   ||k...@davidedmundson.co.uk

--- Comment #2 from Ahmad Samir  ---
It could be systemd-related; could you please test this:
mkdir -p ~/.local/share/dbus-1/services/
cp -v /usr/share/dbus-1/services/org.kde.dolphin.FileManager1.service
~/.local/share/dbus-1/services/

then edit ~/.local/share/dbus-1/services/org.kde.dolphin.FileManager1.service
to be like this:
[D-BUS Service]
Name=org.freedesktop.FileManager1
Exec=/usr/bin/dolphin --daemon --select

then try again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 461520] Add a way to temporarily stop LSP server

2022-11-07 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=461520

--- Comment #1 from Ahmad Samir  ---
Another data point, QtCreator has two config options:
- "Files to keep open":
"Minimum number of open documents that should be kept in memory.
Increasing this number will lead to greater resource usage when not manually
closing documents."

- "Auto-suspend unmodified files":
"Automatically free resources of old documents that are not visible and
not modified. They stay visible in the list of open documents."

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 461520] New: Add a way to temporarily stop LSP server

2022-11-06 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=461520

Bug ID: 461520
   Summary: Add a way to temporarily stop LSP server
Classification: Applications
   Product: kate
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: application
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: a.samir...@gmail.com
  Target Milestone: ---

This is useful if you have multiple instances of Kate open, each on a different
project; clangd takes 10% of my 16GiB of RAM per project (depending on
project's codebase size). It would be nice if there is a way to "suspend" the
LSP server, i.e. terminate it to free the memory, the one can resume/start it
again when one wants to work on the project in that Kate instance.

Closing the Kate instance is an option, yes, but quite annoying, you have
documents open, edits in the undo stack ...etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 461337] Right-click menu only appears after moving mouse pointer

2022-11-04 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=461337

--- Comment #2 from Ahmad Samir  ---
X11, OpenSuse TumbleWeed.

Right clicking anywhere, Kate, Dolphin, Konsole. It also seems to affect the
menus in the menu bar. Setting the animation speed in the general behaviour KCM
to a very low value seems to "fix it".

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 461337] New: Right-click menu only appears after moving mouse pointer

2022-11-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=461337

Bug ID: 461337
   Summary: Right-click menu only appears after moving mouse
pointer
Classification: Plasma
   Product: kwin
   Version: master
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: effects-various
  Assignee: kwin-bugs-n...@kde.org
  Reporter: a.samir...@gmail.com
  Target Milestone: ---

Clicking the right mouse button, the context menu only appears after moving the
mouse pointer; this seems to be an issue when the "fading popups" effect is
disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 431351] For files that don't fit in the trash, the user isn't provided with the option to delete immediately

2022-10-18 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431351

Ahmad Samir  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.100
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/3f922b72e
   ||5202b882c85a390926c905f8008
   ||ca60
 Resolution|--- |FIXED

--- Comment #10 from Ahmad Samir  ---
Git commit 3f922b72e5202b882c85a390926c905f8008ca60 by Ahmad Samir.
Committed on 19/10/2022 at 04:29.
Pushed by ahmadsamir into branch 'master'.

AskUserActionInterface: add DeleteInsteadOfTrash deletion type

Typical use-case:
- the user tries to Trash some file, which fails due to size constraints
- we ask the user again about deleting the files instead of Trashing them
FIXED-IN: 5.100

M  +7-0src/core/askuseractioninterface.h
M  +8-1src/core/global.h
M  +3-0src/core/job_error.cpp
M  +2-2src/ioslaves/trash/trashimpl.cpp
M  +22   -2src/widgets/deleteortrashjob.cpp
M  +23   -1src/widgets/widgetsaskuseractionhandler.cpp

https://invent.kde.org/frameworks/kio/commit/3f922b72e5202b882c85a390926c905f8008ca60

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 458525] Kate crash on save - every time

2022-10-17 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458525

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||a.samir...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #7 from Ahmad Samir  ---
The backtrace isn't useful due to missing debug symbols; install the debug info
packages from your distro and provide the backtrace again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 458665] Kate crashes during the open file dialogue

2022-10-17 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458665

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||a.samir...@gmail.com
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Ahmad Samir  ---
The backtrace isn't complete, please install the debug symbols and post the
backtrace again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 458709] [bug]: the closed file manager window crashes when copying

2022-09-16 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458709

--- Comment #9 from Ahmad Samir  ---
The backtrace in comment#6 looks slightly different than the one from
comment#0, could be two separate issues... the problem is the backtrace from
comment#0 is not complete due to missing debug symbols.

I tried reproducing this issue, and it happened 1-2 times, but I failed to make
crash again.

This *might* be related:
https://invent.kde.org/frameworks/kio/-/merge_requests/977 (it makes sense to
parent the widgets to the dialog, not to its parent anyway). The question is,
why is this happening only now when this code has been around for ages?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 458709] [bug]: the closed file manager window crashes when copying

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458709

Ahmad Samir  changed:

   What|Removed |Added

 CC||beedellrokejulianlockhart@g
   ||mail.com

--- Comment #8 from Ahmad Samir  ---
*** Bug 458570 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 458570] Crash when exiting dolphin.

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458570

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 458709 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 454133] Crash on Copy Local Files to SMB1 Share

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=454133

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 458709 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 458709] [bug]: the closed file manager window crashes when copying

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458709

Ahmad Samir  changed:

   What|Removed |Added

 CC||myccl...@outlook.com

--- Comment #7 from Ahmad Samir  ---
*** Bug 454133 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 458709] [bug]: the closed file manager window crashes when copying

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458709

--- Comment #6 from Ahmad Samir  ---
postix posted a complete backtrace at
https://bugs.kde.org/show_bug.cgi?id=364039#c84


Operating System: openSUSE Tumbleweed 20220525
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.2
Kernel Version: 5.17.9-1-default (64-bit)
Graphics Platform: Wayland


```
#0  0x7f0f092846ac in __pthread_kill_implementation () from
/lib64/libc.so.6
#1  0x7f0f092316f6 in raise () from /lib64/libc.so.6
#2  0x7f0f0b2b9d7e in KCrash::defaultCrashHandler (sig=11) at
/usr/src/debug/kcrash-5.94.0-1.1.x86_64/src/kcrash.cpp:633
#3  
#4  QScopedPointer
>::operator-> (this=0x8) at
../../include/QtCore/../../src/corelib/tools/qscopedpointer.h:116
#5  qGetPtrHelper > > (ptr=...) at
../../include/QtCore/../../src/corelib/global/qglobal.h:1143
#6  QWidget::d_func (this=0x0) at kernel/qwidget.h:132
#7  QWidgetPrivate::createWinId (this=) at
kernel/qwidget.cpp:2371
#8  0x7f0f0a5bdf79 in QWidget::createWinId (this=) at
kernel/qwidget.cpp:2442
#9  0x7f0f0a5bbbd0 in QWidget::create (this=0x564ddc1b3f00,
window=, initializeWindow=,
destroyOldWindow=) at kernel/qwidget.cpp:1149
#10 0x7f0f0a5c899a in QWidgetPrivate::setVisible (this=0x564ddc020db0,
visible=) at kernel/qwidget.cpp:8063
#11 0x7f0f0a5c8d92 in QWidget::setVisible (this=this@entry=0x564ddc1b3f00,
visible=visible@entry=true) at kernel/qwidget.cpp:8044
#12 0x7f0f0a78fb95 in QDialog::setVisible (this=0x564ddc1b3f00,
visible=) at dialogs/qdialog.cpp:787
#13 0x7f0f0b335dda in KIO::CopyJobPrivate::slotResultErrorCopyingFiles
(this=, job=0x564dda63dd60) at
/usr/src/debug/kio-5.94.0-1.1.x86_64/src/core/copyjob.cpp:1769
#14 0x7f0f09949def in QtPrivate::QSlotObjectBase::call (a=0x7ffd4c6f7b20,
r=0x564ddc0c4920, this=0x564dda659950) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#15 doActivate (sender=0x564dda63dd60, signal_index=6,
argv=0x7ffd4c6f7b20) at kernel/qobject.cpp:3886
#16 0x7f0f099430cf in QMetaObject::activate
(sender=sender@entry=0x564dda63dd60, m=,
local_signal_index=local_signal_index@entry=3, argv=argv@entry=0x7ffd4c6f7b20)
at kernel/qobject.cpp:3946
#17 0x7f0f0ab97785 in KJob::result (this=this@entry=0x564dda63dd60,
_t1=, _t1@entry=0x564dda63dd60, _t2=...) at
/usr/src/debug/kcoreaddons-5.94.0-1.1.x86_64/build/src/lib/KF5CoreAddons_autogen/include/moc_kjob.cpp:633
#18 0x7f0f0ab9b8eb in KJob::finishJob (this=0x564dda63dd60,
emitResult=) at
/usr/src/debug/kcoreaddons-5.94.0-1.1.x86_64/src/lib/jobs/kjob.cpp:98
#19 0x7f0f09949def in QtPrivate::QSlotObjectBase::call (a=0x7ffd4c6f7c40,
r=0x564dda63dd60, this=0x564ddb3e85a0) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#20 doActivate (sender=0x564ddb3bd9a0, signal_index=6,
argv=0x7ffd4c6f7c40) at kernel/qobject.cpp:3886
#21 0x7f0f099430cf in QMetaObject::activate
(sender=sender@entry=0x564ddb3bd9a0, m=,
local_signal_index=local_signal_index@entry=3, argv=argv@entry=0x7ffd4c6f7c40)
at kernel/qobject.cpp:3946
#22 0x7f0f0ab97785 in KJob::result (this=this@entry=0x564ddb3bd9a0,
_t1=, _t1@entry=0x564ddb3bd9a0, _t2=...) at
/usr/src/debug/kcoreaddons-5.94.0-1.1.x86_64/build/src/lib/KF5CoreAddons_autogen/include/moc_kjob.cpp:633
#23 0x7f0f0ab9b8eb in KJob::finishJob (this=0x564ddb3bd9a0,
emitResult=) at
/usr/src/debug/kcoreaddons-5.94.0-1.1.x86_64/src/lib/jobs/kjob.cpp:98
#24 0x7f0f09949def in QtPrivate::QSlotObjectBase::call (a=0x7ffd4c6f7d60,
r=0x564ddb3bd9a0, this=0x564ddc0b7f80) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#25 doActivate (sender=0x564ddc06c610, signal_index=5,
argv=0x7ffd4c6f7d60) at kernel/qobject.cpp:3886
#26 0x7f0f099430cf in QMetaObject::activate
(sender=sender@entry=0x564ddc06c610, m=,
local_signal_index=local_signal_index@entry=2, argv=argv@entry=0x7ffd4c6f7d60)
at kernel/qobject.cpp:3946
#27 0x7f0f0b34f056 in KIO::SlaveInterface::error
(this=this@entry=0x564ddc06c610, _t1=, _t2=...) at
/usr/src/debug/kio-5.94.0-1.1.x86_64/build/src/core/KF5KIOCore_autogen/include/moc_slaveinterface.cpp:452
#28 0x7f0f0b355f88 in KIO::SlaveInterface::dispatch (this=0x564ddc06c610,
_cmd=102, rawdata=...) at
/usr/src/debug/kio-5.94.0-1.1.x86_64/src/core/slaveinterface.cpp:181
#29 0x7f0f0b34ef06 in KIO::SlaveInterface::dispatch (this=0x564ddc06c610)
at /usr/src/debug/kio-5.94.0-1.1.x86_64/src/core/slaveinterface.cpp:78
#30 0x7f0f0b3528b9 in KIO::Slave::gotInput (this=0x564ddc06c610) at
/usr/src/debug/kio-5.94.0-1.1.x86_64/src/core/slave.cpp:336
#31 0x7f0f09949def in QtPrivate::QSlotObjectBase::call (a=0x7ffd4c6f7f70,
r=0x564ddc06c610, this=0x564ddc0c59f0) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#32 doActivate (sender=0x564ddc09ab80, signal_index=3,
argv=0x7ffd4c6f7f70) at kernel/qobject.cpp:3886
#33 0x7f0f0993e660 in QObject::event (this=0x564ddc09ab80,
e=0x564ddbe54a90) at kernel/qobject.

[dolphin] [Bug 458709] [bug]: the closed file manager window crashes when copying

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458709

Ahmad Samir  changed:

   What|Removed |Added

 CC||midkiffjack...@gmail.com

--- Comment #5 from Ahmad Samir  ---
*** Bug 456223 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 456223] Dolphin closes when copying files to SMB1 Share

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456223

--- Comment #9 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 458709 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 458709] [bug]: the closed file manager window crashes when copying

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458709

Ahmad Samir  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---
 CC||a.samir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 458709] [bug]: the closed file manager window crashes when copying

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458709

Ahmad Samir  changed:

   What|Removed |Added

 CC||damian.hoes...@gmail.com

--- Comment #4 from Ahmad Samir  ---
*** Bug 458111 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 458111] Dolphin crash during transaction overwriting existing files from internal Btrfs RAID6 to USB HDD

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458111

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
Bug 458709 has a slightly better backtrace.

*** This bug has been marked as a duplicate of bug 458709 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 364039] Dolphin crashed on file transfer in KIO::WidgetsAskUserActionHandler::askUserRename()

2022-09-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=364039

--- Comment #94 from Ahmad Samir  ---
All these reports can't be duplicates of the original report from 5.26, since
KIO::WidgetsAskUserActionHandler was introduced in 5.78.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 444614] Potential Buffer overflow inside ki18n KCatalog

2022-09-07 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=444614

--- Comment #5 from Ahmad Samir  ---
Git commit 241e0cfa96b1491721f361f1713b3514c58bde56 by Ahmad Samir.
Committed on 05/09/2022 at 17:12.
Pushed by ahmadsamir into branch 'master'.

KCatalog: make setting LANGUAGE env var more robust

- Use std::snprintf, since its docs state the resulting string will be
  null-terminated; also check the return value from that call to
  print warnings
- Bump the size of the allocated char array to 64

Add rudimentary unittest adapted from kcountrytest.cpp.

M  +7-3autotests/CMakeLists.txt
A  +50   -0autotests/kcatalogtest.cpp [License: LGPL(v2.0+)]
M  +17   -6src/i18n/kcatalog.cpp

https://invent.kde.org/frameworks/ki18n/commit/241e0cfa96b1491721f361f1713b3514c58bde56

-- 
You are receiving this mail because:
You are watching all bug changes.

[kactivitymanagerd] [Bug 458356] Plasma 5.25.x not launching on FreeBSD

2022-08-30 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=458356

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
Does moving ~/.local/share/kactivitymanagerd (before starting plasmashell),
make any difference?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 451834] Calling app crashes trying to show a message box with KMessageBox::createKMessageBox()

2022-08-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=451834

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.97
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/5f7fe0501
   ||725564d4c8247f74731bcee52cd
   ||711d

--- Comment #6 from Ahmad Samir  ---
Git commit 5f7fe0501725564d4c8247f74731bcee52cd711d by Ahmad Samir.
Committed on 21/08/2022 at 11:59.
Pushed by ahmadsamir into branch 'master'.

Use AskUserActionInterface (async) in UserNotificationHandler

This avoids using QDialog::exec(), which uses a nested eventloop, with all
the problems that come from such usage.
FIXED-IN: 5.97

M  +31   -23   src/core/usernotificationhandler.cpp
M  +1-0src/core/usernotificationhandler_p.h

https://invent.kde.org/frameworks/kio/commit/5f7fe0501725564d4c8247f74731bcee52cd711d

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 447238] In tabs bar the icon associated to home folder is the template one.

2022-08-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=447238

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/30d22d282
   ||b0a9b1de359353f064b033ba2d3
   ||0887
   Version Fixed In||5.98
 Resolution|NOT A BUG   |FIXED

--- Comment #5 from Ahmad Samir  ---
Git commit 30d22d282b0a9b1de359353f064b033ba2d30887 by Ahmad Samir.
Committed on 21/08/2022 at 11:57.
Pushed by ahmadsamir into branch 'master'.

Ensure iconForStandardPath() returns user-home for QStandardPaths::HomeLocation
FIXED-IN: 5.98

M  +41   -24   src/core/kioglobal_p.cpp

https://invent.kde.org/frameworks/kio/commit/30d22d282b0a9b1de359353f064b033ba2d30887

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 353883] "Invalid Protocol" when entering relative paths

2022-08-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=353883

Ahmad Samir  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/d2d81ca6e
   ||d0653823b77b2cab3c404dd71bf
   ||8fef
 Resolution|--- |FIXED
   Version Fixed In||5.98

--- Comment #3 from Ahmad Samir  ---
Git commit d2d81ca6ed0653823b77b2cab3c404dd71bf8fef by Ahmad Samir.
Committed on 20/08/2022 at 13:19.
Pushed by ahmadsamir into branch 'master'.

KUrlNavigator: check if typed text matches a relative dir first

Test plan:
- Open e.g. Dolphin at ~/, in the url bar replace all the text with
  ".config", Enter
- it displays an error "Invalid protocol"
- Apply patch and try again, it should open ~/.config as expected
FIXED-IN: 5.98

M  +17   -5src/filewidgets/kurlnavigator.cpp

https://invent.kde.org/frameworks/kio/commit/d2d81ca6ed0653823b77b2cab3c404dd71bf8fef

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 454226] Pointless 'Undo: Copy" option is available in 'Edit' menu after skipping all files in a file operation

2022-08-19 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=454226

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/c34f934e5
   ||8911b0ab64fa9cdbbb662f69ab8
   ||dfda
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
   Version Fixed In||5.98

--- Comment #2 from Ahmad Samir  ---
Git commit c34f934e58911b0ab64fa9cdbbb662f69ab8dfda by Ahmad Samir.
Committed on 19/08/2022 at 15:35.
Pushed by ahmadsamir into branch 'master'.

FileUndoManager: for copyjob only add undo if it copied something

Test plan, before applying this patch:
- copy some files/dirs in dolphin, note the Edit menu now has an "undo copy"
  action
- copy the same files/dirs to the same destination again, you should see
  the copy conflict dialog
- enable "apply to all" and click "skip", nothing is copied; now check the
  Edit menu again, you should see the "undo copy" action still enabled,
  because another undo command was added even when nothing was copied
- trigger "undo copy", nothing happens
- trigger "undo copy" again, now it's asking if you want to delete
  /path/to/dest/files-you-copied-earlier from the destination

Add a unittest.
FIXED-IN: 5.98

M  +57   -0autotests/fileundomanagertest.cpp
M  +1-1autotests/fileundomanagertest.h
M  +11   -0src/widgets/fileundomanager.cpp

https://invent.kde.org/frameworks/kio/commit/c34f934e58911b0ab64fa9cdbbb662f69ab8dfda

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kservice] [Bug 442721] kf.service.services: KApplicationTrader: mimeType "x-scheme-handler/file" not found

2022-08-19 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=442721

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In||5.96
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/a4c404603
   ||bbf43fda2d60c82c814527bde0a
   ||8352
 Resolution|--- |FIXED

--- Comment #15 from Ahmad Samir  ---
Git commit a4c404603bbf43fda2d60c82c814527bde0a8352 by Ahmad Samir.
Committed on 19/08/2022 at 14:31.
Pushed by ahmadsamir into branch 'master'.

DesktopExecParser: don't kioexec if there is a handler for scheme

This fixes an issue where the code called
KApplicationTrader::queryByMimeType("x-scheme-handler/file"), which would
trigger a warning in KApplicationTrader, because there is no
x-scheme-handler/file mimtype.
FIXED-IN: 5.96

M  +24   -12   src/core/desktopexecparser.cpp

https://invent.kde.org/frameworks/kio/commit/a4c404603bbf43fda2d60c82c814527bde0a8352

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 457953] New: Super/Win key always opens the Application menu, regardless of set shortcut

2022-08-16 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=457953

Bug ID: 457953
   Summary: Super/Win key always opens the Application menu,
regardless of set shortcut
   Product: plasmashell
   Version: master
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-b...@kde.org
  Reporter: a.samir...@gmail.com
CC: k...@davidedmundson.co.uk
  Target Milestone: 1.0

Open Application Menu's config dialog, the shortcut is Alt+F1 by default, if
set to that it activated the menu when the Super/Win key is pressed.
- set the shortcut to something else, press Super/Win the menu is still
activated
- unset the shortcut altogether, press Super/Win the menu is still activated

Editing ~/.config/kwinrc and adding:
[ModifierOnlyShortcuts]
Meta=

stops the Super/Win key from activating the menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 456819] Commenting out code in C++ source files adds // to the very beginning of the line

2022-08-10 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456819

--- Comment #6 from Ahmad Samir  ---
Git commit fceb6fef10932a5b6aaf698c102f05bbed04e12a by Ahmad Samir.
Committed on 10/08/2022 at 18:20.
Pushed by cullmann into branch 'master'.

KateDocument: always add space after single line comment start marker

So that if you have code:
if (foo) {
do_something();
}

commenting out the second line, it would become (assuming the
position="afterwhitespace" option is set in c.xml):
if (foo) {
// do_something();
}

This works better with clang-format, which insists on reformatting this:
//do_something();
to
// do_something();

to the version with the space, "// ".

Fix unittests.

M  +1-1autotests/src/katedocument_test.cpp
M  +1-2src/document/katedocument.cpp

https://invent.kde.org/frameworks/ktexteditor/commit/fceb6fef10932a5b6aaf698c102f05bbed04e12a

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 456819] Commenting out code in C++ source files adds // to the very beginning of the line

2022-08-08 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456819

--- Comment #3 from Ahmad Samir  ---
Git commit 178c4dfbf4eb5ad7c5aef4838f190f717f97766f by Ahmad Samir.
Committed on 08/08/2022 at 21:30.
Pushed by ahmadsamir into branch 'master'.

clang-format.cmake: don't change spaces after '//' in code comments

For example, if you have:
//This is a comment

now clang-format won't change it to:
// This is a comment

We're mainly interested in formatting the code, not the comments, so that
cuts down on some noise when running clang-format.

M  +5-0kde-modules/clang-format.cmake

https://invent.kde.org/frameworks/extra-cmake-modules/commit/178c4dfbf4eb5ad7c5aef4838f190f717f97766f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 453197] When window maximized vertically it vertical size becomes not maximized after maximize and unmaximize

2022-07-31 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=453197

Ahmad Samir  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Ahmad Samir  ---
This happens even without restarting the app:
- open dolphin, note the window size, maximize it vertically
- maximize it (which affects both vertical and horizontal size)
- un-maximize it, it goes back to the initial window size from step 1

Repeat the above but instead of maximizing vertically using kwin shorctus (e.g.
middle clicking the maximize button on the title bar), resize the window
manually to the same size it would have been changed to; everything works as
expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 453197] When window maximized vertically it vertical size becomes not maximized after maximize and unmaximize

2022-07-31 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=453197

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 456627] Reported tab name contains non-substituted %n in it

2022-07-28 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456627

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #7 from Ahmad Samir  ---
(In reply to Antonio Rojas from comment #6)
> AFAICS this fix hasn't been backported to the 22.08 branch. The bug will
> make it to the final release if it's not.

The commit was reverted in release/22.08,
https://invent.kde.org/utilities/konsole/-/commit/80f33b011f3cb2e0bcc76b01cb5de163e56ae2f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kholidays] [Bug 457176] No API documentation for HolidayRegion::rawHolidaysWithAstroSeasons()

2022-07-27 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=457176

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com,
   ||spitz...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 456627] Reported tab name contains non-substituted %n in it

2022-07-27 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456627

Ahmad Samir  changed:

   What|Removed |Added

 CC||kishor...@gmail.com

--- Comment #5 from Ahmad Samir  ---
*** Bug 457201 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 457201] %n placeholder in konsole tab title no longer works

2022-07-27 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=457201

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 456627 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 437510] Notification says "Moving" during/after undoing mass renaming with Dolphin

2022-07-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=437510

Ahmad Samir  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.97
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/0bf55cca0
   ||4fd59f6dffd334d22a950d72092
   ||13f7

--- Comment #3 from Ahmad Samir  ---
Git commit 0bf55cca04fd59f6dffd334d22a950d7209213f7 by Ahmad Samir.
Committed on 25/07/2022 at 12:34.
Pushed by ahmadsamir into branch 'master'.

FileUndoManager: fix job description when undoing a batch-renaming

It should be "Renaming", not "Moving".
FIXED-IN: 5.97

M  +28   -5src/widgets/fileundomanager.cpp

https://invent.kde.org/frameworks/kio/commit/0bf55cca04fd59f6dffd334d22a950d7209213f7

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 456819] Commenting out code in C++ source files adds // to the very beginning of the line

2022-07-24 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456819

--- Comment #2 from Ahmad Samir  ---
(In reply to Christoph Cullmann from comment #1)
> Does it behave better if you pass the singleLine tag the
> position="afterwhitespace" attribute in the XML highlighting file?

Yeah, that seems to have an effect:
if (!iconNo.isNull()) {
buttonNoGui.setIconName(iconNo);
}

becomes:
if (!iconNo.isNull()) {
//buttonNoGui.setIconName(iconNo);
}

but, of course, clang(pesky)-fromat still complains and changes it to:
// buttonNoGui.setIconName(iconNo);

so it would probably need another change in the indenter js code to add "// "
instead of just "//".
(I don't know javascript well enough to try hacking the indenter js code).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 456570] "Run current document" fails if path contains spaces

2022-07-23 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456570

--- Comment #6 from Ahmad Samir  ---
Git commit 8e45d772753fb8fc5a2bb2abb1875e9c891df10a by Ahmad Samir.
Committed on 23/07/2022 at 13:43.
Pushed by cullmann into branch 'master'.

Konsole plugin: quote args before passing them to the shell

An alternative fix for 456570

M  +5-8addons/konsole/kateconsole.cpp

https://invent.kde.org/utilities/kate/commit/8e45d772753fb8fc5a2bb2abb1875e9c891df10a

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 456570] "Run current document" fails if path contains spaces

2022-07-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456570

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #4 from Ahmad Samir  ---
There is KShell::quoteArg()
https://api.kde.org/frameworks/kcoreaddons/html/namespaceKShell.html#a471161f0b7fb9b516932d2a9121c715b

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 456819] New: Commenting out code in C++ source files adds // to the very beginning of the line

2022-07-17 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456819

Bug ID: 456819
   Summary: Commenting out code in C++ source files adds // to the
very beginning of the line
   Product: frameworks-ktexteditor
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: indentation
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: a.samir...@gmail.com
  Target Milestone: ---

For example:
if (!iconNo.isNull()) {
buttonNoGui.setIconName(iconNo);
}

if I toggle comment on the middle line (or all of them), it becomes:
 if (!iconNo.isNull()) {
// buttonNoGui.setIconName(iconNo);
 }

the // characters are added to the very beginning of the line; which works, but
interferes with clang-format, which will then change that to:
 if (!iconNo.isNull()) {
 // buttonNoGui.setIconName(iconNo);
 }

This can be avoided if the // characters are added like this to begin with:
if (!iconNo.isNull()) {
// buttonNoGui.setIconName(iconNo);
}

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 446834] Windows C drive is named "Basic data Partition"

2022-07-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=446834

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #4 from Ahmad Samir  ---
As an aside: a filesystem label is tied to the filesystem not the OS, so you
can change the label under Windows, and it'll be used in Linux.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 444098] No entry in Global Shortcuts to configure KCommandBar

2022-07-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=444098

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
The KCommandBar action shortcut is added to the KActionCollection in KXmlGui,
so for now you can configure that shortcut in each app's Settings -> Configure
keyboard shortcuts (it's called "Find Action").

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 438309] Built-in/hardcoded profile should not be named "Default [Read-only]"

2022-07-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=438309

Ahmad Samir  changed:

   What|Removed |Added

 CC||pilo...@gmail.com

--- Comment #8 from Ahmad Samir  ---
*** Bug 456602 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 456602] No edit option for profiles

2022-07-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456602

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #7 from Ahmad Samir  ---
This is sort of duplicate of bug 438309; so closing as such.

*** This bug has been marked as a duplicate of bug 438309 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 456602] No edit option for profiles

2022-07-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456602

--- Comment #5 from Ahmad Samir  ---
The default/built-in profile became read-only because otherwise it caused other
issues.

The "Root Shell" profile is read-only because the .profile file is owned by
root, so your user account has no write-access to it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 445044] LOTS of metadata access warnings on start-up, a few other ones, e.g. "null action"

2022-07-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=445044

Ahmad Samir  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
If this still an issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 456602] No edit option for profiles

2022-07-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456602

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
If the profile you're trying to edit has "Read-only" in its name, then it can't
be edited, you need to create a new profile.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 438394] We need a software utility that will SOLVE the problem of one-off running KDE programs in a different language

2022-07-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=438394

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #11 from Ahmad Samir  ---
Looking around it looks like setting LANGUAGE env var would work[1] e.g. from
terminal:
LANGUAGE=en dolphin

[1]https://invent.kde.org/frameworks/kxmlgui/-/blob/master/src/kswitchlanguagedialog_p.cpp#L69

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-07-11 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=448859

Ahmad Samir  changed:

   What|Removed |Added

 Status|REOPENED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #8 from Ahmad Samir  ---
Ping.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 449600] kf.kio.slaves.file copy() QUrl mode= 420 Cannot copy file (Errno: 38)

2022-07-11 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=449600

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Ahmad Samir  ---
Is this still an issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 454226] Pointless 'Undo: Copy" option is available in 'Edit' menu after skipping all files in a file operation

2022-07-11 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=454226

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Good catch!

https://invent.kde.org/frameworks/kio/-/merge_requests/908

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453576] kioslave5 consumes massive resources slowing down Gimp file save 10 times

2022-07-09 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=453576

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||a.samir...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Ahmad Samir  ---
>From terminal enabled kio debug output, and start dolphin:
export QT_LOGGING_RULES="*kio*=true"
dolphin

then save in gimp, and attach the terminal output here, hopefully it'll give a
clue what's going on.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kconfigwidgets] [Bug 454061] KMail crashes in KCommandBar

2022-07-09 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=454061

--- Comment #3 from Ahmad Samir  ---
bool QIconEngine::isNull() const
{
bool isNull = false;
const_cast(this)->virtual_hook(QIconEngine::IsNullHook,
&isNull);
return isNull;
}

second backtrace, it's crashing on the const_cast line above, which makes no
sense to me...

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 452341] When an icon is not found from its specified absolute path, look for it in the active icon theme before giving up

2022-07-08 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=452341

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #7 from Ahmad Samir  ---
Giving the code an absolute path, is restricting it to that exact path, if it's
not found, the search should fail (as it does now).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kded] [Bug 452859] kded5 crashes with xrandr after reloading i2c_amd_mp2_plat.ko followed by xrandr

2022-07-08 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=452859

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||a.samir...@gmail.com
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Ahmad Samir  ---
This backtrace is incomplete, please install the debuginfo packages, and
provide another backtrace.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 452884] Selection text color is ignored

2022-07-08 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=452884

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #11 from Ahmad Samir  ---
Could you try with a new/fresh user account? so that it's using the default
color scheme, widget style...etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 453570] activitymanagerd created database which took 80 GB in file system

2022-07-08 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=453570

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #21 from Ahmad Samir  ---
(In reply to Tilman Vogel from comment #20)
> > Are you all on Arch?
> 
> No, I am on openSUSE Tumbleweed and had that problem. Also,
> kactivitymanagerd ate 100% of one of my cores. I removed database and config
> files. After that, it did not happen again yet.

I had this same issue on Tumbleweed, and deleting the database files fixed the
issue, I thought it was a fluke on my system, so never reported it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kconfigwidgets] [Bug 454061] KMail crashes in KCommandBar

2022-07-08 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=454061

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Ahmad Samir  ---
I couldn't reproduce this issue; do you still see it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 455281] Folder selector mounts CIFS shares on opening

2022-07-07 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455281

--- Comment #3 from Ahmad Samir  ---
Could you try this? enable kio debug, `export QT_LOGGING_RULES="*kio*=true"`,
then open the app, and recreate the bug, and post the log.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 455281] Folder selector mounts CIFS shares on opening

2022-07-07 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455281

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
As a data point, does the same issue happen if you open the file dialog from
e.g. kwrite or kate? (i.e. is it specific to the that KCM or a general issue).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 456208] KMainWindow saves auto settings too often: this can freeze applications

2022-07-07 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456208

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
The link in your post is to a source file in kdelibs, which was split into
multiple repos many years ago, kmainwindow.cpp is now in KXmlGui; do you see
this problem with recent KF5 versions?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 456223] Dolphin closes when copying files to SMB1 Share

2022-07-07 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456223

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
The backtrace isn't complete, please install the necessary debuginfo packages
and provide another backtrace.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 434912] File selector remembers last thumbnail previewed in last selected path

2022-07-05 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434912

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In||5.96
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/a5b354b9c
   ||f350043e106ecd041de595d4fe7
   ||ed27

--- Comment #4 from Ahmad Samir  ---
Git commit a5b354b9cf350043e106ecd041de595d4fe7ed27 by Ahmad Samir.
Committed on 06/07/2022 at 00:21.
Pushed by ahmadsamir into branch 'master'.

KImageFilePreview: if no current preview, don't show last one on resize

Test plan:
- using e.g. the kfilewidgettest_gui app, show the preview panel, and
  select some image or text file, so that a preview is shown
- unselect the file, the preview panel should be blank
- resize the preview panel
FIXED-IN: 5.96

M  +5-0src/filewidgets/kimagefilepreview.cpp

https://invent.kde.org/frameworks/kio/commit/a5b354b9cf350043e106ecd041de595d4fe7ed27

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 452994] Name field doesn't seem to have any history; cannot undo or redo any text changes with Ctrl+Z or Shift+Ctrl+Z

2022-07-03 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=452994

Ahmad Samir  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/331aad501
   ||acea58013a7cf89e18919f94539
   ||4396
 Resolution|--- |FIXED

--- Comment #2 from Ahmad Samir  ---
Git commit 331aad501acea58013a7cf89e18919f945394396 by Ahmad Samir.
Committed on 03/07/2022 at 19:26.
Pushed by ahmadsamir into branch 'master'.

KFileWidget: remove location history dummy-entry related code

This code was used in m_locationEdit ("Name" combobox).

The issue with this code is that it ultimately invokes QLineEdit::setText(),
which resets the undo/redo steps for the text in the lineedit at index -1,
with every key press event.

So we lose one functionality, showing the corresponding icon for the url in
the lineedit, but gain the undo/redo functionality, the latter being a
functionality that is available/expectted in all Qt/KDE lineedits.

0x76b9aa40 in QLineEdit::setText(QString const&)@plt () from
/lib64/libQt5Widgets.so.5
0x76cb8a83 in QComboBoxPrivate::_q_dataChanged (this=0x558f9560,
topLeft=..., bottomRight=...)

0x75e23235 in QAbstractItemModel::dataChanged
(this=this@entry=0x558f9800, _t1=..., _t2=..., _t3=...)
0x766d7780 in QStandardItemModelPrivate::itemChanged (this=, item=item@entry=0x55d8cfe0, roles=...)
0x766d7ff8 in QStandardItem::setData (this=0x55d8cfe0, value=...,
role=)
0x766db16c in QStandardItemModel::setData (role=1, value=...,
index=..., this=0x558f9800)
QStandardItemModel::setData (this=this@entry=0x558f9800, index=...,
value=..., role=role@entry=1)
0x76cb369f in QComboBox::setItemIcon (this=,
index=index@entry=0, icon=...)
0x77f30501 in KFileWidgetPrivate::setDummyHistoryEntry
(this=this@entry=0x556ddbb0, text=..., icon=...,
  usePreviousPixmapIfNull=usePreviousPixmapIfNull@entry=true)

M  +11   -107  src/filewidgets/kfilewidget.cpp

https://invent.kde.org/frameworks/kio/commit/331aad501acea58013a7cf89e18919f945394396

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 455806] Konsole improperly opens links with '!' at the end

2022-07-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455806

--- Comment #7 from Ahmad Samir  ---
The fixes will be in 22.04.3 (which will be released this month
https://community.kde.org/Schedules/KDE_Gear_22.04_Schedule).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 456253] "http://127.0.0.1:4000/" no longer recognized as a single link (including the port)

2022-07-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456253

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 452978 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 452978] URL parsing broken if URL includes port number or comma (or address is IPv6)

2022-07-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=452978

Ahmad Samir  changed:

   What|Removed |Added

 CC||p...@ralfj.de

--- Comment #15 from Ahmad Samir  ---
*** Bug 456253 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kglobalaccel] [Bug 455117] Global shortcut launches terminal application without a terminal

2022-07-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455117

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kglobalaccel/commit/
   ||b72930eb075a79ff89e8db22174
   ||9de978706e5bf
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Ahmad Samir  ---
Git commit b72930eb075a79ff89e8db221749de978706e5bf by Ahmad Samir, on behalf
of Jin Liu.
Committed on 02/07/2022 at 12:26.
Pushed by ahmadsamir into branch 'master'.

Launch app in terminal when Terminal=true

When the desktop file has Terminal=true (e.g. htop), it should be
launched in a terminal.

Instead of calling "kstart5 -- ", this calls
"kstart5 --application " when and only when:
1. kstart5 is available
2. the desktop file is in XDG_DATA_HOME/applications/,
not XDG_DATA_HOME/kglobalaccel/
3. we are launching the desktop file's main group, not other actions

M  +35   -16   src/runtime/kserviceactioncomponent.cpp
M  +3-0src/runtime/kserviceactioncomponent.h

https://invent.kde.org/frameworks/kglobalaccel/commit/b72930eb075a79ff89e8db221749de978706e5bf

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 456204] Zmodem receive feature doesn't work

2022-07-01 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456204

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Could you test with
https://invent.kde.org/utilities/konsole/-/merge_requests/685

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 455166] URL matching regressions

2022-07-01 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455166

--- Comment #12 from Ahmad Samir  ---
Git commit 6e7cf530a8a9ef2676a1b4faf9a06af9f955c5be by Ahmad Samir.
Committed on 01/07/2022 at 15:33.
Pushed by ahmadsamir into branch 'release/22.04'.

Match urls between grave `
FIXED-IN: 22.08

M  +3-0src/autotests/HotSpotFilterTest.cpp
M  +1-1src/filterHotSpots/UrlFilter.cpp

https://invent.kde.org/utilities/konsole/commit/6e7cf530a8a9ef2676a1b4faf9a06af9f955c5be

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 455166] URL matching regressions

2022-07-01 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455166

--- Comment #11 from Ahmad Samir  ---
Git commit e925acc1ca60ef1116fa84cc35328d5accad23c5 by Ahmad Samir, on behalf
of Luis Javier Merino MorĂ¡n.
Committed on 01/07/2022 at 15:33.
Pushed by ahmadsamir into branch 'release/22.04'.

Only recognize URIs with balanced parentheses

To prevent URIs inside parentheses from getting extended to the closing
parenthesis, only recognize URIs with balanced parentheses in regname,
path, query and/or fragment.  We still allow unbalanced parenthesis in
userInfo, since the postfix @ should prevent most ambiguous situations,
and the parenthesis can be part of a password.

M  +13   -0src/autotests/HotSpotFilterTest.cpp
M  +13   -8src/filterHotSpots/UrlFilter.cpp

https://invent.kde.org/utilities/konsole/commit/e925acc1ca60ef1116fa84cc35328d5accad23c5

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 452978] URL parsing broken if URL includes port number or comma (or address is IPv6)

2022-07-01 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=452978

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
   |ities/konsole/commit/3b7e73 |ities/konsole/commit/c8d8ab
   |f54e2b07e658152ff01964d7ef3 |d1b2b8e93cc38b3bedb1b63f697
   |98616cd |91e5882

--- Comment #14 from Ahmad Samir  ---
Git commit c8d8abd1b2b8e93cc38b3bedb1b63f69791e5882 by Ahmad Samir.
Committed on 01/07/2022 at 15:33.
Pushed by ahmadsamir into branch 'release/22.04'.

UrlFilter::FullUrlRegExp matches more valid urls

Add unittest.

This is based on:
https://datatracker.ietf.org/doc/html/rfc3986
FIXED-IN: 22.08

M  +5-0src/autotests/CMakeLists.txt
A  +46   -0src/autotests/HotSpotFilterTest.cpp [License: GPL(v2.0+)]
A  +21   -0src/autotests/HotSpotFilterTest.h [License: GPL(v2.0+)]
M  +45   -3src/filterHotSpots/UrlFilter.cpp
M  +4-1src/filterHotSpots/UrlFilter.h

https://invent.kde.org/utilities/konsole/commit/c8d8abd1b2b8e93cc38b3bedb1b63f69791e5882

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 455166] URL matching regressions

2022-07-01 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455166

--- Comment #10 from Ahmad Samir  ---
(In reply to SvenK from comment #9)
> Another annoying thing which recently changed is that URLs
> http://127.0.0.1:4000/  used to be properly parsed but now are interpreted
> as http://127.0.0.1, i.e. the port is missing. These kind of URLs typically
> appear in static site generators, kubernetes, etc.
> 

That is already fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 456116] Default Profile not loaded on start

2022-06-29 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=456116

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
(In reply to Tobias C. Berner from comment #0)
> SUMMARY
> 
> When configuring konsole for a new user, I created a profile that configures
> the mouse settings like copy-to-selection.
> The profile is set to be default.
> 

If you're not using Konsole GUI itself to set a profile as default, detailed
steps would great here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 297003] Newly created text files are not empty

2022-06-29 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=297003

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/da65b36c7
   ||8644ce39fcb8c2db1b02461644e
   ||b81d
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #20 from Ahmad Samir  ---
Git commit da65b36c78644ce39fcb8c2db1b02461644eb81d by Ahmad Samir, on behalf
of Alain Laporte.
Committed on 29/06/2022 at 11:17.
Pushed by ahmadsamir into branch 'master'.

Add template for empty file

A  +0-0src/new_file_templates/EmptyFile
A  +10   -0src/new_file_templates/EmptyFile.desktop
M  +2-0src/new_file_templates/templates.qrc

https://invent.kde.org/frameworks/kio/commit/da65b36c78644ce39fcb8c2db1b02461644eb81d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 455327] Filename in the text field is not renamed after the selected file is renamed in a file dialog

2022-06-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455327

Ahmad Samir  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/6d47b5869
   ||d4b328614e5e95e97ef66d97009
   ||295e

--- Comment #3 from Ahmad Samir  ---
Git commit 6d47b5869d4b328614e5e95e97ef66d97009295e by Ahmad Samir, on behalf
of Fushan Wen.
Committed on 25/06/2022 at 17:54.
Pushed by ahmadsamir into branch 'master'.

filewidgets: update location text after selected files are renamed

Before this commit, the location text is not updated after the selected
files are renamed.

M  +2-1src/filewidgets/kdiroperator.cpp
M  +9-0src/filewidgets/kdiroperator.h
M  +4-0src/filewidgets/kfilewidget.cpp

https://invent.kde.org/frameworks/kio/commit/6d47b5869d4b328614e5e95e97ef66d97009295e

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 452978] URL parsing broken if URL includes port number or comma (or address is IPv6)

2022-06-22 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=452978

Ahmad Samir  changed:

   What|Removed |Added

 CC||sudd...@gmx.at

--- Comment #13 from Ahmad Samir  ---
*** Bug 455806 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 455806] Konsole improperly opens links with '!' at the end

2022-06-22 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455806

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE
 CC||a.samir...@gmail.com

--- Comment #5 from Ahmad Samir  ---
There were recent changes in the URL parsing code in master, and it looks like
this is fixed already (I tested and the url includes the trailing '!').

*** This bug has been marked as a duplicate of bug 452978 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 453759] KSyntaxHighlighting does not build with a C++20 compiler on Windows

2022-06-15 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=453759

--- Comment #15 from Ahmad Samir  ---
Git commit c070f3338da63feb0f81170608f9c5de76f98e3c by Ahmad Samir.
Committed on 14/06/2022 at 12:00.
Pushed by ahmadsamir into branch 'master'.

Adjust repo's own includes

Use ForwardingHeaders for public headers.

Also only explicitly add the ForwardingHeader dir added to the target
include dirs; because KDECMakeSettings from ECM already sets
CMAKE_INCLUDE_CURRENT_DIR_IN_INTERFACE, so no need to duplicate that
thanks, to Friedrich W. H. Kossebau for pointing that out.

M  +5-5autotests/foldingtest.cpp
M  +5-5autotests/highlighter_benchmark.cpp
M  +3-3autotests/htmlhighlighter_test.cpp
M  +2-2autotests/repository_benchmark.cpp
M  +6-6autotests/repository_test.cpp
M  +1-1autotests/repository_test_base.cpp
M  +1-1autotests/repository_test_base.h
M  +1-1autotests/test-config.h.in
M  +6-6autotests/testhighlighter.cpp
M  +6-6autotests/theme_test.cpp
M  +1-1autotests/wildcardmatcher_test.cpp
M  +4-4examples/codeeditor/codeeditor.cpp
M  +1-1examples/codeeditor/codeeditor.h
M  +3-3examples/codepdfprinter/codepdfprinter.cpp
M  +1-1examples/codepdfprinter/codepdfprinter.h
M  +5-5examples/minimal/main.cpp
M  +4-4src/cli/kate-syntax-highlighter.cpp
M  +7-8src/lib/CMakeLists.txt
M  +2-2src/quick/kquicksyntaxhighlighter.cpp
M  +2-2src/quick/kquicksyntaxhighlighter.h
M  +3-4src/quick/kquicksyntaxhighlightingplugin.cpp
M  +3-3src/quick/repositorywrapper.cpp

https://invent.kde.org/frameworks/syntax-highlighting/commit/c070f3338da63feb0f81170608f9c5de76f98e3c

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kglobalaccel] [Bug 441203] Some PrtScr shortcuts stopped working for existing users

2022-06-15 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=441203

Ahmad Samir  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #4 from Ahmad Samir  ---
What's the exact command that the shortcut is used to launch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 443690] kioslave5 crashed after click to icon in tasks list

2022-06-14 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=443690

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Ahmad Samir  ---
Is this still an issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kglobalaccel] [Bug 441203] Some PrtScr shortcuts stopped working for existing users

2022-06-14 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=441203

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
I can't reproduce this issue; do you still see it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 440289] Icons are missing at startup

2022-06-14 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=440289

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #5 from Ahmad Samir  ---
Does the same issue happen in a new user account?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kservice] [Bug 442721] kf.service.services: KApplicationTrader: mimeType "x-scheme-handler/file" not found

2022-06-14 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=442721

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #14 from Ahmad Samir  ---
https://invent.kde.org/frameworks/kio/-/merge_requests/867

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 297003] Newly created text files are not empty

2022-06-14 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=297003

--- Comment #15 from Ahmad Samir  ---
- Changing the contents of the new text file template based on the extension
would make the code more complex
- The experience would be a bit confusing, you create a "new file" and
sometimes it has a " \n" and sometimes not
- A file without an extension and 0 size has mimetype application/x-zerosize,
and a blank icon

The default template should cater to the typical use case, i.e. a user who
wants to create a simple text file.

Note that you can customize the behaviour:
- Copy
https://invent.kde.org/frameworks/kio/-/blob/master/src/new_file_templates/TextFile.desktop
to the templates dir (by default it's ~/Templates)
- create a dir ~/Templates/.source/, and inside it create a "Text File.txt"
file, put whatever text you want there or make it blank ...etc.

KNewFileMenu will pick that ~/Templates/TextFile.desktop over the one baked
into KIO (as a QResource).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 297003] Newly created text files are not empty

2022-06-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=297003

Ahmad Samir  changed:

   What|Removed |Added

 CC||vincenzo.rom...@notorand.it

--- Comment #14 from Ahmad Samir  ---
*** Bug 446019 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 446019] New text file created with 2 chars

2022-06-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=446019

Ahmad Samir  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #5 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 297003 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448114] kioslave5 crashes when searching in Dolphin

2022-06-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=448114

Ahmad Samir  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||22.04.3
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/netw
   ||ork/kio-extras/commit/f60b3
   ||27c5ab3a48b1eb781a67e553f33
   ||f2ced71a

--- Comment #5 from Ahmad Samir  ---
Git commit f60b327c5ab3a48b1eb781a67e553f33f2ced71a by Ahmad Samir.
Committed on 13/06/2022 at 19:20.
Pushed by ahmadsamir into branch 'master'.

kio_filenamesearch: don't use iterators when searching pending dirs

Looking at the backtrace from the bug report, it looks like the vector
could get reallocated when it changes capacity ...etc, which would
invalidate iterators.

Instead use a FIFO std::queue, since ideally the dirs should be searched in
the same order they're added to the pendingDirs container, and then
removed, and removing from the from of a vector is more costly than with a
queue (which uses a std::deque by default).
FIXED-IN: 22.04.3

M  +6-6filenamesearch/kio_filenamesearch.cpp
M  +2-2filenamesearch/kio_filenamesearch.h

https://invent.kde.org/network/kio-extras/commit/f60b327c5ab3a48b1eb781a67e553f33f2ced71a

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 450727] Can't edit an application's desktop entry which is a symlink

2022-06-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=450727

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In||5.96
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/a4be43231
   ||840a145c808f6ce81217f02f039
   ||35e8
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Ahmad Samir  ---
Git commit a4be43231840a145c808f6ce81217f02f03935e8 by Ahmad Samir.
Committed on 13/06/2022 at 19:19.
Pushed by ahmadsamir into branch 'master'.

KPropertiesDialog: fix saving changes when editing a .desktop file symlink

Consider the use case of:
/usr/share/applications/foo.desktop is symlink to /opt/someapp/foo.desktop

relativeAppsLocation() was using QFile::canonicalFilePath(), which meant
that foo.desktop would resolve to a file outside /usr/share/applications,
since the code, rightly, expects files in QStandardPaths::ApplicationsLocation
locations, m_sRelativePath would end up being empty, which makes the check in
KFilePropsPlugin::slotCopyFinished() fail, and the .desktop file wouldn't
get copied to ~/.local/share/applications/, and the saving would fail.
FIXED-IN: 5.96

M  +5-3src/widgets/kpropertiesdialog.cpp

https://invent.kde.org/frameworks/kio/commit/a4be43231840a145c808f6ce81217f02f03935e8

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kglobalaccel] [Bug 442584] Applications launched by shortcut are displayed in the Plasma System Monitor with the application's running path, not as the application name

2022-06-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=442584

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||a.samir...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Ahmad Samir  ---
Are you specifying the full path to the executable in the shortcut settings? do
these apps have .desktop files?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 434912] File selector remembers last thumbnail previewed in last selected path

2022-06-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434912

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
https://invent.kde.org/frameworks/kio/-/merge_requests/865

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 436637] KIconLoader does not respect QIcon::themeSearchPaths()

2022-06-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436637

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Seems to work here; I test with qtcreator:

QIcon::setThemeSearchPaths(QIcon::themeSearchPaths() <<
"/usr/share/yelp/icons");
QIcon icon = QIcon::fromTheme("yelp-page-task");
qDebug() << icon << QIcon::themeSearchPaths();

QIcon("yelp-page-task",availableSizes[normal,Off]=QList(QSize(16,
16)),cacheKey=0x1) QList("/home/ahmad/.icons",
"/home/ahmad/.local/share/icons", "/usr/local/share/icons", "/usr/share/icons",
":/icons", "/usr/share/yelp/icons")

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kconfig] [Bug 436712] kconfig_compiler generates invalid code

2022-06-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436712

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Seems to work
https://invent.kde.org/frameworks/kconfig/commit/c098a4f105fb6bb0a5a5a89f09e2211b627266dc
(no MR).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kglobalaccel] [Bug 455117] Global shortcut launches terminal application without a terminal

2022-06-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=455117

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/fram |
   |eworks/kconfigwidgets/-/mer |
   |ge_requests/142 |
   Version Fixed In|5.95|

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   5   6   7   8   9   10   >