[dolphin] [Bug 415312] Dolphin crashes when clicking a link on a target that no longer exists or is empty
https://bugs.kde.org/show_bug.cgi?id=415312 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #1 from David Hallas --- This appears to be a duplicate of bug 414227 - could you retest with KDE Frameworks 5.65? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink
https://bugs.kde.org/show_bug.cgi?id=414227 David Hallas changed: What|Removed |Added CC||nda...@tutanota.com --- Comment #6 from David Hallas --- *** Bug 415275 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415275] Crash when going "Back" or "Forward" to a deleted folder
https://bugs.kde.org/show_bug.cgi?id=415275 David Hallas changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED --- Comment #5 from David Hallas --- Just tested with the latest master of KFileMetadata and I can confirm that the issue is fixed. So I will close this bug as a duplicate of 414227. Please retest this once Frameworks 5.66 is out. Thanks for reporting *** This bug has been marked as a duplicate of bug 414227 *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415275] Crash when going "Back" or "Forward" to a deleted folder
https://bugs.kde.org/show_bug.cgi?id=415275 --- Comment #4 from David Hallas --- (In reply to Ismael Asensio from comment #3) > Out of curiosity, do you have information panel open when the crash happens? > It reminds me of https://bugs.kde.org/show_bug.cgi?id=414227, which got > fixed on KFileMetadata on master I can confirm that I can reproduce the problem with the information panel open. I will just retest with the fix you did in KFileMetadata. Thanks for pointing it out ;) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink
https://bugs.kde.org/show_bug.cgi?id=414227 David Hallas changed: What|Removed |Added CC||eddy...@gmail.com --- Comment #5 from David Hallas --- *** Bug 415198 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415198] Dolphin crashes when deleting a file in the "recent" folders
https://bugs.kde.org/show_bug.cgi?id=415198 David Hallas changed: What|Removed |Added Resolution|WAITINGFORINFO |DUPLICATE Status|NEEDSINFO |RESOLVED --- Comment #6 from David Hallas --- After digging a bit, it turns out that this bug has the same root cause as bug 414227, which has already been fixed in commit https://commits.kde.org/kfilemetadata/4bb4195a6fc6841dd9ce1d3f564fc122b6032d86 - so please retest this once Frameworks 5.66 is out. Thanks for reporting the issue :) *** This bug has been marked as a duplicate of bug 414227 *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415198] Dolphin crashes when deleting a file in the "recent" folders
https://bugs.kde.org/show_bug.cgi?id=415198 --- Comment #5 from David Hallas --- Here is a gdb backtrace: Thread 1 "dolphin" received signal SIGSEGV, Segmentation fault. 0x75aa456d in QByteArray::QByteArray(int, Qt::Initialization) () from /usr/lib64/libQt5Core.so.5 (gdb) bt #0 0x75aa456d in QByteArray::QByteArray(int, Qt::Initialization) () from /usr/lib64/libQt5Core.so.5 #1 0x76f8c4dd in ?? () from /usr/lib64/libKF5FileMetaData.so.3 #2 0x7746d89b in ?? () from /usr/lib64/libKF5BalooWidgets.so.5 #3 0x77470c58 in ?? () from /usr/lib64/libKF5BalooWidgets.so.5 #4 0x75c4e6cf in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib64/libQt5Core.so.5 #5 0x75bb6a0f in QProcess::finished(int, QProcess::ExitStatus) () from /usr/lib64/libQt5Core.so.5 #6 0x75bbbf41 in ?? () from /usr/lib64/libQt5Core.so.5 #7 0x75bbc159 in ?? () from /usr/lib64/libQt5Core.so.5 #8 0x75c4e58b in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib64/libQt5Core.so.5 #9 0x75c598b8 in QSocketNotifier::activated(int, QSocketNotifier::QPrivateSignal) () from /usr/lib64/libQt5Core.so.5 #10 0x75c59c01 in QSocketNotifier::event(QEvent*) () from /usr/lib64/libQt5Core.so.5 #11 0x76610431 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib64/libQt5Widgets.so.5 #12 0x76617840 in QApplication::notify(QObject*, QEvent*) () from /usr/lib64/libQt5Widgets.so.5 #13 0x75c261d1 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib64/libQt5Core.so.5 #14 0x75c77ac6 in ?? () from /usr/lib64/libQt5Core.so.5 #15 0x7426cb12 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0 #16 0x7426cda0 in ?? () from /usr/lib64/libglib-2.0.so.0 #17 0x7426ce2f in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0 #18 0x75c77173 in QEventDispatcherGlib::processEvents(QFlags) () from /usr/lib64/libQt5Core.so.5 #19 0x75c250d3 in QEventLoop::exec(QFlags) () from /usr/lib64/libQt5Core.so.5 #20 0x75c2cdd2 in QCoreApplication::exec() () from /usr/lib64/libQt5Core.so.5 #21 0x77ec48a2 in kdemain (argc=1, argv=0x7fffd6e8) at ../src/main.cpp:188 #22 0x5187 in main (argc=1, argv=0x7fffd6e8) at src/dolphin_dummy.cpp:3 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415198] Dolphin crashes when deleting a file in the "recent" folders
https://bugs.kde.org/show_bug.cgi?id=415198 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #4 from David Hallas --- I can reproduce the crash by doing the following: 1. Navigate to Recent Locations 2. Delete a folder by selecting the folder and pressing the Delete key on the keyboard 3. Hover the mouse over the now deleted folder I think the key here is the hovering part, because it seems like Dolphin doesn't realize that the folder has been deleted, since it doesn't disappear. So when I do a Mouse Over it tries to fetch metadata from the folder and then crashes. I will try and get a coredump and attach the information here. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415275] Crash when going "Back" or "Forward" to a deleted folder
https://bugs.kde.org/show_bug.cgi?id=415275 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #1 from David Hallas --- I have just tested this with Dolphin 19.12 and I cannot reproduce the crash :/ I use the navigation buttons in the UI, have you tried those? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 410945] KProcessList::processInfo(qint64 pid) iterates through all processes only to filter them
https://bugs.kde.org/show_bug.cgi?id=410945 David Hallas changed: What|Removed |Added Latest Commit||https://commits.kde.org/kco ||readdons/e16dda4d50bf9e51f1 ||ec1f388f1267bda1c89417 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #4 from David Hallas --- Git commit e16dda4d50bf9e51f1ec1f388f1267bda1c89417 by David Hallas. Committed on 15/12/2019 at 06:53. Pushed by hallas into branch 'master'. [KProcessList] Optimize KProcessList::processInfo Summary: Optimize KProcessList::processInfo on unix so that it doesn't iterate over all processes and then filter the list to the requested process. Instead refactor the code that fetches process info from a single process and use that function. Test Plan: Unit Test Reviewers: davidedmundson, broulik, mpyne Reviewed By: mpyne Subscribers: mpyne, apol, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D23205 M +0-15 src/lib/util/kprocesslist.cpp M +64 -51 src/lib/util/kprocesslist_unix.cpp M +15 -0src/lib/util/kprocesslist_win.cpp https://commits.kde.org/kcoreaddons/e16dda4d50bf9e51f1ec1f388f1267bda1c89417 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 398908] Dolphin uses up huge amounts of memory
https://bugs.kde.org/show_bug.cgi?id=398908 --- Comment #38 from David Hallas --- I am still trying to reproduce this locally, and lately I have been using the excellent Heaptrack (https://milianw.de/blog/heaptrack-a-heap-memory-profiler-for-linux.html) tool to look at Dolphins memory usage, but I still haven't been able to pinpoint any code that keeps consuming memory. The tool reports some minor leaks, but they all appear to be one-off allocations, so they shouldn't cause the heap to grow over time. I was thinking if it would be possible for one of you who is able to reproduce the problem to use the tool to dump what is using memory and share the results here? This page has details and how to clone, build, install and run it: https://milianw.de/blog/heaptrack-a-heap-memory-profiler-for-linux.html -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking
https://bugs.kde.org/show_bug.cgi?id=189302 David Hallas changed: What|Removed |Added Version Fixed In||19.12.0 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking
https://bugs.kde.org/show_bug.cgi?id=189302 David Hallas changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/dol ||phin/c3b914a7faed3a7c0195ae ||77b40204cbc8d31fe5 Status|ASSIGNED|RESOLVED --- Comment #18 from David Hallas --- Git commit c3b914a7faed3a7c0195ae77b40204cbc8d31fe5 by David Hallas. Committed on 27/10/2019 at 05:52. Pushed by hallas into branch 'master'. Unmounting busy device doesn't tell who is blocking Summary: Unmounting a busy device from the places panel doesn't tell which applications have open files blocking the unmount. Test Plan: Mount a USB stick using Dolphin Open a file from the USB stick Unmount the USB stick using Dolphin Observe the new error message. Reviewers: #dolphin, elvisangelaccio, ngraham, broulik, meven Reviewed By: #dolphin, elvisangelaccio, meven Subscribers: meven, davidedmundson, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19989 M +1-1CMakeLists.txt M +1-0src/CMakeLists.txt M +25 -1src/panels/places/placesitemmodel.cpp https://commits.kde.org/dolphin/c3b914a7faed3a7c0195ae77b40204cbc8d31fe5 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 157819] Missing back and forward history
https://bugs.kde.org/show_bug.cgi?id=157819 David Hallas changed: What|Removed |Added Latest Commit||https://commits.kde.org/dol ||phin/eec49bc38f4e256b66bf16 ||ee5428c5f5d7e97e25 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Version Fixed In||19.12.0 --- Comment #15 from David Hallas --- Git commit eec49bc38f4e256b66bf16ee5428c5f5d7e97e25 by David Hallas. Committed on 29/09/2019 at 12:16. Pushed by hallas into branch 'master'. Add navigation history to forward/back buttons Summary: Adds navigation history to forward/back buttons in the toolbar. This changes the forward/back buttons in the toolbar to use the KToolBarPopupAction class which provides access to a drop down menu. Test Plan: Browse some folders Click the back drop down menu and navigate somewhere Click the forward drop down menu and navigate somewhere FIXED-IN: 19.12.0 Reviewers: #dolphin, ngraham, elvisangelaccio, #vdg Reviewed By: #dolphin, ngraham, elvisangelaccio, #vdg Subscribers: felixernst, nerdopolist, mart, richardl, ognarb, david.fontanals, abetts, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19311 M +88 -5src/dolphinmainwindow.cpp M +34 -0src/dolphinmainwindow.h M +26 -9src/middleclickactioneventfilter.cpp https://commits.kde.org/dolphin/eec49bc38f4e256b66bf16ee5428c5f5d7e97e25 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 398908] Dolphin uses up huge amounts of memory
https://bugs.kde.org/show_bug.cgi?id=398908 --- Comment #32 from David Hallas --- (In reply to Knut Hildebrandt from comment #31) > Hi David, > > (In reply to David Hallas from comment #30) > > Another thing, have you tested with the latest released Dolphin? > I'm using Dolphin 19.04.3, the latest my distribution - Chakra - offers. > > This is my setup: > > Operating System: > KDE Plasma Version: 5.16.3 > KDE Frameworks Version: 5.60.0 > Qt Version: 5.12.4 > Kernel Version: 4.19.26-1-CHAKRA > OS Type: 64-bit > Processors: 4 × Intel® Core™ i5-3317U CPU @ 1.70GHz > Memory: 9,6 GiB > Swap: 20 GB > > I noticed one more thing. Dolphin always uses much CPU time when the machine > starts swapping. Usually this happens due to Dolphin using more memory for > some reason, but sometimes because other programs use up memory. > > BTW, my system is fully encrypted, all partitions except /boot. And I'm > using an 1 TB SSD. > > And I have one question. Could I somehow provide data about the swapping > behavior or other internal processes of Dolphin that might lead to the cause > of the problem? If so, how? Hi Knut, thanks for providing info, I am trying to replicate the setup on my local machine, hopefully I will be able to reproduce the problem. I don't know what other info you could provide that would help narrow down the problem, I am still a bit puzzled here :) But, it is super nice that you keep being so responsive on the bug report, that always helps :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 398908] Dolphin uses up huge amounts of memory
https://bugs.kde.org/show_bug.cgi?id=398908 --- Comment #30 from David Hallas --- Hi Knut, sorry, but I haven't made any progress on this (yet). I have tried stressing Dolphin in various ways, but I have been unable to reproduce the issue. I think the main reason may be that I haven't installed kdenlive, or have any kdenlive files, so I think I will try with that and see if it makes a difference. Another thing, have you tested with the latest released Dolphin? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 410945] KProcessList::processInfo(qint64 pid) iterates through all processes only to filter them
https://bugs.kde.org/show_bug.cgi?id=410945 --- Comment #3 from David Hallas --- I forget to mention this bugreport in the patch commit message :/ https://phabricator.kde.org/D23205 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 410945] KProcessList::processInfo(qint64 pid) iterates through all processes only to filter them
https://bugs.kde.org/show_bug.cgi?id=410945 David Hallas changed: What|Removed |Added Ever confirmed|0 |1 Assignee|mp...@kde.org |da...@davidhallas.dk Status|REPORTED|ASSIGNED --- Comment #2 from David Hallas --- Yeah I see :) I am working on a fix -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 408603] Konsole crash when coping highlighted text
https://bugs.kde.org/show_bug.cgi?id=408603 --- Comment #8 from David Hallas --- (In reply to Kurt Hindenburg from comment #7) > Thanks, so far it looks good. > > I'm not clear on why when searching the links are no longer valid (no > open/copy url, email, etc) even when the links are not highlighted. > Although not really related to this crash or fix. Me neither :/ I think in general there are a bit too many raw pointers in this code for my taste :) It would be nice to work towards changing them to more safer alternatives. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 408603] Konsole crash when coping highlighted text
https://bugs.kde.org/show_bug.cgi?id=408603 --- Comment #6 from David Hallas --- I have pushed a review that fixes this crash: https://phabricator.kde.org/D21849 I have tested quite a bit with this patch and haven't seen any crashes or leaks, but please give it a thorough test as well, just to be sure. I don't want to introduce any other regressions :D And thanks for reporting the issue! -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 408603] Konsole crash when coping highlighted text
https://bugs.kde.org/show_bug.cgi?id=408603 David Hallas changed: What|Removed |Added Assignee|konsole-de...@kde.org |da...@davidhallas.dk Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking
https://bugs.kde.org/show_bug.cgi?id=189302 --- Comment #16 from David Hallas --- (In reply to ncdehnel from comment #15) > Ok, I see, it doesn't work with NFS shares, only USB devices. Suppose it > would be possible to fix that? It might ;D How do you tell which files are keeping a mount blocked for a NFS mount? Wouldn't lsof provide the information we are looking for? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking
https://bugs.kde.org/show_bug.cgi?id=189302 --- Comment #13 from David Hallas --- (In reply to ncdehnel from comment #12) > (In reply to David Hallas from comment #11) > > I have a patch in review that implements this: > > > > https://phabricator.kde.org/D19989 > > > > Please test, review and provide feedback :D > > How do you get the device notifier to show what's using the volume? We are simply using lsof :D Currrently the patch is being split up and put into the appropriate places in the KDE stack, therefore this process is taken a little more time. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403064] Dolphin crashes when hiding device from device tab
https://bugs.kde.org/show_bug.cgi?id=403064 David Hallas changed: What|Removed |Added Version Fixed In||19.08.0 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403064] Dolphin crashes when hiding device from device tab
https://bugs.kde.org/show_bug.cgi?id=403064 David Hallas changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/dol ||phin/78540e49213ed1a03687d5 ||5063816659c9142eba --- Comment #7 from David Hallas --- Git commit 78540e49213ed1a03687d55063816659c9142eba by David Hallas. Committed on 13/05/2019 at 14:58. Pushed by hallas into branch 'master'. Summary: Fixes crash when hiding devices Summary: Fixes crash when hiding devices. The crash is caused by KStandardItem::setDataValue which calls the KStandardItemModel::onItemChanged function, and that function will delete the KStandardItem if the data value being set is the hidden attribute being set to true. To fix this KStandardItem now derives QObject so that we can use deleteLater. Test Plan: Right click a device in the places panel and select hide Right click the places panel and select show hidden Right click the hidden device and select show Right click the same device and select hide Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21050 M +3-30 src/kitemviews/kstandarditem.cpp M +3-11 src/kitemviews/kstandarditem.h M +1-1src/kitemviews/kstandarditemmodel.cpp https://commits.kde.org/dolphin/78540e49213ed1a03687d55063816659c9142eba -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 171366] add bookmarks on dolphin
https://bugs.kde.org/show_bug.cgi?id=171366 David Hallas changed: What|Removed |Added Version Fixed In||19.08.0 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 171366] add bookmarks on dolphin
https://bugs.kde.org/show_bug.cgi?id=171366 David Hallas changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://commits.kde.org/dol ||phin/2fac50f5f59bbbc58a59e7 ||ab5f1ec4e371a604c6 Resolution|--- |FIXED --- Comment #40 from David Hallas --- Git commit 2fac50f5f59bbbc58a59e7ab5f1ec4e371a604c6 by David Hallas. Committed on 13/05/2019 at 14:37. Pushed by hallas into branch 'master'. Add Bookmark Handling Summary: Add Bookmark Handling. Adds complete bookmark support as provided by other KDE applications like Konsole and Konqueror. This allows you to bookmark individual folders, create bookmark folders and open them. Test Plan: Go -> Bookmark -> Add Bookmark Go -> Bookmark -> [Open the bookmark you selected] Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ognarb, meven, loh.tar, cfeck, hein, kfm-devel Tags: #dolphin Maniphest Tasks: T5408 Differential Revision: https://phabricator.kde.org/D19926 M +1-0src/CMakeLists.txt A +135 -0src/dolphinbookmarkhandler.cpp [License: GPL (v2+)] A +61 -0src/dolphinbookmarkhandler.h [License: GPL (v2+)] M +20 -0src/dolphinmainwindow.cpp M +18 -10 src/dolphinmainwindow.h M +2-1src/dolphinui.rc https://commits.kde.org/dolphin/2fac50f5f59bbbc58a59e7ab5f1ec4e371a604c6 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 398908] Dolphin uses up huge amounts of memory
https://bugs.kde.org/show_bug.cgi?id=398908 --- Comment #18 from David Hallas --- I have been running a Dolphin instance with valgrinds massif tool to profile the heap usage and the only large increase I can see is from VLC, so I think this is caused by one of the preview plugins. But I will keep digging... -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 398908] Dolphin uses up huge amounts of memory
https://bugs.kde.org/show_bug.cgi?id=398908 --- Comment #13 from David Hallas --- Thanks a lot for all the info! I have been trying to reproduce this issue for some time now and I am not sure I can. But I have been leaving an instance of Dolphin running on my machine for 2 days now, and I can actually see a rise in memory usage. It is not as big as the increase you see but it does use more memory over time. Currently I am at 41MB and 2 days ago it was 25MB and I haven't use the Dolphin instance at all (though I have been using the PC, so it might have something to do with filesystem monitoring). But I will keep digging, and again if you find more exact patterns please post keep posting them :D -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 175051] mount .iso option in context menu
https://bugs.kde.org/show_bug.cgi?id=175051 --- Comment #25 from David Hallas --- No problem, I will take a stab at it then :D -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 398908] Dolphin uses up huge amounts of memory
https://bugs.kde.org/show_bug.cgi?id=398908 --- Comment #9 from David Hallas --- I have also tried to reproduced this over the past few days, but still unable to :/ Currently dolphin uses about 25MB with 10 tabs open showing hundreds of files with previews. But I do not have suspend enabled on my system, so I can't test how it reacts to that, but I will leave it running over night and see if the memory usage increases. If you can narrow down any repro steps it would certainly help us a lot :D -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 175051] mount .iso option in context menu
https://bugs.kde.org/show_bug.cgi?id=175051 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #23 from David Hallas --- (In reply to Luca Carlon from comment #21) > What about using fuseiso as suggested, and make dolphin also list fuse > mounts? I may try to propose a patch if there is nothing against it. Actually I was also about to start looking into listing fuse mounts in Dolphin as well :D But if you are working on it I will wait for now. Please ping when/if you patches for this I will be happy to help out as much as possible. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 403114] konsole crash when input is copied across multiple tabs
https://bugs.kde.org/show_bug.cgi?id=403114 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #3 from David Hallas --- This appears to be a duplicate of bug 405158 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403064] Dolphin crashes when hiding device from device tab
https://bugs.kde.org/show_bug.cgi?id=403064 David Hallas changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |da...@davidhallas.dk Status|CONFIRMED |ASSIGNED --- Comment #6 from David Hallas --- I have pushed a fix for it here: https://phabricator.kde.org/D20024 Please test and report if it fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403064] Dolphin crashes when hiding device from device tab
https://bugs.kde.org/show_bug.cgi?id=403064 David Hallas changed: What|Removed |Added Ever confirmed|0 |1 CC||da...@davidhallas.dk Status|REPORTED|CONFIRMED --- Comment #5 from David Hallas --- I can reproduce the crash if I do the following: 1. Right click a device in the places panel and select hide 2. Right click the places panel and select show hidden 3. Right click the hidden device and select show 4. Right click the same device and select hide This is the output I get from address sanitizer: = ==10758==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d000661db8 at pc 0x7f11e094c809 bp 0x7fffc2009310 sp 0x7fffc2009300 READ of size 8 at 0x60d000661db8 thread T0 #0 0x7f11e094c808 in KStandardItem::setDataValue(QByteArray const&, QVariant const&) ../src/kitemviews/kstandarditem.cpp:118 #1 0x7f11e222b1a8 in PlacesItem::setHidden(bool) ../src/panels/places/placesitem.cpp:96 #2 0x7f11e221cb94 in PlacesPanel::slotItemContextMenuRequested(int, QPointF const&) ../src/panels/places/placespanel.cpp:260 #3 0x7f11e222905a in QtPrivate::FunctorCall, QtPrivate::List, void, void (PlacesPanel::*)(int, QPointF const&)>::call(void (PlacesPanel::*)(int, QPointF const&), PlacesPanel*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:134 #4 0x7f11e2228621 in void QtPrivate::FunctionPointer::call, void>(void (PlacesPanel::*)(int, QPointF const&), PlacesPanel*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:167 #5 0x7f11e222769b in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:396 #6 0x7f11d919c96e in QMetaObject::activate(QObject*, int, int, void**) (/usr/lib64/libQt5Core.so.5+0x26796e) #7 0x7f11e0a73a39 in KItemListController::itemContextMenuRequested(int, QPointF const&) src/dolphinprivate_autogen/Z3MQH7AOBD/moc_kitemlistcontroller.cpp:449 #8 0x7f11e08d7199 in KItemListController::mousePressEvent(QGraphicsSceneMouseEvent*, QTransform const&) ../src/kitemviews/kitemlistcontroller.cpp:624 #9 0x7f11e08dc2c4 in KItemListController::processEvent(QEvent*, QTransform const&) ../src/kitemviews/kitemlistcontroller.cpp:1038 #10 0x7f11e08fbaf1 in KItemListView::event(QEvent*) ../src/kitemviews/kitemlistview.cpp:923 #11 0x7f11da2f9d8b in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x15ad8b) #12 0x7f11da30134e in QApplication::notify(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x16234e) #13 0x7f11d91753a0 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (/usr/lib64/libQt5Core.so.5+0x2403a0) #14 0x7f11da5ff8c2 (/usr/lib64/libQt5Widgets.so.5+0x4608c2) #15 0x7f11da5ffcb1 (/usr/lib64/libQt5Widgets.so.5+0x460cb1) #16 0x7f11da607cea (/usr/lib64/libQt5Widgets.so.5+0x468cea) #17 0x7f11da607f28 in QGraphicsScene::mousePressEvent(QGraphicsSceneMouseEvent*) (/usr/lib64/libQt5Widgets.so.5+0x468f28) #18 0x7f11da60f1cf in QGraphicsScene::event(QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x4701cf) #19 0x7f11da2f9d8b in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x15ad8b) #20 0x7f11da30134e in QApplication::notify(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x16234e) #21 0x7f11d91753a0 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (/usr/lib64/libQt5Core.so.5+0x2403a0) #22 0x7f11da62bda3 in QGraphicsView::mousePressEvent(QMouseEvent*) (/usr/lib64/libQt5Widgets.so.5+0x48cda3) #23 0x7f11da33941e in QWidget::event(QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x19a41e) #24 0x7f11da3dab3d in QFrame::event(QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x23bb3d) #25 0x7f11da62d04a in QGraphicsView::viewportEvent(QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x48e04a) #26 0x7f11d91751ed in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (/usr/lib64/libQt5Core.so.5+0x2401ed) #27 0x7f11da2f9d64 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x15ad64) #28 0x7f11da301ee6 in QApplication::notify(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x162ee6) #29 0x7f11d91753a0 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (/usr/lib64/libQt5Core.so.5+0x2403a0) #30 0x7f11da300831 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) (/usr/lib64/libQt5Widgets.so.5+0x161831) #31 0x7f11da353ac2 (/usr/lib64/libQt5Widgets.so.5+0x1b4ac2) #32 0x7f11da356088 (/usr/lib64/libQt5Widgets.so.5+0x1b7088) #33 0x7f11da2f9d8b in QApplicationPrivate::notify_helper(QObject*, QEvent*)
[dolphin] [Bug 404858] "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark
https://bugs.kde.org/show_bug.cgi?id=404858 --- Comment #16 from David Hallas --- (In reply to Patrick Silva from comment #15) > it's fixed on Arch Linux running dolphin 19.04 beta \o/ Great! Thanks for testing and commenting :D -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking
https://bugs.kde.org/show_bug.cgi?id=189302 David Hallas changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |da...@davidhallas.dk Status|CONFIRMED |ASSIGNED CC||da...@davidhallas.dk --- Comment #11 from David Hallas --- I have a patch in review that implements this: https://phabricator.kde.org/D19989 Please test, review and provide feedback :D -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 368287] Dolphin crashed while moving files to directory on NTFS/FAT file system owned by another user [KIO::FileCopyJob::slotResult]
https://bugs.kde.org/show_bug.cgi?id=368287 --- Comment #35 from David Hallas --- (In reply to Johann R from comment #34) > Created attachment 118953 [details] > New crash information added by DrKonqi > > dolphin (17.12.3) using Qt 5.9.5 > > - What I was doing when the application crashed: > > Moving a folder from an NTFS usb key to a ntfs hdd partition. > > -- Backtrace (Reduced): > #6 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 > #7 0x7f87759a8801 in __GI_abort () at abort.c:79 > #8 0x7f877599839a in __assert_fail_base (fmt=0x7f87760b4f2c > "%s%s%s\302\240:%u\302\240:\302\240%s%s l'assertion > \302\253\302\240%s\302\240\302\273 a \303\251chou\303\251.\n%n", > assertion=assertion@entry=0x7f8774032650 "!q->hasSubjobs()", > file=file@entry=0x7f8774033a70 > "/build/kio-3qUw81/kio-5.44.0/src/core/copyjob.cpp", line=line@entry=1467, > function=function@entry=0x7f8774032c40 "void > KIO::CopyJobPrivate::slotResultErrorCopyingFiles(KJob*)") at assert.c:92 > #9 0x7f8775998412 in __GI___assert_fail (assertion=0x7f8774032650 > "!q->hasSubjobs()", file=0x7f8774033a70 > "/build/kio-3qUw81/kio-5.44.0/src/core/copyjob.cpp", line=1467, > function=0x7f8774032c40 "void > KIO::CopyJobPrivate::slotResultErrorCopyingFiles(KJob*)") at assert.c:101 > [...] > #12 0x7f8773f6f8db in KIO::CopyJob::slotResult(KJob*) () from > /usr/lib/x86_64-linux-gnu/libKF5KIOCore.so.5 Hi Johann, thanks for the bug report, but could you retest with Frameworks 5.56.0 since this bug has been fixed in that version? Thanks -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 171366] add bookmarks on dolphin
https://bugs.kde.org/show_bug.cgi?id=171366 David Hallas changed: What|Removed |Added Status|CONFIRMED |ASSIGNED Assignee|dolphin-bugs-n...@kde.org |da...@davidhallas.dk CC||da...@davidhallas.dk --- Comment #39 from David Hallas --- A patch is in review for this feature: https://phabricator.kde.org/D19926 Please test and give feedback :D -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 404858] "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark
https://bugs.kde.org/show_bug.cgi?id=404858 David Hallas changed: What|Removed |Added Version Fixed In||19.04.0 --- Comment #12 from David Hallas --- Fix has been merged to Applications/19.04 and master. Please test and report any issues :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 404858] "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark
https://bugs.kde.org/show_bug.cgi?id=404858 David Hallas changed: What|Removed |Added Latest Commit||https://commits.kde.org/dol ||phin/508dc815c75c9db8abaec2 ||6ae664ae41bf7f89b5 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #11 from David Hallas --- Git commit 508dc815c75c9db8abaec26ae664ae41bf7f89b5 by David Hallas. Committed on 17/03/2019 at 18:11. Pushed by hallas into branch 'Applications/19.04'. Fix "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark Summary: Fix "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark. The fix is taken from D19596. Test Plan: Open Dolphin with the Breeze theme Hover the mouse over the "Add Network Folder" The icon is black on black Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19738 M +17 -2src/views/tooltips/tooltipmanager.cpp https://commits.kde.org/dolphin/508dc815c75c9db8abaec26ae664ae41bf7f89b5 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 157819] Missing back and forward history
https://bugs.kde.org/show_bug.cgi?id=157819 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk Status|CONFIRMED |ASSIGNED Assignee|dolphin-bugs-n...@kde.org |da...@davidhallas.dk --- Comment #14 from David Hallas --- I have a WIP patch cooking here: https://phabricator.kde.org/D19311 Feedback is _very_ welcome ;) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 405449] Dolphin crashes when transfering files from a disk to another with different FS
https://bugs.kde.org/show_bug.cgi?id=405449 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #1 from David Hallas --- This looks like the same bug as #368287 - Could you try and reproduce the issue with Frameworks 5.56.0? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 404858] "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark
https://bugs.kde.org/show_bug.cgi?id=404858 David Hallas changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |da...@davidhallas.dk Status|CONFIRMED |ASSIGNED --- Comment #10 from David Hallas --- I have a fix in review here: https://phabricator.kde.org/D19738 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 404858] "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark
https://bugs.kde.org/show_bug.cgi?id=404858 --- Comment #9 from David Hallas --- (In reply to Nate Graham from comment #8) > For reference: > https://cgit.kde.org/kinfocenter.git/commit/ > ?id=23fa369831709f43a3100476b00ced10a1123f7f Thanks for the quick reply :D - i'll try and take a look at it. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 404858] "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark
https://bugs.kde.org/show_bug.cgi?id=404858 --- Comment #7 from David Hallas --- (In reply to Kai Uwe Broulik from comment #6) > Doesn't it just get a QIcon/iconName? So colorizing it should be possible > like Marco did for that other tooltip stuff just now Hi Kai, thanks for the reply :) Could you give some more specific pointers for this? Do you have any working samples for this? I still haven't figured out how this is handled for Breeze Dark, does it simply have a white version of the icon? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 405158] Konsole Crashes When Logging Out All Tabs in a Window Using "Copy Input To" Feature
https://bugs.kde.org/show_bug.cgi?id=405158 David Hallas changed: What|Removed |Added Ever confirmed|0 |1 Assignee|konsole-de...@kde.org |da...@davidhallas.dk Status|REPORTED|ASSIGNED CC||da...@davidhallas.dk --- Comment #1 from David Hallas --- Added a patch that fixes the crash https://phabricator.kde.org/D19642 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 391699] Dolphin crashes when it can't move files (permissions, etc)
https://bugs.kde.org/show_bug.cgi?id=391699 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #14 from David Hallas --- This looks like a duplicate of 368287 and that should be fixed with Frameworks 5.56.0. Can you please retest with that version? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403690] new tab should be opened after the current tab in tab list, not at the end
https://bugs.kde.org/show_bug.cgi?id=403690 --- Comment #20 from David Hallas --- I have just landed the last commit that implements this behavior in Dolphin. Please test it out and report any issues :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403690] new tab should be opened after the current tab in tab list, not at the end
https://bugs.kde.org/show_bug.cgi?id=403690 David Hallas changed: What|Removed |Added Latest Commit|https://commits.kde.org/dol |https://commits.kde.org/dol |phin/17af8ae0ad9092e2f64f8f |phin/e602e532c0f7c023db097d |b612ac39d3b078a266 |0eac50a9d7a652b2d1 Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #19 from David Hallas --- Git commit e602e532c0f7c023db097d0eac50a9d7a652b2d1 by David Hallas. Committed on 09/03/2019 at 11:11. Pushed by hallas into branch 'master'. New tab placed after current tab when middle-clicking Summary: New tabs should be placed after the currently active tab when using middle click. Test Plan: Open new tab from the places panel using middle click, verify that the Open new tab from the folders panel using middle click, verify that the tab is opened after the current tab Open new tab by middle clicking on the Back button, verify that the tab is opened after the current tab Open new tab by middle clicking on the Forward button, verify that the tab is opened after the current tab Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19201 M +22 -13 src/dolphinmainwindow.cpp M +12 -1src/dolphinmainwindow.h M +3-3src/views/dolphinview.cpp M +2-1src/views/dolphinview.h https://commits.kde.org/dolphin/e602e532c0f7c023db097d0eac50a9d7a652b2d1 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 404858] "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark
https://bugs.kde.org/show_bug.cgi?id=404858 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #4 from David Hallas --- (In reply to Nate Graham from comment #3) > The icon itself (folder-new) is fully capable of changing its color, so the > problem here must be that Dolphin's tooltip isn't invoking that behavior > properly. I have been looking into this issue a bit and I can't figure out where the "icon changing color" process should happen? I can see that Dolphin calls the KIO::PreviewJob function, this creates a PreviewJob which ends up determining that it should use the textthumbnail plugin to generate the thumbnail. But the textthumbnail plugin bails out because it is a .desktop file, so the original image is just used, which is black on white background. So Nate, do you have some pointers to where this color changing should happen? Could this simply be the mime type for the Add Network Location desktop entry? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 364039] Dolphin crashed on file transfer
https://bugs.kde.org/show_bug.cgi?id=364039 --- Comment #76 from David Hallas --- A fix has been merged for bug #368287 which looks very similar to this. So please retest with frameworks 5.56.0 once it is released and report of it solves this issue. Otherwise please report new crash information :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 368287] Dolphin crashed while moving files to directory on NTFS/FAT file system owned by another user [KIO::FileCopyJob::slotResult]
https://bugs.kde.org/show_bug.cgi?id=368287 David Hallas changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||5.56.0 Resolution|--- |FIXED --- Comment #30 from David Hallas --- A fix has been merged and should be part of the 5.56.0 frameworks release. Diff: https://phabricator.kde.org/D19170 Commit: 3f3c6d30b7399758ef8c6cbb03f4ed00cbd33905 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 378051] crash when you drag file from trash to trash
https://bugs.kde.org/show_bug.cgi?id=378051 David Hallas changed: What|Removed |Added Version Fixed In||5.56.0 --- Comment #11 from David Hallas --- This should be fixed in Framework 5.56.0 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 378051] crash when you drag file from trash to trash
https://bugs.kde.org/show_bug.cgi?id=378051 David Hallas changed: What|Removed |Added Latest Commit||https://commits.kde.org/kio ||/f56af9e2ea0aa61d3faa9c57aa ||477016b1223f96 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #10 from David Hallas --- Git commit f56af9e2ea0aa61d3faa9c57aa477016b1223f96 by David Hallas. Committed on 25/02/2019 at 10:07. Pushed by hallas into branch 'master'. Fix crash in Dolphin when dropping trashed file in trash Summary: Fix crash in Dolphin when dropping trashed file in trash. The actual crash happens because of an assertion failure in kcoredirlister_p.h:308 and this is triggered from kcoredirlister.cpp:995. What actually happens is that the dropjob determines that it should perform a move action which ends up being a rename operation for kio_trash. But it ends up moving the file to itself and this triggers the above crash. The solution is to error out in the dropjob with a KIO::ERR_DROP_ON_ITSELF error so that the user can see that it doesn't make sense to drop a file from the trash inside the trash again. Test Plan: Put a file in trash Drag and drop the file to the trash Reviewers: #frameworks, elvisangelaccio, ngraham, dfaure Reviewed By: dfaure Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19168 M +25 -0autotests/dropjobtest.cpp M +4-0src/widgets/dropjob.cpp https://commits.kde.org/kio/f56af9e2ea0aa61d3faa9c57aa477016b1223f96 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 364039] Dolphin crashed on file transfer
https://bugs.kde.org/show_bug.cgi?id=364039 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #74 from David Hallas --- This looks _very_ similar to #368287 - should we mark it is duplicate? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403690] new tab should be opened after the current tab in tab list, not at the end
https://bugs.kde.org/show_bug.cgi?id=403690 --- Comment #14 from David Hallas --- I have pushed this commit that should implement all the cases: https://phabricator.kde.org/D19201 Please test it out and let me know if there is any issues or missing cases. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403690] new tab should be opened after the current tab in tab list, not at the end
https://bugs.kde.org/show_bug.cgi?id=403690 --- Comment #12 from David Hallas --- I can see from the code that you can actually middle-click on the back/forward/up buttons in the toolbar to open in a new tab - so should these also open next to the currently open tab? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403690] new tab should be opened after the current tab in tab list, not at the end
https://bugs.kde.org/show_bug.cgi?id=403690 --- Comment #11 from David Hallas --- (In reply to vini.ipsmaker from comment #10) > > Is there any other places where you can use middle-clock to open folders in > > tabs where they are placed wrong? > > You mean like clicking on the left panel shortcuts? Yes, this is another > place to pay attention. > > Or you mean like other shortcuts you missed? I don't think so. There is just > this middle-click thing that I'm aware of. Yes that is what I meant :) So in general we should have a consistent navigation scheme so I just want to make sure that I haven't missed any other places where middle-clicking means opening in another tab and that should put the tab next to the currently open tab. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403690] new tab should be opened after the current tab in tab list, not at the end
https://bugs.kde.org/show_bug.cgi?id=403690 David Hallas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #9 from David Hallas --- I didn't know that shortcut ;) But yes I think that makes sense. Is there any other places where you can use middle-clock to open folders in tabs where they are placed wrong? Nate - do you have any comments on this? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 368287] Dolphin crashed while moving files to directory on NTFS/FAT file system owned by another user [KIO::FileCopyJob::slotResult]
https://bugs.kde.org/show_bug.cgi?id=368287 --- Comment #29 from David Hallas --- I have pushed a patch that calls isAutoDelete prior to emitting the result signal. Could someone please see if it fixes the problem? https://phabricator.kde.org/D19170 Thanks :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 378051] crash when you drag file from trash to trash
https://bugs.kde.org/show_bug.cgi?id=378051 --- Comment #9 from David Hallas --- Pushed the following fix: https://phabricator.kde.org/D19168 Please test it out :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 402784] Dolphin crashes during shutdown, when stopping activity
https://bugs.kde.org/show_bug.cgi?id=402784 --- Comment #12 from David Hallas --- Should be there now :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 402784] Dolphin crashes during shutdown, when stopping activity
https://bugs.kde.org/show_bug.cgi?id=402784 David Hallas changed: What|Removed |Added Latest Commit|https://commits.kde.org/dol |https://commits.kde.org/dol |phin/c72fdaa77380ef811dfef6 |phin/b1ccec70f28fefca8fcd46 |26a4edadbb824ed252 |4ec21dd13070c72e5c --- Comment #11 from David Hallas --- Git commit b1ccec70f28fefca8fcd464ec21dd13070c72e5c by David Hallas. Committed on 18/02/2019 at 19:21. Pushed by hallas into branch 'Applications/18.12'. Fix crash during shutdown Summary: Fix crash during shutdown. The root cause is that when Dolphin in stopped as part of an activity, the KItemListViewAccessible destructor is called after QApplication::exec has returned causing Qt to already having cleaned up the QAccessibleInterface instances kept in KItemListViewAccessible. Instead of storing the pointers to QAccessibleInterface we store the QAccessible::Id so that we can use the QAccessible::deleteAccessibleInterface function for deleting the instances. Test Plan: I wasn't able to reproduce the crash in the first place, but I have just opened and closed Dolphin a few times and verified the the QAccessibleInterface instances are correctly cleaned up. Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19083 M +15 -10 src/kitemviews/kitemlistviewaccessible.cpp M +7-1src/kitemviews/kitemlistviewaccessible.h https://commits.kde.org/dolphin/b1ccec70f28fefca8fcd464ec21dd13070c72e5c -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 378051] crash when you drag file from trash to trash
https://bugs.kde.org/show_bug.cgi?id=378051 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk Ever confirmed|0 |1 Status|REPORTED|ASSIGNED Assignee|fa...@kde.org |da...@davidhallas.dk --- Comment #8 from David Hallas --- I have just reproduced this with a debug build of KIO and I get the following assert failure: ASSERT: "it != dirItem->lstItems.end()" in file /home/dha/workspace/kde/kio/src/core/kcoredirlister_p.h, line 308 I will look into the root cause of this and post and update. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 402784] Dolphin crashes during shutdown, when stopping activity
https://bugs.kde.org/show_bug.cgi?id=402784 David Hallas changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/dol ||phin/c72fdaa77380ef811dfef6 ||26a4edadbb824ed252 Status|CONFIRMED |RESOLVED --- Comment #8 from David Hallas --- Git commit c72fdaa77380ef811dfef626a4edadbb824ed252 by David Hallas. Committed on 18/02/2019 at 07:58. Pushed by hallas into branch 'master'. Fix crash during shutdown Summary: Fix crash during shutdown. The root cause is that when Dolphin in stopped as part of an activity, the KItemListViewAccessible destructor is called after QApplication::exec has returned causing Qt to already having cleaned up the QAccessibleInterface instances kept in KItemListViewAccessible. Instead of storing the pointers to QAccessibleInterface we store the QAccessible::Id so that we can use the QAccessible::deleteAccessibleInterface function for deleting the instances. Test Plan: I wasn't able to reproduce the crash in the first place, but I have just opened and closed Dolphin a few times and verified the the QAccessibleInterface instances are correctly cleaned up. Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19083 M +15 -10 src/kitemviews/kitemlistviewaccessible.cpp M +7-1src/kitemviews/kitemlistviewaccessible.h https://commits.kde.org/dolphin/c72fdaa77380ef811dfef626a4edadbb824ed252 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 368287] Dolphin crashed while moving files to directory on NTFS/FAT file system owned by another user [KIO::FileCopyJob::slotResult]
https://bugs.kde.org/show_bug.cgi?id=368287 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #28 from David Hallas --- I have been looking through all these backtraces and they all point to the KJob::finishJob function and usually the crash is triggered from a call to isAutoDelete. Prior to the call to isAutoDelete two signals are emitted: finished and (optionally) result. So I was thinking is it possible that the receiver of one of these signals would delete the KJob instance? If so, that would explain the crashes. And to fix it we could simply move the isAutoDelete check to before emitting the signals? I can't reproduce the crash myself, but I can cook up a patch that moves this check if anyone is interested in testing? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 402784] Dolphin crashes during shutdown, when stopping activity
https://bugs.kde.org/show_bug.cgi?id=402784 --- Comment #7 from David Hallas --- I have created a patch here: https://phabricator.kde.org/D19083 Please take a look at it and see what you think :) Also, I haven't been able to reproduce the crash myself, so I would really like someone who can reproduce it to check if this fixes it. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403690] new tab should be opened after the current tab in tab list, not at the end
https://bugs.kde.org/show_bug.cgi?id=403690 David Hallas changed: What|Removed |Added Latest Commit||https://commits.kde.org/dol ||phin/17af8ae0ad9092e2f64f8f ||b612ac39d3b078a266 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #7 from David Hallas --- Git commit 17af8ae0ad9092e2f64f8fb612ac39d3b078a266 by David Hallas. Committed on 16/02/2019 at 15:51. Pushed by hallas into branch 'master'. New tab should be placed after the current tab Summary: When opening a new using the context menu the new tab should be placed after the currently open tab, not at the end of the tab list. Test Plan: Open multiple tabs and select a different tab than the last one. Open a new tab using the context menu and see that it opens after the currently selected tab. Open a tab using Ctrl+T and see that it opens at the end. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D18945 M +2-2src/dolphinmainwindow.cpp M +6-2src/dolphintabwidget.cpp M +17 -2src/dolphintabwidget.h https://commits.kde.org/dolphin/17af8ae0ad9092e2f64f8fb612ac39d3b078a266 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 403690] new tab should be opened after the current tab in tab list, not at the end
https://bugs.kde.org/show_bug.cgi?id=403690 David Hallas changed: What|Removed |Added Status|CONFIRMED |ASSIGNED CC||da...@davidhallas.dk Assignee|dolphin-bugs-n...@kde.org |da...@davidhallas.dk --- Comment #5 from David Hallas --- I have pushed a patch for this: https://phabricator.kde.org/D18945 Please test it out to see if it works as expected :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 402784] Dolphin crashes during shutdown, when stopping activity
https://bugs.kde.org/show_bug.cgi?id=402784 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #4 from David Hallas --- (In reply to Elvis Angelaccio from comment #1) > The problem is that when we stop the activity, the KItemListViewAccessible > destructor is called *after* QApplication::exec() from the main() returns > (no idea why). At that point, m_cells contains only dangling pointers and > everything falls apart. Hi Elvis, I was looking at the code for this and I was thinking if a solution could be to change the m_cells type to store QAccessible::Id instead of a pointer to QAccessibleInterface, since Qt provides easy access to the QAccessibleInterface* given the Id. Then in the destructor we could simply lookup the QAccessibleInterface* pointer with the Id and delete it if it was found? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 372441] Konsole Desktop file missing StartupWMClass
https://bugs.kde.org/show_bug.cgi?id=372441 David Hallas changed: What|Removed |Added Status|CONFIRMED |ASSIGNED Assignee|konsole-de...@kde.org |da...@davidhallas.dk -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 372441] Konsole Desktop file missing StartupWMClass
https://bugs.kde.org/show_bug.cgi?id=372441 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #11 from David Hallas --- Posted https://phabricator.kde.org/D16546 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 397910] The title of an open tab from the sidebar is incorrect and is not unified with the window title until I switch between tabs
https://bugs.kde.org/show_bug.cgi?id=397910 David Hallas changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/dol ||phin/5a9567730d37126a66d572 ||3fd22c215f184d1f7f --- Comment #4 from David Hallas --- Git commit 5a9567730d37126a66d5723fd22c215f184d1f7f by David Hallas. Committed on 02/09/2018 at 09:08. Pushed by hallas into branch 'master'. Changes the tabName function to return the name of a specific tab Summary: Changes the tabName function to return the name of the passed in DolphinTabPage. Previously it would return the name of the active tab, which causes in-active tabs to get the wrong name. Test Plan: Open Dolphin Right click a folder and select 'Open in new tab' Notice that the new tab has the wrong title Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15112 M +6-6src/dolphintabwidget.cpp M +3-2src/dolphintabwidget.h https://commits.kde.org/dolphin/5a9567730d37126a66d5723fd22c215f184d1f7f -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 397910] The title of an open tab from the sidebar is incorrect and is not unified with the window title until I switch between tabs
https://bugs.kde.org/show_bug.cgi?id=397910 --- Comment #2 from David Hallas --- Thanks for reporting this :) I have fixed this in https://phabricator.kde.org/D15112. Please give it a try. Also, please keep on testing this new feature and report feedback, it is very much appreciated -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 387851] New tabs should have better title
https://bugs.kde.org/show_bug.cgi?id=387851 David Hallas changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://commits.kde.org/dol ||phin/44a21ea51a055c7429ddee ||866e35b0a5a21c072b Resolution|--- |FIXED --- Comment #9 from David Hallas --- Git commit 44a21ea51a055c7429ddee866e35b0a5a21c072b by David Hallas. Committed on 24/08/2018 at 10:09. Pushed by hallas into branch 'master'. Unify window and tab title Summary: Previously the title of tabs was a prettyfied version of the URL. This is inconsistent with the title of the Window and in some cases for specials URLs kind of misleading. This commit generalizes the code from DolphinMainWindow so that both the DolphinMainWindow title and the tab title uses the same function for the title. This also means that the 'Show Full Path in Title Bar' also applies to the tab title, and also that searches changes the tab title. Test Plan: Open a new tab from the places panel and navigate around. Reviewers: #dolphin, ngraham, elvisangelaccio, markg Reviewed By: #dolphin, ngraham, markg Subscribers: markg, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D14442 M +4-43 src/dolphinmainwindow.cpp M +2-3src/dolphinmainwindow.h M +10 -16 src/dolphintabwidget.cpp M +1-1src/dolphintabwidget.h M +47 -0src/dolphinviewcontainer.cpp M +7-0src/dolphinviewcontainer.h https://commits.kde.org/dolphin/44a21ea51a055c7429ddee866e35b0a5a21c072b -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 397234] Ark does not consider password for encryption (zip)
https://bugs.kde.org/show_bug.cgi?id=397234 --- Comment #3 from David Hallas --- Hi Holger, thanks for the updates. I will try and see if I can reproduce the issue on openSUSE Tumbleweed. If you find any other relevant information, please make sure to update the bug report. Thanks :) -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 397234] Ark does not consider password for encryption (zip)
https://bugs.kde.org/show_bug.cgi?id=397234 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #1 from David Hallas --- I just tested this and it works on my setup :) I have tested with both the zip plugin and with the 7zip plugin. I am using ark both from latest master. Can you reproduce the problem? Can you provide more details? Can you enable some debug? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 387851] New tabs should have better title
https://bugs.kde.org/show_bug.cgi?id=387851 David Hallas changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |da...@davidhallas.dk CC||da...@davidhallas.dk Status|CONFIRMED |ASSIGNED --- Comment #7 from David Hallas --- I am working on implementing this. The solution I am going for is basically to have the tab titles follow the window title, I think that is the most logical. -- You are receiving this mail because: You are watching all bug changes.
[plasma4] [Bug 323230] windows (maximized) are going under the vertical panel on dual screen setup
https://bugs.kde.org/show_bug.cgi?id=323230 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 359133] m_deduppoolalloc.c:258 (vgPlain_allocEltDedupPA): Assertion 'eltSzB <= ddpa->poolSzB' failed.
https://bugs.kde.org/show_bug.cgi?id=359133 --- Comment #9 from David Hallas --- So, should I go ahead and close the bug now that a testcase has been added? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 359133] m_deduppoolalloc.c:258 (vgPlain_allocEltDedupPA): Assertion 'eltSzB <= ddpa->poolSzB' failed.
https://bugs.kde.org/show_bug.cgi?id=359133 --- Comment #7 from David Hallas --- I have attached a reduced test case that shows the problem. I have tested with gcc-4.9.3 and clang-3.7.1 using a 64bit Linux PC. I compiled it like this: g++ -std=c++11 main.cpp -o test I also verified that the latest master fixes the problem. Let me know if there is anything else you need -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 359133] m_deduppoolalloc.c:258 (vgPlain_allocEltDedupPA): Assertion 'eltSzB <= ddpa->poolSzB' failed.
https://bugs.kde.org/show_bug.cgi?id=359133 --- Comment #6 from David Hallas --- Created attachment 97251 --> https://bugs.kde.org/attachment.cgi?id=97251&action=edit Reduced test case -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 359133] m_deduppoolalloc.c:258 (vgPlain_allocEltDedupPA): Assertion 'eltSzB <= ddpa->poolSzB' failed.
https://bugs.kde.org/show_bug.cgi?id=359133 --- Comment #4 from David Hallas --- I can try :) What would the format of a testcase be? Would a C++ code snippet be good enough? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 359133] m_deduppoolalloc.c:258 (vgPlain_allocEltDedupPA): Assertion 'eltSzB <= ddpa->poolSzB' failed.
https://bugs.kde.org/show_bug.cgi?id=359133 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #2 from David Hallas --- Hi Philippe, I tested with the latest HEAD and it works! Thanks a lot for fixing this issue, it is greatly appreciated. Should I go ahead and close the bug or what is the workflow? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 359133] New: m_deduppoolalloc.c:258 (vgPlain_allocEltDedupPA): Assertion 'eltSzB <= ddpa->poolSzB' failed.
https://bugs.kde.org/show_bug.cgi?id=359133 Bug ID: 359133 Summary: m_deduppoolalloc.c:258 (vgPlain_allocEltDedupPA): Assertion 'eltSzB <= ddpa->poolSzB' failed. Product: valgrind Version: 3.12 SVN Platform: Gentoo Packages OS: Linux Status: UNCONFIRMED Severity: crash Priority: NOR Component: general Assignee: jsew...@acm.org Reporter: da...@davidhallas.dk Valgrind will crash with an assertion error: m_deduppoolalloc.c:258 (vgPlain_allocEltDedupPA): Assertion 'eltSzB <= ddpa->poolSzB' failed. when encountering a debug info string larger than 64kb. This can quite easily be reproduced when using heavily templated C++ code. -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 211669] Add LZO support to Ark
https://bugs.kde.org/show_bug.cgi?id=211669 David Hallas changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #8 from David Hallas --- I am currently working on adding support for this using lzop - I will post patches to reviewboard when ready. Currently I only have listing done. -- You are receiving this mail because: You are watching all bug changes.
