[krita] [Bug 252071] [FEATURE_PROJECT] Ability to cancel long-running background strokes

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=252071

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #9 from Dmitry Kazakov  ---
Ok, most of the long-running actions are cancellable now. If you think some
action is not cancellable, please report a separate bug for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 371528] Cache generation regression

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371528

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/3c903e48d4d5e8622e3e52e99
   ||2cd1622ea440f69

--- Comment #1 from Dmitry Kazakov  ---
Git commit 3c903e48d4d5e8622e3e52e992cd1622ea440f69 by Dmitry Kazakov.
Committed on 24/10/2016 at 12:12.
Pushed by dkazakov into branch 'kazakov/undo-with-instant-preview-T2544'.

Fix animation cache to be updates while playback

This is a hack. But it is the easiest way we can fix it at the moment.
If you see any deadlocks caused by this fix please report a bug.

M  +3-0libs/ui/canvas/kis_animation_player.cpp

http://commits.kde.org/krita/3c903e48d4d5e8622e3e52e992cd1622ea440f69

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 371529] Playback interaction issues

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371529

--- Comment #3 from Dmitry Kazakov  ---
Git commit 13bbe54e3a85cd79f5a102e6d9c7aefb70c15e16 by Dmitry Kazakov.
Committed on 24/10/2016 at 12:10.
Pushed by dkazakov into branch 'kazakov/undo-with-instant-preview-T2544'.

Fix recalculation of the cache when editing the last frame of the layer

M  +2-4libs/ui/kis_animation_cache_populator.cpp

http://commits.kde.org/krita/13bbe54e3a85cd79f5a102e6d9c7aefb70c15e16

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 368119] Line Tool - strange line to corner

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368119

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/fb9ba2c7bb082dad96a8e9a30
   ||41c535dc7b14731

--- Comment #11 from Dmitry Kazakov  ---
Git commit fb9ba2c7bb082dad96a8e9a3041c535dc7b14731 by Dmitry Kazakov.
Committed on 24/10/2016 at 09:25.
Pushed by dkazakov into branch 'kazakov/undo-with-instant-preview-T2544'.

Always use Basic Smoothing for Line Tool

Basically, line tool doesn't know how to use Stabilizer.
Fixes T4102

M  +10   -10   libs/ui/tool/kis_smoothing_options.cpp
M  +1-1libs/ui/tool/kis_smoothing_options.h
M  +4-2libs/ui/tool/kis_tool_freehand_helper.cpp
M  +2-1libs/ui/tool/kis_tool_freehand_helper.h
M  +4-1plugins/tools/basictools/kis_tool_line_helper.cpp

http://commits.kde.org/krita/fb9ba2c7bb082dad96a8e9a3041c535dc7b14731

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363311] Ctrl+Z / Undo doesn't work on big brush strokes

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363311

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/1426e045e9cdd653b0ca3c6cb
   ||e29703ee57b2c81
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 1426e045e9cdd653b0ca3c6cbe29703ee57b2c81 by Dmitry Kazakov.
Committed on 21/10/2016 at 11:42.
Pushed by dkazakov into branch 'kazakov/undo-with-instant-preview-T2544'.

Implemented Undo for Instant Preview strokes

Now the user can cancel a stroke without waiting until the main
full-resolution stroke finishes its execution. Just press Ctrl+Z
and the your preview will be (partially) reverted and the corresponding
background stroke will be cancelled.

Technically it is implemented by introducing the second undo store
inside the strokes queue and syncing it with the running strokes
with a set of complicated rules. If the stroke can be cancelled,
it is cancelled, if the stroke has already completed its execution,
it is just undone.
Ref T2544

M  +9-1libs/image/kis_image.cc
M  +11   -0libs/image/kis_image.h
M  +4-0libs/image/kis_image_interfaces.cpp
M  +8-0libs/image/kis_image_interfaces.h
M  +1-2libs/image/kis_processing_applicator.cpp
M  +6-0libs/image/kis_stroke.cpp
M  +2-0libs/image/kis_stroke.h
M  +10   -10   libs/image/kis_stroke_strategy_undo_command_based.cpp
M  +4-5libs/image/kis_stroke_strategy_undo_command_based.h
M  +183  -4libs/image/kis_strokes_queue.cpp
M  +11   -0libs/image/kis_strokes_queue.h
C  +9-11   libs/image/kis_strokes_queue_undo_result.h [from:
libs/image/kis_image_interfaces.cpp - 075% similarity]
M  +5-0libs/image/kis_undo_stores.cpp
M  +2-0libs/image/kis_undo_stores.h
M  +10   -0libs/image/kis_update_scheduler.cpp
M  +7-0libs/image/kis_update_scheduler.h
M  +1-1libs/image/tests/kis_stroke_strategy_undo_command_based_test.cpp
M  +189  -14   libs/image/tests/kis_strokes_queue_test.cpp
M  +5-0libs/image/tests/kis_strokes_queue_test.h
M  +11   -3libs/image/tests/scheduler_utils.h
M  +5-0libs/ui/KisDocument.cpp
M  +1-1libs/ui/actions/kis_selection_action_factories.cpp
M  +0-3libs/ui/kis_filter_manager.cc
M  +0-1libs/ui/tests/fill_processing_visitor_test.cpp
M  +0-1libs/ui/tool/kis_figure_painting_tool_helper.cpp
M  +2-4libs/ui/tool/kis_resources_snapshot.cpp
M  +1-1libs/ui/tool/kis_resources_snapshot.h
M  +1-1libs/ui/tool/kis_tool.cc
M  +1-2libs/ui/tool/kis_tool_freehand.cc
M  +0-4libs/ui/tool/kis_tool_freehand_helper.cpp
M  +0-2libs/ui/tool/kis_tool_freehand_helper.h
M  +0-1libs/ui/tool/strokes/freehand_stroke.cpp
M  +0-1libs/ui/tool/strokes/kis_filter_stroke_strategy.cpp
M  +0-19   libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp
M  +0-1libs/ui/tool/strokes/kis_painter_based_stroke_strategy.h
M  +0-1libs/ui/widgets/kis_scratch_pad.cpp
M  +0-1   
plugins/paintops/defaultpaintops/brush/tests/kis_brushop_test.cpp
M  +1-1plugins/tools/basictools/kis_tool_fill.cc
M  +1-1plugins/tools/basictools/kis_tool_gradient.cc
M  +1-2plugins/tools/basictools/kis_tool_line.cc
M  +2-3plugins/tools/basictools/kis_tool_line_helper.cpp
M  +1-2plugins/tools/basictools/kis_tool_line_helper.h
M  +3-4plugins/tools/basictools/kis_tool_move.cc
M  +16   -32  
plugins/tools/basictools/strokes/move_selection_stroke_strategy.cpp
M  +2-4   
plugins/tools/basictools/strokes/move_selection_stroke_strategy.h
M  +12   -22   plugins/tools/basictools/strokes/move_stroke_strategy.cpp
M  +2-3plugins/tools/basictools/strokes/move_stroke_strategy.h
M  +3-4plugins/tools/basictools/tests/move_selection_stroke_test.cpp
M  +1-1plugins/tools/basictools/tests/move_stroke_test.cpp
M  +1-1plugins/tools/tool_crop/kis_tool_crop.cc
M  +3-3plugins/tools/tool_transform2/kis_tool_transform.cc
M  +2-2   
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
M  +1-1   
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h
M  +0-1sdk/tests/stroke_testing_utils.cpp

http://commits.kde.org/krita/1426e045e9cdd653b0ca3c6cbe29703ee57b2c81

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 371139] Trim to image with local selection active crashes krita. (gdb backtrace)

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371139

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Dmitry Kazakov  ---
I'm afraid I cannot reproduce this crash either :( It might have been fixed by
my KisLayer::selection() crash fix. Could you please check with my today's
patches applied?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 371136] Undoing a change in selection while the global selection mask is selected doesn't do anything.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371136

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
I'm afraid I cannot reproduce this bug :( Could you check the newest version
with my today's fixes applied?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 371138] Crash attempting to undo selection mask transformation. (gdb backtrace)

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371138

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
I'm afraid I cannot reproduce the reported crash. I have fixed some other
crashes/hangups and bugs, but the original one is not reachable for me :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 371138] Crash attempting to undo selection mask transformation. (gdb backtrace)

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371138

--- Comment #1 from Dmitry Kazakov  ---
Git commit 989b681592d57804db73655b913e994380da3258 by Dmitry Kazakov.
Committed on 19/10/2016 at 13:19.
Pushed by dkazakov into branch 'master'.

Fix a hangup and a crash when undoing vector selection creation

This is not exactly the crash reported in the report, but may be related

M  +4-2libs/image/kis_layer.cc
M  +9-1libs/ui/KisDocument.cpp

http://commits.kde.org/krita/989b681592d57804db73655b913e994380da3258

--- Comment #2 from Dmitry Kazakov  ---
Git commit 2aaa11b1a46e74db2b3a09f8cf3731b16611ea1d by Dmitry Kazakov.
Committed on 19/10/2016 at 14:15.
Pushed by dkazakov into branch 'master'.

Fix updates of the shape selection after converting it from shapes

M  +4-1libs/ui/flake/kis_shape_selection_model.cpp
M  +1-0libs/ui/flake/kis_shape_selection_model.h

http://commits.kde.org/krita/2aaa11b1a46e74db2b3a09f8cf3731b16611ea1d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 371138] Crash attempting to undo selection mask transformation. (gdb backtrace)

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371138

--- Comment #1 from Dmitry Kazakov  ---
Git commit 989b681592d57804db73655b913e994380da3258 by Dmitry Kazakov.
Committed on 19/10/2016 at 13:19.
Pushed by dkazakov into branch 'master'.

Fix a hangup and a crash when undoing vector selection creation

This is not exactly the crash reported in the report, but may be related

M  +4-2libs/image/kis_layer.cc
M  +9-1libs/ui/KisDocument.cpp

http://commits.kde.org/krita/989b681592d57804db73655b913e994380da3258

--- Comment #2 from Dmitry Kazakov  ---
Git commit 2aaa11b1a46e74db2b3a09f8cf3731b16611ea1d by Dmitry Kazakov.
Committed on 19/10/2016 at 14:15.
Pushed by dkazakov into branch 'master'.

Fix updates of the shape selection after converting it from shapes

M  +4-1libs/ui/flake/kis_shape_selection_model.cpp
M  +1-0libs/ui/flake/kis_shape_selection_model.h

http://commits.kde.org/krita/2aaa11b1a46e74db2b3a09f8cf3731b16611ea1d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 371135] Active Local Selection doesn't actually limit drawing.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371135

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/773b8bf82f4a011da95b0e64f
   ||8929005b65dd1e6
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Dmitry Kazakov  ---
Git commit 773b8bf82f4a011da95b0e64f8929005b65dd1e6 by Dmitry Kazakov.
Committed on 19/10/2016 at 10:27.
Pushed by dkazakov into branch 'master'.

Fix local selections to work again

This patch just correctly implements the overriding of a selection
in the resources snapshot

Fixes T4089
CC:djka...@yandex.ru

M  +10   -14   libs/ui/tool/kis_resources_snapshot.cpp

http://commits.kde.org/krita/773b8bf82f4a011da95b0e64f8929005b65dd1e6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 318882] implement indirect painting mode for masks

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=318882

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #13 from Dmitry Kazakov  ---
Fixed now in
http://commits.kde.org/krita/9cf0a76bfb77ec014f0a29688b00475de6934b1f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369643] Transparency Mask not updating correctly on canvas

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369643

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/9cf0a76bfb77ec014f0a29688
   ||b00475de6934b1f
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #4 from Dmitry Kazakov  ---
Git commit 9cf0a76bfb77ec014f0a29688b00475de6934b1f by Dmitry Kazakov.
Committed on 19/10/2016 at 08:45.
Pushed by dkazakov into branch 'master'.

Fix Wash Mode painting on masks

We told Krita that the masks support indirect painting but
we never implemented the indirect painting itself! :(

Fixes T3922

M  +38   -18   libs/image/kis_indirect_painting_support.h
M  +34   -3libs/image/kis_mask.cc
M  +1-2libs/image/kis_paint_layer.cc
M  +1-3libs/image/kis_selection_based_layer.cpp
M  +6-12   libs/image/lazybrush/kis_colorize_mask.cpp

http://commits.kde.org/krita/9cf0a76bfb77ec014f0a29688b00475de6934b1f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369643] Transparency Mask not updating correctly on canvas

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369643

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
Looks like something very recent...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369532] Can't "use color as mask" on newly created brush tips - Krita 3.0.1.1

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369532

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/b46e7db264c8aaf111c89cbe2
   ||d3128f2d1041ca4

--- Comment #2 from Dmitry Kazakov  ---
Git commit b46e7db264c8aaf111c89cbe2d3128f2d1041ca4 by Dmitry Kazakov.
Committed on 18/10/2016 at 17:59.
Pushed by dkazakov into branch 'master'.

Fix the Predefined Brushes

The problem is that we share a single KisBrush object across the entire
Krita. Therefore, if we start writing into the settings object and some
other code will get notifications that "something has changed", that other
location may override some settings in the shared KisBrush. Therefore we
will continue to write wrong values to the brush.

Therefore now we postpone all the updates of the settings object until the
entire write operation is completed. The postponing is implemented using a
special KisPaintOpPreset::UpdatedPostponer class that uses the interface
of updates proxy to do the stuff

Fixes T3925

M  +15   -0libs/image/brushengine/kis_paintop_preset.cpp
M  +14   -0libs/image/brushengine/kis_paintop_preset.h
M  +34   -2libs/image/brushengine/kis_paintop_settings_update_proxy.cpp
M  +17   -0libs/image/brushengine/kis_paintop_settings_update_proxy.h
M  +12   -1libs/ui/kis_paintop_box.cc

http://commits.kde.org/krita/b46e7db264c8aaf111c89cbe2d3128f2d1041ca4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369163] Merging selected layers results into new layer with merged data instead of merging them into single layer

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369163

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/65f659d786d945d3ad5f3ba68
   ||c19bad6e7956b69
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 65f659d786d945d3ad5f3ba68c19bad6e7956b69 by Dmitry Kazakov.
Committed on 18/10/2016 at 14:49.
Pushed by dkazakov into branch 'master'.

Fix merging multiple layers

Fixes T3870

M  +1-1libs/image/kis_layer_utils.cpp

http://commits.kde.org/krita/65f659d786d945d3ad5f3ba68c19bad6e7956b69

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369532] Can't "use color as mask" on newly created brush tips - Krita 3.0.1.1

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369532

Dmitry Kazakov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Dmitry Kazakov  ---
Basically, no options that are placed below the preset chooser work and are
reset on every editor opening :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369532] Can't "use color as mask" on newly created brush tips - Krita 3.0.1.1

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369532

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369605] Presets are not marked dirty if the modification is done via the brush-settings.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369605

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/aabbafbe25892dd1d33a41bfa
   ||c1e303a42b497e3
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Dmitry Kazakov  ---
Git commit aabbafbe25892dd1d33a41bfac1e303a42b497e3 by Dmitry Kazakov.
Committed on 18/10/2016 at 14:44.
Pushed by dkazakov into branch 'master'.

Fix marking presets with Dirty mark when changing presets in the editor

Fixes T3923

M  +4-3libs/image/brushengine/kis_locked_properties_proxy.cpp
M  +1-4libs/image/brushengine/kis_paintop_preset.cpp
M  +2-1libs/ui/kis_paintop_box.cc

http://commits.kde.org/krita/aabbafbe25892dd1d33a41bfac1e303a42b497e3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369605] Presets are not marked dirty if the modification is done via the brush-settings.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369605

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369191] Crash if I use next/previous key frame quickly (back and forth) and draw at the same time

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369191

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/7ade2d46b4c7e6411d0175c4c
   ||f8621c83b01a06e
 Status|CONFIRMED   |RESOLVED
  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/7ade2d46b4c7e6411d0175c4c |a/4ae6ff72311d9b1a97f7e71f4
   |f8621c83b01a06e |a0adf0d1127064e

--- Comment #7 from Dmitry Kazakov  ---
Git commit 7ade2d46b4c7e6411d0175c4cf8621c83b01a06e by Dmitry Kazakov.
Committed on 17/10/2016 at 12:21.
Pushed by dkazakov into branch 'master'.

Fix switching frames when painting at the same time

Fixes T3930

M  +1-0libs/image/CMakeLists.txt
M  +5-5libs/image/commands_new/kis_switch_current_time_command.cpp
M  +4-2libs/image/commands_new/kis_switch_current_time_command.h
M  +62   -34   libs/image/kis_image_animation_interface.cpp
M  +7-4libs/image/kis_image_animation_interface.h
A  +78   -0libs/image/kis_switch_time_stroke_strategy.cpp [License: GPL
(v2+)]
A  +53   -0libs/image/kis_switch_time_stroke_strategy.h [License: GPL
(v2+)]
M  +37   -0libs/image/tests/kis_image_animation_interface_test.cpp
M  +1-1libs/image/tests/kis_image_animation_interface_test.h
M  +1-1plugins/dockers/animation/animation_docker.cpp
M  +1-1plugins/dockers/animation/kis_time_based_item_model.cpp
M  +1-1plugins/dockers/animation/tests/timeline_model_test.cpp
M  +1-1plugins/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/krita/7ade2d46b4c7e6411d0175c4cf8621c83b01a06e

--- Comment #8 from Dmitry Kazakov  ---
Git commit 4ae6ff72311d9b1a97f7e71f4a0adf0d1127064e by Dmitry Kazakov.
Committed on 17/10/2016 at 12:21.
Pushed by dkazakov into branch 'master'.

Make the frame switch stroke a barrier

Now the frame cannot switch until all the background strokes are
finished. Basically, we had this behavior from the very beginning,
though I wanted to get out of it, but it didn't work.

Fixes T3930

M  +3-5libs/image/kis_image_animation_interface.cpp
M  +9-4libs/image/kis_switch_time_stroke_strategy.cpp

http://commits.kde.org/krita/4ae6ff72311d9b1a97f7e71f4a0adf0d1127064e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369191] Crash if I use next/previous key frame quickly (back and forth) and draw at the same time

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369191

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/7ade2d46b4c7e6411d0175c4c
   ||f8621c83b01a06e
 Status|CONFIRMED   |RESOLVED
  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/7ade2d46b4c7e6411d0175c4c |a/4ae6ff72311d9b1a97f7e71f4
   |f8621c83b01a06e |a0adf0d1127064e

--- Comment #7 from Dmitry Kazakov  ---
Git commit 7ade2d46b4c7e6411d0175c4cf8621c83b01a06e by Dmitry Kazakov.
Committed on 17/10/2016 at 12:21.
Pushed by dkazakov into branch 'master'.

Fix switching frames when painting at the same time

Fixes T3930

M  +1-0libs/image/CMakeLists.txt
M  +5-5libs/image/commands_new/kis_switch_current_time_command.cpp
M  +4-2libs/image/commands_new/kis_switch_current_time_command.h
M  +62   -34   libs/image/kis_image_animation_interface.cpp
M  +7-4libs/image/kis_image_animation_interface.h
A  +78   -0libs/image/kis_switch_time_stroke_strategy.cpp [License: GPL
(v2+)]
A  +53   -0libs/image/kis_switch_time_stroke_strategy.h [License: GPL
(v2+)]
M  +37   -0libs/image/tests/kis_image_animation_interface_test.cpp
M  +1-1libs/image/tests/kis_image_animation_interface_test.h
M  +1-1plugins/dockers/animation/animation_docker.cpp
M  +1-1plugins/dockers/animation/kis_time_based_item_model.cpp
M  +1-1plugins/dockers/animation/tests/timeline_model_test.cpp
M  +1-1plugins/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/krita/7ade2d46b4c7e6411d0175c4cf8621c83b01a06e

--- Comment #8 from Dmitry Kazakov  ---
Git commit 4ae6ff72311d9b1a97f7e71f4a0adf0d1127064e by Dmitry Kazakov.
Committed on 17/10/2016 at 12:21.
Pushed by dkazakov into branch 'master'.

Make the frame switch stroke a barrier

Now the frame cannot switch until all the background strokes are
finished. Basically, we had this behavior from the very beginning,
though I wanted to get out of it, but it didn't work.

Fixes T3930

M  +3-5libs/image/kis_image_animation_interface.cpp
M  +9-4libs/image/kis_switch_time_stroke_strategy.cpp

http://commits.kde.org/krita/4ae6ff72311d9b1a97f7e71f4a0adf0d1127064e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369557] incorrect number of pixels

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369557

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/ea6dacc6117a5fd0014705d88
   ||4d9529717cb318d
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit ea6dacc6117a5fd0014705d884d9529717cb318d by Dmitry Kazakov.
Committed on 03/10/2016 at 10:34.
Pushed by dkazakov into branch 'master'.

Fix alignment of the selection size values

M  +1-5libs/ui/tool/kis_tool_rectangle_base.cpp

http://commits.kde.org/krita/ea6dacc6117a5fd0014705d884d9529717cb318d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 349666] Changing the anchor point using the Tool Options Docker when using "Transform a layer or selection" tool fails to change origin.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349666

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/bfe18d2ef177b77beab669fb5 |a/4e30027503205b7898c237786
   |74ba39997ad021a |1d15edde183c3d6

--- Comment #9 from Dmitry Kazakov  ---
Git commit 4e30027503205b7898c2377861d15edde183c3d6 by Dmitry Kazakov.
Committed on 29/09/2016 at 17:24.
Pushed by dkazakov into branch 'master'.

Fix translation transform handle the anchor points!

Ref T119
Fixes T2475

M  +27   -8   
plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp

http://commits.kde.org/krita/4e30027503205b7898c2377861d15edde183c3d6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 349666] Changing the anchor point using the Tool Options Docker when using "Transform a layer or selection" tool fails to change origin.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349666

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/bfe18d2ef177b77beab669fb5
   ||74ba39997ad021a
 Status|CONFIRMED   |RESOLVED

--- Comment #8 from Dmitry Kazakov  ---
Git commit bfe18d2ef177b77beab669fb574ba39997ad021a by Dmitry Kazakov.
Committed on 29/09/2016 at 17:18.
Pushed by dkazakov into branch 'kazakov/scale-from-pivot-point-T119'.

Fix translation transform handle the anchor points!

Ref T119
Fixes T2475

M  +25   -8   
plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp

http://commits.kde.org/krita/bfe18d2ef177b77beab669fb574ba39997ad021a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369114] After using the brush editor, first stroke has broken sensors

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369114

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Dmitry Kazakov  ---
Fixed in
https://phabricator.kde.org/rKRITA84fe0d80ece2c903c6e2fa1527dae53f88fa1e49

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369093] Unexpected results when toggling visibility of a colorize mask and its parent layer

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369093

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/ad689f117d5335b52494d4210
   ||5ec001071029e32
 Resolution|--- |FIXED

--- Comment #1 from Dmitry Kazakov  ---
Git commit ad689f117d5335b52494d42105ec001071029e32 by Dmitry Kazakov.
Committed on 22/09/2016 at 09:06.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Fixed an update glitch in the Colorize Mask

Now I had to introduce a special property for the masks, which
reports the additional area where the masks draws. This area
cannot be computed by mean of change/needRect functionality
since it doesn't depend on the dirty rect of the layer.
Fixes T3812

M  +20   -2libs/image/kis_layer.cc
M  +5-0libs/image/kis_mask.cc
M  +13   -0libs/image/kis_mask.h
M  +5-0libs/image/lazybrush/kis_colorize_mask.cpp
M  +6-0libs/image/lazybrush/kis_colorize_mask.h

http://commits.kde.org/krita/ad689f117d5335b52494d42105ec001071029e32

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369112] some brushes look broken

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369112

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #2 from Dmitry Kazakov  ---
Might be related to the Ratio Sensor functionality

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 365992] Krita Crashes on closing document

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365992

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/619be10b7f59cd5a26168144a |a/0571f3df18ea27362cff38bba
   |5d44eeacdc951e4 |e20560da87475c7
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Dmitry Kazakov  ---
Git commit 62ad2e3ec438e710eb49f8fe0f7cbc9958e5b698 by Dmitry Kazakov.
Committed on 21/09/2016 at 14:52.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Fix memory leak when Cumulative Undo is turned on

By default all the KUndo2Command objects should be *not* mergable

Ref T3681

M  +3-2libs/kundo2/kundo2stack.cpp
M  +1-0libs/ui/KisDocument.cpp

http://commits.kde.org/krita/62ad2e3ec438e710eb49f8fe0f7cbc9958e5b698

--- Comment #8 from Dmitry Kazakov  ---
Git commit 0571f3df18ea27362cff38bbae20560da87475c7 by Dmitry Kazakov.
Committed on 21/09/2016 at 14:53.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Convert the memory leak assert into a safe assert

So people would not get a dataloss accidentally :(
Fixes T3681

M  +1-1libs/ui/KisDocument.cpp

http://commits.kde.org/krita/0571f3df18ea27362cff38bbae20560da87475c7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 365992] Krita Crashes on closing document

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365992

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/619be10b7f59cd5a26168144a |a/0571f3df18ea27362cff38bba
   |5d44eeacdc951e4 |e20560da87475c7
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Dmitry Kazakov  ---
Git commit 62ad2e3ec438e710eb49f8fe0f7cbc9958e5b698 by Dmitry Kazakov.
Committed on 21/09/2016 at 14:52.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Fix memory leak when Cumulative Undo is turned on

By default all the KUndo2Command objects should be *not* mergable

Ref T3681

M  +3-2libs/kundo2/kundo2stack.cpp
M  +1-0libs/ui/KisDocument.cpp

http://commits.kde.org/krita/62ad2e3ec438e710eb49f8fe0f7cbc9958e5b698

--- Comment #8 from Dmitry Kazakov  ---
Git commit 0571f3df18ea27362cff38bbae20560da87475c7 by Dmitry Kazakov.
Committed on 21/09/2016 at 14:53.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Convert the memory leak assert into a safe assert

So people would not get a dataloss accidentally :(
Fixes T3681

M  +1-1libs/ui/KisDocument.cpp

http://commits.kde.org/krita/0571f3df18ea27362cff38bbae20560da87475c7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 369095] Lazybrush assertion when a key stroke has 0 opacity

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369095

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/87bb1079c1aa68ed4334f1618
   ||161b4d9c1a4887d

--- Comment #3 from Dmitry Kazakov  ---
Git commit 87bb1079c1aa68ed4334f1618161b4d9c1a4887d by Dmitry Kazakov.
Committed on 21/09/2016 at 14:03.
Pushed by dkazakov into branch 'master'.

Fix crash in Colorize Mask when painted with 0 opacity

Well, there is no reason to try to fill empty scribbles
Fixes T3811

M  +12   -0libs/image/lazybrush/kis_multiway_cut.cpp

http://commits.kde.org/krita/87bb1079c1aa68ed4334f1618161b4d9c1a4887d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366607

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/68ca0a9afba1693d7f1a6234c |a/431fbb5a10eb2f1b54085e791
   |605ff7233522dd5 |37db8d0e7e997c4

--- Comment #12 from Dmitry Kazakov  ---
Git commit a1e7098bdfa7618578f4c6096c0b35146c81bee3 by Dmitry Kazakov.
Committed on 21/09/2016 at 11:05.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Fix crash when D frames from a *cloned* layer

Yes, we should also copy the free-frame-id counter when cloning
the layers (and ideally also check if the frame id is already occupied)

M  +12   -3libs/image/kis_paint_device.cc
M  +55   -11   libs/image/tests/kis_keyframing_test.cpp
M  +2-0libs/image/tests/kis_keyframing_test.h

http://commits.kde.org/krita/a1e7098bdfa7618578f4c6096c0b35146c81bee3

--- Comment #13 from Dmitry Kazakov  ---
Git commit 431fbb5a10eb2f1b54085e79137db8d0e7e997c4 by Dmitry Kazakov.
Committed on 21/09/2016 at 13:15.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Fix crash in timedMergeWith()

Don't try to read from m_lastMergedIndex + 1, which might not
exist because the previous command has been merged using basic
Qt's mechanism.

M  +53   -19   libs/kundo2/kundo2stack.cpp

http://commits.kde.org/krita/431fbb5a10eb2f1b54085e79137db8d0e7e997c4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366607

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/68ca0a9afba1693d7f1a6234c |a/431fbb5a10eb2f1b54085e791
   |605ff7233522dd5 |37db8d0e7e997c4

--- Comment #12 from Dmitry Kazakov  ---
Git commit a1e7098bdfa7618578f4c6096c0b35146c81bee3 by Dmitry Kazakov.
Committed on 21/09/2016 at 11:05.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Fix crash when D frames from a *cloned* layer

Yes, we should also copy the free-frame-id counter when cloning
the layers (and ideally also check if the frame id is already occupied)

M  +12   -3libs/image/kis_paint_device.cc
M  +55   -11   libs/image/tests/kis_keyframing_test.cpp
M  +2-0libs/image/tests/kis_keyframing_test.h

http://commits.kde.org/krita/a1e7098bdfa7618578f4c6096c0b35146c81bee3

--- Comment #13 from Dmitry Kazakov  ---
Git commit 431fbb5a10eb2f1b54085e79137db8d0e7e997c4 by Dmitry Kazakov.
Committed on 21/09/2016 at 13:15.
Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'.

Fix crash in timedMergeWith()

Don't try to read from m_lastMergedIndex + 1, which might not
exist because the previous command has been merged using basic
Qt's mechanism.

M  +53   -19   libs/kundo2/kundo2stack.cpp

http://commits.kde.org/krita/431fbb5a10eb2f1b54085e79137db8d0e7e997c4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 351106] Crash using "Create Copy from Current Image"

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=351106

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/47e8ee0294ce0441ce93ec6a8
   ||38dad5bca13130f
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #16 from Dmitry Kazakov  ---
Git commit 47e8ee0294ce0441ce93ec6a838dad5bca13130f by Dmitry Kazakov.
Committed on 16/09/2016 at 14:59.
Pushed by dkazakov into branch 'master'.

Fix crash when copying the image with Instant Preview active

Fixes T3758,T3709

M  +5-0libs/image/kis_base_node.cpp
M  +2-0libs/image/kis_base_node.h
M  +1-1libs/image/kis_group_layer.h
M  +1-0libs/image/kis_image.cc
M  +10   -11   libs/image/kis_layer.cc
M  +1-1libs/image/kis_layer.h
M  +1-1libs/image/kis_mask.h
M  +1-1libs/image/kis_paint_layer.h
M  +1-1libs/image/kis_selection_based_layer.h
M  +1-1libs/image/lazybrush/kis_colorize_mask.h
M  +1-1libs/ui/flake/kis_shape_layer.h

http://commits.kde.org/krita/47e8ee0294ce0441ce93ec6a838dad5bca13130f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 368483] Segfault when creating a new document

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368483

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/ca4941ad1e1066cc96fedb53e |a/d4a7b903b4de0f83f1f0fa76f
   |06f1058c5a398a0 |a5bea9ca97dce89

--- Comment #3 from Dmitry Kazakov  ---
Git commit d4a7b903b4de0f83f1f0fa76fa5bea9ca97dce89 by Dmitry Kazakov.
Committed on 09/09/2016 at 09:51.
Pushed by dkazakov into branch 'master'.

Fix a crash in New Image dialog

Thanks bruceoutdoors for the patch! :)

M  +0-14   libs/ui/forms/wdgnewimage.ui
M  +7-2libs/ui/widgets/kis_color_button.h

http://commits.kde.org/krita/d4a7b903b4de0f83f1f0fa76fa5bea9ca97dce89

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 368483] Segfault when creating a new document

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368483

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/ca4941ad1e1066cc96fedb53e
   ||06f1058c5a398a0
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit ca4941ad1e1066cc96fedb53e06f1058c5a398a0 by Dmitry Kazakov.
Committed on 09/09/2016 at 09:49.
Pushed by dkazakov into branch 'krita-lazybrush-kazakov'.

Fix a crash in New Image dialog

Thanks bruceoutdoors for the patch! :)

M  +0-14   libs/ui/forms/wdgnewimage.ui
M  +7-2libs/ui/widgets/kis_color_button.h

http://commits.kde.org/krita/ca4941ad1e1066cc96fedb53e06f1058c5a398a0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366619] Shift Drag brush resize is slower in recent git builds (probably due to HUD patches)

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366619

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/662ecc874f61ea5da34c66b59 |a/dc8ae57fbad42f286c3250ec2
   |86a9a7fb36a6836 |4cf3fab11aa2315
 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Dmitry Kazakov  ---
Git commit dc8ae57fbad42f286c3250ec24cf3fab11aa2315 by Dmitry Kazakov.
Committed on 05/09/2016 at 14:23.
Pushed by dkazakov into branch 'master'.

Fix slowdown when doing Shift+Drag resizing gesture

This patch implements a concept of "sequence number" for
KisPaintOpSettings objects. This "number" changes every time the
properties change, therefore we can track if the property has been
changed or not in the external code.

Fixes T3520

M  +6-1libs/image/brushengine/kis_paintop_config_widget.cpp
M  +1-0libs/image/brushengine/kis_paintop_config_widget.h
M  +2-1libs/image/brushengine/kis_paintop_settings.cpp
M  +16   -0libs/image/kis_properties_configuration.cc
M  +13   -0libs/image/kis_properties_configuration.h

http://commits.kde.org/krita/dc8ae57fbad42f286c3250ec24cf3fab11aa2315

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 367547] [layer-color-label] Newer Krita can't read a color label set by Krita 3.0

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367547

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/fb90378afe58fb5b02099fb14
   ||9b33cc768a773e9

--- Comment #1 from Dmitry Kazakov  ---
Git commit fb90378afe58fb5b02099fb149b33cc768a773e9 by Dmitry Kazakov.
Committed on 19/08/2016 at 08:10.
Pushed by dkazakov into branch 'master'.

Fix overflowing color labels

They should always have some color and not become transparent again.

M  +11   -1libs/ui/kis_node_view_color_scheme.cpp

http://commits.kde.org/krita/fb90378afe58fb5b02099fb149b33cc768a773e9

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 360677] Krita constantly creates and removes native threads

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360677

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/9c34fef3320983c8e05423631
   ||21035eab225cd29
 Resolution|WAITINGFORINFO  |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/9c34fef3320983c8e05423631
   ||21035eab225cd29
 Resolution|WAITINGFORINFO  |FIXED

--- Comment #8 from Dmitry Kazakov  ---
Git commit 9c34fef3320983c8e0542363121035eab225cd29 by Dmitry Kazakov, on
behalf of Andrew Savonichev.
Committed on 18/08/2016 at 06:59.
Pushed by dkazakov into branch 'master'.

Summary:
KisUpdaterContext::waitForDone() method must lock context and wait
untill all threads finish their current tasks.
We cannot call QThreadPool.waitForDone() to do this, because after
waiting it removes all threads from the pool.

Test Plan:
Verified that no extra threads created: 8 for global thread pool and 8 for
KisUpdaterContext

(gdb) info threads
  Id   Target Id Frame
  22   Thread 0x7fff8cff9700 (LWP 18481) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  21   Thread 0x7fff8d7fa700 (LWP 18480) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  20   Thread 0x7fff8dffb700 (LWP 18479) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  19   Thread 0x7fff8e7fc700 (LWP 18478) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  18   Thread 0x7fff8effd700 (LWP 18477) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  17   Thread 0x7fff8f7fe700 (LWP 18476) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  16   Thread 0x7fff8700 (LWP 18475) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  15   Thread 0x7fff9bfff700 (LWP 18474) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  13   Thread 0x7fffb8ff9700 (LWP 18471) "QFileInfoGather" 0x7fffef6e291f
in pthread_cond_wait () from /lib64/libpthread.so.0
  12   Thread 0x7fffb97fa700 (LWP 18470) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  11   Thread 0x7fffb9ffb700 (LWP 18469) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  10   Thread 0x7fffba7fc700 (LWP 18468) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  9Thread 0x7fffbaffd700 (LWP 18467) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  8Thread 0x7fffbb7fe700 (LWP 18466) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  7Thread 0x7fffbbfff700 (LWP 18465) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  6Thread 0x7fffc8f8a700 (LWP 18464) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  5Thread 0x7fffc978b700 (LWP 18463) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  4Thread 0x7fffca38d700 (LWP 18462) "KisTileDataSwap" 0x7fffef6e291f
in pthread_cond_wait () from /lib64/libpthread.so.0
  3Thread 0x7fffcab8e700 (LWP 18461) "KisTileDataPool" 0x7fffef6e291f
in pthread_cond_wait () from /lib64/libpthread.so.0
  2Thread 0x7fffe0843700 (LWP 18460) "QXcbEventReader" 0x716a33ed
in poll () from /lib64/libc.so.6
* 1Thread 0x7fffe7f3f7c0 (LWP 18456) "krita" 0x716a33ed in poll ()
from /lib64/libc.so.6

Reviewers: dkazakov

Reviewed By: dkazakov

Subscribers: fazek
Differential Revision: https://phabricator.kde.org/D1166

M  +10   -2libs/image/kis_update_scheduler.cpp
M  +89   -14   libs/image/kis_updater_context.cpp
M  +14   -0libs/image/kis_updater_context.h
M  +14   -0libs/image/tests/kis_strokes_queue_test.cpp
M  +2-0libs/image/tests/kis_updater_context_test.cpp

http://commits.kde.org/krita/9c34fef3320983c8e0542363121035eab225cd29

--- Comment #9 from Dmitry Kazakov  ---
Git commit 9c34fef3320983c8e0542363121035eab225cd29 by Dmitry Kazakov, on
behalf of Andrew Savonichev.
Committed on 18/08/2016 at 06:59.
Pushed by dkazakov into branch 'master'.

Summary:
KisUpdaterContext::waitForDone() method must lock context and wait
untill all threads finish their current tasks.
We 

[krita] [Bug 360677] Krita constantly creates and removes native threads

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360677

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/9c34fef3320983c8e05423631
   ||21035eab225cd29
 Resolution|WAITINGFORINFO  |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/9c34fef3320983c8e05423631
   ||21035eab225cd29
 Resolution|WAITINGFORINFO  |FIXED

--- Comment #8 from Dmitry Kazakov  ---
Git commit 9c34fef3320983c8e0542363121035eab225cd29 by Dmitry Kazakov, on
behalf of Andrew Savonichev.
Committed on 18/08/2016 at 06:59.
Pushed by dkazakov into branch 'master'.

Summary:
KisUpdaterContext::waitForDone() method must lock context and wait
untill all threads finish their current tasks.
We cannot call QThreadPool.waitForDone() to do this, because after
waiting it removes all threads from the pool.

Test Plan:
Verified that no extra threads created: 8 for global thread pool and 8 for
KisUpdaterContext

(gdb) info threads
  Id   Target Id Frame
  22   Thread 0x7fff8cff9700 (LWP 18481) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  21   Thread 0x7fff8d7fa700 (LWP 18480) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  20   Thread 0x7fff8dffb700 (LWP 18479) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  19   Thread 0x7fff8e7fc700 (LWP 18478) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  18   Thread 0x7fff8effd700 (LWP 18477) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  17   Thread 0x7fff8f7fe700 (LWP 18476) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  16   Thread 0x7fff8700 (LWP 18475) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  15   Thread 0x7fff9bfff700 (LWP 18474) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  13   Thread 0x7fffb8ff9700 (LWP 18471) "QFileInfoGather" 0x7fffef6e291f
in pthread_cond_wait () from /lib64/libpthread.so.0
  12   Thread 0x7fffb97fa700 (LWP 18470) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  11   Thread 0x7fffb9ffb700 (LWP 18469) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  10   Thread 0x7fffba7fc700 (LWP 18468) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  9Thread 0x7fffbaffd700 (LWP 18467) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  8Thread 0x7fffbb7fe700 (LWP 18466) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  7Thread 0x7fffbbfff700 (LWP 18465) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  6Thread 0x7fffc8f8a700 (LWP 18464) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  5Thread 0x7fffc978b700 (LWP 18463) "Thread (pooled)" 0x7fffef6e2cc8
in pthread_cond_timedwait () from /lib64/libpthread.so.0
  4Thread 0x7fffca38d700 (LWP 18462) "KisTileDataSwap" 0x7fffef6e291f
in pthread_cond_wait () from /lib64/libpthread.so.0
  3Thread 0x7fffcab8e700 (LWP 18461) "KisTileDataPool" 0x7fffef6e291f
in pthread_cond_wait () from /lib64/libpthread.so.0
  2Thread 0x7fffe0843700 (LWP 18460) "QXcbEventReader" 0x716a33ed
in poll () from /lib64/libc.so.6
* 1Thread 0x7fffe7f3f7c0 (LWP 18456) "krita" 0x716a33ed in poll ()
from /lib64/libc.so.6

Reviewers: dkazakov

Reviewed By: dkazakov

Subscribers: fazek
Differential Revision: https://phabricator.kde.org/D1166

M  +10   -2libs/image/kis_update_scheduler.cpp
M  +89   -14   libs/image/kis_updater_context.cpp
M  +14   -0libs/image/kis_updater_context.h
M  +14   -0libs/image/tests/kis_strokes_queue_test.cpp
M  +2-0libs/image/tests/kis_updater_context_test.cpp

http://commits.kde.org/krita/9c34fef3320983c8e0542363121035eab225cd29

--- Comment #9 from Dmitry Kazakov  ---
Git commit 9c34fef3320983c8e0542363121035eab225cd29 by Dmitry Kazakov, on
behalf of Andrew Savonichev.
Committed on 18/08/2016 at 06:59.
Pushed by dkazakov into branch 'master'.

Summary:
KisUpdaterContext::waitForDone() method must lock context and wait
untill all threads finish their current tasks.
We 

[krita] [Bug 363663] bad pixel randomness with low density with gaussian or soft mask type

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363663

--- Comment #5 from Dmitry Kazakov  ---
Ok, I might be wrong about Vc. My local branch was at
kazakov/memory-optimizations, which is a bit old. Anyway, Alpha2 package is
affected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363663] bad pixel randomness with low density with gaussian or soft mask type

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363663

Dmitry Kazakov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||dimul...@gmail.com
 Status|UNCONFIRMED |CONFIRMED

--- Comment #4 from Dmitry Kazakov  ---
The bug can be reproduced only on Windows and only with the prebuilt packages.
My own build (without Vc) works fine. The latest Alpha2 brebuilt .zip package
is broken.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 361709] With more than 1 curve based assistant, zooming in will black screen part or all of the drawing window

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361709

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/34f8ecdf866b556c4a054003f
   ||6358a7cee6fa025

--- Comment #24 from Dmitry Kazakov  ---
Git commit 34f8ecdf866b556c4a054003f6358a7cee6fa025 by Dmitry Kazakov.
Committed on 16/08/2016 at 14:59.
Pushed by dkazakov into branch 'master'.

Workaround a NVIDIA/Qt but with black screen in assistants

It seems like Qt uses some internal caches/textures for painting
pixmaps/images on screen. And if the images of one rendering cycle
don't fit into that cache they are painted and black rectangles.

There is a workaround for that: just make the size of the pixmap cache
more than 20 MiB. Then all the pixmaps painted through the cache will work
correctly (if you decide to draw a QImage on screen manually, it still
doesn't work).

I don't know what happens there, but it seems like this workaround fixes
the problem. Let's wait until we merge Qt+openGL3 branch, probably, it
will change something.

M  +36   -0libs/ui/opengl/kis_opengl.cpp
M  +5-0libs/ui/opengl/kis_opengl.h

http://commits.kde.org/krita/34f8ecdf866b556c4a054003f6358a7cee6fa025

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 361709] With more than 1 curve based assistant, zooming in will black screen part or all of the drawing window

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361709

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #23 from Dmitry Kazakov  ---
I can also reproduce this bug on Linux + Qt 5.5.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366765] Exporting a PSD file onto a network drive causes application hang

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366765

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #5 from Dmitry Kazakov  ---
Well, the only problem I can imagine is that PSD saving code uses file seeks
while saving... I'm not sure how we should fix that though...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363225] Qt5 under Linux get stuck in "clicking" state, and Krita become unusable

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363225

--- Comment #23 from Dmitry Kazakov  ---
Hi, Camille!

I didn't understood, were you able to to run the AppImage in the end? The point
is that AppImage has a patched version of Qt, so it should work differently
from what is compiled using the system library. Here is the link to the latest
AppImage present:

http://files.kde.org/krita/3/linux/devbuilds/krita-3.0.1-Alpha2-d33dbe0-x86_64.appimage

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366736] Changing brushes slowly slows down Krita

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366736

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/430b17968e79df3fee35cf309
   ||1e48c01cbd02dc3
 Resolution|--- |FIXED

--- Comment #3 from Dmitry Kazakov  ---
Git commit 430b17968e79df3fee35cf3091e48c01cbd02dc3 by Dmitry Kazakov.
Committed on 16/08/2016 at 10:43.
Pushed by dkazakov into branch 'master'.

Fix leaking connections in KisPaintOpBox

Fixes T3462

M  +6-8libs/ui/kis_paintop_box.cc

http://commits.kde.org/krita/430b17968e79df3fee35cf3091e48c01cbd02dc3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366736] Changing brushes slowly slows down Krita

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366736

Dmitry Kazakov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||dimul...@gmail.com
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Dmitry Kazakov  ---
Yes, it seems like the number of brush connections grows with the time :(

And the brush jumping happens do to Qt handling a long delay somehow. Qt
5.6.something doesn't have this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363080] scratchpad stops working when clicking right/middle mb while painting

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363080

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/596d09a948a3e8a105ee578cd
   ||20fc3dda3dcdf89
 Resolution|--- |FIXED

--- Comment #10 from Dmitry Kazakov  ---
Git commit 596d09a948a3e8a105ee578cd20fc3dda3dcdf89 by Dmitry Kazakov.
Committed on 15/08/2016 at 15:46.
Pushed by dkazakov into branch 'master'.

Fix a hangup in ScratchPad when clicking too many mouse buttons at the same
time

Fixes T3458

M  +18   -6libs/ui/widgets/kis_scratch_pad.cpp
M  +4-0libs/ui/widgets/kis_scratch_pad.h

http://commits.kde.org/krita/596d09a948a3e8a105ee578cd20fc3dda3dcdf89

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366595] Wrap-around mode: cannot sample colors outside of the original document

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366595

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/a33fbfd8408271914d3127c98
   ||6a610653ab8b3c6

--- Comment #2 from Dmitry Kazakov  ---
Git commit a33fbfd8408271914d3127c986a610653ab8b3c6 by Dmitry Kazakov.
Committed on 15/08/2016 at 15:23.
Pushed by dkazakov into branch 'master'.

Fix color picking in wraparound mode

The properties of the strokes without initializing job should
be loaded as well.

Fixes T3460

M  +17   -0libs/image/kis_strokes_queue.cpp

http://commits.kde.org/krita/a33fbfd8408271914d3127c986a610653ab8b3c6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363089] Problems with the brushes with "Instant preview" active

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363089

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/fa0a9b592a21a6422da846026
   ||0339a1b86314090
 Resolution|--- |FIXED

--- Comment #3 from Dmitry Kazakov  ---
Git commit fa0a9b592a21a6422da8460260339a1b86314090 by Dmitry Kazakov.
Committed on 15/08/2016 at 12:58.
Pushed by dkazakov into branch 'master'.

Fix Instant Preview + Mirror Mode

Fixes T3276

M  +23   -8libs/image/kis_painter.cc

http://commits.kde.org/krita/fa0a9b592a21a6422da8460260339a1b86314090

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 355976] Brush stroke signal lost with krita-lod-unstable

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355976

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #5 from Dmitry Kazakov  ---
Hi, Tyson! I didn't see this bug for ages... is this bug still actual? I have a
feeling it has been fixed since then.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363225] Qt5 under Linux get stuck in "clicking" state, and Krita become unusable

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363225

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #20 from Dmitry Kazakov  ---
Hi, Camille! Did you try to run AppImage version of Krita? The point is, into
AppImage we put a patched version of Qt, with some tablet-related bugs fixed.
Does it also happen with AppImage?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363924] [Huion 610] Losing pressure sensitiveness when opening other softwares

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363924

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Dmitry Kazakov  ---
Hi, zeusex81!

Could you check if the bug is reproducible with the newer version of the
driver? Your tablet log says that the driver just stops sending any events to
Krita, so I'm not sure if we can do anything here. Does this bug also happens
with version 12 of the driver?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 362487] [Huion 610] Cursor is misaligned with brush/tools

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362487

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #17 from Dmitry Kazakov  ---
Hi, Zeusex81!

Do I understand it right that in newer version of the Huion driver the offset
problem is not reproducible?

Do I also understand it correctly that in older version of the driver, the
right/middle-button click worked fine and in newer ones it doesn't?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 365120] Range in Outer Glow Layer Style Value 0 Causes Crash

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365120

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/b8c76c425fdf639ed5a6493d9
   ||1a27a75f8a3097c
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Dmitry Kazakov  ---
Git commit b8c76c425fdf639ed5a6493d91a27a75f8a3097c by Dmitry Kazakov.
Committed on 15/08/2016 at 10:39.
Pushed by dkazakov into branch 'master'.

Fix one more range slider not to become 0

Boud's fix was absolutely correct. This is just an addition.

Fixes T3177

M  +1-1libs/ui/dialogs/kis_dlg_layer_style.cpp

http://commits.kde.org/krita/b8c76c425fdf639ed5a6493d91a27a75f8a3097c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 362629] Certain Brushes do not behave the same from 2.9 to 3.0

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362629

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #5 from Dmitry Kazakov  ---
Hi,  brusheco!

Could you please attach the failing preset? I tried to reproduce the problem
manually with the presets attached to the Phabricator task, but I failed :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 362136] Instant preview doesn't work for the spray brush

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362136

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/5cf22427beabe410851c52e78
   ||a906fd44adb2a64
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Dmitry Kazakov  ---
Git commit 5cf22427beabe410851c52e78a906fd44adb2a64 by Dmitry Kazakov.
Committed on 15/08/2016 at 09:18.
Pushed by dkazakov into branch 'master'.

Fix Instant Preview in Spray brushes

We should use KisRandomSource for every random number generation in
the paintop, not the home-grown implementation based on srand.
Fixes T2369

M  +8-0libs/image/brushengine/kis_random_source.cpp
M  +5-0libs/image/brushengine/kis_random_source.h
M  +0-1plugins/paintops/gridbrush/CMakeLists.txt
D  +0-49   plugins/paintops/gridbrush/random_gauss.cpp
D  +0-53   plugins/paintops/gridbrush/random_gauss.h
M  +0-1plugins/paintops/spray/CMakeLists.txt
D  +0-49   plugins/paintops/spray/random_gauss.cpp
D  +0-54   plugins/paintops/spray/random_gauss.h
M  +11   -9plugins/paintops/spray/spray_brush.cpp
M  +0-2plugins/paintops/spray/spray_brush.h

http://commits.kde.org/krita/5cf22427beabe410851c52e78a906fd44adb2a64

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363577] Spray brush changes particle size weirdly

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363577

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/cdd42948590ac1758d8c920e1
   ||6016a3f2fcbb4c8

--- Comment #1 from Dmitry Kazakov  ---
Git commit cdd42948590ac1758d8c920e16016a3f2fcbb4c8 by Dmitry Kazakov.
Committed on 12/08/2016 at 15:04.
Pushed by dkazakov into branch 'master'.

Fix wrong aspect ratio fixing in Spray Brush

Fixes T2755

M  +12   -70   plugins/paintops/spray/kis_spray_shape_option.cpp
M  +2-10   plugins/paintops/spray/kis_spray_shape_option.h

http://commits.kde.org/krita/cdd42948590ac1758d8c920e16016a3f2fcbb4c8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 362347] The Shade selector doesn't have scrollbars if it's too high for the screen

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362347

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/b1a1576f4196c04ed5389637f
   ||b53800834724adb
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit b1a1576f4196c04ed5389637fb53800834724adb by Dmitry Kazakov.
Committed on 12/08/2016 at 14:21.
Pushed by dkazakov into branch 'master'.

Don't let KisShadeSelectorLineComboBox jump out of the screen :)

Fixes T2796

M  +13   -2   
plugins/dockers/advancedcolorselector/kis_shade_selector_line_combo_box.cpp

http://commits.kde.org/krita/b1a1576f4196c04ed5389637fb53800834724adb

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364183] Stabilizer's Finish line option is down

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364183

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/54098bcd976ee40eb8ea0dc9c
   ||2d234c86b30d1ad

--- Comment #4 from Dmitry Kazakov  ---
Git commit 54098bcd976ee40eb8ea0dc9c2d234c86b30d1ad by Dmitry Kazakov.
Committed on 12/08/2016 at 13:29.
Pushed by dkazakov into branch 'master'.

Fix Stabilizer Finish Line feature broken by the stabilizer fix in 3.0
Fixes T3272

M  +13   -2libs/ui/tool/kis_stabilized_events_sampler.cpp
M  +1-0libs/ui/tool/kis_stabilized_events_sampler.h
M  +4-9libs/ui/tool/kis_tool_freehand_helper.cpp

http://commits.kde.org/krita/54098bcd976ee40eb8ea0dc9c2d234c86b30d1ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366619] Shift Drag brush resize is slower in recent git builds (probably due to HUD patches)

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366619

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/662ecc874f61ea5da34c66b59
   ||86a9a7fb36a6836
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 662ecc874f61ea5da34c66b5986a9a7fb36a6836 by Dmitry Kazakov.
Committed on 12/08/2016 at 12:26.
Pushed by dkazakov into branch 'master'.

Fix the algorithm of the calculation of the Shift+Gesture scale

Now it takes the screen size into account

M  +20   -12   libs/ui/tool/kis_tool_freehand.cc

http://commits.kde.org/krita/662ecc874f61ea5da34c66b5986a9a7fb36a6836

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366243] Something's really wrong with the update scheduler/kisstroke/etc.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366243

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
 CC||dimul...@gmail.com

--- Comment #9 from Dmitry Kazakov  ---
Fixed by Grigory

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 366378] Hitting 'K' - darker color and 'L' lighter color keys in greyscale document crashes krita randomly

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366378

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/42e434f090834d057d5be87bd
   ||73e16dcc5f53f2e
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 42e434f090834d057d5be87bd73e16dcc5f53f2e by Dmitry Kazakov.
Committed on 11/08/2016 at 10:32.
Pushed by dkazakov into branch 'master'.

Fix crash when using K and L shortcuts

Summary:
We shouldn't fetch the RGB triplets from the grayscale color data

Fixes T3442

Maniphest Tasks: T3442

Differential Revision: https://phabricator.kde.org/D2405

M  +43   -71  
plugins/color/lcms2engine/colorprofiles/LcmsColorProfileContainer.cpp

http://commits.kde.org/krita/42e434f090834d057d5be87bd73e16dcc5f53f2e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 365992] Krita Crashes on closing document

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365992

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/619be10b7f59cd5a26168144a
   ||5d44eeacdc951e4
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 619be10b7f59cd5a26168144a5d44eeacdc951e4 by Dmitry Kazakov.
Committed on 11/08/2016 at 14:42.
Pushed by dkazakov into branch 'master'.

Fix crash on saving a document and closing it rigth after that

Fixes T3351

M  +11   -4libs/ui/KisMainWindow.cpp
M  +11   -0libs/ui/KisMainWindow.h
M  +10   -0libs/ui/KisPart.cpp

http://commits.kde.org/krita/619be10b7f59cd5a26168144a5d44eeacdc951e4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364213] Key + Drag for Opacity and Flow are needed too.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364213

--- Comment #2 from Dmitry Kazakov  ---
Git commit 5edaa336d4999c5db77958cc2e9970a6cfc995f5 by Dmitry Kazakov.
Committed on 05/08/2016 at 09:39.
Pushed by dkazakov into branch 'master'.

Merge the Heads-up-display for the brushes into master

Now the popup palette has a special HUD that is used for controlling
specific brush properties. Every brush engine has its own properties,
and you can choose which ones you want to see in a special settings
dialog in the HUD itself.

Fixes T127
Related: bug 322835
Auditors:#krita_manual,#krita_website_and_translations
Differential Revision: https://phabricator.kde.org/D2289


http://commits.kde.org/krita/5edaa336d4999c5db77958cc2e9970a6cfc995f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 322835] Brush rotation hotkey

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=322835

--- Comment #8 from Dmitry Kazakov  ---
Git commit 5edaa336d4999c5db77958cc2e9970a6cfc995f5 by Dmitry Kazakov.
Committed on 05/08/2016 at 09:39.
Pushed by dkazakov into branch 'master'.

Merge the Heads-up-display for the brushes into master

Now the popup palette has a special HUD that is used for controlling
specific brush properties. Every brush engine has its own properties,
and you can choose which ones you want to see in a special settings
dialog in the HUD itself.

Fixes T127
Related: bug 364213
Auditors:#krita_manual,#krita_website_and_translations
Differential Revision: https://phabricator.kde.org/D2289


http://commits.kde.org/krita/5edaa336d4999c5db77958cc2e9970a6cfc995f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364213] Key + Drag for Opacity and Flow are needed too.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364213

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
I think we consider the bug as fixed now :) The opacity and flow can now be
edited in the HUD widget :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 322835] Brush rotation hotkey

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=322835

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||dimul...@gmail.com

--- Comment #9 from Dmitry Kazakov  ---
I think we consider the bug as fixed now :) You can rotate the brush using the
HUD :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 361811] Breeze causes hangs and crashes in Krita

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361811

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #17 from Dmitry Kazakov  ---
I have Qt 5.5.1, KF5 5.15.0-0ubuntu3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 143306] when moving the image block, show always (!) coordinates

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=143306

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/48287eb395e6590bd1dd18197
   ||44fc6317b5eda79
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Dmitry Kazakov  ---
Git commit 48287eb395e6590bd1dd1819744fc6317b5eda79 by Dmitry Kazakov, on
behalf of Grigory Tantsevov.
Committed on 23/07/2016 at 21:15.
Pushed by dkazakov into branch 'master'.

Added showing coordinates when using Move Tool.

Coordinates showing in floating message in format: X: x px, Y: y px.
X, Y means position of Left Top pixel of the moved area.
Also there are two spin bars, which you can use for setting image
position by keyboard (not only arrows).

Reviewers: #krita, dkazakov
Subscribers: dkazakov, scottpetrovic, timotheegiet, Deevad
Differential Revision: https://phabricator.kde.org/D2238
Auditors: #krita_manual

M  +10   -0krita/data/actions/MoveTool.action
M  +136  -0plugins/tools/basictools/kis_tool_move.cc
M  +16   -0plugins/tools/basictools/kis_tool_move.h
M  +47   -0plugins/tools/basictools/kis_tool_movetooloptionswidget.cpp
M  +22   -0plugins/tools/basictools/kis_tool_movetooloptionswidget.h
M  +165  -44   plugins/tools/basictools/wdgmovetool.ui

http://commits.kde.org/krita/48287eb395e6590bd1dd1819744fc6317b5eda79

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 325052] JJ: Isolate layer mode

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=325052

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/f6b1c94cca22f854982afcb90
   ||31ac6580c463054
 Status|CONFIRMED   |RESOLVED

--- Comment #17 from Dmitry Kazakov  ---
Git commit f6b1c94cca22f854982afcb9031ac6580c463054 by Dmitry Kazakov, on
behalf of Alexey Kapustin.
Committed on 22/07/2016 at 09:45.
Pushed by dkazakov into branch 'master'.

Isolation mode is now saved when you move between layers.
When moving to a higher layer level , all the sub-layers are visible.

Now to exit Isolate Layer you can either toggle the checkbox in
a context menu or just Alt+click on the currently selected layer.

Reviewers: #krita, dkazakov
Subscribers: dkazakov, woltherav
Tags: #krita
Differential Revision: https://phabricator.kde.org/D2213
CC:kimages...@kde.org

M  +1-14   libs/ui/kis_node_manager.cpp

http://commits.kde.org/krita/f6b1c94cca22f854982afcb9031ac6580c463054

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #9 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 363334

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

--- Comment #10 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 363334

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #9 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 363334

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

--- Comment #10 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 363334

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363334] Memory full when working with large files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363334

--- Comment #16 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 364848, bug 364848

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364183] Stabilizer's Finish line option is down

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364183

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||dimul...@gmail.com
 Ever confirmed|0   |1

--- Comment #3 from Dmitry Kazakov  ---
Confirmed on a local build

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 352533] Add quick flip buttons to transform docker

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352533

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/efc2047b46c479ee2d0913c0a
   ||45e038be994c479

--- Comment #6 from Dmitry Kazakov  ---
Git commit efc2047b46c479ee2d0913c0a45e038be994c479 by Dmitry Kazakov.
Committed on 19/07/2016 at 08:06.
Pushed by dkazakov into branch 'master'.

Add quick flip buttons to transform docker

https://bugs.kde.org/show_bug.cgi?id=352533

Adds vertical flip, horizontal flip, clockwise rotate
and counter-clockwise rotate buttons to the free
transform docker widget.

Thanks Pulponite for the patch!
Differential Revision: https://phabricator.kde.org/D2127

A  +160  -0krita/pics/tool_transform/dark_transform_icons_mirror_x.svg
A  +160  -0krita/pics/tool_transform/dark_transform_icons_mirror_y.svg
A  +104  -0krita/pics/tool_transform/dark_transform_icons_rotate_ccw.svg
A  +103  -0krita/pics/tool_transform/dark_transform_icons_rotate_cw.svg
A  +160  -0krita/pics/tool_transform/light_transform_icons_mirror_x.svg
A  +164  -0krita/pics/tool_transform/light_transform_icons_mirror_y.svg
A  +104  -0krita/pics/tool_transform/light_transform_icons_rotate_ccw.svg
A  +103  -0krita/pics/tool_transform/light_transform_icons_rotate_cw.svg
M  +8-1krita/pics/tool_transform/tool-transform-icons.qrc
M  +42   -0   
plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp
M  +5-0plugins/tools/tool_transform2/kis_tool_transform_config_widget.h
M  +139  -0plugins/tools/tool_transform2/wdg_tool_transform.ui

http://commits.kde.org/krita/efc2047b46c479ee2d0913c0a45e038be994c479

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363882] HSV/HSL adjustment filter with Colorize displays wrong hue values

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363882

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Fixed in master!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 352533] Add quick flip buttons to transform docker

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352533

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Dmitry Kazakov  ---
Fixed in master

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363334] Memory full when working with large files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363334

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||dimul...@gmail.com

--- Comment #15 from Dmitry Kazakov  ---
The bug should now be fixed in kazakov/memory-optimizations branch. If you see
the problem again, please reopen the bug! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #5 from Dmitry Kazakov  ---
Git commit 550ff114cbae42c33edb667981d091e2ac4346f5 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)

M  +72   -9libs/image/tiles3/kis_tile_data.cc

http://commits.kde.org/krita/550ff114cbae42c33edb667981d091e2ac4346f5

--- Comment #6 from Dmitry Kazakov  ---
Git commit a8f901e40fb7de35a29a4b4803ccbacab802c8bd by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Fix releasing the node pixes memory when closing the document

KisNodeFilterProxyModel should not store any pointers after the
image has been closed.

M  +1-1libs/image/kis_default_bounds.cpp
M  +9-0libs/ui/kis_node_filter_proxy_model.cpp
M  +2-0libs/ui/kis_node_filter_proxy_model.h
M  +1-1plugins/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/krita/a8f901e40fb7de35a29a4b4803ccbacab802c8bd

--- Comment #7 from Dmitry Kazakov  ---
Git commit 54282a72cee6256f29be9970793b32f6ffae6aa1 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.
Related: bug 363334

M  +0-1libs/ui/CMakeLists.txt
M  +8-1libs/ui/opengl/kis_opengl_image_textures.cpp
M  +4-0libs/ui/opengl/kis_opengl_image_textures.h
A  +156  -0libs/ui/opengl/kis_texture_tile_info_pool.h [License: GPL
(v2+)]
D  +0-22   libs/ui/opengl/kis_texture_tile_update_info.cpp
M  +58   -72   libs/ui/opengl/kis_texture_tile_update_info.h

http://commits.kde.org/krita/54282a72cee6256f29be9970793b32f6ffae6aa1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #5 from Dmitry Kazakov  ---
Git commit 550ff114cbae42c33edb667981d091e2ac4346f5 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)

M  +72   -9libs/image/tiles3/kis_tile_data.cc

http://commits.kde.org/krita/550ff114cbae42c33edb667981d091e2ac4346f5

--- Comment #6 from Dmitry Kazakov  ---
Git commit a8f901e40fb7de35a29a4b4803ccbacab802c8bd by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Fix releasing the node pixes memory when closing the document

KisNodeFilterProxyModel should not store any pointers after the
image has been closed.

M  +1-1libs/image/kis_default_bounds.cpp
M  +9-0libs/ui/kis_node_filter_proxy_model.cpp
M  +2-0libs/ui/kis_node_filter_proxy_model.h
M  +1-1plugins/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/krita/a8f901e40fb7de35a29a4b4803ccbacab802c8bd

--- Comment #7 from Dmitry Kazakov  ---
Git commit 54282a72cee6256f29be9970793b32f6ffae6aa1 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.
Related: bug 363334

M  +0-1libs/ui/CMakeLists.txt
M  +8-1libs/ui/opengl/kis_opengl_image_textures.cpp
M  +4-0libs/ui/opengl/kis_opengl_image_textures.h
A  +156  -0libs/ui/opengl/kis_texture_tile_info_pool.h [License: GPL
(v2+)]
D  +0-22   libs/ui/opengl/kis_texture_tile_update_info.cpp
M  +58   -72   libs/ui/opengl/kis_texture_tile_update_info.h

http://commits.kde.org/krita/54282a72cee6256f29be9970793b32f6ffae6aa1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363334] Memory full when working with large files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363334

--- Comment #14 from Dmitry Kazakov  ---
Git commit 54282a72cee6256f29be9970793b32f6ffae6aa1 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.
Related: bug 364848

M  +0-1libs/ui/CMakeLists.txt
M  +8-1libs/ui/opengl/kis_opengl_image_textures.cpp
M  +4-0libs/ui/opengl/kis_opengl_image_textures.h
A  +156  -0libs/ui/opengl/kis_texture_tile_info_pool.h [License: GPL
(v2+)]
D  +0-22   libs/ui/opengl/kis_texture_tile_update_info.cpp
M  +58   -72   libs/ui/opengl/kis_texture_tile_update_info.h

http://commits.kde.org/krita/54282a72cee6256f29be9970793b32f6ffae6aa1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #5 from Dmitry Kazakov  ---
Git commit 550ff114cbae42c33edb667981d091e2ac4346f5 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)

M  +72   -9libs/image/tiles3/kis_tile_data.cc

http://commits.kde.org/krita/550ff114cbae42c33edb667981d091e2ac4346f5

--- Comment #6 from Dmitry Kazakov  ---
Git commit a8f901e40fb7de35a29a4b4803ccbacab802c8bd by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Fix releasing the node pixes memory when closing the document

KisNodeFilterProxyModel should not store any pointers after the
image has been closed.

M  +1-1libs/image/kis_default_bounds.cpp
M  +9-0libs/ui/kis_node_filter_proxy_model.cpp
M  +2-0libs/ui/kis_node_filter_proxy_model.h
M  +1-1plugins/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/krita/a8f901e40fb7de35a29a4b4803ccbacab802c8bd

--- Comment #7 from Dmitry Kazakov  ---
Git commit 54282a72cee6256f29be9970793b32f6ffae6aa1 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.
Related: bug 363334

M  +0-1libs/ui/CMakeLists.txt
M  +8-1libs/ui/opengl/kis_opengl_image_textures.cpp
M  +4-0libs/ui/opengl/kis_opengl_image_textures.h
A  +156  -0libs/ui/opengl/kis_texture_tile_info_pool.h [License: GPL
(v2+)]
D  +0-22   libs/ui/opengl/kis_texture_tile_update_info.cpp
M  +58   -72   libs/ui/opengl/kis_texture_tile_update_info.h

http://commits.kde.org/krita/54282a72cee6256f29be9970793b32f6ffae6aa1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 365142] Clone_tool crash ctrl+LMB

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365142

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/38f27574c903b0d910911211a
   ||1f43cc1fbee0b39
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Dmitry Kazakov  ---
Git commit 38f27574c903b0d910911211a1f43cc1fbee0b39 by Dmitry Kazakov.
Committed on 13/07/2016 at 10:53.
Pushed by dkazakov into branch 'master'.

Fix a crash in KisToolPaint caused by a passed-through event

The paintop-based picking event should be eaten by the KisToolFreehand
and not being passed-through to KisToolPaint.
Fixes T3180

M  +11   -4libs/ui/tool/kis_tool_freehand.cc
M  +2-0libs/ui/tool/kis_tool_freehand.h

http://commits.kde.org/krita/38f27574c903b0d910911211a1f43cc1fbee0b39

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 365595] Let Mirror/Rotate Layer work with a selection when it is present and assign shortcuts

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365595

--- Comment #1 from Dmitry Kazakov  ---
Created attachment 100056
  --> https://bugs.kde.org/attachment.cgi?id=100056=edit
List of affected actions

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 352533] Add quick flip buttons to transform docker

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352533

--- Comment #4 from Dmitry Kazakov  ---
Added a merging adea as a separate bug 365595

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 365595] New: Let Mirror/Rotate Layer work with a selection when it is present and assign shortcuts

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365595

Bug ID: 365595
   Summary: Let Mirror/Rotate Layer work with a selection when it
is present and assign shortcuts
   Product: krita
   Version: git master
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: usability
  Assignee: krita-bugs-n...@kde.org
  Reporter: dimul...@gmail.com

All Layer Translformation actions (see atachment) should work in a universal
way, that is:

1) If there is a selection present, process the current selection on the
currently selected layer
2) If there is no selection, just process the whole layer bounds
3) It might be a good idea to have some shortcuts for mirroring and rotation
actions
4) They also should be renamed to conform with the new behavior

See bug 352533 as an initial idea.

WISHGROUP: Small Usability Fixes

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363921] Canvas is darkened and locked from further editing or saving, after leaving/re-entering virtual desktop

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363921

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/634b1a8421f2a36dd025d06bb
   ||5575f4a0e1a9706
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from Dmitry Kazakov  ---
Git commit 634b1a8421f2a36dd025d06bb5575f4a0e1a9706 by Dmitry Kazakov.
Committed on 22/06/2016 at 13:11.
Pushed by dkazakov into branch 'master'.

Fix unbalanced barrierLock() in KisCanvas2::slotSetDisplayProfile
Fixes T2940

M  +5-5libs/ui/canvas/kis_canvas2.cpp

http://commits.kde.org/krita/634b1a8421f2a36dd025d06bb5575f4a0e1a9706

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364074] Crash when creating a file with pixels greater than 2000*1790

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364074

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||dimul...@gmail.com
 Resolution|--- |WORKSFORME

--- Comment #1 from Dmitry Kazakov  ---
Hi, Rodrigo!

I tried to reproduce your problem by artificially limiting the available memory
to 4G. And I only get crashes when trying to open 3.5G file, when the system
has no swap file/partition.

Please try to do the following:

1) Check if you system has a swap-file and there is enough disk space for it.
2) Lower the amount of memory available to Krita to something like 1-1.5 GiB in
Settings->Preferences->Performance dialog.

This should solve the problem for you.

If the problem persists, please reopen the bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364037] Massive performance drop/lag when trying to move layers via drag and drop

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364037

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/7b1b729cf5643574ff049d13c
   ||624e8562fcd5770
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Dmitry Kazakov  ---
Git commit 7b1b729cf5643574ff049d13c624e8562fcd5770 by Dmitry Kazakov.
Committed on 21/06/2016 at 12:00.
Pushed by dkazakov into branch 'master'.

Add two patches for the Windows version of Qt

This effectively fixes the D stalls when Qt tried to
request entire QImage every time Windows asks it about the
list of supported mime types.
Related: bug 340736
CC:shawn.rutle...@qt.io

A  +37   -0   
3rdparty/ext_qt/0001-Don-t-request-the-MIME-image-every-time-Windows-asks.patch
A  +30   -03rdparty/ext_qt/0002-Hack-always-return-we-support-DIBV5.patch
M  +2-03rdparty/ext_qt/CMakeLists.txt

http://commits.kde.org/krita/7b1b729cf5643574ff049d13c624e8562fcd5770

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 340736] Very slow performance while changing layer orders

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=340736

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/7b1b729cf5643574ff049d13c
   ||624e8562fcd5770

--- Comment #25 from Dmitry Kazakov  ---
Git commit 7b1b729cf5643574ff049d13c624e8562fcd5770 by Dmitry Kazakov.
Committed on 21/06/2016 at 12:00.
Pushed by dkazakov into branch 'master'.

Add two patches for the Windows version of Qt

This effectively fixes the D stalls when Qt tried to
request entire QImage every time Windows asks it about the
list of supported mime types.
Related: bug 364037
CC:shawn.rutle...@qt.io

A  +37   -0   
3rdparty/ext_qt/0001-Don-t-request-the-MIME-image-every-time-Windows-asks.patch
A  +30   -03rdparty/ext_qt/0002-Hack-always-return-we-support-DIBV5.patch
M  +2-03rdparty/ext_qt/CMakeLists.txt

http://commits.kde.org/krita/7b1b729cf5643574ff049d13c624e8562fcd5770

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363921] Canvas is darkened and locked from further editing or saving, after leaving/re-entering virtual desktop

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363921

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #2 from Dmitry Kazakov  ---
Hi!

I'm using Ubuntu 16.04 with Unity and I have absolutely no crash or hangup with
switching the desktops. Could you please generate a backtrace of what Krita
does when it hangs up on your computer? Here is a manual how to do that:

http://nonaynever.ru/kwiki/krita/BugWritingGuidelines#Hangup_Bug

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 354979] [WALTOP] Crash in the selection of screen resolution under multiple display to use Tablet

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354979

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/942cb4b614246ad08485eaa22 |a/22c3c0d5d49ef164e4def4d54
   |64154de2d07ce17 |5faee7f37797a5f

--- Comment #2 from Dmitry Kazakov  ---
Git commit 22c3c0d5d49ef164e4def4d545faee7f37797a5f by Dmitry Kazakov.
Committed on 03/06/2016 at 12:48.
Pushed by dkazakov into branch 'krita/3.0'.

Add a workaround for weird tablets

Instead of the returning the size of the needed buffer these
"nice" tablet drivers start writing its name straight into
the buffer pointed by a null pointer.

See a comment in the code for more details
Related: bug 359298, bug 362868, bug 363684, bug 363873, bug 351059, bug 362948

M  +35   -2libs/ui/input/wintab/kis_tablet_support_win.cpp

http://commits.kde.org/krita/22c3c0d5d49ef164e4def4d545faee7f37797a5f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363873] krita stops working after any use of the "Adesso Cybertablet M14"

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363873

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/942cb4b614246ad08485eaa22 |a/22c3c0d5d49ef164e4def4d54
   |64154de2d07ce17 |5faee7f37797a5f

--- Comment #4 from Dmitry Kazakov  ---
Git commit 22c3c0d5d49ef164e4def4d545faee7f37797a5f by Dmitry Kazakov.
Committed on 03/06/2016 at 12:48.
Pushed by dkazakov into branch 'krita/3.0'.

Add a workaround for weird tablets

Instead of the returning the size of the needed buffer these
"nice" tablet drivers start writing its name straight into
the buffer pointed by a null pointer.

See a comment in the code for more details
Related: bug 359298, bug 362868, bug 363684, bug 351059, bug 354979, bug 362948

M  +35   -2libs/ui/input/wintab/kis_tablet_support_win.cpp

http://commits.kde.org/krita/22c3c0d5d49ef164e4def4d545faee7f37797a5f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 351059] [GENIUS] Krita crashes while using a genius tablet

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=351059

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/942cb4b614246ad08485eaa22 |a/22c3c0d5d49ef164e4def4d54
   |64154de2d07ce17 |5faee7f37797a5f

--- Comment #23 from Dmitry Kazakov  ---
Git commit 22c3c0d5d49ef164e4def4d545faee7f37797a5f by Dmitry Kazakov.
Committed on 03/06/2016 at 12:48.
Pushed by dkazakov into branch 'krita/3.0'.

Add a workaround for weird tablets

Instead of the returning the size of the needed buffer these
"nice" tablet drivers start writing its name straight into
the buffer pointed by a null pointer.

See a comment in the code for more details
Related: bug 359298, bug 362868, bug 363684, bug 363873, bug 354979, bug 362948

M  +35   -2libs/ui/input/wintab/kis_tablet_support_win.cpp

http://commits.kde.org/krita/22c3c0d5d49ef164e4def4d545faee7f37797a5f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 362948] [AIPTEK][VISTALK][ADESSO][TRUST][PERITAB] Krita crashes if I touch the tablet with the pen

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362948

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/942cb4b614246ad08485eaa22 |a/22c3c0d5d49ef164e4def4d54
   |64154de2d07ce17 |5faee7f37797a5f

--- Comment #27 from Dmitry Kazakov  ---
Git commit 22c3c0d5d49ef164e4def4d545faee7f37797a5f by Dmitry Kazakov.
Committed on 03/06/2016 at 12:48.
Pushed by dkazakov into branch 'krita/3.0'.

Add a workaround for weird tablets

Instead of the returning the size of the needed buffer these
"nice" tablet drivers start writing its name straight into
the buffer pointed by a null pointer.

See a comment in the code for more details
Related: bug 359298, bug 362868, bug 363684, bug 363873, bug 351059, bug 354979

M  +35   -2libs/ui/input/wintab/kis_tablet_support_win.cpp

http://commits.kde.org/krita/22c3c0d5d49ef164e4def4d545faee7f37797a5f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 359298] crash while use Genius MX-712 tablet (click, move pen, while focus on Krita window)

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359298

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/942cb4b614246ad08485eaa22 |a/22c3c0d5d49ef164e4def4d54
   |64154de2d07ce17 |5faee7f37797a5f

--- Comment #4 from Dmitry Kazakov  ---
Git commit 22c3c0d5d49ef164e4def4d545faee7f37797a5f by Dmitry Kazakov.
Committed on 03/06/2016 at 12:48.
Pushed by dkazakov into branch 'krita/3.0'.

Add a workaround for weird tablets

Instead of the returning the size of the needed buffer these
"nice" tablet drivers start writing its name straight into
the buffer pointed by a null pointer.

See a comment in the code for more details
Related: bug 362868, bug 363684, bug 363873, bug 351059, bug 354979, bug 362948

M  +35   -2libs/ui/input/wintab/kis_tablet_support_win.cpp

http://commits.kde.org/krita/22c3c0d5d49ef164e4def4d545faee7f37797a5f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 362868] [AIPTEK] Krita crashes upon putting the stylus back onto the tablet

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362868

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/942cb4b614246ad08485eaa22 |a/22c3c0d5d49ef164e4def4d54
   |64154de2d07ce17 |5faee7f37797a5f

--- Comment #14 from Dmitry Kazakov  ---
Git commit 22c3c0d5d49ef164e4def4d545faee7f37797a5f by Dmitry Kazakov.
Committed on 03/06/2016 at 12:48.
Pushed by dkazakov into branch 'krita/3.0'.

Add a workaround for weird tablets

Instead of the returning the size of the needed buffer these
"nice" tablet drivers start writing its name straight into
the buffer pointed by a null pointer.

See a comment in the code for more details
Related: bug 359298, bug 363684, bug 363873, bug 351059, bug 354979, bug 362948

M  +35   -2libs/ui/input/wintab/kis_tablet_support_win.cpp

http://commits.kde.org/krita/22c3c0d5d49ef164e4def4d545faee7f37797a5f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 363684] Krita crashes when I use my VisTablet Realm Pro pen/stylus.

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363684

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit
   |a/942cb4b614246ad08485eaa22 |a/22c3c0d5d49ef164e4def4d54
   |64154de2d07ce17 |5faee7f37797a5f

--- Comment #4 from Dmitry Kazakov  ---
Git commit 22c3c0d5d49ef164e4def4d545faee7f37797a5f by Dmitry Kazakov.
Committed on 03/06/2016 at 12:48.
Pushed by dkazakov into branch 'krita/3.0'.

Add a workaround for weird tablets

Instead of the returning the size of the needed buffer these
"nice" tablet drivers start writing its name straight into
the buffer pointed by a null pointer.

See a comment in the code for more details
Related: bug 359298, bug 362868, bug 363873, bug 351059, bug 354979, bug 362948

M  +35   -2libs/ui/input/wintab/kis_tablet_support_win.cpp

http://commits.kde.org/krita/22c3c0d5d49ef164e4def4d545faee7f37797a5f

-- 
You are receiving this mail because:
You are watching all bug changes.