[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 --- Comment #11 from Ellie --- Created attachment 168624 --> https://bugs.kde.org/attachment.cgi?id=168624=edit New crash information added by DrKonqi spectacle (23.08.4) using Qt 5.15.12 I was clicking "finish recording", it was a recoding of a specific window and fairly short. -- Backtrace (Reduced): #4 0x7f1a9710b0c0 in QQuickView::rootObject() const () at /lib64/libQt5Quick.so.5 #5 0x56429ac886dd in ViewerWindow::showInlineMessage(QString const&, QMap const&) (this=0x0, qmlFile=..., properties=...) at /usr/src/debug/spectacle-23.08.4/src/Gui/ViewerWindow.cpp:146 #6 0x56429ac78985 in ViewerWindow::showSavedVideoMessage(QUrl const&) (messageArgument=..., this=0x0) at /usr/src/debug/spectacle-23.08.4/src/Gui/ViewerWindow.cpp:161 #7 operator() (path=, __closure=0x56429ca1f110) at /usr/src/debug/spectacle-23.08.4/src/SpectacleCore.cpp:233 #10 QtPrivate::QFunctorSlotObject, 1, QtPrivate::List, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void **, bool *) (which=, this_=0x56429ca1f100, r=, a=, ret=) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:443 -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 Ellie changed: What|Removed |Added CC||e...@horse64.org -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 Nate Graham changed: What|Removed |Added Resolution|FIXED |DUPLICATE --- Comment #10 from Nate Graham --- *** This bug has been marked as a duplicate of bug 469336 *** -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #9 from Nate Graham --- Fixed with the commits in https://invent.kde.org/graphics/spectacle/-/merge_requests/283. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/279 -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556
--- Comment #7 from Noah Davis ---
(In reply to David Edmundson from comment #6)
> I should have read this:
>
> #7 0x0046429e in ViewerWindow::showSavedVideoMessage(QUrl const&)
> (this=0x0, messageArgument=...) at
> /home/nate/kde/src/spectacle/src/Gui/ViewerWindow.cpp:152
>
> this=0
>
> ViewerWindow is not instantiated. The lifespan is managed by something else
> and there's effectively a weakpointer for the singleton.
>
> connect(m_videoPlatform.get(), ::recordingSaved, this,
> [this](const QString ) {
> const QUrl url = QUrl::fromUserInput(path, {},
> QUrl::AssumeLocalFile);
> ViewerWindow::instance()->showSavedVideoMessage(url);
>
> and several other places are not guarding ViewerWindow::instance().
>
> It should be either guarded or we should figure the lifespan
What's really weird about this is that it should currently be impossible to
activate this code in a situation where the ViewerWindow is null. You can
currently only start and stop recording while a ViewerWindow is open.
--
You are receiving this mail because:
You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556
David Edmundson changed:
What|Removed |Added
Status|REPORTED|CONFIRMED
Ever confirmed|0 |1
--- Comment #6 from David Edmundson ---
I should have read this:
#7 0x0046429e in ViewerWindow::showSavedVideoMessage(QUrl const&)
(this=0x0, messageArgument=...) at
/home/nate/kde/src/spectacle/src/Gui/ViewerWindow.cpp:152
this=0
ViewerWindow is not instantiated. The lifespan is managed by something else and
there's effectively a weakpointer for the singleton.
connect(m_videoPlatform.get(), ::recordingSaved, this,
[this](const QString ) {
const QUrl url = QUrl::fromUserInput(path, {}, QUrl::AssumeLocalFile);
ViewerWindow::instance()->showSavedVideoMessage(url);
and several other places are not guarding ViewerWindow::instance().
It should be either guarded or we should figure the lifespan
--
You are receiving this mail because:
You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 --- Comment #5 from Noah Davis --- (In reply to David Edmundson from comment #4) > >#5 0x7fd936cdb5f4 in QQuickView::rootObject() const () at > >/lib64/libQt6Quick.so.6 > > This is typically a sign that QML failed to load, hence no root object. > This could mean a missing import on the user. In either case spectacle > should report any QML errors to stderr and exit gracefully. That was one of my first thoughts, but I asked Nate to put a Q_ASSERT(rootObject() != nullptr) there and he said it didn't trigger. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #4 from David Edmundson --- >#5 0x7fd936cdb5f4 in QQuickView::rootObject() const () at >/lib64/libQt6Quick.so.6 This is typically a sign that QML failed to load, hence no root object. This could mean a missing import on the user. In either case spectacle should report any QML errors to stderr and exit gracefully. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 --- Comment #3 from Noah Davis --- Could you tell me exactly what you're doing and what settings related to saving videos you have? I am unable to reproduce the crash. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 Nate Graham changed: What|Removed |Added Version|23.04.1 |git-master --- Comment #2 from Nate Graham --- It was indeed with git master, sorry. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 --- Comment #1 from Noah Davis --- I see this bug report is for 23.04.1. Do you have the same bug with git master? -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 474556] Crash in ViewerWindow::showInlineMessage() when stopping recording with Webm
https://bugs.kde.org/show_bug.cgi?id=474556 Bug Janitor Service changed: What|Removed |Added Severity|normal |crash -- You are receiving this mail because: You are watching all bug changes.
