[frameworks-ki18n] [Bug 365917] ki18n fails to link on musl libc due to _nl_msg_cat_cntr

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=365917

Michael Pyne  changed:

   What|Removed |Added

   Version Fixed In||5.49.0
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/ki1
   ||8n/543b8ae67c57500bf3cabde7
   ||5bf1599904d6e482

--- Comment #6 from Michael Pyne  ---
Git commit 543b8ae67c57500bf3cabde75bf1599904d6e482 by Michael Pyne, on behalf
of A. Wilcox.
Committed on 15/07/2018 at 18:08.
Pushed by mpyne into branch 'master'.

libintl: Determine if _nl_msg_cat_cntr exists before use

Using GNU gettext does not guarantee that GNU libintl will be used. This
assumption breaks the build when using musl libc (which does implement
libintl, but does so without using internal GNU symbols).
FIXED-IN:5.49.0

M  +1-0.gitignore
M  +3-0CMakeLists.txt
M  +3-0cmake/FindLibIntl.cmake
A  +25   -0src/config.h.in
M  +3-2src/kcatalog.cpp

https://commits.kde.org/ki18n/543b8ae67c57500bf3cabde75bf1599904d6e482

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 365917] ki18n fails to link on musl libc due to _nl_msg_cat_cntr

[awilfox]

https://bugs.kde.org/show_bug.cgi?id=365917

A. Wilcox (awilfox)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from A. Wilcox (awilfox)  ---
I didn't have a Phabricator account at the time I reported this bug, and I lost
track of this bug when I brought the other patches over to Phabricator.  Sorry!

Yes, GNU libintl on Alpine will override musl.  We're shipping gettext-tiny in
Adélie now, which has a tiny libintl.a containing only this symbol and a few
others that are needed.  However, since "libintl is part of libc", ki18n still
won't link to it, and still fails with this error.

Thank you for the style notes, Michael; I'll be sure to keep them in mind for
any future patches I write.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 365917] ki18n fails to link on musl libc due to _nl_msg_cat_cntr

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=365917

Michael Pyne  changed:

   What|Removed |Added

 CC||mp...@kde.org

--- Comment #4 from Michael Pyne  ---
The patch as attached looks stylistically correct to me, using a CMake check to
generate a config.h file that would then be used for the include guard. That's
also how I'd do it, and I wouldn't have even bothered to fix the .gitignore
myself.

However the patch wouldn't have worked directly (the fix to FindLibIntl.cmake
uses "HAVE_..." while the code checks for "HAS_..."). Also I'd use a namespaced
include guard in config.h (e.g. "#ifndef KF5_KI18N_CONFIG_H ..." instead of
"#ifndef CONFIG_H"), but that's more about residual trauma from --enable-final
builds back in the day.

Since we've already got a soft +1 on this patch already I'll go ahead and
commit the corrected patch in the next day or two if there's no objections from
here.

P.S. I've previously built all of KF5 on Alpine Linux (also using musl libc)
while testing Docker, but I think that had worked because I had also installed
GNU libintl, presumably that overrides the musl libintl if both exist?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 365917] ki18n fails to link on musl libc due to _nl_msg_cat_cntr

[Heiko Becker]

https://bugs.kde.org/show_bug.cgi?id=365917

Heiko Becker  changed:

   What|Removed |Added

 CC||heire...@exherbo.org

--- Comment #3 from Heiko Becker  ---
I was just pointed to this bug by a musl user on my distro.

What's the status of this patch. Why wasn't it posted to phabricator?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 365917] ki18n fails to link on musl libc due to _nl_msg_cat_cntr

[Chusslove Illich via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365917

Chusslove Illich  changed:

   What|Removed |Added

 CC||caslav.i...@gmx.net,
   ||fa...@kde.org

--- Comment #2 from Chusslove Illich  ---
The patch seems fine to me, but this is also the question of which conventions
we follow for this type of configuration in CMake, and that I'm not so sure
about. So for the moment I'll just add someone who knows better, or knows who
knows better, to CC.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 365917] ki18n fails to link on musl libc due to _nl_msg_cat_cntr

[awilfox]

https://bugs.kde.org/show_bug.cgi?id=365917

--- Comment #1 from A. Wilcox (awilfox)  ---
Created attachment 100223
  --> https://bugs.kde.org/attachment.cgi?id=100223=edit
Patch to ki18n to check for presence of _nl_msg_cat_cntr before using it

I cannot upload to Gerrit using my KDE Identity account (awilcox) so I am
submitting the patch here.  This patch allows ki18n (tested on 5.21.0, 5.24.0,
and master) to build on both glibc (using _nl_msg_cat_cntr) and musl (without
using _nl_msg_cat_cntr).

-- 
You are receiving this mail because:
You are watching all bug changes.