[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Andreas Hartmetz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #79 from Andreas Hartmetz  ---
For the record, konsole had a separate session restore bug (bug 367447) which
has also been fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

Rex Dieter  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #78 from Rex Dieter  ---
closing as requested, thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Wolfram via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #77 from Wolfram  ---
I upgraded to Kubuntu 16.10 yesterday. As i can say, now all is working as it
did before upgrading to 15.04, one and a half year ago.
>From my opinion this thread can be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #76 from cach...@yahoo.com ---
(In reply to cacho96 from comment #75)
> (In reply to Jonathan Wakely from comment #74)
> > (In reply to Mark T. Kennedy from comment #73)
> > > konsole session saving does *not* work in fedora 23 (tested with a brand 
> > > new
> > > ID).  haven't tried 24 beta yet.  but 23 is definitely (for me) unusable
> > > because of this.
> > 
> > It works if you change the Desktop Session settings to "Restore manually
> > saved session" and manually save the session before exiting the session. It
> > doesn't work if you use "Restore previous session" (which is supposed to
> > automatically save and restore the session).
> 
> Certainly not for me. All my consoles are gone, and I have never have
> anything but "Restore manually saved session".

BTW, this is not a konsole problem. I use 5 rxvt's. My rxvt's are not shown
(yet present in the session file), but when I open rxvt's with my shortcut, one
by one appear again with placement and sizes as they should. Very strange.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

cach...@yahoo.com changed:

   What|Removed |Added

 CC||cach...@yahoo.com

--- Comment #75 from cach...@yahoo.com ---
(In reply to Jonathan Wakely from comment #74)
> (In reply to Mark T. Kennedy from comment #73)
> > konsole session saving does *not* work in fedora 23 (tested with a brand new
> > ID).  haven't tried 24 beta yet.  but 23 is definitely (for me) unusable
> > because of this.
> 
> It works if you change the Desktop Session settings to "Restore manually
> saved session" and manually save the session before exiting the session. It
> doesn't work if you use "Restore previous session" (which is supposed to
> automatically save and restore the session).

Certainly not for me. All my consoles are gone, and I have never have anything
but "Restore manually saved session".

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Mark T . Kennedy via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #73 from Mark T. Kennedy  ---
konsole session saving does *not* work in fedora 23 (tested with a brand new
ID).  haven't tried 24 beta yet.  but 23 is definitely (for me) unusable
because of this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Wolfram via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #72 from Wolfram  ---
In KDE Neon it seems to work now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[George R . Goffe via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #71 from George R. Goffe  ---
Hi,

Please accept my apologies for this out of bandwidth response.

Maybe "we" should abandon all the distributions that use 5.5 and go  with
Fedora Rawhide? I'm sure that would get someone's attention. I use Fedora 23
and Rawhide (24) and don't seem to have these problems.

George...

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Jason Tibbitts via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #70 from Jason Tibbitts  ---
I've seen session management in Fedora 23 testing get better when qt5.6 was
first introduced and indeed had a few session restores which were 100% complete
and repeatable, but then it's gotten worse again.  However, I haven't seen the
issue mentioned in this ticket (konsole not saving tabs or preferences) in
quite some time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Wolfram via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #69 from Wolfram  ---
(In reply to Andreas Hartmetz from comment #68)
> Kubuntu 16.04 does not have Qt 5.6, so session management is not expected to
> work right in it.

But KDE-Neon has, and it does not work either.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Andreas Hartmetz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #68 from Andreas Hartmetz  ---
Kubuntu 16.04 does not have Qt 5.6, so session management is not expected to
work right in it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Wolfram via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #67 from Wolfram  ---
Since yesterday I upgraded to Kubuntu 16.04 and nothing has improved. It's even
worse, because now hibernation, my only workaround, does'n work anymore.
That should be no surprise, because they stick to qt 5.5 and as I could read
here, the problems are fixed in only within qt 5.6. So, because not able to
build my own KDE, I'm depending on the backport team. But even on the staging
branch, no one seems to be working on it actually.

An attempt with KDE-Neon in a virtual-machine gave this result:
Konsole-settings are totally broken. Not even the appearance is restored after
restart.

Are there too few people like us having these problems ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Mark T . Kennedy via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

Mark T. Kennedy  changed:

   What|Removed |Added

 CC||m...@acm.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Andreas Hartmetz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

Andreas Hartmetz  changed:

   What|Removed |Added

 CC||ahartm...@gmail.com

--- Comment #66 from Andreas Hartmetz  ---
Is the following correct:
- Things are mostly fixed now
- The ksmserver patch is still needed to make aborted shutdown/logout work
correctly?
If so, I'm planning to have a look at the ksmserver patch (no promises). The
logic in ksmserver does look dubious to me, on the other hand it has worked
alright for a long time so one needs to be very careful.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Alexey Chernov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #63 from Alexey Chernov <4er...@gmail.com> ---
(In reply to John Stanley from comment #62)
> (In reply to Alexey Chernov from comment #61)
> > (In reply to John Stanley from comment #60)
> > > (In reply to Alexey Chernov from comment #56)
> > > > I've just applied and quite intensively tested two patches John 
> > > > attached.
> > > > 
> > > > At first for patches: I've actually looked through them before 
> > > > applying, and
> > > > there're a couple of questions:
> > > > 
> > > > 1. I've modified kxmlgui patch a little — at first I've replaces close 
> > > > event
> > > > stuff for calling queryClose() method. Following XSM protocol one is not
> > > > allowed to close windows on the saving state as a) this is not necessary
> > > > shutdown that save-yourself is triggered , it is explicitly stated in 
> > > > the
> > > > documentation, and b) shutdown, if any, could normally be cancelled and
> > > > session would continue, and closing some windows would just spoil this
> > > > user's session.
> > > Agreed. But, the close event here is actually "fake", no windows are
> > > actually closed. In tracing queryClose(), it seemed appropriate to hook
> > > KMainWindow::closeEvent() in KMainWindow::commitData() to pick up the 
> > > "auto
> > > save" functionality in KMainWindow::closeEvent(). 
> > > KMainWindow::closeEvent()
> > > potentially does some KMainWindow-specific auto saving, and then simply
> > > calls queryClose().
> > > Anyway, I'm happy to go with your call on this, but have a look at
> > > KMainWindow::closeEvent() if you haven't already.
> > 
> > Yeah, I've looked at it just briefly applying the patch and now have looked
> > closer. As far as I can see, it still can close window as soon as
> > queryClose() returns true (as it accepts the event). But you're right that
> > there's some code of auto-saving, yes.
> > 
> Yea, but, in this case we are instigating the CloseEvent (not Qt via
> close()/quit() for example), and so as I understand it, no actual close will
> be triggered by event acceptance here. That is, I thought that an actual
> close is done by Qt in, e.g., the close() method after Qt does a sendEvent()
> and checks for acceptance Here, we only use sendEvent() to decide whether or
> not to cancel the session

Yes, you're probably right then, since we send close event by ourselves. I
think, it's quite easy to test this as well — just left one client untouched
and another one with modifications before logging out, cancel the shutdown in
the latter and see what happens. I believe, you have tried the initial version
of the patch, did you happen to follow this scenario?

> > Another problem arises in that basically the client should ask session
> > manager a permission to interact with the user to get the monopoly
> > attention, but it's not so, as queryClose doesn't have any clue of session
> > manager, it just shows the dialog. But still such things are minor, we need
> > to bring back session restore first.
> > 
> > > > Another thing I removed is restore() method which is obviously the same 
> > > > as
> > > > before, but always returns false. Is there any reason for it?
> > > >
> > > The  KMainWindow::restore() currently always returns false, which is not
> > > useful for apps that choose to iterate over windows for multi-window
> > > restorations (using a false return code terminate iteration). My change is
> > > to return true on successful restoration, and false otherwise.
> > 
> > Oh, yes, didn't notice, thanks for pointing out.
> > 
> > > > 2. KSMServer patch is what I first have tried not to apply at all. 
> > > > Except
> > > > the first edit, which seems to be right as it's just follows the 
> > > > comment,
> > > > other stuff seems to be redundant. Could you please explain you ideas 
> > > > behind
> > > > these changes? Anyway, everything works even without it (see below).
> > > > 
> > > Yup, the first edit is the only important one. The others, well, I was
> > > tinkering a bit, and thinking of doing more, but its a bit 
> > > time-consuming; I
> > > should have removed them before posting. The final two edits are merely 
> > > code
> > > restructuring, no functional changes, should've removed 'em. The remaining
> > > edits, associated with "Phase 2 for non-WM clients", are an attempt to 
> > > allow
> > > non-WM apps which want to do their shutdown processing in Phase 2 to do so
> > > before the WM is shutdown (also in Phase 2). I don't specifically know of
> > > any such apps, but, in principle there could be. 
> > 
> > OK.
> > 
> > > > As for testing, I've tested the following use cases:
> > > > 
> > > > 1. Plain saving session. It's generally works even without any patches
> > > > (except Qt patch https://codereview.qt-project.org/#/c/140115 I've 
> > > > applied
> > > > much earlier). Works fine.
> > > > 
> > > > 2. Saving session with several "modified" clients — in my case it was 
> > > > KWrite
> > > > with 

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[John Stanley via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #64 from John Stanley  ---
(In reply to Alexey Chernov from comment #63)
> (In reply to John Stanley from comment #62)
> > (In reply to Alexey Chernov from comment #61)
> > > (In reply to John Stanley from comment #60)
> > > > (In reply to Alexey Chernov from comment #56)
> > > > > I've just applied and quite intensively tested two patches John 
> > > > > attached.
> > > > > 
> > > > > At first for patches: I've actually looked through them before 
> > > > > applying, and
> > > > > there're a couple of questions:
> > > > > 
> > > > > 1. I've modified kxmlgui patch a little — at first I've replaces 
> > > > > close event
> > > > > stuff for calling queryClose() method. Following XSM protocol one is 
> > > > > not
> > > > > allowed to close windows on the saving state as a) this is not 
> > > > > necessary
> > > > > shutdown that save-yourself is triggered , it is explicitly stated in 
> > > > > the
> > > > > documentation, and b) shutdown, if any, could normally be cancelled 
> > > > > and
> > > > > session would continue, and closing some windows would just spoil this
> > > > > user's session.
> > > > Agreed. But, the close event here is actually "fake", no windows are
> > > > actually closed. In tracing queryClose(), it seemed appropriate to hook
> > > > KMainWindow::closeEvent() in KMainWindow::commitData() to pick up the 
> > > > "auto
> > > > save" functionality in KMainWindow::closeEvent(). 
> > > > KMainWindow::closeEvent()
> > > > potentially does some KMainWindow-specific auto saving, and then simply
> > > > calls queryClose().
> > > > Anyway, I'm happy to go with your call on this, but have a look at
> > > > KMainWindow::closeEvent() if you haven't already.
> > > 
> > > Yeah, I've looked at it just briefly applying the patch and now have 
> > > looked
> > > closer. As far as I can see, it still can close window as soon as
> > > queryClose() returns true (as it accepts the event). But you're right that
> > > there's some code of auto-saving, yes.
> > > 
> > Yea, but, in this case we are instigating the CloseEvent (not Qt via
> > close()/quit() for example), and so as I understand it, no actual close will
> > be triggered by event acceptance here. That is, I thought that an actual
> > close is done by Qt in, e.g., the close() method after Qt does a sendEvent()
> > and checks for acceptance Here, we only use sendEvent() to decide whether or
> > not to cancel the session
> 
> Yes, you're probably right then, since we send close event by ourselves. I
> think, it's quite easy to test this as well — just left one client untouched
> and another one with modifications before logging out, cancel the shutdown
> in the latter and see what happens. I believe, you have tried the initial
> version of the patch, did you happen to follow this scenario?

I did do a quick 'n dirty check with konsole (had to patch konsole's
MainWindow::queryClose() to allow session cancellation though): open several
apps plus konsole, launch vi in konsole, attempt to logout, refuse, and it
works as expected -- session is canceled and windows remain open,

> 
> > > Another problem arises in that basically the client should ask session
> > > manager a permission to interact with the user to get the monopoly
> > > attention, but it's not so, as queryClose doesn't have any clue of session
> > > manager, it just shows the dialog. But still such things are minor, we 
> > > need
> > > to bring back session restore first.
> > > 
> > > > > Another thing I removed is restore() method which is obviously the 
> > > > > same as
> > > > > before, but always returns false. Is there any reason for it?
> > > > >
> > > > The  KMainWindow::restore() currently always returns false, which is not
> > > > useful for apps that choose to iterate over windows for multi-window
> > > > restorations (using a false return code terminate iteration). My change 
> > > > is
> > > > to return true on successful restoration, and false otherwise.
> > > 
> > > Oh, yes, didn't notice, thanks for pointing out.
> > > 
> > > > > 2. KSMServer patch is what I first have tried not to apply at all. 
> > > > > Except
> > > > > the first edit, which seems to be right as it's just follows the 
> > > > > comment,
> > > > > other stuff seems to be redundant. Could you please explain you ideas 
> > > > > behind
> > > > > these changes? Anyway, everything works even without it (see below).
> > > > > 
> > > > Yup, the first edit is the only important one. The others, well, I was
> > > > tinkering a bit, and thinking of doing more, but its a bit 
> > > > time-consuming; I
> > > > should have removed them before posting. The final two edits are merely 
> > > > code
> > > > restructuring, no functional changes, should've removed 'em. The 
> > > > remaining
> > > > edits, associated with "Phase 2 for non-WM clients", are an attempt to 
> > > > allow
> > > > non-WM apps which want to do their shutdown processing 

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[John Stanley via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

John Stanley  changed:

   What|Removed |Added

  Attachment #95381|0   |1
is obsolete||

--- Comment #65 from John Stanley  ---
Created attachment 97078
  --> https://bugs.kde.org/attachment.cgi?id=97078=edit
Updated plasma-workspace SM patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Alexey Chernov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #61 from Alexey Chernov <4er...@gmail.com> ---
(In reply to John Stanley from comment #60)
> (In reply to Alexey Chernov from comment #56)
> > I've just applied and quite intensively tested two patches John attached.
> > 
> > At first for patches: I've actually looked through them before applying, and
> > there're a couple of questions:
> > 
> > 1. I've modified kxmlgui patch a little — at first I've replaces close event
> > stuff for calling queryClose() method. Following XSM protocol one is not
> > allowed to close windows on the saving state as a) this is not necessary
> > shutdown that save-yourself is triggered , it is explicitly stated in the
> > documentation, and b) shutdown, if any, could normally be cancelled and
> > session would continue, and closing some windows would just spoil this
> > user's session.
> Agreed. But, the close event here is actually "fake", no windows are
> actually closed. In tracing queryClose(), it seemed appropriate to hook
> KMainWindow::closeEvent() in KMainWindow::commitData() to pick up the "auto
> save" functionality in KMainWindow::closeEvent(). KMainWindow::closeEvent()
> potentially does some KMainWindow-specific auto saving, and then simply
> calls queryClose().
> Anyway, I'm happy to go with your call on this, but have a look at
> KMainWindow::closeEvent() if you haven't already.

Yeah, I've looked at it just briefly applying the patch and now have looked
closer. As far as I can see, it still can close window as soon as queryClose()
returns true (as it accepts the event). But you're right that there's some code
of auto-saving, yes.

Another problem arises in that basically the client should ask session manager
a permission to interact with the user to get the monopoly attention, but it's
not so, as queryClose doesn't have any clue of session manager, it just shows
the dialog. But still such things are minor, we need to bring back session
restore first.

> > Another thing I removed is restore() method which is obviously the same as
> > before, but always returns false. Is there any reason for it?
> >
> The  KMainWindow::restore() currently always returns false, which is not
> useful for apps that choose to iterate over windows for multi-window
> restorations (using a false return code terminate iteration). My change is
> to return true on successful restoration, and false otherwise.

Oh, yes, didn't notice, thanks for pointing out.

> > 2. KSMServer patch is what I first have tried not to apply at all. Except
> > the first edit, which seems to be right as it's just follows the comment,
> > other stuff seems to be redundant. Could you please explain you ideas behind
> > these changes? Anyway, everything works even without it (see below).
> > 
> Yup, the first edit is the only important one. The others, well, I was
> tinkering a bit, and thinking of doing more, but its a bit time-consuming; I
> should have removed them before posting. The final two edits are merely code
> restructuring, no functional changes, should've removed 'em. The remaining
> edits, associated with "Phase 2 for non-WM clients", are an attempt to allow
> non-WM apps which want to do their shutdown processing in Phase 2 to do so
> before the WM is shutdown (also in Phase 2). I don't specifically know of
> any such apps, but, in principle there could be. 

OK.

> > As for testing, I've tested the following use cases:
> > 
> > 1. Plain saving session. It's generally works even without any patches
> > (except Qt patch https://codereview.qt-project.org/#/c/140115 I've applied
> > much earlier). Works fine.
> > 
> > 2. Saving session with several "modified" clients — in my case it was KWrite
> > with unsaved document and Konsole with "vim" running in one of the tabs. On
> > logging out I was gently and sequencially asked for both KWrite and Konsole.
> > Saved nothing and logged out. Works fine.
> > 
> > 3. Triggering session save with several "modified" clients and cancel
> > logging out in one of them. In my case they were KWrite again with an
> > unsaved document and Kate with an unsaved document. Here I tried two
> > sub-clauses:
> > 
> > a) at first, say "don't save" to KWrite and "Cancel" to Kate. Session
> > continued successfully, no data is lost in both programs. Just KWin moved
> > both of them to "Any virtual desktop" — it's apparently the default
> > behaviour, appropriate for now. So works fine;
> > 
> > b) finally, say "save" to KWrite and "don't save" to Kate. Session
> > finished and then restored successfully except Kate crashed, which is
> > apparently separate bug in Kate, which I will address, too. In terms of SM
> > works fine.
> > 
> > As a conclusion, I think, this patch can be candidate for merge right now
> > without even waiting for Qt patch — there's no harm in saving documents
> > beforehand, but, of course, without Qt changes of this report:
> > https://codereview.qt-project.org/#/c/140115 applications won't 

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Alexey Chernov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #59 from Alexey Chernov <4er...@gmail.com> ---
(In reply to John Stanley from comment #58)
> First, thanks so much for looking at this issue.
> No I haven't posted to the  KDE Reviewboard ; give me a day or two max to
> orient myself, and I'll do so.

Yes, no problem. Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[John Stanley via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #60 from John Stanley  ---
(In reply to Alexey Chernov from comment #56)
> I've just applied and quite intensively tested two patches John attached.
> 
> At first for patches: I've actually looked through them before applying, and
> there're a couple of questions:
> 
> 1. I've modified kxmlgui patch a little — at first I've replaces close event
> stuff for calling queryClose() method. Following XSM protocol one is not
> allowed to close windows on the saving state as a) this is not necessary
> shutdown that save-yourself is triggered , it is explicitly stated in the
> documentation, and b) shutdown, if any, could normally be cancelled and
> session would continue, and closing some windows would just spoil this
> user's session.
Agreed. But, the close event here is actually "fake", no windows are actually
closed. In tracing queryClose(), it seemed appropriate to hook
KMainWindow::closeEvent() in KMainWindow::commitData() to pick up the "auto
save" functionality in KMainWindow::closeEvent(). KMainWindow::closeEvent()
potentially does some KMainWindow-specific auto saving, and then simply calls
queryClose().
Anyway, I'm happy to go with your call on this, but have a look at
KMainWindow::closeEvent() if you haven't already.
> 
> Another thing I removed is restore() method which is obviously the same as
> before, but always returns false. Is there any reason for it?
>
The  KMainWindow::restore() currently always returns false, which is not useful
for apps that choose to iterate over windows for multi-window restorations
(using a false return code terminate iteration). My change is to return true on
successful restoration, and false otherwise.

> 2. KSMServer patch is what I first have tried not to apply at all. Except
> the first edit, which seems to be right as it's just follows the comment,
> other stuff seems to be redundant. Could you please explain you ideas behind
> these changes? Anyway, everything works even without it (see below).
> 
Yup, the first edit is the only important one. The others, well, I was
tinkering a bit, and thinking of doing more, but its a bit time-consuming; I
should have removed them before posting. The final two edits are merely code
restructuring, no functional changes, should've removed 'em. The remaining
edits, associated with "Phase 2 for non-WM clients", are an attempt to allow
non-WM apps which want to do their shutdown processing in Phase 2 to do so
before the WM is shutdown (also in Phase 2). I don't specifically know of any
such apps, but, in principle there could be. 

> As for testing, I've tested the following use cases:
> 
> 1. Plain saving session. It's generally works even without any patches
> (except Qt patch https://codereview.qt-project.org/#/c/140115 I've applied
> much earlier). Works fine.
> 
> 2. Saving session with several "modified" clients — in my case it was KWrite
> with unsaved document and Konsole with "vim" running in one of the tabs. On
> logging out I was gently and sequencially asked for both KWrite and Konsole.
> Saved nothing and logged out. Works fine.
> 
> 3. Triggering session save with several "modified" clients and cancel
> logging out in one of them. In my case they were KWrite again with an
> unsaved document and Kate with an unsaved document. Here I tried two
> sub-clauses:
> 
> a) at first, say "don't save" to KWrite and "Cancel" to Kate. Session
> continued successfully, no data is lost in both programs. Just KWin moved
> both of them to "Any virtual desktop" — it's apparently the default
> behaviour, appropriate for now. So works fine;
> 
> b) finally, say "save" to KWrite and "don't save" to Kate. Session
> finished and then restored successfully except Kate crashed, which is
> apparently separate bug in Kate, which I will address, too. In terms of SM
> works fine.
> 
> As a conclusion, I think, this patch can be candidate for merge right now
> without even waiting for Qt patch — there's no harm in saving documents
> beforehand, but, of course, without Qt changes of this report:
> https://codereview.qt-project.org/#/c/140115 applications won't be restarted.
> 
> I'm attaching the patch with my modification. If there's no objection, John,
> I'd suggest you as original author to post it to https://reviewboard.kde.org
> so that we can have it reviewed and potentially merged as soon as possible.

Thanks again for the help and interest and I'll get on the
https://reviewboard.kde.org post asap.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[John Stanley via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #58 from John Stanley  ---
(In reply to Alexey Chernov from comment #55)
> (In reply to John Stanley from comment #51)
> > (In reply to Wolfram from comment #50)
> > > (In reply to John Stanley from comment #47)
> > > > (In reply to Wolfram from comment #46)
> > > > > (In reply to John Stanley from comment #43)
> > > > > > Sorry about the the links in Comment 41, (3); there are two links 
> > > > > > there,
> > > > > > separated by a comma:
> > > > > >   https://bugreports.qt.io/browse/QTBUG-49241
> > > > > >   https://codereview.qt-project.org/#/c/140115/
> > > > > > 
> > > > > > As far as building, you need to rebuild three packages:
> > > > > >   qtbase-5.5.1 (
> > > > > > http://download.qt.io/official_releases/qt/5.5/5.5.1/submodules/qtbase-
> > > > > > opensource-src-5.5.1.tar.xz )
> > > > > >   kxmlgui-5.15.0 (
> > > > > > http://download.kde.org/stable/frameworks/5.15/kxmlgui-5.15.0.tar.xz
> > > > > >  )
> > > > > >   plasma-workspace-5.4.2 (
> > > > > > http://download.kde.org/stable/plasma/5.4.2/plasma-workspace-5.4.2.tar.xz
> > > > > >  )
> > > > > > Assuming you already have these installed, the build order is 
> > > > > > immaterial,
> > > > > > otherwise build in the order shown.
> > > > > 
> > > > > are the patches included in the tarballs ?
> > > > 
> > > > The 3 patches, three separate files, one for each package/tarball, are 
> > > > given
> > > > in Comment 44; they have to be applied before building/rebuilding each
> > > > package.
> > > 
> > > Is your patch implemented in KDE by now ?
> > > 
> > > Because I was not able to compile the environment until now (see Comment
> > > 48), I just installed Kubuntu 15.10 in a virtual machine with
> > > 'kubuntu-ppa/staging-plasma' activated. There they use the newest plasma
> > > version 5.5.3. As result I can say, that the the session management 
> > > problems
> > > still exist in that version.
> > 
> > Sorry, for the delay. I've pretty much given up on both KDE and Qt regarding
> > this, no movement at all, no one appears to care -- so, no,  the patches are
> > not in the latest KDE (5.5.3/5.18.0). It'd be nice, at least, if someone
> > would explain why there's no interest..
> 
> I think it's partially due to some bugs were closed as duplicate of bug
> #341930 which continued as bug #354724, there've happened to be several
> discussions recently, with somewhat contradictory approach with which I
> personally disagree. I tend to fully support you review request to Qt, set
> +1 there, and you KDE patches look good as well, it's a shame I just came
> accross these reports, just after you posted a link in Gerrit. I've got all
> the KDE stuff compiled from sources, so it's no problem to try and test you
> patches which I plan to do right away and give them some time of every day
> work.
> 
> Just one question: have you posted a review request with these patches on
> KDE Reviewboard? I'm not sure if I have enough rights to vote there in case
> patch testing is OK, but still there's better chance to have your patches
> merged with the review request there.
> 
First, thanks so much for looking at this issue.
No I haven't posted to the  KDE Reviewboard ; give me a day or two max to
orient myself, and I'll do so.

> Anyway, thank you for your efforts and apparently right fixes of this whole
> problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Alexey Chernov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #57 from Alexey Chernov <4er...@gmail.com> ---
Created attachment 96997
  --> https://bugs.kde.org/attachment.cgi?id=96997=edit
KXmlGui patch with my modifications

- sending close event was replaced with calling queryClose() as the earlier
violates XSMP (http://www.x.org/releases/X11R7.6/doc/libSM/xsmp.html)
- changes in restore() method were removed

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Alexey Chernov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #56 from Alexey Chernov <4er...@gmail.com> ---
I've just applied and quite intensively tested two patches John attached.

At first for patches: I've actually looked through them before applying, and
there're a couple of questions:

1. I've modified kxmlgui patch a little — at first I've replaces close event
stuff for calling queryClose() method. Following XSM protocol one is not
allowed to close windows on the saving state as a) this is not necessary
shutdown that save-yourself is triggered , it is explicitly stated in the
documentation, and b) shutdown, if any, could normally be cancelled and session
would continue, and closing some windows would just spoil this user's session.

Another thing I removed is restore() method which is obviously the same as
before, but always returns false. Is there any reason for it?

2. KSMServer patch is what I first have tried not to apply at all. Except the
first edit, which seems to be right as it's just follows the comment, other
stuff seems to be redundant. Could you please explain you ideas behind these
changes? Anyway, everything works even without it (see below).

As for testing, I've tested the following use cases:

1. Plain saving session. It's generally works even without any patches (except
Qt patch https://codereview.qt-project.org/#/c/140115 I've applied much
earlier). Works fine.

2. Saving session with several "modified" clients — in my case it was KWrite
with unsaved document and Konsole with "vim" running in one of the tabs. On
logging out I was gently and sequencially asked for both KWrite and Konsole.
Saved nothing and logged out. Works fine.

3. Triggering session save with several "modified" clients and cancel logging
out in one of them. In my case they were KWrite again with an unsaved document
and Kate with an unsaved document. Here I tried two sub-clauses:

a) at first, say "don't save" to KWrite and "Cancel" to Kate. Session
continued successfully, no data is lost in both programs. Just KWin moved both
of them to "Any virtual desktop" — it's apparently the default behaviour,
appropriate for now. So works fine;

b) finally, say "save" to KWrite and "don't save" to Kate. Session finished
and then restored successfully except Kate crashed, which is apparently
separate bug in Kate, which I will address, too. In terms of SM works fine.

As a conclusion, I think, this patch can be candidate for merge right now
without even waiting for Qt patch — there's no harm in saving documents
beforehand, but, of course, without Qt changes of this report:
https://codereview.qt-project.org/#/c/140115 applications won't be restarted.

I'm attaching the patch with my modification. If there's no objection, John,
I'd suggest you as original author to post it to https://reviewboard.kde.org so
that we can have it reviewed and potentially merged as soon as possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Alexey Chernov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

Alexey Chernov <4er...@gmail.com> changed:

   What|Removed |Added

 CC||4er...@gmail.com

--- Comment #55 from Alexey Chernov <4er...@gmail.com> ---
(In reply to John Stanley from comment #51)
> (In reply to Wolfram from comment #50)
> > (In reply to John Stanley from comment #47)
> > > (In reply to Wolfram from comment #46)
> > > > (In reply to John Stanley from comment #43)
> > > > > Sorry about the the links in Comment 41, (3); there are two links 
> > > > > there,
> > > > > separated by a comma:
> > > > >   https://bugreports.qt.io/browse/QTBUG-49241
> > > > >   https://codereview.qt-project.org/#/c/140115/
> > > > > 
> > > > > As far as building, you need to rebuild three packages:
> > > > >   qtbase-5.5.1 (
> > > > > http://download.qt.io/official_releases/qt/5.5/5.5.1/submodules/qtbase-
> > > > > opensource-src-5.5.1.tar.xz )
> > > > >   kxmlgui-5.15.0 (
> > > > > http://download.kde.org/stable/frameworks/5.15/kxmlgui-5.15.0.tar.xz )
> > > > >   plasma-workspace-5.4.2 (
> > > > > http://download.kde.org/stable/plasma/5.4.2/plasma-workspace-5.4.2.tar.xz
> > > > >  )
> > > > > Assuming you already have these installed, the build order is 
> > > > > immaterial,
> > > > > otherwise build in the order shown.
> > > > 
> > > > are the patches included in the tarballs ?
> > > 
> > > The 3 patches, three separate files, one for each package/tarball, are 
> > > given
> > > in Comment 44; they have to be applied before building/rebuilding each
> > > package.
> > 
> > Is your patch implemented in KDE by now ?
> > 
> > Because I was not able to compile the environment until now (see Comment
> > 48), I just installed Kubuntu 15.10 in a virtual machine with
> > 'kubuntu-ppa/staging-plasma' activated. There they use the newest plasma
> > version 5.5.3. As result I can say, that the the session management problems
> > still exist in that version.
> 
> Sorry, for the delay. I've pretty much given up on both KDE and Qt regarding
> this, no movement at all, no one appears to care -- so, no,  the patches are
> not in the latest KDE (5.5.3/5.18.0). It'd be nice, at least, if someone
> would explain why there's no interest..

I think it's partially due to some bugs were closed as duplicate of bug #341930
which continued as bug #354724, there've happened to be several discussions
recently, with somewhat contradictory approach with which I personally
disagree. I tend to fully support you review request to Qt, set +1 there, and
you KDE patches look good as well, it's a shame I just came accross these
reports, just after you posted a link in Gerrit. I've got all the KDE stuff
compiled from sources, so it's no problem to try and test you patches which I
plan to do right away and give them some time of every day work.

Just one question: have you posted a review request with these patches on KDE
Reviewboard? I'm not sure if I have enough rights to vote there in case patch
testing is OK, but still there's better chance to have your patches merged with
the review request there.

Anyway, thank you for your efforts and apparently right fixes of this whole
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[John Stanley via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #53 from John Stanley  ---
(In reply to George R. Goffe from comment #52)
> Hi,
> John/everyone,
> 
> I have been thinking about this situation.
> 
> I have multiple Fedora systems (F22/23/24). Generally they seem to be
> working ok now... more or less, including the Konsole and tabs problem. 
> 
> As I visualize it, the developers add config items, remove config items,
> change config items as they develop. Anything they don't hit directly would
> tend to remain. After a while, the config(s) would tend to have stuff that's
> no longer needed, wanted, or changed, or doesn't work any more as a result.
> I would like to suggest some form of migration of config(s) be performed by
> the developers in the install scripts (think rpmsave) to help eliminate the
> unused "stuff". For example, my fedora 22 system with KDE, starts the apps
> that I have running at the time of the save but it also starts things that
> ARE NOT REFERENCED by the save of configuration process AND/OR are NOT even
> running... so they remain. I don't know enough of the config process to
> isolate where the extra apps/config items are located. I don't want to
> remove everything and re-config.
> 
> There's a kde-testing repo for Fedora systems but whoever builds/maintains
> needs to rebuild the repo index or other files AFTER update so the repodata
> can be syncronized. I wrote a bug on this...
> 
> Have you tried removing .config and .kde/share/apps/ ... Like what would
> happen for a brand new user?
> 
> Good luck,
> 
> George...
Actually, during testing the patches I posted I removed .config/session +
.config/ksmserverrc frequently. More generally, after several frameworks and/or
plasma5 updates I had graphics/opengl artifacts and removing .config entirely
fixed the problems. For the latest update (plasma-5.5.3/frameworks-5.18.0), no
issues whatsoever, so an improvement.

I'm curious, what version of konsole do have installed?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Wolfram via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #54 from Wolfram  ---
(In reply to John Stanley from comment #53)
> (In reply to George R. Goffe from comment #52)
> > Hi,
> > John/everyone,
> > 
> > I have been thinking about this situation.
> > 
> > I have multiple Fedora systems (F22/23/24). Generally they seem to be
> > working ok now... more or less, including the Konsole and tabs problem. 
> > 
> > As I visualize it, the developers add config items, remove config items,
> > change config items as they develop. Anything they don't hit directly would
> > tend to remain. After a while, the config(s) would tend to have stuff that's
> > no longer needed, wanted, or changed, or doesn't work any more as a result.
> > I would like to suggest some form of migration of config(s) be performed by
> > the developers in the install scripts (think rpmsave) to help eliminate the
> > unused "stuff". For example, my fedora 22 system with KDE, starts the apps
> > that I have running at the time of the save but it also starts things that
> > ARE NOT REFERENCED by the save of configuration process AND/OR are NOT even
> > running... so they remain. I don't know enough of the config process to
> > isolate where the extra apps/config items are located. I don't want to
> > remove everything and re-config.
> > 
> > There's a kde-testing repo for Fedora systems but whoever builds/maintains
> > needs to rebuild the repo index or other files AFTER update so the repodata
> > can be syncronized. I wrote a bug on this...
> > 
> > Have you tried removing .config and .kde/share/apps/ ... Like what would
> > happen for a brand new user?
> > 
> > Good luck,
> > 
> > George...
> Actually, during testing the patches I posted I removed .config/session +
> .config/ksmserverrc frequently. More generally, after several frameworks
> and/or plasma5 updates I had graphics/opengl artifacts and removing .config
> entirely fixed the problems. For the latest update
> (plasma-5.5.3/frameworks-5.18.0), no issues whatsoever, so an improvement.
> 
> I'm curious, what version of konsole do have installed?

Since yesterday I have plasma-5.5.3/frameworks-5.18.0 running on my Kubuntu
15.10 wokplace-system via backports-ppa. The session-problems still exist, so I
tried your suggestion regarding .config in the following way: Logged out,
renamed .config to .config_save in a konsole-session and logged in again. The
result was, that I was not able to get my two screens running in kde anymore.
Luckily I had saved my old .config and could switch back. Then I tried it with
a new user. Here the two screens worked, but the session problem still exist.

Maybe my environment is kind of strange: Two screens, folder-view on one
screen, desktop-view on the other, four virtual desktops with different
sessions running in each of them. But all this worked on in kde4 with no
problems !

Since the forced change to kde5 in kubuntu (I promise to stick to LTS-release
next time), my daily workaround is this: starting a new konsole window (and the
tabs i need) if missing, if the positions of the desktop icons are messed up,
copying  ~/.config/plasma-org.kde.plasma.desktop-appletsrc.save to
~/.config/plasma-org.kde.plasma.desktop-appletsrc, then logging off and back
in. If the konsole window appears, the tabs exist (this seems to be fixed), if
not, I have to start a new konsole window again. Sometimes I also have to
spread the the sessions back to the virtual desktops where they belong. It is
frustrating !

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[George R . Goffe via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #52 from George R. Goffe  ---
Hi,
John/everyone,

I have been thinking about this situation.

I have multiple Fedora systems (F22/23/24). Generally they seem to be working
ok now... more or less, including the Konsole and tabs problem. 

As I visualize it, the developers add config items, remove config items, change
config items as they develop. Anything they don't hit directly would tend to
remain. After a while, the config(s) would tend to have stuff that's no longer
needed, wanted, or changed, or doesn't work any more as a result. I would like
to suggest some form of migration of config(s) be performed by the developers
in the install scripts (think rpmsave) to help eliminate the unused "stuff".
For example, my fedora 22 system with KDE, starts the apps that I have running
at the time of the save but it also starts things that ARE NOT REFERENCED by
the save of configuration process AND/OR are NOT even running... so they
remain. I don't know enough of the config process to isolate where the extra
apps/config items are located. I don't want to remove everything and re-config.

There's a kde-testing repo for Fedora systems but whoever builds/maintains
needs to rebuild the repo index or other files AFTER update so the repodata can
be syncronized. I wrote a bug on this...

Have you tried removing .config and .kde/share/apps/ ... Like what would happen
for a brand new user?

Good luck,

George...

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[John Stanley via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #51 from John Stanley  ---
(In reply to Wolfram from comment #50)
> (In reply to John Stanley from comment #47)
> > (In reply to Wolfram from comment #46)
> > > (In reply to John Stanley from comment #43)
> > > > Sorry about the the links in Comment 41, (3); there are two links there,
> > > > separated by a comma:
> > > >   https://bugreports.qt.io/browse/QTBUG-49241
> > > >   https://codereview.qt-project.org/#/c/140115/
> > > > 
> > > > As far as building, you need to rebuild three packages:
> > > >   qtbase-5.5.1 (
> > > > http://download.qt.io/official_releases/qt/5.5/5.5.1/submodules/qtbase-
> > > > opensource-src-5.5.1.tar.xz )
> > > >   kxmlgui-5.15.0 (
> > > > http://download.kde.org/stable/frameworks/5.15/kxmlgui-5.15.0.tar.xz )
> > > >   plasma-workspace-5.4.2 (
> > > > http://download.kde.org/stable/plasma/5.4.2/plasma-workspace-5.4.2.tar.xz
> > > >  )
> > > > Assuming you already have these installed, the build order is 
> > > > immaterial,
> > > > otherwise build in the order shown.
> > > 
> > > are the patches included in the tarballs ?
> > 
> > The 3 patches, three separate files, one for each package/tarball, are given
> > in Comment 44; they have to be applied before building/rebuilding each
> > package.
> 
> Is your patch implemented in KDE by now ?
> 
> Because I was not able to compile the environment until now (see Comment
> 48), I just installed Kubuntu 15.10 in a virtual machine with
> 'kubuntu-ppa/staging-plasma' activated. There they use the newest plasma
> version 5.5.3. As result I can say, that the the session management problems
> still exist in that version.

Sorry, for the delay. I've pretty much given up on both KDE and Qt regarding
this, no movement at all, no one appears to care -- so, no,  the patches are
not in the latest KDE (5.5.3/5.18.0). It'd be nice, at least, if someone would
explain why there's no interest..

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Wolfram via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

--- Comment #50 from Wolfram  ---
(In reply to John Stanley from comment #47)
> (In reply to Wolfram from comment #46)
> > (In reply to John Stanley from comment #43)
> > > Sorry about the the links in Comment 41, (3); there are two links there,
> > > separated by a comma:
> > >   https://bugreports.qt.io/browse/QTBUG-49241
> > >   https://codereview.qt-project.org/#/c/140115/
> > > 
> > > As far as building, you need to rebuild three packages:
> > >   qtbase-5.5.1 (
> > > http://download.qt.io/official_releases/qt/5.5/5.5.1/submodules/qtbase-
> > > opensource-src-5.5.1.tar.xz )
> > >   kxmlgui-5.15.0 (
> > > http://download.kde.org/stable/frameworks/5.15/kxmlgui-5.15.0.tar.xz )
> > >   plasma-workspace-5.4.2 (
> > > http://download.kde.org/stable/plasma/5.4.2/plasma-workspace-5.4.2.tar.xz 
> > > )
> > > Assuming you already have these installed, the build order is immaterial,
> > > otherwise build in the order shown.
> > 
> > are the patches included in the tarballs ?
> 
> The 3 patches, three separate files, one for each package/tarball, are given
> in Comment 44; they have to be applied before building/rebuilding each
> package.

Is your patch implemented in KDE by now ?

Because I was not able to compile the environment until now (see Comment 48), I
just installed Kubuntu 15.10 in a virtual machine with
'kubuntu-ppa/staging-plasma' activated. There they use the newest plasma
version 5.5.3. As result I can say, that the the session management problems
still exist in that version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Vadym Krevs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

Vadym Krevs  changed:

   What|Removed |Added

 CC||vkr...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 346768] After login only one tab is present, when several tabs where opened before logout.

[Naughty Girl via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=346768

Naughty Girl  changed:

   What|Removed |Added

 CC||neurop...@yahoo.com.au

--- Comment #49 from Naughty Girl  ---
FYI, I also hit this bug on upgrade to Fedora 23 -- and after trying F23 Gnome,
Cinnamon, etc, decided to switch to openSUSE (LEAP 4.21 + updates), with KDE,
but konsole still fails to restore across sessions. :-(

I tried installing gnome-terminal, but that also fails to save-and-restore.

I then installed xfce4-terminal which *does* save-and-restore perfectly well,
afaict, -- even though I'm running it on a KDE desktop.

-- 
You are receiving this mail because:
You are watching all bug changes.