[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 Nate Graham changed: What|Removed |Added Version Fixed In||5.93 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 --- Comment #9 from snx --- Git commit 1c15548132621f0a543572338402ff302c621ae1 by snooxx . Committed on 17/03/2022 at 01:36. Pushed by meven into branch 'master'. KExtendableItemDelegate: Fix HiDPI positioning of indicator arrows After fixing pixelated indicator arrows in `KShortcutsEditorDelegate` (i.e. a subclass, see frameworks/kxmlgui!104) used in the "Configure Keyboard Shortcuts" dialog, they were not drawn centered anymore, e.g. slightly moved upwards. The same problem can be observed in the download list of KGet. This is because the increased size of the pixmap is not accounted for. By transforming the pixmap size to device independent dimensions again, as used in the positioning calculations, the arrows will finally be shown correctly. Note that running `KItemViews` in conjunction with a version of `KXmlGUI` not including the fix will still work fine, since the `devicePixelRatio` will only ever be set to `1` in that case. Test Plan: - Launch `QT_SCALE_FACTOR=1.7 ./bin/kxmlguiwindowtest` (from KXmlGui, including the fix mentioned above). - Open "Configure Keyboard Shortcuts" dialog. - Arrows in "Shortcut" column positioned correctly, for both their expanded and collapsed states. - Test with `-style Fusion` and other scaling factors, too. - `QT_SCALE_FACTOR=1.7 kget`, start download, observe indicator arrow in download list. M +10 -8src/kextendableitemdelegate.cpp https://invent.kde.org/frameworks/kitemviews/commit/1c15548132621f0a543572338402ff302c621ae1 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 snx changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/fram ||eworks/kxmlgui/commit/a8207 ||6a6c353509ca404157237f61c6a ||28b37d3e --- Comment #8 from snx --- Git commit a82076a6c353509ca404157237f61c6a28b37d3e by snooxx . Committed on 16/03/2022 at 20:11. Pushed by ahmadsamir into branch 'master'. KShortcutsEditorDelegate: Fix HiDPI rendering of indicator arrows Even with HiDPI rendering enabled in applications, the standard "Configure Keyboard Shortcuts" dialog would still show pixelated indicator arrows in the "Shortcut" and "Alternate" columns. This is because the respective pixmap is only scaled up, but not rendered appropriately sized from the beginning. Setting the pixmap's `devicePixelRatio` and increasing its size fixes the issue. `option.rect` is in device independent pixels, and therefore should be kept as is. Note: In order for the arrows to still get drawn in the right place, additional fixes in `KExtendableItemDelegate` (i.e. the base class) are necessary, see frameworks/kitemviews!10. Test Plan: - Launch `QT_SCALE_FACTOR=1.7 ./bin/kxmlguiwindowtest`. - Open "Configure Keyboard Shortcuts" dialog. - Arrows in "Shortcut" column should not be pixelated anymore, for both their expanded and collapsed states. - Test with `-style Fusion` and other scaling factors, too. M +7-2src/kshortcutseditordelegate.cpp https://invent.kde.org/frameworks/kxmlgui/commit/a82076a6c353509ca404157237f61c6a28b37d3e -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/104 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 --- Comment #6 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kitemviews/-/merge_requests/10 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 --- Comment #5 from Ahmad Samir --- That makes sense (and it benefits the whole app rather than just one dialog, that is if it works at all setting those attributes _after_ the application object has been created). Thanks for the confirmation :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 --- Comment #4 from Christoph Cullmann --- (In reply to Ahmad Samir from comment #3) > I think this can be fixed by using: > QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps, true); > QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, true); > > but I am not sure we should do that in the dialog code; I think it should be > in the application where the dialog(s) is launched from. No, such stuff must be done by the application, preferable "before" the application object is created. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com, ||cullm...@kde.org --- Comment #3 from Ahmad Samir --- I think this can be fixed by using: QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps, true); QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, true); but I am not sure we should do that in the dialog code; I think it should be in the application where the dialog(s) is launched from. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 Christoph Feck changed: What|Removed |Added Product|systemsettings |frameworks-kxmlgui Assignee|k...@michael-jansen.biz |kdelibs-b...@kde.org Component|kcm_keys|general Version|5.17.4 |5.65.0 Summary|">" arrows are blurry on|[KShortcutsEditorDelegate] |HiDPI screen|">" arrows are blurry on ||HiDPI screen -- You are receiving this mail because: You are watching all bug changes.
