[kdevplatform] [Bug 347351] commit fails when no git user/email are configured

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=347351

Kevin Funk  changed:

   What|Removed |Added

   Version Fixed In|5.0 |5.0.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 347351] commit fails when no git user/email are configured

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347351

Kevin Funk  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kdev
   ||platform/2df0558b458dae4694
   ||73e117ad6045a29802359a
 Status|REOPENED|RESOLVED
   Version Fixed In||5.0
 Resolution|--- |FIXED

--- Comment #3 from Kevin Funk  ---
Git commit 2df0558b458dae469473e117ad6045a29802359a by Kevin Funk, on behalf of
Artur Puzio.
Committed on 02/02/2016 at 23:21.
Pushed by kfunk into branch '5.0'.

Git: Display dialog to configure user & name

Summary:
Added function to get git config
Added checking of `user.email` and `user.name` when committing
Added possibility to configure global git parameters
Added `QDialog` extension to choose the name and email, with possibility to
save the settings as global and validation.
Used the extension to handle the lack of `user.name` or `user.email` configured
when committing.
Added unit tests for readConfigOption and setConfigOption.
This fixes the [[ https://bugs.kde.org/show_bug.cgi?id=347351 | Bug 347351 ]]

Test Plan:
The new dialog works fine.
Tests pass.
FIXED-IN: 5.0

Reviewers: kfunk

Reviewed By: kfunk

Subscribers: mwolff, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D852

M  +2-0plugins/git/CMakeLists.txt
A  +82   -0plugins/git/gitnameemaildialog.cpp [License: LGPL (v2+)]
A  +54   -0plugins/git/gitnameemaildialog.h [License: LGPL (v2+)]
A  +145  -0plugins/git/gitnameemaildialog.ui
M  +33   -3plugins/git/gitplugin.cpp
M  +2-1plugins/git/gitplugin.h
M  +2-0plugins/git/tests/CMakeLists.txt
M  +29   -0plugins/git/tests/test_git.cpp
M  +1-0plugins/git/tests/test_git.h

http://commits.kde.org/kdevplatform/2df0558b458dae469473e117ad6045a29802359a

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 347351] commit fails when no git user/email are configured

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347351

Milian Wolff  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED

--- Comment #2 from Milian Wolff  ---
there should be a dialog that lets the user input the mail and email, if he
hasn't ever configured that and is trying to open a git project in kdevelop.
just showing an error in the console is not enough, imo.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 347351] commit fails when no git user/email are configured

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347351

Kevin Funk  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Kevin Funk  ---
Is this just about the CI failure? If yes, I fixed this a while ago...

Do we need changes to handle this case in a normal KDevelop run?

(I don't think so, you already get the output in the terminal view afaik, so
the user knows what's going wrong).

-- 
You are receiving this mail because:
You are watching all bug changes.