[krita] [Bug 403576] Cannot edit transparency masks as greyscale images when using pixel brush with wash mode.

2019-05-04 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=403576

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/0ed30208c97a83
   ||74b8c2b0b04f8d51b9b119d83b
 Status|ASSIGNED|RESOLVED

--- Comment #10 from Dmitry Kazakov  ---
Git commit 0ed30208c97a8374b8c2b0b04f8d51b9b119d83b by Dmitry Kazakov.
Committed on 04/05/2019 at 16:53.
Pushed by dkazakov into branch 'master'.

Implement a projection store for masks (for indirect painting)

We have implemented correct painting on masks, but we have never
implemented a projection for them. Indeed, for normal rendering
process they don't need it. But when a mask is selected in isolated
mode, it still needs a projection, so that the use could see the result
of the painting.

M  +1-0libs/image/CMakeLists.txt
M  +8-9libs/image/KisRecycleProjectionsJob.cpp
M  +4-3libs/image/KisRecycleProjectionsJob.h
A  +283  -0libs/image/KisSafeNodeProjectionStore.cpp [License: GPL
(v2+)]
A  +109  -0libs/image/KisSafeNodeProjectionStore.h [License: GPL (v2+)]
M  +14   -5libs/image/kis_base_node.cpp
M  +2-1libs/image/kis_base_node.h
M  +16   -122  libs/image/kis_layer.cc
M  +0-12   libs/image/kis_layer.h
M  +26   -12   libs/image/kis_mask.cc
M  +20   -2libs/image/kis_node.cpp
M  +4-1libs/image/kis_node.h
M  +5-0sdk/tests/testing_nodes.h

https://invent.kde.org/kde/krita/commit/0ed30208c97a8374b8c2b0b04f8d51b9b119d83b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 403576] Cannot edit transparency masks as greyscale images when using pixel brush with wash mode.

2019-05-02 Thread Brendan
https://bugs.kde.org/show_bug.cgi?id=403576

--- Comment #9 from Brendan  ---
According to the guy in this video: 
https://www.youtube.com/watch?v=hLW6ulXZ9GM
in Krita 3.0.1 you could access the mask by holding "alt" and clicking on the
thumbnail.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 403576] Cannot edit transparency masks as greyscale images when using pixel brush with wash mode.

2019-05-02 Thread Brendan
https://bugs.kde.org/show_bug.cgi?id=403576

--- Comment #8 from Brendan  ---
I'm pretty sure Wolthera is describing a different, albeit probably related
bug.  

My problem is that I cannot view any transparency mask without isolating the
layer first.  There is nowhere on the node that I can click to bring up the
greyscale image that represents the mask, and I'm pretty sure there should be.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 403576] Cannot edit transparency masks as greyscale images when using pixel brush with wash mode.

2019-05-01 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=403576

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

--- Comment #7 from Dmitry Kazakov  ---
Ah, I should have isolated the node first! Thank you for the video! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 403576] Cannot edit transparency masks as greyscale images when using pixel brush with wash mode.

2019-05-01 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=403576

--- Comment #6 from wolthera  ---
Created attachment 119764
  --> https://bugs.kde.org/attachment.cgi?id=119764=edit
Video showing the problem

Video showing the problem with a basic brush. I guess the trick here is isolate
mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 403576] Cannot edit transparency masks as greyscale images when using pixel brush with wash mode.

2019-05-01 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=403576

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #5 from Dmitry Kazakov  ---
Hi, Wolthera and Brendan!

Could you please share an image and a brush preset (at least name), in which I
could reproduce the problem? I cannot get it here :(

I tried painting on a transparency mask with a pixel brush in both Wash and
BuildUp modes and it seem to work :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 403576] Cannot edit transparency masks as greyscale images when using pixel brush with wash mode.

2019-04-12 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=403576

Tymond  changed:

   What|Removed |Added

 CC||tamtamy.tym...@gmail.com
 Status|REOPENED|CONFIRMED

--- Comment #4 from Tymond  ---
Wolthera confirmed it, so I change the status (also, REOPENED suggest it was
fixed once and now the issue appears again; but in this case the report was
just closed as NOT A BUG, so 'reopening' just confirms it is in fact a bug).

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 403576] Cannot edit transparency masks as greyscale images when using pixel brush with wash mode.

2019-04-08 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=403576

wolthera  changed:

   What|Removed |Added

 CC||griffinval...@gmail.com
   Keywords||regression, triaged
Summary|Cannot edit transparency|Cannot edit transparency
   |masks as greyscale images   |masks as greyscale images
   ||when using pixel brush with
   ||wash mode.

--- Comment #3 from wolthera  ---
I can reproduce this: It seems to be caused in specific by indirect painting
again. The color smudge brush which has no indirect painting for example does
update immidiately, but pixel brushes with 'wash mode'(which uses indirect
painting) don't seem to cause an update of the view.

reproduced on

Krita

 Version: 4.2.0-pre-alpha (git c5838c0)
 Languages: en_US, en_GB, nl
 Hidpi: false

Qt

  Version (compiled): 5.12.0
  Version (loaded): 5.12.0

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 4.15.0-46-generic
  Pretty Productname: KDE neon User Edition 5.15
  Product Type: neon
  Product Version: 18.04

-- 
You are receiving this mail because:
You are watching all bug changes.