[krita] [Bug 418406] A Rotation Transform around the 'x' or 'y' axis (not 'z' axis) caused loss of off-canvas content
https://bugs.kde.org/show_bug.cgi?id=418406 Dmitry Kazakov changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/db6406a6c ||27ddf11874a7e72d8e2c066954f ||3d7e Resolution|--- |FIXED --- Comment #6 from Dmitry Kazakov --- Git commit db6406a6c27ddf11874a7e72d8e2c066954f3d7e by Dmitry Kazakov. Committed on 03/06/2021 at 07:52. Pushed by dkazakov into branch 'master'. Fix losing off-canvas data when doing perspective trasnform Basically, off-canvas cropping is needed only for the transform mask. The transform tool should transform the entire image all the time. The only danger of this change is that perspective transform can easily grow to infinity. But I didn't manage to reproduce this growth with the transform tool. I guess it is only possible with the transform mask (when the source layer is moved). M +1-1libs/image/kis_fill_painter.cc M +7-5libs/image/kis_perspectivetransform_worker.cpp M +3-2libs/image/kis_perspectivetransform_worker.h M +1-1libs/image/kis_transform_mask.cpp M +1-1libs/image/tests/kis_perspective_transform_worker_test.cpp M +1-1libs/image/tests/kis_transform_worker_test.cpp M +1-1plugins/tools/tool_transform2/kis_transform_mask_adapter.cpp M +25 -5plugins/tools/tool_transform2/kis_transform_utils.cpp M +5-0plugins/tools/tool_transform2/kis_transform_utils.h https://invent.kde.org/graphics/krita/commit/db6406a6c27ddf11874a7e72d8e2c066954f3d7e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418406] A Rotation Transform around the 'x' or 'y' axis (not 'z' axis) caused loss of off-canvas content
https://bugs.kde.org/show_bug.cgi?id=418406 Dmitry Kazakov changed: What|Removed |Added CC||ra...@raghukamath.com --- Comment #5 from Dmitry Kazakov --- *** Bug 437956 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418406] A Rotation Transform around the 'x' or 'y' axis (not 'z' axis) caused loss of off-canvas content
https://bugs.kde.org/show_bug.cgi?id=418406 --- Comment #4 from Ahab Greybeard --- @Dmitry re. Comment 3. I was working with Rotation but I now see that it also happens with a Perspective transform. There would be a further problem/complication caused by any pre-existing off canvas content (intentional or not) that would be included in the content bounding box for the transform. For Rotation, you can have transformed content that's beyond infinity (it's behind your head) and that would be a very difficult problem For the Rotation transform, there is a bug report which is associated with this issue: https://bugs.kde.org/show_bug.cgi?id=418557 This is classed as Wishlist. I believe that if that bug was dealt with then it would mostly take care of the problem for Rotation transforms for the x/y axis. It may be possible to determine a 'reasonable working limit' for keeping content but it would be a lot of work and I doubt that many people do x/y rotations of that nature anyway. For now, there is a possible workaround (for Rotation and Perspective) where you Resize the canvas so that the transformed content stays on canvas and then you can deal with it as needed. Maybe you could put this on your backburner until all other bugs are fixed :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418406] A Rotation Transform around the 'x' or 'y' axis (not 'z' axis) caused loss of off-canvas content
https://bugs.kde.org/show_bug.cgi?id=418406 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com --- Comment #3 from Dmitry Kazakov --- Well, that is done semi-intentionally. The problem is that perspective transforms can easily grow really large, sometimes to the infinity. So all the perspective transforms limit the result to the bounds of the image. I'm not sure how to resolve this bug correctly. There should still some limit, though I don't know how big. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418406] A Rotation Transform around the 'x' or 'y' axis (not 'z' axis) caused loss of off-canvas content
https://bugs.kde.org/show_bug.cgi?id=418406 Rebecca Breu changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||rebe...@rbreu.de --- Comment #2 from Rebecca Breu --- I can confirm this for both the 4.2.8 version and today's nightly appimage 4c27cab. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418406] A Rotation Transform around the 'x' or 'y' axis (not 'z' axis) caused loss of off-canvas content
https://bugs.kde.org/show_bug.cgi?id=418406 --- Comment #1 from Ahab Greybeard --- Created attachment 126551 --> https://bugs.kde.org/attachment.cgi?id=126551=edit lost off-canvas content due to 'y' axis rotatiob -- You are receiving this mail because: You are watching all bug changes.
