[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/d47a33aa9 |hics/krita/commit/e62499df7 |c7d1ba54cbe30f2d04263ca4aff |d4fe14a26dde7edac8610bd1ad4 |7a92|bffb --- Comment #10 from Dmitry Kazakov --- Git commit e62499df7d4fe14a26dde7edac8610bd1ad4bffb by Dmitry Kazakov. Committed on 31/03/2022 at 13:43. Pushed by dkazakov into branch 'krita/5.0'. Fix delay on auto-brush stroke with randomness KisAutoBrush used to initialize brushTipImage() and image() with a full-size preview image, which could cause huge delay for big brushes with randomness enabled. This patch disables initialization of brushTipImage() for auto-brushes (it is not used for them anyway). M +46 -11 libs/brush/kis_auto_brush.cpp M +1-1libs/brush/kis_auto_brush.h https://invent.kde.org/graphics/krita/commit/e62499df7d4fe14a26dde7edac8610bd1ad4bffb -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 --- Comment #9 from acc4commissi...@gmail.com --- (In reply to acc4commissions from comment #8) > The delay has reduced! But still, compared to brushes that use Predefined > tips, still there's a small gap, feels like a flicker before the actual > brush rendering starts on canvas. I hope it's completely gone someday. > > But thanks for the patch overall. nonono, sorry. I was testing the wrong nightly lol. The delay seems almost completely gone after the patch. Thank you! I'll post more if I find something else. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 --- Comment #8 from acc4commissi...@gmail.com --- The delay has reduced! But still, compared to brushes that use Predefined tips, still there's a small gap, feels like a flicker before the actual brush rendering starts on canvas. I hope it's completely gone someday. But thanks for the patch overall. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/d47a33aa9 ||c7d1ba54cbe30f2d04263ca4aff ||7a92 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #7 from Dmitry Kazakov --- Git commit d47a33aa9c7d1ba54cbe30f2d04263ca4aff7a92 by Dmitry Kazakov. Committed on 23/03/2022 at 12:29. Pushed by dkazakov into branch 'master'. Fix delay on auto-brush stroke with randomness KisAutoBrush used to initialize brushTipImage() and image() with a full-size preview image, which could cause huge delay for big brushes with randomness enabled. This patch disables initialization of brushTipImage() for auto-brushes (it is not used for them anyway). M +46 -11 libs/brush/kis_auto_brush.cpp M +1-1libs/brush/kis_auto_brush.h https://invent.kde.org/graphics/krita/commit/d47a33aa9c7d1ba54cbe30f2d04263ca4aff7a92 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 Dmitry Kazakov changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 --- Comment #6 from Dmitry Kazakov --- Hi, acc4commissions! Thanks a lot for the info! Indeed, we have brush caching only for the predefined brushes. It was always believed that auto brushes are "fast enough" to skip caching :) I'll have a look into this bug later :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 --- Comment #5 from acc4commissi...@gmail.com --- I found the biggest culprit. It was the Randomness option(the delay happens when it's set to other than 0) and the Density option(the delay happens when it's set to other than 100) that I was using. Although the delay still isn't completely gone even with optimal settings in both. There still seems to be many options contribute to the stutter at the start of the stroke(to be exact, an inherent short delay between you start a stroke and the actual stroke rendering starts). Using different Mask Type also makes differences. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 --- Comment #4 from acc4commissi...@gmail.com --- It seems that it doesn't happen that much when using Predefined brush tips. The stutter is the most obvious with Auto tips. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 --- Comment #3 from acc4commissi...@gmail.com --- (In reply to Dmitry Kazakov from comment #2) > Hi, acc4commissions! > > Could you state the sha1 of the nightlies you use? I have fixed exactly a > bug like that in October. It's present in the most recent nightlies. I used 1000px brush in e36a034 to test. Let me know if there's more info you need. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 --- Comment #2 from Dmitry Kazakov --- Hi, acc4commissions! Could you state the sha1 of the nightlies you use? I have fixed exactly a bug like that in October. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 Dmitry Kazakov changed: What|Removed |Added Severity|wishlist|normal CC||dimul...@gmail.com --- Comment #1 from Dmitry Kazakov --- It is surely not a wishlist bug :) -- You are receiving this mail because: You are watching all bug changes.
