[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #22 from Freek --- Thanx! Fixed for me as well, a big annoyance is gone now, really appreciate it!! -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Christoph Feck changed: What|Removed |Added CC||shaloksha...@protonmail.ch --- Comment #21 from Christoph Feck --- *** Bug 379910 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Aleix Pol changed: What|Removed |Added CC||aleix...@kde.org --- Comment #20 from Aleix Pol --- (In reply to Aetf from comment #17) > Git commit a41a850a3943dbc1bd43b867def775e41902f987 by Peifeng Yu. > Committed on 30/04/2017 at 18:20. > Pushed by peifengyu into branch 'master'. > > Only follow mouse when moved (Fixes Bug #372635) > > Summary: > Use a new variable moved to detect if mouse moved and only change index if > the mouse moved. This helps preventing index changes when only using > keyboard to search something in milou and to not accidently start/open > something you did not want (see bug report > https://bugs.kde.org/show_bug.cgi?id=372635 ) > > In general the onEntered signal seems to be broken in Qt somehow as I could > not make it work reliably with Qt 5.7.1. Sometimes it worked but mostly the > code using onEntered failed to work with onPositionChanged (I guess this > also does not always set it to true). > Hence I tried containsMouse which seems to work reliably at least on Qt > 5.7.1. > Tests are appreciated especially on other Qt versions. > > Reviewers: broulik, davidedmundson > > Reviewed By: davidedmundson > > Subscribers: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, > plasma-devel > > Tags: #plasma > > Differential Revision: https://phabricator.kde.org/D5490 > > M +1-0lib/CMakeLists.txt > A +40 -0lib/mousehelper.cpp [License: GPL (v2/3)] > A +44 -0lib/mousehelper.h [License: GPL (v2/3)] > M +12 -4lib/qml/ResultDelegate.qml > M +9-0lib/qml/ResultsView.qml > M +5-0lib/qml/qmlplugins.cpp > > https://commits.kde.org/milou/a41a850a3943dbc1bd43b867def775e41902f987 Thanks a lot for fixing it Aetf! :D -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Christoph Feck changed: What|Removed |Added CC||fr...@hmrt.nl --- Comment #19 from Christoph Feck --- *** Bug 379859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #18 from Martin Steigerwald --- Dear Aetf. *Thank you*. Finally, this quite annoying issue received a fix. Any plans to backport this to Plasma LTS 5.8 release? It would improve the user experience on all the distributions that ship with it considerably, like next Debian Stretch. *If not* I may still point Debian Qt/KDE team at this and if its easy enough to carry it as a patch they may include it. Thanks, Martin -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Aetf <7437...@gmail.com> changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/mil ||ou/a41a850a3943dbc1bd43b867 ||def775e41902f987 Resolution|--- |FIXED --- Comment #17 from Aetf <7437...@gmail.com> --- Git commit a41a850a3943dbc1bd43b867def775e41902f987 by Peifeng Yu. Committed on 30/04/2017 at 18:20. Pushed by peifengyu into branch 'master'. Only follow mouse when moved (Fixes Bug #372635) Summary: Use a new variable moved to detect if mouse moved and only change index if the mouse moved. This helps preventing index changes when only using keyboard to search something in milou and to not accidently start/open something you did not want (see bug report https://bugs.kde.org/show_bug.cgi?id=372635 ) In general the onEntered signal seems to be broken in Qt somehow as I could not make it work reliably with Qt 5.7.1. Sometimes it worked but mostly the code using onEntered failed to work with onPositionChanged (I guess this also does not always set it to true). Hence I tried containsMouse which seems to work reliably at least on Qt 5.7.1. Tests are appreciated especially on other Qt versions. Reviewers: broulik, davidedmundson Reviewed By: davidedmundson Subscribers: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D5490 M +1-0lib/CMakeLists.txt A +40 -0lib/mousehelper.cpp [License: GPL (v2/3)] A +44 -0lib/mousehelper.h [License: GPL (v2/3)] M +12 -4lib/qml/ResultDelegate.qml M +9-0lib/qml/ResultsView.qml M +5-0lib/qml/qmlplugins.cpp https://commits.kde.org/milou/a41a850a3943dbc1bd43b867def775e41902f987 -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #16 from Leszek Lesner --- (In reply to Leszek Lesner from comment #15) > Propose a proper patch that enables hovering + highlight with mouse after > the mouse moves. > https://git.reviewboard.kde.org/r/130088/ Found out reviewboard isn't used anymore and posted to phabricator here: https://phabricator.kde.org/D5490 -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #15 from Leszek Lesner --- Propose a proper patch that enables hovering + highlight with mouse after the mouse moves. https://git.reviewboard.kde.org/r/130088/ -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Jan-Matthias Braun changed: What|Removed |Added CC||jan_br...@gmx.net --- Comment #14 from Jan-Matthias Braun --- Works for me. Thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #13 from fuermetz+...@mailbox.org --- Created attachment 105009 --> https://bugs.kde.org/attachment.cgi?id=105009&action=edit Disable mouse from stealing focus If this patch is applied to ResultDelegate.qml from milou, the mouse animation for the current list item is disabled, but the rest works as expected (Selecting via keyboard or clicking with mouse). -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #12 from Till Schäfer --- Is it possible to detect the start and end of the animation? In this case it should be possible to deregister the listener of the mouse move event while the animation is going on and re-register is afterwards. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #11 from Kai Uwe Broulik --- The processing happens in Qt itself.. your best guess would be having a look at milou (which the ResultDelegate comes from and try your luck in there) -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #10 from fuermetz+...@mailbox.org --- I would try to fix this, if somebody could point me in the right direction. My idea is to get the current cursor position, when the krunner pops up and ignore the hover event, when the mouse position doesn't differ from the previously saved position. I guess the UI is painted with QtQuick2 in plasma-workspace/lookandfeel/contents/runcommand/RunCommand.qml and is clued together in plasma-workspace/blob/master/krunner/view.cpp, but I cannot find where the mouse events are processed.. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 fuermetz+...@mailbox.org changed: What|Removed |Added CC||fuermetz+...@mailbox.org -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Aetf <7437...@gmail.com> changed: What|Removed |Added CC||7437...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Kevin Ottens changed: What|Removed |Added CC||er...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Leszek Lesner changed: What|Removed |Added CC||leszek.les...@web.de -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #9 from Martin Steigerwald --- Kai, thank you for thinking on a fix. Whatever the fix may be: Please consider to backport it to Plasma 5.8 LTS, cause this way it can still be integrated in distributions – giving much relief to users how would otherwise be stuck with this really annoying bug for years. I am volunteering to hint Debian Qt/KDE team at a fix thats usable in Plasma 5.8 LTS. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #8 from Kai Uwe Broulik --- >From what I can tell Qt now processes mouse events even if the item moves underneath the mouse without the mouse moving. While this is a good thing in principle, it causes this side-effect as items show up under the mouse and then it fires a hover event. I'm still looking for a good way to fix this, other than randomly adding timers... -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 xdmx changed: What|Removed |Added CC||x...@email.it --- Comment #7 from xdmx --- This. Please. It happens to me as well at least 5 times each day, it's very frustrating :( -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Janek Bevendorff changed: What|Removed |Added CC||k...@jbev.net Version|5.8.4 |5.8.5 --- Comment #6 from Janek Bevendorff --- Either I never noticed it before or this must have been introduced by a recent update. It annoys the crap out of me as well. The KRunner list usually has a length of about half my screen height and one quarter its width. Since I rarely have my mouse cursor anywhere but around the center of my screen, it's very likely that I select something I didn't intend to select. What I notice is: when I invoke KRunner and type something, the first list item is selected, but then the selection is replaced by whatever my cursor is hovering over. I think the best solution would be to only change the selection if I actually move my mouse cursor. When I use the keyboard, I don't touch the mouse, so the cursor is stationary. A stationary cursor should not change the selection. An easy criterion for checking this would be if the cursor has moved since the last KRunner list update. If it hasn't, don't let it select anything. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 kishor...@gmail.com changed: What|Removed |Added CC||kishor...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #5 from Till Schäfer --- (In reply to Ralf Jung from comment #2) > > I think an easy workaround would to only select an item from krunner by > > mouse if the user actually presses the left mouse button. I see no point in > > the on hover selection. Sure I could use the mouse and then still hit the > > enter key, but what for? Either I use the keyboard or I use the mouse. > > Alternatively (because the on-hover graphical effect is nice and potentially > helpful), pressing the Enter key could entirely ignore th selected item if > it was selected with the mouse. (Of course the selection should be honored > if it was done with the keyboard.) I do not like an out of sync visual representation with actual behavior. For this reason I propose to select an item only on mouse move or click. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Till Schäfer changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 Version|5.8.2 |5.8.4 -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Till Schäfer changed: What|Removed |Added CC||till2.schaefer@uni-dortmund ||.de --- Comment #4 from Till Schäfer --- *** Bug 374044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #3 from Martin Steigerwald --- Any update on this one? This easily qualifies as the most annoying bug I currently have with Plasma. I triggered it at least 10 times in the last two days. And whenever I trigger it krunner starts something completely unrelated to what I wanted to start. For now I consider to just disable any and all krunner plugins to reduce the likely for this issue to happen again. Have a merry christmas, (and yes I understand if there would not be a reply before it anymore). Martin -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 --- Comment #2 from Ralf Jung --- > I think an easy workaround would to only select an item from krunner by mouse > if the user actually presses the left mouse button. I see no point in the on > hover selection. Sure I could use the mouse and then still hit the enter key, > but what for? Either I use the keyboard or I use the mouse. Alternatively (because the on-hover graphical effect is nice and potentially helpful), pressing the Enter key could entirely ignore th selected item if it was selected with the mouse. (Of course the selection should be honored if it was done with the keyboard.) -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Christoph Feck changed: What|Removed |Added CC||p...@ralfj.de --- Comment #1 from Christoph Feck --- *** Bug 373154 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Christoph Feck changed: What|Removed |Added Severity|wishlist|normal -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 372635] do not follow mousepointer when accessing krunner via keyboard
https://bugs.kde.org/show_bug.cgi?id=372635 Martin Steigerwald changed: What|Removed |Added CC||mar...@lichtvoll.de -- You are receiving this mail because: You are watching all bug changes.