[plasmashell] [Bug 385463] favourite system actions are no longer removable via right click menu - breaks/prevents sidebar hiding
https://bugs.kde.org/show_bug.cgi?id=385463 Fabian Vogt changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/pla ||sma-desktop/06f01ed291ca210 ||57497fd0ceaa69f6e4d324bc3 --- Comment #3 from Fabian Vogt --- Git commit 06f01ed291ca21057497fd0ceaa69f6e4d324bc3 by Fabian Vogt. Committed on 10/10/2017 at 16:53. Pushed by fvogt into branch 'Plasma/5.11'. Fix editing items in SimpleFavoritesModel Summary: tools.js is supposed to support both KaStatsFavoritesModel (used for favorite applications) and SimpleFavoritesModel (used for system actions, like poweroff/reboot/logout). The latter did not work though, as tools.js unconditionally calls methods only present in KaStatsFavoritesModel. This commit makes KaStatsFavoritesModel API compatible to SimpleFavoritesModel and changes the relevant code in tools.js to support both. Additionally, this syncs applets/kickoff/package/contents/code/tools.js again. Test Plan: Before this patch it wasn't possible to remove system actions from the favorites bar. Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: hein, davidedmundson, rikmills, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8178 M +6-6applets/kicker/package/contents/code/tools.js M +2-2applets/kicker/plugin/kastatsfavoritesmodel.cpp M +13 -11 applets/kickoff/package/contents/code/tools.js https://commits.kde.org/plasma-desktop/06f01ed291ca21057497fd0ceaa69f6e4d324bc3 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 385463] favourite system actions are no longer removable via right click menu - breaks/prevents sidebar hiding
https://bugs.kde.org/show_bug.cgi?id=385463 Rik Mills changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #2 from Rik Mills --- Update proposed revision from Fabian Vogt here I believe https://phabricator.kde.org/D8178 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 385463] favourite system actions are no longer removable via right click menu - breaks/prevents sidebar hiding
https://bugs.kde.org/show_bug.cgi?id=385463 Fabian Vogt changed: What|Removed |Added Attachment #108220|0 |1 is patch|| -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 385463] favourite system actions are no longer removable via right click menu - breaks/prevents sidebar hiding
https://bugs.kde.org/show_bug.cgi?id=385463 Fabian Vogt changed: What|Removed |Added CC||fab...@ritter-vogt.de --- Comment #1 from Fabian Vogt --- Created attachment 108220 --> https://bugs.kde.org/attachment.cgi?id=108220&action=edit PoC that fixes the API mismatch The reason for this bug is that tools.js does not support SimpleFavoritesModel anymore. I attached a patch that changes KAStatsFavoritesModel to be a superset of SimpleFavoritesModel and adjusts tools.js to use the SimpleFavoritesModel API if necessary. -- You are receiving this mail because: You are watching all bug changes.
