[systemsettings] [Bug 408512] Add support cups-pk-helper or kauth/policykit equivalent

2020-03-12 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=408512

Nicolas Fella  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://commits.kde.org/pri
   ||nt-manager/9a11a1f4de8a2699
   ||9485148c5a78e160e8880f17
 Resolution|--- |FIXED

--- Comment #14 from Nicolas Fella  ---
Git commit 9a11a1f4de8a26999485148c5a78e160e8880f17 by Nicolas Fella.
Committed on 12/03/2020 at 23:18.
Pushed by nicolasfella into branch 'master'.

Fix authentication

Summary:
According to the CUPS code
(https://github.com/apple/cups/blob/master/cups/auth.c#L105)
cupsDoAuthentication returns 0 on success and -1 on error. The code was
assuming the opposite

Now the CUPS password dialog is shown when needed. This is quite often, e.g
directly at startup due to getServerSettings() so it might be worth checking if
that's really necessary.

Test Plan: Open print-manager with a user that is not in a CUPS system group.
Privileged operations work after entering a password

Reviewers: dantti, broulik

Reviewed By: dantti

Subscribers: ognarb, rdieter, kde-utils-devel

Differential Revision: https://phabricator.kde.org/D23403

M  +2-2libkcups/KCupsConnection.cpp

https://commits.kde.org/print-manager/9a11a1f4de8a26999485148c5a78e160e8880f17

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 408512] Add support cups-pk-helper or kauth/policykit equivalent

2020-03-11 Thread Kevin Kofler
https://bugs.kde.org/show_bug.cgi?id=408512

--- Comment #13 from Kevin Kofler  ---
This is not as nice as PolicyKit support, but it will do the job.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 408512] Add support cups-pk-helper or kauth/policykit equivalent

2020-03-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408512

Nate Graham  changed:

   What|Removed |Added

   Assignee|dantt...@gmail.com  |nicolas.fe...@gmx.de
 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 408512] Add support cups-pk-helper or kauth/policykit equivalent

2020-03-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=408512

--- Comment #12 from Nicolas Fella  ---
https://phabricator.kde.org/D23403 should fix this

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 408512] Add support cups-pk-helper or kauth/policykit equivalent

2020-03-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408512

Nate Graham  changed:

   What|Removed |Added

  Component|general |kcm_printer_manager
Version|19.04   |unspecified
Product|print-manager   |systemsettings
 CC||plasma-b...@kde.org
 Status|REOPENED|CONFIRMED

--- Comment #11 from Nate Graham  ---
That makes sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.