[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2023-01-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=454991

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2023-01-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=454991

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |134e2d5c989c36ac0e985ee0ae3 |efbef4f66365f16f545cad6d2cc
   |82996c6b7b56e   |e460fcb212697
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.27

--- Comment #8 from Nate Graham  ---
Git commit efbef4f66365f16f545cad6d2cce460fcb212697 by Nate Graham, on behalf
of Han Young.
Committed on 10/01/2023 at 15:41.
Pushed by ngraham into branch 'master'.

kcms/regionanglang: explicitly set pt to pt_PT

Explicitly set pt to pt_PT as a workaround for GNU Gettext and CLDR
treating the default dialect of 'pt' differently.

See the discussion on:
https://mail.kde.org/pipermail/kde-i18n-doc/2023-January/001340.html
FIXED-IN: 5.27

M  +13   -1kcms/region_language/languagelistmodel.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/efbef4f66365f16f545cad6d2cce460fcb212697

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2023-01-08 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=454991

Luigi Toscano  changed:

   What|Removed |Added

 CC||luigi.tosc...@tiscali.it

--- Comment #7 from Luigi Toscano  ---
Let's not promise a solution which hasn't been agreed upon. Other relevant
software in the free software world based on gettext (I've checked GNU, GNOME
and LibreOffice) uses pt. Does it mean they are broken too? If there is an
issue, maybe it should be solved in gettext.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2023-01-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=454991

--- Comment #6 from hanyo...@protonmail.com ---
In the short term the Region and Language KCM will automatic set "pt" to
"pt_PT". In the long term, we'll rename the 'pt' directory in i10n svn to
'pt_PT'. See the discussion on
https://discuss.kde.org/t/rename-pt-in-i10n-svn-to-pt-pt/118

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2023-01-04 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=454991

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2478

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2023-01-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=454991

Nate Graham  changed:

   What|Removed |Added

  Component|kcm_language|kcm_regionandlang
 CC||hanyo...@protonmail.com

--- Comment #4 from Nate Graham  ---
CCing the author of those changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2022-12-25 Thread Eduardo Correia
https://bugs.kde.org/show_bug.cgi?id=454991

Eduardo Correia  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Ever confirmed|0   |1
Version|5.24.5  |5.26.4
 Status|RESOLVED|REOPENED

--- Comment #3 from Eduardo Correia  ---
This bug is still present, if not somewhat worse after the languages KCM
rework.
I also suggest many visual improvements while we are at it.
There is a quick list with everything at the end. Lost many hours testing and
repeating all this so I hope I am giving as much details as possible for an
easier debug.

KDE still insists in using [pt] in all config files when european portuguese is
selected. However, 99% of apps read [pt] as being the same as [pt_BR] which is
Brazilian Portuguese, a completely different language in many ways, especially
grammar.

The new languages KCM rework was great but didn't solve this bug and even made
it worse: When we try to switch language or add more, we completely lost the
"third" option of "European Portuguese" (called "Português (Portugal)" or
"português europeu", can't remember) that we had before 5.26 . The only two
options we have are now "português" and "português (brasil)". Choosing
"português" makes it add "pt" in plasma-localerc in the [Translations] part. If
we then add the other option, "português (brasil)", that config file gets
changed to "pt:pt_BR". The "pt_BR" part is correct, but the "pt" is not. And
while theoretically using "pt" to refer to European Portuguese is not wrong,
almost all third party apps on all OSs and all DEs even many KDE own apps
consider "pt" to be the same as "pt_BR". So having "pt" in plasma-localerc
makes all apps display their content in Brazilian. This together with this bug
makes it so effectively both language options in the language picker are, in
the end, actually both brazilian.

If we manually edit plasma-localerc [Translations] from "pt" to "pt_PT" and
re-login, the languages KCM will show "português europeu" (European Portuguese)
in the title of the currently added languages, even though that option doesn't
exist when we try to add it via the languages picker. Changing it manually to
pt_PT also makes all apps to be correctly shown in European Portuguese
including all third party ones, be it native, flatpaks, snaps, everything. If
we try to change it in the KCM and choose the "português" option, it reverts
back to "pt" in plasma-localerc.

My suggestion would be to completely remove the "português" option from the
add/edit languages KCM and instead add the "Português (Portugal)" option and
make it link to "pt_PT", so we get the only two options that actually matter:
"Português (Portugal)" [pt_PT] and "Português (Brasil)" [pt_BR]. Having the
other "português" [pt] doesn't make much sense since all apps consider it as
pt_BR anyway and will only create confusion for the final user in the UI.

Also related, all of these languages should be correctly written to look more
professional, and correctly capitalized. "português (brasil)" should be
"Português (Brasil)" for example. All languages suffer from this (see the
language picker), some are correct, others are not, it's very inconsistent.
When not in the picker, the list that shows currently added languages should
reflect this same improvement as it suffers from the same thing. "português
europeu" as it reads when we manually edit the plasma-localerc to be pt_PT,
should instead read "Português (Portugal)" as should the languages picker.
Languages should all also follow a more professional naming scheme: "American
English" should instead be "English (US)". British English should be English
(UK), and so on and so forth.

The "home page" of this "languages and region" KCM (I don't know their real
names) also shows different things in the "Language" part: when we have "pt_PT"
manually added in plasma-localerc, this reads "português europeu" (should read
Português (Portugal) too), and when we select "português (brasil)" this reads
"português" only. However the "português" option in the language picker
actually is the one that means "pt" (the bug) and when this one is selected the
home page also reads "português". So the home page says "português" no matter
which of the two availabme options in the picker is selected. When we click
"modify" to enter into the edit language settings, it says different things
again. I know this is all very confusing, it also is for me as it took me a lot
of time to figure out what the hell was happening here. Can't imagine this
being any easier for less techy users.

Another related random bug I encontered when playing with this, is that some
specific languages, for example and for coincidence the "português (brasil)"
being one of them, it makes plasma-localerc completely lose the [Formats] part
of it. 

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2022-07-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=454991

hanyo...@protonmail.com changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||134e2d5c989c36ac0e985ee0ae3
   ||82996c6b7b56e

--- Comment #2 from hanyo...@protonmail.com ---
Git commit 134e2d5c989c36ac0e985ee0ae382996c6b7b56e by Han Young.
Committed on 02/07/2022 at 09:29.
Pushed by hanyoung into branch 'master'.

merge Language and Formats
Related: bug 192019, bug 341235, bug 344588, bug 394477, bug 397974, bug
397975, bug 403580, bug 417564, bug 420268, bug 429474, bug 431292, bug 444772,
bug 446785, bug 447787, bug 448324, bug 448355, bug 451919, bug 451944

closes https://invent.kde.org/plasma/plasma-workspace/-/issues/23

M  +1-0.kde-ci.yml
M  +52   -8CMakeLists.txt
M  +2-1config-workspace.h.cmake
D  +0-2doc/kcontrol/formats/CMakeLists.txt
D  +0-63   doc/kcontrol/formats/index.docbook
R  +1-1doc/kcontrol/region_language/CMakeLists.txt [from:
doc/kcontrol/translations/CMakeLists.txt - 063% similarity]
R  +---doc/kcontrol/region_language/go-top.png [from:
doc/kcontrol/translations/go-top.png - 100% similarity]
R  +36   -23   doc/kcontrol/region_language/index.docbook [from:
doc/kcontrol/translations/index.docbook - 050% similarity]
A  +---doc/kcontrol/region_language/list-remove.png
D  +---doc/kcontrol/translations/list-remove.png
M  +1-2kcms/CMakeLists.txt
D  +0-30   kcms/formats/CMakeLists.txt
D  +0-5kcms/formats/Messages.sh
D  +0-61   kcms/formats/formatssettings.kcfg
D  +0-80   kcms/formats/kcmformats.cpp
D  +0-34   kcms/formats/kcmformats.h
D  +0-183  kcms/formats/localelistmodel.cpp
D  +0-140  kcms/formats/optionsmodel.cpp
D  +0-126  kcms/formats/package/contents/ui/main.qml
A  +75   -0kcms/region_language/CMakeLists.txt
A  +8-0kcms/region_language/Messages.sh
R  +2-27   kcms/region_language/exampleutility.cpp [from:
kcms/formats/exampleutility.cpp - 052% similarity]
A  +22   -0kcms/region_language/exampleutility.h [License: GPL(v2.0+)]
A  +82   -0kcms/region_language/kcm_regionandlang.desktop [TRAILING SPACE]
** [TRAILING SPACE] **
R  +4-4kcms/region_language/kcm_regionandlang.json [from:
kcms/formats/kcm_formats.json - 098% similarity]
A  +250  -0kcms/region_language/kcmregionandlang.cpp [License:
GPL(v2.0+)]
A  +58   -0kcms/region_language/kcmregionandlang.h [License:
GPL(v2.0+)]
A  +372  -0kcms/region_language/languagelistmodel.cpp [License:
GPL(v2.0+)]
A  +100  -0kcms/region_language/languagelistmodel.h [License:
GPL(v2.0+)]
A  +30   -0kcms/region_language/localegenerator.cpp [License:
LGPL(v2.0+)]
A  +17   -0kcms/region_language/localegenerator.h [License:
LGPL(v2.0+)]
A  +19   -0kcms/region_language/localegeneratorbase.cpp [License:
GPL(v2.0+)]
A  +23   -0kcms/region_language/localegeneratorbase.h [License:
GPL(v2.0+)]
A  +32   -0kcms/region_language/localegeneratorglibc.cpp [License:
GPL(v2.0+)]
A  +24   -0kcms/region_language/localegeneratorglibc.h [License:
GPL(v2.0+)]
A  +101  -0kcms/region_language/localegeneratorubuntu.cpp [License:
GPL(v2.0+)]
A  +27   -0kcms/region_language/localegeneratorubuntu.h [License:
GPL(v2.0+)]
A  +36   -0kcms/region_language/localegenhelper/CMakeLists.txt
A  +187  -0kcms/region_language/localegenhelper/localegenhelper.cpp
[License: GPL(v2.0+)]
A  +46   -0kcms/region_language/localegenhelper/localegenhelper.h
[License: GPL(v2.0+)]
A  +20   -0   
kcms/region_language/localegenhelper/org.kde.localegenhelper.conf
A  +21   -0   
kcms/region_language/localegenhelper/org.kde.localegenhelper.policy
A  +8-0   
kcms/region_language/localegenhelper/org.kde.localegenhelper.service.in
A  +158  -0kcms/region_language/localelistmodel.cpp [License: GPL
(v2+)]
R  +22   -22   kcms/region_language/localelistmodel.h [from:
kcms/formats/localelistmodel.h - 060% similarity]
A  +197  -0kcms/region_language/optionsmodel.cpp [License: GPL(v2.0+)]
R  +21   -11   kcms/region_language/optionsmodel.h [from:
kcms/formats/optionsmodel.h - 054% similarity]
A  +204  -0   
kcms/region_language/package/contents/ui/AdvancedLanguageSelectPage.qml
[License: LGPL(v3.0+)]
A  +238  -0kcms/region_language/package/contents/ui/main.qml [License:
LGPL(v3.0+)]
A  +64   -0kcms/region_language/regionandlangsettings.cpp [License:
GPL(v2.0+)]
A  +21   -0kcms/region_language/regionandlangsettings.h [License:
GPL(v2.0+)]

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2022-06-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=454991

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
This might be fixed with
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1147.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2022-06-07 Thread Eduardo Correia
https://bugs.kde.org/show_bug.cgi?id=454991

Eduardo Correia  changed:

   What|Removed |Added

Version|5.24.90 |5.24.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 454991] Language KCM sets wrong language variable for European Portuguese (pt_PT)

2022-06-07 Thread Eduardo Correia
https://bugs.kde.org/show_bug.cgi?id=454991

Eduardo Correia  changed:

   What|Removed |Added

   Keywords||accessibility, usability

-- 
You are receiving this mail because:
You are watching all bug changes.