D27270: Use ecm_qt_install_logging_categories over manual categories files

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R174 KContacts

BRANCH
  generateqtlogcatfile

REVISION DETAIL
  https://phabricator.kde.org/D27270

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent added a comment.


  In D27150#608491 , @kossebau wrote:
  
  > In D27150#608318 , @mlaurent 
wrote:
  >
  > > Yep you need to create a file name "foo.renamecategories" where you 
change the categorie name
  > >
  > > 1. old module namenew module name
  > >
  > >   for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail
  >
  >
  > Does kdebugsettings also support multiple renames? Like log1 > log2 > log3?
  
  
  Perhaps :) I will test it next week
  
  > 
  > 
  >> What do you need as " Could that be supported by some additional macro or 
adaption of the existing/new ones?" ?
  > 
  > We could have another argument for `ecm_qt_declare_logging_category`& 
`ecm_qt_export_logging_category` to pass old log names, and then have 
`ecm_qt_install_logging_categories` also generate & install a .renamecategories 
file. Should be easy to add, working on it next.
  
  oki

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent added a comment.


  Yep you need to create a file name "foo.renamecategories" where you change 
the categorie name
  
  old module namenew module name
  =
  
  for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail
  
  What do you need as " Could that be supported by some additional macro or 
adaption of the existing/new ones?" ?

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent added a comment.


  I don't see other case. For me your macro works for all case that we can 
implement.
  
  No other idea.
  But avoiding to create by hand the file is a good idea. I never successed to 
create a macro for it
  So thanks

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent added a comment.


  Seems ok for me

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27151: Use ecm_qt_install_logging_categories over manual categories file

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me.

REPOSITORY
  R244 KCoreAddons

BRANCH
  generateqtlogcatfile

REVISION DETAIL
  https://phabricator.kde.org/D27151

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:0c95c9f799cd: Create specific directory for Qt logging 
categories file (authored by mlaurent).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58952=58953

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Laurent Montel]

mlaurent retitled this revision from "Create specific directory for 
kdebugsettings categories file" to "Create specific directory for Qt logging 
categories file".

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58952.
mlaurent added a comment.


  Fix typo

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58746=58952

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent added a comment.


  So ? :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58746.
mlaurent added a comment.


  Change as qlogging-categories5

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58604=58746

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent added a comment.


  Thanks david.
  Indeed qlogging-categories5 seems a good name :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent added a comment.


  LOGGINGCATEGORIESDIR indeed it's more specific +1 for me
  debug-categories5 => indeed it's just using by kdebugsettings at the moment. 
=> kdebugsettings-categories5 ? 
  no idea if it's better.
  
  @dfaure do you have an idea ?:)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58604.
mlaurent added a comment.


  Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR
  
  Thanks for pointing me it :)

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58454=58604

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent added a comment.


  Ping ?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58454.
mlaurent added a comment.


  Use DEBUGCATEGORIESDIR and debug-categories5

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58391=58454

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent added a comment.


  DEBUGCATEGORIESDIR is fine for me too
  
  debug-categories5 ?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58391.
mlaurent added a comment.


  Fix comment reported by Christophe Giboudeaux

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58390=58391

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58390.
mlaurent added a comment.


  Forgot to commit before creating diff

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58389=58390

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  kdebugsettings categories files

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:9b528012703a: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT 
as default compile flags (authored by mlaurent).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15566?vs=41793=42140

REVISION DETAIL
  https://phabricator.kde.org/D15566

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

[Laurent Montel]

mlaurent added a comment.


  Ping?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15566

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

[Laurent Montel]

mlaurent added a comment.


  I fixed 2 repos.
  Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some 
module is not compiles on my computer)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15566

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15566

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

[Laurent Montel]

mlaurent created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_QT_NO_NARROWING_CONVERSIONS_IN_CONNECT

REVISION DETAIL
  https://phabricator.kde.org/D15566

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D9446: WIP: Allow to autogenerate and install categories file

[Laurent Montel]

mlaurent abandoned this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9446

To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: #frameworks, #build_system, michaelh, ngraham

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

[Laurent Montel]

> On Dec. 30, 2016, 6:39 a.m., Martin Gräßlin wrote:
> > Is that enabled by default now? I hope not! This is a completely useless 
> > warning for all frameworks (as we are not allowed to use override) and even 
> > more for a legacy code bases. I don't want to have to adjust the cmake in 
> > all projects I maintain to silence this warning again. And even less I want 
> > to spent days adding overrides to legacy code base.

We can use Q_DECL_OVERRIDE which is replaced by override when your gcc support 
it. So There is not a problem to use this flags no ?


- Laurent


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/#review101664
---


On Dec. 29, 2016, 11:48 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129724/
> ---
> 
> (Updated Dec. 29, 2016, 11:48 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Gives a nice warning about something that should be marked as override but 
> isn't
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 
> 
> Diff: https://git.reviewboard.kde.org/r/129724/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 122941: Warn about icon filenames with leading characters.

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122941/#review77466
---


Seems good for me.
Ship it :)
(I started to create a script to fix all application and rename icon and adapt 
cmakelists.txt)

- Laurent Montel


On mars 14, 2015, 12:47 après-midi, Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122941/
 ---
 
 (Updated mars 14, 2015, 12:47 après-midi)
 
 
 Review request for Extra Cmake Modules and Laurent Montel.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Through a quirk of implementation, old-style icon filenames are accepted
 by the new-style ecm_install_icons function. It's too late to change it
 now, as that would break existing projects, but we can warn about it.
 
 
 Diffs
 -
 
   modules/ECMInstallIcons.cmake 34d5a485c08bb904f13f1da8a80d6835d32e1365 
   tests/ECMInstallIconsTest/16-apps-cmake.png  
   tests/ECMInstallIconsTest/CMakeLists.txt 
 85f2d9f55e263c2983167622b3bb74dce21c10d3 
   tests/ECMInstallIconsTest/hi16-actions-old-style-name.png PRE-CREATION 
   tests/ECMInstallIconsTest/subdir/16-apps-cmake.png PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/122941/diff/
 
 
 Testing
 ---
 
 Tests pass. The test output log shows the warning for the appropriate file, 
 and not for other files.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: FindPlasma.cmake obsolete ?

[Laurent Montel]

On Sunday 04 January 2009 16:43:48 Alexander Neundorf wrote:
 Hi,

 in kdelibs/cmake/modules/ there is a FindPlasma.cmake.

 But plasma has moved to kdelibs and is now found automatically by
 find_package(KDE4)
 which sets the appropriate variables like KDE4_PLASMA_LIBS etc.

 Before KDE 4.2 there were no compatibility guarantees for plasma, right ?
 So, where is this file used ?
 I think it should be removed now that plasma is part of kdelibs. And we
 can't break anything by removing it, since plasma itself will have broken
 everything which depended on it before 4.2, right ?

 Alex
Hi,

I am against to remove it because some program use it as:
extragear/network/ktorrent/plasma/applet
We can see that this developper adapt code to support plasma  4.2 and plasma 
=4.2
And it used PLASMA_FOUND.

Regards

-- 
Laurent Montel,
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: FindPlasma.cmake not ok

[Laurent Montel]

On Thursday 06 November 2008 00:46:47 Alexander Neundorf wrote:
 Hi,

 FindPlasma.cmake as it is currently in kdelibs doesn't make sense.
 Each cmake module should (or must) be self-contained, i.e. you should be
 able to do simply

 find_package(Foo)

 and you should get the expected results.
 Now FindPlasma.cmake is right now only this:

 8-88---
 set(PLASMA_LIBS ${KDE4_PLASMA_LIBS} )
 set(PLASMA_INCLUDE_DIR ${KDE4_INCLUDE_DIR})
 set(PLASMA_FOUND true)

 find_file(PLASMA_OPENGL_FOUND plasma/glapplet.h
   PATHS ${PLASMA_INCLUDE_DIR}
   NO_DEFAULT_PATH)

 mark_as_advanced(PLASMA_INCLUDE_DIR PLASMA_LIBS)
 8-88---


 If I just do
 find_package(Plasma)

 I will PLASMA_FOUND TRUE as result, which would be clearly wrong (i.e.
 PLASMA_LIBS and PLASMA_INCLUDE_DIR would be empty).

 What would in some way work would be:

 find_package(KDE4)
 find_package(Plasma)

 Still PLASMA_FOUND would always be true then, also if KDE4 was *not* found.

 So, this needs to be fixed.
 How ?
 Does a separate FindPlasma.cmake still make sense ?
 It's probably good to keep it for compatibility.

yes

 The minimum would be to add something like this:

 if(NOT DEFINED KDE4_FOUND)
find_package(KDE4)
 endif(NOT DEFINED KDE4_FOUND)

 ...
 set(PLASMA_FOUND ${KDE4_FOUND})
 ...

By default FindPlasma will be installed when we install kde4. But it's right 
it's better to add it.

 This would make it self-contained and also report correct results.

 Somewhat harder would be to make it empty except a message like
 message(FATAL_ERROR FindPlasma.cmake doesn't exist anymore, please use
 this and that instead)

 This would be cleaner but not be backward compatible. But OTOH, Plasma will
 just start staying compatible with the 4.2 release, right ?
 So anything relying on it since 4.1 may be broken anyway ?

I keep FindPlasma because some module as extragear can be compile yet with kde 
4.1 and kde 4.2 (I tested it previous week)
And I don't want that we create a hack in extragear module to change 
${PLASMA_LIBS} and ${PLASMA_INCLUDE_DIR} when we use kde4.1 or kde 4.2
it's better to keep compatibility with old cmake plasma variable.
Otherwise we must add a check in extragear module to disable plasma build when 
kdelibs  4.2

Regards

 Alex



-- 
Laurent Montel,
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: [PATCH] FindPackageHandleStandardArgs Default Message

[Laurent Montel]

On Thursday 23 August 2007 14:18:13 Allen Winter wrote:
 Comments on the attached patch?

 I think it provides a little nicer default message when
 the package cannot  be found.

For me sound good.
Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: KDE version string not in build system available

[Laurent Montel]

On Wednesday 20 June 2007 10:13:35 Stephan Kulow wrote:
 Am Mittwoch 20 Juni 2007 schrieb Ralf Habacker:
  Hi,
 
  for win32 packaging of kdelibs I need the recent KDE version string in
  the build system which is only available at c++ level yet provided by
  the file kdecore/util/kdeversion.h which defines some VERSION macros
 
  #define KDE_VERSION_STRING 3.90.1 (KDE 4.0 = 20070518)
  /// @brief Major version of KDE, at compile time
  #define KDE_VERSION_MAJOR 3
  /// @brief Minor version of KDE, at compile time
  #define KDE_VERSION_MINOR 90
  /// @brief Release version of KDE, at compile time
  #define KDE_VERSION_RELEASE 1
 
  If there are no objectivities I would place this into the top level
  CMakeLists.txt and generate kdeversion.h in top level build root from it
  according the followin cmake code snippets

 You should also install the values by means of KDELibsDependencies.cmake

Yes it will great.
Add this value into kdelibs/CMakeLists.txt.
Thanks
Regards

 Greetings, Stephan
 ___
 Kde-buildsystem mailing list
 Kde-buildsystem@kde.org
 https://mail.kde.org/mailman/listinfo/kde-buildsystem
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Buildsystem for Translators

[Laurent Montel]

On lundi 02 avril 2007, Thomas Reitelbach wrote:
 Hello everyone,

 thanks to Laurent, who implemented the buildsystem for trunk/l10n-kde4 for
 us translators.

 Unfortunately I have trouble with it, and i hope you can help me. This is
 what i do:

 In trunk/l10n-kde4/:
 - ./scripts/autogen.sh de #-generates the CMakeLists.txt files for de
 - cd de
 - cmake -DCMAKE_INSTALL_PREFIX=/home/kde4/kde .
 - cd messages
 - make#-builds all *.gmo files in all subdirectories
 - make install #does only install entry.desktop, but no *.gmo files

For me it works fine.
It installed *.mo files.
Which cmake version do you used ?

(try: cd de
mkdir build
cd build
cmake -DCMAKE_INSTALL_PREFIX=/home/kde4/kde ../
make
make install
)
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: CMake in l10n-kde4

[Laurent Montel]

On Saturday 17 March 2007 23:48:01 Thomas Reitelbach wrote:
 Am Samstag, 17. März 2007 18:21:37 schrieb Laurent Montel:
  On Saturday 17 March 2007 16:27:20 Stephan Kulow wrote:
   No, I can do the autogen.sh if someone has cmake macros to compile and
   install docbook and PO files
 
  I will do it.
  Regards

 Thank you very much for your help, Laurent :-)
 I would have done it myself, i'm not a lazy slacker, but I really don't
 understand how this build system magic works.

Now we can generate po files with cmake.
But there is not translated doc file (as previously)

Regards

 Cheers,
 Thomas
 ___
 Kde-buildsystem mailing list
 Kde-buildsystem@kde.org
 https://mail.kde.org/mailman/listinfo/kde-buildsystem
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: CMake in l10n-kde4

[Laurent Montel]

On Saturday 17 March 2007 11:20:25 Thomas Reitelbach wrote:
 On Donnerstag, 15. März 2007, Thomas Reitelbach wrote:
  Hello list,
 
  my name is Thomas Reitelbach, i'm one of the team coordinators for german
  translations. I'm currently preparing myself to begin translation for KDE
  4 and came across the currently missing build system for translators.
 
  Is anyone currently working on a CMake port of the build system for KDE4
  l10n?
 
  Some teams have already started translation effort for KDE 4, but
  currently we have to manually compile each PO file and copy it to it's
  final destination, which is much work compared to the old AM based
  system. We have to check our translations with the corresponding program
  at runtime and thus have to install our translations.
 
  Can anyone tell me more about it?

 Hm, is no one reading this list or does nobody know anything about it?

I can look at it. But I didn't know if Stephan Kulow started to work on.
Stephan ?

 Cheers,
 Thomas
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: required CMake version is still 2.4.3

[Laurent Montel]

On Thursday 08 March 2007, Alexander Neundorf wrote:
 On Thursday 08 March 2007 18:31, Thiago Macieira wrote:
  Alexander Neundorf wrote:
  If we then find that we really need to raise the required minimum
   version then we'll announce it on k-c-d, kde-buildsystem and kde-devel
   and do it two weeks later. I really hate it when I come to my box and
   just notice that something doesn't build anymore because some
   requirement was silently changed.
 
  Again, let's announce it right now that you need to upgrade and be done
  with it.
 
  Alternatively, we can do a general requirements upgrade when we decide to
  switch to the Qt 4.3 betas.

 Do you know when SUSE 10.3 and kUbuntu 7.04 Feisty Fawn wil be released and
 which versions they will ship ?

 We shouldn't require a newer version than these two will ship.

Why just Kubuntu/Suse ?
Why not look at Mandriva/RedHat/Debian ?

 Bye
 Alex
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: macro_bool_to_01 not defining stuff right in kdeedu?

[Laurent Montel]

On Tuesday, December 19, 2006 09:43:07 PM Benjamin Reed wrote:
 in kdeedu's ConfigureChecks.cmake, I see this:

could you add :
include(MacroBoolTo01)
into ConfigureChecks.cmake
is it fix your pb ?
Regards

   check_include_files(termios.h TERMIOS_FOUND)
   macro_bool_to_01(TERMIOS_FOUND HAVE_TERMIOS_H)

 ...from what I can tell, it's supposed to define HAVE_TERMIOS_H to 1
 or 0 depending on whether termios.h is found.

 My CMakeCache.txt in kdeedu seems to think it's there:

   //Have include TERMIOS_FOUND
   TERMIOS_FOUND:INTERNAL=1

 ...but a grep of the build tree shows that HAVE_TERMIOS_H never gets set:

   $ grep -r HAVE_TERMIOS .
   ./config.h:/* #undef   HAVE_TERMIOS 1 */

 Any idea where the disconnect is?
 ___
 Kde-buildsystem mailing list
 Kde-buildsystem@kde.org
 https://mail.kde.org/mailman/listinfo/kde-buildsystem
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: RFC: automoc changes

[Laurent Montel]

On Sunday 05 November 2006 13:48, Alexander Neundorf wrote:
 Hi,
{..}
Hi,

 I see three options:
 1) disabled by default and require the argument AUTOMOC:
 kde4_add_executable(kblub AUTOMOC ${mySrcs} )   # with automoc
 kde4_add_executable(kblah ${myOtherSrcs} )  # no automoc

 pro: cmake will only do what it's explicitely told
 con: all kde4_add_*() calls have to be adjusted

When we look at CMakeLists.txt into kde project we can see that all program 
have a automoc (I didn't see a lot of cmakelists.txt which have not a automoc 
macro)
= for me it will better to use a NO_AUTOMOC argument to disable it.

 2) enabled by default and require NO_AUTOMOC for disabling it:
 kde4_add_executable(kblub ${mySrcs} ) # with automoc
 kde4_add_executable(kblah NO_AUTMOC ${myOtherSrcs} )  # no automoc
 pro: no need to modify all kde4_add_*() calls
 con: cmake will do something implicitely, which I don't really like

 3) use a variable which will decide whether the functions will use automoc
 or not:
 set(KDE4_AUTOMOC TRUE)
 kde4_add_executable(kblub ${mySrcs} ) # with automoc
 set(KDE4_AUTOMOC FALSE)
 kde4_add_executable(kblah ${mySrcs} ) # no automoc

I don't like it, because we must set/unset variable, and it's easy to forgot 
to unset it into same CMakeLists.txt

 pro:
 -no need to modify all kde4_add_*() calls
 -slightly faster at cmake time than 1) and 2)
 con:
 -using an explicite argument instead of a global variable to influence the
 behaviour is easier to document and understand

 So, any opinions on this ?

 Bye
 Alex

 Btw. can we please archive this mailing list on lists.kde.org ?

Regards.
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: How to add a specific .o file generated (with cmake)

[Laurent Montel]

On Wednesday 18 October 2006 18:36, Brad King wrote:
 Laurent Montel wrote:
  On Wednesday 18 October 2006 17:58, Alexander Neundorf wrote:
  On Wednesday 18 October 2006 17:42, Laurent Montel wrote:
  Hi,
  Into kalzium we generate a .o file.
  We want to link it with kalzium binary.
 
  How is it possible to specify a obj file when we want to create a
  binary ? (obj file is a C file)
 
  Can you please explain a bit more ? It sounds a bit like a hack.
 
  We have an object file generated (into kdeedu/kalzium/src/solver/) with
  ocalm program.
  We generate directly a obj file.
  After we must add this object file when we will create binary kalzium.

 Just include the object file in the list of sources for the target.
 CMake will recognize it as an external object file and include it in the
 link line.

Ok thanks.
It works now.
Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: How to add a specific .o file generated (with cmake)

[Laurent Montel]

On Wednesday 18 October 2006 17:58, Alexander Neundorf wrote:
 On Wednesday 18 October 2006 17:42, Laurent Montel wrote:
  Hi,
  Into kalzium we generate a .o file.
  We want to link it with kalzium binary.
 
  How is it possible to specify a obj file when we want to create a binary
  ? (obj file is a C file)

 Can you please explain a bit more ? It sounds a bit like a hack.

We have an object file generated (into kdeedu/kalzium/src/solver/) with ocalm 
program.
We generate directly a obj file.
After we must add this object file when we will create binary kalzium.


For the moment I try to use :

set_source_files_properties (
  eqresult.cpp PROPERTIES
  OBJECT_DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/solver.o
  )

For the moment it's not perfect.

ocalm doesn't generate a lib but just an object file

 It should be possible to add the object file with the full path either to
 the sources or using target_link_libraries(). I never did that, but I can
 vaguely remember some message on the mailing list already quite long ago.



 Bye
 Alex
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: cmake and install file + group

[Laurent Montel]

On Friday 11 August 2006 15:10, William A. Hoffman wrote:
 At 01:17 AM 8/11/2006, Laurent Montel wrote:
 On Friday 11 August 2006 02:15, William A. Hoffman wrote:
  At 01:07 PM 8/10/2006, Laurent Montel wrote:
  Hi,
  What is the command if I want to install a file with specific
   group/user ?
 
  See the INSTALL command:
 
  http://www.cmake.org/HTML/Documentation.html
 
  
  PERMISSIONS arguments specify permissions for installed files. Valid
  permissions are OWNER_READ, OWNER_WRITE, OWNER_EXECUTE, GROUP_READ,
  GROUP_WRITE, GROUP_EXECUTE, WORLD_READ, WORLD_WRITE, WORLD_EXECUTE,
  SETUID, and SETGID. Permissions that do not make sense on certain
  platforms are ignored on those platforms. 
 
 Yes I used it for changing properties of files but how change owner of
  files. For example if I want to install a binary for group sounds ?

 Your right, you can not do that with the command.   I guess you would
 have to use a POST_INSTALL_SCRIPT

Thanks for info.

 , and put a feature request into the 
 cmake bug tracker for this ability to be added to the INSTALL command.

Done

 See SET_TARGET_PROPERTIES for information on POST_INSTALL_SCRIPT.



 -Bill

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

cmake and install file + group

[Laurent Montel]

Hi,
What is the command if I want to install a file with specific group/user ?

Thanks
Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: KDE/kdelibs/cmake/modules

[Laurent Montel]

On Tuesday 01 August 2006 20:22, David Faure wrote:

Hi,
What do you think about this patch ?

I readd as for old build system a libsuffix 

Regards

 On Monday 31 July 2006 09:41, Laurent Montel wrote:
  SVN commit 568125 by mlaurent:
 
  Fix pb when we relauch ccmake -D... ../
  LIB_* variable was not changed
 
 
   M  +1 -1  FindKDE4Internal.cmake
 
 
  --- trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake #568124:568125
  @@ -197,7 +197,7 @@
   ## the following are directories where stuff will be installed to
set(BIN_INSTALL_DIR  ${EXEC_INSTALL_PREFIX}/bin  
 CACHE PATH The kde info install dir (default prefix/info) FORCE)
  set(SBIN_INSTALL_DIR ${EXEC_INSTALL_PREFIX}/sbin   
   CACHE PATH The kde info install dir (default prefix/info) FORCE) -
  set(LIB_INSTALL_DIR  ${EXEC_INSTALL_PREFIX}/lib
   CACHE PATH The subdirectory relative to the install prefix where
  libraries will be installed (default is /lib)) + set(LIB_INSTALL_DIR
   ${EXEC_INSTALL_PREFIX}/lib  CACHE PATH The
  subdirectory relative to the install prefix where libraries will be
  installed (default is /lib) FORCE)

 Ohoh, this reverts an earlier commit. The FORCE broke for people using
 /lib64 iirc; check svn logs.
Index: FindKDE4Internal.cmake
===
--- FindKDE4Internal.cmake	(revision 568750)
+++ FindKDE4Internal.cmake	(working copy)
@@ -190,15 +190,15 @@
 
 
 #add some KDE specific stuff
-
+set(LIB_SUFFIX  CACHE STRING Define suffix of directory name (32/64) FORCE)
  set(SHARE_INSTALL_PREFIX ${CMAKE_INSTALL_PREFIX}/share CACHE PATH Base directory for files which go to share/ FORCE)
  set(EXEC_INSTALL_PREFIX  ${CMAKE_INSTALL_PREFIX}   CACHE PATH  Base directory for executables and libraries FORCE)
 #
 ## the following are directories where stuff will be installed to
  set(BIN_INSTALL_DIR  ${EXEC_INSTALL_PREFIX}/bin  CACHE PATH The kde info install dir (default prefix/info) FORCE)
  set(SBIN_INSTALL_DIR ${EXEC_INSTALL_PREFIX}/sbin CACHE PATH The kde info install dir (default prefix/info) FORCE)
- set(LIB_INSTALL_DIR  ${EXEC_INSTALL_PREFIX}/lib  CACHE PATH The subdirectory relative to the install prefix where libraries will be installed (default is /lib) FORCE)
- set(LIBEXEC_INSTALL_DIR  ${LIB_INSTALL_DIR}/kde4/libexec CACHE PATH The subdirectory relative to the install prefix where libraries will be installed (default is /lib) FORCE)
+ set(LIB_INSTALL_DIR  ${EXEC_INSTALL_PREFIX}/lib${LIB_SUFFIX} CACHE PATH The subdirectory relative to the install prefix where libraries will be installed (default is /lib${LIB_SUFFIX}) FORCE)
+ set(LIBEXEC_INSTALL_DIR  ${LIB_INSTALL_DIR}/kde4/libexec CACHE PATH The subdirectory relative to the install prefix where libraries will be installed (default is /lib/kde4/libexec) FORCE)
  set(PLUGIN_INSTALL_DIR   ${LIB_INSTALL_DIR}/kde4 CACHE PATH The subdirectory relative to the install prefix where plugins will be installed (default is ${KDE4_LIB_INSTALL_DIR}/kde4) FORCE)
  set(INCLUDE_INSTALL_DIR  ${CMAKE_INSTALL_PREFIX}/include CACHE PATH The subdirectory to the header prefix FORCE)
  set(CONFIG_INSTALL_DIR   ${SHARE_INSTALL_PREFIX}/config  CACHE PATH The config file install dir FORCE)
@@ -717,7 +717,7 @@
 # NOT used in Qt4: QT_NO_COMPAT, QT_CLEAN_NAMESPACE, QT_THREAD_SUPPORT
 set(KDE4_DEFINITIONS ${_KDE4_PLATFORM_DEFINITIONS} -DQT3_SUPPORT -DQT_NO_STL -DQT_NO_CAST_TO_ASCII -D_REENTRANT -DQT3_SUPPORT_WARNINGS -DKDE_DEPRECATED_WARNINGS )
 
-string(REGEX REPLACE .*/lib  KDELIBSUFF ${LIB_INSTALL_DIR} )
+set( KDELIBSUFF ${LIB_SUFFIX} )
 
 
 if (NOT _kde4_uninstall_rule_created)
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: KDE/kdepimlibs/kabc/kab

[Laurent Montel]

On Thursday 20 July 2006 20:47, Allen Winter wrote:
 On Thursday 20 July 2006 11:12, Laurent Montel wrote:
  On Thursday 20 July 2006 15:30, Allen Winter wrote:
   On Thursday 20 July 2006 09:22, Laurent Montel wrote:
SVN commit 564561 by mlaurent:
   
bin-${BIN_INSTALL_DIR}
  
   Laurent,
  
   These kind of fixes imply that we need a lint for CMakeLists.txt.
 
  a lint ?
  what means 'lint' ?

 From the lint man page:
 The lint utility attempts to detect features of the named C program files
 that are likely to be bugs, to be non-portable, or to be wasteful.  It
 also performs stricter type checking than does the C compiler. 

ok thanks for info

   Do you have a script that you are running to find these problems?
   Should we write one?
 
  Just it. Not perfect I think but now all is fixed.
 
  find -name CMakeLists.txt | xargs grep -l  DESTINATION bin  | xargs
  perl -pi -e 's! DESTINATION bin! DESTINATION \${BIN_INSTALL_DIR}!

 Attached is an initial attempt at a 'cmakelint' command.  If we make it
 much better we could put it in kdesdk/scripts.  Let me know about other
 things to check for in CMakeLists.txt files and I will add it to the
 program. If you think this is useful.

 -Allen

You made some typo:
$issues += checkLine($line,$linecnt,
  'DESTINATION[[:space:]]lib[[:space:]]*\)',
  'replace bin with ${LIB_INSTALL_DIR}');
--^ lib I think

$issues += checkLine($line,$linecnt,
  'DESTINATION[[:space:]]include[[:space:]]*\)',
  'replace bin with ${INCLUDE_INSTALL_DIR}');

---^ include I think

Perhaps add $issues += checkLine($line,$linecnt,
  'DESTINATION[[:space:]]share/*\)',
  'replace share/ with ${DATA_INSTALL_DIR}');

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: KDE/kdepimlibs/kabc/kab

[Laurent Montel]

On Thursday 20 July 2006 15:30, Allen Winter wrote:
 On Thursday 20 July 2006 09:22, Laurent Montel wrote:
  SVN commit 564561 by mlaurent:
 
  bin-${BIN_INSTALL_DIR}

 Laurent,

 These kind of fixes imply that we need a lint for CMakeLists.txt.

a lint ?
what means 'lint' ?

 Do you have a script that you are running to find these problems?
 Should we write one?


Just it. Not perfect I think but now all is fixed.

find -name CMakeLists.txt | xargs grep -l  DESTINATION bin  | xargs 
perl -pi -e 's! DESTINATION bin! DESTINATION \${BIN_INSTALL_DIR}!
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: small patch imlib and kuickshow

[Laurent Montel]

On Wednesday 19 July 2006 08:36, Marcus Hufgard (Kalkwerk Hufgard GmbH) wrote:
 Hi!

 I have a small cmake-patch for building kuickshow. Please have a look at
 it and commit this too trunk.

Apply thanks.
Regards

 Thanks

 By

 Marcus
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Poppler-qt4

[Laurent Montel]

Hi,
There is two cmake file which allows to search poppler-qt4:
One into kdegraphics/cmake/module/FindPopplerQt4.cmake
one into playground/graphics/cmake/modules/FindPoppler.cmake

I will want to move one into kdelibs (because it duplicates)

One which is into playground search poppler-qt4 = 0.5.2 so I will add it into 
kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a 
better name for it (and renamed variable to add qt4 suffix)

Can I make it ?

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Poppler-qt4

[Laurent Montel]

On Thursday 29 June 2006 14:16, Stefan Nikolaus wrote:
 On Thursday 29 June 2006 13:57, Pino Toscano wrote:
  Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
   There is two cmake file which allows to search poppler-qt4:
   One into kdegraphics/cmake/module/FindPopplerQt4.cmake
   one into playground/graphics/cmake/modules/FindPoppler.cmake
 
  I am the author of the latter, and I planned to do that merge in case of
  a moving of okular to kdegraphics.

 If Pino will merge oKular into kdegraphics, the FindPoppler[Qt4].cmake file
 is only used there, so I object to move it to kdelibs.

Normal to not move into kdelibs if it will merge into it.

 In general I don't think it makes much sense to merge cmake files of
 playground/ as the code there is experimental/not released.

It's cmake file :) not a lib.
I don't think that cmake file can be experimental (and difference between two 
cmake file is just search poppler version.

 Regards,
 Stefan
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Licensing of cmake modules?

[Laurent Montel]

On Tuesday 27 June 2006 10:51, Dirk Mueller wrote:
 Hi,

 Before its too late: has anyone ever thought about the licensing of the
 cmake module files? I think we should re-license them as loosely as
 possible (X11/MIT license), so that other projects can just copypaste the
 code freely.

 Any opinions?

Hi,
As I created some cmake file for me it's ok to add this license.

Regards.


 Dirk
 ___
 Kde-buildsystem mailing list
 Kde-buildsystem@kde.org
 https://mail.kde.org/mailman/listinfo/kde-buildsystem
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Problem in KDEEDU with OpenBabel2

[Laurent Montel]

On Saturday 10 June 2006 17:09, Carsten Niehaus wrote:
 Am Samstag 10 Juni 2006 16:54 schrieben Sie:
  On Saturday 10 June 2006 16:01, Carsten Niehaus wrote:
   Hi
 
  You use macro_optional_find_package and I think that it's not found but
  you try to use openbabel dir when it's not found.
  use
  if(OPENBABEL2_FOUND)
  include_directories(${OPENBABEL2_DIR})
  endif(OPENBABEL2_FOUND)

 Ok, i removed the marco-line and add those three lines. The error is gone,
 in CMakeCache.txt I get this:

 //The directory containing OpenBabel2Config.cmake.
 OpenBabel2_DIR:PATH=OpenBabel2_DIR-NOTFOUND

 So it seems the FindOpenBabel2.cmake is broken, right? (I have OB2
 installed, of course)

Use MESSAGE(STATUS OPENBABEL2_INCLUDE_DIR :${OPENBABEL2_INCLUDE_DIR} --- 
OPENBABEL2_LIBRARIES : ${OPENBABEL2_LIBRARIES})


Look at where is install your openbabel/obconversation.h
and add good path

  But I don't see into kalzium where you use it
  so perhaps it's an other pb I don't know

 Yes, I cannot use it when the cmake-stuff is not working :) 

ok :)

 As soon as the 
 cmake-checks work I will port Kalzium to OpenBabel2. Or do I have to use it
 so that cmake is changing behaviour? (like ui-files are not compiled until
 you include the ui_classname.h -file in the project)

But OpenBabel2 is requires or optional ?
if optional you will able to compile without it
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

duplicate cmake file between kde module.

[Laurent Montel]

Hi,
Now as we store necessary cmake file (for specific module) into cmake/modules 
we have some duplicate cmake check file.

For example FindBerkeleyDB.cmake is stored into kdesdk and kdevelop
(we can't force use to compile kdesdk before kdevelop or kdevelop before 
kdesdk, but this check is necessary)

Same as for FindTaglib.cmake which is necessary for amarok and kdemultimedia 
or FindMusicBrainz.cmake (amarok/kdemultimedia), FindPostgreSQL.cmake need by 
koffice and amarok etc.

For me it's not just as admin directory as previously which was a svn link = 
when we changed into admin all files was changed into all module.
For the moment it's duplicate files.

I know that for the future it will a good idea to move them into CMake 
package, but for the moment we can't.

So perhaps it will a good idea to create a kde-cmake-module directory which 
will contain all duplicated file. It will very easy to create it.

For me move all into kdelibs is not a good idea, I don't think that all guy 
want to upgrade all the time its kdelibs to have cmake check update, and 
problem will arrive when we will create branche (kde-4.0/kde-4.1 etc... = 
need to duplicate file into branch)


What do you think ?

PS: I add file which contains all cmake module.
./kdelibs4_snapshot/cmake/modules/CheckTypeSize.cmake
./kdelibs4_snapshot/cmake/modules/FindACL.cmake
./kdelibs4_snapshot/cmake/modules/FindZLIB.cmake
./kdelibs4_snapshot/cmake/modules/FindFAM.cmake
./kdelibs4_snapshot/cmake/modules/FindCarbon.cmake
./kdelibs4_snapshot/cmake/modules/MacroEnsureOutOfSourceBuild.cmake
./kdelibs4_snapshot/cmake/modules/CheckPrototypeExists.cmake
./kdelibs4_snapshot/cmake/modules/FindGIF.cmake
./kdelibs4_snapshot/cmake/modules/MacroGetenvWinPath.cmake
./kdelibs4_snapshot/cmake/modules/CheckPointerMember.cmake
./kdelibs4_snapshot/cmake/modules/FindQt4.cmake
./kdelibs4_snapshot/cmake/modules/KDE4Defaults.cmake
./kdelibs4_snapshot/cmake/modules/FindOpenEXR.cmake
./kdelibs4_snapshot/cmake/modules/FindASPELL.cmake
./kdelibs4_snapshot/cmake/modules/MacroBoolTo01.cmake
./kdelibs4_snapshot/cmake/modules/FindAkode.cmake
./kdelibs4_snapshot/cmake/modules/FindJasper.cmake
./kdelibs4_snapshot/cmake/modules/MacroOptionalFindPackage.cmake
./kdelibs4_snapshot/cmake/modules/FindGettext.cmake
./kdelibs4_snapshot/cmake/modules/FindKDEWIN32.cmake
./kdelibs4_snapshot/cmake/modules/FindTIFF.cmake
./kdelibs4_snapshot/cmake/modules/FindPCRE.cmake
./kdelibs4_snapshot/cmake/modules/FindLibXml2.cmake
./kdelibs4_snapshot/cmake/modules/CheckStructMember.cmake
./kdelibs4_snapshot/cmake/modules/FindX11.cmake
./kdelibs4_snapshot/cmake/modules/FindCups.cmake
./kdelibs4_snapshot/cmake/modules/FindDNSSD.cmake
./kdelibs4_snapshot/cmake/modules/FindGNUWIN32.cmake
./kdelibs4_snapshot/cmake/modules/FindLibArt.cmake
./kdelibs4_snapshot/cmake/modules/CheckCXXCompilerFlag.cmake
./kdelibs4_snapshot/cmake/modules/MacroLogFeature.cmake
./kdelibs4_snapshot/cmake/modules/FindLibXslt.cmake
./kdelibs4_snapshot/cmake/modules/MacroAdditionalCleanFiles.cmake
./kdelibs4_snapshot/cmake/modules/MacroAddFileDependencies.cmake
./kdelibs4_snapshot/cmake/modules/FindOpenSSL.cmake
./kdelibs4_snapshot/cmake/modules/kde4_exec_via_sh.cmake
./kdelibs4_snapshot/cmake/modules/FindSasl2.cmake
./kdelibs4_snapshot/cmake/modules/FindKDE4Internal.cmake
./kdelibs4_snapshot/cmake/modules/MacroLibrary.cmake
./kdelibs4_snapshot/cmake/modules/FindXmms.cmake
./kdelibs4_snapshot/cmake/modules/FindGSSAPI.cmake
./kdelibs4_snapshot/cmake/modules/FindBZip2.cmake
./kdelibs4_snapshot/cmake/modules/FindHSPELL.cmake
./kdelibs4_snapshot/cmake/modules/kde4uic.cmake
./kdelibs4_snapshot/cmake/modules/KDE4Macros.cmake
./kdelibs4_snapshot/cmake/modules/MacroEnsureVersion.cmake
./kdelibs4_snapshot/cmake/modules/FindAGG.cmake
./kdebase/cmake/modules/FindRAW1394.cmake
./kdebase/cmake/modules/FindSamba.cmake
./kdebase/cmake/modules/FindSensors.cmake
./kdebase/cmake/modules/FindUSB.cmake
./kdebase/cmake/modules/FindLdap.cmake
./kdebase/cmake/modules/remove_files.cmake
./kdebase/cmake/modules/cmake_install.cmake
./kdebase/cmake/modules/FindKDM.cmake
./kdebase/cmake/modules/FindFontconfig.cmake
./kdebase/cmake/modules/FindFreetype.cmake
./kdeaccessibility/cmake/modules/FindAlsa.cmake
./kdeaccessibility/cmake/modules/FindKttsmodule.cmake
./kdeaccessibility/cmake/modules/config-alsa.h.cmake
./kdeedu/cmake/modules/FindBoostPython.cmake
./kdepim/cmake/modules/FindGpgme.cmake
./kdepim/cmake/modules/FindLIBKDEPIM.cmake
./kdepim/cmake/modules/cmake_install.cmake
./kdepim/cmake/modules/FindMAL.cmake
./kdepim/cmake/modules/KodeMacros.cmake
./kdepim/cmake/modules/FindXPM.cmake
./kdepim/cmake/modules/CheckTimezone.cmake
./kdepim/cmake/modules/FindKode.cmake
./kdepim/cmake/modules/FindBoost.cmake
./kdenetwork/cmake/modules/FindQCA2.cmake
./kdenetwork/cmake/modules/FindIW.cmake
./kdenetwork/cmake/modules/FindSLP.cmake
./kdeutils/cmake/modules/FindGMP.cmake
./kdeutils/cmake/modules/FindTPCTL.cmake
./kdesdk/cmake/modules/FindSVN.cmake

cmake + segfault

[Laurent Montel]

Hi,
I use cmake-2.4.1-beta and when I write just:
cmake -D I have a Segmentation fault

I don't know where report this bug so I wrote here where there is some cmake 
developper. (I didn't test cmake-2.4.2 for the moment)

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

KDE/kdesdk/kbugbuster

[Laurent Montel]

SVN commit 541270 by mlaurent:

Add message to signal why kresource will not compile
(I think that it will better to have a configure.in.bot into cmake)
CCMAIL: kde-buildsystem@kde.org



 M  +3 -1  CMakeLists.txt  


--- trunk/KDE/kdesdk/kbugbuster/CMakeLists.txt #541269:541270
@@ -60,7 +60,9 @@
 
 if(LIBKCAL_RESOURCECALENDAR)
add_subdirectory(kresources)
-endif(LIBKCAL_RESOURCECALENDAR)
+else( LIBKCAL_RESOURCECALENDAR)
+   MESSAGE(STATUS Unable to find libkcal. The Bugzilla todo list resource 
for KOrganizer won't be compiled)
+endif(LIBKCAL_RESOURCECALENDAR)
 
 include_directories( ${CMAKE_SOURCE_DIR}/kbugbuster/backend  )
 
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: KDE/kdesdk/kbugbuster

[Laurent Montel]

On Monday 15 May 2006 23:42, Allen Winter wrote:
 On Monday 15 May 2006 17:27, David Faure wrote:
  On Monday 15 May 2006 22:55, Laurent Montel wrote:
   SVN commit 541270 by mlaurent:
  
   Add message to signal why kresource will not compile
   (I think that it will better to have a configure.in.bot into cmake)
 
  In other terms, this is a request for a way to collect warnings and show
  them at the end of the execution. Could be done with kde-specific macros
  or could be done in cmake. Any CMakeLists.txt in any subdir could add a
  message to the list, and then some code that runs at the end of it all
  (I guess that would be the bottom of the toplevel CMakeLists.txt) would
  issue those messages.
 
  Is there interest for such a feature in cmake or should we implement it
  with our own macros?

 However we do it... let's please take this opportunity to come up with a
 standard message format.

 I don't like Warning in this situation.  I like better a wording that
 states you are missing features since you don' t have something installed. 
 And it would be nice to always have a URL pointing you to where the
 optional software can be obtained.

 Now, I haven't given this a lot of thought (Adriaan maybe has), but
 something like the following might be nice:


 Notice:  Your build will be missing the following features because some
 optional software packages could not be located.  Please install the
 optional software as indicated below and re-run 'cmake' if you would like
 to have the associated feature enabled:

 FEATURE: gives extra coolness to kneato
 PACKAGE: cool software
 URL: http://cool_software.org

 FEATURE: weaponize your computer
 PACKAGE: libarmament
 URL: http://www.armament.org/download
 

 So maybe we have a cmake macro
 missing_feature_message(description,package name,url)

 or something like this...
 -Allen

I agree with you.
A standard message format is a very good idea.
For me it will better that it will integrate into cmake and not just a kde 
cmake macro.
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

koffice

[Laurent Montel]

SVN commit 534050 by mlaurent:

Add first cmake support for ruby kross bindings
It's a modified version from cmake-2.4.0 FindRuby
Perhaps we can merge it for cmake-2.4.1
CCMAIL: kde-buildsystem@kde.org


 A cmake/modules/FindRUBY.cmake  
 M  +6 -2  libs/kross/CMakeLists.txt  
 M  +2 -2  libs/kross/ruby/CMakeLists.txt  


--- trunk/koffice/libs/kross/CMakeLists.txt #534049:534050
@@ -1,6 +1,6 @@
 kde4_header()
 macro_optional_find_package(PythonLibs)
-
+macro_optional_find_package(RUBY)
 include_directories( ${KOFFICECORE_INCLUDES} )
 
 set (CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}  ${KDE4_ENABLE_EXCEPTIONS})
@@ -14,10 +14,14 @@
add_subdirectory(python)
 endif(PYTHON_INCLUDE_PATH) 
 
-message(STATUS ${CMAKE_CURRENT_SOURCE_DIR}: skipped subdir $(RUBYSUBDIR))
+# Laurent: perhaps add new search info
+if(RUBY_INCLUDE_PATH)
+   add_subdirectory(ruby)
+endif(RUBY_INCLUDE_PATH)
 
 
 
+
 ### install files ###
 
 
--- trunk/koffice/libs/kross/ruby/CMakeLists.txt #534049:534050
@@ -1,6 +1,6 @@
 kde4_header()
 
-include_directories( ${CMAKE_SOURCE_DIR}/lib/kross ${KDE4_INCLUDES} )
+include_directories( ${RUBY_INCLUDE_PATH} ${CMAKE_SOURCE_DIR}/lib/kross 
${KDE4_INCLUDES} )
 
 
 ### next target ###
@@ -17,7 +17,7 @@
 
 kde4_install_libtool_file( ${PLUGIN_INSTALL_DIR} krossruby )
 
-target_link_libraries(krossruby  ${KDE4_KDECORE_LIBS} krossapi krossmain )
+target_link_libraries(krossruby  ${KDE4_KDECORE_LIBS} ${RUBY_LIBRARY} krossapi 
krossmain )
 
 install_targets(${PLUGIN_INSTALL_DIR} krossruby )
 
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: [PATCH] makekdewidgets macro

[Laurent Montel]

On Saturday 15 April 2006 11:33, Volker Krause wrote:
 Hi,

 the attached patch contains a cmake macro for the makekdewidgets code
 generation tool. Currently there are cutsom commands in at least three
 diffrent places (libs, pim, edu) to handle this.

 Ok to commit?

For me your patch seems ok.
For me ok for commit it into kdelibs/kdelibs4-snapshot

Regards

 regards
 Volker
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: New cmake tarball needed

[Laurent Montel]

On Tuesday 28 March 2006 10:23, David Faure wrote:
 On Monday 27 March 2006 21:26, Alexander Neundorf wrote:
  We should only use features of the latest released cmake I think (which
  is 2.3.4 right now), in order to avoid too frequent cmake updates.

 Yes, this is exactly why I had to disable srcdir==builddir, since the
 latest released cmake breaks in that case.

It's necessary to release a stable version.
I found that cmake from cvs doesn't search lib in good directory.
   find_library(KDE4_KDECORE_LIBRARY NAMES kdecore PATHS 
${KDE4_LIB_INSTALL_DIR} )

doesn't work
it searchs just on system and not with argument PATHS
= cmake from cvs fix problem with builddir!=srcdir but brokes find_library :(
(cvs from yesterday 2006-03-27)

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Problems with path search order

[Laurent Montel]

On Monday 27 March 2006 23:44, Albert Astals Cid wrote:
 Hi, the attached patch fixes problems i had with cmake not searching my
 correct libkdecore.so, (it found kde3 libkdecore on /usr/lib64) i think the
 patch is correct, because if you have kdelibs outside what
 KDE4_LIB_INSTALL_DIR says you are in deep trouble.

it's a cmake bugs
I think that you use cmake from cvs.
When I revert to 2006-03-17 it works fine
= patch not necessary (for the moment)

 As a suggestion i think it could be good improving cmake so that it is able
 of using the suggested path as first path and then the other paths in the
 order mentioned on the man page, i see not sense in letting the program
 provide a path to look for but it beign the least significant path.

 Albert

 P.S: The patch is against kdelibs4_snapshtot
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Where there is a faq about regex into cmake ?

[Laurent Montel]

Hi,
regexp into cmake is not standard.
Where can I read doc about it ?

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Need help about forcing dependancy

[Laurent Montel]

Hi,
I have this code:
set(COMBINEDHEADERSICAL
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalversion.h
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icaltime.h
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalduration.h
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalperiod.h
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalenums.h
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icaltypes.h
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalrecur.h
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalattach.h
   ${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalderivedvalue.h
...
}

icalderivedvalue.h is a generated file generated by a custom command
add_custom_command(OUTPUT 
${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalderivedvalue.h COMMAND 
${PERL_EXECUTABLE} ARGS -I${ICALSCRIPTS} ${ICALSCRIPTS}/mkderivedvalues.pl -i 
${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalderivedvalue.h.in -h 
${CMAKE_SOURCE_DIR}/libkcal/libical/design-data/value-types.csv  
${CMAKE_SOURCE_DIR}/libkcal/libical/src/libical/icalderivedvalue.h   DEPENDS  
${VALUEDEPS} )

(this macro works fine it's not a problem)

But I am a macro which will create a ical.h file

macro(CREATE_ICAL_FILE _out_FILE)
FILE(WRITE ${_out_FILE} #ifdef __cplusplus\n)
FILE(APPEND ${_out_FILE} extern \C\ {\n)
FILE(APPEND ${_out_FILE} #endif\n)
FILE(APPEND ${_out_FILE} /*\n)
FILE(APPEND ${_out_FILE}  $$''Id''$$\n)
FILE(APPEND ${_out_FILE} */\n)

foreach (_current_FILE ${COMBINEDHEADERSICAL})
FILE(READ ${_current_FILE} _contents)
STRING(REGEX REPLACE #include.*\ical  _contents ${_contents} )
STRING(REGEX REPLACE #include.*\config  _contents 
${_contents} )
STRING(REGEX REPLACE #include.*\pvl.h\  _contents 
${_contents} )
STRING(REGEX REPLACE \$$(Id|Locker): .+\$$  _contents 
${_contents} )
FILE(APPEND ${_out_FILE} ${_contents})
endforeach (_current_FILE ${COMBINEDHEADERSICAL})

FILE(APPEND ${_out_FILE} \n)
FILE(APPEND ${_out_FILE} #ifdef __cplusplus\n)
FILE(APPEND ${_out_FILE} }\n)
FILE(APPEND ${_out_FILE} #endif\n)
endmacro(CREATE_ICAL_FILE)


But cmake doesn't like it.
Because it doesn't know file 
(icalderivedvalue.h is not generated before to go to CREATE_ICAL_FILE macro)

How force to call first custom_command which generate icalderivedvalue.h 
before to go to macro ?

For me I want :
- generate icalderivedvalue.h
- after go to macro

= I don't know how to define a dependancy first custom_command, second 
macro.

Thanks for your help.
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Need help about forcing dependancy

[Laurent Montel]

On Tuesday 21 March 2006 19:00, Alexander Neundorf wrote:


 This must be done differently.
 The command is executed during the build, calling a macro gets executed
 during cmake time, so you can't add a dependency to it.

Ok I understand.

 Instead you probably need an additional custom command, which has as output
 the ical.h file, and which calls cmake with a cmake script file, as it is
 done in KDE4Macros.cmake with kde4uic.cmake.

I will test it.
Thanks a lot.
Regards

 Bye
 Alex
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

how to debug it ?

[Laurent Montel]

Hi,
I am this error:
The end of a CMakeLists file was reached with an IF statement that was not 
closed properly.
Within the directory: kde-4.0/kde4/cmake/snapshot/kdeaccessibility
The arguments are: NOT CMAKE_INSTALL_PREFIX

how to find CMakeLists.txt where there is this error ?

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: how to debug it ?

[Laurent Montel]

On Friday 17 March 2006 16:05, Brad King wrote:
 Laurent Montel wrote:
  Hi,
  I am this error:
  The end of a CMakeLists file was reached with an IF statement that was
  not closed properly.
  Within the directory: kde-4.0/kde4/cmake/snapshot/kdeaccessibility
  The arguments are: NOT CMAKE_INSTALL_PREFIX
 
  how to find CMakeLists.txt where there is this error ?

 If this is happening during installation then this is due to a bug in
 CMake which I fixed last night.  It was just introduced a few days ago
 so this is only the case if you are using a recent CVS cmake.  Just
 update to today's CVS cmake and re-run it on your tree to solve the
 problem.

 Meanwhile I'll look at fixing CMake to report which file has the problem.

Ok thanks.
I will update it.
Do you think to release a new cmake tarball ?

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: cmake news: RPATH, kdevelop projects, finding kdelibs

[Laurent Montel]

On Thursday 16 March 2006 22:30, Alexander Neundorf wrote:
 Hi,

 for everybody who is using cmake to compile kde 4 stuff: please consider
 updating to current cmake cvs.

 What's new:

 I added support for different RPATH handling styles, they are selected by
 setting RPATH_STYLE (either using ccmake or -DRPATH_STYLE=your_choice)
 The options are:

 none - don't use RPATH at all
 When installed, the libs have to be in the system library path
 (ld.so.conf/LD_LIBRARY_PATH)
 To run the executables during the build, simple wrapper shell scripts are
 created which set (DY)LD_LIBRARY_PATH accordingly.

 install - (not on OS X)
 Compile with RPATH set to the installation directory, the kde library
 directory and the Qt library directory.
 To run the executables during the build, simple wrapper shell scripts are
 created which set (DY)LD_LIBRARY_PATH accordingly.

 both - (not on OS X)
 Compile with RPATH set to the build directory, the installation directory,
 the kde library directory and the Qt library directory.
 Executables can simply be run during the build. If both libs, the installed
 and the not-yet-installed ones are available, the not-yet-installed ones
 are prefered. This is probably mostly useful for developers.

 default or everything else:
 Compile with RPATH set to the builddir, link again when installing and set
 RPATH to the install dir, the kde lib dir and the Qt lib dir.

ok

 I couldn't test, but I hope I got things right so it works on OS X too.

 Is there anything I missed ?

 -

 Also in kdebase you can now generate kdevelop project files for all
 subprojects by running cmake with -GKDevelop3

Great good news.
I will look at how to add it to all other kde modules (I will look at it 
tomorrow)

 -

 In kdelibs/CMakeLists.txt there is now a file KDELibsDependencies.cmake
 created, which lists all dependencies of all libs of kdelibs, and the
 install directories of kdelibs. This file gets installed and is included by
 FindKDE4Internal.cmake when compiling stuff!=kdelibs.
 The install dirs are then used as first choice for finding the kde 4 libs,
 headers and executables.
 Laurent: LIB_KPARTS, LIB_KIO etc. should be removed and instead
 KDE4_KPARTS_LIBRARIES, KDE4_KIO_LIBRARIES etc. should be used. I prepared
 these variables already FindKDE4Internal.cmake . Also kparts, kio,
 kdecore etc. should not be used directly in modules different from
 kdelibs/, since then the depending libs might be missing. This is fixed
 by using KDE4_XXX_LIBRARIES(), they contain everything requried.
 The am2cmake script should be changed accordingly.

Ok but we mustn't change it before new kdelibs snapshot.
I will create a script to change it for next snapshot.
For the moment we must keep old variable.

 Bye
 Alex

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: cmake + cpp file + c file + subdir

[Laurent Montel]

On Wednesday 15 March 2006 15:46, Laurent Montel wrote:
 On Wednesday 15 March 2006 15:40, Brad King wrote:
  Laurent Montel wrote:
   Hi,
   I have a problem:
   I have a card.cpp and card.c into subdir
   and cmake said me that it's the same:
   (kdegames/kpat)
   set(libfcs_SRCS
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/alloc.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/app_str.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/caas.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/card.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/cl_chop.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/cmd_line.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/fcs_dm.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/fcs_hash.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/fcs_isa.c
   ${CMAKE_SOURCE_DIR}/kpat/freecell-solver/freecell.c
   ...
   )
  
   set(kpat_SRCS ${libfcs_SRCS}
  main.cpp
  cardmaps.cpp
  card.cpp
  dealer.cpp
  pwidget.cpp
  pile.cpp
  deck.cpp
  pile_algorithms.cpp
  kings.cpp
  freecell.cpp
   ...
   )
   and cmake said me:
   Warning: Source file card.cpp is listed multiple times for target
   kpat. Warning: Source file freecell.cpp is listed multiple times
   for target kpat.
 
  This should be fixed in CVS CMake.  If you are able, please try it to
  make sure it works before we do the next KDE CMake release.

 Where can I get this version ?
 Do you have tarball snapshot ?

I didn't success to rescue cvs 
It's stop in this file
CMake/Utilities/cmzlib/zutil.c
Do you have an idea ?
is it a lock ?
Regards

 Regards

  Thanks,
  -Brad
  ___
  Kde-buildsystem mailing list
  Kde-buildsystem@kde.org
  https://mail.kde.org/mailman/listinfo/kde-buildsystem
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

cmake + configure_file + script perl

[Laurent Montel]

Hi,
I must generate script perl from a configure_file.
I have a lot of script perl where I must specify into some variable
example:
convert.pl.in
into I must change [EMAIL PROTECTED]@
I change it with $src=${KD4_DATADIR}

but as it's perl script I have a lot of $variable
= cmake try to convert it.

do you have an idea to convert it without try to convert other variable ?

Thanks
Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: link to lib which have same name as binary

[Laurent Montel]

On Thursday 09 March 2006 15:18, William A. Hoffman wrote:
 At 02:57 AM 3/9/2006, Laurent Montel wrote:
 Hi,
 I think that there is a bug.
 If we try to link a binary with a lib which have same name (as into
 kdepim/ktnef) it doens't link
 
 Lib name is libktnef.so.0
 et binary is ktnef.
 = we use this line:
 target_link_libraries(ktnef  ${LIB_KDEUI} ktnef )
 (not into same directory)
 
 Do you have an idea to fix it ?
 Could you explain specificaly a path of lib ?

 Two targets can not have the same name.  So you have to call them
 different things.   One ktnef and one ktneflib.  You can then
 use the target property OUTPUT_NAME to give them the same name
 at link time.  This is a restriction from Visual Stuido IDE and Xcode.


 -Bill

Thanks a lot now it works fine.
Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

link to lib which have same name as binary

[Laurent Montel]

Hi,
I think that there is a bug.
If we try to link a binary with a lib which have same name (as into 
kdepim/ktnef) it doens't link

Lib name is libktnef.so.0
et binary is ktnef.
= we use this line:
target_link_libraries(ktnef  ${LIB_KDEUI} ktnef )
(not into same directory)

Do you have an idea to fix it ?
Could you explain specificaly a path of lib ?

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Status of cmake + kde

[Laurent Montel]

Hi,
Today I started to port all kde module (which compile fully) to cmake build 
system (kdetoys/kdepim/kdeedu/kdeaccessibility/kdebase)
(When other module will compile fully I will add cmake build system)

Now we can configure it and start to compile.

For the moment there is some missing check (look at into config.h.cmake and 
ConfigureChecks.cmake)
Some cmake module is missing (for example libmad cmake module etc.)

For the moment I didn't test compile under MacOs or Windows.

Now I need some help to finish all cmake portage.

Regards.
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem