Review Request: Start D-Bus after setting KDE_FULL_SESSION
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102194/ --- Review request for kdelibs, Kevin Kofler, George Kiagiadakis, and David Faure. Summary --- As described in bug 267770. Luckily, there is no KDE-specific initialization between D-Bus launch and setting KDE_FULL_SESSION, so interchanging them should not affect KDE itself. This addresses bug 267770. http://bugs.kde.org/show_bug.cgi?id=267770 Diffs - startkde.cmake 92c8753 Diff: http://git.reviewboard.kde.org/r/102194/diff Testing --- I don't know D-Bus activated apps, I assume I don't have any, so I did not see any difference in startup. Thanks, Christoph
Review Request: Remove monthly auto backups from the GUI
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102195/ --- Review request for KDE Runtime and Sebastian Trueg. Summary --- Monthly auto backup was removed in 4.6 with http://websvn.kde.org/?view=revisionrevision=1215783 with this log: Removed monthly auto backups in 4.6. It was missing the date configuration and does not seem to be implemented in the service anyway. But the option ist still in the GUI of master/4.7, but same situation with the code than in 4.6 - missing date configuration + not implemented in the service. This addresses bug 263530. http://bugs.kde.org/show_bug.cgi?id=263530 Diffs - nepomuk/kcm/nepomukserverkcm.cpp b6bc457 Diff: http://git.reviewboard.kde.org/r/102195/diff Testing --- Thanks, Burkhard
Re: Review Request: Generate email for docbook authors
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/#review5349 --- This review has been submitted with commit 2534d85a86546fa210d32888f49defb95675a14e by Burkhard Lück to branch KDE/4.7. - Commit On July 12, 2011, 5:59 a.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/ --- (Updated July 12, 2011, 5:59 a.m.) Review request for kdelibs, Tom Albers, Luigi Toscano, and Jack Ostroff. Summary --- Preferred form for authors in kde docbooks is author author.name; author.name.mail; /author, where the entifies are defined in kdelibs/kdoctools/customization/entities/contributor.entities. But using this form does not generated the email in the html output, it is missing see bug 248576, apparently since several years (around 2004). This addresses bug 248576. http://bugs.kde.org/show_bug.cgi?id=248576 Diffs - kdoctools/customization/kde-ttlpg-online.xsl 523648b kdoctools/customization/kde-ttlpg.xsl 78d4792 Diff: http://git.reviewboard.kde.org/r/101921/diff Testing --- Building kdelibs with the patch generates the email address in the html file, tested with kdelibs/doc/sonnet/index.docbook Thanks, Burkhard
Re: Review Request: Generate email for docbook authors
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/#review5350 --- This review has been submitted with commit 6fe43f5c89e9d9cbb7dabc0b33b42b7c5c1e by Burkhard Lück to branch master. - Commit On July 12, 2011, 5:59 a.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/ --- (Updated July 12, 2011, 5:59 a.m.) Review request for kdelibs, Tom Albers, Luigi Toscano, and Jack Ostroff. Summary --- Preferred form for authors in kde docbooks is author author.name; author.name.mail; /author, where the entifies are defined in kdelibs/kdoctools/customization/entities/contributor.entities. But using this form does not generated the email in the html output, it is missing see bug 248576, apparently since several years (around 2004). This addresses bug 248576. http://bugs.kde.org/show_bug.cgi?id=248576 Diffs - kdoctools/customization/kde-ttlpg-online.xsl 523648b kdoctools/customization/kde-ttlpg.xsl 78d4792 Diff: http://git.reviewboard.kde.org/r/101921/diff Testing --- Building kdelibs with the patch generates the email address in the html file, tested with kdelibs/doc/sonnet/index.docbook Thanks, Burkhard
Re: Review Request: Resize KMessageBox::detailedError at start to display all text
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101931/#review5352 --- This review has been submitted with commit 370d3ed6e5153fc61b774cf2640acc72d334033d by Burkhard Lück to branch master. - Commit On July 12, 2011, 4:01 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101931/ --- (Updated July 12, 2011, 4:01 p.m.) Review request for kdelibs and Darío Andrés Rodríguez. Summary --- Quoting the BR: When using KMessageBox::detailedError() it sometimes doesn't resize properly to show all the text See kgpg error dialog without kdelibs patch. The text your keyringxx is cut off. Pressing Details button (kgpg error dialog without kdelibs patch after clicking details) resizes the dialog properly and all text is visible. Last screenshot (kgpg error dialog with kdelibs patch) shows the dialog after the start and before clicking the Deatils button, everything is properly readable. I commit this review request on behalf of Dario Andres (https://bugs.kde.org/show_bug.cgi?id=193097#c9) This addresses bug 193097. http://bugs.kde.org/show_bug.cgi?id=193097 Diffs - kdeui/dialogs/kdialog.cpp 32f5df0 Diff: http://git.reviewboard.kde.org/r/101931/diff Testing --- Tested with kgpg error dialog, see third screenshot. Screenshots --- kgpg error dialog without kdelibs patch http://git.reviewboard.kde.org/r/101931/s/200/ kgpg error dialog without kdelibs patch after clicking details http://git.reviewboard.kde.org/r/101931/s/201/ kgpg error dialog with kdelibs patch http://git.reviewboard.kde.org/r/101931/s/203/ Thanks, Burkhard
Re: KF5 Qt5 - QtCS Session
On Thursday 28 Jul 2011 15:25:38 Laszlo Papp wrote: ... * KJob - Qt-Addon for 5.1 Is the lack of manpower the reason or something else it is not planned against 5.0 ? I have made some simple modifications in our project where it is now KDE dependency free. Partly manpower, but mainly that we don't think we need any Binary or Source Incompatible changes made to Qt itself to allow us to do this as a Qt-Addon, so it is simply a lower priority than the Binary/Source incompatible work we need to do in Qt itself. There have been many times that I have experience the need for archiving operations inside Qt framework, in various pure Qt projects. Yes, that's one I missed from the list, it is on the plan to make KArchive a Qt-Addon as well. Both KJob and KArchive are prime examples of what we want to achieve with the KF5 restructure. I am not sure about the legal part of kde codebase reuse, but let me know if there is anything i can do to help. From the legal side, both these will be KDE hosted Qt-Addons and will not being going tnto Qt itself, so nothing changes. You are free to use the existing code as a base for the new libraries. Will you be at the Desktop Summit? If so come to the Qt5 BoF to discuss it. I know there are people with ideas on how those libs need changing that can help with direction. Cheers! John.
Re: Review Request: Start D-Bus after setting KDE_FULL_SESSION
On Aug. 3, 2011, 6:19 p.m., Oswald Buddenhagen wrote: this sounds wrong. what if dbus is started earlier, e.g. by a PAM module? this can easily happen once we use the new SecretService. there should be some interface to push environment variables into the bus after it is running. maybe it would be ok to read a file with VAR=value assignments (one per line, no quoting whatsoever - printenv output) from a defined per-session location before activating services. I guess a D-Bus enabled app could actually check the workspace it is running on instead of falling back to the detect by environment variable hack. E.g. by checking if Plasma Desktop's name is registered or ksmserver is the session server, etc. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102194/#review5362 --- On Aug. 3, 2011, 12:15 p.m., Christoph Feck wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102194/ --- (Updated Aug. 3, 2011, 12:15 p.m.) Review request for kdelibs, Kevin Kofler, George Kiagiadakis, and David Faure. Summary --- As described in bug 267770. Luckily, there is no KDE-specific initialization between D-Bus launch and setting KDE_FULL_SESSION, so interchanging them should not affect KDE itself. This addresses bug 267770. http://bugs.kde.org/show_bug.cgi?id=267770 Diffs - startkde.cmake 92c8753 Diff: http://git.reviewboard.kde.org/r/102194/diff Testing --- I don't know D-Bus activated apps, I assume I don't have any, so I did not see any difference in startup. Thanks, Christoph
Re: Review Request: Do not terminate threads
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5369 --- I do not like this patch for the very reason you stated. I do not want the mutex there either because it is rather expensive. As it stands we start a thread for each lookup right now which in of itself is already too expensive for my taste. Hence, I will have to think of some other way to avoid the even worse solution of creating a local even loop. Having said that, are you using a slow DNS server ? The only way the lookup thread gets terminated is if your nameserver takes longer than 1000 ms per query. That is because the two KUriFilterPlugins that use it set a timeout value of that duration. Otherwise, that code path should not be encountered at all! - Dawit On Aug. 2, 2011, 11:30 a.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/ --- (Updated Aug. 2, 2011, 11:30 a.m.) Review request for kdelibs and Dawit Alemayehu. Summary --- Each time the terminate code triggers my Konqueror crashes, i'm substituting the terminate for just waiting the thread to finish and we just ignoring it. The code has a race condition in which wait() returns false, then we switch to the thread and m_autoDelete is still not set and thus noone will delete the thread. I can add a mutex if you guys think this is unacceptable. Diffs - kio/kio/hostinfo.cpp fef39fc Diff: http://git.reviewboard.kde.org/r/102179/diff Testing --- When the kDebug() Name look up for hostName failed; if triggers i do not get a crash anymore. Thanks, Albert
