Re: Review Request: make folderview icons translucent if composite is enabled
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/#review13308 --- For the record, I have implemented a 'modified' version of Thomas patch in oxygen (without the clearMask() call that could possibly break things elsewhere), and it just works (without this current patch implemented). See: http://wstaw.org/m/2012/05/03/dnd0.png This is pushed to master. I do not think it requires backporting to KDE 4.8 (As a side note, I have also implemented alpha channel for Window tabbing dnd icons, in oxygen-decoration, to test the above. See: http://wstaw.org/m/2012/05/03/dnd1.png) I believe this review request can therefore be discarder. - Hugo Pereira Da Costa On April 19, 2012, 11:29 p.m., Mathias Stephan Panzenböck wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/ --- (Updated April 19, 2012, 11:29 p.m.) Review request for KDE Base Apps. Description --- This patch makes dragged folderview icons translucent if composite is enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D window, clears any mask on it and sets the Qt::WA_TranslucentBackground attribute. I use it day to day and it works fine. The proper place to fix this would be in Qt, but they wrongfully marked the bug report as invalid, because they think X11 does not support translucent windows: http://bugreports.qt.nokia.com/browse/QTBUG-8519 This addresses bug 256475. http://bugs.kde.org/show_bug.cgi?id=256475 Diffs - plasma/applets/folderview/iconview.h e648ff0 plasma/applets/folderview/iconview.cpp 3186b18 Diff: http://git.reviewboard.kde.org/r/101463/diff/ Testing --- Thanks, Mathias Stephan Panzenböck
Re: Review Request: make folderview icons translucent if composite is enabled
On May 29, 2011, 1:05 p.m., Thomas Lübking wrote:
Not sure wheher it's really worth it (though using ARGB over XShape might
actually bring better performance) but I assume the style (oxygen) can deal
this more efficiently (via polishment) and also globally (not only for the
folderview plasmoid but _all_ Qt icon drags)
Gonna try and send Hugo a patch if it works.
Thomas Lübking wrote:
Yes, is. As trivial as
if (widget-testAttribute(Qt::WA_X11NetWmWindowTypeDND)
FX::compositingActive()) // uses KWindowSystem, FX is bespin
{
widget-setAttribute(Qt::WA_TranslucentBackground);
widget-clearMask();
}
Mathias Stephan Panzenböck wrote:
If you have *a lot* of desktop icons and drag them all, the current code
(using a mask and no ARGB window) makes kwin so slow, that the automatic
desktop effects deactivation kicks in. So I think just for that it is worth
to apply this (or a similar) patch. Also I think using these masked icons are
really ugly. If no ARGB window can be used it would be better to use drag
icons like dolphin does.
I agree with Thomas it would be much less of a hack if it goes in the style.
Will add in there.
(PS: I see other places where I'd love ARGB in DND, namely when moving title
windows around for window tabbing).
- Hugo
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101463/#review3574
---
On April 19, 2012, 11:29 p.m., Mathias Stephan Panzenböck wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101463/
---
(Updated April 19, 2012, 11:29 p.m.)
Review request for KDE Base Apps.
Description
---
This patch makes dragged folderview icons translucent if composite is
enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D
window, clears any mask on it and sets the Qt::WA_TranslucentBackground
attribute. I use it day to day and it works fine.
The proper place to fix this would be in Qt, but they wrongfully marked the
bug report as invalid, because they think X11 does not support translucent
windows:
http://bugreports.qt.nokia.com/browse/QTBUG-8519
This addresses bug 256475.
http://bugs.kde.org/show_bug.cgi?id=256475
Diffs
-
plasma/applets/folderview/iconview.h e648ff0
plasma/applets/folderview/iconview.cpp 3186b18
Diff: http://git.reviewboard.kde.org/r/101463/diff/
Testing
---
Thanks,
Mathias Stephan Panzenböck
Re: [Nepomuk] The Nepomuk Situation
I just noticed that this discussion is no longer cced to kcd. On Thu, May 3, 2012 at 2:47 PM, Christian Mollekopf chrig...@fastmail.fmwrote: On Thu, May 3, 2012, at 02:22 PM, Vishesh Handa wrote: On Thu, May 3, 2012 at 3:09 AM, Christian Mollekopf chrig...@fastmail.fm wrote: On Thursday 03 May 2012 00.32:37 Vishesh Handa wrote: Hey everyone! Hey Vishesh, Hey Christian Glad your tackling this, it's indeed a rather painful situation. So, we need a solution. The first solution - * Remove nepomuk from kdelibs and kde-runtime * Make nepomuk-core a compile time dependency for kdelibs * Including the missing gui code into nepomuk-core The second solution is - * nepomuk-core installs the headers in nepomuk2 * the library already has a different name, so there are no clashes over there * kde-runtime/nepomuk is removed * nepomuk-core is added as a dependency of kde-runtime The problem with the second solution is that all applications using Nepomuk will also need to depend on nepomuk-core. So far the list includes - Dolphin, KDE-pim and Telepathy (kinda) I would suggest to create two repostories. One nepomuk-core containing the dependencies of kdelibs (respectively nepomuks core libraries), and another one nepomuk2 containing the dms and possibly other stuff which depends on kdelibs (and in the future the required parts of kf5). That would give you clean dependencies without copies of code, which I think would be rather ugly (assuming that the missing gui code would be a copy of kdelibs code). I do not think this would be possible. Cause kdelibs requires parts of the new APIS (Datamanagent APIs), for now we have just copied some of the headers, and cpp files and are duplicating stuff. I would really want to avoid fragmenting nepomuk even more. Having 2 repositories with related code is something that we want to avoid. Indeed, if the code is related you don't want to split it. I suppose I don't really understand your two suggestions then. I would just depend on nepomuk-core from kdelibs/kde-runtime (if necessary) and every application that uses nepomuk (if you're using it, depend on it). I don't think you should try to keep applications from depending on stuff they need, because that also gives the option not to depend on it. PS: I can't seem to reasonably answer to your html mails, neither in kmail nor in the webinterface. Cheers, Christian I don't see any problem with applications having to depend on nepomuk libraries when they're using it. In contrary I would welcome repositories which keep dependencies low, as that opens new possibilities, such as using the same libraries in a server environment where you don't want to pull in everything including X11. Cheers, Christian What do you guys think? [1] https://projects.kde.org/projects/kde/kdelibs/nepomuk-core [2] http://trueg.wordpress.com/2011/06/08/nepomuk-2-0-and-the-data- management-service/http://trueg.wordpress.com/2011/06/08/nepomuk-2-0-and-the-data-%0Amanagement-service/ -- Vishesh Handa ___ Nepomuk mailing list nepo...@kde.org https://mail.kde.org/mailman/listinfo/nepomuk -- Vishesh Handa -- Vishesh Handa
Re: [Nepomuk] The Nepomuk Situation
nepomuk-core depends on kdelibs. So kdelibs cannot depend on nepomuk-core. We would have to get rid of those dependencies in kdelibs. But that should not be too hard. On 05/03/2012 11:21 AM, Vishesh Handa wrote: I just noticed that this discussion is no longer cced to kcd. On Thu, May 3, 2012 at 2:47 PM, Christian Mollekopf chrig...@fastmail.fm mailto:chrig...@fastmail.fm wrote: On Thu, May 3, 2012, at 02:22 PM, Vishesh Handa wrote: On Thu, May 3, 2012 at 3:09 AM, Christian Mollekopf chrig...@fastmail.fm mailto:chrig...@fastmail.fm wrote: On Thursday 03 May 2012 00.32:37 Vishesh Handa wrote: Hey everyone! Hey Vishesh, Hey Christian Glad your tackling this, it's indeed a rather painful situation. So, we need a solution. The first solution - * Remove nepomuk from kdelibs and kde-runtime * Make nepomuk-core a compile time dependency for kdelibs * Including the missing gui code into nepomuk-core The second solution is - * nepomuk-core installs the headers in nepomuk2 * the library already has a different name, so there are no clashes over there * kde-runtime/nepomuk is removed * nepomuk-core is added as a dependency of kde-runtime The problem with the second solution is that all applications using Nepomuk will also need to depend on nepomuk-core. So far the list includes - Dolphin, KDE-pim and Telepathy (kinda) I would suggest to create two repostories. One nepomuk-core containing the dependencies of kdelibs (respectively nepomuks core libraries), and another one nepomuk2 containing the dms and possibly other stuff which depends on kdelibs (and in the future the required parts of kf5). That would give you clean dependencies without copies of code, which I think would be rather ugly (assuming that the missing gui code would be a copy of kdelibs code). I do not think this would be possible. Cause kdelibs requires parts of the new APIS (Datamanagent APIs), for now we have just copied some of the headers, and cpp files and are duplicating stuff. I would really want to avoid fragmenting nepomuk even more. Having 2 repositories with related code is something that we want to avoid. Indeed, if the code is related you don't want to split it. I suppose I don't really understand your two suggestions then. I would just depend on nepomuk-core from kdelibs/kde-runtime (if necessary) and every application that uses nepomuk (if you're using it, depend on it). I don't think you should try to keep applications from depending on stuff they need, because that also gives the option not to depend on it. PS: I can't seem to reasonably answer to your html mails, neither in kmail nor in the webinterface. Cheers, Christian I don't see any problem with applications having to depend on nepomuk libraries when they're using it. In contrary I would welcome repositories which keep dependencies low, as that opens new possibilities, such as using the same libraries in a server environment where you don't want to pull in everything including X11. Cheers, Christian What do you guys think? [1] https://projects.kde.org/projects/kde/kdelibs/nepomuk-core [2] http://trueg.wordpress.com/2011/06/08/nepomuk-2-0-and-the-data- management-service/ http://trueg.wordpress.com/2011/06/08/nepomuk-2-0-and-the-data-%0Amanagement-service/ -- Vishesh Handa ___ Nepomuk mailing list nepo...@kde.org mailto:nepo...@kde.org https://mail.kde.org/mailman/listinfo/nepomuk -- Vishesh Handa -- Vishesh Handa ___ Nepomuk mailing list nepo...@kde.org https://mail.kde.org/mailman/listinfo/nepomuk
Re: Review Request: Fix Solid CMake check with Qt 5
On May 2, 2012, 11:43 a.m., Stephen Kelly wrote: Please do not submit this. It is out of date. You are probably using qt5.git which is way out of date. This is not needed anymore. Ok. How do I get a Qt 5 with which I can build kdelibs? Checkout master in every repo? - Alexander --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104820/#review13267 --- On May 1, 2012, 11:28 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104820/ --- (Updated May 1, 2012, 11:28 p.m.) Review request for kdelibs. Description --- Fix CMake configure with Qt 5 DBusTools is required so that qt5_add_dbus_interfaces is available Not sure if this is the preferred way of solving the issue, but it works for me. Diffs - tier1/solid/src/solid/CMakeLists.txt f309a64 Diff: http://git.reviewboard.kde.org/r/104820/diff/ Testing --- Configuring didn't work before, now it does. Thanks, Alexander Richardson
Review Request: Add warning for searching the complete file system
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104826/ --- Review request for KDE Base Apps. Description --- In my company it regularly happens that some non technical person, e.g. a secretary or a marketing guy tries to find a file he or she has no idea where it is placed. When they use kfind to search the complete file system without using locate this pretty much means a DOS attack on our company network with loads of NFS shares etc. Searching the complete filesystem is nearly always wrong but as users are used to it from Search my Computer or other indexed search options they might not realize it. This Patch adds a confirmation dialog if you want to search / or file:/// recursively without using locate warning you that this might take a very long time and is a resource intensive operation Diffs - kfind/kfinddlg.cpp 12b3b7e kfind/kquery.h 39609f3 Diff: http://git.reviewboard.kde.org/r/104826/diff/ Testing --- Compiled, tested with regular paths, as well as / and file:/// Thanks, Andre Heinecke
Re: Review Request: PreviewJob supports webpages
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- (Updated May 3, 2012, 3:20 p.m.) Review request for KDE Runtime and Dawit Alemayehu. Changes --- Implement changes as suggested. Description --- Make htmlcreator thumbnailer plugin support remote URLs Requesting thumbnails for URLs has been added to kdelibs in 4.7. This patch makes the webcreator thumbnailer plugin support remote URLs as well. We've been using a similar webcreator in Plasma Active, with this patch, our use cases would be covered by stock KDE. Diffs (updated) - kioslave/thumbnail/htmlcreator.cpp afbcea2 kioslave/thumbnail/htmlthumbnail.desktop 9cc4e02 Diff: http://git.reviewboard.kde.org/r/104821/diff/ Testing --- Used plugin through Plasma's preview engine for URLs, thumbnails of local html files also still work (tested through Dolphin). I'm getting all-white images sometimes, the check for mainFrame()'s contentSize() mitigates this partly, but it still happens. As that's not a regression for local code, I'd like to get this patch merged. (When the error happens, loadFinished() still returns true, so it isn't caught by the m_loadedOk guard.) If anyone has suggestions how to handle these kinds of silent failures, they would be most welcome :) Screenshots --- previews for bookmarks http://git.reviewboard.kde.org/r/104821/s/554/ Thanks, Sebastian Kügler
Re: Review Request: PreviewJob supports webpages
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/#review13356 --- kioslave/thumbnail/htmlcreator.cpp http://git.reviewboard.kde.org/r/104821/#comment10502 Why make this branch statement compute the negation of the bool value ? Why not simply do: const int t = startTimer((url.isLocalFile()?5000:3)); kioslave/thumbnail/htmlthumbnail.desktop http://git.reviewboard.kde.org/r/104821/#comment10499 Hmm... I doubt you need to explicitly add protocols by name if you also have KIO in this list. You can just use KIO. - Dawit Alemayehu On May 3, 2012, 3:20 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- (Updated May 3, 2012, 3:20 p.m.) Review request for KDE Runtime and Dawit Alemayehu. Description --- Make htmlcreator thumbnailer plugin support remote URLs Requesting thumbnails for URLs has been added to kdelibs in 4.7. This patch makes the webcreator thumbnailer plugin support remote URLs as well. We've been using a similar webcreator in Plasma Active, with this patch, our use cases would be covered by stock KDE. Diffs - kioslave/thumbnail/htmlcreator.cpp afbcea2 kioslave/thumbnail/htmlthumbnail.desktop 9cc4e02 Diff: http://git.reviewboard.kde.org/r/104821/diff/ Testing --- Used plugin through Plasma's preview engine for URLs, thumbnails of local html files also still work (tested through Dolphin). I'm getting all-white images sometimes, the check for mainFrame()'s contentSize() mitigates this partly, but it still happens. As that's not a regression for local code, I'd like to get this patch merged. (When the error happens, loadFinished() still returns true, so it isn't caught by the m_loadedOk guard.) If anyone has suggestions how to handle these kinds of silent failures, they would be most welcome :) Screenshots --- previews for bookmarks http://git.reviewboard.kde.org/r/104821/s/554/ Thanks, Sebastian Kügler
Re: Review Request: PreviewJob supports webpages
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/#review13369 --- Ship it! Looks good to me. - Dawit Alemayehu On May 3, 2012, 4:19 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- (Updated May 3, 2012, 4:19 p.m.) Review request for KDE Runtime and Dawit Alemayehu. Description --- Make htmlcreator thumbnailer plugin support remote URLs Requesting thumbnails for URLs has been added to kdelibs in 4.7. This patch makes the webcreator thumbnailer plugin support remote URLs as well. We've been using a similar webcreator in Plasma Active, with this patch, our use cases would be covered by stock KDE. Diffs - kioslave/thumbnail/htmlcreator.cpp afbcea2 kioslave/thumbnail/htmlthumbnail.desktop 9cc4e02 Diff: http://git.reviewboard.kde.org/r/104821/diff/ Testing --- Used plugin through Plasma's preview engine for URLs, thumbnails of local html files also still work (tested through Dolphin). I'm getting all-white images sometimes, the check for mainFrame()'s contentSize() mitigates this partly, but it still happens. As that's not a regression for local code, I'd like to get this patch merged. (When the error happens, loadFinished() still returns true, so it isn't caught by the m_loadedOk guard.) If anyone has suggestions how to handle these kinds of silent failures, they would be most welcome :) Screenshots --- previews for bookmarks http://git.reviewboard.kde.org/r/104821/s/554/ Thanks, Sebastian Kügler
Re: Review Request: PreviewJob supports webpages
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/#review13375 --- This review has been submitted with commit bb5ef71483caaf1ce9cd2d4aa50a43583531cc1c by Sebastian Kügler to branch master. - Commit Hook On May 3, 2012, 4:19 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- (Updated May 3, 2012, 4:19 p.m.) Review request for KDE Runtime and Dawit Alemayehu. Description --- Make htmlcreator thumbnailer plugin support remote URLs Requesting thumbnails for URLs has been added to kdelibs in 4.7. This patch makes the webcreator thumbnailer plugin support remote URLs as well. We've been using a similar webcreator in Plasma Active, with this patch, our use cases would be covered by stock KDE. Diffs - kioslave/thumbnail/htmlcreator.cpp afbcea2 kioslave/thumbnail/htmlthumbnail.desktop 9cc4e02 Diff: http://git.reviewboard.kde.org/r/104821/diff/ Testing --- Used plugin through Plasma's preview engine for URLs, thumbnails of local html files also still work (tested through Dolphin). I'm getting all-white images sometimes, the check for mainFrame()'s contentSize() mitigates this partly, but it still happens. As that's not a regression for local code, I'd like to get this patch merged. (When the error happens, loadFinished() still returns true, so it isn't caught by the m_loadedOk guard.) If anyone has suggestions how to handle these kinds of silent failures, they would be most welcome :) Screenshots --- previews for bookmarks http://git.reviewboard.kde.org/r/104821/s/554/ Thanks, Sebastian Kügler
Re: Review Request: Add warning for searching the complete file system
On Thursday, May 03, 2012 19:35:00 Mark Gaiser wrote: Let me first say that i have absolutely nothing to say about this. I do have an opinion about this though. I would not like this. If i'm searching i just want to search and certainly don't get a dialog just to confirm my search. Others might think differently though... Perhaps as an option but disabled by default. I agree with Andres stance that searching / is almost never what the user wants. Checking a searchbox is nothing compared to the amount of time a full disk scan can take (and worse: you don't have a progress bar or indication of duration). I think the patch is a good idea. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
