Re: Review Request: Rename Samba Shares to Windows Shares (SMB)

2012-06-21 Thread Lamarque Vieira Souza


> On June 21, 2012, 10:05 p.m., Mark Gaiser wrote:
> > I don't really know if we should do this.. I do understand why you want to 
> > rename it. From a user point of view the user probably wants to either 
> > access windows shares or make shares accessible for windows. Either way, 
> > it's done through Samba which implements the SMB protocol: 
> > http://en.wikipedia.org/wiki/Server_Message_Block so it are actually "SMB 
> > Shares" ;)
> > 
> > Changing it is not really useful i think. I for example make "Samba shares" 
> > between Linux machines as well since that is just easy and why should those 
> > be called "Windows Shares" all of a sudden? I think "Samba Shares" is just 
> > fine. Perhaps "SMB Shares" describes it even better.
> > 
> > I'm not against the change, but also not in favor. Someone else should 
> > decide whether this is OK or not.

I am also against this change, also because Windows is a trademark, so we have 
better avoid using it in KDE. OBS: samba also implements the cifs protocol, the 
sucessor of SMB and the current default protocol used in Win7. So "SMB Shares" 
is also not a good name.


- Lamarque Vieira


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105318/#review14969
---


On June 21, 2012, 3:40 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105318/
> ---
> 
> (Updated June 21, 2012, 3:40 p.m.)
> 
> 
> Review request for KDE Runtime and David Edmundson.
> 
> 
> Description
> ---
> 
> Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)'
> 
> I posted this on the usability mailing list a while a go and David Edmundson 
> CC'd the original author but for now there has been no response.
> http://lists.kde.org/?l=kde-usability&m=133173657001169&w=2
> 
> Since we are past string freeze this is probably for 4.10
> I can not commit this myself, thanks
> 
> 
> This addresses bug 141257.
> http://bugs.kde.org/show_bug.cgi?id=141257
> 
> 
> Diffs
> -
> 
>   kioslave/smb/smb-network.desktop a121a31 
> 
> Diff: http://git.reviewboard.kde.org/r/105318/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>



Hello...

2012-06-21 Thread Michail V.

Hello everyone,

I am developing a plasmoid called Workflow, the project's webpage can be 
found here:

http://opentoolsandspace.org/en/projects/development/plasmoid-workflow

I'd love to have your feedback, as I have a deadline in my head for the 
first version
mid-of September. The pieces are starting to get into place, it's almost 
usable right now
but until now I have faced the following issues, I am developing it in 
KDE 4.8.4 at opensuse


1) I am using the following code to remove an activity:

void ActivityManager::remove(QString id) {
ActivityManager::stop(id);

Plasma::Service *service = plasmaActEngine->serviceForSource(id);
KConfigGroup op = service->operationDescription("remove");
op.writeEntry("Id", id);
Plasma::ServiceJob *job = service->startOperationCall(op);
connect(job, SIGNAL(finished(KJob*)), service, SLOT(deleteLater()));

}

plasmaActEngine is org.kde.activities,
the behavior is that the activity is not removed from the dataengine, 
there is a ghost activity

in the dataengine that doesnt have some fields, name, icon etc...
In order for someone to delete it completely the user must use the 
ActivityManager or make

a logout/login

2) The plasmoid is developed as a PopupApplet in order to be able to be 
placed in a panel,
I have tried many things but I can not restore the plasmoid in its 
previous used size after a logout/login,
the popupapplet changes the DialogWidth,DialogHeight properties 
correctly in the plasmoids settings

but after a logout/login the plasmoid remains in its default size.

3) I have tried to find a way to clone an activity through the plasmoid 
but I did not have any success.
I have seen that the ActivitiesEngine, in plasma/desktop/shell, is using 
class PlasmaApp for most of the
operations and not the dataengine, Is there a way to use PlasmaApp also? 
or in the future cloning an activity

is going to be supported through the dataengine?

Thanks a lot everyone,
Michail


Review Request: Rename Samba Shares to Windows Shares (SMB)

2012-06-21 Thread Maarten De Meyer

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105318/
---

Review request for KDE Runtime and David Edmundson.


Description
---

Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)'

I posted this on the usability mailing list a while a go and David Edmundson 
CC'd the original author but for now there has been no response.
http://lists.kde.org/?l=kde-usability&m=133173657001169&w=2

Since we are past string freeze this is probably for 4.10
I can not commit this myself, thanks


This addresses bug 141257.
http://bugs.kde.org/show_bug.cgi?id=141257


Diffs
-

  kioslave/smb/smb-network.desktop a121a31 

Diff: http://git.reviewboard.kde.org/r/105318/diff/


Testing
---


Thanks,

Maarten De Meyer



Re: Review Request: Rename Samba Shares to Windows Shares (SMB)

2012-06-21 Thread Mark Gaiser

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105318/#review14969
---


I don't really know if we should do this.. I do understand why you want to 
rename it. From a user point of view the user probably wants to either access 
windows shares or make shares accessible for windows. Either way, it's done 
through Samba which implements the SMB protocol: 
http://en.wikipedia.org/wiki/Server_Message_Block so it are actually "SMB 
Shares" ;)

Changing it is not really useful i think. I for example make "Samba shares" 
between Linux machines as well since that is just easy and why should those be 
called "Windows Shares" all of a sudden? I think "Samba Shares" is just fine. 
Perhaps "SMB Shares" describes it even better.

I'm not against the change, but also not in favor. Someone else should decide 
whether this is OK or not.

- Mark Gaiser


On June 21, 2012, 3:40 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105318/
> ---
> 
> (Updated June 21, 2012, 3:40 p.m.)
> 
> 
> Review request for KDE Runtime and David Edmundson.
> 
> 
> Description
> ---
> 
> Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)'
> 
> I posted this on the usability mailing list a while a go and David Edmundson 
> CC'd the original author but for now there has been no response.
> http://lists.kde.org/?l=kde-usability&m=133173657001169&w=2
> 
> Since we are past string freeze this is probably for 4.10
> I can not commit this myself, thanks
> 
> 
> This addresses bug 141257.
> http://bugs.kde.org/show_bug.cgi?id=141257
> 
> 
> Diffs
> -
> 
>   kioslave/smb/smb-network.desktop a121a31 
> 
> Diff: http://git.reviewboard.kde.org/r/105318/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>