Re: Re: kde review kartesio
Yes, Kartesio is used to calculate fitting curves for experimental points: I, as a chemistry student, already used it for some laboratory reports. Actually, there is no other program like this in KDE: obiously you could obtain something similar with RKward, but this one is too much complex for fitting curves, and students usually do not like R. Kartesio does one thing, and does it simply and good. Caculating best fit curves with R is smilar to cross a stream with the Queen Mary.The most interesting feature of Kartesio is that it allows you to write manually the equation you want to use to fit the points (with other programs like LibreOffice Calc it's possible only to use 3 or 4 already implemented and generic functions). For example, I can choose to fit my points with y=a*sin(b*x) or with y=(9.342/x)+c. Luca Tringali Messaggio originale Da: tcanabr...@kde.org Data: 10/05/2013 12.28 A: Anne-Marie Mahfoufannemarie.mahf...@free.fr Cc: LucaTringalitringalinv...@libero.it, kde-core-devel@kde.org Ogg: Re: kde review kartesio Quite Unlikely ... It's a Solver, to fit curves into points, That's very used in any theorical research, engeniering, math, phisics, etc. 2013/5/10 Anne-Marie Mahfouf annemarie.mahf...@free.fr Hi, I am wondering what is the user base for this application as it seems quite specialized (I did not build it yet though). Can you tell us more about the potential target? Another question that comes to mind is: can't it be a feature of an existing KDE Edu apps? Best regards, Anne-Marie - Mail original - De: LucaTringali tringalinv...@libero.it À: kde-core-devel@kde.org Envoyé: Jeudi 9 Mai 2013 18:06:16 Objet: kde review kartesio Hello, I have been working on Kartesio, a program for calculating best fit curves with experimental points. I think it is ready to be moved in the KDE Edu main repo now, so I'm asking your approval. I followed the guidelines ( http://techbase.kde.org/Policies/Application_Lifecycle ) and Kartesio is actually in KDE review: https://projects.kde.org/projects/kdereview/kartesio For any question, ask me. Luca Tringali
R: Re: kde review kartesio
Hello, libzorbaneural can be found here: https://www.gitorious.org/zorbaneural/zorbaneural/trees/master Here are also some packages for the stable version (deb and rpm): https://www.gitorious.org/zorbaneural/zorbaneural/trees/master/binary- packages/libzorbaneural-0.1 Once you have installed it, the build should go fine. The screenshot folder and the .pro file are not needed, if they are a problem I can remove them. Talking about the system call in calculations, this is the reason why actuallt Kartesio works only on GNU/Linux systems. Why I did it? Because it was the easier way to do that. In the next release of Kartesio, this problem will be solved. I'm not very practical with translatable strings, so I excuse for the Message. sh: is there a wiki page to understand how to write a Message.sh file? I'm writing comments on variables in header files, in the next hours I'll publish them into git. Luca Tringali Messaggio originale Da: annemarie.mahf...@free.fr Data: 10/05/2013 13.58 A: LucaTringalitringalinv...@libero.it Cc: kde-core-devel@kde.org Ogg: Re: kde review kartesio Hi, A few primary remarks: - libzorbaneural is needed but my distro does not have anything with neural in it (OpenSuse 12.3) what repo do I need to add in order to get it? The libzorbaneural website should be added to the cmake file so people can find this and packagers can add it to their distros. - I see a screenshot folder and some .pro files that probably are not needed - some doxygen comments for the variables in the .h files would be appreciated, if anyone else wants to fix bugs it'll help a lot. - Kartesio does not build for me, I get /home/kde- devel/kartesio/src/calculations.cpp:278:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: some warnings being treated as errors - I don't see a Messages.sh file to extract translatable strings. - I am not comfortable with the rm call line 181 in calculations.cpp = you can probably use more Qt classes here and in other parts of this file too. That's only a quick review as I couldn't run the app yet. Tomaz, as for the user base maybe we could start a module for advanced scientific tools? Best regards, Anne-Marie - Mail original - De: Tomaz Canabrava tcanabr...@kde.org À: Anne-Marie Mahfouf annemarie.mahf...@free.fr Cc: LucaTringali tringalinv...@libero.it, kde-core-devel@kde.org Envoyé: Vendredi 10 Mai 2013 12:28:54 Objet: Re: kde review kartesio Quite Unlikely ... It's a Solver, to fit curves into points, That's very used in any theorical research, engeniering, math, phisics, etc. 2013/5/10 Anne-Marie Mahfouf annemarie.mahf...@free.fr Hi, I am wondering what is the user base for this application as it seems quite specialized (I did not build it yet though). Can you tell us more about the potential target? Another question that comes to mind is: can't it be a feature of an existing KDE Edu apps? Best regards, Anne-Marie - Mail original - De: LucaTringali tringalinv...@libero.it À: kde-core-devel@kde.org Envoyé: Jeudi 9 Mai 2013 18:06:16 Objet: kde review kartesio Hello, I have been working on Kartesio, a program for calculating best fit curves with experimental points. I think it is ready to be moved in the KDE Edu main repo now, so I'm asking your approval. I followed the guidelines ( http://techbase.kde.org/Policies/Application_Lifecycle ) and Kartesio is actually in KDE review: https://projects.kde.org/projects/kdereview/kartesio For any question, ask me. Luca Tringali
Re: Re: kde review kartesio
Hi,
I'll answer point to point:
Messaggio originale
Hey!
A good thing, I think such a tool could be useful to me too (and I
know a lot of other people to whom it might be useful). Here's what I
noticed from a quick look (some has been said already I think):
* You probably shouldn't track the kdev4 file in the repository, same
goes for screenshots
Yes, those files are there just because I found them useful, but I can remove
them without any problem.
* zorbaneural is a very fancy dependency, it's not even in arch's AUR.
You should put the git URL into the cmake message.
I know, I wrote where to find it in Kartesio project overview but, since
almost everybody had some troubles with it, I will make this thing more clear.
* I put x**2 into the fit box and clicked Fit, and it crashed:
http://paste.kde.org/741026/
Yes, the correct way to express a power is ^. So you should write x^2. There
should be a check routine to avoid that a dangerous string like ** is used,
and I'm surely integrating this check in the next release.
* Did you think about laying out the UI around a splitter? On my
screen, the table takes most of the area and the plot is quite small,
and I can't change that...
This could be a good idea: another thing for the next release.
* It would be useful to be able to import data in some way, e.g. from
a CSV file. I don't see a way to get data into the program except
typing every number into the cells -- or is there another way? If
there is, could it be made more obvious eventually?
Actually there is not: I'm working on a new window for the next releases:
basically, there will be a button over the table, something like Edit datas.
This will open a new window in which it will be possible to import/export CSV,
sort X axis values, add other rows or deleting some...
* What does the code in calculations.cpp:117 do? It looks quite
curious. Isn't there a more elegant solution (it looks a bit like a
QChar::isLetter() implementation)?
* calculations.cpp:505 and 584 the same code like in 117 again? It's
weird enough to have that stuff once, but copied multiple times is bad
imho ;)
No, at least not only. Originally, line 117 and 118 were collapsed into one
single if instruction, it slip it in two because it was too long. This line
checks if the current char (which is a C++ char an not a QChar) is permitted or
not. Permitted characters ar letters, numbers, and some other simbols (for
example +, (, etc..).
Could this instruction be shorter and more elagant? Probably. But it works,
and actually I think it could stay as it is.
* Your code uses mixed tab- and space indent (sometimes it uses tabs,
sometimes spaces for no apparent reason). Most KDE apps use only
spaces, you might consider if you want to do that too. Sometimes, the
indent is even missing completely; you should indent one level after
each opening curly parenthesis.
* Same goes for the whole formatting of the code, it's pretty
inconsistent. For example, look at the spaces around operators or so.
I know it, I'll try to make the code more readable, but I do not have so much
time so usually I prefer to dedicate my time to new features or corrections
instead of making them prettier.
* Instead of writing to /tmp/kartesiotmp.txt you should probably use
QTempFile. That will also take care of the deleting the temp file when
it gets deallocated so you don't need to exec (scary and
platform-dependent) rm commands.
I'm already working with QTempFile for the next release of Kartesio.
* calculations.cpp:277 this makes no sense, there's a statement behind
a return
Ooops: I thought I already removed it.
In general, you're mixing a lot of plain C / stdlib stuff into Qt
code. Is there a reason for that? For example, in calculations.cpp:148
you take text from a text field, convert it to a byte array, convert
it to a char* and then pass it to a function. Why not just pass the
QString? You can iterate over a QString like
foreach ( const QChar c, myqstring ) { ... }
or also
for ( int i = 0; i myqstring.size(); i++ ) { ... }
if you like that better, and you can also index it like a char*, as in
mystring[i+1] or so.
Yes, this is an heritage from the older version of Kartesio, that was based
mainly on plain ANSI C++. Those mixing are just an hack to make Kartesio work
immediately. If I'll have time, I will translate everything into Qt, but
first of all I would like to apply other features.
Also, nothing in your code is const and everything is public, although
almost everything could be const and private, but I won't get started
on that now ;)
This is not meant as a list of what you must fix, it's just my two cents.
Thank you, it's always nice to get some suggestions.
Cheers!
Sven
2013/5/10 Tomaz Canabrava tcanabr...@kde.org:
Annma, I find that proposal *very* good.
I'm a bit distant of KDE programming - I know - because my day job is
making
me work 12h+ creating scientific tools.
( actually - one of the tools that I
Re: R: Re: kde review kartesio
Hi, Hi, actually I have not prepared any binary package. Anyway, you can install Kartesio downloading the source code from the git repo (https://projects.kde. org/projects/kdereview/kartesio), installing the library libzorbaneural (https: //www.gitorious.org/zorbaneural/zorbaneural/trees/master/binary- packages/libzorbaneural-0.1), and running the build.sh script you find in the Kartesio root folder. Why is this build.sh script needed? Is it because I did not run it that I got my build error? Also, you should have installed the program maxima (just the program, dev libraries are not needed) to have Kartesio fully working. If there are some troubles in building Kartesio, just ask me. I have this error: /home/kde-devel/kartesio/src/calculations.cpp:278:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: some warnings being treated as errors Best regards, Anne-Marie
R: Re: kde review kartesio
Hello everybody, just wanted to tell you that I made some fixes to the code, based on your suggestions: *comments in header files *deleted some unseful string *check routine to avoid that a dangerous string like ** or similar is used for the function *add where to download zorbaneural in cmake module *in neural network algortihm, check if all the points are between 0 and 1 *check if the maxima report is empty before showing it *added file messages.sh I also cleaned it up a little, to make it more readable. Luca Tringali Messaggio originale Da: tringalinv...@libero.it Data: 10/05/2013 14.18 A: kde-core-devel@kde.org, annemarie.mahf...@free.fr Ogg: R: Re: kde review kartesio Hello, libzorbaneural can be found here: https://www.gitorious.org/zorbaneural/zorbaneural/trees/master Here are also some packages for the stable version (deb and rpm): https://www.gitorious.org/zorbaneural/zorbaneural/trees/master/binary- packages/libzorbaneural-0.1 Once you have installed it, the build should go fine. The screenshot folder and the .pro file are not needed, if they are a problem I can remove them. Talking about the system call in calculations, this is the reason why actuallt Kartesio works only on GNU/Linux systems. Why I did it? Because it was the easier way to do that. In the next release of Kartesio, this problem will be solved. I'm not very practical with translatable strings, so I excuse for the Message. sh: is there a wiki page to understand how to write a Message.sh file? I'm writing comments on variables in header files, in the next hours I'll publish them into git. Luca Tringali Messaggio originale Da: annemarie.mahf...@free.fr Data: 10/05/2013 13.58 A: LucaTringalitringalinv...@libero.it Cc: kde-core-devel@kde.org Ogg: Re: kde review kartesio Hi, A few primary remarks: - libzorbaneural is needed but my distro does not have anything with neural in it (OpenSuse 12.3) what repo do I need to add in order to get it? The libzorbaneural website should be added to the cmake file so people can find this and packagers can add it to their distros. - I see a screenshot folder and some .pro files that probably are not needed - some doxygen comments for the variables in the .h files would be appreciated, if anyone else wants to fix bugs it'll help a lot. - Kartesio does not build for me, I get /home/kde- devel/kartesio/src/calculations.cpp:278:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: some warnings being treated as errors - I don't see a Messages.sh file to extract translatable strings. - I am not comfortable with the rm call line 181 in calculations.cpp = you can probably use more Qt classes here and in other parts of this file too. That's only a quick review as I couldn't run the app yet. Tomaz, as for the user base maybe we could start a module for advanced scientific tools? Best regards, Anne-Marie - Mail original - De: Tomaz Canabrava tcanabr...@kde.org À: Anne-Marie Mahfouf annemarie.mahf...@free.fr Cc: LucaTringali tringalinv...@libero.it, kde-core-devel@kde.org Envoyé: Vendredi 10 Mai 2013 12:28:54 Objet: Re: kde review kartesio Quite Unlikely ... It's a Solver, to fit curves into points, That's very used in any theorical research, engeniering, math, phisics, etc. 2013/5/10 Anne-Marie Mahfouf annemarie.mahf...@free.fr Hi, I am wondering what is the user base for this application as it seems quite specialized (I did not build it yet though). Can you tell us more about the potential target? Another question that comes to mind is: can't it be a feature of an existing KDE Edu apps? Best regards, Anne-Marie - Mail original - De: LucaTringali tringalinv...@libero.it À: kde-core-devel@kde.org Envoyé: Jeudi 9 Mai 2013 18:06:16 Objet: kde review kartesio Hello, I have been working on Kartesio, a program for calculating best fit curves with experimental points. I think it is ready to be moved in the KDE Edu main repo now, so I'm asking your approval. I followed the guidelines ( http://techbase.kde.org/Policies/Application_Lifecycle ) and Kartesio is actually in KDE review: https://projects.kde.org/projects/kdereview/kartesio For any question, ask me. Luca Tringali
Re: kde review kartesio
Hi,
In general, you're mixing a lot of plain C / stdlib stuff into Qt
code. Is there a reason for that? For example, in
calculations.cpp:148
you take text from a text field, convert it to a byte array, convert
it to a char* and then pass it to a function. Why not just pass the
QString? You can iterate over a QString like
foreach ( const QChar c, myqstring ) { ... }
or also
for ( int i = 0; i myqstring.size(); i++ ) { ... }
if you like that better, and you can also index it like a char*, as
in
mystring[i+1] or so.
Yes, this is an heritage from the older version of Kartesio, that was
based
mainly on plain ANSI C++. Those mixing are just an hack to make
Kartesio work
immediately. If I'll have time, I will translate everything into
Qt, but
first of all I would like to apply other features.
You asked for an inclusion in KDE and we are reviewing Kartesio. There is
already a big amount of work to be done from the comments you got. I don't
think adding features now is a smart move, review is a phase where your program
should reach KDE standards. Using Qt libs wherever possible is the priority and
getting all the required fixes will make you busy enough.
Best regards,
Anne-Marie
Re: R: Re: R: Re: kde review kartesio
Hi, so I don't have to type all those every time I want to build Kartesio again. I'm not sure why you get that error, mainlybecause I don't know which is the instruction that gives that problem since I changed a lot the code in these hours. Try to download the latest git version and build it, so I will know exactly where the problem is. commenting out line 465 in calculations.cpp makes it build (the line after the return). Anne-Marie
Review Request 110388: Change default thumbnail cache directory
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110388/ --- Review request for kdelibs. Description --- The freedesktop spec[0] has changed the default location of the thumbnail cache directory. Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of ~/.thumbnails/ GNOME has already made this change. Some applications[1] and documentation[2] (maybe thumbnailers) will have to be changed to adapt to this new directory. If this patch is accepted I'll make the needed changes. For frameworks we can use QStandardPaths::CacheLocation, I'll post a separate review for that. All thumbnails will have to be regenerated. We could symlink the directory? Is fromLocal8Bit correct or is UTF8 needed now? [0] http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html [1] configurepreviewdialog.cpp in Dolphin [2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails This addresses bug 319528. http://bugs.kde.org/show_bug.cgi?id=319528 Diffs - kio/kio/previewjob.cpp 01b674d Diff: http://git.reviewboard.kde.org/r/110388/diff/ Testing --- Remove ~/.thumbnails/ Run dolphin with previews: thumbnails are created in .cache/thumbnails/ Repeated with XDG_CACHE_HOME=~/.cachetestdir/ Thumbnails in .cachetestdir/thumbnails/ Not tested: gwenview and digikam. Thanks, Maarten De Meyer
Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- Review request for KDE Runtime. Description --- This patch fixes a problem in Phonon KCM which is always set as changed when using PulseAudio. I made two changes. The first change is renaming of ready() signal from AudioSetup class to pulseAudioReady() which is connected to slot in KCM which sets PulseAudio to enabled in Phonon::DevicePreference. The second change is a new signal emitted when GUI is initialized and only when pulseAudioReady() signal was emitted before. This signal is connected to slot in KCM which inserts this widget to KCM and connects changed() signal to KCM changed() slot. Diffs - phonon/kcm/audiosetup.h 4887efe phonon/kcm/audiosetup.cpp 35dc4ca phonon/kcm/main.h 277adfe phonon/kcm/main.cpp 5d75cba Diff: http://git.reviewboard.kde.org/r/110390/diff/ Testing --- Thanks, Jan Grulich
Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)
Hi,
tl;dr how to avoid crashes if libQtUiTools.a is linked multiple times into a
process?
You use at least one of kross, kjsembed, or plasma in your
application/lib/module and possibly also directly libQtUiTools yourself?
Then bugs.kde.org shows that chances are that you have seen crashes with this
in the backtrace:
#6 0xb5320313 in
QFormInternal::domPropertyToVariant(QFormInternal::QAbstractFormBuilder*,
QMetaObject const*, QFormInternal::DomProperty const*) () from XXX
where XXX could be libplasma, libkjsembed, krossmoduleforms or your own
binary/lib/module.
For historic reasons libQtUiTools is a static lib, not a shared, and there has
been no work to change that, compare
https://bugreports.qt-project.org/browse/QTBUG-437
A few days ago I looked into Kross scripts in Calligra the first time, only to
ran into this problem, as reported to my distri here:
https://bugzilla.novell.com/show_bug.cgi?id=819437
As can be read in that report, I saw in my backtrace that QFormInternal
methods are once called in krossmoduleforms.so, once in libkjsembed.so.4 in
the very same call stack, while they surely should be only done in a single
place. And Hrvoje Senjan found that linking libQtUiTools.a into the own code
without Bsymbolic-functions flag seems to avoid the crashes.
So, anyone with more clue than me WRT symbols from static libs and the
Bsymbolic-functions linker flag who could tell if that indeed should fix such
problems if code from the same static lib is arriving multiple times in the
same process via different libs/modules?
If so, should all the places where ${QT_QTUITOOLS_LIBRARY} is linked in
kdelibs and elsewhere get a blocker to the Bsymbolic-functions flag?
How would that be done, to force this flag to be unset?
What about other non-GCC platforms/compilers, is there a similar problem?
Cheers
Friedrich
Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- (Updated May 11, 2013, 7:47 p.m.) Review request for KDE Runtime and Casian Andrei. Description --- This patch fixes a problem in Phonon KCM which is always set as changed when using PulseAudio. I made two changes. The first change is renaming of ready() signal from AudioSetup class to pulseAudioReady() which is connected to slot in KCM which sets PulseAudio to enabled in Phonon::DevicePreference. The second change is a new signal emitted when GUI is initialized and only when pulseAudioReady() signal was emitted before. This signal is connected to slot in KCM which inserts this widget to KCM and connects changed() signal to KCM changed() slot. Diffs - phonon/kcm/audiosetup.h 4887efe phonon/kcm/audiosetup.cpp 35dc4ca phonon/kcm/main.h 277adfe phonon/kcm/main.cpp 5d75cba Diff: http://git.reviewboard.kde.org/r/110390/diff/ Testing --- Thanks, Jan Grulich
Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- (Updated May 11, 2013, 8:05 p.m.) Review request for KDE Runtime and Casian Andrei. Description (updated) --- This patch fixes a problem in Phonon KCM which is always set as changed when using PulseAudio. Previous solution emits ready() signal when some parts of AudioSetup are not initialized yet. And changed() signal is connected to soon so that's the reason why this KCM is always set as changed. Diffs (updated) - phonon/kcm/audiosetup.cpp 35dc4ca phonon/kcm/main.cpp 5d75cba Diff: http://git.reviewboard.kde.org/r/110390/diff/ Testing --- Thanks, Jan Grulich
Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)
On 2013-05-11, Friedrich W. H. Kossebau kosse...@kde.org wrote: So, anyone with more clue than me WRT symbols from static libs and the Bsymbolic-functions linker flag who could tell if that indeed should fix such problems if code from the same static lib is arriving multiple times in the same process via different libs/modules? It most likely will help on such a case. -Bsymbolic-functions ensures that functiotns are first resolved in the library/plugin itself before resolving it from outside the library. What happens, I think, is that it is sometimes using the functions from one of the static libs, other times from some of the other. I'm not sure we want libraries linking QtTools to be built with -Bsymbolic-functions because it breaks debugging and other magic using function overriding with LD_PRELOAD tricks, because they rely on being chosen first over the 'internal' functions. /Sune
Review Request 110392: Do not overwrite directories inside a tar archive
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/ --- Review request for kdelibs and David Faure. Description --- The attached patch fixes KTar so that the contents of a sample archive: d/ d/f1.txt d/ d/f2.txt are shown correctly as d/f1.txt d/f2.txt instead of d/f2.txt See the bug report for details on what kind of archives are not shown correctly in Konqueror vs Ark. This addresses bug 206994. http://bugs.kde.org/show_bug.cgi?id=206994 Diffs - kdecore/io/ktar.cpp 142a80a Diff: http://git.reviewboard.kde.org/r/110392/diff/ Testing --- Thanks, Dawit Alemayehu
Re: Review Request 110392: Do not overwrite directories inside a tar archive
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/#review32362 --- Ship it! Looks good, please commit. I just wrote a unittest for it, which I'll commit next. - David Faure On May 11, 2013, 8:43 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/ --- (Updated May 11, 2013, 8:43 p.m.) Review request for kdelibs and David Faure. Description --- The attached patch fixes KTar so that the contents of a sample archive: d/ d/f1.txt d/ d/f2.txt are shown correctly as d/f1.txt d/f2.txt instead of d/f2.txt See the bug report for details on what kind of archives are not shown correctly in Konqueror vs Ark. This addresses bug 206994. http://bugs.kde.org/show_bug.cgi?id=206994 Diffs - kdecore/io/ktar.cpp 142a80a Diff: http://git.reviewboard.kde.org/r/110392/diff/ Testing --- Thanks, Dawit Alemayehu
Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110271/ --- (Updated May 11, 2013, 9:14 p.m.) Review request for kde-workspace. Changes --- Update FindLibUSB-1.cmake Description --- Use libusb-1 to query info about usb devices in kinfocenter. Remove *BSD specific code: it doesn't work on all supported FreeBSD versions. In principle it can be saved for NetBSD, but NetBSD could use libusb-1, thus drop it for simplification. Remove polling and use DeviceNotifier instead. Add FindLibUSB-1.cmake Diffs (updated) - cmake/modules/FindLibUSB-1.cmake PRE-CREATION kinfocenter/Modules/usbview/CMakeLists.txt 87bb256 kinfocenter/Modules/usbview/config-kcmusb.h.cmake PRE-CREATION kinfocenter/Modules/usbview/kcmusb.cpp c598467 kinfocenter/Modules/usbview/usbdevices.h 493caeb kinfocenter/Modules/usbview/usbdevices.cpp 9bd7033 Diff: http://git.reviewboard.kde.org/r/110271/diff/ Testing --- I've tested it only on FreeBSD. It would nice to test at least FindLibUSB-1.cmake on other OSes. Thanks, Max Brazhnikov
Re: Review Request 110392: Do not overwrite directories inside a tar archive
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/#review32367 --- This review has been submitted with commit fa9fa9ce0271e44117a70f03af58aa1963ba5df5 by Dawit Alemayehu to branch KDE/4.10. - Commit Hook On May 11, 2013, 8:43 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/ --- (Updated May 11, 2013, 8:43 p.m.) Review request for kdelibs and David Faure. Description --- The attached patch fixes KTar so that the contents of a sample archive: d/ d/f1.txt d/ d/f2.txt are shown correctly as d/f1.txt d/f2.txt instead of d/f2.txt See the bug report for details on what kind of archives are not shown correctly in Konqueror vs Ark. This addresses bug 206994. http://bugs.kde.org/show_bug.cgi?id=206994 Diffs - kdecore/io/ktar.cpp 142a80a Diff: http://git.reviewboard.kde.org/r/110392/diff/ Testing --- Thanks, Dawit Alemayehu
Re: Review Request 110392: Do not overwrite directories inside a tar archive
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/ --- (Updated May 12, 2013, 1:44 a.m.) Status -- This change has been marked as submitted. Review request for kdelibs and David Faure. Description --- The attached patch fixes KTar so that the contents of a sample archive: d/ d/f1.txt d/ d/f2.txt are shown correctly as d/f1.txt d/f2.txt instead of d/f2.txt See the bug report for details on what kind of archives are not shown correctly in Konqueror vs Ark. This addresses bug 206994. http://bugs.kde.org/show_bug.cgi?id=206994 Diffs - kdecore/io/ktar.cpp 142a80a Diff: http://git.reviewboard.kde.org/r/110392/diff/ Testing --- Thanks, Dawit Alemayehu
