Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017/
---

(Updated Feb. 28, 2014, 5:44 a.m.)


Review request for kdelibs, Andrea Iacovitti and David Faure.


Changes
---

Updated the branch this patch applies to.


Bugs: 330890
http://bugs.kde.org/show_bug.cgi?id=330890


Repository: kdelibs


Description
---

The attached patch implements support for redirecting one POST request to 
another in KIO. Unless implicitly disabled currently the automatic redirection 
handler in KIO always redirects any POST requests to a GET.

Note this patch also changes the original KIO::http_post implementation that 
accepted a QByteArray to simply store the data in a QBuffer and call the newer 
implementation that uses a QIODevice. I have updated the documentation for the 
original implementation to state as such and encourage developers to directly 
use the newer http_post method instead. Not sure if everyone will agree with my 
implementation but it makes it much easier to resend POST data on redirection.


Diffs
-

  kio/kio/job.h aeaffa2 
  kio/kio/job.cpp edc5fed 
  kio/kio/job_p.h 5ead3ed 
  kioslave/http/http.cpp 9eba5d1 

Diff: https://git.reviewboard.kde.org/r/116017/diff/


Testing
---

http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
http://www.w3.org/People/Bos/Test/redirect307.html


Thanks,

Dawit Alemayehu

Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017/
---

(Updated Feb. 28, 2014, 5:42 a.m.)


Review request for kdelibs, Andrea Iacovitti and David Faure.


Changes
---

Updated patch.


Bugs: 330890
http://bugs.kde.org/show_bug.cgi?id=330890


Repository: kdelibs


Description
---

The attached patch implements support for redirecting one POST request to 
another in KIO. Unless implicitly disabled currently the automatic redirection 
handler in KIO always redirects any POST requests to a GET.

Note this patch also changes the original KIO::http_post implementation that 
accepted a QByteArray to simply store the data in a QBuffer and call the newer 
implementation that uses a QIODevice. I have updated the documentation for the 
original implementation to state as such and encourage developers to directly 
use the newer http_post method instead. Not sure if everyone will agree with my 
implementation but it makes it much easier to resend POST data on redirection.


Diffs (updated)
-

  kio/kio/job.h aeaffa2 
  kio/kio/job.cpp edc5fed 
  kio/kio/job_p.h 5ead3ed 
  kioslave/http/http.cpp 9eba5d1 

Diff: https://git.reviewboard.kde.org/r/116017/diff/


Testing
---

http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
http://www.w3.org/People/Bos/Test/redirect307.html


Thanks,

Dawit Alemayehu

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-02-27 Thread Dawit Alemayehu 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/
---

(Updated Feb. 28, 2014, 5:33 a.m.)


Review request for kdelibs, Andrea Iacovitti and David Faure.


Changes
---

Uploaded patch.


Bugs: 331295
http://bugs.kde.org/show_bug.cgi?id=331295


Repository: kdelibs


Description
---

This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which 
attempted to workaround webdav servers that do not accept delete requests on 
directories unless there is a trailing slash. It ensures that the "fix" is only 
applicable to webdav and the addition of the trailing slash is communicated to 
the client application.


Diffs (updated)
-

  kioslave/http/http.cpp 9eba5d1 

Diff: https://git.reviewboard.kde.org/r/116122/diff/


Testing
---


Thanks,

Dawit Alemayehu

Re: KColorEdit in extragear/graphics

2014-02-27 Thread Percy Camilo Triveño Aucahuasi 

Hi all,

On 26/02/14 17:36, Ben Cooksley wrote:

On Thu, Feb 27, 2014 at 11:15 AM, Nicolás Alvarez
 wrote:

2014-02-23 11:56 GMT-03:00 Albert Astals Cid :

El Diumenge, 23 de febrer de 2014, a les 15:53:44, Albert Astals Cid va
escriure:

El Dissabte, 22 de febrer de 2014, a les 19:13:39, Percy Camilo Triveño

Aucahuasi va escriure:

Hi all, the migration is complete now[1], big thanks to Ben for all the
help and patience.


The log still seems to be incomplete, first commit is

kcoloredit moves to extragear
svn path=/trunk/extragear/graphics/kcoloredit/; revision=674157

Seems to ignore the past of kcoloredit in trunk/KDE/kdegraphics/kcoloredit/
before that move.

Can you have a look?


Also it seems it has no tags at all and i can see that kcoloredit was part of
http://websvn.kde.org/tags/KDE/3.0.4/kdegraphics/
so it should have a v3.0.4 tag (and probably others)


I have fixed these and other problems, the history seems complete now.

Can I get force-push permissions to kcoloredit.git?


I believe everything has now been sorted (per IRC chat).



--
Nicolás


Thanks,
Ben



Nicolás, thank you so much for help me with the migration! And thanks to 
the rest too.


Cheers,
Percy (aucahuasi)

Re: Lokalization for KDE AppStream AppData files

2014-02-27 Thread Aleix Pol 
On Fri, Feb 21, 2014 at 4:48 PM, Matthias Klumpp wrote:

> 2014-02-21 2:02 GMT+01:00 Aleix Pol :
> > [...]
> >
> > I'm very happy to see you pushing this forward. Muon will be supporting
> this
> > format from the next released version (to some extent) and I'm sure this
> > will increase over time.
> Great! Please keep in mind that the format is not meant to be
> processed directly, but instead an intermediate Xapian database is
> used. GNOME does not use it because the library for accessing the db
> was not ready in time and it only had to run on Fedora anyway at that
> time.
> I will hopefully have time to work on the database stuff this weekend.
>

I'm aware of that library, but I don't really see the need yet. Maybe I
will when we're actually using those.


>
> > Regarding localization, Albert is the man here. If he says it's done in a
> > way, you do it this way. ;-)
> > More seriously though, I agree that it's doesn't make much sense to have
> it
> > generated at build time, since this would require having all translations
> > installed. Maybe we can figure out a mechanism appdata -> po -> appdata
> like
> > in the desktop files. It works great there for desktop files, and it's
> the
> > exact same use-case.
> I have a compromise to offer, which will be necessary anyway in a way,
> since to-be-localized entries in our XML files would have to be
> prefixed with an underscore, so merging stuff back into the original
> file does not work (unless we duplicate data there, which is ugly).
> So, new suggestion:
>  * Project author creates file project.appdata.xml.in, containing the
> raw data which has to be translated.
>  * Scripty processes that file and commits a project.appdata.xml file
> in the same directory where the previous one was, containing all
> localizations. If one is already there, the file is updated.
>  * We simply install the localized file and keep the other one as template
> That solution would work, I would be happy with it and hopefully
> Albert as well :-) If not, please make an alternative suggestion.
> Cheers,
> Matthias
>
> --
> Debian Developer | Freedesktop-Developer
> I welcome VSRE emails. See http://vsre.info/
>

Aleix

Re: Review Request 115964: Oxygen: avoid calls to reparseConfiguration() on startup.

2014-02-27 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115964/
---

(Updated Feb. 27, 2014, 8:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and Hugo Pereira Da Costa.


Repository: kde-workspace


Description
---

Oxygen: avoid calls to reparseConfiguration() on startup.

strace -e open kate |& grep -v NOENT | grep oxygenrc | wc -l
  went from 8 to 4
  (and when looking for kdeglobals, from 13 to 11)

There's still a lot of work to be done in that area...
(within KConfigSkeleton, and probably kdeplatformtheme)


Diffs
-

  kstyles/oxygen/oxygenshadowhelper.h 066edd3292f390401691a9d6e5182e9dc6d24133 
  kstyles/oxygen/oxygenshadowhelper.cpp 
b3f3d0c876067292a72647e9fcda07cbbf4ba4b0 
  kstyles/oxygen/oxygenstyle.h 35323b4578eb9aa0d1efcc5901bab80fadea64f3 
  kstyles/oxygen/oxygenstyle.cpp f6ff24ad515003ad031c80665935e6d113b5a1e5 
  kstyles/oxygen/oxygenstylehelper.h 57b86c7ed540364040e87a8464299db17c460647 
  kstyles/oxygen/oxygenstylehelper.cpp f2af4172c5beb8b8c3bb0d75b5eb351dc710289e 
  kwin/clients/oxygen/demo/oxygenshadowdemodialog.cpp 
9e1481cab4cca2961b48c791e72d925ae4a83d05 
  kwin/clients/oxygen/oxygendecohelper.h 
4c9a44ab54edec7bdc428f33e580efc60efdf235 
  kwin/clients/oxygen/oxygendecohelper.cpp 
e6bbcbf9df7eee3188c84cd74f0e32b7cfd162d3 
  kwin/clients/oxygen/oxygenfactory.h 9ed90ec1567ed537a3524b2d4a507a3471341a64 
  kwin/clients/oxygen/oxygenfactory.cpp 
6d5b08b9160a7794f668feb2914450b602360ce6 
  libs/oxygen/oxygenhelper.h ee381a74320da172e834550f61ef214377870bfc 
  libs/oxygen/oxygenhelper.cpp cd6562b411fdb1bce6d0c740a4b38dae33218324 

Diff: https://git.reviewboard.kde.org/r/115964/diff/


Testing
---


Thanks,

David Faure

Re: Review Request 115964: Oxygen: avoid calls to reparseConfiguration() on startup.

2014-02-27 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115964/#review51127
---


This review has been submitted with commit 
2a9b5a2f4fb3bcdfae6cad53f93bfe5c8db48d95 by David Faure to branch master.

- Commit Hook


On Feb. 25, 2014, 12:02 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115964/
> ---
> 
> (Updated Feb. 25, 2014, 12:02 p.m.)
> 
> 
> Review request for kde-workspace and Hugo Pereira Da Costa.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Oxygen: avoid calls to reparseConfiguration() on startup.
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc | wc -l
>   went from 8 to 4
>   (and when looking for kdeglobals, from 13 to 11)
> 
> There's still a lot of work to be done in that area...
> (within KConfigSkeleton, and probably kdeplatformtheme)
> 
> 
> Diffs
> -
> 
>   kstyles/oxygen/oxygenshadowhelper.h 
> 066edd3292f390401691a9d6e5182e9dc6d24133 
>   kstyles/oxygen/oxygenshadowhelper.cpp 
> b3f3d0c876067292a72647e9fcda07cbbf4ba4b0 
>   kstyles/oxygen/oxygenstyle.h 35323b4578eb9aa0d1efcc5901bab80fadea64f3 
>   kstyles/oxygen/oxygenstyle.cpp f6ff24ad515003ad031c80665935e6d113b5a1e5 
>   kstyles/oxygen/oxygenstylehelper.h 57b86c7ed540364040e87a8464299db17c460647 
>   kstyles/oxygen/oxygenstylehelper.cpp 
> f2af4172c5beb8b8c3bb0d75b5eb351dc710289e 
>   kwin/clients/oxygen/demo/oxygenshadowdemodialog.cpp 
> 9e1481cab4cca2961b48c791e72d925ae4a83d05 
>   kwin/clients/oxygen/oxygendecohelper.h 
> 4c9a44ab54edec7bdc428f33e580efc60efdf235 
>   kwin/clients/oxygen/oxygendecohelper.cpp 
> e6bbcbf9df7eee3188c84cd74f0e32b7cfd162d3 
>   kwin/clients/oxygen/oxygenfactory.h 
> 9ed90ec1567ed537a3524b2d4a507a3471341a64 
>   kwin/clients/oxygen/oxygenfactory.cpp 
> 6d5b08b9160a7794f668feb2914450b602360ce6 
>   libs/oxygen/oxygenhelper.h ee381a74320da172e834550f61ef214377870bfc 
>   libs/oxygen/oxygenhelper.cpp cd6562b411fdb1bce6d0c740a4b38dae33218324 
> 
> Diff: https://git.reviewboard.kde.org/r/115964/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Faure
> 
>

Re: Moving Baloo forward

2014-02-27 Thread GEO 
On Sunday 23 February 2014 12:21:24 GEO wrote:
> On Sunday 23 February 2014 12:14:30 Vishesh Handa wrote:
> > On Thursday, February 20, 2014 08:58:48 AM GEO wrote:
> > > First of all: I am totally for xattr, thank you Vishesh for the great
> > > idea!
> > 
> > Thanks, though the idea was Simeons. I just implemented some parts of it
> > :)
> 
> I was not able to find that out without any doubt in the wiki page: Are
> relations also stored as xattr? (Like: from etc.)
> This would be really awesome, as everything would be pretty reliable and
> portable.

I understand that not everything makes sense to store in xattr and that you 
sometimes need unique identifiers for certain informations, but is some 
information about relations like for e.g. "from: t...@mail.com" stores in the 
file attributes? 
That would really make sense, as the same argument applies as for using xattr 
in the first place.

Thank you very much!

Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-27 Thread David Faure 


> On Feb. 24, 2014, 7:17 p.m., David Faure wrote:
> > kio/kio/job.h, line 307
> > 
> >
> > "recommended you use the function for when..." - rather unclear. Which 
> > function? In the commit log you said you wanted to encourage using the 
> > QIODevice overload directly (which I assume this is trying to do, although 
> > not clearly).
> > 
> > But even then I don't think it makes sense. Anyone who has a QByteArray 
> > on their hands should call the function with a QByteArray rather than just 
> > create a QBuffer in order to be able to call the "recommended function" -- 
> > all this achieves is duplicating that bit of code into the apps.
> > 
> > I would suggest removing the whole note, simply. Two overloads = pick 
> > the most convenient one for the calling code.
> >
> 
> Dawit Alemayehu wrote:
> Well the intent was to discourage people from using QByteArrays to store 
> upload data in the first place so as to avoid the same mistake committed in 
> KHTML. Currently KHTML stores the contents of an entire file, no matter how 
> large, into memory whenever a user attempts to upload such files. My attempt 
> to get the KHTML developers to realize that is the wrong thing to do did not 
> get anywhere. Anyways, you are correct. It is pointless to attempt to 
> discourage people from using API that has been available since the creation 
> of KIO.

Oh, I agree. If one can provide the data as a QIODevice that retrieves data on 
demand that is indeed much better.

But simply deprecating the method that takes a QByteArray will lead to 
absurdity for people who actually have a QByteArray in the first place and no 
other choice: they'd have to create a QBuffer around it just to call the right 
method, that's just inconvenient.

However I agree - if one has a choice, one should prefer not to create a 
qbytearray with the full data in the first place.

"has been available since the creation of kio" isn't at all any reason for or 
against, times change and things improve :) We deprecate things for a good 
reason. I just don't think there's a good reason to deprecate the QByteArray 
overload. At most it can say in its documentation "if you can, try not to load 
the full data upfront, and use the QIODevice overload instead".


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017/#review50701
---


On Feb. 27, 2014, 1:41 p.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116017/
> ---
> 
> (Updated Feb. 27, 2014, 1:41 p.m.)
> 
> 
> Review request for kdelibs, Andrea Iacovitti and David Faure.
> 
> 
> Bugs: 330890
> http://bugs.kde.org/show_bug.cgi?id=330890
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The attached patch implements support for redirecting one POST request to 
> another in KIO. Unless implicitly disabled currently the automatic 
> redirection handler in KIO always redirects any POST requests to a GET.
> 
> Note this patch also changes the original KIO::http_post implementation that 
> accepted a QByteArray to simply store the data in a QBuffer and call the 
> newer implementation that uses a QIODevice. I have updated the documentation 
> for the original implementation to state as such and encourage developers to 
> directly use the newer http_post method instead. Not sure if everyone will 
> agree with my implementation but it makes it much easier to resend POST data 
> on redirection.
> 
> 
> Diffs
> -
> 
>   kioslave/http/http.cpp 9eba5d1 
>   kio/kio/job_p.h 5ead3ed 
>   kio/kio/job.h aeaffa2 
>   kio/kio/job.cpp edc5fed 
> 
> Diff: https://git.reviewboard.kde.org/r/116017/diff/
> 
> 
> Testing
> ---
> 
> http://greenbytes.de/tech/tc/httpredirects/t307methods.html
> http://greenbytes.de/tech/tc/httpredirects/t308methods.html
> http://www.w3.org/People/Bos/Test/redirect307.html
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-27 Thread Andrea Iacovitti 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017/#review51063
---



kio/kio/job.cpp


This seems to have no effect in the next GET request, shouldn't be added to 
the outgoing metadata?


- Andrea Iacovitti


On Feb. 27, 2014, 1:41 p.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116017/
> ---
> 
> (Updated Feb. 27, 2014, 1:41 p.m.)
> 
> 
> Review request for kdelibs, Andrea Iacovitti and David Faure.
> 
> 
> Bugs: 330890
> http://bugs.kde.org/show_bug.cgi?id=330890
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The attached patch implements support for redirecting one POST request to 
> another in KIO. Unless implicitly disabled currently the automatic 
> redirection handler in KIO always redirects any POST requests to a GET.
> 
> Note this patch also changes the original KIO::http_post implementation that 
> accepted a QByteArray to simply store the data in a QBuffer and call the 
> newer implementation that uses a QIODevice. I have updated the documentation 
> for the original implementation to state as such and encourage developers to 
> directly use the newer http_post method instead. Not sure if everyone will 
> agree with my implementation but it makes it much easier to resend POST data 
> on redirection.
> 
> 
> Diffs
> -
> 
>   kioslave/http/http.cpp 9eba5d1 
>   kio/kio/job_p.h 5ead3ed 
>   kio/kio/job.h aeaffa2 
>   kio/kio/job.cpp edc5fed 
> 
> Diff: https://git.reviewboard.kde.org/r/116017/diff/
> 
> 
> Testing
> ---
> 
> http://greenbytes.de/tech/tc/httpredirects/t307methods.html
> http://greenbytes.de/tech/tc/httpredirects/t308methods.html
> http://www.w3.org/People/Bos/Test/redirect307.html
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-02-27 Thread Andrea Iacovitti 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/#review51064
---


What patch? ;)

- Andrea Iacovitti


On Feb. 27, 2014, 2:28 p.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116122/
> ---
> 
> (Updated Feb. 27, 2014, 2:28 p.m.)
> 
> 
> Review request for kdelibs, Andrea Iacovitti and David Faure.
> 
> 
> Bugs: 331295
> http://bugs.kde.org/show_bug.cgi?id=331295
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, 
> which attempted to workaround webdav servers that do not accept delete 
> requests on directories unless there is a trailing slash. It ensures that the 
> "fix" is only applicable to webdav and the addition of the trailing slash is 
> communicated to the client application.
> 
> 
> Diffs
> -
> 
> 
> Diff: https://git.reviewboard.kde.org/r/116122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-27 Thread kdeuser56 kdeuser56 


> On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote:
> > Here's my vote then.
> > Unless there's concern, push it "in some days™" (ie. tuesday or so, should 
> > leave enough time to cry out)
> 
> kdeuser56 kdeuser56 wrote:
> "push it" sounds like I should push it, however I can't do it, as I do 
> not have a dev account. Could you push it for me? 
> Pushing in frameworks/kio would also be nice (diff can be found here: 
> http://pastebin.kde.org/p7eahjnoq)!
> 
> kdeuser56 kdeuser56 wrote:
> Thomas: Would you mind shipping it for me?
> 
> Thomas Lübking wrote:
> I'd have to setup a frameworks build first.
> I'll push it then if that didn't happen otherwise, but Frank might want 
> to push it before.
> 
> Frank Reininghaus wrote:
> "Frank might want to push it before": To be honest, I'd prefer if you 
> could ask someone else to do it. I do update and build a subset of 
> Qt5+frameworks occasionally, but I only worked on a few low-level things so 
> far, and I never built or used anything that could show a properties dialog. 
> I don't feel comfortable pushing commits in code that I never worked with 
> without testing first, and I will be unable to do it in the near future. 
> Sorry about that.

@Thomas: Thank you I guess I will wait for that. I will check if the code in 
kio framework has changed since the creation of the diff that evening hopefully.


- kdeuser56


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115408/#review49252
---


On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115408/
> ---
> 
> (Updated Feb. 8, 2014, 10:02 a.m.)
> 
> 
> Review request for kdelibs and Frank Reininghaus.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The iconbutton and the iconlabel were clearly aligned using the old style, 
> when everything was left aligned.
> In my interpretation of the KDE HIG guidelines, the iconbutton/label should 
> also be right aligned.  
> Especially with bigger font sizes, the visual issue becomes obvious. 
> 
> Idea: see kproperties-dolphin-1.png
> Before: see before-1.png and before-2.png 
> After: see after-1.png and after-2.png
> 
> Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w
> 
> 
> Diffs
> -
> 
>   kio/kfile/kpropertiesdialog.cpp 6611ee7 
> 
> Diff: https://git.reviewboard.kde.org/r/115408/diff/
> 
> 
> Testing
> ---
> 
> Compiled and installed. Works as expected. 
> 
> 
> File Attachments
> 
> 
> idea
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png
> before1
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png
> before2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png
> after1
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png
> after2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png
> center-center
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png
> left-left
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png
> right-center
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png
> right-right
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png
> 
> 
> Thanks,
> 
> kdeuser56 kdeuser56
> 
>

Review Request 116122: Do not add trailing slash on http DELETE requests

2014-02-27 Thread Dawit Alemayehu 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/
---

Review request for kdelibs, Andrea Iacovitti and David Faure.


Bugs: 331295
http://bugs.kde.org/show_bug.cgi?id=331295


Repository: kdelibs


Description
---

This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which 
attempted to workaround webdav servers that do not accept delete requests on 
directories unless there is a trailing slash. It ensures that the "fix" is only 
applicable to webdav and the addition of the trailing slash is communicated to 
the client application.


Diffs
-


Diff: https://git.reviewboard.kde.org/r/116122/diff/


Testing
---


Thanks,

Dawit Alemayehu

Review Request 116117: Place new panels to bottom by default

2014-02-27 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116117/
---

Review request for kde-workspace and Plasma.


Repository: kde-workspace


Description
---

When adding a new empty panel, it's placed at top by default, but it should be 
placed to bottom, when it's possible. Also when adding a new "Default Panel" to 
second screen without any panel and you already have one on your first screen, 
then it's also placed to top instead of bottom. This is just a simple fix, 
which changes order of checking free edges for empty panels and adds a check 
for screenId when executing a script for default panel layout. I'm not much 
sure with the javascript part, but it works.


Diffs
-

  
plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
 47f635c 
  plasma/desktop/shell/desktopcorona.cpp d3635d9 

Diff: https://git.reviewboard.kde.org/r/116117/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017/
---

(Updated Feb. 27, 2014, 1:41 p.m.)


Review request for kdelibs, Andrea Iacovitti and David Faure.


Changes
---

Added associated bug report number to the ticket.


Bugs: 330890
http://bugs.kde.org/show_bug.cgi?id=330890


Repository: kdelibs


Description
---

The attached patch implements support for redirecting one POST request to 
another in KIO. Unless implicitly disabled currently the automatic redirection 
handler in KIO always redirects any POST requests to a GET.

Note this patch also changes the original KIO::http_post implementation that 
accepted a QByteArray to simply store the data in a QBuffer and call the newer 
implementation that uses a QIODevice. I have updated the documentation for the 
original implementation to state as such and encourage developers to directly 
use the newer http_post method instead. Not sure if everyone will agree with my 
implementation but it makes it much easier to resend POST data on redirection.


Diffs
-

  kioslave/http/http.cpp 9eba5d1 
  kio/kio/job_p.h 5ead3ed 
  kio/kio/job.h aeaffa2 
  kio/kio/job.cpp edc5fed 

Diff: https://git.reviewboard.kde.org/r/116017/diff/


Testing (updated)
---

http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
http://www.w3.org/People/Bos/Test/redirect307.html


Thanks,

Dawit Alemayehu