Re: Review Request 116602: fix setting "ssl_was_in_use" metadata

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review54262
---


This review has been submitted with commit 
cf1a7a6f521837792296386275e0e66f7a40e631 by Andrea Iacovitti to branch KDE/4.12.

- Commit Hook


On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> ---
> 
> (Updated March 4, 2014, 9:43 p.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i 
> verified this happen) using [] operator results in inserting a new item with 
> key "ssl_in_use" and NullString value in incomingMetaData map and, as a 
> consequence, a new item with key "ssl_was_in_use" and NullString value in 
> outgoingMetaData map.
> This patch aims to avoid this situation by looking up the key using 
> queryMetadata().
> 
> 
> Diffs
> -
> 
>   kio/kio/job.cpp edc5fed 
> 
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

Re: Review Request 116602: fix setting "ssl_was_in_use" metadata

[Andrea Iacovitti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/
---

(Updated March 27, 2014, 6:19 a.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs and Dawit Alemayehu.


Repository: kdelibs


Description
---

If incomingMetaData doesn't contain item with key "ssl_in_use" (and i verified 
this happen) using [] operator results in inserting a new item with key 
"ssl_in_use" and NullString value in incomingMetaData map and, as a 
consequence, a new item with key "ssl_was_in_use" and NullString value in 
outgoingMetaData map.
This patch aims to avoid this situation by looking up the key using 
queryMetadata().


Diffs
-

  kio/kio/job.cpp edc5fed 

Diff: https://git.reviewboard.kde.org/r/116602/diff/


Testing
---


Thanks,

Andrea Iacovitti

Re: Review Request 116602: fix setting "ssl_was_in_use" metadata

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review54260
---

Ship it!


In that case then you can ship it. I do not care about the other suggestion I 
made.

- Dawit Alemayehu


On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> ---
> 
> (Updated March 4, 2014, 9:43 p.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i 
> verified this happen) using [] operator results in inserting a new item with 
> key "ssl_in_use" and NullString value in incomingMetaData map and, as a 
> consequence, a new item with key "ssl_was_in_use" and NullString value in 
> outgoingMetaData map.
> This patch aims to avoid this situation by looking up the key using 
> queryMetadata().
> 
> 
> Diffs
> -
> 
>   kio/kio/job.cpp edc5fed 
> 
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

Re: Review Request 116522: Make KAboutDialog looks better under OSX

[Yue Liu]

> On March 2, 2014, 12:07 a.m., Kai Uwe Broulik wrote:
> > File Attachment: after-3.png - after-3.png
> > 
> >
> > There is no way to send an E-Mail anymore?
> > 
> > Mabye use a text link instead for all platforms and get rid of that 
> > misused toolbar button altogether.
> 
> Yue Liu wrote:
> I feel any contact info feature in about dialog is not very useful. If a 
> user want to contact developer for software-related stuff, they should go to 
> a public channel like irc/ml/bugzilla so that information is shared by the 
> whole community. If they want to contact a developer for something in person, 
> since they know the developer in person they should already have good 
> communication channel to that developer.
> 
> Frank Reininghaus wrote:
> But then we should remove the possibility to send an E-mail on all 
> platforms, not just MacOS. I would welcome such a change because users do use 
> that link in the "About Dolphin" dialog to send me bug reports and support 
> requests, which should better go to bugs.kde.org and forum.kde.org, 
> respectively.

Anyone interested in this discussion? Should personal contact method provided 
in about dialog?


- Yue


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116522/#review51557
---


On March 1, 2014, 11:06 p.m., Yue Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116522/
> ---
> 
> (Updated March 1, 2014, 11:06 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Removed close button, because About dialog on OSX usually don't have any 
> buttons.
> Don't draw QFrame in title widget because QFrame::styledPanel looks ugly on 
> OSX.
> KToolBar also looks ugly so removed main links and social links.
> Focus shadow for QListView is also ugly so disabled focus.
> 
> Patch should also work for frameworks but it seems files are split to 
> different parts, can anyone tell me where can I find all the files touched in 
> this patch?
> 
> 
> Diffs
> -
> 
>   kdeui/dialogs/kaboutapplicationdialog.cpp 8c50615 
>   kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp 5b7c278 
>   kdeui/widgets/ktitlewidget.cpp 8464d7e 
> 
> Diff: https://git.reviewboard.kde.org/r/116522/diff/
> 
> 
> Testing
> ---
> 
> Works on OSX 10.9.2
> 
> 
> File Attachments
> 
> 
> before-1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/a7c007c8-08c4-4537-a679-5487ad36d261__before-1.png
> before-2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/66e2b0ca-8a75-4db1-9433-791c44958c3d__before-2.png
> before-3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/9c0b2e5f-9fab-4f15-a916-715a60eb60f2__before-3.png
> after-1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/39880e76-adeb-4d3d-bee3-a9029b4ed060__after-1.png
> after-2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/f8a4472a-1eb7-4a89-9f13-434676547e63__after-2.png
> after-3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/1b290e0c-97f9-448e-b83e-67144773bdbb__after-3.png
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

Re: Final kde-runtime splitting plan

[Aleix Pol]

On Wed, Mar 26, 2014 at 12:37 PM, Carlos De Maine wrote:

>  On Wed, 26 Mar 2014 11:28:24 AM Àlex Fiestas wrote:
>
> > On Wednesday 26 March 2014 09:52:08 Carlos De Maine wrote:
>
> > > On Tue, 25 Mar 2014 04:18:22 PM Àlex Fiestas wrote:
>
> > > > Hi there
>
> > > >
>
> > > > Today Aleix and I are starting to split kde-runtime so we have gone
>
> > > > through
>
> > > > all the components again making sure that everything has a suitable
>
> > > > destination. The result is this [1] wiki.
>
> > > >
>
> > > > Please, check that you are ok with the destination of each component
> and
>
> > > > also check the things that have been targeted as **REMOVE** should be
>
> > > > really removed (we believe so).
>
> > >
>
> > > Kio-network works on 4.13 for me.
>
> > > http://wstaw.org/w/2ADU/[1]
>
> > > Does have a weird issue that it has to be refreshed twice to show any
>
> > > content for the first time, but works perfectly after that.
>
> > > Would be a pity to remove the only network browser.
>
> >
>
> > You can't actually execute anything from it can you? It is basically a
>
> > browser that lets you list things but little more which is quite useless
>
> > imho.
>
> >
>
> > I'm good on moving it elsewhere but what I would like to avoid is
> shipping
>
> > this not finished kio as part of the official release which servers only
> a
>
> > use (browser and discovery) that most people do not need by itself.
>
> >
>
> It opens fish/sftp, smb, afc kioslaves in dolphin, launches krdc for rfb
> and vnc, opens konsole (at password entry stage) for ssh. In the past when
> the upnp kioslave was still compiling i was able to access my upnp shares
> around the network as well.
>
>
>
> I agree its not fully functional but in it's present state it is still
> incredibly useful in the file dialog for accessing the network transparency
> of kde's kioslaves. With a bit of polish (such as linking ktp to
> *.presence, fish kioslave for *.udisks-ssh) it would be perfect.
>
>
>
> Cheers
>
> > Cheers.
>
>
>

It is a pity indeed. I just tried it myself on KDE4 and it seems like it
wants to work but it doesn't quite.

I wouldn't want this to prolongue, this project couldn't go through
kdereview at the moment successfully, so there's little reason for it to
stay in.

Instead of removing, we can put it differently and move it to a little farm
where kioslaves go die, but if somebody doesn't commit to it, it has to go.

Also there's many other kioslaves in need for love: ** Adopt your kioslave
**

Aleix

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review54247
---


you could sighup or sigusr the greeter process and have it

setImmediateLock(true);
desktopResized();

in return

- Thomas Lübking


On March 26, 2014, 4:58 p.m., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117091/
> ---
> 
> (Updated March 26, 2014, 4:58 p.m.)
> 
> 
> Review request for kde-workspace and Aaron J. Seigo.
> 
> 
> Bugs: 327947 and 329076
> http://bugs.kde.org/show_bug.cgi?id=327947
> http://bugs.kde.org/show_bug.cgi?id=329076
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> If the screen locker is set to not require a password to unlock, it will not 
> show the password input field even when the powermanagement settings suspend 
> the system and are set to require a password after resume (when it was 
> already running at that point).
> This locks people out of their system.
> 
> As there seems to be no way to switch the already running greeter to 
> immediateLock mode, it is killed in that case by this patch. It gets 
> restarted immediately with the --immediatelock option in 
> KSldApp::lockProcessFinished() and shows the password input field then.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp 3dfcc9e 
> 
> Diff: https://git.reviewboard.kde.org/r/117091/diff/
> 
> 
> Testing
> ---
> 
> Disable "Require password after" in the screen locker settings (the default), 
> set it to start after 1 min. (for easier testing).
> Enable "Suspend session after" and set it to 2 minutes. (set the action to 
> "Suspend", "Hibernate", or "Lock Screen", doesn't matter)
> Make sure "Lock screen on resume" is enabled in the powermanagements 
> "Advanced Options" (it is by default).
> 
> After 1 minute the screen locker kicks in, and doesn't require a password.
> After 2 minutes the session gets suspended, hibernated or locked, and 
> requires a password to resume.
> 
> Without this patch no password dialog is shown, the user cannot resume the 
> session by entering the password.
> 
> With this patch this works: there is a password input field, the session is 
> unlocked when the user enters the password.
> 
> Other openSUSE users have tested this as well, see f.e. 
> https://bugzilla.novell.com/show_bug.cgi?id=864305#c4
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

Re: Final kde-runtime splitting plan

[Carlos De Maine]

On Wed, 26 Mar 2014 11:28:24 AM Àlex Fiestas wrote:
> On Wednesday 26 March 2014 09:52:08 Carlos De Maine wrote:
> > On Tue, 25 Mar 2014 04:18:22 PM Àlex Fiestas wrote:
> > > Hi there
> > > 
> > > Today Aleix and I are starting to split kde-runtime so we have gone
> > > through
> > > all the components again making sure that everything has a suitable
> > > destination. The result is this [1] wiki.
> > > 
> > > Please, check that you are ok with the destination of each component and
> > > also check the things that have been targeted as **REMOVE** should be
> > > really removed (we believe so).
> > 
> > Kio-network works on 4.13 for me.
> > http://wstaw.org/w/2ADU/[1]
> > Does have a weird issue that it has to be refreshed twice to show any
> > content for the first time, but works perfectly after that.
> > Would be a pity to remove the only network browser.
> 
> You can't actually execute anything from it can you? It is basically a
> browser that lets you list things but little more which is quite useless
> imho.
> 
> I'm good on moving it elsewhere but what I would like to avoid is shipping
> this not finished kio as part of the official release which servers only a
> use (browser and discovery) that most people do not need by itself.
> 
It opens fish/sftp, smb, afc kioslaves in dolphin, launches krdc for rfb and 
vnc, opens 
konsole (at password entry stage) for ssh. In the past when the upnp kioslave 
was 
still compiling i was able to access my upnp shares around the network as well.

I agree its not fully functional but in it's present state it is still 
incredibly useful in the 
file dialog for accessing the network transparency of kde's kioslaves.  With a 
bit of 
polish (such as linking ktp to *.presence, fish kioslave for *.udisks-ssh) it 
would be 
perfect.

Cheers
> Cheers.

KBibTeX in KDE Review

[Thomas Fischer]

Hello,

KBibTeX is a BibTeX editor to edit bibliographies used with LaTeX.

After being under development for nearly 10 years, KBibTeX moved a
few months ago from its previous hosting platform Gna! to KDE's
playground. Being a mature project already when entering the
playground, it may be time to continue. Therefore, I would like to
ask you to review KBibTeX and approve a move to extragear.

The Policies/Application Lifecycle documentation states some
requirements for be reached before being allowed to proceed.
1. User documentation: initial documentation has been provided by
Yuri Chornoivan and Burkhard Lück, located in master and will be
part of future 0.6 releases
2. Developer documentation: due to organic growth, the level of
documentation in the source code varies strongly.
3. Most Krazy issues have been addressed, a few border cases are left.
4. No usability review has been done, but normal users' feedback on
usability has been considered previously.
5. Intel's profiler has been used in the past and Valgrind is still
used from time to time (not a profiler per se, but still got to
improve code quality). Hot spots exist, but those appear only in
border cases, e.g. when a bibliography entry has 300 authors.
6. KBibTeX used ki18n(...) and alike from the beginning.
Translations of configuration file strings has been added after the
code moved to playground.

The project's current location in KDE Review is:
https://projects.kde.org/projects/kdereview/kbibtex

General information on KBibTeX can be retrieved from its old homepage:
http://home.gna.org/kbibtex/

Looking forward to your feedback,
Thomas



signature.asc
Description: OpenPGP digital signature

Re: Review Request 116602: fix setting "ssl_was_in_use" metadata

[Andrea Iacovitti]

> On March 26, 2014, 12:27 p.m., Dawit Alemayehu wrote:
> > Do you want me to apply this patch with the minor changes I suggested?

Sorry for the late reply!

Based on how these metadata are used (ssl_in_use, ssl_was_in_use) if the map 
contains the key the associated value string could (well... should) only be 
equals to "TRUE" or "FALSE". So when looking up for the key using 
queryMetaData() if the map doesn't contain the key a Null string is returned, 
that's why i used !sslInUse.isNull() (it's the same as checking for 
map.contains(key)).
About the other changes you suggested i found my code more readable.
However the goal doesn't change so i'm fine if you apply the patch with the 
changes you suggested.

One last thing i found grepping the code for "ssl_in_use".
In kdelibs/kio/kio/accessmanager.cpp:482 should not the check
if (metadata.contains(QL1S(""ssl_in_use"")))
be changed to
if (metadata.value(QL1S("ssl_in_use")) == QL1S("TRUE"))
for the same reason i stated above?


- Andrea


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review54178
---


On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> ---
> 
> (Updated March 4, 2014, 9:43 p.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i 
> verified this happen) using [] operator results in inserting a new item with 
> key "ssl_in_use" and NullString value in incomingMetaData map and, as a 
> consequence, a new item with key "ssl_was_in_use" and NullString value in 
> outgoingMetaData map.
> This patch aims to avoid this situation by looking up the key using 
> queryMetadata().
> 
> 
> Diffs
> -
> 
>   kio/kio/job.cpp edc5fed 
> 
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

Re: Review Request 113931: Fix process list to start already sorted

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113931/
---

(Updated March 26, 2014, 7:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and John Tapsell.


Bugs: 282636
http://bugs.kde.org/show_bug.cgi?id=282636


Repository: kde-workspace


Description
---

Quoting the bug report:

"When starting System Monitor, the process list is unsorted. It only gets 
sorted after the first timer tick. Waiting before sorting only makes sense when 
sorting by CPU load, where the load is not available before the fist tick. For 
all other types of sorting (name, username, memory, etc.) all data is available 
immediately, so the list should appear already sorted when starting up."


Diffs
-

  libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff 

Diff: https://git.reviewboard.kde.org/r/113931/diff/


Testing
---

I use this patch since some weeks.


Thanks,

Christoph Feck

Re: Review Request 113931: Fix process list to start already sorted

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113931/#review54226
---


This review has been submitted with commit 
e9d34e89e248cf980ce4858e609cf4b5e58661a4 by Christoph Feck to branch KDE/4.11.

- Commit Hook


On Nov. 19, 2013, 2:18 a.m., Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113931/
> ---
> 
> (Updated Nov. 19, 2013, 2:18 a.m.)
> 
> 
> Review request for kde-workspace and John Tapsell.
> 
> 
> Bugs: 282636
> http://bugs.kde.org/show_bug.cgi?id=282636
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Quoting the bug report:
> 
> "When starting System Monitor, the process list is unsorted. It only gets 
> sorted after the first timer tick. Waiting before sorting only makes sense 
> when sorting by CPU load, where the load is not available before the fist 
> tick. For all other types of sorting (name, username, memory, etc.) all data 
> is available immediately, so the list should appear already sorted when 
> starting up."
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff 
> 
> Diff: https://git.reviewboard.kde.org/r/113931/diff/
> 
> 
> Testing
> ---
> 
> I use this patch since some weeks.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

Review Request 117096: rename khelpcenter to khelpcenter5 for coinstallability

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117096/
---

Review request for KDE Runtime and Aleix Pol Gonzalez.


Repository: kde-runtime


Description
---

rename khelpcenter to khelpcenter5 for coinstallability with kdelibs4 
kde-runtime
but somewhere in kf5 will be the code that runs khelpcenter from the standard 
menu which should be updated, I couldn't find it alas


Diffs
-

  khelpcenter/CMakeLists.txt 01639b4 
  khelpcenter/Help.desktop 71505f1 
  khelpcenter/Help5.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117096/diff/


Testing
---


Thanks,

Jonathan Riddell

Review Request 117095: rename kdebugdialog to kdebugdialog5 for coinstallability

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117095/
---

Review request for KDE Runtime and Aleix Pol Gonzalez.


Repository: kde-runtime


Description
---

rename kdebugdialog to kdebugdialog5 for coinstallability.  I'm not aware of 
any other software using kdebugdialog that would need to be updated, it's just 
for (developer) end users.


Diffs
-

  kdebugdialog/CMakeLists.txt 9abc9bd 

Diff: https://git.reviewboard.kde.org/r/117095/diff/


Testing
---


Thanks,

Jonathan Riddell

Review Request 117094: remove obsolete drkonqi kconf_update script

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117094/
---

Review request for KDE Runtime and Aleix Pol Gonzalez.


Repository: kde-runtime


Description
---

remove obsolete drkonq kconf_update script, kf5 based drkonqi starts with a 
fresh config file


Diffs
-

  drkonqi/CMakeLists.txt c7984bf 
  drkonqi/drkonqi-rename-config-section.upd 413908f 

Diff: https://git.reviewboard.kde.org/r/117094/diff/


Testing
---


Thanks,

Jonathan Riddell

Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

[Wolfgang Bauer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---

Review request for kde-workspace and Aaron J. Seigo.


Bugs: 327947 and 329076
http://bugs.kde.org/show_bug.cgi?id=327947
http://bugs.kde.org/show_bug.cgi?id=329076


Repository: kde-workspace


Description
---

If the screen locker is set to not require a password to unlock, it will not 
show the password input field even when the powermanagement settings suspend 
the system and are set to require a password after resume (when it was already 
running at that point).
This locks people out of their system.

As there seems to be no way to switch the already running greeter to 
immediateLock mode, it is killed in that case by this patch. It gets restarted 
immediately with the --immediatelock option in KSldApp::lockProcessFinished() 
and shows the password input field then.


Diffs
-

  ksmserver/screenlocker/ksldapp.cpp 3dfcc9e 

Diff: https://git.reviewboard.kde.org/r/117091/diff/


Testing
---

Disable "Require password after" in the screen locker settings (the default), 
set it to start after 1 min. (for easier testing).
Enable "Suspend session after" and set it to 2 minutes. (set the action to 
"Suspend", "Hibernate", or "Lock Screen", doesn't matter)
Make sure "Lock screen on resume" is enabled in the powermanagements "Advanced 
Options" (it is by default).

After 1 minute the screen locker kicks in, and doesn't require a password.
After 2 minutes the session gets suspended, hibernated or locked, and requires 
a password to resume.

Without this patch no password dialog is shown, the user cannot resume the 
session by entering the password.

With this patch this works: there is a password input field, the session is 
unlocked when the user enters the password.

Other openSUSE users have tested this as well, see f.e. 
https://bugzilla.novell.com/show_bug.cgi?id=864305#c4


Thanks,

Wolfgang Bauer

Review Request 117093: remove obsolete kconfig_update file

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117093/
---

Review request for KDE Runtime and Aleix Pol Gonzalez.


Repository: kde-runtime


Description
---

remove kconf_update file which handles settings from kdelibs4 land.  In kf5 
land people will start with clean settings.


Diffs
-

  kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 
  kurifilter-plugins/ikws/CMakeLists.txt 51294b5 

Diff: https://git.reviewboard.kde.org/r/117093/diff/


Testing
---


Thanks,

Jonathan Riddell

Review Request 117092: rename kioslave files for co-installability

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117092/
---

Review request for KDE Runtime and Aleix Pol Gonzalez.


Repository: kde-runtime


Description
---

ktrash -> ktrash5 (I'm not aware of anything which uses this binary)
network.xml -> kf5_network.xml
org.kde.network.kioslavenotifier.xml -> 
kf5_org.kde.network.kioslavenotifier.xml (I don't know what uses this but I 
assume something must and will need updated)


Diffs
-

  kioslave/trash/ktrash.cpp 9d93d15 
  kioslave/trash/CMakeLists.txt 7c72cdc 
  kioslave/network/mimetypes/CMakeLists.txt c20dc90 
  kioslave/network/kded/CMakeLists.txt e851f73 

Diff: https://git.reviewboard.kde.org/r/117092/diff/


Testing
---


Thanks,

Jonathan Riddell

Review Request 117090: add version to libmolletnetwork

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117090/
---

Review request for KDE Runtime and Aleix Pol Gonzalez.


Repository: kde-runtime


Description
---

add soversion to libmolletnetwork, currently it installs as 
libmolletnetwork.so.SOVERSION which can't be right.
used a simple static version number as inspired by libksysguard in kde-workspace


Diffs
-

  kioslave/network/network/CMakeLists.txt ad72048 

Diff: https://git.reviewboard.kde.org/r/117090/diff/


Testing
---


Thanks,

Jonathan Riddell

Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

[Thomas Lübking]

> On March 26, 2014, 2:29 p.m., Hrvoje Senjan wrote:
> > >(dbus docs say the name of a .service file is arbitrary)
> > it is. however, with this solution, user will never know (i.e. predict) 
> > will kuiserver, or kuiserver5 be started - unless you also change the name 
> > (not filename) of the service. that will however then need adjusting in 
> > 'downstream' consumers of kuiserver
> 
> Jonathan Riddell wrote:
> But then it won't be compatible between uses in kdelibs4 land and users 
> in kf5 land.
>

kuiserver would have to be a proxy that detects the current environment and 
launch the proper variant (like qt-chooser)?


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117088/#review54206
---


On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117088/
> ---
> 
> (Updated March 26, 2014, 2:03 p.m.)
> 
> 
> Review request for KDE Runtime and Aleix Pol Gonzalez.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
> (dbus docs say the name of a .service file is arbitrary)
> 
> 
> Diffs
> -
> 
>   kuiserver/CMakeLists.txt a724326 
>   kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION 
>   kuiserver/kuiserver.desktop 2d7a874 
>   kuiserver/org.kde.kuiserver.service.in a900b64 
> 
> Diff: https://git.reviewboard.kde.org/r/117088/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

[Jonathan Riddell]

> On March 26, 2014, 2:29 p.m., Hrvoje Senjan wrote:
> > >(dbus docs say the name of a .service file is arbitrary)
> > it is. however, with this solution, user will never know (i.e. predict) 
> > will kuiserver, or kuiserver5 be started - unless you also change the name 
> > (not filename) of the service. that will however then need adjusting in 
> > 'downstream' consumers of kuiserver

But then it won't be compatible between uses in kdelibs4 land and users in kf5 
land.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117088/#review54206
---


On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117088/
> ---
> 
> (Updated March 26, 2014, 2:03 p.m.)
> 
> 
> Review request for KDE Runtime and Aleix Pol Gonzalez.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
> (dbus docs say the name of a .service file is arbitrary)
> 
> 
> Diffs
> -
> 
>   kuiserver/CMakeLists.txt a724326 
>   kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION 
>   kuiserver/kuiserver.desktop 2d7a874 
>   kuiserver/org.kde.kuiserver.service.in a900b64 
> 
> Diff: https://git.reviewboard.kde.org/r/117088/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117088/#review54206
---


>(dbus docs say the name of a .service file is arbitrary)
it is. however, with this solution, user will never know (i.e. predict) will 
kuiserver, or kuiserver5 be started - unless you also change the name (not 
filename) of the service. that will however then need adjusting in 'downstream' 
consumers of kuiserver

- Hrvoje Senjan


On March 26, 2014, 2:03 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117088/
> ---
> 
> (Updated March 26, 2014, 2:03 p.m.)
> 
> 
> Review request for KDE Runtime and Aleix Pol Gonzalez.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
> (dbus docs say the name of a .service file is arbitrary)
> 
> 
> Diffs
> -
> 
>   kuiserver/CMakeLists.txt a724326 
>   kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION 
>   kuiserver/kuiserver.desktop 2d7a874 
>   kuiserver/org.kde.kuiserver.service.in a900b64 
> 
> Diff: https://git.reviewboard.kde.org/r/117088/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117088/
---

Review request for KDE Runtime and Aleix Pol Gonzalez.


Repository: kde-runtime


Description
---

Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
(dbus docs say the name of a .service file is arbitrary)


Diffs
-

  kuiserver/CMakeLists.txt a724326 
  kuiserver/kf5_org.kde.kuiserver.service.in PRE-CREATION 
  kuiserver/kuiserver.desktop 2d7a874 
  kuiserver/org.kde.kuiserver.service.in a900b64 

Diff: https://git.reviewboard.kde.org/r/117088/diff/


Testing
---


Thanks,

Jonathan Riddell

Re: Review Request 116602: fix setting "ssl_was_in_use" metadata

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review54178
---


Do you want me to apply this patch with the minor changes I suggested?

- Dawit Alemayehu


On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> ---
> 
> (Updated March 4, 2014, 9:43 p.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i 
> verified this happen) using [] operator results in inserting a new item with 
> key "ssl_in_use" and NullString value in incomingMetaData map and, as a 
> consequence, a new item with key "ssl_was_in_use" and NullString value in 
> outgoingMetaData map.
> This patch aims to avoid this situation by looking up the key using 
> queryMetadata().
> 
> 
> Diffs
> -
> 
>   kio/kio/job.cpp edc5fed 
> 
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

Re: Review Request 117081: Switch to Comme font

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117081/
---

(Updated March 26, 2014, 12:26 p.m.)


Review request for kde-workspace and Sebastian Kügler.


Changes
---

Spotted the problem in the cmake check, an extra bracket broke it.


Repository: kde-workspace


Description
---

Oxygen Font has been renamed to Comme Font upstream
I'm trying to get together a release of Comme Font, testing tar at 
http://starsky.19inch.net/~jr/tmp/commefont-1.0.0.tar.gz
This renames the expected font by startkde
It also puts in a find_package line for Comme Font so that people compiling it 
know to install it, however when running cmake it didn't show up so I'm a 
little confused there.


Diffs (updated)
-

  plasma-workspace/CMakeLists.txt 460755b 
  plasma-workspace/startkde/startkde.cmake e845603 

Diff: https://git.reviewboard.kde.org/r/117081/diff/


Testing
---


Thanks,

Jonathan Riddell

Review Request 117081: Switch to Comme font

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117081/
---

Review request for kde-workspace and Sebastian Kügler.


Repository: kde-workspace


Description
---

Oxygen Font has been renamed to Comme Font upstream
I'm trying to get together a release of Comme Font, testing tar at 
http://starsky.19inch.net/~jr/tmp/commefont-1.0.0.tar.gz
This renames the expected font by startkde
It also puts in a find_package line for Comme Font so that people compiling it 
know to install it, however when running cmake it didn't show up so I'm a 
little confused there.


Diffs
-

  plasma-workspace/CMakeLists.txt 460755b 
  plasma-workspace/startkde/startkde.cmake e845603 

Diff: https://git.reviewboard.kde.org/r/117081/diff/


Testing
---


Thanks,

Jonathan Riddell

Re: Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116956/
---

(Updated March 26, 2014, 11:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Runtime, Plasma and Martin Gräßlin.


Repository: kde-runtime


Description
---

kde-runtime will soon get an alpha release.  Because both KF5 and kdelibs4 
applications should be able to be installed and run it should be co-installable 
with kde-runtime from KDE 4 times.  Starting at the top of the cmake file I've 
renamed kglobalaccel to see if it's sane to do so.


Diffs
-

  kglobalaccel/CMakeLists.txt e0b739f 
  kglobalaccel/kglobalaccel.desktop a61516e 
  kglobalaccel/org.kde.kglobalaccel.service.in d8576b0 

Diff: https://git.reviewboard.kde.org/r/116956/diff/


Testing
---


Thanks,

Jonathan Riddell

Re: Final kde-runtime splitting plan

[Àlex Fiestas]

On Tuesday 25 March 2014 23:01:39 Luigi Toscano wrote:
> Why kreadconfig (which includes kreadconfig and kwriteconfig) is going to be
> in plasma-workspace? Isn't it useful for every KConfig-based
> component/application? Maybe  kde cli tools  could be the target...
I thought there was another tool to do such things but apparently there are 
not, so yes we have to move kread/write config elsewhere.

I wonder if a good place will be kconfig itself? they are useful tools for any 
kconfig user.

Maintainer, any thoughts?

signature.asc
Description: This is a digitally signed message part.

Re: Final kde-runtime splitting plan

[Àlex Fiestas]

On Tuesday 25 March 2014 20:00:51 Albert Astals Cid wrote:
> Can you give a rationale of why we're removing the following things?
> 
> kfile4
kfile4 is only useful to test a library that is right now on kde4support. Maybe 
we can move it there if you want.

> kio_cgi
Who needs to execute a cgi script without a web server? If you do then we can 
move it its own repo, I really don't want to see distributions shipping this 
kio in a package such of "kioslaves-extras" since it really doesn't offer 
anything useful for most of our user base.

> kio settings
Browsing the settings in the file browser does not seem like a really 
convenient thing to have, and of course it adds more code to maintain.
If you want to keep it that's fine but then please become maintainer and tell 
us where to move it (maybe kioslave-extra?).

Cheers!

signature.asc
Description: This is a digitally signed message part.

Re: Final kde-runtime splitting plan

[Àlex Fiestas]

On Wednesday 26 March 2014 09:52:08 Carlos De Maine wrote:
> On Tue, 25 Mar 2014 04:18:22 PM Àlex Fiestas wrote:
> > Hi there
> > 
> > Today Aleix and I are starting to split kde-runtime so we have gone
> > through
> > all the components again making sure that everything has a suitable
> > destination. The result is this [1] wiki.
> > 
> > Please, check that you are ok with the destination of each component and
> > also check the things that have been targeted as **REMOVE** should be
> > really removed (we believe so).
> 
> Kio-network works on 4.13 for me.
> http://wstaw.org/w/2ADU/[1]
> Does have a weird issue that it has to be refreshed twice to show any
> content for the first time, but works perfectly after that.
> Would be a pity to remove the only network browser.
You can't actually execute anything from it can you? It is basically a browser 
that lets you list things but little more which is quite useless imho.

I'm good on moving it elsewhere but what I would like to avoid is shipping 
this not finished kio as part of the official release which servers only a use 
(browser and discovery) that most people do not need by itself.

Cheers.


signature.asc
Description: This is a digitally signed message part.

kde-workspace split incoming!

[Àlex Fiestas]

Hi everybody!

We are done doing CMake on kde-workspace so we have asked sysadmin team  to 
create the new repositories. Once that's done we will freeze kde-
workspace/master and proceed to split and setup everything (kdesrc-build, 
build.kde.org etc).

We will try to send a last reminder of the freeze just before it happens (I 
guess sysadmins will do so anyway) so you can be prepared for it.

cheers!

signature.asc
Description: This is a digitally signed message part.

Re: Final kde-runtime splitting plan

[Carlos De Maine]

On Tue, 25 Mar 2014 04:18:22 PM Àlex Fiestas wrote:
> Hi there
> 
> Today Aleix and I are starting to split kde-runtime so we have gone through
> all the components again making sure that everything has a suitable
> destination. The result is this [1] wiki.
> 
> Please, check that you are ok with the destination of each component and
> also check the things that have been targeted as **REMOVE** should be
> really removed (we believe so).

Kio-network works on 4.13 for me.  
http://wstaw.org/w/2ADU/[1] 
Does have a weird issue that it has to be refreshed twice to show any content 
for 
the first time, but works perfectly after that.
Would be a pity to remove the only network browser.

Cheers
Carlos

> 
> Cheers !
> [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization



[1] http://wstaw.org/w/2ADU/