Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118763/
---
(Updated Aug. 22, 2014, 3:31 p.m.)
Status
--
This change has been marked as submitted.
Review request for kde-workspace, Plasma and Hugo Pereira Da Costa.
Repository: oxygen
Description
---
No idea if kde-workspace is still the right group, if not, please change.
find_package(XCB) is called without specifying the required components. This
leads to linking to unused dependencies in case they are installed.
Since XCB is searched for in the top level cmake file in the repository, there
is no need to search for it again. The component required there (only base XCB)
is sufficient.
Although, this should be sufficient to fix the deps problem, it makes sense to
link to XCB::XCB instead of ${XCB_LIBRARIES}, since the former is what is
actually needed.
Diffs
-
kstyle/CMakeLists.txt 165b62a
liboxygen/CMakeLists.txt 0d1dd94
Diff: https://git.reviewboard.kde.org/r/118763/diff/
Testing
---
Thanks,
Bernd Steinhauser
Re: Review Request 119869: KIO: Correctly handle .directory files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 22, 2014, 3:48 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kdelibs and Frank Reininghaus. Bugs: 235457 https://bugs.kde.org/show_bug.cgi?id=235457 Repository: kio Description --- My attempt at fixing [bug 235457](https://bugs.kde.org/show_bug.cgi?id=235457) We give .directory the default Type 'Directory' and a way for KDesktopFileActions to handle .directory files. To do that we trick KRun in opening the file as plain text. hasDirectoryType is a new method in KConfig. see: [119868](https://git.reviewboard.kde.org/r/119868/) Anything I should look out for when commiting this to KConfig and KIO? Diffs - src/widgets/kdesktopfileactions.cpp 9486015 Diff: https://git.reviewboard.kde.org/r/119869/diff/ Testing --- Configure a folder with a custom icon in dolphin. Click the created .directory file. Thanks, Maarten De Meyer
Re: Review Request 119892: [Dolphin] Implement Add to archive option when dragging and dropping onto an archive file in dolphin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/#review65070 --- Thanks for the patch, but I still think (see bug report) that implementing write support for archive kio slaves and then enable dnd for archives in Dolphin is the better way to achieve this. It will be also better in terms of consistency, because the user can not only drag files and folders onto archives but also paste files and folders into archives - archives will be like normal folders. ;) I'm really interested what Frank thinks about it. - Emmanuel Pescosta On Aug. 21, 2014, 11:11 p.m., Arjun Ak wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/ --- (Updated Aug. 21, 2014, 11:11 p.m.) Review request for KDE Base Apps and KDE Utils. Bugs: 338414 http://bugs.kde.org/show_bug.cgi?id=338414 Repository: kde-baseapps Description --- This patch implements the Add to archive option, which is shown when a user drags and drops files onto an existing archive. See also: https://git.reviewboard.kde.org/r/119890 https://bugs.kde.org/show_bug.cgi?id=338414 Diffs - dolphin/src/views/dolphinview.cpp 02b8815 dolphin/src/views/draganddrophelper.cpp f8ae0ad lib/konq/konq_operations.cpp 220a90a Diff: https://git.reviewboard.kde.org/r/119892/diff/ Testing --- Thanks, Arjun Ak
