On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote:
What would likely be confusing is that the two button modes have different
interaction flows: The End Process mode requires to first select a
process and then press the button to work, whereas the Kill specific
window mode requires to first press the button and then select the window
to kill, and users have no easy way to understand how each one works and
why they work differently.
The ellipsis in the label End Process... adds to that confusion. It
indicates that further input is necessary before the action can take
effect. While the button does open a dialog to confirm killing the selected
process, ellipses are actually reserved for actions where a dialog asks for
new information, such as the Save As... button, not for actions that
require confirmation.
To avoid this confusion, it should be possible to also click End
Process... even if no processes has been selected, whuch would then ask
the user to select the process to kill. This could theoretically be done
similarly to the Kill specific window function: Click the End
Process... button and then click the process in the list that you want to
end. Alternatively, if no process had been selected when End Process...
is clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
Gregor Mi wrote:
Thanks for the feedback! The ellipsis in End Process... is the original
design. According to your explanation this was wrong in the first place. What
about removing the ellipses in both menu items so we will end up with End
Process and Kill a specific window?
Thomas Pfeiffer wrote:
Kill specific window does always need additional input until it really
does something, doesn't it? As I understood it merely changes the cursor to
the kill cursor and then the user has to select the window to kill, right?
Gregor Mi wrote:
Erm, right. To be exact, Kill specific window... only shows a message
box. But in the end - after the user presses the keyboard shortcut - the user
has to select a window. So this seems to be a special case. The intention
behind all this is to increase the discoverability of the hidden xkill
feature.
To avoid this confusion, it should be possible to also click End Process...
even if no processes has been selected, whuch would then ask the user to
select the process to kill.
If End Process is clicked with no processes selected, there will be a message
box which says that the user has to select one more more processes first.
This could theoretically be done similarly to the Kill specific window
function: Click the End Process... button and then click the process in the
list that you want to end.
I think Kill specific windows should be considered as the special case here.
Changing or extending the End Process workflow would introduce more
complexity to the code.
Alternatively, if no process had been selected when End Process... is
clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
This would be a topic for another RR.
Summary of final changes for this RR:
- I would change the End Process... to End Process (remove ellipsis). Ok?
- I am not sure if the ellipsis of Kill specific window... should be removed
or not.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review79262
---
On April 20, 2015, 10:24 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/
---
(Updated April 20, 2015, 10:24 p.m.)
Review request for KDE Base Apps, Martin Gräßlin, John Tapsell, and Thomas
Pfeiffer.
Repository: libksysguard
Description
---
Current situation:
The End Process... button has a tooltip which says To target a specific
window to kill, press Ctrl+Alt+Esc at any time. The keyboard shortcut is
hardcoded.
New:
Replace the End Process... button with a drop-down button and a action
named Kill a specific window...
Diffs
-
CMakeLists.txt 66899e577a03786d894423a8f1ce5b3aeed6de8a
processui/CMakeLists.txt 7f87b85e0201e63d69070a71203bbb34851a79c6
processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3
processui/ksysguardprocesslist.cpp 450ca600b8aed7ca611ec638610b6c524c96080c
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
---
File Attachments
New End Process button with drop down arrow
