Jenkins-kde-ci: kdelibs KDE-4.14 latest-qt4 » Linux,gcc - Build # 63 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs%20KDE-4.14%20latest-qt4/PLATFORM=Linux,compiler=gcc/63/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Nov 2016 01:34:03 +
Build duration: 13 min

CHANGE SET
Revision c990b7d3b13900b0e392e2664d0819f4847c9e54 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit khtml/khtml.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 163 test(s), Skipped: 0 test(s), Total: 
163 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: kdelibs KDE-4.14 latest-qt4 » Linux,gcc - Build # 63 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs%20KDE-4.14%20latest-qt4/PLATFORM=Linux,compiler=gcc/63/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Nov 2016 01:34:03 +
Build duration: 13 min

CHANGE SET
Revision c990b7d3b13900b0e392e2664d0819f4847c9e54 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit khtml/khtml.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 163 test(s), Skipped: 0 test(s), Total: 
163 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: kdelibs KDE-4.14 stable-qt4 » Linux,gcc - Build # 64 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs%20KDE-4.14%20stable-qt4/PLATFORM=Linux,compiler=gcc/64/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Nov 2016 01:34:03 +
Build duration: 10 min

CHANGE SET
Revision c990b7d3b13900b0e392e2664d0819f4847c9e54 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit khtml/khtml.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 163 test(s), Skipped: 0 test(s), Total: 
163 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: kdelibs KDE-4.14 stable-qt4 » Linux,gcc - Build # 64 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs%20KDE-4.14%20stable-qt4/PLATFORM=Linux,compiler=gcc/64/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Nov 2016 01:34:03 +
Build duration: 10 min

CHANGE SET
Revision c990b7d3b13900b0e392e2664d0819f4847c9e54 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit khtml/khtml.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 163 test(s), Skipped: 0 test(s), Total: 
163 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

[Damjan Georgievski]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129526/
---

Review request for KDE Base Apps.


Bugs: 365722
https://bugs.kde.org/show_bug.cgi?id=365722


Repository: kwallet-pam


Description
---

Most recent Linux distributions setup a per-user XDG_RUNTIME_DIR as a tmpfs, 
which is also tied to their session lifecycle. Typically this is in 
/run/user/1000/.

My suggestion is to use $XDG_RUNTIME_DIR/kwallet5.socket if XDG_RUNTIME_DIR 
exists, or fallback to /tmp/kwallet5_${username}.socket if it doesn't.

Reproducible: Always


Diffs
-

  pam_kwallet.c 809ab9a 

Diff: https://git.reviewboard.kde.org/r/129526/diff/


Testing
---


Thanks,

Damjan Georgievski

Re: Review Request 129518: Konqueror: restore "Default web browser engine" setting

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129518/#review101036
---


Ship it!




Indeed, you are completely right, sorry.

I forgot my own code, but at least I did document it (ksycoca.h, 
ensureCacheValid(), says (implies) no autodetection for mimeapps.list changes 
-- after all there are only few places which modify it, so no point in slowing 
down queries). And that docu suggests KBuildSycocaProgressDialog in GUI 
programs, so this code is right on.

- David Faure


On Nov. 21, 2016, 12:25 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129518/
> ---
> 
> (Updated Nov. 21, 2016, 12:25 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: konqueror
> 
> 
> Description
> ---
> 
> This settings was originally commented out in the sources, requiring a port 
> to Qt5.  There was not actually much porting to be done, apart from setting 
> the correct QStandardPaths location for the mimeapps.list file, but I've also 
> tidied up and removed a lot of the old cruft and unused code.
> 
> 
> Diffs
> -
> 
>   settings/konqhtml/generalopts.cpp facec057 
> 
> Diff: https://git.reviewboard.kde.org/r/129518/diff/
> 
> 
> Testing
> ---
> 
> Built Konqueror with these changes, checked correct operation of the Settings 
> - Configure Konqueror - General dialogue and the setting of the preferred 
> association for the HTML MIME types.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

Re: Review Request 129518: Konqueror: restore "Default web browser engine" setting

[Jonathan Marten]

> On Nov. 21, 2016, 12:44 p.m., David Faure wrote:
> > settings/konqhtml/generalopts.cpp, line 277
> > 
> >
> > That is actually not fully correct anymore, any process making a trader 
> > query should get updated information automatically, the sycoca rebuilding 
> > happening in-process if necessary. Can you try removing it?

Have tried removing the KBuildSycocaProgressDialog::rebuildKSycoca(this) and it 
doesn't seem to work.  What happens (under a full Plasma 5 desktop) is:

  Start with engine set to WebKit
  kcmshell5 khtml_general, change web engine to KHTML then OK
=> mimeapps.list is updated with khtml.desktop at the front of the list, 
but there is no kbuildsycoca activity
  konqueror www.kde.org
=> still opens in WebKit
  keditfiletype5 text/html
=> "Embedding" tab still has WebKit at the top of the list
  kbuildsycoca5
  konqueror www.kde.org
=> now opens in KHTML
  keditfiletype5 text/html
=> "Embedding" tab now has KHTML at the top of the list


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129518/#review101013
---


On Nov. 21, 2016, 12:25 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129518/
> ---
> 
> (Updated Nov. 21, 2016, 12:25 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: konqueror
> 
> 
> Description
> ---
> 
> This settings was originally commented out in the sources, requiring a port 
> to Qt5.  There was not actually much porting to be done, apart from setting 
> the correct QStandardPaths location for the mimeapps.list file, but I've also 
> tidied up and removed a lot of the old cruft and unused code.
> 
> 
> Diffs
> -
> 
>   settings/konqhtml/generalopts.cpp facec057 
> 
> Diff: https://git.reviewboard.kde.org/r/129518/diff/
> 
> 
> Testing
> ---
> 
> Built Konqueror with these changes, checked correct operation of the Settings 
> - Configure Konqueror - General dialogue and the setting of the preferred 
> association for the HTML MIME types.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

Re: Review Request 129518: Konqueror: restore "Default web browser engine" setting

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129518/#review101013
---


Fix it, then Ship it!




Thanks!


settings/konqhtml/generalopts.cpp (line 258)


That is actually not fully correct anymore, any process making a trader 
query should get updated information automatically, the sycoca rebuilding 
happening in-process if necessary. Can you try removing it?


- David Faure


On Nov. 21, 2016, 12:25 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129518/
> ---
> 
> (Updated Nov. 21, 2016, 12:25 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: konqueror
> 
> 
> Description
> ---
> 
> This settings was originally commented out in the sources, requiring a port 
> to Qt5.  There was not actually much porting to be done, apart from setting 
> the correct QStandardPaths location for the mimeapps.list file, but I've also 
> tidied up and removed a lot of the old cruft and unused code.
> 
> 
> Diffs
> -
> 
>   settings/konqhtml/generalopts.cpp facec057 
> 
> Diff: https://git.reviewboard.kde.org/r/129518/diff/
> 
> 
> Testing
> ---
> 
> Built Konqueror with these changes, checked correct operation of the Settings 
> - Configure Konqueror - General dialogue and the setting of the preferred 
> association for the HTML MIME types.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

Review Request 129518: Konqueror: restore "Default web browser engine" setting

[Jonathan Marten]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129518/
---

Review request for KDE Base Apps and David Faure.


Repository: konqueror


Description
---

This settings was originally commented out in the sources, requiring a port to 
Qt5.  There was not actually much porting to be done, apart from setting the 
correct QStandardPaths location for the mimeapps.list file, but I've also 
tidied up and removed a lot of the old cruft and unused code.


Diffs
-

  settings/konqhtml/generalopts.cpp facec057 

Diff: https://git.reviewboard.kde.org/r/129518/diff/


Testing
---

Built Konqueror with these changes, checked correct operation of the Settings - 
Configure Konqueror - General dialogue and the setting of the preferred 
association for the HTML MIME types.


Thanks,

Jonathan Marten