Re: KDE inclusion
Am Donnerstag, 11. Januar 2018, 12:22:49 CET schrieb Luigi Toscano: > Kevin Funk ha scritto: > > On Tuesday, 9 January 2018 21:06:36 CET Michael Reeves wrote: > >> I have a version of kdiff3 that I ported to kf5. I like to what build > >> requirements kf5 as a whole has. Also what would be the process for being > >> considered for inclusion in kde? > > > > Heya, > > > > Note: kdiff3 right now is hosted & developed on SourceForge. > > The official one, yes, but see below. > > > I'd love to see kdiff3 being adopted by KDE again (it former was KDE > > extragear if I understood correctly). kdiff3 is a super useful tool -- > > and right now development has stalled a bit. > > > > Talked to Joachim (the original author) a few weeks ago, where he stated > > he > > just doesn't have the time maintaining it anymore, really. I've CC'd > > Joachim so he can tell us whether he's okay with having kdiff3 developed > > further under the KDE umbrella. > > > > I don't really know the process of having it integrated either. I'll leave > > that to others. > > We also have this: > https://cgit.kde.org/scratch/thomasfischer/kdiff3.git/log/?h=kf5 > (see https://t-fischer.dreamwidth.org/4327.html) > And scripty also tracks this one: https://websvn.kde.org/trunk/extragear/utils/kdiff3/ -- Burkhard Lück
Re: Review Request 128659: Proofread/update kfind docbooks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128659/ --- (Updated Nov. 5, 2016, 10:01 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Kai Uwe Broulik, and David Faure. Repository: kde-baseapps Description --- handbook remove ENTITY kappname man page remove "a colon separated path", this does not work for me in kf5 master compiled from sources add kf5options + qt5options to refsect1 "See Also" Diffs - kfind/docs/index.docbook 5b84f68 kfind/docs/man-kfind.1.docbook 31222ea Diff: https://git.reviewboard.kde.org/r/128659/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: announcement: Kwave is in kdereview
Am Sonntag, 9. Oktober 2016, 18:05:29 CEST schrieb Friedrich W. H. Kossebau: > What breaks exactly? https://api.kde.org/frameworks/ki18n/html/prg_guide.html#link_noncode: KXmlGui (.rc) files Since .rc files are interpreted at runtime, the translation domain connection is established simply by adding the translationDomain attribute to the top element: 1 2 3 ... If the .rc file belongs to application rather than library source, it is not necessary to set translationDomain. If not set, translations will be looked up in the domain set with KLocalizedString::setApplicationDomain call in the code. -- Burkhard Lück
Re: announcement: Kwave is in kdereview
Am Samstag, 8. Oktober 2016, 09:39:24 CEST schrieb Thomas Eschenbacher: > Hello, > > according to > https://community.kde.org/Policies/Application_Lifecycle#Stage_2:_Stable > I hereby announce the move of Kwave to "kdereview", on it's way to > "kdemultimedia". > I have three untranslated strings in the GUI of the main window in the fully translated locale x-test + de: the menu item "Record" "Record" + "Enter Command" in the Settings menu -- Burkhard Lück
Re: announcement: Kwave is in kdereview
Am Sonntag, 9. Oktober 2016, 11:44:16 CEST schrieb David Faure: > AFAIK KLocalizedString::setApplicationDomain isn't necessary, you should? > instead define the domain as a -D flag during compilation, but I'm no expert > on? that, check the wiki. https://api.kde.org/frameworks/ki18n/html/prg_guide.html#link_prog says: Connecting to Catalogs in Application Code All *i18n* calls in an application can be connected to a single domain by calling the static KLocalizedString::setApplicationDomain method with the domain as the argument: Therefore KLocalizedString::setApplicationDomain seems to be correct -- Burkhard Lück
Re: Review Request 128684: Proofread + update khtml-general kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128684/ --- (Updated Sept. 18, 2016, 6:05 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update comment webkit code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/khtml-general/index.docbook 1b9c80e Diff: https://git.reviewboard.kde.org/r/128684/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128803: Import konqueror kcm docbooks from kde-runtime master
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128803/ --- (Updated Sept. 18, 2016, 6:04 nachm.) Status -- This change has been discarded. Review request for KDE Base Apps and David Faure. Repository: kde-baseapps Description --- doc/kcontrol/bookmarks/ doc/kcontrol/filemanager/ doc/kcontrol/history/ doc/kcontrol/kcmcss/ doc/kcontrol/khtml-adblock/ doc/kcontrol/khtml-behavior/ doc/kcontrol/khtml-general/ doc/kcontrol/khtml-java-js/ doc/kcontrol/khtml-plugins/ doc/kcontrol/performance/ splitted from kde-runtime master using https://github.com/ajdruff/git-splits Not included in build so far, the CMakeLists.txt and the dtd have to be adapted to kf5 If this is pushed to kde-baseapps master, the kcontrol subdirs in plasma-desktop have to be removed, see https://git.reviewboard.kde.org/r/128685/ Diffs - doc/kcontrol/bookmarks/CMakeLists.txt PRE-CREATION doc/kcontrol/bookmarks/index.docbook PRE-CREATION doc/kcontrol/filemanager/CMakeLists.txt PRE-CREATION doc/kcontrol/filemanager/index.docbook PRE-CREATION doc/kcontrol/history/CMakeLists.txt PRE-CREATION doc/kcontrol/history/index.docbook PRE-CREATION doc/kcontrol/kcmcss/CMakeLists.txt PRE-CREATION doc/kcontrol/kcmcss/index.docbook PRE-CREATION doc/kcontrol/khtml-adblock/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-adblock/index.docbook PRE-CREATION doc/kcontrol/khtml-behavior/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-behavior/index.docbook PRE-CREATION doc/kcontrol/khtml-general/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-general/index.docbook PRE-CREATION doc/kcontrol/khtml-java-js/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-java-js/index.docbook PRE-CREATION doc/kcontrol/khtml-plugins/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-plugins/index.docbook PRE-CREATION doc/kcontrol/performance/CMakeLists.txt PRE-CREATION doc/kcontrol/performance/index.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128803/diff/ Testing --- history looks good, see git-log-doc-kcontrol.txt File Attachments git-log-doc-kcontrol.txt https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/fd446511-8b66-48c3-ab4f-97086d79f090__git-log-doc-kcontrol.txt Thanks, Burkhard Lück
Re: Review Request 128737: Update second part of konqueror docbook to 16.12
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128737/ --- (Updated Sept. 18, 2016, 8 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Base Apps and David Faure. Changes --- Submitted with commit 14f35a59700d328c9b23429d25a4ec6f1b7c88b9 by Burkhard Lück to branch master. Repository: kde-baseapps Description --- proofread + update replace common menu items with link to fundamentals Diffs - doc/konqueror/index.docbook 00bfdfd Diff: https://git.reviewboard.kde.org/r/128737/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128684: Proofread + update khtml-general kcm docbook
> On Aug. 16, 2016, 7:05 vorm., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 51 > > <https://git.reviewboard.kde.org/r/128684/diff/1/?file=474210#file474210line51> > > > > Well, qt5-webkit and kwebkitpart do still exist. They're just not > > really maintained (but then again that is a problem for konqueror itself as > > well, especially due to being built on top of deprecated web engines...). > > (I hate this situation.) > > Burkhard Lück wrote: > Thanks to your hints I just detected that kwebkitpart has a frameworks > branch. Building this branch I get the webkit engine back in konqueror kf5. > But kwebkitpart frameworks branch is unreleased, stable/released branch > is 1.3 kde4 based, master as well. > So should I update the docbooks for konqueror with kwebkitpart/frameworks > branch? > > Burkhard Lück wrote: > > So should I update the docbooks for konqueror with > kwebkitpart/frameworks branch? > > kde-doc-english: please comment/answer my question > thanks > > Yuri Chornoivan wrote: > +1 > > Luigi Toscano wrote: > The kwerbkitpart is under construction, and there may be a qwebengine > part instead or in addition. I would leave that part commented with a > reminder to revisit it before the documentation freeze. > > Burkhard Lück wrote: > Let's do it the other way round, leave kwebkitpart for now and revisit > before documentation freeze. > That we we get the konqueror except the kwebkit related stuff immediately > up to date and have minimal changes for now. in https://bugs.kde.org/show_bug.cgi?id=368705#c1 Christoph says: "Konqueror and the WebKit part will be released as Qt5 versions starting with KDE Applications 16.12 release." so we should stick with the kwebkitpart for now - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128684/#review98408 --- On Aug. 15, 2016, 11:40 vorm., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128684/ > --- > > (Updated Aug. 15, 2016, 11:40 vorm.) > > > Review request for Documentation, KDE Base Apps, Plasma, and David Faure. > > > Repository: plasma-desktop > > > Description > --- > > proofread + update > comment webkit > > code in kde-baseapps - docbook in plasma-desktop? > > > Diffs > - > > doc/kcontrol/khtml-general/index.docbook 1b9c80e > > Diff: https://git.reviewboard.kde.org/r/128684/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Re: Review Request 128685: Proofread + update performance kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/ --- (Updated Sept. 14, 2016, 2:25 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update remove obsolete comment code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/performance/index.docbook 5ac5055 Diff: https://git.reviewboard.kde.org/r/128685/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128684: Proofread + update khtml-general kcm docbook
> On Aug. 16, 2016, 7:05 vorm., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 51 > > <https://git.reviewboard.kde.org/r/128684/diff/1/?file=474210#file474210line51> > > > > Well, qt5-webkit and kwebkitpart do still exist. They're just not > > really maintained (but then again that is a problem for konqueror itself as > > well, especially due to being built on top of deprecated web engines...). > > (I hate this situation.) > > Burkhard Lück wrote: > Thanks to your hints I just detected that kwebkitpart has a frameworks > branch. Building this branch I get the webkit engine back in konqueror kf5. > But kwebkitpart frameworks branch is unreleased, stable/released branch > is 1.3 kde4 based, master as well. > So should I update the docbooks for konqueror with kwebkitpart/frameworks > branch? > > Burkhard Lück wrote: > > So should I update the docbooks for konqueror with > kwebkitpart/frameworks branch? > > kde-doc-english: please comment/answer my question > thanks > > Yuri Chornoivan wrote: > +1 > > Luigi Toscano wrote: > The kwerbkitpart is under construction, and there may be a qwebengine > part instead or in addition. I would leave that part commented with a > reminder to revisit it before the documentation freeze. Let's do it the other way round, leave kwebkitpart for now and revisit before documentation freeze. That we we get the konqueror except the kwebkit related stuff immediately up to date and have minimal changes for now. - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128684/#review98408 --- On Aug. 15, 2016, 11:40 vorm., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128684/ > --- > > (Updated Aug. 15, 2016, 11:40 vorm.) > > > Review request for Documentation, KDE Base Apps, Plasma, and David Faure. > > > Repository: plasma-desktop > > > Description > --- > > proofread + update > comment webkit > > code in kde-baseapps - docbook in plasma-desktop? > > > Diffs > ----- > > doc/kcontrol/khtml-general/index.docbook 1b9c80e > > Diff: https://git.reviewboard.kde.org/r/128684/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Re: Review Request 128693: Proofread + update khtml-java-js kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128693/ --- (Updated Sept. 14, 2016, 1:49 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update remove unused entity nsplugins-kcontrol add debug info use entity javascript code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/khtml-java-js/index.docbook d707fcb Diff: https://git.reviewboard.kde.org/r/128693/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128690: Proofread + update khtml-adblock kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128690/ --- (Updated Sept. 14, 2016, 1:48 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update remove unused entity code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/khtml-adblock/index.docbook 1868626 Diff: https://git.reviewboard.kde.org/r/128690/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128691: Proofread + update history kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128691/ --- (Updated Sept. 14, 2016, 1:49 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/history/index.docbook 27f805c Diff: https://git.reviewboard.kde.org/r/128691/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128688: Proofread + update khtml-behavior kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128688/ --- (Updated Sept. 14, 2016, 1:48 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update remove unused entity code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/khtml-behavior/index.docbook ca39472 Diff: https://git.reviewboard.kde.org/r/128688/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128687: Proofread + update filemanager kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128687/ --- (Updated Sept. 14, 2016, 1:47 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/filemanager/index.docbook 2ac80b6 Diff: https://git.reviewboard.kde.org/r/128687/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128686: Proofread + update bookmarks kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128686/ --- (Updated Sept. 14, 2016, 1:46 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/bookmarks/index.docbook 173222c Diff: https://git.reviewboard.kde.org/r/128686/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Splitting kde-baseapps?
Hi, what is the future of the kde-basapps repo? It consists of: 1) Konqueror code + docbooks in subdirs doc, konq-plugins, konqueror + lib 2) kfind code + docbook in subdir kfind 3) kdepasswd (don't we have already a similar dialog in frameworks/ kwidgetaddons?) 4) kdialog 5) keditbookmarks (documentation is part of konqueror docbooks) See also https://git.reviewboard.kde.org/r/128803/ -- Burkhard Lück
Re: Review Request 128659: Proofread/update kfind docbooks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128659/#review99078 --- ping? - Burkhard Lück On Aug. 11, 2016, 7:59 nachm., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128659/ > --- > > (Updated Aug. 11, 2016, 7:59 nachm.) > > > Review request for Documentation, KDE Base Apps, Kai Uwe Broulik, and David > Faure. > > > Repository: kde-baseapps > > > Description > --- > > handbook > remove ENTITY kappname > man page > remove "a colon separated path", this does not work for me in kf5 master > compiled from sources > add kf5options + qt5options to refsect1 "See Also" > > > Diffs > - > > kfind/docs/index.docbook 5b84f68 > kfind/docs/man-kfind.1.docbook 31222ea > > Diff: https://git.reviewboard.kde.org/r/128659/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Re: Review Request 128737: Update second part of konqueror docbook to 16.12
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128737/#review98808 --- Please review, thanks - Burkhard Lück On Aug. 23, 2016, 4:35 nachm., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128737/ > --- > > (Updated Aug. 23, 2016, 4:35 nachm.) > > > Review request for Documentation, KDE Base Apps and David Faure. > > > Repository: kde-baseapps > > > Description > --- > > proofread + update > replace common menu items with link to fundamentals > > > Diffs > - > > doc/konqueror/index.docbook 00bfdfd > > Diff: https://git.reviewboard.kde.org/r/128737/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Re: Review Request 128685: Proofread + update performance kcm docbook
> On Aug. 16, 2016, 7:11 vorm., David Faure wrote: > > Can you move it to kde-baseapps, along with any other konqueror-related > > docbook? > > Burkhard Lück wrote: > move khtml-behavior, bookmarks, html-java-js, khtml-adblock, history, > performance, kcmcss, filemanager, khtml-general preserving history > from plasma-desktop to kde-baseapps does not make sense, because these > docbooks have no history in plasma-desktop besides the initial commit > > https://quickgit.kde.org/?p=plasma-desktop.git=commit=d64d589db1291fc61935585019f492943ce0032a > and the history before this commit is hidden and not easy to access. > > From my pov these docbook dirs should be copied from kde-runtime (with > history) into the directory kde-runtime/doc/kcontrol/ > and these dirs should be deleted afterwards in plasma-desktop > > Burkhard Lück wrote: > - From my pov these docbook dirs should be copied from kde-runtime (with > history) into the directory kde-runtime/doc/kcontrol/ > - and these dirs should be deleted afterwards in plasma-desktop > > + From my pov these docbook dirs should be copied from kde-runtime (with > history) into the directory kde-baseapps/doc/kcontrol/ > + and these dirs should be deleted afterwards in plasma-desktop see https://git.reviewboard.kde.org/r/128803/ - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/#review98410 --- On Aug. 15, 2016, 11:48 vorm., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128685/ > --- > > (Updated Aug. 15, 2016, 11:48 vorm.) > > > Review request for Documentation, KDE Base Apps, Plasma, and David Faure. > > > Repository: plasma-desktop > > > Description > --- > > proofread + update > remove obsolete comment > > code in kde-baseapps - docbook in plasma-desktop? > > > Diffs > - > > doc/kcontrol/performance/index.docbook 5ac5055 > > Diff: https://git.reviewboard.kde.org/r/128685/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Review Request 128803: Import konqueror kcm docbooks from kde-runtime master
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128803/ --- Review request for KDE Base Apps and David Faure. Repository: kde-baseapps Description --- doc/kcontrol/bookmarks/ doc/kcontrol/filemanager/ doc/kcontrol/history/ doc/kcontrol/kcmcss/ doc/kcontrol/khtml-adblock/ doc/kcontrol/khtml-behavior/ doc/kcontrol/khtml-general/ doc/kcontrol/khtml-java-js/ doc/kcontrol/khtml-plugins/ doc/kcontrol/performance/ splitted from kde-runtime master using https://github.com/ajdruff/git-splits Not included in build so far, the CMakeLists.txt and the dtd have to be adapted to kf5 If this is pushed to kde-baseapps master, the kcontrol subdirs in plasma-desktop have to be removed, see https://git.reviewboard.kde.org/r/128685/ Diffs - doc/kcontrol/bookmarks/CMakeLists.txt PRE-CREATION doc/kcontrol/bookmarks/index.docbook PRE-CREATION doc/kcontrol/filemanager/CMakeLists.txt PRE-CREATION doc/kcontrol/filemanager/index.docbook PRE-CREATION doc/kcontrol/history/CMakeLists.txt PRE-CREATION doc/kcontrol/history/index.docbook PRE-CREATION doc/kcontrol/kcmcss/CMakeLists.txt PRE-CREATION doc/kcontrol/kcmcss/index.docbook PRE-CREATION doc/kcontrol/khtml-adblock/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-adblock/index.docbook PRE-CREATION doc/kcontrol/khtml-behavior/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-behavior/index.docbook PRE-CREATION doc/kcontrol/khtml-general/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-general/index.docbook PRE-CREATION doc/kcontrol/khtml-java-js/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-java-js/index.docbook PRE-CREATION doc/kcontrol/khtml-plugins/CMakeLists.txt PRE-CREATION doc/kcontrol/khtml-plugins/index.docbook PRE-CREATION doc/kcontrol/performance/CMakeLists.txt PRE-CREATION doc/kcontrol/performance/index.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128803/diff/ Testing --- history looks good, see git-log-doc-kcontrol.txt File Attachments git-log-doc-kcontrol.txt https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/fd446511-8b66-48c3-ab4f-97086d79f090__git-log-doc-kcontrol.txt Thanks, Burkhard Lück
Re: Review Request 128677: Proofread/update second part of konqueror docbooks for kf5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128677/ --- (Updated Aug. 24, 2016, 12:31 nachm.) Status -- This change has been discarded. Review request for Documentation, KDE Base Apps and David Faure. Repository: kde-baseapps Description --- Proofread + update remove webkit, not in kf5 fix paths remove obsolete comments replace common menu items wirh links to fundamentals use all keyboard entities defined in kdoctools Diffs - doc/konqueror/index.docbook 52fcafa Diff: https://git.reviewboard.kde.org/r/128677/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128737: Update second part of konqueror docbook to 16.12
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128737/ --- (Updated Aug. 23, 2016, 4:35 nachm.) Review request for Documentation, KDE Base Apps and David Faure. Changes --- adding an icon for a konqueror profile works also with Add to Desktop if the desktop has a folder layout Repository: kde-baseapps Description --- proofread + update replace common menu items with link to fundamentals Diffs (updated) - doc/konqueror/index.docbook 00bfdfd Diff: https://git.reviewboard.kde.org/r/128737/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128737: Update second part of konqueror docbook to 16.12
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128737/ --- (Updated Aug. 23, 2016, 6:13 vorm.) Review request for Documentation, KDE Base Apps and David Faure. Changes --- describe how to add a custom profile to a Folder View Zoom actions for WebKit browser view Repository: kde-baseapps Description --- proofread + update replace common menu items with link to fundamentals Diffs (updated) - doc/konqueror/index.docbook 00bfdfd Diff: https://git.reviewboard.kde.org/r/128737/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128659: Proofread/update kfind docbooks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128659/#review98559 --- Please review, thanks - Burkhard Lück On Aug. 11, 2016, 7:59 nachm., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128659/ > --- > > (Updated Aug. 11, 2016, 7:59 nachm.) > > > Review request for Documentation, KDE Base Apps, Kai Uwe Broulik, and David > Faure. > > > Repository: kde-baseapps > > > Description > --- > > handbook > remove ENTITY kappname > man page > remove "a colon separated path", this does not work for me in kf5 master > compiled from sources > add kf5options + qt5options to refsect1 "See Also" > > > Diffs > - > > kfind/docs/index.docbook 5b84f68 > kfind/docs/man-kfind.1.docbook 31222ea > > Diff: https://git.reviewboard.kde.org/r/128659/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Re: Review Request 128685: Proofread + update performance kcm docbook
> On Aug. 16, 2016, 7:11 vorm., David Faure wrote: > > Can you move it to kde-baseapps, along with any other konqueror-related > > docbook? > > Burkhard Lück wrote: > move khtml-behavior, bookmarks, html-java-js, khtml-adblock, history, > performance, kcmcss, filemanager, khtml-general preserving history > from plasma-desktop to kde-baseapps does not make sense, because these > docbooks have no history in plasma-desktop besides the initial commit > > https://quickgit.kde.org/?p=plasma-desktop.git=commit=d64d589db1291fc61935585019f492943ce0032a > and the history before this commit is hidden and not easy to access. > > From my pov these docbook dirs should be copied from kde-runtime (with > history) into the directory kde-runtime/doc/kcontrol/ > and these dirs should be deleted afterwards in plasma-desktop - From my pov these docbook dirs should be copied from kde-runtime (with history) into the directory kde-runtime/doc/kcontrol/ - and these dirs should be deleted afterwards in plasma-desktop + From my pov these docbook dirs should be copied from kde-runtime (with history) into the directory kde-baseapps/doc/kcontrol/ + and these dirs should be deleted afterwards in plasma-desktop - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/#review98410 ------- On Aug. 15, 2016, 11:48 vorm., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128685/ > --- > > (Updated Aug. 15, 2016, 11:48 vorm.) > > > Review request for Documentation, KDE Base Apps, Plasma, and David Faure. > > > Repository: plasma-desktop > > > Description > --- > > proofread + update > remove obsolete comment > > code in kde-baseapps - docbook in plasma-desktop? > > > Diffs > - > > doc/kcontrol/performance/index.docbook 5ac5055 > > Diff: https://git.reviewboard.kde.org/r/128685/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Re: Review Request 128685: Proofread + update performance kcm docbook
> On Aug. 16, 2016, 7:11 vorm., David Faure wrote: > > Can you move it to kde-baseapps, along with any other konqueror-related > > docbook? move khtml-behavior, bookmarks, html-java-js, khtml-adblock, history, performance, kcmcss, filemanager, khtml-general preserving history from plasma-desktop to kde-baseapps does not make sense, because these docbooks have no history in plasma-desktop besides the initial commit https://quickgit.kde.org/?p=plasma-desktop.git=commit=d64d589db1291fc61935585019f492943ce0032a and the history before this commit is hidden and not easy to access. >From my pov these docbook dirs should be copied from kde-runtime (with >history) into the directory kde-runtime/doc/kcontrol/ and these dirs should be deleted afterwards in plasma-desktop - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/#review98410 --- On Aug. 15, 2016, 11:48 vorm., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128685/ > --- > > (Updated Aug. 15, 2016, 11:48 vorm.) > > > Review request for Documentation, KDE Base Apps, Plasma, and David Faure. > > > Repository: plasma-desktop > > > Description > --- > > proofread + update > remove obsolete comment > > code in kde-baseapps - docbook in plasma-desktop? > > > Diffs > - > > doc/kcontrol/performance/index.docbook 5ac5055 > > Diff: https://git.reviewboard.kde.org/r/128685/diff/ > > > Testing > --- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
Review Request 128693: Proofread + update khtml-java-js kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128693/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update remove unused entity nsplugins-kcontrol add debug info use entity javascript code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/khtml-java-js/index.docbook d707fcb Diff: https://git.reviewboard.kde.org/r/128693/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128691: Proofread + update history kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128691/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/history/index.docbook 27f805c Diff: https://git.reviewboard.kde.org/r/128691/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128690: Proofread + update khtml-adblock kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128690/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update remove unused entity code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/khtml-adblock/index.docbook 1868626 Diff: https://git.reviewboard.kde.org/r/128690/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128688: Proofread + update khtml-behavior kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128688/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update remove unused entity code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/khtml-behavior/index.docbook ca39472 Diff: https://git.reviewboard.kde.org/r/128688/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128687: Proofread + update filemanager kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128687/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/filemanager/index.docbook 2ac80b6 Diff: https://git.reviewboard.kde.org/r/128687/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128686: Proofread + update bookmarks kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128686/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/bookmarks/index.docbook 173222c Diff: https://git.reviewboard.kde.org/r/128686/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128685: Proofread + update performance kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update remove obsolete comment code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/performance/index.docbook 5ac5055 Diff: https://git.reviewboard.kde.org/r/128685/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128684: Proofread + update khtml-general kcm docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128684/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure. Repository: plasma-desktop Description --- proofread + update comment webkit code in kde-baseapps - docbook in plasma-desktop? Diffs - doc/kcontrol/khtml-general/index.docbook 1b9c80e Diff: https://git.reviewboard.kde.org/r/128684/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128677: Proofread/update second part of konqueror docbooks for kf5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128677/ --- Review request for Documentation, KDE Base Apps and David Faure. Repository: kde-baseapps Description --- Proofread + update remove webkit, not in kf5 fix paths remove obsolete comments replace common menu items wirh links to fundamentals use all keyboard entities defined in kdoctools Diffs - doc/konqueror/index.docbook 52fcafa Diff: https://git.reviewboard.kde.org/r/128677/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128663: Proofread + update Konqueror docbook chapters up to bookmarks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128663/ --- (Updated Aug. 14, 2016, 7:09 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Base Apps and David Faure. Changes --- Submitted with commit 146e958551d39706298fc010db8323fa43e71a5e by Burkhard Lück to branch master. Repository: kde-baseapps Description --- proofread + update remove entity kappname + package, no longer used bump date + releaseinfo remove kde sc remove commented lines replace some keys with entities (up, down, left, right etc.) replace info about webshortcuts + useragent with links to systemsettings modules replace kde ftp with l10n ftp (tosky: ok?) comment sect1 portnumbers, is this still usefull? new screenshots, not uploaded so far, want me to do that? Diffs - doc/konqueror/index.docbook a9e40ad Diff: https://git.reviewboard.kde.org/r/128663/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Review Request 128663: Proofread + update Konqueror docbook chapters up to bookmarks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128663/ --- Review request for Documentation, KDE Base Apps and David Faure. Repository: kde-baseapps Description --- proofread + update remove entity kappname + package, no longer used bump date + releaseinfo remove kde sc remove commented lines replace some keys with entities (up, down, left, right etc.) replace info about webshortcuts + useragent with links to systemsettings modules replace kde ftp with l10n ftp (tosky: ok?) comment sect1 portnumbers, is this still usefull? new screenshots, not uploaded so far, want me to do that? Diffs - doc/konqueror/index.docbook a9e40ad Diff: https://git.reviewboard.kde.org/r/128663/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128659: Proofread/update kfind docbooks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128659/#review98319
---
Let me explain why I removed "a colon separated path", and what does not work
for me starting kfind in konsole:
1) "kfind /tmp:/home" -> Look in: prefilled with "file:///tmp:/home"
2) "kfind +/tmp" -> Look in: prefilled with
"file:///path/to/startdir/+/tmp"
If I start the search 1) or 2) I get a dialog saying "Could not find the
specified folder."
kfind/kfinddlg.cpp-208- else if (errorCode == KIO::ERR_DOES_NOT_EXIST)
kfind/kfinddlg.cpp-209- {
kfind/kfinddlg.cpp-210- setStatusMsg(i18n("Error."));
kfind/kfinddlg.cpp:211: KMessageBox::sorry( this, i18n("Could not find the
specified folder."));
- Burkhard Lück
On Aug. 11, 2016, 7:59 nachm., Burkhard Lück wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128659/
> ---
>
> (Updated Aug. 11, 2016, 7:59 nachm.)
>
>
> Review request for Documentation, KDE Base Apps, Kai Uwe Broulik, and David
> Faure.
>
>
> Repository: kde-baseapps
>
>
> Description
> ---
>
> handbook
> remove ENTITY kappname
> man page
> remove "a colon separated path", this does not work for me in kf5 master
> compiled from sources
> add kf5options + qt5options to refsect1 "See Also"
>
>
> Diffs
> -
>
> kfind/docs/index.docbook 5b84f68
> kfind/docs/man-kfind.1.docbook 31222ea
>
> Diff: https://git.reviewboard.kde.org/r/128659/diff/
>
>
> Testing
> ---
>
> passes checkXML5
>
>
> Thanks,
>
> Burkhard Lück
>
>
Review Request 128659: Proofread/update kfind docbooks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128659/ --- Review request for Documentation, KDE Base Apps and David Faure. Repository: kde-baseapps Description --- handbook remove ENTITY kappname man page remove "a colon separated path", this does not work for me in kf5 master compiled from sources add kf5options + qt5options to refsect1 "See Also" Diffs - kfind/docs/index.docbook 5b84f68 kfind/docs/man-kfind.1.docbook 31222ea Diff: https://git.reviewboard.kde.org/r/128659/diff/ Testing --- passes checkXML5 Thanks, Burkhard Lück
Re: Review Request 128637: Remove obsolete kdepasswd docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128637/ --- (Updated Aug. 11, 2016, 1:37 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Base Apps and David Faure. Changes --- Submitted with commit 5874a978e0857768dcecc2b3b3da7413f6cdea34 by Burkhard Lück to branch master. Repository: kde-baseapps Description --- this docbook was for the "Password and User Account" KCM in kde4 code for the KCM was removed in the frameworks branch, so the docbook is no longer used Diffs - kdepasswd/CMakeLists.txt 7a62270 kdepasswd/docs/CMakeLists.txt 8cf55fb kdepasswd/docs/index.docbook 557f458 kdepasswd/docs/password.png 90bc47e Diff: https://git.reviewboard.kde.org/r/128637/diff/ Testing --- builds Thanks, Burkhard Lück
Review Request 128637: Remove obsolete kdepasswd docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128637/ --- Review request for Documentation, KDE Base Apps and David Faure. Repository: kde-baseapps Description --- this docbook was for the "Password and User Account" KCM in kde4 code for the KCM was removed in the frameworks branch, so the docbook is no longer used Diffs - kdepasswd/CMakeLists.txt 7a62270 kdepasswd/docs/CMakeLists.txt 8cf55fb kdepasswd/docs/index.docbook 557f458 kdepasswd/docs/password.png 90bc47e Diff: https://git.reviewboard.kde.org/r/128637/diff/ Testing --- builds Thanks, Burkhard Lück
Re: kirigami moved in kdereview
Am Donnerstag, 28. Juli 2016, 16:44:57 CEST schrieb Marco Martin: > On Sun, Jul 24, 2016 at 7:51 PM, Burkhard Lück <lu...@hube-lueck.de> wrote: > > Am Sonntag, 24. Juli 2016, 19:32:54 CEST schrieb Marco Martin: > >> Hi all, > >> the kirigami project has been moved to kdereview. > > > > I see a message extraction into a catalog named libkirigamiplugin with two > > messages, but apparently this catalog is not used in kirigami? > > how would translations be done if the Qt translation system is used > instead? I see tier1 frameworks use that, but they don't seem to have > extraction scripts or anything.. > wcgrep EXTRACT_TR_STRINGS frameworks: 17 hits Extraction see https://techbase.kde.org/Development/Tutorials/Localization/ i18n_Build_Systems#Writing_a_Messages.sh_script Loading Qt translation: https://techbase.kde.org/Development/Tutorials/Localization/ i18n_Build_Systems#Qt5-only:_Code_using_Qt_translation_system -- Burkhard Lück
Re: kirigami moved in kdereview
Am Sonntag, 24. Juli 2016, 19:32:54 CEST schrieb Marco Martin: > Hi all, > the kirigami project has been moved to kdereview. > I see a message extraction into a catalog named libkirigamiplugin with two messages, but apparently this catalog is not used in kirigami? -- Burkhard Lück
Re: web server for appstream metadata screenshots
Am Mittwoch, 8. Juni 2016, 12:45:13 CEST schrieb Nicolás Alvarez: > 2016-06-08 8:33 GMT-03:00 Friedrich W. H. Kossebau <kosse...@kde.org>: > > Am Mittwoch, 8. Juni 2016, 13:10:04 CEST schrieb Sebastian Kügler: > >> Hey, > >> > >> I've been adding appstream metadata to one of the apps I maintain, among > >> that are also screenshots, in the form of a URL. That means that I have > >> to > >> put the screenshots on a webserver. > >> > >> Do we already have a canonical location for these screenshots? If not, > >> let's create one before we get people hosting them on imgur, their > >> private webserver or their router-behind-a-dsl-line. :) > > > > Good idea, also when it comes to long-term availability of referenced > > images> > > :) > > > > It might make sense to reuse/share the screenshots with the ones used for > > the KDE app catalog we have at kde.org/applications/. For consistency and > > for efficiency. > > > > Not sure though what a stable url would be like, given people planning to > > rework kde.org (and thus those app catalog pages), so perhaps relying on > > the current screenshot urls used by kde.org/applications is not perfect. > The screenshots on kde.org/applications are stored in SVN and they are > the main reason why I couldn't migrate that website to Git. I would > prefer if you don't add even more there... www/sites/www/screenshots (svn) has 176 pngs websites/edu-kde-org/ (git) has 1287 pngs master kf5 / doc[s] (git) folders have 2079 pngs master kde4 / doc[s] (git) folders have 1702 pngs I do not understand why the 176 pngs in www/sites/www/screenshots are a problem for migration to git -- Burkhard Lück
Re: Cervisia?
Am Sonntag, 5. Juni 2016, 14:22:45 CEST schrieb Nicolás Alvarez:
> > El 5 jun 2016, a las 09:08, Martin Koller <kol...@aon.at> escribió:
> >> On Sunday 05 June 2016 09:14:42 Burkhard Lück wrote:
> >>
> >> Some i18n issues:
> >>
> >> It is a QApplication so you have to add the translators tab manually with
> >> aboutData.setTranslator
> >
> > ok. what shall I write there (names, emails ?)
> >
> > Isn't that a limited approach to name the translators in the sourcecode,
> > since every new translation added will need a source change ?
>
> No; you use something like i18n("TRANSLATOR NAME") (I don't remember the
> exact string), so that the name comes from the translation itself.
aboutData.setTranslator(i18nc("NAME OF TRANSLATORS", "Your names"),
i18nc("EMAIL OF TRANSLATORS", "Your emails"));
but not necessary here as Albert pointed out.
Thanks
--
Burkhard Lück
Re: Cervisia?
Am Samstag, 4. Juni 2016, 22:45:49 CEST schrieb Martin Koller:
> On Friday 16 October 2015 06:53:19 Jeremy Whiting wrote:
> > Awesome! Keep it up. Porting to Qt5/KF5 can happen on a branch and be
> > done a small bit at a time if you like. There are also some scripts in
> > kdesdk/kde-dev-scripts/kf5 that can help with the trivial changes.
> > Most are executed like find -iname *.cpp | xargs scriptname, but if
> > not they will say in a comment at the top of the script how to execute
> > them.
> >
> > On Thu, Oct 15, 2015 at 8:02 PM, Martin Koller <kol...@aon.at> wrote:
> > > On Thursday 15 October 2015 15:49:32 Jeremy Whiting wrote:
> > >> Michael, Martin,
> > >>
> > >> Any progress on the cervisia front? Is there anything I can do to help?
> > >
> > > yes, a lot of progress!
> > > We have already ported away from Qt3/KDE3 support classes.
> > > This is already in master and I'm testing it by using it on a daily
> > > basis.
> > >
> > > The next step would now be to start the port to KF5 - this has not been
> > > started yet.
> Just for your information: I have now completed the KF5 port and master now
> holds this version
So you want Scripty to track master to trunk_kf5 and Applications/16.04 to
l10n stable, right?
Some i18n issues:
It is a QApplication so you have to add the translators tab manually with
aboutData.setTranslator
no setApplicationDomain("cervisia"), so no translations of KXmlGui (.rc) files
and KConfigXT (.kcfg) files, see https://api.kde.org/frameworks/ki18n/html/
prg_guide.html
Thanks
--
Burkhard Lück
Re: [kde-doc-english] The new data dirs and kf5 docs
Am Donnerstag, 20. August 2015, 13:57:19 schrieb Luigi Toscano:
On Thursday 20 of August 2015 14:46:45 Yuri Chornoivan wrote:
Hi,
Hi,
CC: kde-core-devel@ for some help (see below).
As it was pointed by Burkhard [1], the paths in kf5 docs should be
updated/fixed to the new configuration.
The list is rather big now:
fundamentals/config.docbook
korganizer
knotes
kalarm
kmail
konversation
kate/plugins.docbook
kgeography
kwordquiz
kstars/faq.docbook
kstars/config.docbook
kstars/install.docbook
khangman
killbots
ktuberling/technical-reference.docbook
okteta
tellico/faqs.docbook
tellico/fundamentals.docbook
tellico/configuration.docbook
kile/inedx.docbook
kile/usermenu.docbook
kile/scripting.docbook
However, it is not clear what environment variables can (or should) be
used to help user in finding the proper files. In my KDE 4 environment
some variables are undefined:
[yurchor@localhost uk]$ printenv|grep XDG
XDG_VTNR=1
XDG_SESSION_ID=c1
XDG_MENU_PREFIX=kde-
XDG_CONFIG_DIRS=/etc/xdg:/etc/xdg/kde4
XDG_SEAT=seat0
XDG_DATA_DIRS=/usr/share:/usr/share:/usr/local/share
XDG_RUNTIME_DIR=/run/user/500
XDG_CURRENT_DESKTOP=KDE
As you can see, there are no XDG_DATA_HOME (default $HOME/.local),
XDG_CONFIG_HOME (default $HOME/.config) and XDG_CACHE_HOME.
So,
1. Can anybody confirm that all these variables are defined in Plasma 5
and other modern DEs?
2. Are there any objections about usage something like `echo
${XDG_DATA_DIRS%%:*}` instead of `kde4-config --install data`? What are
the possible shortcomings? Does it work for shells other than BASH?
I don't think it's the proper way. I think the solution is to use qtpaths. I
would ask on the kde-core-devel@ list for more details.
Using qtpaths on kubuntu + fedora kde spin in VMs I have:
qtpaths --paths ConfigLocation
first item is XDG_CONFIG_HOME (default $HOME/.config), other items are
different
in both VMs
qtpaths --paths GenericConfigLocation
same as ConfigLocation
qtpaths --paths GenericDataLocation
first item is XDG_DATA_HOME (default $HOME/.local), other items are different
in both VMs
qtpaths --paths GenericCacheLocation
only one item XDG_CACHE_HOME (default $HOME/.cache)
--
Burkhard Lück
Re: Plasma Applet for Audio Volume for kdereview
Am Donnerstag, 6. August 2015, 00:40:41 schrieb Albert Astals Cid: El Dimecres, 5 d'agost de 2015, a les 12:45:01, Jonathan Riddell va escriure: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview for your reviewing attention. https://projects.kde.org/projects/kdereview/plasma-pa Please check over it and consider if it passes review. Missing or not so good i18n ./src/kcm/package/contents/ui/VolumeSlider.qml:84:text: Math.floor(slider.value / slider.maximumValue * 100.0) + % ./src/kcm/package/contents/ui/VolumeSlider.qml:90:text: 100% ./src/kcm/package/contents/ui/StreamListItem.qml:55: text: PulseObject.client.name + : + PulseObject.name ./src/kcm/package/contents/ui/main.qml:33:ConfigModule.quickHelp: ((UNKNOWN)) ./applet/contents/ui/ListItemBase.qml:208: text: Math.floor(slider.value / slider.maximumValue * 100.0) + % ./applet/contents/ui/ListItemBase.qml:230:text: 100% ./applet/contents/ui/StreamListItemBase.qml:28:label: PulseObject.client.name + : + PulseObject.name Please keep in mind that some langs show the % sign before the value, so it should be i18n(%1%, value) for percent values -- Burkhard Lück
Re: KScreenGenie moved to KDE Review
Am Donnerstag, 2. Juli 2015, 21:47:16 schrieb Boudhayan Gupta: Hi, I've fixed up the UI as per the above mail thread, and pushed to master. Download and test! Copy to clipboard has UI feedback now with a KMessageBox, On 29 June 2015 at 19:51, Boudhayan Gupta m...@baloneygeek.com wrote: Hi Thomas, On 29 June 2015 at 19:30, Thomas Lübking thomas.luebk...@gmail.com wrote: It's because eg. you use the Apply role for Save Exit (would rather be Ok role) and Discard for Discard, while the latter actually acts as Cancel (reject, not reset and exit - there's nothing to reset in the first place) - the different roles cause different positions in different GUI layouts. Right, I'll fix that. I don't understand. Direct mass shooting? Take a shot, click save. Take another shot, click save. Take yet another shot, save once more. Ideally with filename patterns such as bug123456_%n.png ;-) This could be done, yes. I thought the idea was to improve ksnapshot :-P If this does actually only allow you to open the image in another application (the copy to clipboard thing doesn't belong there, we'll have to find a better way to save a button) the button should say so =) Point taken :-) Would you prefer I swap the Clipboard option in the Send To menu with Print, and put Clipboard on the buttons? At least I think the Print button is too prominent regarding its usage frequency (and compared to the need to copy to clipboard) Brainfart: Save... ...to paper ;-) That is actually a brilliant idea. Is that much better than the current solution? I'll boldly claim: yes. IMO the way KSnapshot merges delay and on-click into one spinbox is bad Suboptimal - yes (and not what I meant) Two alternative approaches: [ ] Delay | Capture on click [x] Delay | ( n.m seconds ) (capture on click label and n,m seconds spinbox being in a stacked layout) [ ] Capture on click | (n.m senconds delay) Say I want a shot taken instantly when I click Take New Screenshot. Then I'll have to tick delay, then input 0.0, which makes no sense because there's no delay. The third option doesn't suffer that problem, but visually the current solution IMHO looks better because of the way the input fields are lined up right now. I've made it so that the entire right hand side of the window is dedicated to options and buttons, and the entire left hand side is dedicated to the preview. I don't question that approach at all. What worries me is the grouping *inside* the right hand column, which visually ties the Take new screenshot button to the Capture Options, therefore I'd suggest to combine the two righthand rows and add a horizontal below them, that sets off the Take new screenshot button visually. Point taken. Adding a horizontal bar makes things ugly (I've tried it before). Let me see if I can play with the spacing. The idea is to have the Edit Image (when the basic editor is added) button right next to the Take New Screenshot button. g) pressing Escape should abort the screenshot. It already does. No, doesn't :) To be clear, I do *not* mean QDialog should reject on pressing escape, but when I say Take new screenshot and press escape, I'd like to see the kscreengenie abort taking the screenshot and its window re-appear without new screenshot (and the mousgrab restored in case) - there's no xcb_grab_key in the code, so this cannot work ;-) Ah you meant during the delay / click wait. Yeah, that needs to be added. There's a mini-editor feature planned yes, but I wasn't aware KSnapshot already does it. No, does not - kscreengenie lacks it like ksnapshot does lack it. Go ahead, write the patch! I'd be delighted to add it in then! If the usability team wants larger steps, I guess I have to do it. But personally I've set even 0.2 sec timeouts, although they may have been for special reasons. That's not the problem - even with a single step size of 10 you could still enter 0.1 seconds - it's about how the box reacts to the mousewheel and the spinbox buttons (and atm, going from 0.0 to 5.0 takes 50 wheel clicks) Ah if that's possible I'll set the step size to 1.0 then! Cheers, Thomas Thanks, Boudhayan Some minor nitpicking: Docbook: Afaik Alt+Space is default kf5 shortcut for KRunner, wrong in docbook Shortcut Ctrl+C and Esc missing in docbook Resizable Window, where resizing the window ends up resizing the screenshot in it missing in docbook Functionality: KSnapshot gives feedback about the size of the taken screenshot (tooltip on hoovering the screenshot), that is missing for me. Thanks. -- Burkhard Lück
Re: KScreenGenie moved to KDE Review
Am Samstag, 4. Juli 2015, 15:00:48 schrieb Boudhayan Gupta: This has been fixed in the latest commit I did last night. There's also a new mode which allows you to shoot Transients along with the parent window in the same image. Is this already mentioned in the docbook? -- Burkhard Lück
Re: KPeg (Board Game) moved to KDE Review
Am Donnerstag, 4. Juni 2015, 09:24:02 schrieb Alexander Potashev: 2015-06-03 21:35 GMT+03:00 Burkhard Lück lu...@hube-lueck.de: Am Dienstag, 2. Juni 2015, 00:06:04 schrieb Alexander Potashev: Please configure the i18n branches at [1], I guess i18n trunk branch (KF5) should be set up for extraction from branch master. Then you need to ask i18n maintainers in kde-i18n-doc (already in CC) to move the existing translations into trunk/l10n-kf5 so that we don't have to translate twice. translations moved Burkhard, Thanks for you effort, but it was too early: the project is still set up for extraction to trunk/l10n-kde4, so Scripty will keep recreating templates there. I don't know if anyone but Ronny can fix this configuration. It was my fault, fixed this now. -- Burkhard Lück
Re: KPeg (Board Game) moved to KDE Review
Am Mittwoch, 27. Mai 2015, 05:43:02 schrieb Ronny Yabar Aizcorbe: Can you please test the game and/or provide some feedback and make some comments about the request? You use add_definitions(-DTRANSLATION_DOMAIN=kpeg) in CMakeLists.txt instead of KLocalizedString::setApplicationDomain(kpeg); in a .cpp file for applications. Therefore strings from KXmlGui (.rc) files and KConfigXT (.kcfg) files are not loaded and are untranslated in the GUI. See also http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/prg_guide.html -- Burkhard Lück
Re: desktoptojson and list properties / i18n of JSON files
Am Freitag, 21. November 2014, 00:16:23 schrieben Sie: On Friday 21 November 2014 00:07:53 Milian Wolff wrote: On Thursday 20 November 2014 19:57:54 Burkhard Lück wrote: Am Mittwoch, 19. November 2014, 23:00:57 schrieb Albert Astals Cid: Well, there's two steps about this: 1) Know where the code is that gets the Name/Comment/Description from the json 2) Decide how you want to translate stuff (which may depend on 1) For 2) there's broadly two options: 2.1: Make the .json file have the translations and make sure the code from 1 reads it properly 2.2: Make the translations be in the .po and then make the code from 1 read the english variant and call i18n(englishText) 2.2 is easier (if possible to change the code in 1 to do it) since it does not involve writing back strings to the json file. In kf5 using LANGUAGE=foo kate or LANGUAGE=foo kdevelop (both projects do not install desktop files but use json files generated at build time from desktop files) I see the name/description (from the json files) of plugins in the settings dialog translated in language foo. So apparently in kf5 using json files with translated Name/Description as provided by Kevin's example kdevpatchreview.json I get the proper translations in the GUI. Please check that, you do not need to have language foo installed, just launch kate or kdevelop using x-test/uk/de/fr... as value for foo. OK, that sounds good and that is also what I hoped was already the case. If that works we could treat json and desktop files in the same way from devel/translators pov, because what is the difference between desktop and json files? Name and format, nothing else. I have played a bit with pythons json module using kdevpatchreview.json and the following workflow might be possible: * Find all *json in a repo * generate a template json_reponame.pot with all translatable strings from all json files in the repo (msgid=string, msgctxt=dictkeyofstring+jsonfilename to get unique translations per file or similar) * translators translate these json_reponame.pos and Scripty merges the translation back in to the *.json in the repos similar to merging back translations of xml mimetype translations. *This* is what I was wondering about. If no .desktop exists in the first place and we just create a .json, will translators be able to translate it? Many thanks for looking into that, it sounds as if you don't need more help from my side? If there is anything I can do, please tell me. snip Since Albert just asked me about that: Burkhard, I understood your sentence above such, that you already have code to implement the workflow you outline above. I'll file a RR to implement extraction of translations in json files into scripty's workflow later and add you as reviewer. As first step let's make the extraction working properly, especially with the new json files you have in mind. If that works as expected we can add updating translations in json files. If that is not the case, I'll be happy to implement it for you. If that is the case, can you give me some directions as to where the code resides that does the xml mimetype translations? trunk/l10n-kf5/scripts: update_translations is the main script extract-xml.sh - extract mimetype translation to pot fillxmlfrompo.py - spreading mimetype translations into mimetype xml files, but for json translations the workflow has to be different: 1) load each json into a python dict 2) throw away any translation 3) add all translations from svn po's 4) write python dict to json file create_desktop_files.sh + createdesktopcontext.pl for desktop file translation Also maybe where/how I can run the *.desktop - *.pot conversion manually, such that I can test compare it against my future *.json - *.pot code? I'd say we should use kdevelop or kdevplatform as guinea pig, means you add your future json files (without using them in the code actually) and will check if the templates generated by scripty are ok and adapt the extraction as necessary. Albert? Manually I have used my local kdevplatform build dir for testing: l10n-kf5/scripts$ python createjsoncontext.py $(find ../../extragear/build/kdevelop_kdevplatform/ -name *.json) ../../extragear/build/ /tmp//json_kdevplatform.pot Thanks. -- Burkhard Lück
Re: desktoptojson and list properties / i18n of JSON files
Am Mittwoch, 19. November 2014, 18:46:28 schrieben Sie: On Wednesday 19 November 2014 17:30:28 Burkhard Lück wrote: Am Mittwoch, 19. November 2014, 01:28:51 schrieb Kevin Funk: On Wednesday 19 November 2014 00:09:25 Albert Astals Cid wrote: El Dimarts, 18 de novembre de 2014, a les 23:01:14, Alex Merry va escriure: On Tuesday 18 November 2014 23:45:56 Albert Astals Cid wrote: I didn't even know we were using json now. Why did we change from .desktop file to .json ones? What's the benefit? Seems like .desktop files did their job good enough and we have all the tooling available already. Because that's what Qt uses - Qt5 plugins have JSON metadata as standard, meaning it's all in one file (the JSON is embedded in the plugin, although it can be read without loading the plugin). And Qt introduced a technology without making it translatable? What fields do we need to make translatable? Can somebody point me to such a .json file we'd like to translate? Here's one: http://pastebin.kde.org/p4p38fqr1 That's kdevpatchreview.json, generated from kdevpatchreview.desktop via kcoreaddons_desktop_to_json(...) during the CMake run. But the kdevpatchreview.desktop is installed nevertheless and is apparently used to get the translations for Name + Comment/Description. Having german translations for Name + Comment/Description only in kdevpatchreview.json at build time, but removed after installation in the installed kdevpatchreview.desktop file makes them untranslated for me. This was from kde4, kf5 apparently is different. And if the .desktop is not installed at all (we do this in other places, and would/should do it here too). Are translations then gone alltogether? One more reason to get i18n support for .json files. In kde4 the plugin is gone without a desktop file. Looks to me like translations are not supported via json files. That is only true for kde4 Please check the above. Anyhow, imo it should be our goal to get this supported. In the ideal scenario, a plugin would be just a .so installed into the right directory. No .desktop, no sycoca cache. So again, what is necessary to get this done? See my other mail in this thread. -- Burkhard Lück
Re: desktoptojson and list properties / i18n of JSON files
Am Mittwoch, 19. November 2014, 23:00:57 schrieb Albert Astals Cid: Well, there's two steps about this: 1) Know where the code is that gets the Name/Comment/Description from the json 2) Decide how you want to translate stuff (which may depend on 1) For 2) there's broadly two options: 2.1: Make the .json file have the translations and make sure the code from 1 reads it properly 2.2: Make the translations be in the .po and then make the code from 1 read the english variant and call i18n(englishText) 2.2 is easier (if possible to change the code in 1 to do it) since it does not involve writing back strings to the json file. In kf5 using LANGUAGE=foo kate or LANGUAGE=foo kdevelop (both projects do not install desktop files but use json files generated at build time from desktop files) I see the name/description (from the json files) of plugins in the settings dialog translated in language foo. So apparently in kf5 using json files with translated Name/Description as provided by Kevin's example kdevpatchreview.json I get the proper translations in the GUI. Please check that, you do not need to have language foo installed, just launch kate or kdevelop using x-test/uk/de/fr... as value for foo. If that works we could treat json and desktop files in the same way from devel/translators pov, because what is the difference between desktop and json files? Name and format, nothing else. I have played a bit with pythons json module using kdevpatchreview.json and the following workflow might be possible: * Find all *json in a repo * generate a template json_reponame.pot with all translatable strings from all json files in the repo (msgid=string, msgctxt=dictkeyofstring+jsonfilename to get unique translations per file or similar) * translators translate these json_reponame.pos and Scripty merges the translation back in to the *.json in the repos similar to merging back translations of xml mimetype translations. -- Burkhard Lück
Re: desktoptojson and list properties / i18n of JSON files
Am Donnerstag, 20. November 2014, 20:05:19 schrieb Sebastian Kügler: On Thursday, November 20, 2014 19:57:54 Burkhard Lück wrote: 2.2 is easier (if possible to change the code in 1 to do it) since it does not involve writing back strings to the json file. In kf5 using LANGUAGE=foo kate or LANGUAGE=foo kdevelop (both projects do not install desktop files but use json files generated at build time from desktop files) I see the name/description (from the json files) of plugins in the settings dialog translated in language foo. So apparently in kf5 using json files with translated Name/Description as provided by Kevin's example kdevpatchreview.json I get the proper translations in the GUI. Please check that, you do not need to have language foo installed, just launch kate or kdevelop using x-test/uk/de/fr... as value for foo. If that works we could treat json and desktop files in the same way from devel/translators pov, because what is the difference between desktop and json files? Name and format, nothing else. The json embedded in plugins is created using the desktoptojson tool. This tool runs at build time, it converts a .desktop file (including its translations) to a .json file, which is then embedded into the plugin binary. This tool has only limited understanding of list properties (this limitation is what Milian's problem triggering this thread is about). An idea is to not do a conversion, but rather add a json file to the repository, which can directly be included. Since translations are done in the .desktop file, the json file would not be translated. This is the root of the problem. Please launch LANGUAGE=nl kdevelop or LANGUAGE=nl kate in Konsole. Do you have translated Names/Description in the settings dialog page Plugins? -- Burkhard Lück
Re: desktoptojson and list properties / i18n of JSON files
Am Donnerstag, 20. November 2014, 22:55:03 schrieb Albert Astals Cid: El Dijous, 20 de novembre de 2014, a les 20:18:29, Burkhard Lück va escriure: Am Donnerstag, 20. November 2014, 20:05:19 schrieb Sebastian Kügler: On Thursday, November 20, 2014 19:57:54 Burkhard Lück wrote: 2.2 is easier (if possible to change the code in 1 to do it) since it does not involve writing back strings to the json file. In kf5 using LANGUAGE=foo kate or LANGUAGE=foo kdevelop (both projects do not install desktop files but use json files generated at build time from desktop files) I see the name/description (from the json files) of plugins in the settings dialog translated in language foo. So apparently in kf5 using json files with translated Name/Description as provided by Kevin's example kdevpatchreview.json I get the proper translations in the GUI. Please check that, you do not need to have language foo installed, just launch kate or kdevelop using x-test/uk/de/fr... as value for foo. If that works we could treat json and desktop files in the same way from devel/translators pov, because what is the difference between desktop and json files? Name and format, nothing else. The json embedded in plugins is created using the desktoptojson tool. This tool runs at build time, it converts a .desktop file (including its translations) to a .json file, which is then embedded into the plugin binary. This tool has only limited understanding of list properties (this limitation is what Milian's problem triggering this thread is about). An idea is to not do a conversion, but rather add a json file to the repository, which can directly be included. Since translations are done in the .desktop file, the json file would not be translated. This is the root of the problem. Please launch LANGUAGE=nl kdevelop or LANGUAGE=nl kate in Konsole. Do you have translated Names/Description in the settings dialog page Plugins? Yes they are translated, but this is tangential to the issue here, they are translated because the .desktop file is converted to .json on compile time and then embedded into the .so file of the plugin. What Milian wants is not having the .desktop file in the repository, but having the .json file directly, it's an unneeded conversion step if we have the proper i18n tooling for it. Kate and KDevelop do not install any desktop file in kf5 so we can skip the conversion of deskop to json files and start to translate json files directly. -- Burkhard Lück
Re: desktoptojson and list properties / i18n of JSON files
Am Mittwoch, 19. November 2014, 01:28:51 schrieb Kevin Funk: On Wednesday 19 November 2014 00:09:25 Albert Astals Cid wrote: El Dimarts, 18 de novembre de 2014, a les 23:01:14, Alex Merry va escriure: On Tuesday 18 November 2014 23:45:56 Albert Astals Cid wrote: I didn't even know we were using json now. Why did we change from .desktop file to .json ones? What's the benefit? Seems like .desktop files did their job good enough and we have all the tooling available already. Because that's what Qt uses - Qt5 plugins have JSON metadata as standard, meaning it's all in one file (the JSON is embedded in the plugin, although it can be read without loading the plugin). And Qt introduced a technology without making it translatable? What fields do we need to make translatable? Can somebody point me to such a .json file we'd like to translate? Here's one: http://pastebin.kde.org/p4p38fqr1 That's kdevpatchreview.json, generated from kdevpatchreview.desktop via kcoreaddons_desktop_to_json(...) during the CMake run. But the kdevpatchreview.desktop is installed nevertheless and is apparently used to get the translations for Name + Comment/Description. Having german translations for Name + Comment/Description only in kdevpatchreview.json at build time, but removed after installation in the installed kdevpatchreview.desktop file makes them untranslated for me. Looks to me like translations are not supported via json files. -- Burkhard Lück
Re: desktoptojson and list properties / i18n of JSON files
Am Mittwoch, 19. November 2014, 18:46:28 schrieben Sie: So again, what is necessary to get this done? First step is to make kdevelop in kf5 translatable using the normal po files, then let's talk about json translation: * KDevelop has 20 translation catalogs, but none of them is used (no setApplicationDomain call, no TRANSLATION_DOMAIN defintion) * KDevelop uses ki18n (XGETTEXT) and qt5_wrap_ui. That is broken, a ki18n based system has to use ki18n_wrap_ui * KDevelop has 9 .rc files, 6 of them do not belong to an application with a KLocalizedString::setApplicationDomain call, therefore these 6 rc files need a translationDomain definition of the corresponding translation catalog in the header. * KDevplatform has 32 translation catalogs, but only one add_definitions(- DTRANSLATION_DOMAIN=\kdevplatform\) line in the top level CMakeLists file - translations in 31 catalogs are not used. * KDevplatform uses ki18n (XGETTEXT) and qt5_wrap_ui. That is broken, a ki18n based system has to use ki18n_wrap_ui * KDevplatform has 21 .rc files, none of them belongs to an application with a KLocalizedString::setApplicationDomain call, therefore all of them need a translationDomain definition of the corresponding translation catalog in the header. -- Burkhard Lück
Re: Gwenview maintainership
Am Dienstag, 14. Oktober 2014, 22:10:19 schrieb Lukáš Tinkl: Dne 14.10.2014 v 17:51 Aurélien Gâteau napsal(a): For the past few months, I haven't been doing any work on KDE projects, and I don't see this changing for now. It's time for me to step down from the projects I maintain. This includes Gwenview. Awesome David Edmundson did the grunt work of porting it to KDE Frameworks 5 (Thanks again David!), but he already has too much on his plate: he can't take over Gwenview. I am therefore looking for a new maintainer. If you are interested, please get in touch. I would be more than happy to guide you through the code to get you started. Some parts of Gwenview user interface (as well as inner plumbing) are getting a bit dated, so it would be wonderful if you could get in touch with the VDG to give Gwenview the visual refresh it deserves. Aurélien Hi, as I did quite some fixes recently, I'd be happy to take over the maintainership from you. Thanks for all the hard work, Gwenview is fun to hack on! And it is fun to use / important for my daily use cases So thanks to Aurélien + Lukáš -- Burkhard Lück
Re: AppStream Upstream Metadata: The next steps
Am Freitag, 18. April 2014, 21:11:10 schrieben Sie: 2014-04-18 20:50 GMT+02:00 Burkhard Lück lu...@hube-lueck.de: Am Freitag, 18. April 2014, 16:25:40 schrieb Matthias Klumpp: These scripts illustrate how translation of the XML can be done in KDE. I would kindly ask the l10n-script developers to take a look at it any maybe integrate it at the proper places, because they know the code way better than I do. The scripts can be found at: http://people.freedesktop.org/~mak/appstream/kde-asmetadata-l10n.tar.gz (I also included a demo XML file) I wanted to post that to Reviewboard, but couldn't find a project for Scripty. Please use https://svn.reviewboard.kde.org/groups/l10n/ for your patch Quoting my comment on https://git.reviewboard.kde.org/r/117609/ Please have a look at the recent changes in http://websvn.kde.org/trunk/l10n-kde4/scripts/?sortby=date#dirlist extract-xml.sh update_translations fillxmlfrompo.py These changes are about a similar problem, ectracting strings for translation from mimetype xml files and fill the xml files with the translations. Some of these files already existed back in the days. From what I've seen, the code takes the mime-xml, extracts interesting tag (comment/) performs some hacks so intltool likes it (comment/ = _comment/) and then does similar stuff my examples do (but with intltool instead of itstool, which IMHO is mot really nice for this purpose (I love intltool otherwise!)). I also don't fully understand the need for XmlMessages.sh in the source tree... So, because of this and especially because of: # Note to developers: # there are not many comments in this code to avoid to slow down the code # So please look also in the svn log to have comments about the code I would need help from someone experienced with the l10n workflow and especially the l10n code to integrate the changes - that stuff is really hard to understand if you don't know the details and if there are zero comments explaining things[1]. The UML helps a little bit, but it still leaves lots of questions. I think with the scripts above it's trivial for someone who knows the code to call them from the appropriate places and make the necessary adjustments ;-) Cheers, Matthias [1]: Maybe long-term it would make sense to attempt a Python rewrite of this? (there are currently bits of C++, Python, Perl, Sh and Bash in this - Esp. calls like g++ -O2 -march=nocona -o apply scripts/applycontext.cpp in the generation code make me wonder...) Thanks. -- Burkhard Lück
Re: AppStream Upstream Metadata: The next steps
Am Freitag, 18. April 2014, 16:25:40 schrieb Matthias Klumpp: These scripts illustrate how translation of the XML can be done in KDE. I would kindly ask the l10n-script developers to take a look at it any maybe integrate it at the proper places, because they know the code way better than I do. The scripts can be found at: http://people.freedesktop.org/~mak/appstream/kde-asmetadata-l10n.tar.gz (I also included a demo XML file) I wanted to post that to Reviewboard, but couldn't find a project for Scripty. Quoting my comment on https://git.reviewboard.kde.org/r/117609/ Please have a look at the recent changes in http://websvn.kde.org/trunk/l10n-kde4/scripts/?sortby=date#dirlist extract-xml.sh update_translations fillxmlfrompo.py These changes are about a similar problem, ectracting strings for translation from mimetype xml files and fill the xml files with the translations. -- Burkhard Lück
Re: Is kpovmodeler still valid or should it be removed
Am Donnerstag, 10. April 2014, 22:55:46 schrieb Michael Pyne: On Wed, April 9, 2014 23:50:15 Burkhard Lück wrote: From my pov I'd like to file a sysadmin request to move these apps to unmaintained4: kpovmodeler kuickshow kgrab I'll +1 the request if you want to go ahead and file it. kpovmodeler, kuickshow, kgrab were just moved to unmaintained/4. -- Burkhard Lück
Re: Is kpovmodeler still valid or should it be removed
Am Dienstag, 11. März 2014, 08:54:11 schrieb Burkhard Lück: Am Montag, 10. März 2014, 22:54:50 schrieb Albert Astals Cid: El Dilluns, 10 de març de 2014, a les 12:36:59, Burkhard Lück va escriure: Am Samstag, 8. März 2014, 22:11:11 schrieb Freek de Kruijf: One of our translators mentioned kpovmodeler in extragear-graphics. It seems this package still requires KDE3 stuff and the last development has been done 5 years ago. It also is hardly usable anymore because it calls an external program, povray, which apparently needs another set of parameters to function properly. You are right kpovmodeler development in kde svn seems to be dead and it does not build here, but there is apparently some development outside kde repos, see http://forum.kde.org/viewtopic.php?f=19t=90952start=15 According to the forum thread there are still users who would like to work with kpovmodeler. Well, if they want to work with kpovmodeler, someone should contact the guy that is working on it and tell him to come over and work with us :-) I have mailed him yesterday, waiting for a response now. Now response to my mail nor on the forum thread. Hence my question: should it be moved to unmaintained? extragear/graphics has more candidates for this question: kuickshow: no development since 4 years needs an old no longer available library imlib1 to build no deb packages provided kgrab no development since many years builds and works for me, but apparently it has minor functionality compared to ksnapshot, so I fail to see a need for this application kfax no development since many years builds and works for me with the example fax in the code no deb packages provided Are there still any users of this application? My conclusion: applications which can not be build since a long time should not be in extragear, therefore kuickshow should go to unmaintained and kpovmodeler tp playground, if some wants to develop it otherwise to unmaintained as well kgrab should go to unmaintained I am not sure what to do with kfax We have the application lifecycle document over in techbase that describes this kind of stuff, it's just that noone is janitoring the process so that it actually happens. Do you want to do it? From my pov I'd like to file a sysadmin request to move these apps to unmaintained4: kpovmodeler kuickshow kgrab -- Burkhard Lück
Re: KBibTeX in KDE Review
Am Mittwoch, 26. März 2014, 19:37:02 schrieb Thomas Fischer: 1. User documentation: initial documentation has been provided by Yuri Chornoivan and Burkhard Lück, located in master and will be part of future 0.6 releases Correction: Documentation is solely Yuri's work Looking forward to your feedback, You have a mime-info file in mime/bibliography.xml, but no XmlMessages.sh to extract these strings for translation. Please add a XmlMessages.sh An example how to do that you'l find in kdeedu/marble/data/mimetypes/ or in kdelibs/mimetypes/ Thanks. -- Burkhard Lück
Re: Is kpovmodeler still valid or should it be removed
Am Montag, 10. März 2014, 22:54:50 schrieb Albert Astals Cid: El Dilluns, 10 de març de 2014, a les 12:36:59, Burkhard Lück va escriure: Am Samstag, 8. März 2014, 22:11:11 schrieb Freek de Kruijf: One of our translators mentioned kpovmodeler in extragear-graphics. It seems this package still requires KDE3 stuff and the last development has been done 5 years ago. It also is hardly usable anymore because it calls an external program, povray, which apparently needs another set of parameters to function properly. You are right kpovmodeler development in kde svn seems to be dead and it does not build here, but there is apparently some development outside kde repos, see http://forum.kde.org/viewtopic.php?f=19t=90952start=15 According to the forum thread there are still users who would like to work with kpovmodeler. Well, if they want to work with kpovmodeler, someone should contact the guy that is working on it and tell him to come over and work with us :-) I have mailed him yesterday, waiting for a response now. Hence my question: should it be moved to unmaintained? extragear/graphics has more candidates for this question: kuickshow: no development since 4 years needs an old no longer available library imlib1 to build no deb packages provided kgrab no development since many years builds and works for me, but apparently it has minor functionality compared to ksnapshot, so I fail to see a need for this application kfax no development since many years builds and works for me with the example fax in the code no deb packages provided Are there still any users of this application? My conclusion: applications which can not be build since a long time should not be in extragear, therefore kuickshow should go to unmaintained and kpovmodeler tp playground, if some wants to develop it otherwise to unmaintained as well kgrab should go to unmaintained I am not sure what to do with kfax We have the application lifecycle document over in techbase that describes this kind of stuff, it's just that noone is janitoring the process so that it actually happens. Do you want to do it? Cheers, Albert -- Burkhard Lück
Re: Is kpovmodeler still valid or should it be removed
Am Samstag, 8. März 2014, 22:11:11 schrieb Freek de Kruijf: One of our translators mentioned kpovmodeler in extragear-graphics. It seems this package still requires KDE3 stuff and the last development has been done 5 years ago. It also is hardly usable anymore because it calls an external program, povray, which apparently needs another set of parameters to function properly. You are right kpovmodeler development in kde svn seems to be dead and it does not build here, but there is apparently some development outside kde repos, see http://forum.kde.org/viewtopic.php?f=19t=90952start=15 According to the forum thread there are still users who would like to work with kpovmodeler. Hence my question: should it be moved to unmaintained? extragear/graphics has more candidates for this question: kuickshow: no development since 4 years needs an old no longer available library imlib1 to build no deb packages provided kgrab no development since many years builds and works for me, but apparently it has minor functionality compared to ksnapshot, so I fail to see a need for this application kfax no development since many years builds and works for me with the example fax in the code no deb packages provided Are there still any users of this application? My conclusion: applications which can not be build since a long time should not be in extragear, therefore kuickshow should go to unmaintained and kpovmodeler tp playground, if some wants to develop it otherwise to unmaintained as well kgrab should go to unmaintained I am not sure what to do with kfax -- Burkhard Lück
Re: Review Request 116604: Allow directories with . as output for meinproc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/#review52347 --- Ship it! Thanks - Burkhard Lück On March 5, 2014, 1:06 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/ --- (Updated March 5, 2014, 1:06 a.m.) Review request for Documentation, KDE Frameworks, kdelibs, and Aleix Pol Gonzalez. Bugs: 246755 https://bugs.kde.org/show_bug.cgi?id=246755 Repository: kdoctools Description --- The outputFile parameter is not used by the stylesheets, so don't pass it. If a directory starts with ., it is interpreted in a wrong way by libxslt with an error like: --- XPath error : Invalid expression /home/kde-devel/.cache5/khelpcenter/help/__home__kde- devel__kde__share__doc__HTML__en__kioslave__file__index.docbook ^ runtime error Evaluating user parameter outputFile failed --- This is an old issue, it was solved on windows by not compiling that code, but I suspect that the issue has been in UNIX systems too for a long time. Another way to solve the bug is quoting the value of the parameter with '...', replacing: params.append(qstrdup(parser.value(QStringLiteral(output)).toLocal8Bit().constData())); with something like QString quotedOutput = ' + parser.value(QStringLiteral(output)) + '; params.append(qstrdup(quotedOutput.toLocal8Bit().constData())); but anyway in this case the name of output file is not used, or I can't find any occurrence in the stylesheets. The stylesheet is applied and the name of the file is used only after to write the generated XML (see tranform() function). A similar patch can be applied to kdelibs/kdoctools too (same codepath). Diffs - src/meinproc.cpp 95adcea Diff: https://git.reviewboard.kde.org/r/116604/diff/ Testing --- Run meinproc5 (and 4) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano
Re: Review Request 116604: Allow directories with . as output for meinproc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/#review52091 --- src/meinproc.cpp https://git.reviewboard.kde.org/r/116604/#comment36985 How does this affect this code in KHelpcenter: kde-runtime/khelpcenter/glossary.cpp:149:KProcess *meinproc = new KProcess; kde-runtime/khelpcenter/glossary.cpp:153:*meinproc KStandardDirs::locate( exe, QLatin1String( meinproc4 ) ); kde-runtime/khelpcenter/glossary.cpp:154:*meinproc QLatin1String( --output ) m_cacheFile; kde-runtime/khelpcenter/glossary.cpp:155:*meinproc QLatin1String( --stylesheet ) kde-runtime/khelpcenter/glossary.cpp:157:*meinproc m_sourceFile; kde-runtime/khelpcenter/glossary.cpp:176:KProcess *meinproc = static_castKProcess *(sender()); kde-runtime/khelpcenter/toc.cpp:148:KProcess *meinproc = new KProcess; kde-runtime/khelpcenter/toc.cpp:152:*meinproc KStandardDirs::locate(exe, meinproc4); kde-runtime/khelpcenter/toc.cpp:153:*meinproc --stylesheet KStandardDirs::locate( data, khelpcenter/table-of-contents.xslt ); kde-runtime/khelpcenter/toc.cpp:154:*meinproc --output m_cacheFile; kde-runtime/khelpcenter/toc.cpp:155:*meinproc m_sourceFile; kde-runtime/khelpcenter/toc.cpp:172:KProcess *meinproc = static_castKProcess *(sender()); About the issue with dot in Path see also http://lists.kde.org/?l=kde-doc-englishm=127421104303628w=2 - Burkhard Lück On March 5, 2014, 1:06 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/ --- (Updated March 5, 2014, 1:06 a.m.) Review request for Documentation, KDE Frameworks, kdelibs, and Aleix Pol Gonzalez. Bugs: 246755 https://bugs.kde.org/show_bug.cgi?id=246755 Repository: kdoctools Description --- The outputFile parameter is not used by the stylesheets, so don't pass it. If a directory starts with ., it is interpreted in a wrong way by libxslt with an error like: --- XPath error : Invalid expression /home/kde-devel/.cache5/khelpcenter/help/__home__kde- devel__kde__share__doc__HTML__en__kioslave__file__index.docbook ^ runtime error Evaluating user parameter outputFile failed --- This is an old issue, it was solved on windows by not compiling that code, but I suspect that the issue has been in UNIX systems too for a long time. Another way to solve the bug is quoting the value of the parameter with '...', replacing: params.append(qstrdup(parser.value(QStringLiteral(output)).toLocal8Bit().constData())); with something like QString quotedOutput = ' + parser.value(QStringLiteral(output)) + '; params.append(qstrdup(quotedOutput.toLocal8Bit().constData())); but anyway in this case the name of output file is not used, or I can't find any occurrence in the stylesheets. The stylesheet is applied and the name of the file is used only after to write the generated XML (see tranform() function). A similar patch can be applied to kdelibs/kdoctools too (same codepath). Diffs - src/meinproc.cpp 95adcea Diff: https://git.reviewboard.kde.org/r/116604/diff/ Testing --- Run meinproc5 (and 4) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano
Re: Moving Milou to Extragear
Am Freitag, 14. Februar 2014, 13:09:19 schrieb Vishesh Handa: On Thursday, February 13, 2014 11:28:40 AM Burkhard Lück wrote: That loads the translation catalog, which also contains messages from the plasmoid outside the library. Apparently that happens early enough at runtime (at least I see the catalog is loaded running milou in plasmoidviewer in locale x-test), so even messages used only in the plasmoid are translated. Your plasmoid tries to load a catalog named plasma_applet_milou_applet via plasmoid/applet.h:60:K_EXPORT_PLASMA_APPLET(milou_applet, Applet), but you extract to milou, so this catalog does not exist. But then the milou catalog would be loaded so the translations should be there, right? If not, what would be the correct way of fixing this? One option which I can think of is extracting the translations to plasma_applet_milou_applet, and updating the KCatalogLoader in the case the library is used without the applet. This does not make sense to me. Use two messages catalogs, one for the plasmoid named plasma_applet_milou_applet and loaded via K_EXPORT_PLASMA_APPLET and the second one for the library named e.g. libmilou and loaded via KCatalogLoader. Btw the fixes from Lukáš Tinkl for the preview plugins are useless, because the plugins are part of the library, which loads its catalog already via KCatalogLoader. -- Burkhard Lück
Re: Moving Milou to Extragear
Am Donnerstag, 13. Februar 2014, 10:38:34 schrieb Vishesh Handa: On Wednesday, February 12, 2014 11:56:27 PM Albert Astals Cid wrote: I'd also say that your catalog isn't getting loaded (i.e. your catalog name is wrong). Is it? Messages.sh #! /usr/bin/env bash $XGETTEXT `find . -name *.cpp -o -name *.qml` -o $podir/milou.pot And in lib/abstractsource.cpp 26:static const KCatalogLoader loader(milou); That loads the translation catalog, which also contains messages from the plasmoid outside the library. Apparently that happens early enough at runtime (at least I see the catalog is loaded running milou in plasmoidviewer in locale x-test), so even messages used only in the plasmoid are translated. Your plasmoid tries to load a catalog named plasma_applet_milou_applet via plasmoid/applet.h:60:K_EXPORT_PLASMA_APPLET(milou_applet, Applet), but you extract to milou, so this catalog does not exist. What would need to be changed? -- Burkhard Lück
Re: AW: KDE Review: Moving Smb4K to extragear/network
Am Donnerstag, 23. Januar 2014, 09:08:03 schrieb alexander.reinholdt@t- online.de: [...] I checked the the code and compared it with the tutorials on techbase. And I seem to have done everything necessary: All strings in the QML code are translatable and the strings are correctly extracted from the QML files as well. Could you please give me a hint, what's missing? Sure, extraction to the translation catalog smb4k is correct, that was never in question. But your plasmoid tries to load the translation catalog plasma_applet_smb4k- qml, but this catalog does not exist, therefore the plasmoid gui is untranslated. The catalog name for the plasmoid is generated in kde-runtime/plasma/: scriptengines/javascript/plasmoid/declarativeappletscript.cpp#90 KGlobal::locale()-insertCatalog(plasma_applet_ % description().pluginName()); With plasmoid/package/metadata.desktop:32:X-KDE-PluginInfo-Name=smb4k-qml the catalogname is plasma_applet_smb4k-qml Adding a Messages.sh in smb4k/plasmoid/ with #!/bin/bash $XGETTEXT `find . -name \*.qml` -L Java -o $podir/plasma_applet_smb4k-qml.pot makes the plasmoid gui translated, but e.g. the dialogs Edit Bookmarks + Mount Share opened from the plasmoid are still untranslated, because the messages for them are in smb4k. @Albert: How to solve this dilemma? The proper solution would probably be splitting the thing into 3 .pot files, one for core/ that gets loaded with a KCatalogLoader, one for smb4k that gets loaded by the regular KAboutData/KComponentData way and another for the plasmoid that gets loaded the plasmoid way. The easy solution is just adding a KCatalogLoader of smb4k catalog somewhere in core/ Thanks for the directions, Burkhard and Albert. I will split the current catalogue into three *.pot files as suggested by Albert. https://git.reviewboard.kde.org/r/115263/ -- Burkhard Lück
Re: KDE Review: Moving Smb4K to extragear/network
Am Sonntag, 19. Januar 2014, 10:34:35 schrieb Alexander Reinholdt: [...] Hmm, running smb4k in locale x-test with recent smb4k compiled from sources in master only the settings dialog for the smb4k plasmoid is translated, but not the dialog opened with a left mouse button click on the smb4k plasmoid icon. This dialog shows no xx around the gui strings. And like Albert I fail to see any code to load the translation catalog smb4k in the plasmoid. I checked the the code and compared it with the tutorials on techbase. And I seem to have done everything necessary: All strings in the QML code are translatable and the strings are correctly extracted from the QML files as well. Could you please give me a hint, what's missing? Sure, extraction to the translation catalog smb4k is correct, that was never in question. But your plasmoid tries to load the translation catalog plasma_applet_smb4k- qml, but this catalog does not exist, therefore the plasmoid gui is untranslated. The catalog name for the plasmoid is generated in kde-runtime/plasma/: scriptengines/javascript/plasmoid/declarativeappletscript.cpp#90 KGlobal::locale()-insertCatalog(plasma_applet_ % description().pluginName()); With plasmoid/package/metadata.desktop:32:X-KDE-PluginInfo-Name=smb4k-qml the catalogname is plasma_applet_smb4k-qml Adding a Messages.sh in smb4k/plasmoid/ with #!/bin/bash $XGETTEXT `find . -name \*.qml` -L Java -o $podir/plasma_applet_smb4k-qml.pot makes the plasmoid gui translated, but e.g. the dialogs Edit Bookmarks + Mount Share opened from the plasmoid are still untranslated, because the messages for them are in smb4k. @Albert: How to solve this dilemma? -- Burkhard Lück
Re: KDE Review: Moving Smb4K to extragear/network
Am Mittwoch, 15. Januar 2014, 20:17:52 schrieb Albert Astals Cid: Am Donnerstag, 16. Januar 2014, 09:13:46 schrieb alexander.reinholdt@t- online.de: I don't think your plasmoid is getting properly i18n'ed since i don't see how it would load the smb4k catalog. Have you tried it works? On my desktop it is fully translated. However, I'd be happy about hints how to improve the plugin. Hmm, running smb4k in locale x-test with recent smb4k compiled from sources in master only the settings dialog for the smb4k plasmoid is translated, but not the dialog opened with a left mouse button click on the smb4k plasmoid icon. This dialog shows no xx around the gui strings. And like Albert I fail to see any code to load the translation catalog smb4k in the plasmoid. -- Burkhard Lück
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Dec. 14, 2013, 11:33 a.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, David Faure, and Frank Reininghaus. Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs - khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop PRE-CREATION khelpcenter/plugins/filemanagercontrolmodules.desktop PRE-CREATION khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop PRE-CREATION khelpcenter/plugins/othercontrolmodules.desktop PRE-CREATION khelpcenter/plugintraverser.cpp b0b0e78 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45657 --- Where is the message extraction for these i18n() ? - Burkhard Lück On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 3:37 p.m.) Review request for KDE Runtime. Repository: kde-runtime Description --- This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text. Diffs - plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f Diff: http://git.reviewboard.kde.org/r/114437/diff/ Testing --- Thanks, Leszek Lesner
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
On Nov. 29, 2013, 7:32 p.m., Ben Cooksley wrote: Patch looks fine to me, sucks a bit that the names have to be hardcoded for certain lists but not much can be done there if that is what the applications do... Patch looks fine to me = Ship It! ? - Burkhard --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44837 --- On Nov. 29, 2013, 12:37 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 29, 2013, 12:37 p.m.) Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, David Faure, and Frank Reininghaus. Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs - khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop PRE-CREATION khelpcenter/plugins/filemanagercontrolmodules.desktop PRE-CREATION khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop PRE-CREATION khelpcenter/plugins/othercontrolmodules.desktop PRE-CREATION khelpcenter/plugintraverser.cpp b0b0e78 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Review Request 114201: define property X-KDE-PluginKeyword in kdelibs/kio/kcmodule.desktop
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114201/ --- (Updated Dec. 4, 2013, 11:43 a.m.) Status -- This change has been marked as submitted. Review request for kdelibs and David Faure. Repository: kdelibs Description --- This is required to make https://git.reviewboard.kde.org/r/111851/ work properly I don't know what to document here, the only hint I found in: http://websvn.kde.org/?view=revisionrevision=705672 Log Message: port to KPluginFactory Diffs - kio/kcmodule.desktop 2a978a5 Diff: http://git.reviewboard.kde.org/r/114201/diff/ Testing --- Thanks, Burkhard Lück
Review Request 114201: define property X-KDE-PluginKeyword in kdelibs/kio/kcmodule.desktop
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114201/ --- Review request for kdelibs and David Faure. Repository: kdelibs Description --- This is required to make https://git.reviewboard.kde.org/r/111851/ work properly I don't know what to document here, the only hint I found in: http://websvn.kde.org/?view=revisionrevision=705672 Log Message: port to KPluginFactory Diffs - kio/kcmodule.desktop 2a978a5 Diff: http://git.reviewboard.kde.org/r/114201/diff/ Testing --- Thanks, Burkhard Lück
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
On Nov. 22, 2013, 7:05 a.m., Ben Cooksley wrote: khelpcenter/plugintraverser.cpp, line 95 http://git.reviewboard.kde.org/r/111851/diff/1/?file=176031#file176031line95 Do you intend on modifying the control modules used by Dolphin and Konqueror here to fit this? That sounds like something which will cause unintended breakages. Perhaps it might be wise to check their respective code to determine how they look up the modules they want to load? As far as I understand the code, neither Dolphin nor Konqueror use X-KDE-ParentApp. In dolphinsettingsdialog.cpp the pages are manually added to the configuration dialog In konqmainwindow.cpp the pages are added e.g. via addModule(KCModuleInfo(QString(fmModules[i])+.desktop),fileManagementGroup); where fmModules is a hardcoded list of desktop file names On Nov. 22, 2013, 7:05 a.m., Ben Cooksley wrote: kcmshell/main.cpp, line 63 http://git.reviewboard.kde.org/r/111851/diff/1/?file=176023#file176023line63 System Settings doesn't look for control modules via X-KDE-ParentApp. It uses the following trader query instead: [X-KDE-System-Settings-Parent-Category] != '' The list of modules you get from kcmshell4 --list is different from the list of modules in systemsettings. Wirh or without the patch you get the same output from kcmshell4 --list - Burkhard --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44184 --- On Nov. 21, 2013, 11:50 a.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 21, 2013, 11:50 a.m.) Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, and David Faure. Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs - kcmshell/main.cpp dab8fc6 khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop e69de29 khelpcenter/plugins/filemanagercontrolmodules.desktop e69de29 khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop e69de29 khelpcenter/plugins/othercontrolmodules.desktop e69de29 khelpcenter/plugintraverser.cpp b0b0e78 kioslave/cgi/kcmcgi/kcmcgi.desktop f49eeb9 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 28, 2013, 8:36 p.m.) Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, David Faure, and Frank Reininghaus. Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs - kcmshell/main.cpp dab8fc6 khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop e69de29 khelpcenter/plugins/filemanagercontrolmodules.desktop e69de29 khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop e69de29 khelpcenter/plugins/othercontrolmodules.desktop e69de29 khelpcenter/plugintraverser.cpp b0b0e78 kioslave/cgi/kcmcgi/kcmcgi.desktop f49eeb9 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44734 --- In theory I have a possible solution using the existing X-KDE-PluginKeyword in the desktop files, so no changes outside khelpcenter would be required. But in contrary to the api documentation this does not work or I do wrong: $ ktraderclient --servicetype KCModule --constraint [X-KDE-PluginKeyword] == 'dolphinviewmodes' servicetype is : KCModule constraint is : [X-KDE-PluginKeyword] == 'dolphinviewmodes' got 0 offers. This should return *one* offer kcmdolphinviewmodes.desktop which has X-KDE-ServiceTypes=KCModule + X-KDE-PluginKeyword=dolphinviewmodes What is wrong here? - Burkhard Lück On Nov. 28, 2013, 8:36 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 28, 2013, 8:36 p.m.) Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, David Faure, and Frank Reininghaus. Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs - kcmshell/main.cpp dab8fc6 khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop e69de29 khelpcenter/plugins/filemanagercontrolmodules.desktop e69de29 khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop e69de29 khelpcenter/plugins/othercontrolmodules.desktop e69de29 khelpcenter/plugintraverser.cpp b0b0e78 kioslave/cgi/kcmcgi/kcmcgi.desktop f49eeb9 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 21, 2013, 11:50 a.m.) Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, and David Faure. Changes --- Adding Ben Cooksley (Systemsettings maintainer) and David Faure as reviewer Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs - kcmshell/main.cpp dab8fc6 khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop e69de29 khelpcenter/plugins/filemanagercontrolmodules.desktop e69de29 khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop e69de29 khelpcenter/plugins/othercontrolmodules.desktop e69de29 khelpcenter/plugintraverser.cpp b0b0e78 kioslave/cgi/kcmcgi/kcmcgi.desktop f49eeb9 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review43855 --- Please review - Burkhard Lück On Sept. 3, 2013, 12:38 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Sept. 3, 2013, 12:38 p.m.) Review request for Documentation and KDE Runtime. Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs - kcmshell/main.cpp dab8fc6 khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop e69de29 khelpcenter/plugins/filemanagercontrolmodules.desktop e69de29 khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop e69de29 khelpcenter/plugins/othercontrolmodules.desktop e69de29 khelpcenter/plugintraverser.cpp b0b0e78 kioslave/cgi/kcmcgi/kcmcgi.desktop f49eeb9 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Review Request 112575: KMenuedit documentation - improve introduction chapter and add use case section
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112575/ --- (Updated Sept. 21, 2013, 3:41 p.m.) Review request for Documentation, kde-workspace and Julien Borderie. Changes --- update with changes requested by Julien Borderie Description --- improve introduction and add use cases (add, remove, hide entry, transfer menu modifications) as requested on http://lists.kde.org/?l=kde-doc-englishm=137817779023377w=2 Diffs (updated) - doc/kmenuedit/index.docbook f62b55a Diff: http://git.reviewboard.kde.org/r/112575/diff/ Testing --- ebn, spellcheck, build + installed Thanks, Burkhard Lück
Review Request 112575: KMenuedit documentation - improve introduction chapter and add use case section
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112575/ --- Review request for Documentation, kde-workspace and Julien Borderie. Description --- improve introduction and add use cases (add, remove, hide entry, transfer menu modifications) as requested on http://lists.kde.org/?l=kde-doc-englishm=137817779023377w=2 Diffs - doc/kmenuedit/index.docbook f62b55a Diff: http://git.reviewboard.kde.org/r/112575/diff/ Testing --- ebn, spellcheck, build + installed Thanks, Burkhard Lück
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Sept. 3, 2013, 12:38 p.m.) Review request for Documentation and KDE Runtime. Changes --- changed branch to master only Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. This addresses bug 262935. http://bugs.kde.org/show_bug.cgi?id=262935 Diffs - kcmshell/main.cpp dab8fc6 khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop e69de29 khelpcenter/plugins/filemanagercontrolmodules.desktop e69de29 khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop e69de29 khelpcenter/plugins/othercontrolmodules.desktop e69de29 khelpcenter/plugintraverser.cpp b0b0e78 kioslave/cgi/kcmcgi/kcmcgi.desktop f49eeb9 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- Review request for Documentation and KDE Runtime. Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. This addresses bug 262935. http://bugs.kde.org/show_bug.cgi?id=262935 Diffs - kcmshell/main.cpp dab8fc6 khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop e69de29 khelpcenter/plugins/filemanagercontrolmodules.desktop e69de29 khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop e69de29 khelpcenter/plugins/othercontrolmodules.desktop e69de29 khelpcenter/plugintraverser.cpp b0b0e78 kioslave/cgi/kcmcgi/kcmcgi.desktop f49eeb9 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Moving KScreen and libkscreen to extragear
Am Donnerstag, 4. Juli 2013, 01:13:36 schrieb Àlex Fiestas: I would like to request a review so we can move KScreen and libkscreen to extragear/base. KScreen is a new manager for outputs such: monitors, projectors, embedded screens... It contains: -KDED Module which does some magic by auto configuring the screens, and saving configurations whenever they are changed. -KCM allowing to apply any configuration (change resolution, rotate...) -A plasmoid that does little at the moment. It has six qtTr() calls for gui strings, but these messages are not extracted to l10n-kde4/templates/messages, reported already some time ago here: https://bugs.kde.org/show_bug.cgi?id=316548#c1 -A library that offers a good abstraction so we can support multiple backends. At the moment we support XRandR 1.1 and 1.2/3/4. -- Burkhard Lück
Review Request 110799: Remove translation via babelfish - service is no longer avaibable - use google as default
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110799/ --- Review request for KDE Base Apps and David Faure. Description --- Since may 2012 the babelfish service is no longer available, it was moved to Bing translator and can't be used no more. I changed default translator to Google, which is already used by kdepim/pimcommon/translator/ Translating a selection did not work with the old code, so I used the code from Laurent Montel in the pim translator. Btw. pimcommon lib has a nice translation bar, could probably be reused here. Diffs - konq-plugins/babelfish/plugin_babelfish.cpp c962f18 konq-plugins/babelfish/plugin_babelfish.desktop 267ac60 Diff: http://git.reviewboard.kde.org/r/110799/diff/ Testing --- Tested in master + 4.10 in HTML + WebKit view modes Result is the same as using translate.google.com direct with text or an url. In master in HTML mode a JavaScript Error Warning pops up: An error occurred while attempting to run a script on this page. Type-Error: Attempt to use a non-function object or a value as a function. Thanks, Burkhard Lück
Re: Moving Plasma Media Center to extragear
Am Mittwoch, 22. Mai 2013, 08:11:49 schrieb Burkhard Lück: Am Dienstag, 21. Mai 2013, 10:07:50 schrieb Sinny Kumari: Hi, Any news on this? Does PMC look ok now from your side so that we can move it to extragear ? If not, please let us know what all changes we still need to do. still i18n() calls in *qml files, but no message extraction Extraction is fixed now and pmc is fully translated in x-test. I18n wise Plasma Media Center is ready to move to extragear -- Burkhard Lück
Re: Moving Plasma Media Center to extragear
Am Dienstag, 21. Mai 2013, 10:07:50 schrieb Sinny Kumari: Hi, Any news on this? Does PMC look ok now from your side so that we can move it to extragear ? If not, please let us know what all changes we still need to do. still i18n() calls in *qml files, but no message extraction -- Burkhard Lück
Re: Moving Plasma Media Center to extragear
Am Freitag, 12. April 2013, 23:58:32 schrieb Sinny Kumari: Hi! After Plasma Media Center 1.0 release, we feel that it should be moved to Extragear now. It has been moved to kdereview with link https://projects.kde.org/projects/kdereview/plasma-mediacenter/repository . we are fixing krazy issues as we go. I request you all to review this project and provide comments. i18n() calls in *qml files, but no message extraction -- Burkhard Lück
Re: Request: Move of kdev-perforce plugin from playground to extragear
Am Donnerstag, 7. Februar 2013, 23:31:38 schrieb Morten Volden: Hi All I have created a sysadmin request to move kdev-perforce to extragear: Scripty mailed me kdev-perforce arrived in kdereview this morning, extragear/kdevelop is the target after rhe review, right? -- Burkhard Lück
Re: Plans for SVN infrastructure shutdown
Am Mittwoch, 2. Januar 2013, 18:52:32 schrieb Nicolás Alvarez: The initial draft of the SVN shutdown plan is available on the community wiki: http://community.kde.org/Sysadmin/SVNInfrastructureShutdown http://community.kde.org/Sysadmin/SVNInfrastructureShutdown#Note says: The only exception are the translations. These will continue to happen via subversion... Please elaborate on these minor changes and how it affects the workflow of the translation teams. Thanks -- Burkhard Lück
Re: Moving Trojitá to extragear
Am Mittwoch, 5. Dezember 2012, 15:25:21 schrieb Jan Kundrát: On Tuesday, 4 December 2012 13:03:57 CEST, Burkhard Lück wrote: Scripty does not like your message extraction, see ftp://l10n.kde.org/121204.trunk_l10n-kde4. Hi Burkhard, the latest log [1] looks fine to me. Could you please confirm that it is indeed OK now? Yes, OK now. Thanks. -- Burkhard Lück
Re: Moving Trojitá to extragear
Am Donnerstag, 22. November 2012, 23:31:43 schrieb Jan Kundrát: It took quite a few hours, but it looks like I've tamed the beast. I wanted to follow the way how Marble works, i.e. calling QObject::tr and converting between the .ts and .po files. This turned out to be a problem because QObject::tr expects the context to be a name of the class while the xgettext, as used by Messages.sh, works with file names. I have no idea how come that Marble's tr() calls work -- when I used the same, nothing would get translated. Scripty does not like your message extraction, see ftp://l10n.kde.org/121204.trunk_l10n-kde4. Using a simple $XGETTEXT_QT `find src/ -name \*.cpp` -o $podir/trojita_common.pot will avoid the duplicated messages make Scripty happy. -- Burkhard Lück
