Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- (Updated Aug. 29, 2011, 9:14 a.m.) Review request for KDE Base Apps and Peter Penz. Changes --- Rebased against current master. Summary --- Allow opening files and directories by pressing 'Enter' key. In case multiple files are selected when enter is pressed, all of them are opened. In case of multiple directories, the first directory gets opened in the current tab, while the other directories open in new tabs. Diffs (updated) - dolphin/src/kitemviews/kitemlistcontroller.h 04d4985 dolphin/src/kitemviews/kitemlistcontroller.cpp 207535c dolphin/src/views/dolphinview.h 437f12f dolphin/src/views/dolphinview.cpp 959e4da Diff: http://git.reviewboard.kde.org/r/102450/diff Testing --- Yes, tested and working. Thanks, Tirtha
Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'
On Aug. 29, 2011, 9:40 a.m., Peter Penz wrote: Thanks for the update! Looks good and is exactly like the proposal you, Frank and I discussed per e-mail. As usual I've added a punch of my nitpicking stuff ;-) Please push it to master after fixing, you don't need to add another diff here. I have used itemActivated signal here since itemTriggered is already used by DolphinView. Then I noticed that in my previous keyboard-searching patch, we use the name 'activation' to mean selection. So is it okay to use activation here? - Tirtha --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/#review6128 --- On Aug. 29, 2011, 9:14 a.m., Tirtha Chatterjee wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- (Updated Aug. 29, 2011, 9:14 a.m.) Review request for KDE Base Apps and Peter Penz. Summary --- Allow opening files and directories by pressing 'Enter' key. In case multiple files are selected when enter is pressed, all of them are opened. In case of multiple directories, the first directory gets opened in the current tab, while the other directories open in new tabs. Diffs - dolphin/src/kitemviews/kitemlistcontroller.h 04d4985 dolphin/src/kitemviews/kitemlistcontroller.cpp 207535c dolphin/src/views/dolphinview.h 437f12f dolphin/src/views/dolphinview.cpp 959e4da Diff: http://git.reviewboard.kde.org/r/102450/diff Testing --- Yes, tested and working. Thanks, Tirtha
Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- (Updated Aug. 27, 2011, 7:31 a.m.) Review request for KDE Base Apps and Peter Penz. Changes --- Made the suggested changes, also now respecting KGlobalSettings::changeCursorOverIcon() Summary --- Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, whether files should be opened on single or double clicks), and functions accordingly. Diffs (updated) - dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47 Diff: http://git.reviewboard.kde.org/r/102447/diff Testing --- Yes tested and works. Thanks, Tirtha
Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- (Updated Aug. 27, 2011, 12:31 p.m.) Review request for KDE Base Apps and Peter Penz. Changes --- Fixed a bug, single directory should not open in new tab. Summary --- Allow opening files and directories by pressing 'Enter' key. In case multiple files are selected when enter is pressed, all of them are opened. In case of multiple directories, the first directory gets opened in the current tab, while the other directories open in new tabs. Diffs (updated) - dolphin/src/kitemviews/kitemlistcontroller.h 134e116 dolphin/src/kitemviews/kitemlistcontroller.cpp 2e32880 dolphin/src/views/dolphinview.h 437f12f dolphin/src/views/dolphinview.cpp 959e4da Diff: http://git.reviewboard.kde.org/r/102450/diff Testing --- Yes, tested and working. Thanks, Tirtha
Review Request: Find list items by typing their initial letters.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- Review request for KDE Base Apps and Peter Penz. Summary --- This patch allows finding items by typing on the keyboard while the KItemListController is in focus. Timer and key queuing is handled by KItemListKeyboardManager, and search itself is done by reimplementing indexForKeyboardSearch(QString) from KItemModelBase. This implementation does not, at the moment, take care of the repetitive typing as suggested by Frank. I think we can implement that once this is in. p.s. Not sure if line 213 in kitemlistcontroller.cpp is the best way to do it. Returning true does not work. p.s. I feel the name KItemListKeyboardManager can be changed to KItemListKeyboardSearchManager, although a little too big. Diffs - dolphin/src/CMakeLists.txt 31d3f89 dolphin/src/kitemviews/kfileitemmodel.h 654c7db dolphin/src/kitemviews/kfileitemmodel.cpp f36ab83 dolphin/src/kitemviews/kitemlistcontroller.h 134e116 dolphin/src/kitemviews/kitemlistcontroller.cpp 2e32880 dolphin/src/kitemviews/kitemlistkeyboardmanager.h PRE-CREATION dolphin/src/kitemviews/kitemlistkeyboardmanager.cpp PRE-CREATION dolphin/src/kitemviews/kitemmodelbase.h 4670469 dolphin/src/kitemviews/kitemmodelbase.cpp fc604e7 Diff: http://git.reviewboard.kde.org/r/102465/diff Testing --- yes. tested and works. Thanks, Tirtha
Re: Review Request: Find list items by typing their initial letters.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- (Updated Aug. 27, 2011, 8:36 p.m.) Review request for KDE Base Apps and Peter Penz. Changes --- Changed the name of the macro for the header of KItemListKeyboardManager class. However, It is to be noted that if we do introduce a tranlucent lineedit to show what has been typed, like GTK+ does, the code of the KItemListKeyboardManager would be best put into that class. Because then, we do not need to trap all keyPressEvents, just show the lineedit on the first keyPressEvent which isn't a direction key, then connect textChanged to a timer, and also to KItemListController::slotKeyboardActivationRequested. I think all applications which use this itemview framework can use it (or optionally turn it off). Do we need to worry about breaking API in this case? Summary --- This patch allows finding items by typing on the keyboard while the KItemListController is in focus. Timer and key queuing is handled by KItemListKeyboardManager, and search itself is done by reimplementing indexForKeyboardSearch(QString) from KItemModelBase. This implementation does not, at the moment, take care of the repetitive typing as suggested by Frank. I think we can implement that once this is in. p.s. Not sure if line 213 in kitemlistcontroller.cpp is the best way to do it. Returning true does not work. p.s. I feel the name KItemListKeyboardManager can be changed to KItemListKeyboardSearchManager, although a little too big. Diffs (updated) - dolphin/src/CMakeLists.txt 31d3f89 dolphin/src/kitemviews/kfileitemmodel.h 654c7db dolphin/src/kitemviews/kfileitemmodel.cpp f36ab83 dolphin/src/kitemviews/kitemlistcontroller.h 134e116 dolphin/src/kitemviews/kitemlistcontroller.cpp 2e32880 dolphin/src/kitemviews/kitemlistkeyboardmanager.h PRE-CREATION dolphin/src/kitemviews/kitemlistkeyboardmanager.cpp PRE-CREATION dolphin/src/kitemviews/kitemmodelbase.h 4670469 dolphin/src/kitemviews/kitemmodelbase.cpp fc604e7 Diff: http://git.reviewboard.kde.org/r/102465/diff Testing --- yes. tested and works. Thanks, Tirtha
Re: Review Request: Find list items by typing their initial letters.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- (Updated Aug. 27, 2011, 11:22 p.m.) Review request for KDE Base Apps and Peter Penz. Changes --- Sorry for yet another diff :-) But i made some significant code changes in this one (removed a slot, etc), so posted it. Will commit this tomorrow morning. Summary --- This patch allows finding items by typing on the keyboard while the KItemListController is in focus. Timer and key queuing is handled by KItemListKeyboardManager, and search itself is done by reimplementing indexForKeyboardSearch(QString) from KItemModelBase. This implementation does not, at the moment, take care of the repetitive typing as suggested by Frank. I think we can implement that once this is in. p.s. Not sure if line 213 in kitemlistcontroller.cpp is the best way to do it. Returning true does not work. p.s. I feel the name KItemListKeyboardManager can be changed to KItemListKeyboardSearchManager, although a little too big. Diffs (updated) - dolphin/src/CMakeLists.txt 31d3f89 dolphin/src/kitemviews/kfileitemmodel.h 654c7db dolphin/src/kitemviews/kfileitemmodel.cpp f36ab83 dolphin/src/kitemviews/kitemlistcontroller.h 134e116 dolphin/src/kitemviews/kitemlistcontroller.cpp 2e32880 dolphin/src/kitemviews/kitemmodelbase.h 4670469 dolphin/src/kitemviews/kitemmodelbase.cpp fc604e7 Diff: http://git.reviewboard.kde.org/r/102465/diff Testing --- yes. tested and works. Thanks, Tirtha
Re: Review Request: Find list items by typing their initial letters.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- (Updated Aug. 28, 2011, 12:21 p.m.) Review request for KDE Base Apps and Peter Penz. Changes --- Sorry for yet another diff, but as Frank pointed out, I had missed the files of KItemListKeyboardSearchManager class. Also, made the change suggested by Frank. Summary --- This patch allows finding items by typing on the keyboard while the KItemListController is in focus. Timer and key queuing is handled by KItemListKeyboardManager, and search itself is done by reimplementing indexForKeyboardSearch(QString) from KItemModelBase. This implementation does not, at the moment, take care of the repetitive typing as suggested by Frank. I think we can implement that once this is in. p.s. Not sure if line 213 in kitemlistcontroller.cpp is the best way to do it. Returning true does not work. p.s. I feel the name KItemListKeyboardManager can be changed to KItemListKeyboardSearchManager, although a little too big. Diffs (updated) - dolphin/src/CMakeLists.txt 31d3f89 dolphin/src/kitemviews/kfileitemmodel.h 654c7db dolphin/src/kitemviews/kfileitemmodel.cpp f36ab83 dolphin/src/kitemviews/kitemlistcontroller.h 134e116 dolphin/src/kitemviews/kitemlistcontroller.cpp 2e32880 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp PRE-CREATION dolphin/src/kitemviews/kitemlistkeyboardsearchmanager_p.h PRE-CREATION dolphin/src/kitemviews/kitemmodelbase.h 4670469 dolphin/src/kitemviews/kitemmodelbase.cpp fc604e7 Diff: http://git.reviewboard.kde.org/r/102465/diff Testing --- yes. tested and works. Thanks, Tirtha
Re: Review Request: Find list items by typing their initial letters.
On Aug. 28, 2011, 12:49 p.m., Peter Penz wrote: Looks fine! Please just push it to master after fixing the minor const-comments. Pushed to master. I forgot to mention the review number in the commit message. - Tirtha --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/#review6096 --- On Aug. 28, 2011, 12:21 p.m., Tirtha Chatterjee wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- (Updated Aug. 28, 2011, 12:21 p.m.) Review request for KDE Base Apps and Peter Penz. Summary --- This patch allows finding items by typing on the keyboard while the KItemListController is in focus. Timer and key queuing is handled by KItemListKeyboardManager, and search itself is done by reimplementing indexForKeyboardSearch(QString) from KItemModelBase. This implementation does not, at the moment, take care of the repetitive typing as suggested by Frank. I think we can implement that once this is in. p.s. Not sure if line 213 in kitemlistcontroller.cpp is the best way to do it. Returning true does not work. p.s. I feel the name KItemListKeyboardManager can be changed to KItemListKeyboardSearchManager, although a little too big. Diffs - dolphin/src/CMakeLists.txt 31d3f89 dolphin/src/kitemviews/kfileitemmodel.h 654c7db dolphin/src/kitemviews/kfileitemmodel.cpp f36ab83 dolphin/src/kitemviews/kitemlistcontroller.h 134e116 dolphin/src/kitemviews/kitemlistcontroller.cpp 2e32880 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp PRE-CREATION dolphin/src/kitemviews/kitemlistkeyboardsearchmanager_p.h PRE-CREATION dolphin/src/kitemviews/kitemmodelbase.h 4670469 dolphin/src/kitemviews/kitemmodelbase.cpp fc604e7 Diff: http://git.reviewboard.kde.org/r/102465/diff Testing --- yes. tested and works. Thanks, Tirtha
Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- (Updated Aug. 28, 2011, 11:33 p.m.) Review request for KDE Base Apps and Peter Penz. Changes --- Here's a new diff, after the design changes we discussed over mail. It incorporates all of them. Summary --- Allow opening files and directories by pressing 'Enter' key. In case multiple files are selected when enter is pressed, all of them are opened. In case of multiple directories, the first directory gets opened in the current tab, while the other directories open in new tabs. Diffs (updated) - dolphin/src/CMakeLists.txt b443aa7 dolphin/src/kitemviews/kfileitemmodel.h 0fecbcf dolphin/src/kitemviews/kfileitemmodel.cpp c2f49f7 dolphin/src/kitemviews/kitemlistcontainer.cpp 0d2637d dolphin/src/kitemviews/kitemlistcontroller.h 04d4985 dolphin/src/kitemviews/kitemlistcontroller.cpp 207535c dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp 34633d6 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager_p.h cf41f3b dolphin/src/kitemviews/kitemlistview.h 9977e36 dolphin/src/kitemviews/kitemlistview.cpp a35752a dolphin/src/kitemviews/kitemmodelbase.h c4e0464 dolphin/src/kitemviews/kitemmodelbase.cpp 69f62bc dolphin/src/views/dolphinview.h 437f12f dolphin/src/views/dolphinview.cpp 959e4da plasma/applets/folderview/plasma-applet-folderview.desktop 03fbfff Diff: http://git.reviewboard.kde.org/r/102450/diff Testing --- Yes, tested and working. Thanks, Tirtha
Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- Review request for KDE Base Apps and Peter Penz. Summary --- Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, whether files should be opened on single or double clicks), and functions accordingly. Diffs - dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47 Diff: http://git.reviewboard.kde.org/r/102447/diff Testing --- Yes tested and works. Thanks, Tirtha
Review Request: Allow externally deleted files to be removed from view in Dolphin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102435/ --- Review request for KDE Base Apps and Peter Penz. Summary --- Currently, if a file is deleted by an external application, and the directory containing that file is open in Dolphin, the change is not reflected in Dolphin until we refresh. This patch fixes it. Diffs - dolphin/src/kitemviews/kfileitemmodel.cpp 189aa75 Diff: http://git.reviewboard.kde.org/r/102435/diff Testing --- Yes, tested locally. Thanks, Tirtha
