Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- (Updated Aug. 27, 2011, 7:31 a.m.) Review request for KDE Base Apps and Peter Penz. Changes --- Made the suggested changes, also now respecting KGlobalSettings::changeCursorOverIcon() Summary --- Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, whether files should be opened on single or double clicks), and functions accordingly. Diffs (updated) - dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47 Diff: http://git.reviewboard.kde.org/r/102447/diff Testing --- Yes tested and works. Thanks, Tirtha
Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102447/#review6042
---
dolphin/src/kitemviews/kitemlistcontroller.cpp
http://git.reviewboard.kde.org/r/102447/#comment5320
Should be:
bool emitItemClicked = KGlobalSettings::singleClick() ||
(event-button() != Qt::LeftButton);
otherwise opening a context-menu does not work anymore in the doubleclick
mode (or middleclicking is not possible).
dolphin/src/kitemviews/kitemlistcontroller.cpp
http://git.reviewboard.kde.org/r/102447/#comment5321
Should be something like:
const bool useDoubleClick = !KGlobalSettings::singleClick()
(event-buttons() Qt::LeftButton)
index = 0 index m_model-count();
if (useDoubleClick) {
to work correctly with the change done above.
Thanks, works nice! Please push it to master after fixing the two minor issues
above.
- Peter
On Aug. 26, 2011, 8:51 p.m., Tirtha Chatterjee wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102447/
---
(Updated Aug. 26, 2011, 8:51 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM,
whether files should be opened on single or double clicks), and functions
accordingly.
Diffs
-
dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47
Diff: http://git.reviewboard.kde.org/r/102447/diff
Testing
---
Yes tested and works.
Thanks,
Tirtha
Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6050 --- Thanks for the update, but could you please revert the changes with KGlobalSettings::changeCursorOverIcon()? I consider this option an unnecessary micro-option and plan to implement the same behavior as in Dolphin 1.7. - Peter On Aug. 27, 2011, 7:31 a.m., Tirtha Chatterjee wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- (Updated Aug. 27, 2011, 7:31 a.m.) Review request for KDE Base Apps and Peter Penz. Summary --- Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, whether files should be opened on single or double clicks), and functions accordingly. Diffs - dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47 Diff: http://git.reviewboard.kde.org/r/102447/diff Testing --- Yes tested and works. Thanks, Tirtha
Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6056 --- This review has been submitted with commit b0db096e4a3efc58da1c341b9259eb890e90d451 by Tirtha Chatterjee to branch master. - Commit On Aug. 27, 2011, 7:31 a.m., Tirtha Chatterjee wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- (Updated Aug. 27, 2011, 7:31 a.m.) Review request for KDE Base Apps and Peter Penz. Summary --- Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, whether files should be opened on single or double clicks), and functions accordingly. Diffs - dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47 Diff: http://git.reviewboard.kde.org/r/102447/diff Testing --- Yes tested and works. Thanks, Tirtha
Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.
On Aug. 27, 2011, 9:31 a.m., Peter Penz wrote: Thanks for the update, but could you please revert the changes with KGlobalSettings::changeCursorOverIcon()? I consider this option an unnecessary micro-option and plan to implement the same behavior as in Dolphin 1.7. Tirtha Chatterjee wrote: Yeah sure. But TBH, it does feel a bit odd if a pointing hand cursor does not appear, and the folder opens on a single click. Reverting it, and committing for now. Thanks for pushing this! But TBH, it does feel a bit odd if a pointing hand cursor does not appear, and the folder opens on a single click We'll introduce the pointing hand cursor later, but: - not as an option - and first the selection markers need to be reintroduced again, as this will make the code for the pointing hand a little bit more complicated - Peter --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6050 --- On Aug. 27, 2011, 7:31 a.m., Tirtha Chatterjee wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- (Updated Aug. 27, 2011, 7:31 a.m.) Review request for KDE Base Apps and Peter Penz. Summary --- Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, whether files should be opened on single or double clicks), and functions accordingly. Diffs - dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47 Diff: http://git.reviewboard.kde.org/r/102447/diff Testing --- Yes tested and works. Thanks, Tirtha
