Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9347 --- Ship it! Looks good now. lxr finds no other usage of the mimetype. - David On 2010-12-20 21:52:20, Rex Dieter wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-20 21:52:20) Review request for kdelibs. Summary --- This patch adjusts the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspackage instead). Addresses bugs #235564, #250924 Diffs - /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 1208169 /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/kcmfontinst/FontList.cpp 1208169 /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/kcmfontinst/KCmFontInst.cpp 1208169 /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/thumbnail/FontThumbnail.cpp 1208169 /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/viewpart/FontViewPart.cpp 1208169 /trunk/KDE/kdelibs/mimetypes/kde.xml 1206489 Diff: http://svn.reviewboard.kde.org/r/6111/diff Testing --- confirmed no warnings/errors from desktop-file-utils/shared-mime-info Thanks, Rex
Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain
On 2010-12-13 16:48:31, Ingo Klöcker wrote: How about using vnd.kde.fontspackage instead of x-kde-fontspackage? Rex Dieter wrote: I only used x-kde-fontspackage at aaron's suggestion in one of the aforementioned bugs, I'm not attached to it. vnd.kde.fontspackage is fine with me too. Christopher Yeleighton wrote: How about submitting a registration of application/vnd.kde.fontspackage to IETF first? vnd.registrations are just let go. I could prepare the registration form, but some KDE VIP would have to sign it. Rex Dieter wrote: OK (?), I'm not familiar with that, so any assistance would be appreciated. 1. Where is a definitive description of the purpose and the content of the media type? 2. All registrations in the KDE domain are submitted by David Fauré; accordingly, his opinion on the matter would be greatly appreciated. - Christopher --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9232 --- On 2010-12-13 17:07:48, Rex Dieter wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-13 17:07:48) Review request for kdelibs. Summary --- This patch adjusts the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspackage instead). Addresses bugs #235564, #250924 Diffs - /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 1206154 /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 Diff: http://svn.reviewboard.kde.org/r/6111/diff Testing --- confirmed no warnings/errors from desktop-file-utils/shared-mime-info Thanks, Rex
Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain
On 2010-12-14 12:59:34, David Faure wrote: The real question is whether this mimetype is used for files, or only for internal fake purposes. If for files, then it should be added to shared-mime-info (Pino or I can help with that). But if I remember correctly in this case it's not about files, which is why a fake mimetype is used. In that case, I'd rather not reuse an existing file mimetype, but rather use a kde-specific fake name. The mime definition in kde.xml seems to imply it's for real *.fonts.zip file globs. svn log kde.xml doesn't seem to include any mention of fonts/package origin though. :( (and I don't see anything in branches/KDE/3.5 either) - Rex --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9248 --- On 2010-12-13 17:07:48, Rex Dieter wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-13 17:07:48) Review request for kdelibs. Summary --- This patch adjusts the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspackage instead). Addresses bugs #235564, #250924 Diffs - /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 1206154 /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 Diff: http://svn.reviewboard.kde.org/r/6111/diff Testing --- confirmed no warnings/errors from desktop-file-utils/shared-mime-info Thanks, Rex
Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- Review request for kdelibs. Summary --- This patch adjusts the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/x-kde-fontspackage instead). Addresses bugs #235564, #250924 Diffs - /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 1206154 /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 Diff: http://svn.reviewboard.kde.org/r/6111/diff Testing --- confirmed no warnings/errors from desktop-file-utils/shared-mime-info Thanks, Rex
Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9232 --- How about using vnd.kde.fontspackage instead of x-kde-fontspackage? - Ingo On 2010-12-13 16:30:38, Rex Dieter wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-13 16:30:38) Review request for kdelibs. Summary --- This patch adjusts the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/x-kde-fontspackage instead). Addresses bugs #235564, #250924 Diffs - /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 1206154 /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 Diff: http://svn.reviewboard.kde.org/r/6111/diff Testing --- confirmed no warnings/errors from desktop-file-utils/shared-mime-info Thanks, Rex
Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain
On 2010-12-13 16:48:31, Ingo Klöcker wrote: How about using vnd.kde.fontspackage instead of x-kde-fontspackage? I only used x-kde-fontspackage at aaron's suggestion in one of the aforementioned bugs, I'm not attached to it. vnd.kde.fontspackage is fine with me too. - Rex --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9232 --- On 2010-12-13 17:07:48, Rex Dieter wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-13 17:07:48) Review request for kdelibs. Summary --- This patch adjusts the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspackage instead). Addresses bugs #235564, #250924 Diffs - /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 1206154 /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 Diff: http://svn.reviewboard.kde.org/r/6111/diff Testing --- confirmed no warnings/errors from desktop-file-utils/shared-mime-info Thanks, Rex
Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain
On 2010-12-13 16:48:31, Ingo Klöcker wrote: How about using vnd.kde.fontspackage instead of x-kde-fontspackage? Rex Dieter wrote: I only used x-kde-fontspackage at aaron's suggestion in one of the aforementioned bugs, I'm not attached to it. vnd.kde.fontspackage is fine with me too. How about submitting a registration of application/vnd.kde.fontspackage to IETF first? vnd.registrations are just let go. I could prepare the registration form, but some KDE VIP would have to sign it. - Christopher --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9232 --- On 2010-12-13 17:07:48, Rex Dieter wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-13 17:07:48) Review request for kdelibs. Summary --- This patch adjusts the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspackage instead). Addresses bugs #235564, #250924 Diffs - /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 1206154 /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 Diff: http://svn.reviewboard.kde.org/r/6111/diff Testing --- confirmed no warnings/errors from desktop-file-utils/shared-mime-info Thanks, Rex
