Re: Review Request: Fix missing ... in KBookmarkAction displayed text
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5682 --- This review has been submitted with commit 3cc10496aa6eb4aae27b8b6b473d5d8c0ef8df2b by Yoann Laissus to branch KDE/4.7. - Commit On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/ --- (Updated Aug. 9, 2011, 3:32 p.m.) Review request for kdelibs. Summary --- When a bookmark name, is too long, its name is truncated with ... at the middle. But, QAction strip those three dots by default. This patch solves this issue by defining imageText. Diffs - kio/bookmarks/kbookmarkmenu.cc 873f4a8 Diff: http://git.reviewboard.kde.org/r/102262/diff Testing --- It works with Konqueror and rekonq. Thanks, Yoann
Re: Review Request: Fix missing ... in KBookmarkAction displayed text
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5621 --- Ship it! Ah, I see. Indeed after reading QAction::iconText() it's all clear ;) But yeah this is quite obviously a bug in qaction (qt_strippedText), which should remove ... only at the end. - David On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/ --- (Updated Aug. 9, 2011, 3:32 p.m.) Review request for kdelibs. Summary --- When a bookmark name, is too long, its name is truncated with ... at the middle. But, QAction strip those three dots by default. This patch solves this issue by defining imageText. Diffs - kio/bookmarks/kbookmarkmenu.cc 873f4a8 Diff: http://git.reviewboard.kde.org/r/102262/diff Testing --- It works with Konqueror and rekonq. Thanks, Yoann
Re: Review Request: Fix missing ... in KBookmarkAction displayed text
On Aug. 11, 2011, 9:13 a.m., David Faure wrote: Ah, I see. Indeed after reading QAction::iconText() it's all clear ;) But yeah this is quite obviously a bug in qaction (qt_strippedText), which should remove ... only at the end. It's my first patch in kdelibs, where should i push it ? In frameworks and KDE/4.7 ? - Yoann --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5621 --- On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/ --- (Updated Aug. 9, 2011, 3:32 p.m.) Review request for kdelibs. Summary --- When a bookmark name, is too long, its name is truncated with ... at the middle. But, QAction strip those three dots by default. This patch solves this issue by defining imageText. Diffs - kio/bookmarks/kbookmarkmenu.cc 873f4a8 Diff: http://git.reviewboard.kde.org/r/102262/diff Testing --- It works with Konqueror and rekonq. Thanks, Yoann
Re: Review Request: Fix missing ... in KBookmarkAction displayed text
On Aug. 9, 2011, 10:45 p.m., David Faure wrote: Since you're setting iconText, this is about actions into a toolbar, not into a menu, right? So Qt strips ... from toolbar button texts? What's the logic there? I'm just curious, the patch looks ok, from your description. The logic behind this stripping is to show Open instead of Open... on toolbar buttons. Ideally, Qt would only strip trailing ellipsis, but it doesn't, probably to handle trailing spaces etc. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5554 --- On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/ --- (Updated Aug. 9, 2011, 3:32 p.m.) Review request for kdelibs. Summary --- When a bookmark name, is too long, its name is truncated with ... at the middle. But, QAction strip those three dots by default. This patch solves this issue by defining imageText. Diffs - kio/bookmarks/kbookmarkmenu.cc 873f4a8 Diff: http://git.reviewboard.kde.org/r/102262/diff Testing --- It works with Konqueror and rekonq. Thanks, Yoann
Re: Review Request: Fix missing ... in KBookmarkAction displayed text
On Aug. 9, 2011, 10:45 p.m., David Faure wrote: Since you're setting iconText, this is about actions into a toolbar, not into a menu, right? So Qt strips ... from toolbar button texts? What's the logic there? I'm just curious, the patch looks ok, from your description. Christoph Feck wrote: The logic behind this stripping is to show Open instead of Open... on toolbar buttons. Ideally, Qt would only strip trailing ellipsis, but it doesn't, probably to handle trailing spaces etc. Yes, and this fix is only for bookmark actions in a toolbar. - Yoann --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5554 --- On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/ --- (Updated Aug. 9, 2011, 3:32 p.m.) Review request for kdelibs. Summary --- When a bookmark name, is too long, its name is truncated with ... at the middle. But, QAction strip those three dots by default. This patch solves this issue by defining imageText. Diffs - kio/bookmarks/kbookmarkmenu.cc 873f4a8 Diff: http://git.reviewboard.kde.org/r/102262/diff Testing --- It works with Konqueror and rekonq. Thanks, Yoann
Review Request: Fix missing ... in KBookmarkAction displayed text
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/ --- Review request for kdelibs. Summary --- When a bookmark name, is too long, its name is truncated with ... at the middle. But, QAction strip those three dots by default. This patch solves this issue by defining imageText. Diffs - kio/bookmarks/kbookmarkmenu.cc 873f4a8 Diff: http://git.reviewboard.kde.org/r/102262/diff Testing --- It works with Konqueror and rekonq. Thanks, Yoann
Re: Review Request: Fix missing ... in KBookmarkAction displayed text
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5554 --- Since you're setting iconText, this is about actions into a toolbar, not into a menu, right? So Qt strips ... from toolbar button texts? What's the logic there? I'm just curious, the patch looks ok, from your description. - David On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/ --- (Updated Aug. 9, 2011, 3:32 p.m.) Review request for kdelibs. Summary --- When a bookmark name, is too long, its name is truncated with ... at the middle. But, QAction strip those three dots by default. This patch solves this issue by defining imageText. Diffs - kio/bookmarks/kbookmarkmenu.cc 873f4a8 Diff: http://git.reviewboard.kde.org/r/102262/diff Testing --- It works with Konqueror and rekonq. Thanks, Yoann
