Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44806 --- This review has been submitted with commit 40ded3efd3fa093247dd24e5b99d802536eda68a by Patrick von Reth to branch KDE/4.11. - Commit Hook On July 1, 2013, 5:17 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 5:17 p.m.) Review request for kde-workspace, KInfoCenter and kwin. Repository: kde-workspace Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
On July 1, 2013, 3:27 p.m., Martin Gräßlin wrote: from my side it looks OK, though I won't give a ship-it. This is a decision to the kinfocenter developers whether they are fine with the ifdefs. we'd like to include it in the next release and since the last message in this review request is 4 months old, I'd like to ping it again... - Nico --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review35374 --- On July 1, 2013, 5:17 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 5:17 p.m.) Review request for kde-workspace, KInfoCenter and kwin. Repository: kde-workspace Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44671 --- Ship it! Besides the i18n misssing, sure, ship it, i don't see any huge problem (not kinfoncenter myself but not sure we have one) kinfocenter/Modules/devinfo/soldevicetypes.cpp http://git.reviewboard.kde.org/r/111342/#comment31894 i18n missing - Albert Astals Cid On July 1, 2013, 5:17 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 5:17 p.m.) Review request for kde-workspace, KInfoCenter and kwin. Repository: kde-workspace Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44724 --- Hi, I maintain KInfoCenter :) Also agree on the shipping it, somehow I missed this when it was submitted :( - David Stephen Hubner On July 1, 2013, 5:17 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 5:17 p.m.) Review request for kde-workspace, KInfoCenter and kwin. Repository: kde-workspace Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- Review request for kde-workspace and kwin. Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review35347 --- Not that I could comment on whether it's useful or not on Windows, but my recommendation is to remove the complete Graphical Information subtree on Windows. kinfocenter/Modules/base/os_base.h http://git.reviewboard.kde.org/r/111342/#comment25898 why is this else part needed? If something is still accessing Display it should probably better be ifdefed there. - Martin Gräßlin On July 1, 2013, 1:33 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 1:33 p.m.) Review request for kde-workspace and kwin. Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 1:14 p.m.) Review request for kde-workspace and kwin. Changes --- fixed ifdef so there is no need to define Display anymore Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs (updated) - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review35374 --- from my side it looks OK, though I won't give a ship-it. This is a decision to the kinfocenter developers whether they are fine with the ifdefs. - Martin Gräßlin On July 1, 2013, 3:14 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 3:14 p.m.) Review request for kde-workspace and kwin. Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 5:17 p.m.) Review request for kde-workspace, KInfoCenter and kwin. Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
