Review Request 117779: fix crash when textureNode->texture() is null

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/
---

Review request for kde-workspace and Plasma.


Repository: plasma-framework


Description
---

fix crash when textureNode->texture() is null

I get this crash very frequently on my system. This is probably only fixing
the symptom and not the underlying issue, however at least plasma no longer
crashes every few minutes


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 
59255f75994adb96b30fb503c759b2e9110ab708 

Diff: https://git.reviewboard.kde.org/r/117779/diff/


Testing
---

No longer crashes


Thanks,

Alexander Richardson

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56577
---



src/declarativeimports/core/windowthumbnail.cpp


try before this call.


- Thomas Lübking


On April 25, 2014, 9:41 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> ---
> 
> (Updated April 25, 2014, 9:41 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> fix crash when textureNode->texture() is null
> 
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 59255f75994adb96b30fb503c759b2e9110ab708 
> 
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
> 
> 
> Testing
> ---
> 
> No longer crashes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Alexander Richardson]

> On April 25, 2014, 11:44 p.m., Thomas Lübking wrote:
> > src/declarativeimports/core/windowthumbnail.cpp, line 231
> > 
> >
> > try before this call.

Okay, just thought I'd exit early in that case and not bother with the other 
stuff. However is this an appropriate fix, or should it be done somewhere else?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56577
---


On April 25, 2014, 11:41 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> ---
> 
> (Updated April 25, 2014, 11:41 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> fix crash when textureNode->texture() is null
> 
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 59255f75994adb96b30fb503c759b2e9110ab708 
> 
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
> 
> 
> Testing
> ---
> 
> No longer crashes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Thomas Lübking]

> On April 25, 2014, 9:44 p.m., Thomas Lübking wrote:
> > src/declarativeimports/core/windowthumbnail.cpp, line 231
> > 
> >
> > try before this call.
> 
> Alexander Richardson wrote:
> Okay, just thought I'd exit early in that case and not bother with the 
> other stuff. However is this an appropriate fix, or should it be done 
> somewhere else?

No idea (don't know the code), but that'd apparently be the crash location 
while the texture might still be generated above - so it has to work here, not 
before.

It would crash because the texture has never been set and just for the function 
name i'd assume that to be the bug.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56577
---


On April 25, 2014, 9:41 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> ---
> 
> (Updated April 25, 2014, 9:41 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> fix crash when textureNode->texture() is null
> 
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 59255f75994adb96b30fb503c759b2e9110ab708 
> 
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
> 
> 
> Testing
> ---
> 
> No longer crashes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/
---

(Updated April 26, 2014, 12:51 a.m.)


Review request for kde-workspace and Plasma.


Repository: plasma-framework


Description
---

fix crash when textureNode->texture() is null

I get this crash very frequently on my system. This is probably only fixing
the symptom and not the underlying issue, however at least plasma no longer
crashes every few minutes


Diffs (updated)
-

  src/declarativeimports/core/windowthumbnail.cpp 
59255f75994adb96b30fb503c759b2e9110ab708 

Diff: https://git.reviewboard.kde.org/r/117779/diff/


Testing
---

No longer crashes


Thanks,

Alexander Richardson

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56587
---


I'd rather not want to see us hide this crash. There is an underlying problem 
which needs a more proper fix. I recently hit this problem myself on one on my 
systems and a crash one can reproduce is as good as fixed ;-)

- Martin Gräßlin


On April 26, 2014, 12:51 a.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> ---
> 
> (Updated April 26, 2014, 12:51 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> fix crash when textureNode->texture() is null
> 
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 59255f75994adb96b30fb503c759b2e9110ab708 
> 
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
> 
> 
> Testing
> ---
> 
> No longer crashes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56707
---


did you notice any pattern which triggers the crash? That could help me to 
reproduce and find the root cause.

- Martin Gräßlin


On April 26, 2014, 12:51 a.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> ---
> 
> (Updated April 26, 2014, 12:51 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> fix crash when textureNode->texture() is null
> 
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 59255f75994adb96b30fb503c759b2e9110ab708 
> 
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
> 
> 
> Testing
> ---
> 
> No longer crashes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Martin Gräßlin]

> On April 28, 2014, 10:24 a.m., Martin Gräßlin wrote:
> > did you notice any pattern which triggers the crash? That could help me to 
> > reproduce and find the root cause.

I found the condition myself:

1. show thumbnail
2. let it hide again
3. show thumbnail for same task

when switching to another task crash does not happen.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56707
---


On April 26, 2014, 12:51 a.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> ---
> 
> (Updated April 26, 2014, 12:51 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> fix crash when textureNode->texture() is null
> 
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 59255f75994adb96b30fb503c759b2e9110ab708 
> 
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
> 
> 
> Testing
> ---
> 
> No longer crashes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Martin Gräßlin]

> On April 26, 2014, 8:22 a.m., Martin Gräßlin wrote:
> > I'd rather not want to see us hide this crash. There is an underlying 
> > problem which needs a more proper fix. I recently hit this problem myself 
> > on one on my systems and a crash one can reproduce is as good as fixed ;-)

fix for underlying problem: https://git.reviewboard.kde.org/r/117824/


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56587
---


On April 26, 2014, 12:51 a.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> ---
> 
> (Updated April 26, 2014, 12:51 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> fix crash when textureNode->texture() is null
> 
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 59255f75994adb96b30fb503c759b2e9110ab708 
> 
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
> 
> 
> Testing
> ---
> 
> No longer crashes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

Re: Review Request 117779: fix crash when textureNode->texture() is null

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/
---

(Updated April 30, 2014, 2:21 p.m.)


Status
--

This change has been discarded.


Review request for kde-workspace and Plasma.


Repository: plasma-framework


Description
---

fix crash when textureNode->texture() is null

I get this crash very frequently on my system. This is probably only fixing
the symptom and not the underlying issue, however at least plasma no longer
crashes every few minutes


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 
59255f75994adb96b30fb503c759b2e9110ab708 

Diff: https://git.reviewboard.kde.org/r/117779/diff/


Testing
---

No longer crashes


Thanks,

Alexander Richardson