Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Remove deprecation for NET::timestampCompare and NET::timestampDiff The deprecated note recommended to use the methods in KXUtils namespace, but those are in a private header and that's not going to change. As the methods are used by applications (e.g. KWin) it should not get deprecated if there is no replacement. Diffs - src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 Diff: https://git.reviewboard.kde.org/r/116941/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kinit_master_qt5 #43
See http://build.kde.org/job/kinit_master_qt5/43/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116894: Clean up comments that reference kde4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 21, 2014, 10:02 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- Clean up comments about removed syscoca type numbers Remove explanation of why the desktoptojson target is exported The explanation was wrong, and it doesn't really need any justification anyway. Remove comment about test finding kmailservice from KDE4 It won't find the wrong kmailservice, because the desktop file is now called kmailservice5. Diffs - autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 src/desktoptojson/CMakeLists.txt f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116894: Clean up comments that reference kde4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 21, 2014, 10:02 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- Clean up comments about removed syscoca type numbers Remove explanation of why the desktoptojson target is exported The explanation was wrong, and it doesn't really need any justification anyway. Remove comment about test finding kmailservice from KDE4 It won't find the wrong kmailservice, because the desktop file is now called kmailservice5. Diffs - autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 src/desktoptojson/CMakeLists.txt f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116894: Clean up comments that reference kde4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/#review53632 --- This review has been submitted with commit 4f4fd18b9710a8ac2a47ccb23ef4ec8e95092713 by Alex Merry to branch master. - Commit Hook On March 19, 2014, 11:26 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 19, 2014, 11:26 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Clean up comments about removed syscoca type numbers Remove explanation of why the desktoptojson target is exported The explanation was wrong, and it doesn't really need any justification anyway. Remove comment about test finding kmailservice from KDE4 It won't find the wrong kmailservice, because the desktop file is now called kmailservice5. Diffs - autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 src/desktoptojson/CMakeLists.txt f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116894: Clean up comments that reference kde4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 21, 2014, 10:02 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- Clean up comments about removed syscoca type numbers Remove explanation of why the desktoptojson target is exported The explanation was wrong, and it doesn't really need any justification anyway. Remove comment about test finding kmailservice from KDE4 It won't find the wrong kmailservice, because the desktop file is now called kmailservice5. Diffs - autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 src/desktoptojson/CMakeLists.txt f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116894: Clean up comments that reference kde4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/#review53631 --- This review has been submitted with commit 335353d1bcb131b00537e3d079a2f96f463ee845 by Alex Merry to branch master. - Commit Hook On March 19, 2014, 11:26 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 19, 2014, 11:26 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Clean up comments about removed syscoca type numbers Remove explanation of why the desktoptojson target is exported The explanation was wrong, and it doesn't really need any justification anyway. Remove comment about test finding kmailservice from KDE4 It won't find the wrong kmailservice, because the desktop file is now called kmailservice5. Diffs - autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 src/desktoptojson/CMakeLists.txt f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116894: Clean up comments that reference kde4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/#review53633 --- This review has been submitted with commit cd279a18e04212633f12d418d40924116a7700d2 by Alex Merry to branch master. - Commit Hook On March 19, 2014, 11:26 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116894/ --- (Updated March 19, 2014, 11:26 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Clean up comments about removed syscoca type numbers Remove explanation of why the desktoptojson target is exported The explanation was wrong, and it doesn't really need any justification anyway. Remove comment about test finding kmailservice from KDE4 It won't find the wrong kmailservice, because the desktop file is now called kmailservice5. Diffs - autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 src/desktoptojson/CMakeLists.txt f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.
On Fri, Mar 21, 2014 at 12:45 PM, David Faure fa...@kde.org wrote: On Wednesday 05 March 2014 10:44:24 Kevin Ottens wrote: Hello, On Tuesday 04 March 2014 22:54:42 David Faure wrote: On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote: It wasn't that transparent at all - a number of modules have been re- downloaded in a different location in my local source directory: * plasma-frameworks moved under playground/libs Maybe time to get this one moved to frameworks. I don't think playground/libs still makes sense for it. I agree. Aaron, any objections? Ben, can you make the change? I'm not sure what has to be done exactly to move a project in the p.k.o hierarchy (is that documented anywhere?) All that needs to be done is for an admin to login on projects.kde.org and move the project. The controls for this are located on the General tab of the project settings. However, I do need to ask if plasma-framework needs to go through KDE Review due to the substantially new nature of the code involved. * kactivities moved under kde/kdelibs/kactivities (a very odd location in the frameworks world, but kde_projects.xml is global, not branch-dependent) Ideally should be under frameworks at some point. I'd rather have it odd in the kde4 world now. :-) Me too... I guess most people compiling all of KDE SC are starting to look at frameworks by now indeed, let's move both. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Frameworksintegration of QFileDialog::getExistingDirectory (was: add test for QFileDialog::getExistingDirectory / bug?)
On Wed, Mar 19, 2014 at 8:26 PM, Aleix Pol aleix...@kde.org wrote: Hi Dominik, I've been looking though it and it seems like in this case we should be showing KDirSelectDialog instead of a QDialog+KFileWidget, depending on the result of options()-testOption(QFileDialogOptions::ShowDirsOnly). I don't really have the time of doing it this week, but I'd certainly would like to have it. If you want to work on it I can review and give you a hand, if you can't this will have to be done before frameworksintegration is released. Have anyone started looking into this? Otherwise I'll give it a try this afternoon. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Re: Frameworksintegration of QFileDialog::getExistingDirectory (was: add test for QFileDialog::getExistingDirectory / bug?)
On Friday, March 21, 2014 12:05:51 Martin Klapetek wrote: On Wed, Mar 19, 2014 at 8:26 PM, Aleix Pol aleix...@kde.org wrote: Hi Dominik, I've been looking though it and it seems like in this case we should be showing KDirSelectDialog instead of a QDialog+KFileWidget, depending on the result of options()-testOption(QFileDialogOptions::ShowDirsOnly). I don't really have the time of doing it this week, but I'd certainly would like to have it. If you want to work on it I can review and give you a hand, if you can't this will have to be done before frameworksintegration is released. Have anyone started looking into this? Otherwise I'll give it a try this afternoon. No, and I probably won't have time for this in the near future. But I'll happily test it! Thanks, Dominik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116952: Make sure non-prefixed desktop files win when looking up by name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Make sure non-prefixed desktop files win when looking up by name The existing code resolved all the overrides (based on storage id), then if there were multiple desktop files with the same id (say konsole.desktop and kde4/konsole.desktop), it would arbitrarily (due to the use of QHash) pick one of them to return from KService::serviceByDesktopName(), regardless of where in XDG_DATA_DIRS it was found. So you might get serviceByDesktopName(konsole) giving you kde4/konsole.desktop and serviceByDesktopName(amarok) giving you amarok.desktop (even if kde4/amarok.desktop also exists). This change makes desktop files without a prefix (like konsole.desktop) override ones with a prefix (like kde4/konsole.desktop). If you also have kde5/konsole.desktop, the ordering between that and kde4/konsole.desktop is still arbitrary, and the order of XDG_DATA_DIRS is ignored. Remove the prefix hacks from KService::serviceByDesktopName() These didn't work; the desktop file kde4/konsole.desktop will only be listed under the desktop name konsole, not under the name kde4-konsole. Add a test app for the KService::serviceBy* methods Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservice.cpp 192682b514a69c41fb84231f3b04ec6e9218d587 tests/CMakeLists.txt 47894e5a6175dac924c2e700b2dafe936590cc1b tests/findservice.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116952/diff/ Testing --- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 21, 2014, 3:41 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Add serviceByDesktopPath to the test app Repository: kservice Description --- Make sure non-prefixed desktop files win when looking up by name The existing code resolved all the overrides (based on storage id), then if there were multiple desktop files with the same id (say konsole.desktop and kde4/konsole.desktop), it would arbitrarily (due to the use of QHash) pick one of them to return from KService::serviceByDesktopName(), regardless of where in XDG_DATA_DIRS it was found. So you might get serviceByDesktopName(konsole) giving you kde4/konsole.desktop and serviceByDesktopName(amarok) giving you amarok.desktop (even if kde4/amarok.desktop also exists). This change makes desktop files without a prefix (like konsole.desktop) override ones with a prefix (like kde4/konsole.desktop). If you also have kde5/konsole.desktop, the ordering between that and kde4/konsole.desktop is still arbitrary, and the order of XDG_DATA_DIRS is ignored. Remove the prefix hacks from KService::serviceByDesktopName() These didn't work; the desktop file kde4/konsole.desktop will only be listed under the desktop name konsole, not under the name kde4-konsole. Add a test app for the KService::serviceBy* methods Diffs (updated) - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservice.cpp 192682b514a69c41fb84231f3b04ec6e9218d587 tests/CMakeLists.txt 47894e5a6175dac924c2e700b2dafe936590cc1b tests/findservice.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116952/diff/ Testing --- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116935: Remove use of KLibrary in KLauncher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Remove use of KLibrary in KLauncher All the non-valgrind code paths that invoke kioslave let it do the lookup of the module, so the valgrind path can as well. Also adjusted the USE_KPROCESS_FOR_KIOSLAVES code path so that the kioslave executable is actually included in the arguments to valgrind. Diffs - src/klauncher/klauncher.cpp a8630854af4bd3094b9688c3f9a40d10516d2056 Diff: https://git.reviewboard.kde.org/r/116935/diff/ Testing --- In combination with https://git.reviewboard.kde.org/r/116934/ Ran KDE_SLAVE_VALGRIND=file kdeinit5 and use the kioslavetest app to copy a file; the copy was successful, and the terminal running kdeinit5 output kdeinit5: preparing to launch '/usr/bin/valgrind' ==20134== Memcheck, a memory error detector ==20134== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al. ==20134== Using Valgrind-3.9.0 and LibVEX; rerun with -h for copyright info ==20134== Command: /home/kf5-devel/kf5/lib64/kde5/libexec/kioslave kio_file file local:/tmp/runtime-kf5-devel/klauncherJ19850.slave-socket local:/tmp/runtime-kf5-devel/kioslavetestJ20122.slave-socket ==20134== (20134)/(default) [31m[34mmain[0m: trying to load kio_file from /home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so ==20134== ==20134== HEAP SUMMARY: ==20134== in use at exit: 5,846 bytes in 42 blocks ==20134== total heap usage: 998 allocs, 956 frees, 672,987 bytes allocated ==20134== ==20134== LEAK SUMMARY: ==20134==definitely lost: 0 bytes in 0 blocks ==20134==indirectly lost: 0 bytes in 0 blocks ==20134== possibly lost: 0 bytes in 0 blocks ==20134==still reachable: 5,846 bytes in 42 blocks ==20134== suppressed: 0 bytes in 0 blocks ==20134== Rerun with --leak-check=full to see details of leaked memory ==20134== ==20134== For counts of detected and suppressed errors, rerun with: -v ==20134== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 1 from 1) Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116934: Use KPluginLoader to find kioslaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 21, 2014, 3:49 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description (updated) --- Use KPluginLoader to find kioslaves KIO slaves are typically installed in PLUGIN_INSTALL_DIR, rather than QT_PLUGIN_INSTALL_DIR, so we should use KPluginLoader instead of QPluginLoader to locate them. NB: https://git.reviewboard.kde.org/r/116938/ would allow the use of KPluginLoader::findPlugin() Diffs - src/core/slave.cpp ee84066f96675caaf1fa5ba612c8242eac160c4a src/kioslave/CMakeLists.txt 64bf7e0f36a1a407dd162e2c0461dedb2f57a13e src/kioslave/kioslave.cpp 50413d04be29361638ba581383354d79881e844e Diff: https://git.reviewboard.kde.org/r/116934/diff/ Testing --- In combination with https://git.reviewboard.kde.org/r/116935/ Ran KDE_SLAVE_VALGRIND=file kdeinit5 and use the kioslavetest app to copy a file; the copy was successful, and the terminal running kdeinit5 output kdeinit5: preparing to launch '/usr/bin/valgrind' ==20134== Memcheck, a memory error detector ==20134== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al. ==20134== Using Valgrind-3.9.0 and LibVEX; rerun with -h for copyright info ==20134== Command: /home/kf5-devel/kf5/lib64/kde5/libexec/kioslave kio_file file local:/tmp/runtime-kf5-devel/klauncherJ19850.slave-socket local:/tmp/runtime-kf5-devel/kioslavetestJ20122.slave-socket ==20134== (20134)/(default) [31m[34mmain[0m: trying to load kio_file from /home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so ==20134== ==20134== HEAP SUMMARY: ==20134== in use at exit: 5,846 bytes in 42 blocks ==20134== total heap usage: 998 allocs, 956 frees, 672,987 bytes allocated ==20134== ==20134== LEAK SUMMARY: ==20134==definitely lost: 0 bytes in 0 blocks ==20134==indirectly lost: 0 bytes in 0 blocks ==20134== possibly lost: 0 bytes in 0 blocks ==20134==still reachable: 5,846 bytes in 42 blocks ==20134== suppressed: 0 bytes in 0 blocks ==20134== Rerun with --leak-check=full to see details of leaked memory ==20134== ==20134== For counts of detected and suppressed errors, rerun with: -v ==20134== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 1 from 1) For the change to src/core/slave.cpp, ran KDE_FORK_SLAVES=1 ./kioslavetest and did the same test; uncommented the debug line in that method so it printed kioslave , /home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so , file , , QUrl( local:/tmp/runtime-kf5-devel/kioslavetestJ32621.slave-socket ) and the copy was successful. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 21, 2014, 3:50 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove defunct plugin-loading code, and deprecate KLibrary KLibrary::factory() tried to load kde3-style plugins (not unreasonable to drop support for) and kdelibs4-style plugins (which do not work, since they depended on Qt support). It now does nothing. This and the KPluginFactory::findPlugin() method leave KLibrary with no purpose, so deprecate it. Improve the KPluginLoader documentation Give KPluginLoader a public static findPlugin method I noticed that several bits of code used KLibrary or KPluginLoader to find a plugin, then proceeded to just use QLibrary to resolve functions from it. This method allows that to be done without actually creating a KPluginLoader instance that is then only used for its fileName() method. Diffs - src/plugin/kpluginloader.h 8621914890bf704213d33108d01032a7b36b3484 src/plugin/kpluginloader.cpp 53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6 src/plugin/klibrary.h 78f0701e01b0a24e8895127640ce575e09d93d7c src/plugin/klibrary.cpp c77ec32dbb1cbd1ccd6342a082012d2c82575fb8 Diff: https://git.reviewboard.kde.org/r/116938/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116927: Fix kdeinit module lookup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116927/#review53702 --- this seems to broke kded modules loading here: Cannot load library /usr/lib64/libkdeinit5_kio_file: (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No such file or directory) - Hrvoje Senjan On March 20, 2014, 10:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116927/ --- (Updated March 20, 2014, 10:18 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Fix kdeinit module lookup KLibrary's lookup magic is not so magic these days - is just uses QCoreApplication::libraryPaths, which is not what we want. Instead, we let dlopen() do the searching for us, plus hack in a check in the library installation directory for kinit (since dlopen() called from Qt does not respect kdeinit5's RUNPATH). This should cover most common cases (module installed to standard location, module installed to same location as the kinit framework, mdoule in LD_LIBRARY_PATH), and if it still fails we just fall back to the normal executable. Rename kinit_library_path() to generate_socket_name() This reflects what the function actually does. Also got rid of the (mostly) ifdef'd-out code that gave the function its original name. Add comment about fragility of lookup based on installation vars Diffs - src/kdeinit/CMakeLists.txt c4e3c49ea28d4e96be9ee1fa02f801052945d01e src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 Diff: https://git.reviewboard.kde.org/r/116927/diff/ Testing --- Built and installed. Ran kdeinit5, which reported that it was launching libkdeinit5_klauncher, rather than /home/kf5-devel/kf5/bin/klauncher as it did previously. klauncher process then has [kdeinit] in its process title in `ps xu`. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116955: Remove KDE 4 refs from Doxyfile.global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116955/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Remove KDE 4 refs from Doxyfile.global The port4 command is no longer relevant, and @glossary now just says Glossary instead of KDE 4 Glossary. Diffs - src/kapidox/data/Doxyfile.global 96cb1c13ffeb78d0e35460c7697342a878d97786 Diff: https://git.reviewboard.kde.org/r/116955/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116927: Fix kdeinit module lookup
On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: this seems to broke kded modules loading here: Cannot load library /usr/lib64/libkdeinit5_kio_file: (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No such file or directory) err, s/kded modules/kio plugins - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116927/#review53702 --- On March 20, 2014, 10:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116927/ --- (Updated March 20, 2014, 10:18 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Fix kdeinit module lookup KLibrary's lookup magic is not so magic these days - is just uses QCoreApplication::libraryPaths, which is not what we want. Instead, we let dlopen() do the searching for us, plus hack in a check in the library installation directory for kinit (since dlopen() called from Qt does not respect kdeinit5's RUNPATH). This should cover most common cases (module installed to standard location, module installed to same location as the kinit framework, mdoule in LD_LIBRARY_PATH), and if it still fails we just fall back to the normal executable. Rename kinit_library_path() to generate_socket_name() This reflects what the function actually does. Also got rid of the (mostly) ifdef'd-out code that gave the function its original name. Add comment about fragility of lookup based on installation vars Diffs - src/kdeinit/CMakeLists.txt c4e3c49ea28d4e96be9ee1fa02f801052945d01e src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 Diff: https://git.reviewboard.kde.org/r/116927/diff/ Testing --- Built and installed. Ran kdeinit5, which reported that it was launching libkdeinit5_klauncher, rather than /home/kf5-devel/kf5/bin/klauncher as it did previously. klauncher process then has [kdeinit] in its process title in `ps xu`. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 21, 2014, 9:26 a.m.) Review request for KDE Frameworks. Changes --- Updated copyright Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116886: Refactor private variables of KCompletion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53705 --- Ship it! Looks reasonable to me, thanks! - Frank Reininghaus On March 19, 2014, 11:01 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/ --- (Updated March 19, 2014, 11:01 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Refactor private variables of KCompletion Also: reorder variables declaration to avoid padding Diffs - src/kcompletion.cpp 7396029 src/kcompletion_p.h e3fad26 Diff: https://git.reviewboard.kde.org/r/116886/diff/ Testing --- It builds. Autotests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #168
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/168/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116957/ --- Review request for KDE Frameworks. Repository: kde4support Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs - tests/kfstest.cpp b85b5372afe6106568c26c73f1eab97bfa90c9ce Diff: https://git.reviewboard.kde.org/r/116957/diff/ Testing --- kfstest still behaves as expected. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116957/ --- (Updated March 21, 2014, 5:05 p.m.) Review request for KDE Frameworks. Changes --- Update diff to include amending a comment. Repository: kde4support Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs (updated) - src/kio/kfiledialog.h ccf327fe78acf71918578bbb72578c83f7dacd92 tests/kfstest.cpp b85b5372afe6106568c26c73f1eab97bfa90c9ce Diff: https://git.reviewboard.kde.org/r/116957/diff/ Testing --- kfstest still behaves as expected. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116958: Update comment referencing fake MIME types
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116958/ --- Review request for KDE Frameworks. Repository: kservice Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservicetypeprofile.h d14955d112e973d45a1387ee6db79b0c09949b23 Diff: https://git.reviewboard.kde.org/r/116958/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116960: @since KDE 4.1 - @since 4.1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- @since KDE 4.1 - @since 4.1 This is consistent with other @since and @deprecated macros. Remove code with KDE4: Port me Clearly no-one missed it in the last few years. Diffs - src/kcompletionbox.cpp 92e87b39c17cab96afb395bc77fabef95992c80b src/klineedit.h c7c46b587c23f342d1c0bc959164fdc95277609e Diff: https://git.reviewboard.kde.org/r/116960/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116960: @since KDE 4.1 - @since 4.1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/#review53708 --- Ship it! Ship It! - David Gil Oliva On March 21, 2014, 5:33 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/ --- (Updated March 21, 2014, 5:33 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- @since KDE 4.1 - @since 4.1 This is consistent with other @since and @deprecated macros. Remove code with KDE4: Port me Clearly no-one missed it in the last few years. Diffs - src/kcompletionbox.cpp 92e87b39c17cab96afb395bc77fabef95992c80b src/klineedit.h c7c46b587c23f342d1c0bc959164fdc95277609e Diff: https://git.reviewboard.kde.org/r/116960/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116961: Replace fake MIME type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116961/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. There are a few other references to all/all, all/allfiles, and all/ in this repo. I didn't touch them since it wasn't suggested to do so on the mailing list post, and I'm not too familiar with this code. Diffs - src/filewidgets/kfilefiltercombo.cpp a800b38a50a4cb3c7b89928e09b6be9d8bc19ca0 Diff: https://git.reviewboard.kde.org/r/116961/diff/ Testing --- Played with some consumers of filewidgets which seems to behave normally, but again I'm not particularly familiar with what's happening here. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116962: Clean up KDE4 references in kconfig
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/
---
Review request for KDE Frameworks.
Repository: kconfig
Description
---
Update docs for KDesktopFile::isAuthorizedDesktopFile()
The fact that it changed in KDE 4.3 is not so relevant any more.
Remove unhelpful comments
These lines of code do not really require any justification.
Better comment for why KDesktopFile::readPath uses readEntry
Remove old kdelibs4 code
All this ifdef'd-out code just makes it hard to see what's going on.
Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}
Not sure why it would be unset and then used, instead of just not used
at all. LXR says it's not used anywhere else, though.
Diffs
-
KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047
KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309
src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500
src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34
src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4
src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0
src/kconfig_compiler/CMakeLists.txt 71f2609d870cd00eae3d98c0f3a07504d5973ff0
Diff: https://git.reviewboard.kde.org/r/116962/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116960: @since KDE 4.1 - @since 4.1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/#review53710 --- This review has been submitted with commit 349966d4f08a9c7936fe8a6bcf4b728635f4f87d by Alex Merry to branch master. - Commit Hook On March 21, 2014, 5:33 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/ --- (Updated March 21, 2014, 5:33 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- @since KDE 4.1 - @since 4.1 This is consistent with other @since and @deprecated macros. Remove code with KDE4: Port me Clearly no-one missed it in the last few years. Diffs - src/kcompletionbox.cpp 92e87b39c17cab96afb395bc77fabef95992c80b src/klineedit.h c7c46b587c23f342d1c0bc959164fdc95277609e Diff: https://git.reviewboard.kde.org/r/116960/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116960: @since KDE 4.1 - @since 4.1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/ --- (Updated March 21, 2014, 6:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- @since KDE 4.1 - @since 4.1 This is consistent with other @since and @deprecated macros. Remove code with KDE4: Port me Clearly no-one missed it in the last few years. Diffs - src/kcompletionbox.cpp 92e87b39c17cab96afb395bc77fabef95992c80b src/klineedit.h c7c46b587c23f342d1c0bc959164fdc95277609e Diff: https://git.reviewboard.kde.org/r/116960/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116960: @since KDE 4.1 - @since 4.1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/#review53724 --- Hi! You didn't submit the modification of kcompletionbox. Should I patch it (I'm about to modify that class) or will you do it? Ah! And thanks, BTW :-) - David Gil Oliva On March 21, 2014, 6:26 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/ --- (Updated March 21, 2014, 6:26 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- @since KDE 4.1 - @since 4.1 This is consistent with other @since and @deprecated macros. Remove code with KDE4: Port me Clearly no-one missed it in the last few years. Diffs - src/kcompletionbox.cpp 92e87b39c17cab96afb395bc77fabef95992c80b src/klineedit.h c7c46b587c23f342d1c0bc959164fdc95277609e Diff: https://git.reviewboard.kde.org/r/116960/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116886: Refactor private variables of KCompletion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53725 --- This review has been submitted with commit d7a60b8d6437090ef9009e5bfc7899d866bc39a4 by David Gil to branch master. - Commit Hook On March 19, 2014, 11:01 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/ --- (Updated March 19, 2014, 11:01 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Refactor private variables of KCompletion Also: reorder variables declaration to avoid padding Diffs - src/kcompletion.cpp 7396029 src/kcompletion_p.h e3fad26 Diff: https://git.reviewboard.kde.org/r/116886/diff/ Testing --- It builds. Autotests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116939: Add deprecation info to kcombobox, kcompletionbase and klineedit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116939/#review53727 --- This review has been submitted with commit 40abd56bb2a6b855c2a697502b4607f7ff79d074 by David Gil to branch master. - Commit Hook On March 20, 2014, 11:16 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116939/ --- (Updated March 20, 2014, 11:16 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- See summary Diffs - src/kcombobox.h eea930d src/kcompletionbase.h 8022214 src/klineedit.h 76a1f01 Diff: https://git.reviewboard.kde.org/r/116939/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116939: Add deprecation info to kcombobox, kcompletionbase and klineedit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116939/ --- (Updated March 21, 2014, 9:19 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- See summary Diffs - src/kcombobox.h eea930d src/kcompletionbase.h 8022214 src/klineedit.h 76a1f01 Diff: https://git.reviewboard.kde.org/r/116939/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Reorder private variables of KLineEditPrivate to avoid padding. In my 32bits box the size goes down from 124 to 116. Diffs - src/klineedit_p.h 09cf8b4 Diff: https://git.reviewboard.kde.org/r/116966/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116967: Fix doc in KUrlPixmapProvider
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116967/ --- Review request for KDE Frameworks. Repository: kio Description --- Fix doc in KUrlPixmapProvider Diffs - src/widgets/kurlpixmapprovider.h 41ed05a Diff: https://git.reviewboard.kde.org/r/116967/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116968: Fix doc in KToolBarLabelAction
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/ --- Review request for KDE Frameworks. Repository: kwidgetsaddons Description --- Fix doc in KToolBarLabelAction KHistoryCombo - KHistoryComboBox Diffs - src/ktoolbarlabelaction.h 3c6978e Diff: https://git.reviewboard.kde.org/r/116968/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Remove private reset() and move the implementation to the public reset() Move method to public Q_SLOTS section Diffs - src/khistorycombobox.h d1f5eac src/khistorycombobox.cpp 80261ae Diff: https://git.reviewboard.kde.org/r/116969/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116970: Remove wish in KComboBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116970/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Remove wish in KComboBox Diffs - src/kcombobox.h 42de884 Diff: https://git.reviewboard.kde.org/r/116970/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox Diffs - src/kcombobox.h 42de884 src/kcombobox.cpp 30edc1b Diff: https://git.reviewboard.kde.org/r/116971/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/ --- Review request for kdelibs. Repository: kdelibs Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. Diffs - kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie
Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/ --- (Updated March 21, 2014, 2:39 p.m.) Review request for kdelibs. Repository: kdelibs Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. Diffs (updated) - kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie
Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/#review53689 --- kio/kio/kdbusservicestarter.cpp https://git.reviewboard.kde.org/r/116951/#comment37656 there is a check for error not being a null pointer in line 74, so it could pontentially be 0 here as well - Kevin Krammer On March 21, 2014, 2:39 p.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/ --- (Updated March 21, 2014, 2:39 p.m.) Review request for kdelibs. Repository: kdelibs Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. Diffs - kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie
Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/ --- (Updated March 21, 2014, 3:10 p.m.) Review request for kdelibs. Changes --- Fix null pointer access. Repository: kdelibs Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. Diffs (updated) - kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie
Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/#review53690 --- Looks good to me but maybe someone closer to KIO can confirm that - Kevin Krammer On March 21, 2014, 3:10 p.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/ --- (Updated March 21, 2014, 3:10 p.m.) Review request for kdelibs. Repository: kdelibs Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. Diffs - kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie
Review Request 116953: Create a ksysguard kded module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116953/ --- Review request for kde-workspace and John Tapsell. Repository: kde-workspace Description --- Create a ksysguard kded module This module is responsible for launching the system activity dialog which krunner used to spawn on pressing Ctrl + Escape. The KSystemActivityDialog has been moved from kde-workspace/krunner/ Diffs - krunner/ksystemactivitydialog.h d72bebd krunner/ksystemactivitydialog.cpp 5c4bcac ksysguard/CMakeLists.txt 35f11f3 ksysguard/kded/CMakeLists.txt PRE-CREATION ksysguard/kded/kded_ksysguard.desktop PRE-CREATION ksysguard/kded/kdedksysguard.h PRE-CREATION ksysguard/kded/kdedksysguard.cpp PRE-CREATION ksysguard/kded/ksystemactivitydialog.h PRE-CREATION ksysguard/kded/ksystemactivitydialog.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116953/diff/ Testing --- Thanks, Vishesh Handa
Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116956/ --- Review request for KDE Runtime, Plasma and Martin Gräßlin. Repository: kde-runtime Description --- kde-runtime will soon get an alpha release. Because both KF5 and kdelibs4 applications should be able to be installed and run it should be co-installable with kde-runtime from KDE 4 times. Starting at the top of the cmake file I've renamed kglobalaccel to see if it's sane to do so. Diffs - kglobalaccel/org.kde.kglobalaccel.service.in d8576b0 kglobalaccel/CMakeLists.txt 8bc8bea kglobalaccel/kglobalaccel.desktop a61516e kglobalaccel/kglobalaccel.notifyrc 9e3ecd3 kglobalaccel/kglobalaccel5.desktop PRE-CREATION kglobalaccel/kglobalaccel5.notifyrc PRE-CREATION kglobalaccel/main.cpp d788b64 Diff: https://git.reviewboard.kde.org/r/116956/diff/ Testing --- Thanks, Jonathan Riddell
Re: UI Guidelines
On 13 July 2013 11:44, Christoph Feck christ...@maxiom.de wrote: On Saturday 13 July 2013 00:03:16 Lindsay Mathieson wrote: Is it ok for std KDE apps to majorly depart from std UI guidelines? We cannot force the guidelines, only recommend them. As a user, you could report those issues to the bug tracker of affected applications, in the hope developers understand that users might prefer consistency instead of diversity. See also http://mobile.osnews.com/printer.php?news_id=26085 Damn - do we really want to go down this route? https://bugs.kde.org/show_bug.cgi?id=322010 The menu bar was too technical and has been removed Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: meinproc4 on Mac, KLocale (was Re: What to test for 4.13?)
On 20/03/2014, at 7:28 AM, mk-li...@email.de wrote: On 19 Mar 2014, at 06:29 , Thomas Lübking thomas.luebk...@gmail.com wrote: There seems a known issue reg. multithreaded libxml2 [1], but since Marko was the reporter, i simply ruled it out being the remaining one. I doubt it was a libxml2 issue, since the corresponding poster wrote — pHi on windows we had a similar crash./p divThe problem was in libxml2, when builded with multithread support.Disabling multithread fixed it./div — The crash I described back then happened with KMyMoney, but did occur for any other KDE software arbitrarily every now and then. I think in order to reproduce the error I’d also need to build stuff highly parallel with all 8 cores and in an an endless loop, but I’d need to get familiar with parallel and stuff alike, I am afraid… Well, let’s see what Ian can come up with once he’s done with partying his birthday. ;-) Heh! Well, I am not any kind of KDE genius and kdoctools is foreign territory for me. It's hard enough for me to write that .docbook format of documentation … :-) I tried a little script to get meinproc4 to fail by executing several copies in parallel. for game in killbots kjumpingcube konquest kpat kubrick kgoldrunner palapeli do echo meinproc4 for $game cd /kdedev/games/$game/doc /opt/local/bin/meinproc4 --check --cache /kdedev/build/games/$game/doc/index.cache.bz2 /kdedev/games/$game/doc/index.docbook done IOW, run meinproc4 for seven games Handbooks at once. The main command is what eventuates from CMake and make when you are installing documentation. /keddev is my KDE development area and /opt/local/bin is where MacPorts puts utilities (though not GUI applications, which require to be installed in a special way on Mac OS X). It was all over in a second or two, with a spike of about 1.5 cores on Apple's Activity Monitor. No crashes. But then meinproc4 never fails for me. Then I wrapped a do forever loop around the above --- and then it crashed, but it was hardly a fair test: writing seven output files an unknown number of times at once. So I think we can discount the concurrency-problem theory. In any case, I had a look at https://trac.macports.org/attachment/ticket/41326/main.log a huge log file (25Mb) from a crash of meinproc4. I do not know what this run was doing (there seems to be no replay of the MacPorts command that started it), but there seem to be multiple commands that are aimed at building meinproc4 itself. What really happened? Anyway, there is just one attempt to execute meinproc4, AFAICS, and that is right near the end of that huge log file. So no concurrency. Anyway, the one backtrace we have (not from this run BTW) shows meinproc4 failing on its one and only call to KGlobal::locale(); at line 109 of file meinproc.cpp. That is part of meinproc4's initialisation, before it starts processing any input. That call to KGlobal::locale(); seems an odd one, KDE guys. That function is supposed to return a locale (KLocale *), but here it is executed as a procedure, ignoring the return result. I can only conclude that the code is being executed for its side-effects, see: http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/kglobal_8cpp_source.html#l00144 Macports guys, in https://trac.macports.org/attachment/ticket/41326/main.log, meinproc4 is actually running inside a script called meinproc4.shell, which I think may be generated by MacPorts. I wonder if meinproc4 has not been fully installed yet (it seems to be being built earlier on in the run). If so, I wonder if it is running from somewhere that is not its usual install location (i.e. not /opt/local/bin/meinproc4) or maybe it has been deprived of its usual KDE environment setup in some way, so that is why it cannot find a locale. One final idea. I see that there is a version of meinproc4 called meinproc4_simple, which the KDE translators use for some purpose which I cannot quite make out. Anyway, it appears to be a special-purpose version of meinproc4 and it is essentially a Qt-only application. I wonder if we could legislate the MacPorts meinproc4 bug out of existence by making another special-purpose version of meinproc4 that only takes in a .docbook file, checks it and spits out a .cache.bz2 file, thus omitting the code where meinproc4 appears to be crashing in the Apple OS X environment. That version could then be the one used to create Handbooks across all platforms. Just a thought. Cheers, Ian W. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 116919: Bug Fix for bug 329039
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116919/#review53634 --- src/file/filewatch.cpp https://git.reviewboard.kde.org/r/116919/#comment37648 Are you sure this compiles? src/file/metadatamover.h https://git.reviewboard.kde.org/r/116919/#comment37647 I'm confused. Why remove this function? - Vishesh Handa On March 20, 2014, 4:15 p.m., Nitul Datt wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116919/ --- (Updated March 20, 2014, 4:15 p.m.) Review request for Baloo and Vishesh Handa. Bugs: 329039 and bug http://bugs.kde.org/show_bug.cgi?id=329039 http://bugs.kde.org/show_bug.cgi?id=bug Repository: baloo Description --- Removed the internal queue from metadatamover. Now, events are processed as they arrive. Diffs - src/file/metadatamover.cpp 14d454a src/file/metadatamover.h d7975ec src/file/CMakeLists.txt c5dba49 src/file/filewatch.cpp c0ccf72 src/file/updaterequest.h 1844dff src/file/updaterequest.cpp 63dd9c5 Diff: https://git.reviewboard.kde.org/r/116919/diff/ Testing --- Thanks, Nitul Datt Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 116692: Lower memory usage of akonadi_baloo_indexer with frequent commits
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116692/#review53637 --- It turned out that most of the memory was used the ItemFetchJob loading all items into memory. We've now optimized this, and for me the indexer never goes beyond ~250MB (initial indexing), and during normal usage stays around 10MB. I made some experiments with notmuch mail (which also uses xapian), and it also stayed around 200MB. This could probably be further tweaked by adjusting XAPIAN_FLUSH_THRESHOLD to lower the amounts of commits that are held in memory, but IMO 250MB for the initial indexing is a sane default value. The only optimization that I think would be viable is releasing the memory again using malloc_free or alike (as we used to do in the nepomuk indexer). So have the recent fixes also fixed the memory consumption for you or do you still think this patch should go in? - Christian Mollekopf On March 10, 2014, 11:12 a.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116692/ --- (Updated March 10, 2014, 11:12 a.m.) Review request for Akonadi and Baloo. Repository: baloo Description --- Baloo is using Xapian for storing processed results from data fed to it by akonadi; in doing so it processes all the data it is sent to index and only once this is complete is the data committed to the Xapian database. From http://xapian.org/docs/apidoc/html/classXapian_1_1WritableDatabase.html#acbea2163142de795024880a7123bc693 we see: For efficiency reasons, when performing multiple updates to a database it is best (indeed, almost essential) to make as many modifications as memory will permit in a single pass through the database. To ensure this, Xapian batches up modifications. This means that *all* the data to be stored in the Xapian database first ends up in RAM. When indexing large mailboxes (or any other large chunk of data) this results in a very large amount of memory allocation. On one test of 100k mails in a maildir folder this resulted in 1.5GB of RAM used. In normal daily usage with maildir I find that it easily balloons to several hundred megabytes within day s. This makes the Baloo indexer unusable on systems with smaller amounts of memory (e.g. mobile devices, which typically have only 512MB-2GB of RAM) Making this even worse is that the indexer is both long-lived *and* the default glibc allocator is unable to return the used memory back to the OS (probably due to memory fragmentation, though I have not confirmed this). Use of other allocators shows the temporary ballooning of memory during processing, but once that is done the memory is released and returned back to the OS. As such, this is not a memory leak .. but it behaves like one on systems with the default glibc allocator with akonai_baloo_indexer taking increasingly large amounts of memory on the system that never get returned to the OS. (This is actually how I noticed the problem in the first place.) The approach used to address this problem is to periodically commit data to the Xapian database. This happens uniformly and transparently to the AbstractIndexer subclasses. The exact behavior is controlled by the s_maxUncommittedItems constant which is set arbitrarily to 100: after an indexer hits 100 uncommitted changes, the results are committed immediately. Caveats: * This is not a guaranteed fix for the memory fragmentation issue experienced with glibc: it is still possible for the memory to grow slowly over time as each smaller commit leaves some % of un-releasable memory due to fragmentation. It has helped with day to day usage here, but in the 100k mails in a maildir structure test memory did still balloon upwards. * It make indexing non-atomic from akonadi's perspective: data fed to akonadi_baloo_indexer to be indexed may show up in chunks and even, in the case of a crash of the indexer, be only partially added to the database. Alternative approaches (not necessarily mutually exclusive to this patch or each other): * send smaller data sets from akonadi to akonadi_baloo_indexer for processing. This would allow akonadi_baloo_indexer to retain the atomic commit approach while avoiding the worst of the Xapian memory usage; it would not address the issue of memory fragmentation * restart akonadi_baloo_indexer process from time to time; this would resolve the fragmentation-over-time issue but not the massive memory usage due to atomically indexing large datasets * improve Xapian's chert backend (to become default in 1.4) to not fragment memory so much; this would not address the
Re: Review Request 116919: Bug Fix for bug 329039
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116919/ --- (Updated March 21, 2014, 11:11 a.m.) Review request for Baloo and Vishesh Handa. Bugs: 329039 and bug http://bugs.kde.org/show_bug.cgi?id=329039 http://bugs.kde.org/show_bug.cgi?id=bug Repository: baloo Description --- Removed the internal queue from metadatamover. Now, events are processed as they arrive. Diffs (updated) - src/file/updaterequest.h 1844dff src/file/updaterequest.cpp 63dd9c5 src/file/CMakeLists.txt c5dba49 src/file/metadatamover.h d7975ec src/file/metadatamover.cpp 14d454a Diff: https://git.reviewboard.kde.org/r/116919/diff/ Testing --- Thanks, Nitul Datt Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 116919: Bug Fix for bug 329039
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116919/#review53639 --- Nice. We're fairly close now. Please run baloo/src/file/autotests/metadatamovertest and check if it passes. The tests do not pass on my machine. See if you can figure it out, otherwise I can help :) - Vishesh Handa On March 21, 2014, 11:11 a.m., Nitul Datt wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116919/ --- (Updated March 21, 2014, 11:11 a.m.) Review request for Baloo and Vishesh Handa. Bugs: 329039 and bug http://bugs.kde.org/show_bug.cgi?id=329039 http://bugs.kde.org/show_bug.cgi?id=bug Repository: baloo Description --- Removed the internal queue from metadatamover. Now, events are processed as they arrive. Diffs - src/file/updaterequest.h 1844dff src/file/updaterequest.cpp 63dd9c5 src/file/CMakeLists.txt c5dba49 src/file/metadatamover.h d7975ec src/file/metadatamover.cpp 14d454a Diff: https://git.reviewboard.kde.org/r/116919/diff/ Testing --- Thanks, Nitul Datt Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: meinproc4 on Mac, KLocale (was Re: What to test for 4.13?)
On Freitag, 21. März 2014 08:24:06 CEST, Ian Wadham wrote: That call to KGlobal::locale(); seems an odd one, KDE guys. That function is supposed to return a locale (KLocale *), but here it is executed as a procedure, ignoring the return result. I can only conclude that the code is being executed for its side-effects: It will likely be to call protected KLocale::initInstance(), eventually to intantiate it from the main thread for sure. Not sure if it's required at all - look at the date of the commit! commit 693da1d1df4876d7c898f3035beead76288872d5 Author: Stephan Kulow ..@kde.org Date: Fri Jul 6 15:19:46 2001 + update to docbook-xsl 1.40 [] -KGlobal::locale()-setMainCatalogue(kio_help); +KLocale::setMainCatalogue(kio_help); KInstance ins(meinproc); +KGlobal::locale(); [] Cheers, Tomas Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
