Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Ben Cooksley 
On Tue, Mar 14, 2017 at 11:28 AM, Brüns, Stefan
 wrote:
> On Montag, 13. März 2017 22:37:51 CET Albert Astals Cid wrote:
>> > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote:
>> > > Sorry for the long wait… I was under the impression it landed a long
>> > > time ago.
>> > >
>> > > Itook your patch and ported it to Frameworks 5, please see the review at
>> > > https://phabricator.kde.org/D5034
>
> Would be nice if you retained the original copyright.
>
> I have no phabricator account (and there is no method to register, AFAICT),
> which bars me from adding any comments there ...

Anyone with an Identity account can login on Phabricator.

>
> Kind regards,
>
> Stefan

Regards,
Ben Cooksley
KDE Sysadmin

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Ben Cooksley 
On Tue, Mar 14, 2017 at 11:28 AM, Brüns, Stefan
 wrote:
> On Montag, 13. März 2017 22:37:51 CET Albert Astals Cid wrote:
>> > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote:
>> > > Sorry for the long wait… I was under the impression it landed a long
>> > > time ago.
>> > >
>> > > Itook your patch and ported it to Frameworks 5, please see the review at
>> > > https://phabricator.kde.org/D5034
>
> Would be nice if you retained the original copyright.
>
> I have no phabricator account (and there is no method to register, AFAICT),
> which bars me from adding any comments there ...

Anyone with an Identity account can login on Phabricator.

>
> Kind regards,
>
> Stefan

Regards,
Ben Cooksley
KDE Sysadmin

D5037: KTextEditor: prevent accidental zooming

2017-03-13 Thread René J . V . Bertin 
rjvbb marked 2 inline comments as done.

REVISION DETAIL
  https://phabricator.kde.org/D5037

To: rjvbb, #ktexteditor
Cc: dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, 
sars

D5037: KTextEditor: prevent accidental zooming

2017-03-13 Thread René J . V . Bertin 
rjvbb updated this revision to Diff 12448.
rjvbb edited the test plan for this revision.
rjvbb added a comment.


  Was this what you had in mind?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5037?vs=12438=12448

REVISION DETAIL
  https://phabricator.kde.org/D5037

AFFECTED FILES
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: rjvbb, #ktexteditor
Cc: dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, 
sars

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Brüns , Stefan 
On Montag, 13. März 2017 22:37:51 CET Albert Astals Cid wrote:
> > On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote:
> > > Sorry for the long wait… I was under the impression it landed a long
> > > time ago.
> > > 
> > > Itook your patch and ported it to Frameworks 5, please see the review at
> > > https://phabricator.kde.org/D5034

Would be nice if you retained the original copyright.

I have no phabricator account (and there is no method to register, AFAICT), 
which bars me from adding any comments there ...

Kind regards,

Stefan

Re: Merging KMag frameworks branch to master

2017-03-13 Thread Albert Astals Cid 
El diumenge, 5 de març de 2017, a les 23:59:02 CET, Albert Astals Cid va 
escriure:
> I had a quick look and features seem to work as good/bad in the frameworks
> branch as in master.
> 
> If noone disagrees I'll do the merge on March 13th.

I have swamped myself in stuff this week and i don't think i'll be able to 
handle this before the dependency freeze.

If someone else agrees we're good enough to go, please merge, otherwise let's 
wait for 17.08.

Cheers,
  Albert

> 
> Cheers,
>   Albert

KDE Applications 17.04 getting close

2017-03-13 Thread Albert Astals Cid 
Make sure you're aware of these dates

March 16, 2017: KDE Applications 17.04 Dependency Freeze
March 23, 2017: KDE Applications 17.04 Freeze and Beta (17.03.80) tag & release
April  6, 2017: KDE Applications 17.04 RC (17.03.90) Tagging and Release
April 13, 2017: KDE Applications 17.04 Tagging
April 20, 2017: KDE Applications 17.04 Release

https://community.kde.org/Schedules/Applications/17.04_Release_Schedule

I'll most probably create the 17.04 branches this either saturday morning or 
sunday evening.

Cheers,
  Albert

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Stefan Brüns 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113587/
---

(Updated March 13, 2017, 9:37 p.m.)


Status
--

This change has been discarded.


Review request for kdelibs and Solid.


Repository: kdelibs


Description
---

These fstab options allows an administrator to specify names and icons intended 
for the user, shown in a GUI
For details, see 
https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt


Diffs
-

  solid/solid/backends/fstab/fstabdevice.h bac409e 
  solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
  solid/solid/backends/fstab/fstabhandling.h 4780a67 
  solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
  solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
  solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 

Diff: https://git.reviewboard.kde.org/r/113587/diff/


Testing
---

Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has 
changed


Thanks,

Stefan Brüns

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Albert Astals Cid 


> On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote:
> > Sorry for the long wait… I was under the impression it landed a long time 
> > ago.
> > 
> > Itook your patch and ported it to Frameworks 5, please see the review at 
> > https://phabricator.kde.org/D5034

I'll discard this one then.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113587/#review102827
---


On June 22, 2014, 1:39 a.m., Stefan Brüns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113587/
> ---
> 
> (Updated June 22, 2014, 1:39 a.m.)
> 
> 
> Review request for kdelibs and Solid.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> These fstab options allows an administrator to specify names and icons 
> intended for the user, shown in a GUI
> For details, see 
> https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt
> 
> 
> Diffs
> -
> 
>   solid/solid/backends/fstab/fstabdevice.h bac409e 
>   solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
>   solid/solid/backends/fstab/fstabhandling.h 4780a67 
>   solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
>   solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
>   solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
> 
> Diff: https://git.reviewboard.kde.org/r/113587/diff/
> 
> 
> Testing
> ---
> 
> Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has 
> changed
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Stefan Brüns 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113587/
---

(Updated March 13, 2017, 9:37 p.m.)


Status
--

This change has been discarded.


Review request for kdelibs and Solid.


Repository: kdelibs


Description
---

These fstab options allows an administrator to specify names and icons intended 
for the user, shown in a GUI
For details, see 
https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt


Diffs
-

  solid/solid/backends/fstab/fstabdevice.h bac409e 
  solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
  solid/solid/backends/fstab/fstabhandling.h 4780a67 
  solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
  solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
  solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 

Diff: https://git.reviewboard.kde.org/r/113587/diff/


Testing
---

Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has 
changed


Thanks,

Stefan Brüns

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Albert Astals Cid 


> On March 13, 2017, 2:29 p.m., Kai Uwe Broulik wrote:
> > Sorry for the long wait… I was under the impression it landed a long time 
> > ago.
> > 
> > Itook your patch and ported it to Frameworks 5, please see the review at 
> > https://phabricator.kde.org/D5034

I'll discard this one then.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113587/#review102827
---


On June 22, 2014, 1:39 a.m., Stefan Brüns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113587/
> ---
> 
> (Updated June 22, 2014, 1:39 a.m.)
> 
> 
> Review request for kdelibs and Solid.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> These fstab options allows an administrator to specify names and icons 
> intended for the user, shown in a GUI
> For details, see 
> https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt
> 
> 
> Diffs
> -
> 
>   solid/solid/backends/fstab/fstabdevice.h bac409e 
>   solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
>   solid/solid/backends/fstab/fstabhandling.h 4780a67 
>   solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
>   solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
>   solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
> 
> Diff: https://git.reviewboard.kde.org/r/113587/diff/
> 
> 
> Testing
> ---
> 
> Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has 
> changed
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

D5037: KTextEditor: prevent accidental zooming

2017-03-13 Thread Dominik Haumann 
dhaumann added a comment.


  Thinking aloud: Can you factor this out into a small helper class called 
WheelEventFilter or similar? I can imagine this would be cleaner.
  The code possibly would shrink down to something like:
  
if (m_wheelEventFilter.processEvent(event)) {
// ... zoom in / out
return;
}

INLINE COMMENTS

> kateviewinternal.cpp:3301
> +bool skip = false;
> +qint64 deltaT = m_lastWheelEvent.elapsed();
> +Qt::KeyboardModifiers modState = e->modifiers();

const qint64 ...

> kateviewinternal.cpp:3331
> +// ctrl pressed -> change font size (only if angle is reported and not 
> accidentally so)
> +// NB: if the ControlModifier is not unset at this point we'd get 
> accelerated scrolling.
> +if (!skip && modState == Qt::ControlModifier) {

Note: instead of NB (had to look it up)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5037

To: rjvbb, #ktexteditor
Cc: dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, 
sars

D5034: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> dhaumann wrote in fstabdevice.cpp:40-41
> Did you intentionally switch vendor and product?

I wondered that too, that's in the original patch, though, didn't really look 
into where this will end up, though :D

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D5034

To: broulik, #plasma, dfaure
Cc: dhaumann, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5034: Add support for x-gvfs style options in fstab

2017-03-13 Thread Dominik Haumann 
dhaumann added a comment.


  Just some minor comments, besides that, looks sane.

INLINE COMMENTS

> fstabdevice.cpp:40-41
> +if (m_device.startsWith(QLatin1String("//"))) {
> +m_vendor = m_device.mid(2, m_device.indexOf(QLatin1String("/"), 2) - 
> 2);
> +m_product = m_device.mid(m_device.indexOf(QLatin1String("/", 2)) + 
> 1);
>  } else {

Did you intentionally switch vendor and product?

> fstabdevice.cpp:51
> +if (option.startsWith(QLatin1String("x-gvfs-name="))) {
> +const QString encoded = 
> option.mid(option.indexOf(QLatin1String("="), 11) + 1);
> +m_description = QUrl::fromPercentEncoding(encoded.toLatin1());

QStringRef through midRef()

> fstabdevice.cpp:54
> +} else if (option.startsWith(QLatin1String("x-gvfs-icon="))) {
> +const QString encoded = 
> option.mid(option.indexOf(QLatin1String("="), 11) + 1);
> +m_iconName = QUrl::fromPercentEncoding(encoded.toLatin1());

likewise, use QStringRef

> fstabhandling.cpp:146
>  const QString mountpoint = QFile::decodeName(fe->mnt_dir);
> +const QStringList options = 
> QFile::decodeName(fe->mnt_opts).split(QLatin1Char(','), 
> QString::SkipEmptyParts);
>  

If you save the decodedName, you could also call splitRef() to avoid more 
allocations.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D5034

To: broulik, #plasma, dfaure
Cc: dhaumann, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: Commit notifications

2017-03-13 Thread Dominik Haumann 
Hi,

On Mon, Mar 13, 2017 at 1:21 PM, Kevin Funk  wrote:
> On Monday, 13 March 2017 13:57:01 CET Kåre Särs wrote:
>> Hi,
>
> Heya,
>
>> I want to do some changes to what git commit notifications I get and I
>> have searched the KDE web-pages to find the information on how to do
>> it, but no luck :(
>>
>> Almost all places I have searched mention commitfilter.kde.org, but that
>> server has been shut down some time go already.
>
>> What is the new place for this?
>
> There is none. commitfilter is still sending out mails, but there's no
> configuration interface anymore. That's sad. :(
>
> I'd welcome a resurrection or an alternative to commitfilter.

Interesting. I still rely on commitfilter.

Greetings
Dominik

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 465 - Unstable!

2017-03-13 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/465/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Mar 2017 19:52:43 +
Build duration: 19 min

CHANGE SET
Revision d804fb5ef43e1a8df033eeb890e03d61efdf14b1 by David Faure: (autotest: 
comment why the SSE-disabling thing doesn#039;t work (QTBUG-47566))
  change: edit autotests/kfileplacesmodeltest.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiocore-jobtestFailed: 
TestSuite.kiocore-klocalsocketservertestFailed: 
TestSuite.kiocore-klocalsockettest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 29970/52014 
(58%)CONDITIONAL 16401/39049 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7940/8288 
(96%)CONDITIONAL 4425/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8131/14181 
(57%)CONDITIONAL 4448/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3464/7561 
(46%)CONDITIONAL 1293/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 
(47%)CONDITIONAL 1266/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 
(63%)CONDITIONAL 420/851 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3661/11064 
(33%)CONDITIONAL 1752/7112 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 469 - Unstable!

2017-03-13 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/469/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Mar 2017 19:52:43 +
Build duration: 19 min

CHANGE SET
Revision d804fb5ef43e1a8df033eeb890e03d61efdf14b1 by David Faure: (autotest: 
comment why the SSE-disabling thing doesn#039;t work (QTBUG-47566))
  change: edit autotests/kfileplacesmodeltest.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiocore-klocalsocketservertestFailed: 
TestSuite.kiocore-klocalsockettest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 29958/52014 
(58%)CONDITIONAL 16382/39049 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7918/8288 
(96%)CONDITIONAL 4395/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8128/14181 
(57%)CONDITIONAL 4459/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3469/7561 
(46%)CONDITIONAL 1293/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 
(47%)CONDITIONAL 1266/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 
(63%)CONDITIONAL 420/851 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3669/11064 
(33%)CONDITIONAL 1754/7112 (25%)

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

2017-03-13 Thread Martin Gräßlin 


Am 13. März 2017 16:15:34 MEZ schrieb Kai Uwe Broulik :
>‎
>> Macs however always have two-fingers secondary click; their magic
>mouse have both (it's mouse-touchpad hybrid).
>
>If all else fails you could still Control click on Mac iirc.
>
>This feature would be useful for Plasma on touchscreens though, faking
>a right click on  *touch* long-press. Maybe that's an approach that's
>more pleasing to Martin G than doing that inside KWin which he said is
>the wrong place to do that.

It is not the wrong place, it is technically impossible to do it in KWin.
Generating context menu events must be in the applications. Only those can know 
what makes sense and know whether the touch event is handled or not.

In general I oppose the idea. I think we need to rethink and not emulating a 
decades old pattern, just because we don't have a better idea.
Especially in Plasma I would not like to see this. We can do better.

Cheers
Martin

D5037: KTextEditor: prevent accidental zooming

2017-03-13 Thread René J . V . Bertin 
rjvbb created this revision.
rjvbb added a project: KTextEditor.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  KTextEditor::KateViewInternal::wheelEvent() implements text zoom in reaction 
to Ctrl+Wheel events, something Qt also implements or used to implement for 
QTextEdit and/or QTextBrowser.
  Problems can occur with systems with a trackpad that use 2-finger scrolling 
and scroll inertia. These are subject to unexpected, accidental text zooming 
when the user holds presses the Ctrl key to trigger a shortcut (say, Ctrl-S to 
save the current document) before scroll coasting has stopped completely.
  
  The end of coasting isn't always clear: scroll events may continue to come in 
with sub-threshold deltas, or when the view has already reached its extreme 
position and can scroll no further. This affects me much more frequently than I 
would like in applications like KDevelop and is especially annoying since there 
is no standard shortcut to return to 100% (no zoom).
  
  Qt itself has a form of protection against this kind of annoyance on Mac and 
possibly other systems where inertial scrolling has better platform support 
than under X11.
  This patch provides what I hope is a reasonably minimal implementation of a 
similar protection that ignores Control modifier changes that occur within a 
certain lapse of time after the start of a series of wheel events.
  
  See also https://bugs.kde.org/show_bug.cgi?id=377562

TEST PLAN
  This is stripped-down version of a proof of concept designed by Thomas 
Lübking and me and well tested on Linux and Mac:
  
  https://github.com/RJVB/qtwheeltest/blob/master/wheeltest.cpp
  
  the timing parameters have been tuned in a rather ad-hoc fashion; the lower 
threshold is probably just fine as it is but the higher threshold could 
possibly be set lower. It represents the time one would have to hold down the 
Ctrl key before wheel events again cause zooming after the protection has 
triggered. Any wheel event without the modifier key set will also reset the 
timer.
  
  This is a patch that merits being tested in practice, not just reviewed in 
source code.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5037

AFFECTED FILES
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: rjvbb, #ktexteditor
Cc: kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, sars, 
dhaumann

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

2017-03-13 Thread Kai Uwe Broulik 
‎
> Macs however always have two-fingers secondary click; their magic mouse have 
> both (it's mouse-touchpad hybrid).

If all else fails you could still Control click on Mac iirc.

This feature would be useful for Plasma on touchscreens though, faking a right 
click on  *touch* long-press. Maybe that's an approach that's more pleasing to 
Martin G than doing that inside KWin which he said is the wrong place to do 
that.

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

2017-03-13 Thread Martin Klapetek 
On Sun, Mar 12, 2017 at 4:03 AM, René J.V. Bertin 
wrote:

> Hello,
>
> The other day I had to add a context menu to a widget (QPushbutton)
> defined in a .ui file and went a bit further when I realised it could be
> nice to be able to open such a menu without using a right-click or menu
> button. After all, not all platforms have a (physical) right mouse button
> or a menu key; Macs come to mind but also mobile devices.


> The usual way to open the context menu on such platforms is
> click/tap-and-hold - I think that was actually introduced in an early Mac
> OS X version.
>

Macs however always have two-fingers secondary click;
their magic mouse have both (it's mouse-touchpad hybrid).

Worth noting that the tap-and-hold is used only in very few
places of the macOS shell, like the bottom launcher and
Launchpad, pretty much nothing else accepts tap-and-hold
for context menu, certainly not any of the regular apps.
So I wouldn't say that is "the usual way" on mac at all.

Just to provide some more insight for non-mac folks.

Cheers
--
Martin Klapetek

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113587/#review102827
---



Sorry for the long wait… I was under the impression it landed a long time ago.

Itook your patch and ported it to Frameworks 5, please see the review at 
https://phabricator.kde.org/D5034

- Kai Uwe Broulik


On Juni 22, 2014, 1:39 vorm., Stefan Brüns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113587/
> ---
> 
> (Updated Juni 22, 2014, 1:39 vorm.)
> 
> 
> Review request for kdelibs and Solid.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> These fstab options allows an administrator to specify names and icons 
> intended for the user, shown in a GUI
> For details, see 
> https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt
> 
> 
> Diffs
> -
> 
>   solid/solid/backends/fstab/fstabdevice.h bac409e 
>   solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
>   solid/solid/backends/fstab/fstabhandling.h 4780a67 
>   solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
>   solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
>   solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
> 
> Diff: https://git.reviewboard.kde.org/r/113587/diff/
> 
> 
> Testing
> ---
> 
> Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has 
> changed
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

Re: Review Request 113587: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113587/#review102827
---



Sorry for the long wait… I was under the impression it landed a long time ago.

Itook your patch and ported it to Frameworks 5, please see the review at 
https://phabricator.kde.org/D5034

- Kai Uwe Broulik


On Juni 22, 2014, 1:39 vorm., Stefan Brüns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113587/
> ---
> 
> (Updated Juni 22, 2014, 1:39 vorm.)
> 
> 
> Review request for kdelibs and Solid.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> These fstab options allows an administrator to specify names and icons 
> intended for the user, shown in a GUI
> For details, see 
> https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt
> 
> 
> Diffs
> -
> 
>   solid/solid/backends/fstab/fstabdevice.h bac409e 
>   solid/solid/backends/fstab/fstabdevice.cpp 0c91c6a 
>   solid/solid/backends/fstab/fstabhandling.h 4780a67 
>   solid/solid/backends/fstab/fstabhandling.cpp e874ffd 
>   solid/solid/backends/fstab/fstabstorageaccess.h bbe93e3 
>   solid/solid/backends/fstab/fstabstorageaccess.cpp 5482d48 
> 
> Diff: https://git.reviewboard.kde.org/r/113587/diff/
> 
> 
> Testing
> ---
> 
> Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has 
> changed
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

D5034: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik 
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  These fstab options allows an administrator to specify names and icons 
intended for the user, shown in a GUI.
  
  For details, see 
https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt

TEST PLAN
  This is a frameworks port and cleanup of 
https://git.reviewboard.kde.org/r/113587
  
  Placed the following in `/etc/fstab`
  
hostname:/ /mnt/ nfs4 
defaults,_netdev,user,rw,exec,comment=x-gvfs-show,x-gvfs-name=Test%20Folder,x-gvfs-icon=folder-home,timeo=14,noatime
 0 0
  
  Got the following entry:
  F2800877: Screenshot_20170313_152729.png 

  Also verified that `comment=x-gvfs-hide` hides the entry. I did not implement 
`x-gvfs-show` as we always show all devices no matter where they are, so the 
override to forcefully show it is of no use to us.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D5034

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h

To: broulik, #plasma, dfaure
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: no krazy reports for extragear

2017-03-13 Thread Allen Winter 
On Saturday, March 11, 2017 08:33:35 PM Alexander Semke wrote:
> Hi all,
> 
> since couple of days there are no krazy reports for couple of extragear 
> projects:
> http://ebn.kde.org/krazy/index.php?component=extragear
> 
> Is there any reason for this?
> 
Fixed, mostly.
I see that the report generation for digikam is failing so I need to 
investigate that,
but it is a different problem.

Re: Commit notifications

2017-03-13 Thread Kevin Funk 
On Monday, 13 March 2017 13:57:01 CET Kåre Särs wrote:
> Hi,

Heya,
 
> I want to do some changes to what git commit notifications I get and I
> have searched the KDE web-pages to find the information on how to do
> it, but no luck :(
> 
> Almost all places I have searched mention commitfilter.kde.org, but that
> server has been shut down some time go already.
 
> What is the new place for this?

There is none. commitfilter is still sending out mails, but there's no 
configuration interface anymore. That's sad. :(

I'd welcome a resurrection or an alternative to commitfilter.

Bhushan (CC'd) wanted to start writing a new interface -- any progress in this 
regard?

Cheers,
Kevin

> Regards,
>   Kåre


-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2017-03-13 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129983/#review102826
---



I'm not sure if we should show the warning dialog at the kio_file level. This 
would result in a double dialog when deleting files with Shift+Del from file 
managers. What about making jobuidelegate.cpp smarter? It could show a more 
"scary" message if the file that's being deleted is write-protected.

- Elvis Angelaccio


On March 9, 2017, 3:57 p.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129983/
> ---
> 
> (Updated March 9, 2017, 3:57 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This is regarding the GSOC idea 
> https://community.kde.org/GSoC/2017/Ideas#Project:_Polkit_support_in_KIO.
> 
> This patch intends to demonstrate one possible approach to provide polkit 
> support in kio. Here its only for the delete operation. This is based on the 
> patch in task https://phabricator.kde.org/T5070.
> 
> The approach is as follows;
> 1. Whenever file ioslave gets access denied error it calls the method 
> *execWithRoot* with the action that requires priviledge, the path of items
>upon which action needs to be performed and a warning ID as arguments.
> 2. *execWithRoot* then executes the KAuth::Action *org.kde.kio.file.execute*. 
> 3. This Kauth::Action has its Persistence set too 'session'. This means that 
> after authentication the restrictions are dropped for a while, for
>about 5 minutes. This is similar to the behaviour of sudo command.
> 4. During this time we can perform any action as a privileged user without 
> any authentication. So to prevent any mishap i added a warning box which
>would popup before performing any action(only during this period).
> 5. After the said time interval the root privileges are droped and calling 
> *execWithRoot* should show the usual authentication dialog.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/file/CMakeLists.txt b9132ce 
>   src/ioslaves/file/file.h 109ea80 
>   src/ioslaves/file/file.cpp eaf6c88 
>   src/ioslaves/file/file_unix.cpp 82eb11a 
>   src/ioslaves/file/kauth/CMakeLists.txt PRE-CREATION 
>   src/ioslaves/file/kauth/file.actions PRE-CREATION 
>   src/ioslaves/file/kauth/helper.h PRE-CREATION 
>   src/ioslaves/file/kauth/helper.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129983/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> warning dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/03/09/d42570e8-aedf-4c02-801e-362a68755c2c__polkit_integration.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

Commit notifications

2017-03-13 Thread Kåre Särs 
Hi,

I want to do some changes to what git commit notifications I get and I 
have searched the KDE web-pages to find the information on how to do 
it, but no luck :(

Almost all places I have searched mention commitfilter.kde.org, but that 
server has been shut down some time go already.

What is the new place for this?

Regards,
  Kåre

D5032: drop examples dir

2017-03-13 Thread Harald Sitter 
sitter added a comment.


  Not interesting enough to me. If someone finds it interesting, sure.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D5032

To: sitter, broulik
Cc: ltoscano, #frameworks

D5032: drop examples dir

2017-03-13 Thread Luigi Toscano 
ltoscano added a comment.


  Couldn't it go to kdeexamples if interesting enough (or at least its 
frameworks branch, if any?)

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D5032

To: sitter, broulik
Cc: ltoscano, #frameworks

D5032: drop examples dir

2017-03-13 Thread Harald Sitter 
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  - it does not build on its own (doesn't find_package anything)
  - it is not wired into the overall build (so you can't build it as part of 
that either)
  - it does not get installed (making it nigh impossible to find for 3rd party 
devs)
  - 2/2 kde devs did not even know this example exists
  - it contains a Messages.sh which is run and extracts and even gets 
translations (! what waste !)
  
  to fix all of the above drop the entire directory. if someone wants to
  bring it back, the above issue list should be dealt with. in particular
  the Messages.sh problem (conceivably the extract line could be commented
  out with a todo note that it needs enabling for i18n).

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5032

AFFECTED FILES
  examples/runner/CMakeLists.txt
  examples/runner/Messages.sh
  examples/runner/homefilesrunner.cpp
  examples/runner/homefilesrunner.h
  examples/runner/plasma-runner-example-homefiles.desktop

To: sitter, broulik
Cc: #frameworks

Re: Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux, gcc - Build # 444 - Failure!

2017-03-13 Thread Ben Cooksley 
On Mon, Mar 13, 2017 at 3:29 AM, David Faure  wrote:
> On dimanche 12 mars 2017 11:45:40 CET no-re...@kde.org wrote:
>> GENERAL INFO
>>
>> BUILD FAILURE
>> Build URL:
>> https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,c
>> ompiler=gcc/444/ Project: PLATFORM=Linux,compiler=gcc
>
> Yet another rsync failure error.
>
> The kf5 CI is very green otherwise, but these false positives unfortunately
> create noise on the list which teaches people to ignore the CI mails :(
>
> I wonder if lock files would help...

A replacement approach, which dispenses with RSync in favour of
checksums, tarballs of binaries, and atomic file replacement is at
https://cgit.kde.org/scratch/bcooksley/ci-tooling.git/

I haven't had time to finish some of the Jenkins side of things though
so it can't be deployed yet i'm afraid. The scripts themselves have
been tested and do work though :)

Sorry for the delay in getting this fixed - it is very much on my
radar, other stuff just keeps pushing it back unfortunately.

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>

Cheers,
Ben

Re: We need to enable auto close in github pull requests

2017-03-13 Thread Harald Sitter 
http://nopullrequests.com/

On Mon, Mar 13, 2017 at 12:31 AM, Albert Astals Cid  wrote:
> Looking at https://github.com/pulls?q=is%3Apr+org%3Akde+is%3Aopen makes me
> very sad seeing how there's people that want to contribute but will never get
> an answer.
>
> Even if you click to those 109 closed you can see how there are some that are
> from people that clearly got fed up from waiting.
>
> Please people that administer the github account (¿Riddell?) make that happen
>
> Cheers,
>   Albert

Re: We need to enable auto close in github pull requests

2017-03-13 Thread Ralf Habacker 
Am 13.03.2017 um 00:31 schrieb Albert Astals Cid:
> Looking at https://github.com/pulls?q=is%3Apr+org%3Akde+is%3Aopen makes me  
> very sad seeing how there's people that want to contribute but will never get 
> an answer.
>
> Even if you click to those 109 closed you can see how there are some that are 
> from people that clearly got fed up from waiting.
>
> Please people that administer the github account (¿Riddell?) make that happen 
It may be unrelated but; At least for the github KDE/umbrello repo there
is the following message displayed:  Only those with write access to
this repository can merge pull requests.
Looking at the related pull requests for umbrello they looks reasonable.
Who is able to merge them ?

Ralf

D5001: Add support for killing a KAuth::ExecuteJob

2017-03-13 Thread Dan Leinir Turthra Jensen 
leinir closed this revision.
leinir added a comment.


  Closed by commit 
https://commits.kde.org/kauth/39621f485f434fb4453a1fd6af2796cde23eec53

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5001

To: leinir, #frameworks, jriddell
Cc: jriddell

D5003: Update docs to Frameworks API

2017-03-13 Thread Dan Leinir Turthra Jensen 
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  That looks about right to me! :)

REPOSITORY
  R283 KAuth

BRANCH
  docs

REVISION DETAIL
  https://phabricator.kde.org/D5003

To: jriddell, leinir
Cc: #frameworks