KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 118 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/118/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Fri, 13 Oct 2017 02:59:56 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(279/349)80%
(279/349)57%
(29947/52345)42%
(16538/39352)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8049/8399)51%
(4486/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)58%
(8186/14205)49%
(4564/9280)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3490/7603)30%
(1299/4403)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file60%
(3/5)60%
(3/5)46%
(436/939)39%
(319/809)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1770/3781)38%
(1326/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)59%
(694/1173)46%
(395/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)63%
(377/594)48%
(280/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)56%
  

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 119 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/119/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Fri, 13 Oct 2017 02:59:56 +
 Build duration:
4 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 407.38 KB...]Generating MOC source include/moc_fileundomanager_p.cppGenerating MOC source include/jobuidelegate.mocGenerating MOC source include/moc_joburlcache_p.cppGenerating MOC source include/moc_kacleditwidget.cppGenerating MOC source include/moc_kacleditwidget_p.cppGenerating MOC source include/moc_kautomount.cppGenerating MOC source include/moc_kbuildsycocaprogressdialog.cppGenerating MOC source include/moc_kdirlister.cppGenerating MOC source include/moc_kdirmodel.cppGenerating MOC source include/moc_kdynamicjobtracker_p.cppGenerating MOC source include/moc_kfile.cppGenerating MOC source include/moc_kopenwithdialog.cppGenerating MOC source include/moc_kopenwithdialog_p.cppGenerating MOC source include/koverlayiconplugin.moc/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/widgets/koverlayiconplugin.cpp:0: Note: No relevant classes found. No output generated.In file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/kauth/fdsender.cpp:24:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/kauth/../sharefd_p.h:46:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/kauth/../sharefd_p.h:46:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/kauth/../sharefd_p.h:51:18: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'char (*)[104]'::strcpy(_path, finalPath.c_str()); ^~~/usr/include/string.h:82:31: note: passing argument to parameter herechar*strcpy(char * __restrict, const char * __restrict); ^2 warnings and 1 error generated.gmake[2]: *** [src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/build.make:87: src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/fdsender.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 27%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/kio_http_cache_cleaner_autogen/mocs_compilation.cpp.o/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/kauth/filehelper.cpp:135:20: error: use of undeclared identifier 'errno'reply.setError(errno ? errno : -1);   ^/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/kauth/filehelper.cpp:135:28: error: use of undeclared identifier 'errno'reply.setError(errno ? errno : -1);   ^[ 27%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/main.cpp.o2 errors generated.gmake[2]: *** [src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/build.make:63: src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:1702: src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/all] Error 2[ 27%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/xslt_help.cpp.o[ 27%] Linking CXX executable ../../../bin/kio_http_cache_cleaner[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_autogen/mocs_compilation.cpp.o[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.o[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.o[ 29%] Built target kio_http_cache_cleaner[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.o[ 29%] Linking CXX shared module ../../../bin/kf5/kio/help.so[ 29%] Built target kio_help[ 29%] Linking CXX shared module ../../../bin/kf5/kio/ghelp.so[ 29%] Built target kio_ghelpGenerating MOC source include/moc_kpropertiesdialog.cppGenerating MOC source include/moc_kpropertiesdialog_p.cppGenerating MOC source include/krun.mocGenerating MOC source include/moc_krun.cppGenerating MOC source include/moc_krun_p.cppGenerating MOC source include/moc_kurlcombobox.cppGenerating MOC source include/kurlcompletion.mocGenerating MOC source include/moc_kurlcompletion.cppGenerating MOC source include/kurlrequester.mocGenerating MOC source include/moc_kurlrequester.cppGenerating MOC source include/moc_kurlrequesterdialog.cppGenerating MOC source include/moc_pastejob.cppGenerating MOC source include/moc_previewjob.cppGenerating MOC source EWIEGA46WW/moc_accessmanager.cppGenerating MOC source EWIEGA46WW/moc_accessmanagerreply_p.cppGenerating MOC source 

Re: Is there interest in participating in Google Code-in this year?

[Valorie Zimmerman]

We don't need one mentor though, we need up to 50, and probably 400
tasks by January. We also need admins, and tasks NOW.

Thanks for offering, and of course you are good enough! -v

On Thu, Oct 12, 2017 at 3:40 PM, Lays Rodrigues
 wrote:
> Hi Valorie,
> I feel sorry to hear that.
> I could give it a try on the mentorship. I just don't know if I'm good
> enough to fill the purpose.
> Cheers
>
> On Thu, Oct 12, 2017 at 6:15 PM, Valorie Zimmerman
>  wrote:
>>
>> Hello folks, when I've written about GCi before this, I got few to no
>> replies. My feeling is that previous enthusiastic mentors are without
>> the energy and time to participate this year.
>>
>> Org applications are open, but unless I hear a swell of enthusiasm
>> here, I'm inclined to not apply.
>>
>> Thoughts?
>>
>> Valorie, for Student Programs admin team
> --
> Lays Rodrigues

KDE CI: Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 22:46:24 +
 Build duration:
1 min 45 sec and counting

KDE CI: Frameworks threadweaver kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks threadweaver kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 22:45:01 +
 Build duration:
1 min 11 sec and counting

Re: Is there interest in participating in Google Code-in this year?

[Lays Rodrigues]

Hi Valorie,
I feel sorry to hear that.
I could give it a try on the mentorship. I just don't know if I'm good
enough to fill the purpose.
Cheers

On Thu, Oct 12, 2017 at 6:15 PM, Valorie Zimmerman <
valorie.zimmer...@gmail.com> wrote:

> Hello folks, when I've written about GCi before this, I got few to no
> replies. My feeling is that previous enthusiastic mentors are without
> the energy and time to participate this year.
>
> Org applications are open, but unless I hear a swell of enthusiasm
> here, I'm inclined to not apply.
>
> Thoughts?
>
> Valorie, for Student Programs admin team
>
> --
> http://about.me/valoriez
>



-- 

*Lays Rodrigues*
*Intern at Rede Globo*
*Software Developer at KDE*
*Information Systems student at Federal Fluminense University*
*https://lays147.github.io *
*Telegram: @lays147*
*IRC: lays147*
*Phone: +55 22 981520012*

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Störm Poorun]

spoorun added a comment.


  I support having the recently used option, perhaps by default in the 
open/save dialogue, and also as an optional panel. 
  This would be highly useful for workflow for many, including using other 
software as suggested, but also coming back to documents (in multiple 
locations) being referred to (though not necessarily saved, so not appearing in 
the 'recently saved' section.
  
  (It's unfortunate that there's not a user-friendly way of selecting 
components of the Places panel).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, 
#frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, navarromorales, firef, ngraham, andrebarros, emmanuelp

Re: Latte Dock in review phase

[Albert Astals Cid]

El dijous, 5 d’octubre de 2017, a les 0:00:01 CEST, Michail Vourlakos va 
escriure:
> Hello everyone,
> 
> we decided to make Latte an active kde project and so now it is in review
> phase. I believe the best place to be is extragear because we would like to
> keep some independence for the first year concerning releases...

Hi, what is the latte dock kde repo git url?

Cheers,
  Albert

> 
> What is Latte Dock?
> 
> Latte is a project that is trying to provide a unified solution concering
> docks and panels for the user. To achieve this it provides,
> the Latte app, a Latte qml library, a Latte containment, a Latte plasmoid,
> a Latte shell that uses plasma shell as base and 2 applets (a separator and
> a specialized spacer)
> 
> for more infos concerning the capabilities of the Latte suite you can find
> at:
> https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html
> https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-tornado-is-coming.html
> 
> the project before entering the kde infrastructure could be found at:
> https://github.com/psifidotos/Latte-Dock
> 
> in review you can find our 0.7.1 version which is our stable version and
> the plan is that after we succeed in the review phase to release a 0.7.2
> version only through kde infrastructure...
> 
> regards,
> michail

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D7446#154734, @anthonyfieroni wrote:
  
  > You can add recent documents as an action like in Kate. Places model looks 
in not correct destination.
  
  
  I'm not sure exactly what this is referring to. Can you clarify?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: anthonyfieroni, andreaska, gregormi, markg, alexeymin, #frameworks, 
broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, 
spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp

D7194: Detach before setting the d pointer

[Jasem Mutlaq]

mutlaqja added a comment.


  This change causes a bug in loading previews, at least for KStars. Bug here: 
https://bugs.kde.org/show_bug.cgi?id=385516

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7194

To: apol, leinir
Cc: mutlaqja, broulik, #frameworks

Commit Notifications

[Allen Winter]

I still get email notifications on commits to a few repos.

How do I unsubscribe from the ones I no longer care about?
How do I subscribe to new repos I'm currently interested in?

searching the wiki isn't helping.
I see mention of CommitFilter, but that's dead.
I tried watching github mirrors, but that didn't work either.

Phab maybe?
not seeing anything obvious there either.

Is there interest in participating in Google Code-in this year?

[Valorie Zimmerman]

Hello folks, when I've written about GCi before this, I got few to no
replies. My feeling is that previous enthusiastic mentors are without
the energy and time to participate this year.

Org applications are open, but unless I hear a swell of enthusiasm
here, I'm inclined to not apply.

Thoughts?

Valorie, for Student Programs admin team

-- 
http://about.me/valoriez

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 2 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/2/
 Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 20:00:42 +
 Build duration:
3 min 53 sec and counting
   CONSOLE OUTPUT
  [...truncated 49.67 KB...]  /opt/Qt/5.9.1/android_armv7/lib/cmake/Qt5/Qt5Config.cmake:25 (include)  autotests/CMakeLists.txt:6 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.-- -- The following REQUIRED packages have been found: * ECM (required version >= 5.39.0) , Extra CMake Modules. ,  * Qt5Core * Qt5Test * Qt5 (required version >= 5.7.0)-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks breeze-icons kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform AndroidQt5.9 --usingInstall /home/user/install-prefix/Scanning dependencies of target scalable_automocScanning dependencies of target dupe_automocScanning dependencies of target qrcAlias_automocScanning dependencies of target symlink_automocScanning dependencies of target breeze-icons-mkdirScanning dependencies of target newline_automoc[  4%] Automatic moc for target dupe[  8%] Automatic moc for target qrcAlias[ 12%] Automatic moc for target scalable[ 16%] Automatic moc for target symlink[ 20%] Automatic moc for target newline[ 20%] Built target breeze-icons-mkdir[ 20%] Built target qrcAlias_automocScanning dependencies of target breeze-icons-dark-mkdir[ 20%] Built target breeze-icons-dark-mkdirScanning dependencies of target qrcAlias[ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_automoc.cpp.o[ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.oGenerating newlinetest.mocGenerating scalabletest.mocGenerating symlinktest.mocGenerating dupetest.moc[ 29%] Built target newline_automoc[ 29%] Built target scalable_automoc[ 29%] Built target dupe_automoc[ 29%] Built target symlink_automocScanning dependencies of target scalableScanning dependencies of target symlinkScanning dependencies of target newlineScanning dependencies of target dupe[ 33%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 37%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_automoc.cpp.o[ 41%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[ 45%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[ 54%] Building CXX object autotests/CMakeFiles/newline.dir/newline_automoc.cpp.o[ 58%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_automoc.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_automoc.cpp.o[ 66%] Linking CXX executable bin/qrcAlias[ 66%] Built target qrcAliasScanning dependencies of target breeze-icons-rccScanning dependencies of target breeze-icons-dark-rcc[ 75%] Generating res/breeze-icons.qrc[ 75%] Generating res/breeze-icons-dark.qrc/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build/bin/qrcAlias: 1: /home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build/bin/qrcAlias: Syntax error: word unexpected (expecting ")")icons-dark/CMakeFiles/breeze-icons-dark-rcc.dir/build.make:64: recipe for target 'icons-dark/res/breeze-icons-dark.qrc' failedmake[2]: *** [icons-dark/res/breeze-icons-dark.qrc] Error 2CMakeFiles/Makefile2:645: recipe for target 'icons-dark/CMakeFiles/breeze-icons-dark-rcc.dir/all' failedmake[1]: *** [icons-dark/CMakeFiles/breeze-icons-dark-rcc.dir/all] Error 2make[1]: *** Waiting for unfinished jobs/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build/bin/qrcAlias: 1: /home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build/bin/qrcAlias: Syntax error: word unexpected (expecting ")")icons/CMakeFiles/breeze-icons-rcc.dir/build.make:64: recipe for target 'icons/res/breeze-icons.qrc' failedmake[2]: *** [icons/res/breeze-icons.qrc] Error 2CMakeFiles/Makefile2:556: recipe for target 'icons/CMakeFiles/breeze-icons-rcc.dir/all' failedmake[1]: *** [icons/CMakeFiles/breeze-icons-rcc.dir/all] Error 2[ 79%] Linking CXX executable ../bin/symlink[ 83%] Linking CXX executable ../bin/newline[ 83%] Built target symlink[ 83%] Built target newline[ 87%] Linking CXX executable ../bin/dupe[ 87%] Built target dupe[ 91%] Linking CXX executable ../bin/scalable[ 91%] Built target scalableMakefile:138: recipe for target 'all' failedmake: *** [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u 

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfileplacesview.cpp:169
> Ok i understaind the workaround, but did you know what is the value of 
> opt.index.row() ?

Humm I did not know about this opt.index property.  Did some debug here and it 
is always -1 .

Sorry but I am not sure why should I care about opt.index? Checking the "index" 
arg is not enough?

I am checking it with "indexIsSectionHeader"  which checks if we should draw 
the section header or not. (it will return "true" for index 0)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> renatoo wrote in kfileplacesview.cpp:169
> m_dragModeCount is used as workaround to draw items on floating window during 
> the drag.
> 
> When drag starts it save the number of selected items and until we draw all 
> selected items once we do not draw the section header (we do not want this to 
> appear on the dragging item), because this paint event will be used to 
> represent the floating item.
> 
> Based on: https://github.com/KDE/zanshin/commit/ce6a5120

Ok i understaind the workaround, but did you know what is the value of 
opt.index.row() ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo marked an inline comment as done.
renatoo added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfileplacesview.cpp:169
> Why you are sure that m_dragModeCount is 0 when indexIsSectionHeader? Why not 
> when index.row() == 0 we can paint section header?

m_dragModeCount is used as workaround to draw items on floating window during 
the drag.

When drag starts it save the number of selected items and until we draw all 
selected items once we do not draw the section header (we do not want this to 
appear on the dragging item), because this paint event will be used to 
represent the floating item.

Based on: https://github.com/KDE/zanshin/commit/ce6a5120

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfileplacesview.cpp:1150
> This calculation makes no sense to me. We have ((x - (y/2) * rowCount) / 
> rowCount so rowCount can be removed no?

Now i see i'm in wrong :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:169
> +// if is drawing the floating element used by drag/drop, does not 
> draw the header
> +if (m_dragModeCount == 0) {
> +drawSectionHeader(painter, opt, index);

Why you are sure that m_dragModeCount is 0 when indexIsSectionHeader? Why not 
when index.row() == 0 we can paint section header?

> kfileplacesview.cpp:1150
>  const int maxWidth = q->viewport()->width() - textWidth - 4 * margin - 1;
> -const int maxHeight = ((q->height() - (fm.height() / 2) * rowCount) / 
> rowCount) - 1;
> +int maxHeight = ((q->height() - (fm.height() / 2) * rowCount) / 
> rowCount) - 1;
> +maxHeight += sectionsCount() * fm.height();

This calculation makes no sense to me. We have ((x - (y/2) * rowCount) / 
rowCount so rowCount can be removed no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo marked 2 inline comments as done.
renatoo added inline comments.

INLINE COMMENTS

> renatoo wrote in kfileplacesview.cpp:424
> I need a way query the header size height from "pointIsHeaderArea" to know if 
> the user clicked on header or in the real item. Since I do not have access 
> from "QStyleOptionViewItem" from there, I need to store it in a var to use it 
> late if necessary.
> 
> I do not love the way that is implemented but, I can not find a better way to 
> implement that.

Ok instead of use QStyleOptionViewItem information to check the font size of 
the header. Now I use QApplication::font, this give me flexibility to check the 
header size at any part of the code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo updated this revision to Diff 20656.
renatoo added a comment.


  Use QApplication::font() to determine the section header font size

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8243?vs=20650=20656

BRANCH
  model-hide-row

REVISION DETAIL
  https://phabricator.kde.org/D8243

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfileplacesview.cpp:424
> So you mean sizeHint have a right height ? This height store looks like a 
> workaround.

I need a way query the header size height from "pointIsHeaderArea" to know if 
the user clicked on header or in the real item. Since I do not have access from 
"QStyleOptionViewItem" from there, I need to store it in a var to use it late 
if necessary.

I do not love the way that is implemented but, I can not find a better way to 
implement that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:424
> +if (m_sectionHeaderHeight == -1) {
> +m_sectionHeaderHeight = option.fontMetrics.height();
> +}

So you mean sizeHint have a right height ? This height store looks like a 
workaround.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.


  In https://phabricator.kde.org/D7446#154720, @ngraham wrote:
  
  > That said, it's not just me who wants this in Dolphin, too. There's a 
Bugzilla ticket with one dupe and 32 votes: 
https://bugs.kde.org/show_bug.cgi?id=357542
  >
  > Also, we have a semi-functional version of this already in the form of the 
Places panel's Recently Saved section. So there does seem to be some interest, 
both historical and current, in having Dolphin show recent files by default.
  
  
  Be aware that the thing you're trying to get approved here is **not** the fix 
for that bug!
  You'd have to dig in Baloo to fix that bug.
  
  You should not even be looking into the recentdocuments KIO slave as that is 
just not the part where the bug is (in this case).
  Also, the users' case is for the file open/save dialog, again not the main 
application.
  
  You yourself even said in the bug that this patch would only be a non optimal 
workaround. This is imho the most nasty thing; patches that "seem" to solve 
something but are in fact workarounds that merely hide the real problem. I 
admit, I - unknowingly - also did that in the past but was often corrected by 
someone. As you are now :)
  
  So, to make things clear.
  -1 for having this in dolphin' main window. Doesn't mean that it never gets 
in, just that i don't like it.
  +1 for having this on a contextual basis in the file/folder open/save 
dialogs, that would in fact be very beneficial! You should still look at Baloo 
for fixing it, not recentdocuments.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: andreaska, gregormi, markg, alexeymin, #frameworks, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Anthony Fieroni]

anthonyfieroni added a comment.


  You can add recent documents as an action like in Kate. Places model looks in 
not correct destination.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: anthonyfieroni, andreaska, gregormi, markg, alexeymin, #frameworks, 
broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, 
spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Nathaniel Graham]

ngraham added a comment.


  That said, it's not just me who wants this in Dolphin, too. There's a 
Bugzilla ticket with one dupe and 32 votes: 
https://bugs.kde.org/show_bug.cgi?id=357542
  
  Also, we have a semi-functional version of this already in the form of the 
Places panel's Recently Saved section. So there does seem to be some interest, 
both historical and current, in having Dolphin show recent files by default.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp
Cc: andreaska, gregormi, markg, alexeymin, #frameworks, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Nathaniel Graham]

ngraham added a comment.


  I could get behind only adding it to Open File dialogs. Let me have a think 
on that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp
Cc: andreaska, gregormi, markg, alexeymin, #frameworks, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Mark Gaiser]

markg added a comment.


  In https://phabricator.kde.org/D7446#154617, @ngraham wrote:
  
  > @markg, I strongly disagree that "recent files" are not useful in open/save 
dialogs.
  >
  > As I've mentioned before, a common use case that this enables is when you 
save an item from one program and need to open it in another without having a 
Dolphin window open that shows it. One example is attaching files to websites. 
You just go to the "Recent files" entry in the Open window and voila, your 
latest saved file is right there on the top. It's a super fast workflow.
  >
  > There is a reason why "Recent items" is a default entry in the file manager 
and open/save dialogs in macOS and GNOME. They didn't add it for no good reason.
  
  
  As you seem eager to compare against others who do have it. How about others 
who don't. That's for instance XFCE with Thunar, it doesn't have that.
  Windows 7 had is partly, called "Recent places" which only lists folders, not 
files.
  Windows 10 doesn't have it.
  macOS finder - contrary to what you keep telling here - does not show recent 
documents or folders by default.
  
  All of the above is for the main applications. I'm not entirely sure about 
the file/folder open dialogs.
  
  The only way i could find this convenient is if it were by context and the 
file open dialog boxes only. What i mean by that is when you get a file open 
dialog box and need to select a file then having the recently used files in 
there might be neat.
  But by default in dolphin' main view in the favorites section... No, that 
doesn't seem the appropriate place.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp
Cc: andreaska, gregormi, markg, alexeymin, #frameworks, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R303:b82ea5b8d7b3: Correct installation of start_kdeinit when 
DESTDIR and libcap are used together (authored by graesslin).

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8064?vs=20619=20654

REVISION DETAIL
  https://phabricator.kde.org/D8064

AFFECTED FILES
  src/start_kdeinit/CMakeLists.txt

To: awilcox, dfaure
Cc: graesslin, #frameworks

[ANNOUNCE] CMake 3.10.0-rc2 is now ready for testing

[Robert Maynard]

I am proud to announce the second CMake 3.10 release candidate.
  https://cmake.org/download/

Documentation is available at:
  https://cmake.org/cmake/help/v3.10

Release notes appear below and are also published at
  https://cmake.org/cmake/help/v3.10/release/3.10.html

Some of the more significant changes in CMake 3.10 are:

* The flang Fortran compiler is now supported, with compiler id
  "Flang".

* Support for the MSVC ARM64 architecture was added. Visual Studio
  2017 Update 4 and above offer an ARM64 toolchain.

* The "include_guard()" command was introduced to allow guarding
  CMake scripts from being included more than once. The command
  supports "DIRECTORY" and "GLOBAL" options to adjust the
  corresponding include guard scope. If no options given, include
  guard is similar to basic variable-based check.

* "FindMPI" received a major overhaul. It now features language specific
  components, better Fortran support, and support for statically linked
  MPI implementations.

* A "FindOpenACC" module was added to detect compiler support for
  OpenACC.  Currently only supports PGI, GNU and Cray compilers.

* The "FindOpenGL" module underwent numerous improvements. It has gained
  support for GLVND and EGL on Linux. It now has import targets that
  separate the OpenGL library and OpenGL contexts.

* The "GoogleTest" module gained a new command
  "gtest_discover_tests()" implementing dynamic (build-time) test
  discovery.

* When using "AUTOMOC" or "AUTOUIC", source files that are
  "GENERATED" will be processed as well. They were ignored by
  "AUTOMOC" and "AUTOUIC" in earlier releases. See policy "CMP0071".

* A "CTEST_LABELS_FOR_SUBPROJECTS" CTest module variable and CTest
  script variable were added to specify a list of labels that should
  be treated as subprojects by CDash. To use this value in both the
  CTest module and the ctest command line Dashboard Client mode (e.g.
  "ctest -S") set it in the "CTestConfig.cmake" config file.

* CPack gained a "FREEBSD" generator for FreeBSD "pkg(8)",
  configured by the "CPackFreeBSD" module.

* The CPack "DEB" generator, configured by the "CPackDeb" module,
  was enabled on Windows.  While not fully featured (due to the lack
  of external UNIX tools) this will allow building basic cross-
  platform Debian packages.

* The "cmake(1)" "-E" mode gained support for "sha1sum",
  "sha224sum", "sha256sum", "sha384sum", and "sha512sum".

* The "file(GENERATE)" command now interprets relative paths given
  to its "OUTPUT" and "INPUT" arguments with respect to the caller's
  current binary and source directories, respectively. See policy
  "CMP0070".

CMake 3.10 Release Notes


Changes made since CMake 3.9 include the following.


New Features



Platforms
-

* The flang Fortran compiler is now supported, with compiler id
  "Flang".

* A new minimal platform file for "Midipix" was added.

* Support for the MSVC ARM64 architecture was added. Visual Studio
  2017 Update 4 and above offer an ARM64 toolchain.

* Support for the IAR ARM Compiler was improved.


Generators
--

* The Makefile Generators and the "Ninja" generator learned to add
  compiler launcher tools like ccache along with the compiler for the
  "CUDA" language ("C" and "CXX" were supported previously).  See the
  "CMAKE__COMPILER_LAUNCHER" variable and
  "_COMPILER_LAUNCHER" target property for details.

* The "CodeBlocks" extra generator learned to optionally exclude
  files from outside the project root directory from the generated
  project. See the "CMAKE_CODEBLOCKS_EXCLUDE_EXTERNAL_FILES" variable.


Commands


* The "cmake_host_system_information()" command learned more keys to
  get information about the processor capabilities and the host OS
  version.

* The "configure_file()" command learned to support indented "#
  cmakedefine" and "#  cmakedefine01". Spaces and/or tabs between the
  "#" character and the "cmakedefine"/"cmakedefine01" words are now
  understood and preserved in the output.

* The "execute_process()" command gained a "RESULTS_VARIABLE" option
  to collect a list of results from all children in a pipeline of
  processes when multiple "COMMAND" arguments are given.

* The "include_guard()" command was introduced to allow guarding
  CMake scripts from being included more than once. The command
  supports "DIRECTORY" and "GLOBAL" options to adjust the
  corresponding include guard scope. If no options given, include
  guard is similar to basic variable-based check.

* The "string()" command learned a new "PREPEND" subcommand.

* The "string(TIMESTAMP)" command now supports "%A" for full weekday
  name and "%B" for full month name.


Variables
-

* A "CMAKE_DIRECTORY_LABELS" variable was added to specify labels
  for all tests in a directory.


Properties
--

* A "_CPPCHECK" target property and supporting
  "CMAKE__CPPCHECK" variable were introduced to tell the
  Makefile Generators and the "Ninja" 

D7369: Wayland foreign protocol

[Martin Flöser]

graesslin accepted this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D8264: Fix build of breeze-icons on the Android CI

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  That comment could be a bit more verbose and better placed (i.e. move it next 
to `set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF)` and make it something along 
"When cross-compiling qrcAlias would be compiled against Embedded Qt, thus 
disable ... -- TODO: should compile ..."
  
  But okay :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8264

To: apol, #frameworks, #plasma, kfunk
Cc: kfunk, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo updated this revision to Diff 20650.
renatoo marked an inline comment as done.
renatoo added a comment.


  Optimize sectionsCount to not use a QSet
  Use static_cast when possible

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8243?vs=20646=20650

BRANCH
  model-hide-row

REVISION DETAIL
  https://phabricator.kde.org/D8243

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesview.cpp:997
> +{
> +KFilePlacesViewDelegate *delegate = dynamic_cast *>(itemDelegate());
> +

If you are sure that the delegate is a KFilePlacesViewDelegate, then use 
static_cast.
If you aren't sure, then test for nullptr.

An unchecked dynamic_cast makes no sense.

> kfileplacesview.cpp:1253
> +{
> +QSet sections;
> +

Missing

  sections.reserve(q->model()->rowCount())

(well, then better put the rowCount into a local variable, anyway).

Overall, filling a set just to count occurences seems like much work for just 
one number in the end, but I don't know if there's a faster algorithm that can 
be used. Would I be correct if I said that those GroupRole values are sorted? 
Couting unique values in a list like {A, A, B, B, B, C, C} doesn't require a 
full QSet to be filled in, one can just increment the count when the current 
value differs from the previous one.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8264: Fix build of breeze-icons on the Android CI

[Aleix Pol Gonzalez]

apol updated this revision to Diff 20648.
apol added a comment.


  Address Kevin's comments

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8264?vs=20641=20648

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8264

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks, #plasma, kfunk
Cc: kfunk, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo updated this revision to Diff 20646.
renatoo added a comment.


  Fixed code style

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8243?vs=20645=20646

BRANCH
  model-hide-row

REVISION DETAIL
  https://phabricator.kde.org/D8243

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo added a comment.


  All problems fixed.

INLINE COMMENTS

> anthonyfieroni wrote in kfileplacesview.cpp:1065-1066
> So if second line is correct why not remove first one?

Sorry wrong operator it should be "+="

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Renato Oliveira Filho]

renatoo updated this revision to Diff 20645.
renatoo marked 9 inline comments as done.
renatoo added a comment.


  Fix code syntax
  Disable drag from item header
  Does not show item header on floating preview during the drag

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8243?vs=20613=20645

BRANCH
  model-hide-row

REVISION DETAIL
  https://phabricator.kde.org/D8243

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8264: Fix build of breeze-icons on the Android CI

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:23
> +if (CMAKE_CROSSCOMPILING)
> +set(GENERATE_ICONS_DEFAULT OFF)
> +else()

Better: `GENERATE_ICONS_DEFAULT` -> `BINARY_ICONS_RESOURCE_OPTION_DEFAULT` 
(consistent naming)

Also add some comment why it's disabled when cross-compiling.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8264

To: apol, #frameworks, #plasma, kfunk
Cc: kfunk, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8264: Fix build of breeze-icons on the Android CI

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  At the moment we are compiling the tool against android then trying to
  execute it, which obviously doesn't work. Building locally would require
  having native Qt available and further changes in the code.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8264

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.9 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.9/2/
 Project:
Frameworks ki18n kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 13:07:16 +
 Build duration:
1 min 38 sec and counting

D7369: Wayland foreign protocol

[Marco Martin]

mart updated this revision to Diff 20639.
mart marked 7 inline comments as done.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - more documentation

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7369?vs=20638=20639

BRANCH
  mart/xdgforeign

REVISION DETAIL
  https://phabricator.kde.org/D7369

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_foreign.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-foreign-unstable-v2.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgforeign.cpp
  src/client/xdgforeign.h
  src/client/xdgforeign_p.h
  src/client/xdgforeign_v2.cpp
  src/client/xdgforeign_v2.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgforeign_interface.cpp
  src/server/xdgforeign_interface.h
  src/server/xdgforeign_v2_interface.cpp
  src/server/xdgforeign_v2_interface_p.h
  tests/CMakeLists.txt
  tests/xdgforeigntest.cpp

To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Nathaniel Graham]

ngraham added a comment.


  @markg, I strongly disagree that "recent files" are not useful in open/save 
dialogs.
  
  As I've mentioned before, a common use case that this enables is when you 
save an item from one program and need to open it in another without having a 
Dolphin window open that shows it. One example is attaching files to websites. 
You just go to the "Recent files" entry in the Open window and voila, your 
latest saved file is right there on the top. It's a super fast workflow.
  
  There is a reason why "Recent items" is a default entry in the file manager 
and open/save dialogs in macOS and GNOME. They didn't add it for no good reason.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp
Cc: andreaska, gregormi, markg, alexeymin, #frameworks, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, spoorun, 
navarromorales, firef, andrebarros, emmanuelp

D7369: Wayland foreign protocol

[Marco Martin]

mart updated this revision to Diff 20638.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  - documentation++
  - name the methods exportTopLevel/importTopLevel

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7369?vs=20584=20638

BRANCH
  mart/xdgforeign

REVISION DETAIL
  https://phabricator.kde.org/D7369

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_foreign.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-foreign-unstable-v2.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgforeign.cpp
  src/client/xdgforeign.h
  src/client/xdgforeign_p.h
  src/client/xdgforeign_v2.cpp
  src/client/xdgforeign_v2.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgforeign_interface.cpp
  src/server/xdgforeign_interface.h
  src/server/xdgforeign_v2_interface.cpp
  src/server/xdgforeign_v2_interface_p.h
  tests/CMakeLists.txt
  tests/xdgforeigntest.cpp

To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8243: Implement support for categories on KfilesPlacesView

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:113
> +QColor baseColor(const QStyleOption ) const;
> +QColor mixedColor(const QColor& c1, const QColor& c2, int c1Percent) 
> const;
>  };

coding style const QColor , const QColor 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

KDE CI: Frameworks kconfig kf5-qt5 AndroidQt5.9 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks kconfig kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 11:52:33 +
 Build duration:
1 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 139.88 KB...][ 29%] Building CXX object autotests/CMakeFiles/kconfignokdehometest.dir/kconfignokdehometest_automoc.cpp.oScanning dependencies of target kdesktopfiletest[ 30%] Building CXX object autotests/CMakeFiles/kdesktopfiletest.dir/kdesktopfiletest.cpp.o[ 30%] Building CXX object autotests/CMakeFiles/kdesktopfiletest.dir/kdesktopfiletest_automoc.cpp.o[ 31%] Building CXX object src/kconf_update/CMakeFiles/kconf_update.dir/kconfigutils.cpp.o[ 32%] Linking CXX executable ../bin/kconfignokdehometest[ 32%] Built target kconfignokdehometest[ 32%] Building CXX object src/kconf_update/CMakeFiles/kconf_update.dir/kconf_update_automoc.cpp.o[ 32%] Building CXX object autotests/CMakeFiles/kconfigcore-fallbackconfigresourcestest.dir/kconfigcore-fallbackconfigresourcestest_automoc.cpp.o[ 32%] Building CXX object src/gui/CMakeFiles/KF5ConfigGui.dir/kconfigloader.cpp.o[ 33%] Linking CXX executable ../bin/kconfigcore-fallbackconfigresourcestest[ 33%] Built target kconfigcore-fallbackconfigresourcestest[ 34%] Building CXX object src/gui/CMakeFiles/KF5ConfigGui.dir/kconfigskeleton.cpp.o[ 34%] Building CXX object src/gui/CMakeFiles/KF5ConfigGui.dir/kstandardshortcut.cpp.o[ 35%] Building CXX object src/gui/CMakeFiles/KF5ConfigGui.dir/kwindowconfig.cpp.o[ 36%] Linking CXX executable ../../bin/kconf_update[ 36%] Built target kconf_updateScanning dependencies of target ksharedconfig_in_global_object[ 36%] Building CXX object autotests/CMakeFiles/ksharedconfig_in_global_object.dir/ksharedconfig_in_global_object.cpp.o[ 37%] Linking CXX executable ../bin/kdesktopfiletest[ 37%] Building CXX object src/gui/CMakeFiles/KF5ConfigGui.dir/ECMQmLoader-kconfig5_qt.cpp.o[ 37%] Built target kdesktopfiletest[ 37%] Building CXX object autotests/CMakeFiles/ksharedconfig_in_global_object.dir/ksharedconfig_in_global_object_automoc.cpp.oScanning dependencies of target test_kconfigutils[ 37%] Building CXX object autotests/CMakeFiles/test_kconfigutils.dir/test_kconfigutils.cpp.o[ 38%] Building CXX object autotests/CMakeFiles/test_kconfigutils.dir/__/src/kconf_update/kconfigutils.cpp.o[ 38%] Building CXX object autotests/CMakeFiles/test_kconfigutils.dir/test_kconfigutils_automoc.cpp.oScanning dependencies of target kconfigtest[ 38%] Building CXX object autotests/CMakeFiles/kconfigtest.dir/kconfigtest.cpp.o[ 38%] Building CXX object src/gui/CMakeFiles/KF5ConfigGui.dir/KF5ConfigGui_automoc.cpp.o[ 39%] Linking CXX executable ../bin/ksharedconfig_in_global_object[ 39%] Built target ksharedconfig_in_global_object[ 40%] Building CXX object autotests/CMakeFiles/kconfigtest.dir/kconfigtest_automoc.cpp.o[ 40%] Generating qrc_sharedconfigresources.cppScanning dependencies of target kconfigcore-ksharedconfigtest[ 41%] Building CXX object autotests/CMakeFiles/kconfigcore-ksharedconfigtest.dir/ksharedconfigtest.cpp.o[ 41%] Building CXX object autotests/CMakeFiles/kconfigcore-ksharedconfigtest.dir/qrc_sharedconfigresources.cpp.o[ 42%] Building CXX object autotests/CMakeFiles/kconfigcore-ksharedconfigtest.dir/kconfigcore-ksharedconfigtest_automoc.cpp.o[ 42%] Linking CXX executable ../bin/test_kconfigutils[ 42%] Built target test_kconfigutilsScanning dependencies of target test_kconf_update[ 43%] Building CXX object autotests/CMakeFiles/test_kconf_update.dir/test_kconf_update.cpp.o[ 43%] Building CXX object autotests/CMakeFiles/test_kconf_update.dir/test_kconf_update_automoc.cpp.o[ 44%] Linking CXX shared library ../../bin/libKF5ConfigGui.so[ 44%] Built target KF5ConfigGuiScanning dependencies of target kconfigloadertest[ 44%] Building CXX object autotests/CMakeFiles/kconfigloadertest.dir/kconfigloadertest.cpp.oScanning dependencies of target kstandardshortcuttest[ 45%] Building CXX object autotests/CMakeFiles/kstandardshortcuttest.dir/kstandardshortcuttest.cpp.o/home/user/workspace/Frameworks kconfig kf5-qt5 AndroidQt5.9/autotests/kconfigtest.cpp: In member function 'void KConfigTest::testChangeGroup()':/home/user/workspace/Frameworks kconfig kf5-qt5 AndroidQt5.9/autotests/kconfigtest.cpp:729:34: warning: 'void KConfigGroup::changeGroup(const char*)' is deprecated (declared at /home/user/workspace/Frameworks kconfig kf5-qt5 AndroidQt5.9/src/core/kconfiggroup.h:160) [-Wdeprecated-declarations] newGroup.changeGroup("FooBar"); // deprecated!  ^/home/user/workspace/Frameworks kconfig kf5-qt5 AndroidQt5.9/autotests/kconfigtest.cpp:745:35: warning: 'void KConfigGroup::changeGroup(const char*)' is deprecated (declared at /home/user/workspace/Frameworks kconfig kf5-qt5 AndroidQt5.9/src/core/kconfiggroup.h:160) [-Wdeprecated-declarations] newGroup2.changeGroup("FooBar"); // deprecated!   ^[ 

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.9 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks ki18n kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 11:49:14 +
 Build duration:
3 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 41.29 KB...]-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Failed-- Could not set up the appstream test. appstreamcli is missing.-- Looking for dngettext-- Looking for dngettext - not found-- libintl is a separate library.-- Could NOT find LibIntl (missing:  LibIntl_INCLUDE_DIRS LibIntl_LIBRARIES) -- Found Gettext: /usr/bin/msgmerge (found version "0.19.7") -- Found PythonInterp: /usr/bin/python3.5 (found version "3.5.2") -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- At least one python version must be available to use PythonModuleGeneration.CMake Warning (dev) at /opt/Qt/5.9.1/android_armv7/lib/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set):  Policy CMP0053 is not set: Simplify variable reference and escape sequence  evaluation.  Run "cmake --help-policy CMP0053" for policy details.  Use the  cmake_policy command to set the policy and suppress this warning.  For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake'  the old evaluation rules produce:'/opt/Qt/5.9.1/android_armv7/lib/cmake/Qt5/Qt5Config.cmake'  but the new evaluation rules produce:'/opt/Qt/5.9.1/android_armv7/lib/cmake/Qt5@module@/Qt5@module@Config.cmake'  Using the old result for compatibility since the policy is not set.Call Stack (most recent call first):  /opt/Qt/5.9.1/android_armv7/lib/cmake/Qt5/Qt5Config.cmake:25 (include)  autotests/CMakeLists.txt:5 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.-- -- The following REQUIRED packages have been found: * ECM (required version >= 5.39.0) , Extra CMake Modules. ,  * Qt5Script (required version >= 5.7.0) * Qt5Core * Gettext * PythonInterp * Qt5Test * Qt5Network (required version >= 5.9.1) * Qt5Qml * Qt5Concurrent * Qt5 (required version >= 5.7.0)-- The following features have been disabled: * QCH , API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * PythonModuleGeneration-- The following REQUIRED packages have not been found: * LibIntl ,Needed for building KI18n unless glibc is the system libc implementationCMake Error at /usr/share/cmake-3.5/Modules/FeatureSummary.cmake:556 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:106 (feature_summary)CMake Error: The following variables are used in this project, but they are set to NOTFOUND.Please set them or make sure they are set and tested correctly in the CMake files:/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.9/autotests/LibIntl_INCLUDE_DIRS   used as include directory in directory /home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.9/autotests/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.9/src/LibIntl_INCLUDE_DIRS   used as include directory in directory /home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.9/srcLibIntl_LIBRARIESlinked by target "KF5I18n" in directory /home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.9/srclinked by target "ki18n-klocalizedstringtest" in directory /home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.9/autotests-- Configuring incomplete, errors occurred!See also "/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.9/build/CMakeFiles/CMakeOutput.log".See also "/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.9/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks ki18n kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production/usr/lib/python3/dist-packages/Crypto/Cipher/blockalgo.py:141: FutureWarning: CTR mode needs counter parameter, not IV  self._cipher = factory.new(key, *args, **kwargs)[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks kguiaddons kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kguiaddons%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks kguiaddons kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 11:48:54 +
 Build duration:
49 sec and counting

KDE CI: Frameworks karchive kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks karchive kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 11:48:29 +
 Build duration:
49 sec and counting

KDE CI: Frameworks kcodecs kf5-qt5 AndroidQt5.9 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks kcodecs kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 11:48:49 +
 Build duration:
37 sec and counting
   CONSOLE OUTPUT
  [...truncated 14.41 KB...] > git config core.sparsecheckout # timeout=10 > git checkout -f b35f59a7b8ab61ed8e98d2ec4df95b53919a2df4Commit message: "Use the Android.cmake part of the SDK"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks kcodecs kf5-qt5 AndroidQt5.9/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 53fd261935cb4b9c761226c2c269ebe406a298f1 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 53fd261935cb4b9c761226c2c269ebe406a298f1Commit message: "Create new repositories for Plasma Redshift Control and Active Window Control Ref T6915"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks kcodecs kf5-qt5 AndroidQt5.9/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision a693b69c3823088b27120dd3815f90ab5bead666 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f a693b69c3823088b27120dd3815f90ab5bead666Commit message: "Add missing deps for qqc2-desktop-style"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks kcodecs kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kcodecs --branchGroup kf5-qt5 --environment production --platform AndroidQt5.9 --installTo /home/user/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks kcodecs kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project kcodecs --branchGroup kf5-qt5 --platform AndroidQt5.9 --installTo /home/user/install-prefix/cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix/;/opt/Qt/5.9.1/android_armv7"  "/home/user/workspace/Frameworks kcodecs kf5-qt5 AndroidQt5.9"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler 

KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/29/
 Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
 Date of build:
Thu, 12 Oct 2017 10:37:04 +
 Build duration:
1 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(23/24)96%
(23/24)73%
(1540/2106)51%
(1046/2044)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(10/10)100%
(10/10)100%
(500/502)52%
(277/532)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)73%
(536/737)62%
(520/834)src.kpackage.private100%
(6/6)100%
(6/6)79%
(289/366)53%
(110/208)src.kpackagetool100%
(3/3)100%
(3/3)42%
(201/483)29%
(132/458)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/35/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
 Date of build:
Thu, 12 Oct 2017 10:37:04 +
 Build duration:
1 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 10:24:00 +
 Build duration:
4 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 50.23 KB...]  /opt/Qt/5.9.1/android_armv7/lib/cmake/Qt5/Qt5Config.cmake:25 (include)  autotests/CMakeLists.txt:6 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.-- -- The following REQUIRED packages have been found: * ECM (required version >= 5.39.0) , Extra CMake Modules. ,  * Qt5Core * Qt5Test * Qt5 (required version >= 5.7.0)-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks breeze-icons kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform AndroidQt5.9 --usingInstall /home/user/install-prefix/Scanning dependencies of target breeze-icons-mkdirScanning dependencies of target scalable_automocScanning dependencies of target qrcAlias_automocScanning dependencies of target dupe_automocScanning dependencies of target symlink_automoc[  0%] Built target breeze-icons-mkdirScanning dependencies of target newline_automocScanning dependencies of target breeze-icons-dark-mkdir[  4%] Automatic moc for target qrcAlias[  8%] Automatic moc for target newline[ 12%] Automatic moc for target scalable[ 20%] Automatic moc for target symlink[ 20%] Automatic moc for target dupe[ 20%] Built target qrcAlias_automoc[ 20%] Built target breeze-icons-dark-mkdirScanning dependencies of target qrcAlias[ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_automoc.cpp.oGenerating newlinetest.mocGenerating scalabletest.mocGenerating dupetest.mocGenerating symlinktest.moc[ 29%] Built target newline_automoc[ 29%] Built target dupe_automoc[ 29%] Built target scalable_automoc[ 29%] Built target symlink_automocScanning dependencies of target scalableScanning dependencies of target newlineScanning dependencies of target dupeScanning dependencies of target symlink[ 33%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_automoc.cpp.o[ 37%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 41%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[ 45%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[ 54%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_automoc.cpp.o[ 58%] Building CXX object autotests/CMakeFiles/newline.dir/newline_automoc.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_automoc.cpp.o[ 66%] Linking CXX executable bin/qrcAlias[ 66%] Built target qrcAliasScanning dependencies of target breeze-icons-dark-rccScanning dependencies of target breeze-icons-rcc[ 70%] Generating res/breeze-icons-dark.qrc[ 75%] Generating res/breeze-icons.qrc[ 79%] Linking CXX executable ../bin/symlink[ 83%] Linking CXX executable ../bin/newline[ 87%] Linking CXX executable ../bin/dupe[ 87%] Built target symlink[ 87%] Built target newline[ 87%] Built target dupe/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build/bin/qrcAlias: 1: /home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build/bin/qrcAlias: Syntax error: word unexpected (expecting ")")/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build/bin/qrcAlias: 1: /home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9/build/bin/qrcAlias: Syntax error: word unexpected (expecting ")")icons/CMakeFiles/breeze-icons-rcc.dir/build.make:64: recipe for target 'icons/res/breeze-icons.qrc' failedmake[2]: *** [icons/res/breeze-icons.qrc] Error 2icons-dark/CMakeFiles/breeze-icons-dark-rcc.dir/build.make:64: recipe for target 'icons-dark/res/breeze-icons-dark.qrc' failedmake[2]: *** [icons-dark/res/breeze-icons-dark.qrc] Error 2CMakeFiles/Makefile2:556: recipe for target 'icons/CMakeFiles/breeze-icons-rcc.dir/all' failedmake[1]: *** [icons/CMakeFiles/breeze-icons-rcc.dir/all] Error 2make[1]: *** Waiting for unfinished jobsCMakeFiles/Makefile2:645: recipe for target 'icons-dark/CMakeFiles/breeze-icons-dark-rcc.dir/all' failedmake[1]: *** [icons-dark/CMakeFiles/breeze-icons-dark-rcc.dir/all] Error 2[ 91%] Linking CXX executable ../bin/scalable[ 91%] Built target scalableMakefile:138: recipe for target 'all' failedmake: *** [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u 

KDE CI: Frameworks attica kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks attica kf5-qt5 AndroidQt5.9
 Date of build:
Thu, 12 Oct 2017 10:23:55 +
 Build duration:
1 min 12 sec and counting

D7520: Fix icon of KStandardAction::MoveToTrash

[Andreas Kainz]

andreaska added a comment.


  +1

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D7520

To: elvisangelaccio, #frameworks
Cc: andreaska, broulik

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 83 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/83/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Thu, 12 Oct 2017 09:33:00 +
 Build duration:
2 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 118 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/118/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Thu, 12 Oct 2017 09:33:00 +
 Build duration:
1 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 124 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/124/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Thu, 12 Oct 2017 09:33:00 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)67%
(6/9)67%
(6/9)64%
(409/640)43%
(169/393)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc80%
(4/5)80%
(4/5)54%
(173/320)34%
(90/263)src.libkirigami50%
(2/4)50%
(2/4)74%
(236/320)61%
(79/130)

D7520: Fix icon of KStandardAction::MoveToTrash

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 20631.
elvisangelaccio added a comment.


  - Switched from `user-trash` to `trash-empty` (discussed with @andreaska in 
person).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7520?vs=18688=20631

BRANCH
  user-trash

REVISION DETAIL
  https://phabricator.kde.org/D7520

AFFECTED FILES
  src/kstandardaction_p.h

To: elvisangelaccio, #frameworks
Cc: andreaska, broulik

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Andreas Kainz]

andreaska added a comment.


  works for the VDG really good job. well done. I like it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp
Cc: andreaska, gregormi, markg, alexeymin, #frameworks, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, spoorun, 
navarromorales, firef, andrebarros, emmanuelp

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 123 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/123/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Thu, 12 Oct 2017 09:04:55 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 117 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/117/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Thu, 12 Oct 2017 09:04:55 +
 Build duration:
1 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D8243: Implement support for categories on KfilesPlacesView

[Kevin Ottens]

ervin added a comment.


  One more thing, the way the sections are currently done, if I drag the first 
item of a section the visual feedback I get also includes the section itself 
giving the feeling that the section itself is being moved. Also I can drag from 
the section title itself which is a problem too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Note that the summary part of the commit is now wrong (it still refers to 
KCategorizedView).
  
  Also, KFilePlacesModelTest needs to be adjusted to take into account the new 
behavior.

INLINE COMMENTS

> kfileplacesitem.cpp:179
> +
> +if (protocol == QLatin1String("bluetooth") || protocol == 
> QLatin1String("obexftp") || protocol == QLatin1String("kdeconnect")) {
> +return DevicesType;

Long line, would be nice to split it.

> kfileplacesitem_p.h:106
>  QStringList m_emblems;
> +QString m_group;
>  };

Rename to m_groupName ?

> kfileplacesmodel.cpp:474
> +// return a sorted list based on groups
> +qStableSort(items.begin(), items.end(), [](KFilePlacesItem *itemA, 
> KFilePlacesItem *itemB) {
> +   return (itemA->groupType() < itemB->groupType());

Might be worth breaking the line after "items.end(),"

> kfileplacesview.cpp:62
>  public:
> -KFilePlacesViewDelegate(KFilePlacesView *parent);
> +KFilePlacesViewDelegate(int sectionRole, KFilePlacesView *parent);
>  virtual ~KFilePlacesViewDelegate();

I don't see the point of that ctor change. KFilePlacesView(Delegate) is already 
very much coupled to KFilePlacesModel anyway, so could be hardcoded to 
KFilePlacesModel::GroupRole.

> kfileplacesview.cpp:104
> +
> +int m_sectionRole;
> +

Likewise, can go away in my opinion.

> kfileplacesview.cpp:342-356
> +if (index.row() == 0) {
> +return true;
> +}
> +
> +const QAbstractItemModel *model = index.model();
> +QVariant section = index.data(m_sectionRole);
> +QModelIndex prevIndex = model->index(index.row() - 1, index.column(), 
> index.parent());

I'd consider refactoring this by splitting it in several helper functions:

- one which returns the groupName from an index (and so an empty string if the 
passed index is invalid);
- one which returns the previous visible index starting from an index (pretty 
much encapsulating the loop you got);

The whole block would then turn into something like:
const auto groupName = groupNameFromIndex(index);
const auto previousGroupName = groupNameFromIndex(previousVisibleIndex(index));
return groupName != previousGroupName;

More elegant and readable in my opinion, also make sure the whole method is at 
the same abstraction level.

> kfileplacesview.cpp:1172
> +
> +for(int i=0; i < q->model()->rowCount(); i++) {
> +if (!q->isRowHidden(i)) {

Spaces before and after =

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:104
> +
> +int m_sectionRole;
> +

const

> kfileplacesview.cpp:1065-1066
>  const int maxWidth = q->viewport()->width() - textWidth - 4 * margin - 1;
> -const int maxHeight = ((q->height() - (fm.height() / 2) * rowCount) / 
> rowCount) - 1;
> +int maxHeight = ((q->height() - (fm.height() / 2) * rowCount) / 
> rowCount) - 1;
> +maxHeight = sectionsCount() * fm.height();
>  

So if second line is correct why not remove first one?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure
Cc: anthonyfieroni, cfeck, #frameworks