KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/69/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 04:44:06 +
 Build duration:
7 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

D10141: Restore Persistence=session for the file ioslave kauth helper

[Chinmoy Ranjan Pradhan]

chinmoyr accepted this revision.
chinmoyr added a comment.
This revision is now accepted and ready to land.


  I think it is now okay to push this diff as the issues pertaining to warning 
dialogs have been fixed.  See T8075 .

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10141

To: elvisangelaccio, lbeltrame, dfaure, davidedmundson, fvogt, chinmoyr
Cc: aacid, #frameworks, michaelh, ngraham

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/13/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 04 Apr 2018 04:44:06 +
 Build duration:
7 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/52/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 04 Apr 2018 04:41:13 +
 Build duration:
9 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31787/59763)38%
(18626/48973)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8602/9158)48%
(5249/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8519/14386)51%
(4932/9731)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
 

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/52/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 04:44:06 +
 Build duration:
4 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 181 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/181/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 04:38:45 +
 Build duration:
8 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiogui-favicontestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/51/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 04 Apr 2018 04:10:40 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31734/59749)38%
(18603/48967)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests99%
(72/73)99%
(72/73)94%
(8567/9157)48%
(5237/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8500/14373)51%
(4922/9725)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7882)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
  

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 203 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/203/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 04:29:12 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31728/59762)38%
(18605/48977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8600/9158)48%
(5252/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8461/14385)50%
(4910/9727)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
   

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 180 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/180/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 04:09:40 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kinit kf5-qt5 SUSEQt5.9 - Build # 9 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20SUSEQt5.9/9/
 Project:
Frameworks kinit kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 04 Apr 2018 04:33:21 +
 Build duration:
4 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 123.43 KB...]Scanning dependencies of target kdeinit_klauncher_autogen[  2%] Automatic MOC for target kdeinit5[  4%] Automatic MOC for target kdeinit5_shutdown[  6%] Automatic MOC for target kdeinit5_wrapper[  8%] Automatic MOC for target kwrapper5[ 10%] Automatic MOC for target kdeinit_klauncher[ 12%] Automatic MOC for target kshell5[ 12%] Built target kdeinit5_shutdown_autogen[ 12%] Built target kdeinit5_wrapper_autogenScanning dependencies of target start_kdeinit_wrapper_autogenScanning dependencies of target start_kdeinit_autogen[ 14%] Automatic MOC for target start_kdeinit_wrapper[ 17%] Automatic MOC for target start_kdeinit[ 17%] Built target kshell5_autogen[ 17%] Built target start_kdeinit_autogen[ 17%] Built target start_kdeinit_wrapper_autogen[ 17%] Built target kwrapper5_autogenScanning dependencies of target docs-kdeinit5-kdeinit5-8Scanning dependencies of target kdeinit5_shutdownScanning dependencies of target kwrapper5[ 17%] Built target kdeinit5_autogenScanning dependencies of target kdeinit5_wrapper[ 19%] Generating kdeinit5.8[ 21%] Building CXX object src/kwrapper/CMakeFiles/kwrapper5.dir/kwrapper.cpp.o[ 23%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5_wrapper.dir/__/wrapper.cpp.oScanning dependencies of target kshell5[ 25%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5_shutdown.dir/__/wrapper.cpp.o[ 27%] Building CXX object src/kshell/CMakeFiles/kshell5.dir/shell.cpp.o[ 27%] Built target kdeinit_klauncher_autogen[ 29%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5_shutdown.dir/kdeinit5_shutdown_autogen/mocs_compilation.cpp.o[ 31%] Building CXX object src/kwrapper/CMakeFiles/kwrapper5.dir/kwrapper5_autogen/mocs_compilation.cpp.o[ 34%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5_wrapper.dir/kdeinit5_wrapper_autogen/mocs_compilation.cpp.o[ 36%] Building CXX object src/kshell/CMakeFiles/kshell5.dir/kshell5_autogen/mocs_compilation.cpp.oScanning dependencies of target start_kdeinit_wrapper[ 38%] Linking CXX executable ../../bin/kdeinit5_shutdown[ 40%] Linking CXX executable ../../bin/kwrapper5[ 42%] Linking CXX executable ../../bin/kdeinit5_wrapper[ 44%] Building C object src/start_kdeinit/CMakeFiles/start_kdeinit_wrapper.dir/start_kdeinit_wrapper.c.o[ 46%] Linking CXX executable ../../bin/kshell5[ 46%] Built target kwrapper5[ 46%] Built target kdeinit5_shutdown[ 46%] Built target kdeinit5_wrapper[ 46%] Built target kshell5[ 48%] Generating kslavelauncheradaptor.cpp, kslavelauncheradaptor.h[ 51%] Building CXX object src/start_kdeinit/CMakeFiles/start_kdeinit_wrapper.dir/start_kdeinit_wrapper_autogen/mocs_compilation.cpp.oScanning dependencies of target start_kdeinit[ 53%] Generating org.kde.KLauncher.xml[ 55%] Building C object src/start_kdeinit/CMakeFiles/start_kdeinit.dir/start_kdeinit.c.o[ 57%] Building CXX object src/start_kdeinit/CMakeFiles/start_kdeinit.dir/start_kdeinit_autogen/mocs_compilation.cpp.o[ 59%] Linking CXX executable ../../bin/start_kdeinit_wrapper[ 61%] Generating kslavelauncheradaptor.moc[ 63%] Linking CXX executable ../../bin/start_kdeinit[ 63%] Built target start_kdeinit_wrapperWarn: AUTHOR sect.: no personblurb|contrib for Waldo Bastian   kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/contr  kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/perso  kdeinit5Warn: AUTHOR sect.: no personblurb|contrib for Mario Weilguni  kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/contr  kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/perso  kdeinit5Warn: AUTHOR sect.: no personblurb|contrib for Lubos Lunak kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/contr  kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/perso  kdeinit5Note: Writing kdeinit5.8[ 63%] Built target start_kdeinit[ 63%] Built target docs-kdeinit5-kdeinit5-8Scanning dependencies of target kdeinit5[ 65%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5.dir/kinit.cpp.o[ 68%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5.dir/proctitle.cpp.o[ 70%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5.dir/__/klauncher_cmds.cpp.o[ 72%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5.dir/kdeinit5_autogen/mocs_compilation.cpp.oScanning dependencies of target kdeinit_klauncher[ 74%] Building CXX object src/klauncher/CMakeFiles/kdeinit_klauncher.dir/klauncher.cpp.o[ 76%] Building CXX object src/klauncher/CMakeFiles/kdeinit_klauncher.dir/klauncher_adaptor.cpp.o[ 78%] Building CXX object src/klauncher/CMakeFiles/kdeinit_klauncher.dir/klauncher_main.cpp.o[ 80%] Building CXX object src/klauncher/CMakeFiles/kdeinit_klauncher.dir/autostart.cpp.o[ 82%] Building CXX 

KDE CI: Frameworks kinit kf5-qt5 SUSEQt5.10 - Build # 18 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20SUSEQt5.10/18/
 Project:
Frameworks kinit kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 04:33:21 +
 Build duration:
3 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 122.34 KB...]Scanning dependencies of target kdeinit_klauncher_autogenScanning dependencies of target kshell5_autogen[  2%] Automatic MOC for target kdeinit5_shutdown[  4%] Automatic MOC for target kdeinit5_wrapper[  6%] Automatic MOC for target kshell5[  8%] Automatic MOC for target kdeinit5[ 10%] Automatic MOC for target kwrapper5[ 12%] Automatic MOC for target kdeinit_klauncher[ 12%] Built target kdeinit5_wrapper_autogen[ 12%] Built target kdeinit5_shutdown_autogen[ 12%] Built target kshell5_autogen[ 12%] Built target kdeinit5_autogen[ 12%] Built target kwrapper5_autogenScanning dependencies of target start_kdeinit_autogenScanning dependencies of target start_kdeinit_wrapper_autogenScanning dependencies of target docs-kdeinit5-kdeinit5-8[ 14%] Automatic MOC for target start_kdeinit[ 17%] Automatic MOC for target start_kdeinit_wrapper[ 19%] Generating kdeinit5.8[ 19%] Built target start_kdeinit_wrapper_autogen[ 19%] Built target start_kdeinit_autogenScanning dependencies of target kdeinit5_shutdownScanning dependencies of target kwrapper5Scanning dependencies of target kdeinit5_wrapper[ 21%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5_wrapper.dir/__/wrapper.cpp.o[ 23%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5_shutdown.dir/__/wrapper.cpp.o[ 25%] Building CXX object src/kwrapper/CMakeFiles/kwrapper5.dir/kwrapper.cpp.oScanning dependencies of target kdeinit5[ 27%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5.dir/kinit.cpp.o[ 27%] Built target kdeinit_klauncher_autogen[ 29%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5.dir/proctitle.cpp.oScanning dependencies of target kshell5[ 31%] Building CXX object src/kshell/CMakeFiles/kshell5.dir/shell.cpp.oWarn: AUTHOR sect.: no personblurb|contrib for Waldo Bastian   kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/contr  kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/perso  kdeinit5Warn: AUTHOR sect.: no personblurb|contrib for Mario Weilguni  kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/contr  kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/perso  kdeinit5Warn: AUTHOR sect.: no personblurb|contrib for Lubos Lunak kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/contr  kdeinit5Note: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/perso  kdeinit5Note: Writing kdeinit5.8[ 31%] Built target docs-kdeinit5-kdeinit5-8[ 34%] Building CXX object src/kshell/CMakeFiles/kshell5.dir/kshell5_autogen/mocs_compilation.cpp.o[ 36%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5_shutdown.dir/kdeinit5_shutdown_autogen/mocs_compilation.cpp.oScanning dependencies of target start_kdeinit_wrapper[ 38%] Building C object src/start_kdeinit/CMakeFiles/start_kdeinit_wrapper.dir/start_kdeinit_wrapper.c.o[ 40%] Building CXX object src/start_kdeinit/CMakeFiles/start_kdeinit_wrapper.dir/start_kdeinit_wrapper_autogen/mocs_compilation.cpp.o[ 42%] Linking CXX executable ../../bin/kdeinit5_shutdown[ 44%] Linking CXX executable ../../bin/start_kdeinit_wrapper[ 46%] Linking CXX executable ../../bin/kshell5[ 48%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5_wrapper.dir/kdeinit5_wrapper_autogen/mocs_compilation.cpp.o[ 51%] Building CXX object src/kwrapper/CMakeFiles/kwrapper5.dir/kwrapper5_autogen/mocs_compilation.cpp.o[ 53%] Linking CXX executable ../../bin/kdeinit5_wrapper[ 53%] Built target start_kdeinit_wrapper[ 55%] Linking CXX executable ../../bin/kwrapper5Scanning dependencies of target start_kdeinit[ 57%] Building C object src/start_kdeinit/CMakeFiles/start_kdeinit.dir/start_kdeinit.c.o[ 57%] Built target kdeinit5_shutdown[ 57%] Built target kshell5[ 59%] Generating kslavelauncheradaptor.cpp, kslavelauncheradaptor.h[ 61%] Building CXX object src/start_kdeinit/CMakeFiles/start_kdeinit.dir/start_kdeinit_autogen/mocs_compilation.cpp.o[ 61%] Built target kdeinit5_wrapper[ 63%] Generating org.kde.KLauncher.xml[ 65%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5.dir/__/klauncher_cmds.cpp.o[ 68%] Linking CXX executable ../../bin/start_kdeinit[ 68%] Built target kwrapper5[ 70%] Building CXX object src/kdeinit/CMakeFiles/kdeinit5.dir/kdeinit5_autogen/mocs_compilation.cpp.o[ 72%] Generating kslavelauncheradaptor.moc[ 72%] Built target start_kdeinitScanning dependencies of target kdeinit_klauncher[ 74%] Building CXX object src/klauncher/CMakeFiles/kdeinit_klauncher.dir/klauncher.cpp.o[ 76%] Building CXX object src/klauncher/CMakeFiles/kdeinit_klauncher.dir/klauncher_main.cpp.o[ 78%] Building CXX object src/klauncher/CMakeFiles/kdeinit_klauncher.dir/autostart.cpp.o[ 80%] Building CXX object 

D10824: Delete IdleSlave having temporary authorization

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R303:bbf120b78773: Delete IdleSlave having temporary 
authorization (authored by chinmoyr).

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10824?vs=28536=31255

REVISION DETAIL
  https://phabricator.kde.org/D10824

AFFECTED FILES
  src/klauncher/klauncher.cpp

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 202 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/202/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 04:11:33 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31716/59739)38%
(18597/48967)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8602/9158)48%
(5248/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8452/14362)50%
(4904/9717)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
   

D11888: Handle adjacent special characters correctly

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in advancedqueryparser.cpp:69
> 1. I misunderstood your description as ':=' should become '='.
> 
> > The lexer should not handle ">" and ">=" differently, both are (valid) 
> > tokens, and should be returned as such.
> 
> That is what I meant. I was confused by `parse()` lexing again when 
> encountering a '>'.
> 
> > Adding e.g. ">=" to the switch statement is not possible, as it works on 
> > QChar's.
> 
> I don't understand. token is QString. Why not instead of `switch 
> (token.at(0).toLatin1())`
> 
>   switch (token) {
>   case '>'`: comparator = Term::Greater; break;
>   case '>='`: comparator = Term::GreaterEqual; break;
> 
> What am I missing?

> I don't understand. token is QString. Why not instead of switch 
> (token.at(0).toLatin1())
> 
>   switch (token) {
>   case '>'`: comparator = Term::Greater; break;
>   case '>='`: comparator = Term::GreaterEqual; break;
> 
> 
> What am I missing?

You can only `switch` on integral statements (ints, chars, ...). With C++11, 
you can do some `constexpr` hacks, but your code won't work as is.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11888

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D10822: Store temporary authorization status in IdleSlave

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d38b373c8b76: Store temporary authorization status in 
IdleSlave (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10822?vs=28581=31254

REVISION DETAIL
  https://phabricator.kde.org/D10822

AFFECTED FILES
  src/core/idleslave.cpp
  src/core/idleslave.h

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10820: Send slave's polkit authorization status to the host

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ea4329c36830: Send slaves polkit authorization 
status to the host (authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10820?vs=30333=31252#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10820?vs=30333=31252

REVISION DETAIL
  https://phabricator.kde.org/D10820

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/slavebase.cpp

To: chinmoyr, dfaure
Cc: anthonyfieroni, #frameworks, michaelh, ngraham

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

[Chinmoy Ranjan Pradhan]

chinmoyr abandoned this revision.
chinmoyr added a comment.


  Not required right now

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10641

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 201 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/201/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 03:59:22 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31691/59740)38%
(18567/48967)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8575/9158)48%
(5234/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8459/14363)50%
(4906/9717)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7882)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
   

D10636: Add support for revoking temporary authorization in KAuth

[Chinmoy Ranjan Pradhan]

chinmoyr abandoned this revision.
chinmoyr added a comment.


  Not required right now

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10636

To: chinmoyr, #frameworks
Cc: fvogt, dfaure, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/50/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 04 Apr 2018 03:46:05 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31787/59744)38%
(18622/48965)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8602/9158)48%
(5252/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8523/14366)51%
(4936/9723)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7883)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
  

D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend

[Chinmoy Ranjan Pradhan]

chinmoyr abandoned this revision.
chinmoyr added a comment.


  Not required right now or in near future.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10638

To: chinmoyr, #frameworks
Cc: michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 179 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/179/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 03:46:05 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 200 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/200/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 03:46:05 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31728/59742)38%
(18600/48969)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8600/9158)48%
(5248/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8461/14365)51%
(4909/9719)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
   

D11010: Add MSG_SLAVE_STATUS_V2 to slave interface

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:004cb9da1913: Add MSG_SLAVE_STATUS_V2 to slave interface 
(authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11010?vs=28540=31251

REVISION DETAIL
  https://phabricator.kde.org/D11010

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ec4df175be47: Store PolicyKit action which the slave is 
authorized to perform (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10818?vs=31249=31250

REVISION DETAIL
  https://phabricator.kde.org/D10818

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 31249.
chinmoyr added a comment.


  Rearranged member vars

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10818?vs=31227=31249

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10818

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/118/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 03:20:29 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3522/13479)18%
(1954/10637)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)51%
(585/1140)27%
(406/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3500)28%
(825/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(541/2013)17%
(298/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/93/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 03:20:29 +
 Build duration:
8 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11891: Fix crashes in NotifyByAudio when closing applications

[René J . V . Bertin]

rjvbb added a comment.


  This is about better and more concise English. The queued connection is the 
indirect explanation why the patch is necessary, and thus comes after the 
direct explanation (the fact that there may be pending signals). Think of it as 
a courtesy to people who want to get to the point first and maybe deal with the 
finer detail later.
  
  The problem with this whole comment is that it's long and not very easy to 
follow for devs who are not (very) familiar with the code already (and those 
who are might not need all the detail). Rereading it with after-bedtime eyes I 
think you should probably just leave only the 1st sentence. The explanation why 
you can end up "here" after close was called could be put in the commit 
message, or as a "warning" above the connect() call that creates the connection.
  
  Come to think of it, your patch could take the form below because there is 
already a check of `notification`:
  
if (Q_UNLIKELY(!notification)) {
return;
} else if ((notification->flags() & KNotification::LoopSound)) {
m->play();
return;
}
  
  Maybe merge your comment with the one about "if the sound is short enough" 
because I from what I understand that describes more or less the same situation.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: cfeck, rjvbb, mpyne, michaelh, ngraham

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Christoph Roick]

croick added a comment.


  In D11236#239055 , @sitter wrote:
  
  > Maybe I am missing something here but wouldn't this allow any application 
to get ptrace access?
  >
  > e.g. if a malicious program watches /tmp/kcrash_*, then writes its own pid 
to a new socket before kcrash writes the debugger's... now the malicious 
program has ptrace access.
  
  
  That's a valid point. In the updated revision the peer PID is checked and 
must match the one of DrKonqi, before `prctl` is called.
  
  > I also think *printf isn't save to call in a signal handler. Not sure about 
atoi.
  
  `atoi` seems to be safe, `(f)printf` isn't indeed. Nevertheless it's used in 
the existing code already. Maybe that should be addressed in a different patch?
  
  Thank you for your remarks!

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks
Cc: sitter, michaelh, ngraham

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Christoph Roick]

croick updated this revision to Diff 31244.
croick added a comment.


  - check for peer PID to restrict socket connection to DrKonqi
  - add ifdefs to deactivate code for non-linuxes

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11236?vs=30980=31244

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11236

AFFECTED FILES
  src/kcrash.cpp

To: croick, #frameworks
Cc: sitter, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kiconloader.h:279
> + */
> +QPixmap loadIcon(const QString , KIconLoader::Group group, qreal 
> scale, int size = 0,
> + int state = KIconLoader::DefaultState, const 
> QStringList  = QStringList(),

loadIcon("test", mygroup, 2);

Which overload is called?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  In D6313#239212 , @cfeck wrote:
  
  > In other words, the icon theme designer can now decide if he makes HiDPI 
only bigger or more detailed by symlinking to either the less detailed or the 
more detailed svg, without duplicating the icon files?
  
  
  Exactly, that is correct. They could also make special icons if they desire, 
just like the other folders (32x32, 64x64, etc).

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11891: Fix crashes in NotifyByAudio when closing applications

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> rjvbb wrote in notifybyaudio.cpp:148-150
> Slightly better English:
> 
>   // since stopping a mediaobject means it wont't emit finished(). However,
>   // we can receive pending finished() signals that were already emitted after
>   // playback completed: phonon uses a queued connection for these signals.

I disagree it is a better explanation, i do understand my text better. the fact 
that it is a queued connection is important and needs to be at the beginning of 
the explanation and not at the end.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: cfeck, rjvbb, mpyne, michaelh, ngraham

D11891: Fix crashes in NotifyByAudio when closing applications

[Albert Astals Cid]

aacid added a comment.


  In D11891#238999 , @rjvbb wrote:
  
  > So the difference here is that `finishNotification` isn't called if 
`notification == nullptr`, with the crucial difference probably being the fact 
that `m` isn't added multiple times to the list of reusable items?
  
  
  Yes, that's the commit log says
  
  > Why isn't that logic part of `finishNotification()`? IOW, is there a valid 
reason for finishNotification to be called with a NULL `notification` argument 
but `m` that hasn't yet been moved from m_notifications to m_reusablePhotons?
  
  no, that should never happen.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: cfeck, rjvbb, mpyne, michaelh, ngraham

D11685: Implement single click on line number to select line of text

[Milian Wolff]

mwolff added a comment.


  the "also" in your commit message: can you split this commit into two parts, 
or is the feature addition also fixing the bug? Put differently: Could you 
first fix the bug, then add the feature, in separate commits?

INLINE COMMENTS

> kateviewhelpers.cpp:2018
>  m_lastClickedLine = t.line();
> -if (positionToArea(e->pos()) != IconBorder && 
> positionToArea(e->pos()) != AnnotationBorder) {
> +auto area = positionToArea(e->pos());
> +if (area != IconBorder && area != AnnotationBorder) {

const

> kateviewhelpers.cpp:2019
> +auto area = positionToArea(e->pos());
> +if (area != IconBorder && area != AnnotationBorder) {
> +auto pos = QPoint(0, e->y());

can you comment this code, why exclude these areas?

> kateviewhelpers.cpp:2183
>  const KateTextLayout  = m_viewInternal->yToKateTextLayout(e->y());
> +auto area = positionToArea(e->pos());
>  if (t.isValid()) {

const

> kateviewinternal.cpp:2787
> +placeCursor(pos);
> +m_possibleTripleClick = true;
> +}

dito comment, what has triple click to do with *begin* of select line? Is this 
b/c an actual triple click would select the line?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: mwolff, richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars, dhaumann

D11811: avoid Asan runtime error: shift exponent -1 is negative

[Milian Wolff]

mwolff added a comment.


  maybe instead make it explicit what the old code did instead? i.e. check what 
you get from GCC for "1 << -1" and then use that when i == 0

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11811

To: jtamate, #kate, #frameworks
Cc: mwolff, brauch, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D7909: Add syntax support for Crystal Programming Language

[Milian Wolff]

mwolff added subscribers: cullmann, mwolff.
mwolff accepted this revision as: mwolff.
mwolff added a comment.


  we got a test file, and it seems to work for a user of the Crystal language, 
so +1 from my side. @dhaumann, @cullmann ?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff
Cc: mwolff, cullmann, ngraham, #kate, #frameworks, faguilar, michaelh, 
genethomas, kevinapavew, demsking, vkrause, sars, dhaumann

D11822: Make the word/char count a global preference

[Milian Wolff]

mwolff added subscribers: cullmann, dhaumann, mwolff.
mwolff accepted this revision as: mwolff.
mwolff added a comment.
This revision is now accepted and ready to land.


  I'm not using that feature, but code-wise this lgtm - but please wait for 
@dhaumann or @cullmann to give their +1 too

REPOSITORY
  R39 KTextEditor

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11822

To: wsdfhjxc, #ktexteditor, #kate, mwolff
Cc: mwolff, dhaumann, cullmann, ngraham, #frameworks, michaelh, kevinapavew, 
demsking, sars

D11907: advancedqueryparsertest: Add optimization test

[Michael Heidelbach]

michaelh added a comment.


  @bruns: This is mainly to confirm I understood D11826 
 correctly. The tests pass with or without 
your patch.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add optimization test

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Baloo, bruns.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  advancedqueryparsertest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11907

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11888: Handle adjacent special characters correctly

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in advancedqueryparser.cpp:55
> Why choose a different wording here? Also, the important aspect here is the 
> "end", which commits the current token to the list.

Because of opening and closing parentheses, but you're right 'end' is the 
important aspect here.

> bruns wrote in advancedqueryparser.cpp:69
> ":=" and "==" are added as is, and the parser interprets both dependent on 
> the first character only, i.e. ":" and "=".
> The behaviour for these two combinations is unchanged with this patch.
> 
> The lexer should not handle ">" and ">=" differently, both are (valid) 
> tokens, and should be returned as such.
> 
> Adding e.g. ">=" to the switch statement is not possible, as it works on 
> QChar's.

1. I misunderstood your description as ':=' should become '='.

> The lexer should not handle ">" and ">=" differently, both are (valid) 
> tokens, and should be returned as such.

That is what I meant. I was confused by `parse()` lexing again when 
encountering a '>'.

> Adding e.g. ">=" to the switch statement is not possible, as it works on 
> QChar's.

I don't understand. token is QString. Why not instead of `switch 
(token.at(0).toLatin1())`

  switch (token) {
  case '>'`: comparator = Term::Greater; break;
  case '>='`: comparator = Term::GreaterEqual; break;

What am I missing?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11888

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> slavebase.cpp:129
>  int m_privilegeOperationStatus;
> +QSet m_tempAuths;
>  

@dfaure  where should I place this variable? Just before "m_confirmationAsked"?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

[Christoph Feck]

cfeck added a comment.


  In other words, the icon theme designer can now decide if he makes HiDPI only 
bigger or more detailed by symlinking to either the less detailed or the more 
detailed svg, without duplicating the icon files?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10437: Update file ioslave's temporary authorization list

[Chinmoy Ranjan Pradhan]

chinmoyr closed this revision.
chinmoyr added a comment.


  Merged with D10818 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh, ngraham

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 31227.
chinmoyr added a comment.


  Rebased on D10568 
  Merged D10437 

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10818?vs=28537=31227

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10818

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/49/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 03 Apr 2018 17:30:51 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31789/59741)38%
(18633/48965)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8602/9158)48%
(5248/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8520/14364)51%
(4935/9723)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7882)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
  

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 178 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/178/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 03 Apr 2018 17:26:21 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 199 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/199/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 03 Apr 2018 17:27:42 +
 Build duration:
5 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31711/59739)38%
(18592/48969)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8602/9158)48%
(5251/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8452/14362)50%
(4908/9719)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/48/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 03 Apr 2018 17:11:21 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31673/59722)38%
(18599/48958)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8610/9158)48%
(5258/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)59%
(8421/14346)50%
(4903/9716)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 198 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/198/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 03 Apr 2018 17:11:21 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(293/442)66%
(293/442)53%
(31581/59721)38%
(18550/48962)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests99%
(72/73)99%
(72/73)94%
(8575/9157)48%
(5245/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)58%
(8363/14345)50%
(4877/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
   

D10568: Handle privilege operation confirmation prompts in SlaveBase

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0e45fcffd182: Handle privilege operation confirmation 
prompts in SlaveBase (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10568?vs=31156=31225

REVISION DETAIL
  https://phabricator.kde.org/D10568

AFFECTED FILES
  src/core/slavebase.cpp

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 177 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/177/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 03 Apr 2018 17:11:21 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8b34864135f8: Remove handling of privilege operation 
confirmation prompts from KIO::Job (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10567?vs=28539=31224

REVISION DETAIL
  https://phabricator.kde.org/D10567

AFFECTED FILES
  src/core/job.cpp
  src/core/job_p.h
  src/core/simplejob.cpp
  src/core/slavebase.cpp

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, ngraham

Re: Problem in GCompris unit testing

[Johnny Jazeix]

Hi,
the exercice is a theorical one, not a practical one ("For balancebox
activity, how will you approach the unit test for this specific activity,
what would you test and how?" for those who wonder).
This issue is probably the only difficult one the student will have to
search for during gsoc so it would be better to later dig more yourself
before asking for help and more rewarding.

Johnny

2018-04-03 6:32 GMT+02:00 Himanshu Vishwakarma :

> Hi,
>
> Currently, I am working on GSoC exercise as given by the mentors. I
> facing some problem in CMAKE while compiling the qml test. My Question
> is:
>
> How to import the activity libraries in the test directory? So that it
> can use in the test.
>
> I write CMakeLists.txt file is something like this:
> https://paste.kde.org/pkhgy85pv
> when I import the files which I going to be tested in our test file,
> It gives the error in the followings lines of the imported file.
>
> import QtQuick 2.6
> import GCompris  1.0
> import Box2D 2.0 as Box2D
>
> when compile, it gives the error like this: Error:
> ~/gcompris-qt/src/activities/balancebox/balancebox.js:30,1: module
> "QtQuick" version 2.6 is not installed OR module "GCompris" is not
> installed OR module "Box2D" is not installed.
> Whereas all the files of the GCompris are importing QtQuick 2.6 &&
> GCompris 1.0 and it compiles successfully.
>
> Currently, I am using the Qt5 version 5.6.1 and the following methods
> for importing in the file like this:
> import "../../src/activities/balancebox"
> import "../../src/activities/balancebox.js" as Activity
> Correct me if I am wrong.
>
> please help me !! So that I can compile the test
> --
> Regards,
> Himanshu Vishwakarma
>

D11487: optimization of TextLineData::attribute

[Milian Wolff]

mwolff added a comment.


  Ah, I knew it :D I suspected missing compiler optimizations from the start... 
But tricky indeed for you to see!
  
  But the real question would now be: what time does it take *without* this 
patch for you? probably it won't be more than a minute anymore. Still, this 
patch is a good improvement and can/should be kept.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

To: jtamate, #frameworks, #kate, cullmann
Cc: anthonyfieroni, dhaumann, mwolff, cullmann, michaelh, kevinapavew, ngraham, 
demsking, sars

D11768: Add Desktop and Downloads to the default list of Places

[Nathaniel Graham]

ngraham set the repository for this revision to R241 KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

[Nathaniel Graham]

ngraham edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D10245: Add more default user locations to Places model/panel

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of D11768 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: zzag, alexeymin, markg, spoorun, rkflx, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

[Nathaniel Graham]

ngraham added a comment.


  Thanks David! HiDPI turns out to be complicated... ;-)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Falkon in kdereview

[David Rosca]

On Sun, Mar 25, 2018 at 11:08 PM, David Rosca  wrote:
> On Sat, Mar 24, 2018 at 7:58 PM, Dr.-Ing. Christoph Cullmann
>  wrote:
>> Hi,
>>
>> no objections from my side,
>>
>> just a note that we need to take care of the last remaining things on
>>
>> https://community.kde.org/Incubator/Projects/Falkon
>>
>> for the final incubation to be done.
>>
>> I think the mailing list/website stuff shouldn't be an issue to get done.
>
> I've requested mailing list creation, but I'm not sure about the
> website. Does it have to be a site under kde.org (subdomain)? If yes,
> then I'm afraid I have no idea how to proceed there. The other option
> is to host it on my server, as is www.qupzilla.com right now.
> For the site contents it would be enough just basic info and download
> links, I think.
>

Mailing list and websites are now up and running. Repository was also
moved to extragear.

Incubation should be completed now.

David

>>
>> The Manifest compliance is IMHO there, licensing stuff was reviewed some 
>> weeks
>> ago if I am not mistaken.
>
> Manifest compliance is done I hope. Licensing should be ok now too.
>
> David
>
>>
>> Greetings
>> Christoph
>>
>> - Am 20. Mrz 2018 um 13:40 schrieb nowrep now...@gmail.com:
>>
>>> On Wed, Feb 28, 2018 at 12:10 PM, David Rosca  wrote:
 Hi,
 I'd like to request review for Falkon.

>>>
>>> All issues that were pointed out are now fixed.
>>>
>>> It's been in kdereview for over two weeks now, so if there are no
>>> objections I will request move to extragear by the end of this week.
>>>
>>> David
>>
>> --
>> - Dr.-Ing. Christoph Cullmann -
>> AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
>> Science Park 1 Tel:   +49-681-38360-22
>> 66123 Saarbrücken  Fax:   +49-681-38360-20
>> GERMANYWWW:   http://www.AbsInt.com
>> 
>> Geschäftsführung: Dr.-Ing. Christian Ferdinand
>> Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

D11863: Add virt-manager icons

[Andreas Kainz]

andreask accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  virt-manager_icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11863

To: ndavis, #vdg, ngraham, andreaska, andreask
Cc: ngraham, andreaska, #frameworks, michaelh

D6313: Support Icon Scale from Icon naming specification 0.13

[David Edmundson]

davidedmundson added a comment.


  RE: QT_SCALE_FACTOR vs QT_SCREEN_SCALE_FACTORS
  
  See: https://paste.kde.org/p0y4ze6dg

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/117/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 03 Apr 2018 14:38:51 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13481)19%
(1978/10637)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

D11487: optimization of TextLineData::attribute

[Jaime Torres Amate]

jtamate added a comment.


  In D11487#232555 , @mwolff wrote:
  
  > WTF :D Your desktop CPU has clearly a better performance than my mobile 
CPU, no? Is AMD really so much worse here? How can that be - I don't get it :D
  >
  > Anyhow, I give up trying to understand this now - thanks a lot for your 
repeated input Jaime!
  
  
  I've found the problem for the poor performance. In .kdesrc-buildrc, I have 
also a like cxxflags # -fsanitize=address -fsanitize=signed-integer-overflow  
-fsanitize=bounds-strict -fsanitize=undefined -fsanitize-recover=address
  That line removes the -O2 from the compiler options. Added manually in the 
way of cxxflags -O2 -mtune=native # -fsanitize=address .
  I "only" get 10 seconds less, 22 seconds with the patch applied.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

To: jtamate, #frameworks, #kate, cullmann
Cc: anthonyfieroni, dhaumann, mwolff, cullmann, michaelh, kevinapavew, ngraham, 
demsking, sars

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/92/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 03 Apr 2018 14:38:51 +
 Build duration:
6 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10849: Add template for Plasma wallpaper with QML extension

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:354bd71296b5: Add template for Plasma wallpaper with QML 
extension (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10849?vs=28086=31219

REVISION DETAIL
  https://phabricator.kde.org/D10849

AFFECTED FILES
  templates/CMakeLists.txt
  templates/plasma-wallpaper-with-qml-extension/CMakeLists.txt
  templates/plasma-wallpaper-with-qml-extension/Messages.sh
  templates/plasma-wallpaper-with-qml-extension/README
  templates/plasma-wallpaper-with-qml-extension/package/contents/config/main.xml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/config.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper-with-qml-extension/package/metadata.desktop
  
templates/plasma-wallpaper-with-qml-extension/plasma-wallpaper-with-qml-extension.kdevtemplate
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/plasma-wallpaper-with-qml-extension/plugin/CMakeLists.txt
  templates/plasma-wallpaper-with-qml-extension/plugin/qmldir

To: kossebau, mart
Cc: #frameworks, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  @ngraham, in the initial description @broulik forced a @2x folder via symlink 
to test. Otherwise no change will be observed. :)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11863: Add virt-manager icons

[Nathaniel Graham]

ngraham added a comment.


  Let's cross that bridge when we come to it!  :-)

REPOSITORY
  R266 Breeze Icons

BRANCH
  virt-manager_icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11863

To: ndavis, #vdg, ngraham, andreaska
Cc: ngraham, andreaska, #frameworks, michaelh

D6313: Support Icon Scale from Icon naming specification 0.13

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  OK, +1 then! If we can safely implement this part of the spec without causing 
any unexpected visual changes, then I don't see a problem with it.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik added a comment.


  > Okay I've deployed the patch, and without applying the change specified in 
the "For testing..." sentence, I was unable to find any visual changes from the 
status quo resulting from this patch. Is that intentional?
  
  Yes, as Breeze currently does not offer any specific high dpi icons.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Nathaniel Graham]

ngraham added a comment.


  Okay I've deployed the patch, and without applying the change specified in 
the "For testing..." sentence, I was unable to find any visual changes from the 
status quo resulting from this patch. Is that intentional? For example 
`QT_SCREEN_SCALE_FACTORS=3 kate` does not show me the "After" picture when I 
open a file open dialog. Might be worth updating the Test Plan section to 
describe exactly what's necessary to test this patch.
  
  Question: what is the technical difference between `QT_SCALE_FACTOR=2` and 
`QT_SCREEN_SCALE_FACTORS=2`?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10849: Add template for Plasma wallpaper with QML extension

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addtemplatewallpaperwithqmlext

REVISION DETAIL
  https://phabricator.kde.org/D10849

To: kossebau, mart
Cc: #frameworks, michaelh, ngraham

D11452: sanitizer: Improve device listing

[Michael Heidelbach]

michaelh added a comment.


  - Ping *

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11452

To: michaelh, #baloo, #frameworks
Cc: smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11753: baloodb: Add clean command

[Michael Heidelbach]

michaelh updated this revision to Diff 31208.
michaelh added a comment.


  - Ignore symbolic links
  
  There seems to be no reliable way to map a symbolic link's target
  to a device id. Instead of removing it print a parseable message
  so users can remove it manually.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11753?vs=31033=31208

BRANCH
  sanitize-clean (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11753

AFFECTED FILES
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/documenturldb.h
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

D11902: Add highlighting for GDB command listings and gdbinit files

[Milian Wolff]

mwolff added reviewers: vkrause, dhaumann, Kate.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11902

To: mwolff, vkrause, dhaumann, #kate
Cc: #frameworks, michaelh, ngraham

D11902: Add highlighting for GDB command listings and gdbinit files

[Milian Wolff]

mwolff created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mwolff requested review of this revision.

REVISION SUMMARY
  Command listings start their non-output lines with (gdb) or >
  for multi-line commands. gdbinit files on the other hand don't
  use either, but also don't show any output.
  
  The existing GDB highlighting file is renamed to gdb-bt as it only
  highlights backtraces. It is reused by the new GDB highlighter
  to pretty-print outputs of bt-producing commands such as bt, where,
  up, down etc.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11902

AFFECTED FILES
  autotests/folding/highlight.bt.fold
  autotests/folding/highlight.gdb.fold
  autotests/folding/highlight.gdbinit.fold
  autotests/html/highlight.bt.html
  autotests/html/highlight.gdb.html
  autotests/html/highlight.gdbinit.html
  autotests/input/highlight.bt
  autotests/input/highlight.gdb
  autotests/input/highlight.gdbinit
  autotests/reference/highlight.bt.ref
  autotests/reference/highlight.gdb.ref
  autotests/reference/highlight.gdbinit.ref
  data/syntax/gdb-bt.xml
  data/syntax/gdb.xml
  data/syntax/gdbinit.xml

To: mwolff
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/51/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 03 Apr 2018 11:53:53 +
 Build duration:
5 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Harald Sitter]

sitter added a comment.


  Maybe I am missing something here but wouldn't this allow any application to 
get ptrace access?
  
  e.g. if a malicious program watches /tmp/kcrash_*, then writes its own pid to 
a new socket before kcrash writes the debugger's... now the malicious program 
has ptrace access.
  
  I also think *printf isn't save to call in a signal handler. Not sure about 
atoi.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks
Cc: sitter, michaelh, ngraham

D11838: Turn on line numbers by default

[Christoph Cullmann]

cullmann added a comment.


  I think allowing a own configuration per hosting application makes sense.
  But I would propose to do this "opt-in".
  We could add some application wide flag in the config that triggers 
"application local" storage, that is default off.
  The KTextEditor config pages could allow to change it, if e.g. Kile wants to 
have this on per default, it just needs to adjust the default by shipping a 
default kilerc.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: cullmann, aacid, acrouthamel, brauch, mludwig, kfunk, dhaumann, 
#frameworks, michaelh, kevinapavew, ngraham, demsking, sars

D11652: Don't show the background if Button.flat

[Marco Martin]

mart added a comment.


  how does it look when the mouse is over the toolbutton?
  the plasma button svg also has an element for that, to look like breeze 
toolbuttons (look at the navigation controls for the calendar for instance

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11652

To: apol, #plasma
Cc: mart, #frameworks, michaelh, ngraham

D11891: Fix crashes in NotifyByAudio when closing applications

[René J . V . Bertin]

rjvbb added a comment.


  (Oops, missed that one :-/)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: cfeck, rjvbb, mpyne, michaelh, ngraham

D11753: baloodb: Add clean command

[Michael Heidelbach]

michaelh planned changes to this revision.
michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:316
> What do you consider a "truly dead" symlink?
> 
> If you really want to do it correctly, you have to walk the file system 
> yourself, one symlink target path component at a time - each path component 
> can be a symlink itself, or a mount point. You should check the device id for 
> *every* path component.

Damn, you're right! I was fooled by this:

  $ balooctl index /mnt/otto/test.mp4
  $ ln -s /mnt/otto/test.mp4 ~/Videos/

baloo now also indexes `~/Videos/test.mp4`
Only in this case 
`m_pimpl->m_transaction->documentId(info.symlink.toLocal8Bit());` will return 
an `id != 0`

I did not notice because every indexed symbolic link on my system also has its 
target indexed. I never saw `id == 0`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

D11891: Fix crashes in NotifyByAudio when closing applications

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> rjvbb wrote in notifybyaudio.cpp:148-150
> Slightly better English:
> 
>   // since stopping a mediaobject means it wont't emit finished(). However,
>   // we can receive pending finished() signals that were already emitted after
>   // playback completed: phonon uses a queued connection for these signals.

wont't -> won't (or will not)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: cfeck, rjvbb, mpyne, michaelh, ngraham

D11891: Fix crashes in NotifyByAudio when closing applications

[René J . V . Bertin]

rjvbb requested changes to this revision.
rjvbb added a comment.
This revision now requires changes to proceed.


  (sorry, keep forgetting to set the action. Consider this a change request at 
least for the typo in the comment ;))

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: rjvbb, mpyne, michaelh, ngraham

D11891: Fix crashes in NotifyByAudio when closing applications

[René J . V . Bertin]

rjvbb added a comment.


  So the difference here is that `finishNotification` isn't called if 
`notification == nullptr`, with the crucial difference probably being the fact 
that `m` isn't added multiple times to the list of reusable items?
  
  Why isn't that logic part of `finishNotification()`? IOW, is there a valid 
reason for finishNotification to be called with a NULL `notification` argument 
but `m` that hasn't yet been moved from m_notifications to m_reusablePhotons?

INLINE COMMENTS

> notifybyaudio.cpp:148-150
> +// since stoping a mediaobject means it wont't emit finished() *BUT*
> +// since the finished signal is a queued connection in phonon it can 
> happen
> +// that the playing had already finished and we just had not got the 
> signal yet

Slightly better English:

  // since stopping a mediaobject means it wont't emit finished(). However,
  // we can receive pending finished() signals that were already emitted after
  // playback completed: phonon uses a queued connection for these signals.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann
Cc: rjvbb, mpyne, michaelh, ngraham

D11361: add a version containmentForScreen with activity

[Marco Martin]

mart updated this revision to Diff 31200.
mart added a comment.


  - make sure the new containment has the proper activity

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11361?vs=30915=31200

BRANCH
  arcpatch-D11361

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik added a comment.


  > The only reason why the symbolic line-art versions exist is because the 
prettier icons look bad at small sizes on low-dpi screens.
  
  Note that the physical size of the icon is the same for 1x on low dpi and 2x 
on high dpi so the icon will be hard to tell which is the main motivation for 
this patch. I have to look closely to actually see the tiny dark blue overlay 
denoting the folder type (music, downloads, etc)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik updated this revision to Diff 31197.
broulik added a comment.


  - Rebase
  - Address Christoph's comments (4x scale and indentation)

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=29668=31197

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11863: Add virt-manager icons

[Noah Davis]

ndavis added a comment.


  In D11863#238210 , @ngraham wrote:
  
  > Looks good to me! Nice use of the Breeze icon style. @andreaska?
  
  
  Thank! If the other reviewer takes a long time to respond, do I still have to 
wait for their permission to land it?

REPOSITORY
  R266 Breeze Icons

BRANCH
  virt-manager_icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11863

To: ndavis, #vdg, ngraham, andreaska
Cc: ngraham, andreaska, #frameworks, michaelh