D13554: [Properties dialog] Make all field values on general tab selectable
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13554 To: ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13554: [Properties dialog] Make all field values on general tab selectable
ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The Location field was already selectable; this patches extends that courtesy to all the rest. BUG: 105692 FIXED-IN 5.48 REPOSITORY R241 KIO BRANCH everything-is-selectable (branched from master) REVISION DETAIL https://phabricator.kde.org/D13554 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13552: Improve some permissions-related strings
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13552: Improve some permissions-related strings
ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 96714 FIXED-IN: 5.48 Improve some permissions-related strings to be clearer. TEST PLAN File: Folder: REPOSITORY R241 KIO BRANCH improve-permission-strings (branched from master) REVISION DETAIL https://phabricator.kde.org/D13552 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13510: Add XDG WM Base support to our XDGShell API
romangg added inline comments.
INLINE COMMENTS
> registry.cpp:88
> #include
> +#include
>
nitpick: put this include directly below the other xdg-shell ones above.
> xdgshell_stable.cpp:195
> +
> +uint32_t constraint = 0;
> +if
> (positioner.constraints().testFlag(XdgPositioner::Constraint::SlideX)) {
`= XDG_POSITIONER_CONSTRAINT_ADJUSTMENT_NONE`
> xdgshell_interface.h:64
> +Stable,
> +Dave
> };
Is this the natural evolution of all protocols? In the end they become you?
> xdgshell_stable_interface.cpp:79
> +if (!configureSerials.contains(serial)) {
> +// TODO: send error?
> +return;
not according to specs
> xdgshell_stable_interface.cpp:160
> +const quint32 serial = global->display()->nextSerial();
> +wl_array state;
> +wl_array_init();
Could you pls name this better: for example wlStates
> xdgshell_stable_interface.cpp:222
> +Q_UNUSED(client)
> +// TODO: send protocol error if there are still surfaces mapped
> +wl_resource_destroy(resource);
Do it?
> xdgshell_stable_interface.cpp:246
> +if (it != surfaces.constEnd()) {
> +wl_resource_post_error(surface->resource(), XDG_WM_BASE_ERROR_ROLE,
> "ShellSurface already created");
> +return;
Wrong id `XDG_WM_BASE_ERROR_ROLE`.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13510
To: davidedmundson, #kwin
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D13549: Switch KIO::convertSize() to KFormat::formatByteSize()
pino created this revision. pino added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY Make KIO::convertSize() use KFormat::formatByteSize(), instead of using an own copy of the same function. The handling of the user configuration of the default dialect is left as-is, and it should work fine since the two enums BinaryUnitDialect (the removed one, and the one in KFormat) are the same. TEST PLAN Builds fine, no changes to the result of KIO::convertSize(). REPOSITORY R241 KIO BRANCH kformat (branched from master) REVISION DETAIL https://phabricator.kde.org/D13549 AFFECTED FILES src/core/global.cpp To: pino, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13541: Port solid from Qt5::Widgets to Qt5::Gui
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. const auto would be even nicer, if possible. Besides that, lgtm. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
[ANNOUNCE] CMake 3.12.0-rc1 is ready for testing
I am proud to announce the first CMake 3.12 release candidate.
https://cmake.org/download/
Documentation is available at:
https://cmake.org/cmake/help/v3.12
Release notes appear below and are also published at
https://cmake.org/cmake/help/v3.12/release/3.12.html
Some of the more significant changes in CMake 3.12 are:
* The "target_link_libraries()" command now supports Object
Libraries. Linking to an object library uses its object files in
direct dependents and also propagates usage requirements.
* The "target_link_libraries()" command may now be called to modify
targets created outside the current directory.
* The "file(GLOB)" and "file(GLOB_RECURSE)" commands learned a new
flag "CONFIGURE_DEPENDS" which enables expression of build system
dependency on globbed directory's contents.
* The "Compile Features" functionality is now aware of C++ 20. No
specific features are yet enumerated besides the "cxx_std_20" meta-
feature.
* The Visual Studio Generators for VS 2017 learned to support a
"version=14.##" option in the "CMAKE_GENERATOR_TOOLSET" value (e.g.
via the "cmake(1)" "-T" option) to specify a toolset version number.
* The "cmake(1)" Build Tool Mode ("cmake --build") gained "--
parallel []" and "-j []" options to specify a parallel
build level. They map to corresponding options of the native build
tool.
* The "add_compile_definitions()" command was added to set
preprocessor definitions at directory level. This supersedes
"add_definitions()".
* The "cmake_minimum_required()" and "cmake_policy(VERSION)"
commands now accept a version range using the form
"[...]". The "" version is required but policies are
set based on the "" version. This allows projects to specify a
range of versions for which they have been updated and avoid
explicit policy settings.
* The "find_package()" command now searches a prefix specified by a
"PackageName_ROOT" CMake or environment variable. Package roots are
maintained as a stack so nested calls to all "find_*" commands
inside find modules also search the roots as prefixes. See policy
"CMP0074".
* A new "$" and "$"
"generator expression" has been added to enable consumption of
generator expressions whose evaluation results itself in generator
expressions.
* A new "$" "generator expression" has been
added.
* A new "$" "generator expression" has
been added.
* The "FindCURL" module now provides imported targets.
* The "FindJPEG" module now provides imported targets.
* A "FindODBC" module was added to find an Open Database
Connectivity (ODBC) library.
* New "FindPython3" and "FindPython2" modules, as well as a new
"FindPython" module, have been added to provide a new way to locate
python environments.
CMake 3.12 Release Notes
Changes made since CMake 3.11 include the following.
New Features
Generators
--
* The Visual Studio Generators for VS 2017 learned to support a
"version=14.##" option in the "CMAKE_GENERATOR_TOOLSET" value (e.g.
via the "cmake(1)" "-T" option) to specify a toolset version number.
Command-Line
* The "cmake(1)" Build Tool Mode ("cmake --build") gained "--
parallel []" and "-j []" options to specify a parallel
build level. They map to corresponding options of the native build
tool.
Commands
* The "add_compile_definitions()" command was added to set
preprocessor definitions at directory level. This supersedes
"add_definitions()".
* The "cmake_minimum_required()" and "cmake_policy(VERSION)"
commands now accept a version range using the form
"[...]". The "" version is required but policies are
set based on the "" version. This allows projects to specify a
range of versions for which they have been updated and avoid
explicit policy settings.
* The "file(GLOB)" and "file(GLOB_RECURSE)" commands learned a new
flag "CONFIGURE_DEPENDS" which enables expression of build system
dependency on globbed directory's contents.
* The "file(TOUCH)" and "file(TOUCH_NOCREATE)" commands were added
to expose "TOUCH" functionality without having to use CMake's
command- line tool mode with "execute_process()".
* The "find_package()" command now searches a prefix specified by a
"PackageName_ROOT" CMake or environment variable. Package roots are
maintained as a stack so nested calls to all "find_*" commands
inside find modules also search the roots as prefixes. See policy
"CMP0074".
* The "install()" command learned an optional "NAMELINK_COMPONENT"
parameter, which allows you to change the component for a shared
library's namelink. If none is specified, the value of "COMPONENT"
is used by default.
* The "list()" command learned a "JOIN" sub-command to concatenate
list's elements separated by a glue string.
* The "list()" command learned a "SUBLIST" sub-command to get a
sublist of the list.
* The "list()" command learned a "TRANSFORM" sub-command to apply
D13495: Fix XDGV6 popup test
davidedmundson added a comment. You can only set the size in the ctor, so needed a new instance. For the rest of the tests we don't need different sizes. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13495 To: davidedmundson, #kwin Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
[ANNOUNCE] CMake 3.11.4 available for download
We are pleased to announce that CMake 3.11.4 is now available for download. Please use the latest release from our download page: https://cmake.org/download/ Thanks for your support! - Changes in 3.11.4 since 3.11.3: Brad King (2): Windows: Restore support for running CMake through a symlink CMake 3.11.4 Jean-Christophe Fillion-Robin (1): ExternalProject: Fix cache generation when args end with "-NOTFOUND" Matt McCormick (1): ExternalProject: Improve URL_HASH argument description
D13495: Fix XDGV6 popup test
romangg added a comment. What's with positioner2? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13495 To: davidedmundson, #kwin Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13535: Do not cancel old clipboard selection if it is same as the new one.
fvogt added a comment.
Yes, a unit test makes sense. I tried to add
// replace the data source with itself, ensure that it did not get cancelled
// replace the data source with itself, ensure that it did not get cancelled
selectionOfferedSpy.clear();
dataSource2->offer(QStringLiteral("text/plain"));
dataDevice->setSelection(2, dataSource2.data());
QVERIFY(selectionOfferedSpy.wait());
QVERIFY(sourceCancelled2Spy.isEmpty());
in TestDataDevice::testReplaceSource() and it fails without this patch.
With this patch however, the selection isn't offered (is that correct
behaviour?) so the wait() times out.
Is there a better way to test this?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13535
To: fvogt, #plasma, #frameworks
Cc: graesslin, kde-frameworks-devel, michaelh, ngraham, bruns
D13488: Make XDGShellV5 co-compilable with XDGWMBase
romangg added inline comments. INLINE COMMENTS > xdgshell_v5.cpp:36 > public: > -void setupV5(xdg_shell *shell) override; > +void setupV5(xdg_shell *shell); > void release() override; This should be still an override. > wayland-xdg-shell-v5-client-protocol.h:1 > +/* Generated by wayland-scanner 1.14.0 */ > + Is this file not also changed like the other ones? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13488 To: davidedmundson, #plasma Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13541: Port solid from Qt5::Widgets to Qt5::Gui
graesslin created this revision. graesslin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. graesslin requested review of this revision. REVISION SUMMARY The only usage of widgets was to get the active window. Incorrectly this was done through QWidget which would fail for any application using just QtGui (e.g. QtQuick). As QGuiApplication also provides access to the focus window we can use QtGui API instead. As a note: the whole thing is X11 specific as a window ID is passed to another process, which cannot work on Wayland. It's possible to get it work on Wayland, but that would require: - changes to the dbus protocol - add a dependency to KWayland - or extend QtWayland to generate the required code TEST PLAN Compiles REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 AFFECTED FILES CMakeLists.txt src/solid/CMakeLists.txt src/solid/devices/backends/udisks2/udisksstorageaccess.cpp To: graesslin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
Re: New KDE application
Hi Rahul, Sayan, Did this project start? Where do I find the source code? -- Alexander Potashev 2018-01-16 9:36 GMT+03:00 Rahul Chowdhury : > On Tue, Jan 16, 2018 at 3:24 AM, Albert Astals Cid wrote: >> El dilluns, 15 de gener de 2018, a les 13:00:13 CET, Rahul Chowdhury va >> escriure: >>> On Mon, Jan 15, 2018 at 5:25 AM, Albert Astals Cid wrote: >>> > El dimecres, 10 de gener de 2018, a les 23:49:06 CET, Sayan Biswas va >>> > >>> > escriure: >>> >> Hi, >>> > >>> > Hi >>> >>> Hi, >>> >>> >> A very happy new year to all. Hope you guys are doing good. :) >>> >> >>> >> Me and Rahul (CC'ed; IRC nick - rahulch) came up with an idea for a >>> >> new application in KDE, and we were hoping to get an opinion on it. >>> >> >>> >> The central idea behind the app will be to manage the expenses of a >>> >> group of users. As a user, you can create one or more groups, add >>> >> members to them, and add entries for expenses for a given group. You >>> >> can also check the outstanding balances and choose to settle-up with one >>> >> or more members. There will be options for fine-tuning a given entry - >>> >> decide who all have born the total expenditure and by what >>> >> proportions, how should the total expense be divided among the members >>> >> (equally/specific amounts/etc), add pictures for receipts, add >>> >> comments, and so on and so forth. >>> > >>> > So somthing like a Splitwise Free Software clone, have you checked if one >>> > already exists? I know starting is half the fun, but maybe joining an >>> > existing project that does something similar and help them build a >>> > desktop application would also be nice. >>> >>> Yes, the idea is very much similar to Splitwise. They do not have any >>> desktop version yet. >>> We wanted to have some similar free desktop application in KDE. >>> >>> >> We are planning to start off with desktop application with a >>> >> decentralised >>> >> approach, i.e. the users will hold the data of the shared expenses. Now >>> >> again, there is a possibility of tampering with the expenditure so we >>> >> might >>> >> need to set a centralised archived or something similar data set to >>> >> maintain the integrity and persistence of a transaction. We are open to >>> >> opinions and discussions for this also. Further to that we will be >>> >> building >>> >> mobile application for the users ease of usage and add expenditure on the >>> >> go. After all, mobiles are more widely used by user than desktop >>> >> application. >>> >> >>> >> >>> >> For settling up we were thinking of integrating some standard payment >>> >> gateways (PayPal, etc) but I am not sure of how much of this >>> >> integration is possible in KDE. >>> > >>> > I don't understand this question, just open a webview to paypal and be >>> > done? >>> Not just open a webview or redirect to some paypal webpage in a >>> browser, but handle the entire transaction from the application itself >>> with some third party integration like PayU. If we could integrate one >>> or more such payment services/e-wallets with the application and >>> handle the paments it would be great. >> >> Honestly, up to you, but opening a webview is easier and more secure, or at >> least you shift the blame to paypal if they have a hackable page. Rolling up >> your own payment code means it's much more easy to make a mistake and get >> hacked like it seems happened to oneplus. >> >> Cheers, >> Albert > > Yes, that makes sense. We will go ahead with the webview approach. > Thanks for the suggestion. > > > Regards, > Rahul
D13535: Do not cancel old clipboard selection if it is same as the new one.
graesslin added a comment. I would appreciate a unit test for the issue. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13535 To: fvogt, #plasma, #frameworks Cc: graesslin, kde-frameworks-devel, michaelh, ngraham, bruns
D13536: Do not cancel old clipboard selection if it is same as the new one.
michalsrb abandoned this revision. michalsrb added a comment. Already submitted: https://phabricator.kde.org/D13535 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13536 To: michalsrb Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13533: Add the arclint file in kwayland
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH add-arclint REVISION DETAIL https://phabricator.kde.org/D13533 To: bshah, #frameworks, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12820: Add KWayland virtual desktop protocol
mart updated this revision to Diff 36161. mart added a comment. - remove release from the protocol - new_id is id REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=36052=36161 BRANCH mart/plasmavirtualdesktop REVISION DETAIL https://phabricator.kde.org/D12820 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_plasma_virtual_desktop.cpp src/client/CMakeLists.txt src/client/plasmavirtualdesktop.cpp src/client/plasmavirtualdesktop.h src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h src/client/protocols/plasma-virtual-desktop.xml src/client/protocols/plasma-window-management.xml src/client/registry.cpp src/client/registry.h src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/plasmavirtualdesktop_interface.cpp src/server/plasmavirtualdesktop_interface.h src/server/plasmawindowmanagement_interface.cpp src/server/plasmawindowmanagement_interface.h src/tools/mapping.txt To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13494: Fix stupid copy paste bug in XDGShellV6 Client
romangg accepted this revision.
romangg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> xdgshell_v6.cpp:180
> uint32_t constraint = 0;
> +
> if
> (positioner.constraints().testFlag(XdgPositioner::Constraint::SlideX)) {
remove this new line
REPOSITORY
R127 KWayland
BRANCH
xdg_squash
REVISION DETAIL
https://phabricator.kde.org/D13494
To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13536: Do not cancel old clipboard selection if it is same as the new one.
michalsrb created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. michalsrb requested review of this revision. REVISION SUMMARY GTK applications seem to call wl_data_device::set_selection multiple times with the same wl_data_source object, replacing it with itself. If we cancel it, they will destroy it and the selection will be gone. With this patch it is again possible to copy from GTK applications. BUG: 395366 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13536 AFFECTED FILES src/server/datadevice_interface.cpp To: michalsrb Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13535: Do not cancel old clipboard selection if it is same as the new one.
fvogt created this revision. fvogt added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY GTK applications seem to call wl_data_device::set_selection multiple times with the same wl_data_source object, replacing it with itself. If we cancel it, they will destroy it and the selection will be gone. With this patch it is again possible to copy from GTK applications. BUG: 395366 TEST PLAN Patch provided by the reporter, he reported success. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13535 AFFECTED FILES src/server/datadevice_interface.cpp To: fvogt, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13533: Add the arclint file in kwayland
bshah created this revision. bshah added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - xml linter to make sure that we don't add broken protocols - merge-conflict so that we don't commit merge-conflict markers - spell check for documentation - cppcheck to check the code TEST PLAN broke some files manually, and then ran arc lint REPOSITORY R127 KWayland BRANCH add-arclint REVISION DETAIL https://phabricator.kde.org/D13533 AFFECTED FILES .arclint To: bshah, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12820: Add KWayland virtual desktop protocol
davidedmundson added a comment. Cool. I'm happy with the protocol, except for one important comment. IMHO worth doing the kwin/plasma code before pushing the frameworks code. INLINE COMMENTS > plasma-virtual-desktop.xml:62 > + > + > + This still isn't deletable, see my comment from last time. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns
Re: Semantic analysis KDevelop
Hi, Note: our mailing list is kdeve...@kde.org for user questions, or kdevelop-de...@kde.org for development; kde-devel@kde.org is a more general KDE development list and not for KDevelop specifically. Please direct KDevelop-specific questions to one of these lists. On 06/14/2018 12:40 AM, Maxime. Haselbauer wrote: Am I the only one having problem since month with the semantic analysis of Kdevelop You are not the only one, but it does not affect everyone either :/ To me at least, it is not fully clear what circumstances result in this problem, but I think there are multiple possible reasons, all somehow related to which standard includes are parsed in what mode. Best, Sven
Semantic analysis KDevelop
Am I the only one having problem since month with the semantic analysis of Kdevelop see https://i.imgur.com/CxKVYh8.png (needless to say Task is a QObject and the code compile and execute correctly) Switching "compiler for path" from clang to gcc does not help Any idea as of why is that welcome No LSB modules are available. Distributor ID: neon Description:KDE neon LTS User Edition 5.12 Release:16.04 Codename: xenial Linux zalman 4.13.0-43-generic #48~16.04.1-Ubuntu SMP Thu May 17 12:56:46 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux konsole 18.04.2 QMake version 3.1 Using Qt version 5.9.3 in /usr/lib/x86_64-linux-gnu
