D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Nibaldo González]

nibags added a comment.


  I think it makes sense to change this in WorDetect: verify delimiter 
characters on the left and right edge of the string, either inside or outside 
the string. I will make another diff with this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24326: Add syntax highlighting for RenPy (.rpy)

[jonathan poelen]

jpoelen updated this revision to Diff 67235.
jpoelen added a comment.


  - Renpy: folding sensitive to indentation

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24326?vs=67094=67235

BRANCH
  renpy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24326

AFFECTED FILES
  autotests/folding/highlight.rpy.fold
  autotests/html/highlight.rpy.html
  autotests/input/highlight.rpy
  autotests/reference/highlight.rpy.ref
  data/syntax/renpy.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24363: Fix several build system errors

[Alexey Min]

alexeymin marked an inline comment as done.
alexeymin added a comment.


  Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our 
main documentation page https://api.kde.org/frameworks/index.html . If it is 
really Tier 3, then maybe it does not even make sense to make IconThemes and 
ConfigWidgets optional?
  
  > The subgroup value looks wrong
  
  And maybe should I include a change to `mtainfo.yaml` modifying `subgroup: 
Tier 1` to `subgroup: Tier 3` then?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

[Alexey Min]

alexeymin updated this revision to Diff 67233.
alexeymin added a comment.


  - Bring back missing KF5_DEP_VERSION

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67207=67233

BRANCH
  alexeymin/fix-cmake-errors

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D23789#540033 , @dfaure wrote:
  
  > I found confirmation in cmake's 
Tests/RunCMake/GenerateExportHeader/reference/
  
  
  Not sure what you exactly mean, can you please specify confirmation for what? 
And what this recommends us to do? :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67222.
kossebau edited the test plan for this revision.
kossebau added a comment.


  - update to latest version of ecm_generate_export_header with deprecation 
text support

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23802?vs=65692=67222

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

AFFECTED FILES
  CMakeLists.txt
  autotests/kplugininfotest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/CMakeLists.txt
  src/kdeinit/ktoolinvocation.cpp
  src/kdeinit/ktoolinvocation.h
  src/plugin/kdbusservicestarter.cpp
  src/plugin/kdbusservicestarter.h
  src/services/kplugininfo.cpp
  src/services/kplugininfo.h
  src/services/kservice.h
  src/sycoca/ksycoca.cpp
  src/sycoca/ksycoca.h
  tests/CMakeLists.txt

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67221.
kossebau added a comment.


  - update to latest version of ecm_generate_export_header with deprecation 
text support

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23800?vs=65686=67221

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23800

AFFECTED FILES
  CMakeLists.txt
  autotests/kaboutdatatest.cpp
  autotests/kusertest.cpp
  src/lib/CMakeLists.txt
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h
  src/lib/plugin/kexportplugin.h
  src/lib/plugin/kpluginfactory.cpp
  src/lib/plugin/kpluginfactory.h
  src/lib/util/kuser.h

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67220.
kossebau added a comment.


  - extend *_VERSION_DEPRECATED to expect third argument "text" first 
experimental consumption time support for "text" output with GCC compiler
  - make *_NO_DEPRECATED a proper shortcut for DISABLE_BEFORE_AND_AT=CURRENT
  - extend unit test to cover *_NO_DEPRECATED

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23789?vs=66670=67220

BRANCH
  addgenerateexportheader

REVISION DETAIL
  https://phabricator.kde.org/D23789

AFFECTED FILES
  docs/module/ECMGenerateExportHeader.rst
  modules/ECMGenerateExportHeader.cmake
  tests/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer-no-deprecated/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer-no-deprecated/main.cpp
  tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/main.cpp
  tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/format_version/main.cpp
  tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/library/library.cpp
  tests/ECMGenerateExportHeaderTest/library/library.hpp
  tests/ECMGenerateExportHeaderTest/library/main.cpp

To: kossebau
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> kfileplacesitem.cpp:113
>  case KFilePlacesModel::RecentlySavedType:
> -m_groupName = i18nc("@item", "Recently Saved");
> +m_groupName = i18nc("@item", "Recent");
>  break;

this string needs a context, as "recent" basically leaves translators clueless 
on what it refers to and/or where it is used

> kfileplacesmodel.h:139
> + */
> +KBookmark bookmarkForUrl(const QUrl );
>  

this method must be const

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: pino, meven, trickyricky26, andreask, huftis, svenmauch, 
kde-frameworks-devel, spoorun, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D24372: Compile without deprecated foreach

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  src/core/*
  src/urifilters/*
  src/widgets/*

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  ahmad/foreach-urifilters2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24372

AFFECTED FILES
  src/core/batchrenamejob.cpp
  src/core/connection.cpp
  src/core/copyjob.cpp
  src/core/desktopexecparser.cpp
  src/core/job.cpp
  src/core/kprotocolinfofactory.cpp
  src/core/kprotocolmanager.cpp
  src/core/ksslcertificatemanager.cpp
  src/core/ktcpsocket.cpp
  src/core/scheduler.cpp
  src/core/tcpslavebase.cpp
  src/urifilters/ikws/ikwsopts.cpp
  src/urifilters/ikws/searchproviderdlg.cpp
  src/urifilters/shorturi/kshorturifilter.cpp
  src/widgets/accessmanager.cpp
  src/widgets/clipboardupdater.cpp
  src/widgets/delegateanimationhandler.cpp
  src/widgets/dropjob.cpp
  src/widgets/kdesktopfileactions.cpp
  src/widgets/kdirmodel.cpp
  src/widgets/kfileitemactions.cpp
  src/widgets/kfileitemdelegate.cpp
  src/widgets/kpropertiesdialog.cpp
  src/widgets/krun_win.cpp
  src/widgets/ksslcertificatebox.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/kurifiltersearchprovideractions.cpp
  src/widgets/previewjob.cpp
  src/widgets/sslui.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24363: Fix several build system errors

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Note: the metainfo file says this framework is tier 3.
  
  The subgroup value looks wrong

INLINE COMMENTS

> CMakeLists.txt:40-41
> +# IconThemes and ConfigWidgets are optional
> +find_package(KF5IconThemes)
> +find_package(KF5ConfigWidgets)
>  

KF5_DEP_VERSION is lost here

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

[Alexey Min]

alexeymin reopened this revision.
alexeymin added a comment.


  Phabricator, you're drunk, it is not pushed to master

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24367: Some sanity verification

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> pcx.cpp:312
> +qWarning() << "Failed to get scanline for" << y << "might be out 
> of bounds";
> +}
>  for (int x = 0; x < header.width(); ++x) {

If `p` indeed could be zero, the next statements need to be in an `else` block 
(or a add a `return`).

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D24367

To: sandsmark, aacid, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24363: Fix several build system errors

[Phabricator]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:9ddd3ba2f531: qqc2-desktop-style: Fix several builsystem 
errors (authored by Aleksey Minnekhanov 
aleksei.minneha...@myoffice.team).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67188=67207

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[ANNOUNCE] CMake 3.15.4 available for download

[Robert Maynard]

We are pleased to announce that CMake 3.15.4 is now available for download.

This release fixes a regression in EXCLUDE_FROM_ALL.

Please use the latest release from our download page:
  https://cmake.org/download/

Thanks for your support!

-
Changes in 3.15.4 since 3.15.3:

Brad King (10):
  VS: Tell VS 16.4 not to verify SYMBOLIC custom command outputs
  Tests: Teach RunCMake to support a custom working directory
  Tests: Revise RunCMake.add_subdirectory ExcludeFromAll to avoid globbing
  Tests: Clarify target names in RunCMake.add_subdirectory ExcludeFromAll
  Makefiles: Revert "Make build root targets ... recursive"
  Restore "all" target in subdirectories marked EXCLUDE_FROM_ALL
  Help: Add release note for EXCLUDE_FROM_ALL fix in 3.14.7
  Help: Add release note for EXCLUDE_FROM_ALL fix in 3.15.4
  Help: Mention 3.14.7 EXCLUDE_FROM_ALL fix in 3.15.4 release note
  CMake 3.15.4

LE GARREC Vincent (1):
  Help: Document VS 2019 toolset in MSVC_TOOLSET_VERSION

[ANNOUNCE] CMake 3.14.7 available for download

[Robert Maynard]

We are pleased to announce that CMake 3.14.7 is now available for download.

This release fixes a regression in EXCLUDE_FROM_ALL.

Please use the latest release from our download page:
  https://cmake.org/download/

Thanks for your support!

-
Changes in 3.14.7 since 3.14.6:

Brad King (6):
  Tests: Teach RunCMake to support a custom working directory
  Tests: Revise RunCMake.add_subdirectory ExcludeFromAll to avoid globbing
  Tests: Clarify target names in RunCMake.add_subdirectory ExcludeFromAll
  Restore "all" target in subdirectories marked EXCLUDE_FROM_ALL
  Help: Add release note for EXCLUDE_FROM_ALL fix in 3.14.7
  CMake 3.14.7

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  Code is ready for review, tests pass @elvisangelaccio @dfaure 
  Following https://phabricator.kde.org/D7446#528536 recentlyused:/ bookmarks 
are only added when KDE_FULL_SESSION is set.
  
  D23557  will get merged after this one.
  
  If no-one objects I will merge this in a couple of days.
  Thanks @ngraham for the first accept ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24010: Fix generating properties that start with an uppercase letter

[Aleix Pol Gonzalez]

apol updated this revision to Diff 67204.
apol added a comment.


  Update test, it seems like tests aren't comparing with .ref now :(

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24010?vs=66271=67204

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24010

AFFECTED FILES
  autotests/kconfig_compiler/test13.cpp.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test13.kcfg
  src/kconfig_compiler/kconfig_compiler.cpp

To: apol, #frameworks
Cc: ngraham, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Shipit!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 67203.
meven added a comment.


  Small changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65981=67203

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24010: Fix generating properties that start with an uppercase letter

[Nathaniel Graham]

ngraham added a comment.


  +1, Works for me

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24010

To: apol, #frameworks
Cc: ngraham, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24010: Fix generating properties that start with an uppercase letter

[Nathaniel Graham]

ngraham added a dependent revision: D5961: Adoption of KUserFeedback for 
Discover.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24010

To: apol, #frameworks
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24367: Some sanity verification

[Martin Tobias Holmedahl Sandsmark]

sandsmark created this revision.
sandsmark added reviewers: aacid, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sandsmark requested review of this revision.

REVISION SUMMARY
  Since QImage does sanity checking for overflows and stuff wrt. dimensions and 
depth, check for QImage::isNull() as early as possible to see if there's some 
funky business going on.
  
  Also tried to add some checks wherever we wrote to "raw" memory.

TEST PLAN
  Unit tests pass, and tested converting some files from 
https://samples.ffmpeg.org/image-samples/ to pngs, and that seemed to work.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D24367

AFFECTED FILES
  src/imageformats/exr.cpp
  src/imageformats/pcx.cpp
  src/imageformats/pic.cpp
  src/imageformats/psd.cpp
  src/imageformats/rgb.cpp
  src/imageformats/tga.cpp

To: sandsmark, aacid, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  @meven do you think you could address the final comments and land this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24363: Fix several build system errors

[Alexey Min]

alexeymin retitled this revision from "Fix several builsystem errors" to "Fix 
several build system errors".

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several builsystem errors

[Alexey Min]

alexeymin edited the summary of this revision.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several builsystem errors

[Alexey Min]

alexeymin added reviewers: mart, Plasma, dfaure.
alexeymin added a subscriber: kde-frameworks-devel.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Dominik Haumann]

dhaumann added a comment.


  Hm, would it make sense to change this? I.e. if the word itself has a word 
boundary, also use this?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Nibaldo González]

nibags added a comment.


  Indeed, WordDetect checks only the boundaries. What happens is that when 
using WordDetect with `".
  It's correct to use RegExpr with `https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Dominik Haumann]

dhaumann added a comment.


  Would it also be an option to fix WordDetect? I always thought WordDetect 
ignores the string contents, it should only check on the boundaries left and 
right

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24357: KateModeMenuList: force the vertical position above the button

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Always display the menu above the trigger button, just like the rest of the 
menus in the status bar (class `KateStatusBarOpenUpMenu`).
  
  This is only noticeable on large monitors, when Kate's window is small.

REPOSITORY
  R39 KTextEditor

BRANCH
  menu-vertical-position

REVISION DETAIL
  https://phabricator.kde.org/D24357

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/view/katestatusbar.cpp

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23523

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21760: Add KListOpenFilesJob

[Méven Car]

meven added a comment.


  Now we can use it :
  
  > dolphin D19989 
  > plasma-vault
  >  libksysguard (KLsofWidget)
  >  dataengines/devicenotifications/ksolidnotify

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24308: [DataProtocol] compile without implicit coversion from ascii

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/compile-without-ascii-cast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24308

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

[David Faure]

dfaure closed this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D24252

To: dfaure, cfeck, vkrause, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[David Faure]

dfaure added a comment.


  I suggest do look at kio_file (kio/src/ioslaves/file), the above code was 
inspired by kio_file, and then ported differently to Windows.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov