Re: Unusual behaviour in KDE Connect CMake

[Piyush Aggarwal]

On Wed, Apr 7, 2021 at 3:04 PM Piyush Aggarwal 
wrote:

> I'll get right on it
>
> On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley,  wrote:
>
>> Hi all,
>>
>> Recently changes were made to kdeconnect-kde that introduced new
>> dependencies that broke the build on Windows.
>>
>
This should be fixed by the
https://invent.kde.org/network/kdeconnect-kde/-/commit/80178b8ff80c1e42692b309880d6f1435c62ce4e
. Please poke the CI once so I can be sure.


>> While this in itself is an issue, it has exposed a much more significant
>> issue which requires urgent remediation as it breaks any Windows build node
>> that attempts to carry out a build of kdeconnect. These breakages require
>> manual Sysadmin intervention to correct.
>>
>
This issue needs to be fixed appropriately. I wrote a way to kill
dbus-daemon.exe with Win APIs in the kdeconnect-kde source, used here:
https://github.com/KDE/kdeconnect-kde/blob/master/indicator/main.cpp#L106 .
The Function's definition is here:
https://github.com/KDE/kdeconnect-kde/blob/master/indicator/indicatorhelper_win.cpp#L48
. Please let me know if I can be of help and integrate it somewhere in
Craft/ the CI.

As this creates persistent issues for other projects and because a new
>> dependency was introduced without notification, the following is notice
>> that Windows CI support for kdeconnect-kde will be terminated in 12 hours
>> time should steps to resolve this not be taken.
>>
>
I apologize for the mishap and the inconvenience caused to the other
projects. This was not intended.

Best
Piyush Aggarwal
from the KDE Connect Team

Re: Unusual behaviour in KDE Connect CMake

[Piyush Aggarwal]

I'll get right on it

On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley,  wrote:

> Hi all,
>
> Recently changes were made to kdeconnect-kde that introduced new
> dependencies that broke the build on Windows.
>
> While this in itself is an issue, it has exposed a much more significant
> issue which requires urgent remediation as it breaks any Windows build node
> that attempts to carry out a build of kdeconnect. These breakages require
> manual Sysadmin intervention to correct.
>
> After diagnosing the issue, it would appear that kdeconnect-kde contains
> CMake code that results in "dbus-daemon.exe" being launched. While this may
> appear innocuous, it is problematic on Windows as it prevents the build
> workspace being wiped and then reused by later jobs.
>
> This was the cause of CI failures for various Frameworks, Dolphin and
> KDevelop.
>
> Prior to the new dependency being introduced this was not an issue, as the
> post-testing cleanup phase ensures that all KDE related processes
> (kdeinit5, kiod, kioslave, dbus-daemon, etc) are all terminated.
>
> As this creates persistent issues for other projects and because a new
> dependency was introduced without notification, the following is notice
> that Windows CI support for kdeconnect-kde will be terminated in 12 hours
> time should steps to resolve this not be taken.
>
> Regards,
> Ben Cooksley
> KDE Sysadmin
>

Re: Unusual behaviour in KDE Connect CMake

[Piyush Aggarwal]

On Wed, Apr 7, 2021 at 3:04 PM Piyush Aggarwal 
wrote:

> I'll get right on it
>
> On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley,  wrote:
>
>> Hi all,
>>
>> Recently changes were made to kdeconnect-kde that introduced new
>> dependencies that broke the build on Windows.
>>
>
This should be fixed by the
https://invent.kde.org/network/kdeconnect-kde/-/commit/80178b8ff80c1e42692b309880d6f1435c62ce4e
. Please poke the CI once so I can be sure.


>> While this in itself is an issue, it has exposed a much more significant
>> issue which requires urgent remediation as it breaks any Windows build node
>> that attempts to carry out a build of kdeconnect. These breakages require
>> manual Sysadmin intervention to correct.
>>
>
This issue needs to be fixed appropriately. I wrote a way to kill
dbus-daemon.exe with Win APIs in the kdeconnect-kde source, used here:
https://github.com/KDE/kdeconnect-kde/blob/master/indicator/main.cpp#L106 .
The Function's definition is here:
https://github.com/KDE/kdeconnect-kde/blob/master/indicator/indicatorhelper_win.cpp#L48
. Please let me know if I can be of help and integrate it somewhere in
Craft/ the CI.

As this creates persistent issues for other projects and because a new
>> dependency was introduced without notification, the following is notice
>> that Windows CI support for kdeconnect-kde will be terminated in 12 hours
>> time should steps to resolve this not be taken.
>>
>
I apologize for the mishap and the inconvenience caused to the other
projects. This was not intended.

Best
Piyush Aggarwal
from the KDE Connect Team

Re: Unusual behaviour in KDE Connect CMake

[Piyush Aggarwal]

I'll get right on it

On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley,  wrote:

> Hi all,
>
> Recently changes were made to kdeconnect-kde that introduced new
> dependencies that broke the build on Windows.
>
> While this in itself is an issue, it has exposed a much more significant
> issue which requires urgent remediation as it breaks any Windows build node
> that attempts to carry out a build of kdeconnect. These breakages require
> manual Sysadmin intervention to correct.
>
> After diagnosing the issue, it would appear that kdeconnect-kde contains
> CMake code that results in "dbus-daemon.exe" being launched. While this may
> appear innocuous, it is problematic on Windows as it prevents the build
> workspace being wiped and then reused by later jobs.
>
> This was the cause of CI failures for various Frameworks, Dolphin and
> KDevelop.
>
> Prior to the new dependency being introduced this was not an issue, as the
> post-testing cleanup phase ensures that all KDE related processes
> (kdeinit5, kiod, kioslave, dbus-daemon, etc) are all terminated.
>
> As this creates persistent issues for other projects and because a new
> dependency was introduced without notification, the following is notice
> that Windows CI support for kdeconnect-kde will be terminated in 12 hours
> time should steps to resolve this not be taken.
>
> Regards,
> Ben Cooksley
> KDE Sysadmin
>

Re: Unusual behaviour in KDE Connect CMake

[Piyush Aggarwal]

On Wed, Apr 7, 2021 at 3:04 PM Piyush Aggarwal 
wrote:

> I'll get right on it
>
> On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley,  wrote:
>
>> Hi all,
>>
>> Recently changes were made to kdeconnect-kde that introduced new
>> dependencies that broke the build on Windows.
>>
>
This should be fixed by the
https://invent.kde.org/network/kdeconnect-kde/-/commit/80178b8ff80c1e42692b309880d6f1435c62ce4e
. Please poke the CI once so I can be sure.


>> While this in itself is an issue, it has exposed a much more significant
>> issue which requires urgent remediation as it breaks any Windows build node
>> that attempts to carry out a build of kdeconnect. These breakages require
>> manual Sysadmin intervention to correct.
>>
>
This issue needs to be fixed appropriately. I wrote a way to kill
dbus-daemon.exe with Win APIs in the kdeconnect-kde source, used here:
https://github.com/KDE/kdeconnect-kde/blob/master/indicator/main.cpp#L106 .
The Function's definition is here:
https://github.com/KDE/kdeconnect-kde/blob/master/indicator/indicatorhelper_win.cpp#L48
. Please let me know if I can be of help and integrate it somewhere in
Craft/ the CI.

As this creates persistent issues for other projects and because a new
>> dependency was introduced without notification, the following is notice
>> that Windows CI support for kdeconnect-kde will be terminated in 12 hours
>> time should steps to resolve this not be taken.
>>
>
I apologize for the mishap and the inconvenience caused to the other
projects. This was not intended.

Best
Piyush Aggarwal
from the KDE Connect Team

Re: Unusual behaviour in KDE Connect CMake

[Piyush Aggarwal]

I'll get right on it

On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley,  wrote:

> Hi all,
>
> Recently changes were made to kdeconnect-kde that introduced new
> dependencies that broke the build on Windows.
>
> While this in itself is an issue, it has exposed a much more significant
> issue which requires urgent remediation as it breaks any Windows build node
> that attempts to carry out a build of kdeconnect. These breakages require
> manual Sysadmin intervention to correct.
>
> After diagnosing the issue, it would appear that kdeconnect-kde contains
> CMake code that results in "dbus-daemon.exe" being launched. While this may
> appear innocuous, it is problematic on Windows as it prevents the build
> workspace being wiped and then reused by later jobs.
>
> This was the cause of CI failures for various Frameworks, Dolphin and
> KDevelop.
>
> Prior to the new dependency being introduced this was not an issue, as the
> post-testing cleanup phase ensures that all KDE related processes
> (kdeinit5, kiod, kioslave, dbus-daemon, etc) are all terminated.
>
> As this creates persistent issues for other projects and because a new
> dependency was introduced without notification, the following is notice
> that Windows CI support for kdeconnect-kde will be terminated in 12 hours
> time should steps to resolve this not be taken.
>
> Regards,
> Ben Cooksley
> KDE Sysadmin
>

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Piyush Aggarwal]

brute4s99 added subscribers: nicolasfella, brute4s99.
brute4s99 added a comment.


  +1 to adding the breeze icons support for other OSes. (Thanks @nicolasfella 
for linking me to this diff).
  
  I have hit the same problem with the KDE Connect Windows port. Thank you for 
working on it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: brute4s99, nicolasfella, aboyer, sars, wrobelda, davidedmundson, broulik, 
rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Announcing MyKDE

[Piyush Aggarwal]

Amazing work!

Best
Piyush Aggarwal

On Sat, 3 Oct, 2020, 3:26 pm Carl Schwan,  wrote:

> Hello folks,
> I'm happy to announce the successful deployment of the new identity system
> in KDE, codename MyKDE. The new identity system is now available in
> https://my.kde.org. You should be able to login into the my.kde.org
> website
> with your normal KDE credential.
>
> For the moment, only the wikis are using MyKDE but in the comming months
> this should change with more and more services switching to MyKDE. I will
> let you all know of the progress of the migration.
>
>
> FAQ:
> 
>
> Why the move?
> -
>
> identity.kde.org is using OpenLDAP for user management with a small PHP
> frontend allowing the account creation. And we had the following problems
> with it:
>
> * Account removal is hard, requiring significant manual intervention and
> effort (several hours work in some instances)
> * Account registration takes 30 seconds or more to complete, creating a
> poor
> user experience
> * Groups don't scale effectively
> * Anti-spam measures are too crude
>
> More on that in https://phabricator.kde.org/T8449
>
> Will my data be migrated?
> -
>
> Yes, your data are migrated just by login into MyKDE once. This will
> migrate
> all your group membership (KDE developer, Akademy Team, ...), personal
> data and password.
>
> For users who didn't log into MyKDE during the migration period. If you are
> a KDE developer or KDE e.V. member, your account will be imported as a
> disabled account and you will need to ask sysadmins to enabled it. For the
> rest of the users of identity.kde.org who don't have a membership to
> groups,
> your account will be removed. We think this is the best solution because
> there
> is no need to store personal information that we don't need from users who
> don't use the system anymore. If you want to conserve your account (and
> username), please log at least once. We will send periodic emails reminding
> you of migrating your account.
>
> How do I register a new account in MyKDE?
> -
>
> For the moment the possibility of registering a new account is disabled in
> MyKDE and the only possibility is to create an identity.kde.org account
> and
> then migrate your account. This is due to the fact we don't want some
> accounts existing only in MyKDE. This will naturally change when we migrate
> fully to MyKDE.
>
> How to I collect a badge?
> -
>
> MyKDE has the possibility to grant badges to users. For the moment there is
> only one badge enabled: KDE developer. This badge is given to every KDE
> developer and is displayed on their public profile (if enabled). When the
> new Season of KDE website will be deployed, it will be also possible to
> have
> an SoK mentor and SoK mentee badge.
>
> I'm interested in ideas of new badges (and badge designs), so please let me
> know if you have a genius idea that doesn't gamify KDE contribution (e.g
> no made
> 100/1000/10 000 commits badge).
>
> Note that you are in control of that badge get displayed.
>
> What is the public profile functionality?
> -
>
> One of the new features of MyKDE is the possibility to have a public
> profile.
> This public profile is opt-in, so you need to explicitly enable it to make
> it work and it can display a small bio, your avatar, name, username, social
> network account, Liberapay account, and badges earned.
>
> This is for example how it looks for me:
> https://my.kde.org/user/carlschwan/
>
> Can I contribute to MyKDE?
> --
>
> Yes, the source code is hosted in
> https://invent.kde.org/websites/my-kde-org
> and all the deployment information can be found here:
> https://sysadmin-docs.kde.org/services/mykde.html
>
> Cheers,
> Carl Schwan
> https://carlschwan.eu
>
>
>

Re: Announcing MyKDE

[Piyush Aggarwal]

Amazing work!

Best
Piyush Aggarwal

On Sat, 3 Oct, 2020, 3:26 pm Carl Schwan,  wrote:

> Hello folks,
> I'm happy to announce the successful deployment of the new identity system
> in KDE, codename MyKDE. The new identity system is now available in
> https://my.kde.org. You should be able to login into the my.kde.org
> website
> with your normal KDE credential.
>
> For the moment, only the wikis are using MyKDE but in the comming months
> this should change with more and more services switching to MyKDE. I will
> let you all know of the progress of the migration.
>
>
> FAQ:
> 
>
> Why the move?
> -
>
> identity.kde.org is using OpenLDAP for user management with a small PHP
> frontend allowing the account creation. And we had the following problems
> with it:
>
> * Account removal is hard, requiring significant manual intervention and
> effort (several hours work in some instances)
> * Account registration takes 30 seconds or more to complete, creating a
> poor
> user experience
> * Groups don't scale effectively
> * Anti-spam measures are too crude
>
> More on that in https://phabricator.kde.org/T8449
>
> Will my data be migrated?
> -
>
> Yes, your data are migrated just by login into MyKDE once. This will
> migrate
> all your group membership (KDE developer, Akademy Team, ...), personal
> data and password.
>
> For users who didn't log into MyKDE during the migration period. If you are
> a KDE developer or KDE e.V. member, your account will be imported as a
> disabled account and you will need to ask sysadmins to enabled it. For the
> rest of the users of identity.kde.org who don't have a membership to
> groups,
> your account will be removed. We think this is the best solution because
> there
> is no need to store personal information that we don't need from users who
> don't use the system anymore. If you want to conserve your account (and
> username), please log at least once. We will send periodic emails reminding
> you of migrating your account.
>
> How do I register a new account in MyKDE?
> -
>
> For the moment the possibility of registering a new account is disabled in
> MyKDE and the only possibility is to create an identity.kde.org account
> and
> then migrate your account. This is due to the fact we don't want some
> accounts existing only in MyKDE. This will naturally change when we migrate
> fully to MyKDE.
>
> How to I collect a badge?
> -
>
> MyKDE has the possibility to grant badges to users. For the moment there is
> only one badge enabled: KDE developer. This badge is given to every KDE
> developer and is displayed on their public profile (if enabled). When the
> new Season of KDE website will be deployed, it will be also possible to
> have
> an SoK mentor and SoK mentee badge.
>
> I'm interested in ideas of new badges (and badge designs), so please let me
> know if you have a genius idea that doesn't gamify KDE contribution (e.g
> no made
> 100/1000/10 000 commits badge).
>
> Note that you are in control of that badge get displayed.
>
> What is the public profile functionality?
> -
>
> One of the new features of MyKDE is the possibility to have a public
> profile.
> This public profile is opt-in, so you need to explicitly enable it to make
> it work and it can display a small bio, your avatar, name, username, social
> network account, Liberapay account, and badges earned.
>
> This is for example how it looks for me:
> https://my.kde.org/user/carlschwan/
>
> Can I contribute to MyKDE?
> --
>
> Yes, the source code is hosted in
> https://invent.kde.org/websites/my-kde-org
> and all the deployment information can be found here:
> https://sysadmin-docs.kde.org/services/mykde.html
>
> Cheers,
> Carl Schwan
> https://carlschwan.eu
>
>
>

D29258: Don't use notifybysnore.h on MSYS2

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> CMakeLists.txt:75
>  if (WIN32)
> -find_package(LibSnoreToast REQUIRED)
> -set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED

please maintain the REQUIRED call for normal Windows builds. 
You can use the OS specific build variables..

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29258

To: wojnilowicz, broulik, brute4s99, vonreth
Cc: vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29258: Don't use notifybysnore.h on MSYS2

[Piyush Aggarwal]

brute4s99 added a comment.


  I still do not understand the utility of this patch. What do you hope to fix 
by this patch exactly?
  
  > SnoreToast fails to build on MSYS2 due to missing
  >  which apparently is not available for this compiler.
  
  which compiler are you referring to here?
  
  > This patch changes dependency on SnoreToast from required to optional.
  >  As a result, it allows to actually build KNotifications on MSYS2.
  
  why do you want to build KNotifications on MSYS2?
  
  More inline comments follow, please take a look.

INLINE COMMENTS

> CMakeLists.txt:76
> +find_package(LibSnoreToast)
> +find_package(Qt5Network)
> +

why do we need Qt5Network for all kinds of Windows builds?

> CMakeLists.txt:79
> +include(CMakeDependentOption)
> +cmake_dependent_option(WITH_SNORETOAST "for the Windows Toast 
> Notifications" ON
> +   "Qt5Network_FOUND;LibSnoreToast_FOUND" OFF

the option should be MSYS specific rather than being SnoreToast specific.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29258

To: wojnilowicz, broulik, brute4s99, vonreth
Cc: vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 closed this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  updated libssh to use version 0.9.4 by default in Craft. We can merge this 
and get  for kio-extras builds. \o/

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 marked an inline comment as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 marked 3 inline comments as done.
brute4s99 added inline comments.

INLINE COMMENTS

> vonreth wrote in CMakeLists.txt:26
> yes pls update libssh

Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 
release as parent revision to this revision, please take a look. ^_^

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 added a dependency: D29835: Add libssh 0.9.4 to fix kio-extras on 
windows.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 83159.

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29461?vs=82069=83159

BRANCH
  arcpatch-D29461

REVISION DETAIL
  https://phabricator.kde.org/D29461

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> sitter wrote in CMakeLists.txt:26
> Hm, I am a bit hazy on the details but I think this changes makes no sense. 
> libssh (upstream) introduced an imported target `ssh`. For backwards 
> compatibility we also inject this target when building with older libssh's 
> than the latest (to be honest though, with libssh you basically always want 
> the latest or you'll have an incredibly subpar experience).

I just built libssh 0.9.4, and kio-extras builds fine without this line change. 
Maybe we should try getting latest libssh onboard. Can I help in that somehow 
@vonreth ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 added a subscriber: sitter.
brute4s99 added a comment.


  @sitter could you please review this change as well?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 82069.
brute4s99 added a comment.


  updated the diff

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29461?vs=82039=82069

BRANCH
  arcpatch-D29461

REVISION DETAIL
  https://phabricator.kde.org/D29461

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, vonreth, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 82039.
brute4s99 added a comment.


  needs testing on windows, will update in a while

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29461?vs=82036=82039

BRANCH
  arcpatch-D29461

REVISION DETAIL
  https://phabricator.kde.org/D29461

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, vonreth
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added a reviewer: vonreth.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
brute4s99 requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29461

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, vonreth
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov

D22554: Finer No-Dbus on Windows

[Piyush Aggarwal]

brute4s99 abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  closing this diff.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29258: Don't use notifybysnore.h on MSYS2

[Piyush Aggarwal]

brute4s99 added a comment.


  > SnoreToast fails to build on MSYS2 due to missing
  >  which apparently is not available for this compiler.
  
  I'm sorry, missing what exactly?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29258

To: wojnilowicz, broulik, brute4s99
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Information regarding upcoming Gitlab Migration

[Piyush Aggarwal]

On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol,  wrote:

> On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah  wrote:
> >
> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> > replies]
> >
> > Hello Community members,
> >
> > In view of upcoming Gitlab migration, we sysadmin team wants to share
> > the recommended structuring for the repositories on Gitlab.
> >
> > We had multiple options,
> >
> > - Flat structure: In this option we would have everything under one
> >   single namespace/group: https://invent.kde.org/kde/knetwalk
> > - Subgroups under top-level group: In this option we would have a groups
> >   under KDE namespace: https://invent.kde.org/kde/games/knetwalk
> > - Groups at top level: In this option we would establish a series of
> >   groups at the top level, e.g.  https://invent.kde.org/games/knetwalk
> >
> > We have discussed this with small but representative group of
> > contributors or maintainers, and based on their suggestions, we
> > recommend that we go with option 3. Having sub-groups at top level will
> > allow us to,
> >
> > - Provides good visibility on all reviews, tasks and other items within
> >   the groups/modules we define
> > - Provides improvements to discoverability of projects
> > - Makes it possible for groups of projects to establish a group level
> >   task board should it fit their needs (for tracking a release for
> >   instance)
> > - Makes the most semantic sense, as the ‘KDE’ top level group suggested
> >   in option 2 is duplicative considering the Gitlab instance is under
> >   kde.org.
> > - The discoverability of projects is maximised, as there is no need to
> >   open the top level ‘KDE’ group before going into the subgroup.
> >
> > I've worked on draft "move" of the current set of the repositories in
> > their respective subgroups at the repo-metadata project's branch [1].
> > You can browse the directory structure to get idea of how final
> > structure on Gitlab would look like.
> >
> > If we don't have any objections we would like to implement this next
> > week and move projects to https://invent.kde.org.
> >
> > Thanks!
> > Bhushan for sysadmin team
> >
> > [1]
> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent
>
> Does this mean that to clone it we'll have to go "git clone
> kde:games/knetwalk" or something along the lines?
>
> If that's the case I'd much prefer if we didn't do this, at the moment
> it's already uncomfortable for me to remember the URL for some of the
> repos (e.g. is it sysadmin/ or not?), this will only increase the
> problem and I personally don't see the advantage.
>
> e.g. Is okular graphics or office? Is gwenview plasma or graphics? Is
> krita graphics or its own thing?
>
> I really prefer when I don't have to guess this kind of things when
> fetching a repository.
>
> Aleix
>

This is technical so I would love to hear Sysadmin team's thoughts on this:
Probably there can be a redirect system that lets us do git clone
kde:knotifications and manages to redirect it to
kde/frameworks/tier3/knotifications.git
So we can clone and tinker with stuff as we normally do while the sysadmin
team goes with the recommended system of setting up the repos.
I think this should be possible because Invent already redirects my URLs
which don't end with .git to .git ones. I might be wrong about my
assumption that both things can work similarly.

Best
Piyush Aggarwal

>

Re: Information regarding upcoming Gitlab Migration

[Piyush Aggarwal]

On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol,  wrote:

> On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah  wrote:
> >
> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> > replies]
> >
> > Hello Community members,
> >
> > In view of upcoming Gitlab migration, we sysadmin team wants to share
> > the recommended structuring for the repositories on Gitlab.
> >
> > We had multiple options,
> >
> > - Flat structure: In this option we would have everything under one
> >   single namespace/group: https://invent.kde.org/kde/knetwalk
> > - Subgroups under top-level group: In this option we would have a groups
> >   under KDE namespace: https://invent.kde.org/kde/games/knetwalk
> > - Groups at top level: In this option we would establish a series of
> >   groups at the top level, e.g.  https://invent.kde.org/games/knetwalk
> >
> > We have discussed this with small but representative group of
> > contributors or maintainers, and based on their suggestions, we
> > recommend that we go with option 3. Having sub-groups at top level will
> > allow us to,
> >
> > - Provides good visibility on all reviews, tasks and other items within
> >   the groups/modules we define
> > - Provides improvements to discoverability of projects
> > - Makes it possible for groups of projects to establish a group level
> >   task board should it fit their needs (for tracking a release for
> >   instance)
> > - Makes the most semantic sense, as the ‘KDE’ top level group suggested
> >   in option 2 is duplicative considering the Gitlab instance is under
> >   kde.org.
> > - The discoverability of projects is maximised, as there is no need to
> >   open the top level ‘KDE’ group before going into the subgroup.
> >
> > I've worked on draft "move" of the current set of the repositories in
> > their respective subgroups at the repo-metadata project's branch [1].
> > You can browse the directory structure to get idea of how final
> > structure on Gitlab would look like.
> >
> > If we don't have any objections we would like to implement this next
> > week and move projects to https://invent.kde.org.
> >
> > Thanks!
> > Bhushan for sysadmin team
> >
> > [1]
> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent
>
> Does this mean that to clone it we'll have to go "git clone
> kde:games/knetwalk" or something along the lines?
>
> If that's the case I'd much prefer if we didn't do this, at the moment
> it's already uncomfortable for me to remember the URL for some of the
> repos (e.g. is it sysadmin/ or not?), this will only increase the
> problem and I personally don't see the advantage.
>
> e.g. Is okular graphics or office? Is gwenview plasma or graphics? Is
> krita graphics or its own thing?
>
> I really prefer when I don't have to guess this kind of things when
> fetching a repository.
>
> Aleix
>

This is technical so I would love to hear Sysadmin team's thoughts on this:
Probably there can be a redirect system that lets us do git clone
kde:knotifications and manages to redirect it to
kde/frameworks/tier3/knotifications.git
So we can clone and tinker with stuff as we normally do while the sysadmin
team goes with the recommended system of setting up the repos.
I think this should be possible because Invent already redirects my URLs
which don't end with .git to .git ones. I might be wrong about my
assumption that both things can work similarly.

Best
Piyush Aggarwal

>

Re: Information regarding upcoming Gitlab Migration

[Piyush Aggarwal]

On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol,  wrote:

> On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah  wrote:
> >
> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> > replies]
> >
> > Hello Community members,
> >
> > In view of upcoming Gitlab migration, we sysadmin team wants to share
> > the recommended structuring for the repositories on Gitlab.
> >
> > We had multiple options,
> >
> > - Flat structure: In this option we would have everything under one
> >   single namespace/group: https://invent.kde.org/kde/knetwalk
> > - Subgroups under top-level group: In this option we would have a groups
> >   under KDE namespace: https://invent.kde.org/kde/games/knetwalk
> > - Groups at top level: In this option we would establish a series of
> >   groups at the top level, e.g.  https://invent.kde.org/games/knetwalk
> >
> > We have discussed this with small but representative group of
> > contributors or maintainers, and based on their suggestions, we
> > recommend that we go with option 3. Having sub-groups at top level will
> > allow us to,
> >
> > - Provides good visibility on all reviews, tasks and other items within
> >   the groups/modules we define
> > - Provides improvements to discoverability of projects
> > - Makes it possible for groups of projects to establish a group level
> >   task board should it fit their needs (for tracking a release for
> >   instance)
> > - Makes the most semantic sense, as the ‘KDE’ top level group suggested
> >   in option 2 is duplicative considering the Gitlab instance is under
> >   kde.org.
> > - The discoverability of projects is maximised, as there is no need to
> >   open the top level ‘KDE’ group before going into the subgroup.
> >
> > I've worked on draft "move" of the current set of the repositories in
> > their respective subgroups at the repo-metadata project's branch [1].
> > You can browse the directory structure to get idea of how final
> > structure on Gitlab would look like.
> >
> > If we don't have any objections we would like to implement this next
> > week and move projects to https://invent.kde.org.
> >
> > Thanks!
> > Bhushan for sysadmin team
> >
> > [1]
> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent
>
> Does this mean that to clone it we'll have to go "git clone
> kde:games/knetwalk" or something along the lines?
>
> If that's the case I'd much prefer if we didn't do this, at the moment
> it's already uncomfortable for me to remember the URL for some of the
> repos (e.g. is it sysadmin/ or not?), this will only increase the
> problem and I personally don't see the advantage.
>
> e.g. Is okular graphics or office? Is gwenview plasma or graphics? Is
> krita graphics or its own thing?
>
> I really prefer when I don't have to guess this kind of things when
> fetching a repository.
>
> Aleix
>

This is technical so I would love to hear Sysadmin team's thoughts on this:
Probably there can be a redirect system that lets us do git clone
kde:knotifications and manages to redirect it to
kde/frameworks/tier3/knotifications.git
So we can clone and tinker with stuff as we normally do while the sysadmin
team goes with the recommended system of setting up the repos.
I think this should be possible because Invent already redirects my URLs
which don't end with .git to .git ones. I might be wrong about my
assumption that both things can work similarly.

Best
Piyush Aggarwal

>

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 marked 2 inline comments as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26888

To: brute4s99, vonreth, broulik, #kde_connect
Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 80333.
brute4s99 added a comment.


  work around to fully support the windows backend

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26888?vs=74291=80333

BRANCH
  arcpatch-D26888

REVISION DETAIL
  https://phabricator.kde.org/D26888

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, vonreth, broulik, #kde_connect
Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> broulik wrote in notifybysnore.cpp:200
> Does the notification still end up with an `id` eventually?

yes. I've used the id in the new patch

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 reclaimed this revision.
brute4s99 added a comment.


  sorry. abandoned wrong diff

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26888

To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 added reviewers: vonreth, broulik, KDE Connect.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26888

To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 marked 2 inline comments as done.
brute4s99 added a comment.


  I will be closing this diff as I recently formed a simpler patch. Inviting 
your reviews on that one!
  
  https://phabricator.kde.org/D26888

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26888

To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  really support the windows backend.

REPOSITORY
  R289 KNotifications

BRANCH
  windows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26888

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 74190.
brute4s99 marked 2 inline comments as done.
brute4s99 added a comment.


  updated

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26801?vs=74005=74190

BRANCH
  arcpatch-D26801

REVISION DETAIL
  https://phabricator.kde.org/D26801

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 marked an inline comment as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 74005.
brute4s99 marked 3 inline comments as done.
brute4s99 added a comment.


  update the diff.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26801?vs=73983=74005

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26801

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> brute4s99 wrote in notifybysnore.cpp:143
> KNotif objects by default have  `d->id = -1`
> 
> `notify()` is invoked by the base with -1 ID and later updated with the 
> correct ID and the actions.
> 
> Weirdly though, `pairingRequest` notification is not updated by the base, 
> (that is, the notification has all the information in the first invocation 
> itself) but still it has ID=-1 (because it's not updated later by the base, 
> hence the default ID).

> Weirdly though, `pairingRequest` notification is not updated by the base.

^ this refers to `eventId` of the notification for KDE Connect's pairing 
request.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, 
Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, pawelkwiecinski, ctakano, 
vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, fbampaloukas, 
GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, michaelh, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, MayeulC, lemuel, 
menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> notifybysnore.cpp:143
>  {
> -Q_UNUSED(config);
> -// HACK work around that notification->id() is only populated after 
> returning from here
> -// note that config will be invalid at that point, so we can't pass that 
> along
> -QMetaObject::invokeMethod(this, [this, notification](){ 
> notifyDeferred(notification); }, Qt::QueuedConnection);
> -}
> +if(notification->id() == -1 && notification->eventId() == 
> QStringLiteral("notification")) {
> +return;

KNotif objects by default have  `d->id = -1`

`notify()` is invoked by the base with -1 ID and later updated with the correct 
ID and the actions.

Weirdly though, `pairingRequest` notification is not updated by the base, (that 
is, the notification has all the information in the first invocation itself) 
but still it has ID=-1 (because it's not updated later by the base, hence the 
default ID).

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, 
Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, pawelkwiecinski, ctakano, 
vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, fbampaloukas, 
GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, michaelh, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, MayeulC, lemuel, 
menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added reviewers: vonreth, broulik, KDE Connect.
brute4s99 added a project: KDE Connect.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  This patch fixes the Windows backend.
  The workaround was implemented by completing ditching the notification->id() 
thing, because it relies on updating the notification afterwards.
  
  Updating was not a viable option because WIndows 8 and 8.1 does not support 
updating a notification.

TEST PLAN
  Now the backend actually works and does not crash at every other notification 
like it used to.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26801

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, 
Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, pawelkwiecinski, ctakano, 
vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, fbampaloukas, 
GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, michaelh, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, MayeulC, lemuel, 
menasshock, mikesomov, tctara, apol

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 added a comment.


  we need this because the symbols being currently used are Unix-only. Porting 
to Qt supplied ones allows this plugin to work on other OSes (my concern: 
Windows) as well. 

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 added a comment.


  In D22727#513842 , @dfaure wrote:
  
  > The truth is stronger than "I would not recommend".
  >  put() in SlaveBase-derived classes is called by the KIO library 
(TransferJob), so you CANNOT change the meaning of the arguments. It's part of 
the API/ABI for all slaves, and this cannot change until KF6.
  
  
  can you please add it to https://phabricator.kde.org/tag/kf6/ ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D23313: improve code in Snore backend

[Piyush Aggarwal]

brute4s99 abandoned this revision.
brute4s99 added a comment.


  in that case I should rather leave this diff. I agree this would be messy for 
the history.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23313

To: brute4s99, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23313: improve code in Snore backend

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23313

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 added a comment.


  landed it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks, broulik
Cc: nicolasfella, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:a9b61d5b0cb8: avoid duplicate notifications from showing 
up on Windows and remove whitespaces (authored by brute4s99).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23133?vs=63846=64122#toc

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23133?vs=63846=64122

REVISION DETAIL
  https://phabricator.kde.org/D23133

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, #frameworks, broulik
Cc: nicolasfella, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 added a subscriber: nicolasfella.
brute4s99 added a comment.


  In D23133#515156 , @ngraham wrote:
  
  > Just on Windows, or does this fix the problem on Linux too?
  
  
  that problem has been fixed by @nicolasfella on master of kdeconnect-kde .
  
  This bug was a backend specific issue of the windows build, unrelated to that 
bug. 

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks, broulik
Cc: nicolasfella, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Piyush Aggarwal]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:e96bf17d8cac: have 1024x1024 app icon as fallback icon in 
Snore (authored by brute4s99).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=64119=64120

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64119.
brute4s99 added a comment.


  changed line endings to Unix style

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=64115=64119

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23291: have application's icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64118.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23291?vs=64116=64118

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23291

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23291: have application's icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23291

To: brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23291: have application's icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23291

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 added a comment.


  landing it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64115.
brute4s99 retitled this revision from "have the app icon as fallback icon in 
Snore" to "have 1024x1024 app icon as fallback icon in Snore".
brute4s99 added a comment.


  removed `actualSize` in favour of always passing an icon of size 1024x1024 to 
SnoreToast

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=64114=64115

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64114.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=64113=64114

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64113.
brute4s99 added a comment.


  rebased

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=63984=64113

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 added a comment.


  landing it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:ee5c3d12f965: add `-pid` parameter to Snore backend calls 
(authored by brute4s99).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64111=64112

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64111.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64110=64111

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64110.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64085=64110

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 added a comment.


  had some non-unix line endings, so updated the diff.

REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 added a comment.


  landing it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 added a comment.


  can I merge this one? 

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 added a dependency: D23273: Allow to pass pid in addition to appID 
try to deduce appID from pid.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks
Cc: kde-frameworks-devel, vonreth, LeGast00n, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added reviewers: KDE Connect, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  the upcoming change to SnoreToast also accepts `process id`. Since we can 
supply PID, why not? :)

REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks
Cc: kde-frameworks-devel, vonreth, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 added a comment.


  may I land this now? 

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63984.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=63981=63984

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 marked 2 inline comments as done.

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63981.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=63888=63981

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/CMakeLists.txt
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 added a reviewer: broulik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63888.
brute4s99 added a comment.


  updated

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=63847=63888

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/CMakeLists.txt
  src/notifybysnore.cpp

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 marked 3 inline comments as done.
brute4s99 added inline comments.

INLINE COMMENTS

> broulik wrote in notifybysnore.cpp:163
> The explicit call to `actualSize` shouldn't be neccessary

just to be sure :)

but if there's a check implemented already somewhere within QIcon, I'd happily 
remove it from here!

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added a reviewer: Frameworks.
brute4s99 added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  by this patch, apps with a set WindowIcon will have that icon as fallback 
icon for their notifications invoked through NotifyBySnore backend for 
KNotifications on Windows 10.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63846.
brute4s99 added a comment.


  took inspiration from NotifyByAndroid. Now I can see all types of 
notifications perfectly well!

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23133?vs=63674=63846

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23133

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 added a comment.


  the duplicate notification always has id= -1, so I think it's more an issue  
of KNotifications, I think

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  without this patch, most notifications show every notification twice. This 
seems to be an internal problem of knotification, but until that is fixed, this 
is the next best solution IMHO.

TEST PLAN
  without this patch, every mobile notification from KDE Connect should show up 
twice.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23133

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  In D21661#510813 , @vkrause wrote:
  
  > It looks like this made D-Bus and Phonon hard required dependencies on 
Android again!?
  
  
  
https://cgit.kde.org/knotifications.git/commit/?id=a56a379097d5159f1efa247a109c82e02872dfd2
  
  this should fix that.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: vkrause, nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 added a comment.


  In D22727#505540 , @dfaure wrote:
  
  > The Qt documentation says "Warning: Because of differences in the platforms 
supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are 
platform-dependent: On Unix, the rights of the owner of the file are returned 
and on Windows the rights of the current user are returned. "
  
  
  okay, I believe you mean I should leave these changes as-are in the diff. Am 
I right?
  
  > But, wait, this code is mixing "int permissions" (*) with the QFileDevice 
enum, that doesn't make any sense to me.
  > 
  > (*) this comes from KIO::put, which takes unix permissions on unix, not 
sure what it takes on Windows...
  > 
  > This doesn't match: unix permissions are octal (e.g. group read is 040 in 
octal), QFileDevice enum is hex (0x040).
  
  Okay. I'm still unable to understand where/ how sftp::put() is called, or I 
would change everywhere it is called, to Qt way of permission extraction.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:d00612351778: add snoretoast backend for KNotifications 
on Windows (authored by brute4s99).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=63558=63569

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/knotifications.qrc
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 marked an inline comment as done.

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D21661

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63558.
brute4s99 added a comment.


  removed duplication

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=63551=63558

BRANCH
  arcpatch-D21661

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/knotifications.qrc
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63551.
brute4s99 added a comment.


  rebased.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=63549=63551

BRANCH
  arcpatch-D21661

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/knotifications.qrc
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63549.
brute4s99 added a comment.


  landing this one. 

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=63538=63549

BRANCH
  arcpatch-D21661

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/knotifications.qrc
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 marked 2 inline comments as done.
brute4s99 added a comment.


  done.

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D21661

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  waiting for some green light(s) for now...

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63538.
brute4s99 added a comment.


  - removed the duplicate remover.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=62374=63538

BRANCH
  arcpatch-D21661

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/knotifications.qrc
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  landing it...

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> pino wrote in kio_sftp.cpp:383
> sounds like you need to use the *User enums, not the *Owner ones

https://www.gnu.org/software/libc/manual/html_node/Permission-Bits.html

The link says these bits refer to the owner of the file. Should I still change 
these to *User ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: pino, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, 
sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> win32_defaults.notifyrc:90
> +Comment[zh_TW]=程式發生了嚴重錯誤，必須離開
> +Action=Snore
> +

Can someone please confirm if this file is correctly used?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  Please do a last minute review, I believe this patch is ready to merge now. 

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 added a comment.


  In D22727#501824 , @vonreth wrote:
  
  > Looks good.
  >  Why not the first time 
  
  
  I was afraid of reverts 

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added a reviewer: vonreth.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
brute4s99 requested review of this revision.

TEST PLAN
  should build on windows with mingw as compiler
  
  should build on linux with gcc

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22727

AFFECTED FILES
  sftp/kio_sftp.cpp

To: brute4s99, vonreth
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22554: Finer No-Dbus on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 62383.
brute4s99 added a comment.


  let's put a pin in this for a while until I get a better solution for DBus on 
Windows

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22554?vs=62069=62383

BRANCH
  arcpatch-D22554

REVISION DETAIL
  https://phabricator.kde.org/D22554

AFFECTED FILES
  src/CMakeLists.txt

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D21660: remove dbus for windows build and change audio dep logic

[Piyush Aggarwal]

brute4s99 added a comment.


  sorry about that. I'll find a better solution that doesn't break builds 

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 marked 2 inline comments as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 62374.
brute4s99 marked an inline comment as done.
brute4s99 added a comment.


  updated and rebased.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=61084=62374

BRANCH
  arcpatch-D21661

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/knotifications.qrc
  src/notifybysnore.cpp
  src/notifybysnore.h
  src/win32_defaults.notifyrc

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22659: Fix bracket

[Piyush Aggarwal]

brute4s99 accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22659

To: vonreth, brute4s99
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov