Re: Can we get tags and tarballs for the KDE Qt patch collection
Hi, Am Dienstag, 8. Juni 2021, 12:51:35 CEST schrieb Neal Gompa: > On Mon, Jun 7, 2021 at 4:52 PM Albert Astals Cid wrote: > > > > El dilluns, 7 de juny de 2021, a les 20:46:25 (CEST), Nate Graham va > > escriure: > > > Hello folks, > > > > > > The Fedora packagers were mentioning to me today that it would be a lot > > > easier for them to ship Qt with our patch collection if we made tags and > > > tarballs. Is this something we could look into doing? > > > > We explicitly do not want to make releases > > https://community.kde.org/Qt5PatchCollection#Will_there_be_releases.3F > > > > Making a release means having to use of a version number, and any version > > number we use will be wrong. > > > > Don't think this as a product, think of it as a central place where patches > > are collected. > > > > If they want a tarball because using git is a problem, they can always use > > https://invent.kde.org/qt/qt/qtbase/-/archive/kde/5.15/qtbase-kde-5.15.tar.bz2 > > ? > > > > You *already* are using version numbers and bumped it to 5.15.3: > https://blog.neon.kde.org/2021/06/04/kde-neons-qt-is-now-built-from-kdes-git-branches/ No, that was done in upstream Qt's 5.15 branch when 5.15.2 got prepared. New version numbers and releases would be necessary if new features get introduced by backported patches, but FWICT that is explicitly against the goal. See https://community.kde.org/Qt5PatchCollection. Cheers, Fabian > This is unreasonable if you're going to make us need fixes from there. > I'd rather we didn't pretend this is something other than what it is: > a community maintained uplift of Qt 5.15 while Plasma works to move to > Qt 6. > > Also, that URL is unstable, you'd get different things each time you'd > fetch from it based on the HEAD of that branch. > > -- > 真実はいつも一つ！/ Always, there's only one truth!
Re: Can we get tags and tarballs for the KDE Qt patch collection
> I'm unsure whether we should stick to "those are patches, grab them" > or, for convenience, giving it a version number that is more than 5.15.2, > less than 5.15.3, says it comes from kde, and allows multiple releases I would suggest simply using 5.12.2-kdemmdd for those, if it will happen. Eike
Re: Can we get tags and tarballs for the KDE Qt patch collection
On Tue, Jun 8, 2021 at 6:36 PM Ömer Fadıl USTA wrote: > > Please don't get me wrong but naming these patches under name of KDE will > make people confuse. > That will lead people to think that it is just KDE-related. So my suggestion > is naming is something like > qt-15.3-communityN that will let everyone take these patches whether if they > are using KDE or not. The branch is already "kde/5.15", so that ship has kind of sailed... 5.15.3.kde.N would at least maintain that relationship info. -- 真実はいつも一つ！/ Always, there's only one truth!
Re: Can we get tags and tarballs for the KDE Qt patch collection
Please don't get me wrong but naming these patches under name of KDE will make people confuse. That will lead people to think that it is just KDE-related. So my suggestion is naming is something like qt-15.3-communityN that will let everyone take these patches whether if they are using KDE or not. Ömer Fadıl Usta PGP key : 0xfd11561976b1690b about.me/omerusta Johannes Zarl-Zierl , 9 Haz 2021 Çar, 01:17 tarihinde şunu yazdı: > Am Dienstag, 8. Juni 2021, 16:56:56 CEST schrieb David Faure: > > On mardi 8 juin 2021 15:04:20 CEST Nate Graham wrote: > > > That being the case, what is the problem with us tagging it as 5.15.3? > > > We would not be using our own version number but rather the one set by > > > upstream. If the issue is one of not wanting to mislead people into > > > thinking that this is some kind of officially sanctioned thing, could > it > > > be something like "5.15.3-kde-patches"? > > > > It's not just about official or not. One day the Qt Company *will* > release > > 5.15.3 (as per the KDE/FreeQt agreement), no? > > So we cannot release something called 5.15.3 which is in fact different > > (older) from what will one day be 5.15.3. > > > > I'm unsure whether we should stick to "those are patches, grab them" > > or, for convenience, giving it a version number that is more than 5.15.2, > > less than 5.15.3, says it comes from kde, and allows multiple > releases > > Setting apart the technicalities of 5.15.3 vs 5.15.2.x vs 5.15.3.kde.N, I > think the best place to come up with a solution is the KDE side, not > downstream distributions: > > If we tell people "this is just a bunch of patches, but you should really > apply them" we create a much bigger problem that nobody can tell for sure > anymore whether that particular distro version of Qt does contain the > patches > or not. If not for the packagers we should provide somewhat canonical > versions > for ourselves and save ourselves some headaches over bug triaging... > > Cheers, > Johannes > >
Re: Can we get tags and tarballs for the KDE Qt patch collection
Am Dienstag, 8. Juni 2021, 16:56:56 CEST schrieb David Faure: > On mardi 8 juin 2021 15:04:20 CEST Nate Graham wrote: > > That being the case, what is the problem with us tagging it as 5.15.3? > > We would not be using our own version number but rather the one set by > > upstream. If the issue is one of not wanting to mislead people into > > thinking that this is some kind of officially sanctioned thing, could it > > be something like "5.15.3-kde-patches"? > > It's not just about official or not. One day the Qt Company *will* release > 5.15.3 (as per the KDE/FreeQt agreement), no? > So we cannot release something called 5.15.3 which is in fact different > (older) from what will one day be 5.15.3. > > I'm unsure whether we should stick to "those are patches, grab them" > or, for convenience, giving it a version number that is more than 5.15.2, > less than 5.15.3, says it comes from kde, and allows multiple releases Setting apart the technicalities of 5.15.3 vs 5.15.2.x vs 5.15.3.kde.N, I think the best place to come up with a solution is the KDE side, not downstream distributions: If we tell people "this is just a bunch of patches, but you should really apply them" we create a much bigger problem that nobody can tell for sure anymore whether that particular distro version of Qt does contain the patches or not. If not for the packagers we should provide somewhat canonical versions for ourselves and save ourselves some headaches over bug triaging... Cheers, Johannes signature.asc Description: This is a digitally signed message part.
Re: Can we get tags and tarballs for the KDE Qt patch collection
On 6/8/21 9:02 AM, Nicolas Fella wrote: On 07/06/2021 20:46, Nate Graham wrote: Hello folks, The Fedora packagers were mentioning to me today that it would be a lot easier for them to ship Qt with our patch collection if we made tags and tarballs. Is this something we could look into doing? Nate I think it would help the discussion to know what exactly of the status quo is creating problems. The lack of tags/version number? That there is no tarball on download.kde.org? The lack of notifying when distros should update their package? Something else? I don't know those details, so hopefully any of the Fedora packagers can provide the information. Nate
Re: Can we get tags and tarballs for the KDE Qt patch collection
On 07/06/2021 20:46, Nate Graham wrote: Hello folks, The Fedora packagers were mentioning to me today that it would be a lot easier for them to ship Qt with our patch collection if we made tags and tarballs. Is this something we could look into doing? Nate I think it would help the discussion to know what exactly of the status quo is creating problems. The lack of tags/version number? That there is no tarball on download.kde.org? The lack of notifying when distros should update their package? Something else?
Re: Can we get tags and tarballs for the KDE Qt patch collection
On mardi 8 juin 2021 15:04:20 CEST Nate Graham wrote: > On 6/8/21 5:20 AM, David Redondo wrote: > > Am Dienstag, 8. Juni 2021, 12:51:35 CEST schrieb Neal Gompa: > >> You *already* are using version numbers and bumped it to 5.15.3: > >> https://blog.neon.kde.org/2021/06/04/kde-neons-qt-is-now-built-from-kdes-> > >> >> git -branches/ > > > > KDE did not bump the version number, the 5.15 (and kde/5.15) branch > > contains the commits from > > TQtC that increased the version number before it was closed. > > > > David > > That being the case, what is the problem with us tagging it as 5.15.3? > We would not be using our own version number but rather the one set by > upstream. If the issue is one of not wanting to mislead people into > thinking that this is some kind of officially sanctioned thing, could it > be something like "5.15.3-kde-patches"? It's not just about official or not. One day the Qt Company *will* release 5.15.3 (as per the KDE/FreeQt agreement), no? So we cannot release something called 5.15.3 which is in fact different (older) from what will one day be 5.15.3. I'm unsure whether we should stick to "those are patches, grab them" or, for convenience, giving it a version number that is more than 5.15.2, less than 5.15.3, says it comes from kde, and allows multiple releases -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: Can we get tags and tarballs for the KDE Qt patch collection
On Tue, Jun 8, 2021 at 9:22 AM Ahmad Samir wrote: > > On 07/06/2021 22:52, Albert Astals Cid wrote: > > El dilluns, 7 de juny de 2021, a les 20:46:25 (CEST), Nate Graham va > > escriure: > >> Hello folks, > >> > >> The Fedora packagers were mentioning to me today that it would be a lot > >> easier for them to ship Qt with our patch collection if we made tags and > >> tarballs. Is this something we could look into doing? > > > > We explicitly do not want to make releases > >https://community.kde.org/Qt5PatchCollection#Will_there_be_releases.3F > > > > Making a release means having to use of a version number, and any version > > number we use will be wrong. > > > > Don't think this as a product, think of it as a central place where patches > > are collected. > > > > If they want a tarball because using git is a problem, they can always use > > https://invent.kde.org/qt/qt/qtbase/-/archive/kde/5.15/qtbase-kde-5.15.tar.bz2 > > ? > > > > Cheers, > >Albert > > > Alternatively they could treat it like backported kernel patches? > https://src.fedoraproject.org/rpms/kernel/blob/rawhide/f/Patchlist.changelog > I don't know the > details but it's doable is what I am saying. > > The thing is, IIUC the KDE Qt patch curators don't want to create a release, > just a set of > "important" patches on top of the last open-source Qt release, i.e. deal with > it like any other > project whose upstream hasn't made any new releases in a long time, but there > are new commits in > git; I am sure most distro packagers have seen one or two cases as such. > The kernel has a weird, special workflow that no other package does. It's because the RHEL kernel and Fedora kernel sources are merged and non-upstream RHEL-ish changes are now always present in the source tree. -- 真実はいつも一つ！/ Always, there's only one truth!
Re: Can we get tags and tarballs for the KDE Qt patch collection
On 07/06/2021 22:52, Albert Astals Cid wrote: El dilluns, 7 de juny de 2021, a les 20:46:25 (CEST), Nate Graham va escriure: Hello folks, The Fedora packagers were mentioning to me today that it would be a lot easier for them to ship Qt with our patch collection if we made tags and tarballs. Is this something we could look into doing? We explicitly do not want to make releases https://community.kde.org/Qt5PatchCollection#Will_there_be_releases.3F Making a release means having to use of a version number, and any version number we use will be wrong. Don't think this as a product, think of it as a central place where patches are collected. If they want a tarball because using git is a problem, they can always use https://invent.kde.org/qt/qt/qtbase/-/archive/kde/5.15/qtbase-kde-5.15.tar.bz2 ? Cheers, Albert Alternatively they could treat it like backported kernel patches? https://src.fedoraproject.org/rpms/kernel/blob/rawhide/f/Patchlist.changelog I don't know the details but it's doable is what I am saying. The thing is, IIUC the KDE Qt patch curators don't want to create a release, just a set of "important" patches on top of the last open-source Qt release, i.e. deal with it like any other project whose upstream hasn't made any new releases in a long time, but there are new commits in git; I am sure most distro packagers have seen one or two cases as such. My 2p. Have a good day. -- Ahmad Samir
Re: Can we get tags and tarballs for the KDE Qt patch collection
On Tue, Jun 8, 2021 at 9:04 AM Nate Graham wrote: > > On 6/8/21 5:20 AM, David Redondo wrote: > > Am Dienstag, 8. Juni 2021, 12:51:35 CEST schrieb Neal Gompa: > >> You *already* are using version numbers and bumped it to 5.15.3: > >> https://blog.neon.kde.org/2021/06/04/kde-neons-qt-is-now-built-from-kdes-git > >> -branches/ > > KDE did not bump the version number, the 5.15 (and kde/5.15) branch contains > > the commits from > > TQtC that increased the version number before it was closed. > > > > David > > > That being the case, what is the problem with us tagging it as 5.15.3? > We would not be using our own version number but rather the one set by > upstream. If the issue is one of not wanting to mislead people into > thinking that this is some kind of officially sanctioned thing, could it > be something like "5.15.3-kde-patches"? > "5.15.3.kde.N" would be the convention I'd recommend (to avoid issues with various distribution version consumption mechanisms), but yeah, having snapshot releases would make life *much* simpler. -- 真実はいつも一つ！/ Always, there's only one truth!
Re: Can we get tags and tarballs for the KDE Qt patch collection
On 6/8/21 5:20 AM, David Redondo wrote: Am Dienstag, 8. Juni 2021, 12:51:35 CEST schrieb Neal Gompa: You *already* are using version numbers and bumped it to 5.15.3: https://blog.neon.kde.org/2021/06/04/kde-neons-qt-is-now-built-from-kdes-git -branches/ KDE did not bump the version number, the 5.15 (and kde/5.15) branch contains the commits from TQtC that increased the version number before it was closed. David That being the case, what is the problem with us tagging it as 5.15.3? We would not be using our own version number but rather the one set by upstream. If the issue is one of not wanting to mislead people into thinking that this is some kind of officially sanctioned thing, could it be something like "5.15.3-kde-patches"? Nate
Re: Can we get tags and tarballs for the KDE Qt patch collection
Am Dienstag, 8. Juni 2021, 12:51:35 CEST schrieb Neal Gompa: > You *already* are using version numbers and bumped it to 5.15.3: > https://blog.neon.kde.org/2021/06/04/kde-neons-qt-is-now-built-from-kdes-git > -branches/ KDE did not bump the version number, the 5.15 (and kde/5.15) branch contains the commits from TQtC that increased the version number before it was closed. David
Re: Can we get tags and tarballs for the KDE Qt patch collection
On Tue, Jun 8, 2021 at 10:52 PM Neal Gompa wrote: > On Mon, Jun 7, 2021 at 4:52 PM Albert Astals Cid wrote: > > > > El dilluns, 7 de juny de 2021, a les 20:46:25 (CEST), Nate Graham va > escriure: > > > Hello folks, > > > > > > The Fedora packagers were mentioning to me today that it would be a lot > > > easier for them to ship Qt with our patch collection if we made tags > and > > > tarballs. Is this something we could look into doing? > > > > We explicitly do not want to make releases > > https://community.kde.org/Qt5PatchCollection#Will_there_be_releases.3F > > > > Making a release means having to use of a version number, and any > version number we use will be wrong. > > > > Don't think this as a product, think of it as a central place where > patches are collected. > > > > If they want a tarball because using git is a problem, they can always > use > https://invent.kde.org/qt/qt/qtbase/-/archive/kde/5.15/qtbase-kde-5.15.tar.bz2 > ? > > > > You *already* are using version numbers and bumped it to 5.15.3: > > https://blog.neon.kde.org/2021/06/04/kde-neons-qt-is-now-built-from-kdes-git-branches/ > > This is unreasonable if you're going to make us need fixes from there. > I'd rather we didn't pretend this is something other than what it is: > a community maintained uplift of Qt 5.15 while Plasma works to move to > Qt 6. > > Also, that URL is unstable, you'd get different things each time you'd > fetch from it based on the HEAD of that branch. > Gitlab offers stable URLs based on a specific hash if absolutely required, see: https://invent.kde.org/qt/qt/qtbase/-/archive/2a2f3cd61f59ccec0eecb09e4a8795d7322edfcb/qtbase-2a2f3cd61f59ccec0eecb09e4a8795d7322edfcb.tar.bz2 Please note however that my previous comment on no automated access still applies. > > -- > 真実はいつも一つ！/ Always, there's only one truth! > Cheers, Ben
Re: Can we get tags and tarballs for the KDE Qt patch collection
On Mon, Jun 7, 2021 at 4:52 PM Albert Astals Cid wrote: > > El dilluns, 7 de juny de 2021, a les 20:46:25 (CEST), Nate Graham va escriure: > > Hello folks, > > > > The Fedora packagers were mentioning to me today that it would be a lot > > easier for them to ship Qt with our patch collection if we made tags and > > tarballs. Is this something we could look into doing? > > We explicitly do not want to make releases > https://community.kde.org/Qt5PatchCollection#Will_there_be_releases.3F > > Making a release means having to use of a version number, and any version > number we use will be wrong. > > Don't think this as a product, think of it as a central place where patches > are collected. > > If they want a tarball because using git is a problem, they can always use > https://invent.kde.org/qt/qt/qtbase/-/archive/kde/5.15/qtbase-kde-5.15.tar.bz2 > ? > You *already* are using version numbers and bumped it to 5.15.3: https://blog.neon.kde.org/2021/06/04/kde-neons-qt-is-now-built-from-kdes-git-branches/ This is unreasonable if you're going to make us need fixes from there. I'd rather we didn't pretend this is something other than what it is: a community maintained uplift of Qt 5.15 while Plasma works to move to Qt 6. Also, that URL is unstable, you'd get different things each time you'd fetch from it based on the HEAD of that branch. -- 真実はいつも一つ！/ Always, there's only one truth!
Re: Can we get tags and tarballs for the KDE Qt patch collection
On Tue, Jun 8, 2021 at 8:52 AM Albert Astals Cid wrote: > El dilluns, 7 de juny de 2021, a les 20:46:25 (CEST), Nate Graham va > escriure: > > Hello folks, > > > > The Fedora packagers were mentioning to me today that it would be a lot > > easier for them to ship Qt with our patch collection if we made tags and > > tarballs. Is this something we could look into doing? > > We explicitly do not want to make releases > https://community.kde.org/Qt5PatchCollection#Will_there_be_releases.3F > > Making a release means having to use of a version number, and any version > number we use will be wrong. > > Don't think this as a product, think of it as a central place where > patches are collected. > > If they want a tarball because using git is a problem, they can always use > https://invent.kde.org/qt/qt/qtbase/-/archive/kde/5.15/qtbase-kde-5.15.tar.bz2 > ? > Please note that automated services should not use the /archive/ endpoints provided by Gitlab - they're for human use only. The recommendation here would be for distributions to periodically manually download snapshots (using the above endpoints if they wish) and then upload those into their systems. > Cheers, > Albert > Cheers, Ben > > > > > Nate > > > > > > >
Re: Can we get tags and tarballs for the KDE Qt patch collection
El dilluns, 7 de juny de 2021, a les 20:46:25 (CEST), Nate Graham va escriure: > Hello folks, > > The Fedora packagers were mentioning to me today that it would be a lot > easier for them to ship Qt with our patch collection if we made tags and > tarballs. Is this something we could look into doing? We explicitly do not want to make releases https://community.kde.org/Qt5PatchCollection#Will_there_be_releases.3F Making a release means having to use of a version number, and any version number we use will be wrong. Don't think this as a product, think of it as a central place where patches are collected. If they want a tarball because using git is a problem, they can always use https://invent.kde.org/qt/qt/qtbase/-/archive/kde/5.15/qtbase-kde-5.15.tar.bz2 ? Cheers, Albert > > Nate >
Can we get tags and tarballs for the KDE Qt patch collection
Hello folks, The Fedora packagers were mentioning to me today that it would be a lot easier for them to ship Qt with our patch collection if we made tags and tarballs. Is this something we could look into doing? Nate
