D22594: [Dolphin] Open Preferred Search Tool action

[Piotr Dabrowski]

pdabrowski added a comment.


  I did some more testing, and everything seems to work fine:
  
sudo su
cd /usr/share/applications
  
sleep 2 && mv org.kde.kfind.desktop org.kde.kfind.desktop_# no KFind now
  
sleep 2 && mv org.kde.kfind.desktop_ org.kde.kfind.desktop# KFind 
installed
  
  Actions to test (KFind installed/not installed):
  
  - menubar -> `Tools` -> `Open KFind`/none
  - `Control` toolbutton (menubar hidden) -> `Tools` -> `Open KFind`/none
  - [`Settings`] -> `Configure Shortcuts...` -> shortcut for `Open KFind`/`Open 
Preferred Search Tool` in the list

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22594: [Dolphin] Open Preferred Search Tool action

[Piotr Dabrowski]

pdabrowski added a comment.


  No problem. I'm glad it works :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22594: [Dolphin] Open Preferred Search Tool action

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Well now I'm embarrassed to admit that I probably didn't. I think I updated 
it but forgot to compile lol. Sorry for wasting your time!
  
  This looks great to me now. @elvisangelaccio do you agree?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22594: [Dolphin] Open Preferred Search Tool action

[Piotr Dabrowski]

pdabrowski added a comment.


  Hmm... Are you using the latest diff 
(https://phabricator.kde.org/D22594?id=62212)?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22199: New plugin to open the selected file path

[Arnaud Ruiz]

nononux marked 2 inline comments as done.
nononux added inline comments.

INLINE COMMENTS

> dhaumann wrote in plugin_kateopenselection.cpp:80
> A PluginViewKateOpenSelection instance is created here for every 
> KTextEditor::MainWindow - this is ok and works as designed / intended.
> 
> However, PluginViewKateOpenSelection inherits KTextEditor::Command, which 
> itself registers in its constructor with the command "open-selection" in the 
> Kate's command line. Now when you create multiple  MainWindows in Kate (View 
> > New Window), then you will add *the same* "open-selection" command twice, 
> which is wrong.
> 
> In short: PluginViewKateOpenSelection must not inherit KTextEditor::Command. 
> Instead, the PluginKateOpenSelection should inherit it.

As a class cannot inherit from 2 QObjects, I've made another class included in 
the plugin as a member.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D22199

To: nononux, dhaumann
Cc: dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad, 
fbampaloukas, domson, michaelh, ngraham, demsking, skadinna, cullmann, sars

D22594: [Dolphin] Open Preferred Search Tool action

[Nathaniel Graham]

ngraham added a comment.


  No, I already had KFind installed. I just opened Dolphin and looked at the 
menu item, nothing fancy. :/
  
  F7070963: repro-2019-07-21_16.08.02.webm 


REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22199: New plugin to open the selected file path

[Arnaud Ruiz]

nononux updated this revision to Diff 62250.
nononux added a comment.


  Fix the required parts, I hope it's ok this time :)

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22199?vs=61266=62250

BRANCH
  openselection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22199

AFFECTED FILES
  addons/CMakeLists.txt
  addons/openselection/CMakeLists.txt
  addons/openselection/Messages.sh
  addons/openselection/kateopenselectionplugin.desktop
  addons/openselection/plugin.qrc
  addons/openselection/plugin_kateopenselection.cpp
  addons/openselection/plugin_kateopenselection.h
  addons/openselection/rc.cpp
  addons/openselection/ui.rc
  doc/kate/plugins.docbook

To: nononux, dhaumann
Cc: dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad, 
fbampaloukas, domson, michaelh, ngraham, demsking, skadinna, cullmann, sars

D22594: [Dolphin] Open Preferred Search Tool action

[Piotr Dabrowski]

pdabrowski added a comment.


  > The way you've implemented the menu item naming seems a bit fragile though
  
  True. It's really hard to update it reliably.
  KMoreTools* do not provide an easy way to get notified that the tools 
changed. Even current solution in "More Search Tools" menu recreates the menu 
every time it is displayed.
  So I tried updating the action every time menu containing it is shown. 
Connect()ions for this aren't pretty, but this should actually work...
  
  > In my testing, the name doesn't show up and it falls back to the static 
name.
  
  This is strange, because this action should be updated on many occasions, 
including Dolphin startup.
  Or is your testcase installing KFind while Dolphin is open, or doing 
something similar? (Either way, that should work too).
  
  Please let me know a test scenario that fails.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22594: [Dolphin] Open Preferred Search Tool action

[Nathaniel Graham]

ngraham added a comment.


  All right, you've convinced me on the shortcut.
  
  The way you've implemented the menu item naming seems a bit fragile though 
(and in line 1410 of `src/dolphinmainwindow.cpp`, it's not used at all). In my 
testing, the name doesn't show up and it falls back to the static name. If you 
can't find a way to implement the feature reliably, it may be best to just 
always show static text. But it would be nice to have the name of the app 
reliably show up there, though.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22199: New plugin to open the selected file path

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  The KTextEditor::Command implementation is wrong, see my other comments. 
Please fix this first :-)

INLINE COMMENTS

> plugin_kateopenselection.cpp:80
> +{
> +return new PluginViewKateOpenSelection(this,mainWindow);
> +}

A PluginViewKateOpenSelection instance is created here for every 
KTextEditor::MainWindow - this is ok and works as designed / intended.

However, PluginViewKateOpenSelection inherits KTextEditor::Command, which 
itself registers in its constructor with the command "open-selection" in the 
Kate's command line. Now when you create multiple  MainWindows in Kate (View > 
New Window), then you will add *the same* "open-selection" command twice, which 
is wrong.

In short: PluginViewKateOpenSelection must not inherit KTextEditor::Command. 
Instead, the PluginKateOpenSelection should inherit it.

> plugin_kateopenselection.cpp:107
> +if (selection.isEmpty()) {
> +const KTextEditor::Cursor  = editView->cursorPosition();
> +const QString line = editView->document()->line(cursor.line());

Please factor this code part out into a separate function: QString 
findPathAtCursor(...).

Reasoning: Currently, you are mixing different levers of logic, i.e. 
slotOpenSelection() should open the selection, but not itself do the work to 
find the path under a cursor.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D22199

To: nononux, dhaumann
Cc: dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad, 
fbampaloukas, domson, michaelh, ngraham, demsking, skadinna, cullmann, sars

D22602: Updated copyright years

[Davide Gianforte]

gengisdave accepted this revision as: gengisdave.
gengisdave added a comment.
This revision is now accepted and ready to land.


  No objections

REPOSITORY
  R167 Krusader

BRANCH
  copyright-years

REVISION DETAIL
  https://phabricator.kde.org/D22602

To: nmel, #krusader, gengisdave
Cc: gengisdave, kde-doc-english, gennad, fbampaloukas, nmel, mjanczara, 
miroslavm, skadinna, janlepper, abika, martinkostolny, asensi, andreaska

D22594: [Dolphin] Open Preferred Search Tool action

[Piotr Dabrowski]

pdabrowski added a comment.


  > 2. For the keyboard shortcut let's use Alt instead of Shift. It is an 
alternate search, after all.
  
  I found `Ctrl+Shift+F` to be much more popular for "search", "advanced 
search", "search in all ...", "find in ...", "advanced find", etc.:
  https://defkey.com/what-means/ctrl-shift-f (40 hits) vs
  https://defkey.com/what-means/ctrl-alt-f (7 hits)
  
  And `Ctrl+Shift+F` seems to be widely used by virtually //all// of the most 
professional applications:
  Mozilla Thunderbird, Opera, Sublime, Android Studio, Atom, IntelliJ IDEA, 
Visual Studio, NetBeans, Notepad++, Qt Creator, Visual Studio Code, Outlook
  
  That's why I have used this shortcut.
  
  My personal opinion is that it also matches `Shift+F4` shortcut for "Open 
Terminal" better (see screenshot).
  Both of which open an //external// tool, which I think goes well with the 
`Shift` modifier.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22594: [Dolphin] Open Preferred Search Tool action

[Piotr Dabrowski]

pdabrowski updated this revision to Diff 62212.
pdabrowski edited the summary of this revision.
pdabrowski added a comment.


  > 1. Instead of showing a generic text, how about making it actually say 
"Search with https://phabricator.kde.org/D22594?vs=62211=62212

REVISION DETAIL
  https://phabricator.kde.org/D22594

AFFECTED FILES
  doc/index.docbook
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h
  src/dolphinpart.cpp
  src/dolphinpart.h
  src/dolphinui.rc

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22594: [Dolphin] Open Preferred Search Tool action

[Piotr Dabrowski]

pdabrowski updated this revision to Diff 62211.
pdabrowski added a comment.


  > 3. Whenever you change anything in a .rc file, you need to bump the version 
number that appears at the top of the file.
  
  Done.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22594?vs=62143=62211

REVISION DETAIL
  https://phabricator.kde.org/D22594

AFFECTED FILES
  doc/index.docbook
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h
  src/dolphinpart.cpp
  src/dolphinpart.h
  src/dolphinui.rc

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

D22199: New plugin to open the selected file path

[Arnaud Ruiz]

nononux added a comment.


  Hi, can the code be pushed ? I don't think there are still changes to do.
  (I don't have a dev account)

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D22199

To: nononux
Cc: dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad, 
fbampaloukas, domson, michaelh, ngraham, demsking, skadinna, cullmann, sars

[labplot] po: Revert "[translation] add copy of po files for building packages"

[Luigi Toscano]

Git commit add9013f66f61d1c03cf04e3cd4f17130d7651aa by Luigi Toscano.
Committed on 21/07/2019 at 09:25.
Pushed by ltoscano into branch 'master'.

Revert "[translation] add copy of po files for building packages"

Please don't - this breaks the translation system.

Just use releaseme, following the instruction from
https://community.kde.org/ReleasingSoftware

CCMAIL: stefan.gerl...@uni-konstanz.de
This reverts commit 2db4e2c9ceb5aa5beca66012d0a63915ab513db8.

D  +0-20209 po/bs/labplot2.po
D  +0-18710 po/ca/labplot2.po
D  +0-18703 po/ca@valencia/labplot2.po
D  +0-17364 po/cs/labplot2.po
D  +0-19054 po/da/labplot2.po
D  +0-18959 po/de/labplot2.po
D  +0-18239 po/el/labplot2.po
D  +0-19034 po/en_GB/labplot2.po
D  +0-18131 po/es/labplot2.po
D  +0-17343 po/eu/labplot2.po
D  +0-19572 po/fi/labplot2.po
D  +0-20053 po/fr/labplot2.po
D  +0-18819 po/gl/labplot2.po
D  +0-17394 po/hu/labplot2.po
D  +0-18410 po/it/labplot2.po
D  +0-17325 po/ja/labplot2.po
D  +0-17374 po/lt/labplot2.po
D  +0-17392 po/nds/labplot2.po
D  +0-7245 po/nl/docs/labplot2/index.docbook
D  +0-155  po/nl/docs/labplot2/man-labplot2.1.docbook
D  +0-19168 po/nl/labplot2.po
D  +0-19091 po/pl/labplot2.po
D  +0-17597 po/pt/labplot2.po
D  +0-19591 po/pt_BR/labplot2.po
D  +0-19229 po/ru/labplot2.po
D  +0-19261 po/sk/labplot2.po
D  +0-7262 po/sv/docs/labplot2/index.docbook
D  +0-153  po/sv/docs/labplot2/man-labplot2.1.docbook
D  +0-19145 po/sv/labplot2.po
D  +0-18832 po/tr/labplot2.po
D  +---po/uk/docs/labplot2/export_spreadsheet_dialog.png
D  +---po/uk/docs/labplot2/export_worksheet_dialog.png
D  +---po/uk/docs/labplot2/import-dialog.png
D  +0-7268 po/uk/docs/labplot2/index.docbook
D  +---po/uk/docs/labplot2/labplot.png
D  +0-153  po/uk/docs/labplot2/man-labplot2.1.docbook
D  +---po/uk/docs/labplot2/matrix.png
D  +---po/uk/docs/labplot2/matrix_function_values.png
D  +---po/uk/docs/labplot2/pe-context-menu.png
D  +---po/uk/docs/labplot2/project-explorer.png
D  +---po/uk/docs/labplot2/properties.png
D  +---po/uk/docs/labplot2/spreadsheet.png
D  +---po/uk/docs/labplot2/spreadsheet_generate_equidistant_values.png
D  +---po/uk/docs/labplot2/spreadsheet_generate_function_values.png
D  +---po/uk/docs/labplot2/spreadsheet_generate_random_values.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet1.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet2.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet3.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet4.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet5.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet6.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet7.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet8.png
D  +---po/uk/docs/labplot2/tutorial-spreadsheet9.png
D  +---po/uk/docs/labplot2/tutorial-xy-function1.png
D  +---po/uk/docs/labplot2/tutorial-xy-function10.png
D  +---po/uk/docs/labplot2/tutorial-xy-function2.png
D  +---po/uk/docs/labplot2/tutorial-xy-function3.png
D  +---po/uk/docs/labplot2/tutorial-xy-function4.png
D  +---po/uk/docs/labplot2/tutorial-xy-function5.png
D  +---po/uk/docs/labplot2/tutorial-xy-function6.png
D  +---po/uk/docs/labplot2/tutorial-xy-function7.png
D  +---po/uk/docs/labplot2/tutorial-xy-function8.png
D  +---po/uk/docs/labplot2/tutorial-xy-function9.png
D  +---po/uk/docs/labplot2/workbook.png
D  +---po/uk/docs/labplot2/worksheet.png
D  +0-19284 po/uk/labplot2.po
D  +0-17298 po/zh_CN/labplot2.po
D  +0-17830 po/zh_TW/labplot2.po

https://commits.kde.org/labplot/add9013f66f61d1c03cf04e3cd4f17130d7651aa

[labplot] po: [translation] add copy of po files for building packages

[Stefan Gerlach]

Git commit 2db4e2c9ceb5aa5beca66012d0a63915ab513db8 by Stefan Gerlach.
Committed on 21/07/2019 at 09:14.
Pushed by sgerlach into branch 'master'.

[translation] add copy of po files for building packages

A  +20209 -0po/bs/labplot2.po
A  +18710 -0po/ca/labplot2.po
A  +18703 -0po/ca@valencia/labplot2.po
A  +17364 -0po/cs/labplot2.po
A  +19054 -0po/da/labplot2.po
A  +18959 -0po/de/labplot2.po
A  +18239 -0po/el/labplot2.po
A  +19034 -0po/en_GB/labplot2.po
A  +18131 -0po/es/labplot2.po
A  +17343 -0po/eu/labplot2.po
A  +19572 -0po/fi/labplot2.po
A  +20053 -0po/fr/labplot2.po
A  +18819 -0po/gl/labplot2.po
A  +17394 -0po/hu/labplot2.po
A  +18410 -0po/it/labplot2.po
A  +17325 -0po/ja/labplot2.po
A  +17374 -0po/lt/labplot2.po
A  +17392 -0po/nds/labplot2.po
A  +7245 -0po/nl/docs/labplot2/index.docbook
A  +155  -0po/nl/docs/labplot2/man-labplot2.1.docbook
A  +19168 -0po/nl/labplot2.po
A  +19091 -0po/pl/labplot2.po
A  +17597 -0po/pt/labplot2.po
A  +19591 -0po/pt_BR/labplot2.po
A  +19229 -0po/ru/labplot2.po
A  +19261 -0po/sk/labplot2.po
A  +7262 -0po/sv/docs/labplot2/index.docbook
A  +153  -0po/sv/docs/labplot2/man-labplot2.1.docbook
A  +19145 -0po/sv/labplot2.po
A  +18832 -0po/tr/labplot2.po
A  +---po/uk/docs/labplot2/export_spreadsheet_dialog.png
A  +---po/uk/docs/labplot2/export_worksheet_dialog.png
A  +---po/uk/docs/labplot2/import-dialog.png
A  +7268 -0po/uk/docs/labplot2/index.docbook
A  +---po/uk/docs/labplot2/labplot.png
A  +153  -0po/uk/docs/labplot2/man-labplot2.1.docbook
A  +---po/uk/docs/labplot2/matrix.png
A  +---po/uk/docs/labplot2/matrix_function_values.png
A  +---po/uk/docs/labplot2/pe-context-menu.png
A  +---po/uk/docs/labplot2/project-explorer.png
A  +---po/uk/docs/labplot2/properties.png
A  +---po/uk/docs/labplot2/spreadsheet.png
A  +---po/uk/docs/labplot2/spreadsheet_generate_equidistant_values.png
A  +---po/uk/docs/labplot2/spreadsheet_generate_function_values.png
A  +---po/uk/docs/labplot2/spreadsheet_generate_random_values.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet1.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet2.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet3.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet4.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet5.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet6.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet7.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet8.png
A  +---po/uk/docs/labplot2/tutorial-spreadsheet9.png
A  +---po/uk/docs/labplot2/tutorial-xy-function1.png
A  +---po/uk/docs/labplot2/tutorial-xy-function10.png
A  +---po/uk/docs/labplot2/tutorial-xy-function2.png
A  +---po/uk/docs/labplot2/tutorial-xy-function3.png
A  +---po/uk/docs/labplot2/tutorial-xy-function4.png
A  +---po/uk/docs/labplot2/tutorial-xy-function5.png
A  +---po/uk/docs/labplot2/tutorial-xy-function6.png
A  +---po/uk/docs/labplot2/tutorial-xy-function7.png
A  +---po/uk/docs/labplot2/tutorial-xy-function8.png
A  +---po/uk/docs/labplot2/tutorial-xy-function9.png
A  +---po/uk/docs/labplot2/workbook.png
A  +---po/uk/docs/labplot2/worksheet.png
A  +19284 -0po/uk/labplot2.po
A  +17298 -0po/zh_CN/labplot2.po
A  +17830 -0po/zh_TW/labplot2.po

https://commits.kde.org/labplot/2db4e2c9ceb5aa5beca66012d0a63915ab513db8

D22602: Updated copyright years

[Nikita Melnichenko]

nmel added a project: Krusader.

REPOSITORY
  R167 Krusader

REVISION DETAIL
  https://phabricator.kde.org/D22602

To: nmel, #krusader
Cc: kde-doc-english, gennad, fbampaloukas, nmel, mjanczara, miroslavm, 
skadinna, janlepper, abika, martinkostolny, asensi, gengisdave, andreaska

D22602: Updated copyright years

[Nikita Melnichenko]

nmel created this revision.
nmel added a reviewer: Krusader.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.
nmel requested review of this revision.

TEST PLAN
  Check if any file is missing the update.

REPOSITORY
  R167 Krusader

BRANCH
  copyright-years

REVISION DETAIL
  https://phabricator.kde.org/D22602

AFFECTED FILES
  CREDITS
  doc/advanced-functions.docbook
  doc/archives.docbook
  doc/basic-functions.docbook
  doc/bookmarks.docbook
  doc/checksum.docbook
  doc/compare.docbook
  doc/configuration-files.docbook
  doc/credits-and-license.docbook
  doc/diskusage.docbook
  doc/editors-note.docbook
  doc/faq.docbook
  doc/features.docbook
  doc/glossary.docbook
  doc/help.docbook
  doc/index.docbook
  doc/introduction.docbook
  doc/keyboard-commands.docbook
  doc/konfigurator.docbook
  doc/krusader-tools.docbook
  doc/locate.docbook
  doc/man-krusader.1.docbook
  doc/menu-commands.docbook
  doc/mount.docbook
  doc/mouse-commands.docbook
  doc/occupied-space.docbook
  doc/profiles.docbook
  doc/release-overview.docbook
  doc/remote-connections.docbook
  doc/search.docbook
  doc/splitter.docbook
  doc/synchronizer.docbook
  doc/user-interface.docbook
  doc/useraction-xml.docbook
  doc/useractions.docbook
  doc/vfs.docbook
  doc/viewer-editor.docbook
  iso/iso.cpp
  iso/iso.h
  iso/kiso.cpp
  iso/kiso.h
  iso/kisodirectory.cpp
  iso/kisodirectory.h
  iso/kisofile.cpp
  iso/kisofile.h
  iso/libisofs/bswap.h
  iso/libisofs/el_torito.h
  iso/libisofs/iso_fs.h
  iso/libisofs/isofs.c
  iso/libisofs/isofs.h
  iso/libisofs/rock.h
  iso/qfilehack.cpp
  iso/qfilehack.h
  krArc/krarc.cpp
  krArc/krarc.h
  krArc/krarcbasemanager.cpp
  krArc/krarcbasemanager.h
  krArc/krlinecountingprocess.cpp
  krArc/krlinecountingprocess.h
  krusader/ActionMan/actionman.cpp
  krusader/ActionMan/actionman.h
  krusader/ActionMan/actionproperty.cpp
  krusader/ActionMan/actionproperty.h
  krusader/ActionMan/addplaceholderpopup.cpp
  krusader/ActionMan/addplaceholderpopup.h
  krusader/ActionMan/useractionlistview.cpp
  krusader/ActionMan/useractionlistview.h
  krusader/ActionMan/useractionpage.cpp
  krusader/ActionMan/useractionpage.h
  krusader/Archive/abstractthreadedjob.cpp
  krusader/Archive/abstractthreadedjob.h
  krusader/Archive/kr7zencryptionchecker.cpp
  krusader/Archive/kr7zencryptionchecker.h
  krusader/Archive/krarchandler.cpp
  krusader/Archive/krarchandler.h
  krusader/Archive/packjob.cpp
  krusader/Archive/packjob.h
  krusader/BookMan/kraddbookmarkdlg.cpp
  krusader/BookMan/kraddbookmarkdlg.h
  krusader/BookMan/krbookmark.cpp
  krusader/BookMan/krbookmark.h
  krusader/BookMan/krbookmarkbutton.cpp
  krusader/BookMan/krbookmarkbutton.h
  krusader/BookMan/krbookmarkhandler.cpp
  krusader/BookMan/krbookmarkhandler.h
  krusader/Dialogs/checksumdlg.cpp
  krusader/Dialogs/checksumdlg.h
  krusader/Dialogs/krdialogs.cpp
  krusader/Dialogs/krdialogs.h
  krusader/Dialogs/krmaskchoice.cpp
  krusader/Dialogs/krmaskchoice.h
  krusader/Dialogs/krpleasewait.cpp
  krusader/Dialogs/krpleasewait.h
  krusader/Dialogs/krspecialwidgets.cpp
  krusader/Dialogs/krspecialwidgets.h
  krusader/Dialogs/krspwidgets.cpp
  krusader/Dialogs/krspwidgets.h
  krusader/Dialogs/krsqueezedtextlabel.cpp
  krusader/Dialogs/krsqueezedtextlabel.h
  krusader/Dialogs/kurllistrequester.cpp
  krusader/Dialogs/kurllistrequester.h
  krusader/Dialogs/newftpgui.cpp
  krusader/Dialogs/newftpgui.h
  krusader/Dialogs/packgui.cpp
  krusader/Dialogs/packgui.h
  krusader/Dialogs/packguibase.cpp
  krusader/Dialogs/packguibase.h
  krusader/Dialogs/percentalsplitter.cpp
  krusader/Dialogs/percentalsplitter.h
  krusader/Dialogs/popularurls.cpp
  krusader/Dialogs/popularurls.h
  krusader/DiskUsage/diskusage.cpp
  krusader/DiskUsage/diskusage.h
  krusader/DiskUsage/diskusagegui.cpp
  krusader/DiskUsage/diskusagegui.h
  krusader/DiskUsage/dufilelight.cpp
  krusader/DiskUsage/dufilelight.h
  krusader/DiskUsage/dulines.cpp
  krusader/DiskUsage/dulines.h
  krusader/DiskUsage/dulistview.cpp
  krusader/DiskUsage/dulistview.h
  krusader/DiskUsage/filelightParts/Config.cpp
  krusader/DiskUsage/filelightParts/Config.h
  krusader/DiskUsage/filelightParts/fileTree.cpp
  krusader/DiskUsage/filelightParts/fileTree.h
  krusader/DiskUsage/radialMap/builder.cpp
  krusader/DiskUsage/radialMap/builder.h
  krusader/DiskUsage/radialMap/labels.cpp
  krusader/DiskUsage/radialMap/map.cpp
  krusader/DiskUsage/radialMap/radialMap.h
  krusader/DiskUsage/radialMap/segmentTip.cpp
  krusader/DiskUsage/radialMap/segmentTip.h
  krusader/DiskUsage/radialMap/sincos.h
  krusader/DiskUsage/radialMap/widget.cpp
  krusader/DiskUsage/radialMap/widget.h
  krusader/DiskUsage/radialMap/widgetEvents.cpp
  krusader/FileSystem/defaultfilesystem.cpp
  krusader/FileSystem/defaultfilesystem.h
  krusader/FileSystem/dirlisterinterface.cpp
  krusader/FileSystem/dirlisterinterface.h
  krusader/FileSystem/fileitem.cpp
  krusader/FileSystem/fileitem.h
  krusader/FileSystem/filesystem.cpp