QTimeZone merged for 5.2

[John Layt]

Hi,

I am extremely relived to announce that QTimeZone finally got merged
late late last night, thanks to the efforts of Thiago in fighting the
CI system :-)  Combined with other changes in QDateTime, this should
mean we're free of KDateTime and KTimeZone, albeit with a few caveats.
 I'll be doing a lightning talk at Qt Dev Days on the topic, so I'll
be documenting all the gotcha's people will need to look out for soon.

Thanks also to the work from Martin and Rohan, all the necessary CUPS
features have been merged into Qt 5.2, and a huge thanks to Alex for
taking on QCollator and getting it in.  I owe you all a beer or three
next time I see you :-)

I was less successful on the QLocale front, unfortunately there was
too much resistance from Windows devs to using ICU everywhere, so that
plan has been shelved and we've moved on to Plan C for 5.3.  I'll be
working through what that means for us soon, but I don't see any
immediate problems for us in still switching to QLocale.

Cheers!

John.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: QTimeZone merged for 5.2

[Kevin Ottens]

On Monday 23 September 2013 09:06:33 John Layt wrote:
> Hi,
> 
> I am extremely relived to announce that QTimeZone finally got merged
> late late last night, thanks to the efforts of Thiago in fighting the
> CI system :-)  Combined with other changes in QDateTime, this should
> mean we're free of KDateTime and KTimeZone, albeit with a few caveats.
>  I'll be doing a lightning talk at Qt Dev Days on the topic, so I'll
> be documenting all the gotcha's people will need to look out for soon.
> 
> Thanks also to the work from Martin and Rohan, all the necessary CUPS
> features have been merged into Qt 5.2, and a huge thanks to Alex for
> taking on QCollator and getting it in.  I owe you all a beer or three
> next time I see you :-)
> 
> I was less successful on the QLocale front, unfortunately there was
> too much resistance from Windows devs to using ICU everywhere, so that
> plan has been shelved and we've moved on to Plan C for 5.3.  I'll be
> working through what that means for us soon, but I don't see any
> immediate problems for us in still switching to QLocale.

Yay!

OK, let's attempt to move KLocale, KDateTime and friends to kde4support now. 
With some luck we'll be able to completely get rid of KDE4Attic before 
release.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Frameworks Overview

[Cornelius Schumacher]

On Thursday 19 September 2013 Sebastian Kügler wrote:
> 
> http://community.kde.org/Frameworks/Overview

I have put the data on Inqlude (see http://inqlude.org/edge.html).

It would be nice, if we could improve the presentation of the different 
libraries along with the code. The goal of Inqlude is to make them easily 
accessible not only to us, but also to Qt developers who don't necessarily 
know anything about KDE or might have (more or less founded) objections 
against using KDE libraries. To reach this we'll need to present KF5 in a bit 
more independent way, and make sure that each library can stand on its own.

-- 
Cornelius Schumacher 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109551: port KPtyProcess to QProcess

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109551/
---

(Updated Sept. 23, 2013, 8:31 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, kdelibs, David Faure, and Oswald Buddenhagen.


Description
---

Just a simple port of KPtyProcess away from using KProcess.


Diffs
-

  kpty/kptyprocess.h 5e0df96 
  kpty/kptyprocess.cpp 015a58c 
  kpty/tests/kptyprocesstest.cpp 04990a0 

Diff: http://git.reviewboard.kde.org/r/109551/diff/


Testing
---

builds and tests pass.


Thanks,

Martin Tobias Holmedahl Sandsmark

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 107696: kcalendarsystem: Simplify weekday naming a lot.

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107696/
---

(Updated Sept. 23, 2013, 8:31 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, David Faure and John Layt.


Description
---

Weekday names depend on *language*, not calendar system. The usual ki18nc can 
handle it just fine, so consolidate it all to a single function.

Note: Before this patch I'm moving some functions to a new file 
"kcalendarsystemweek.cpp" in order move to out of the way of regular calendar 
system code. That commit changes no code whatsoever, so don't really need a 
review.


Diffs
-

  kdecore/date/kcalendarsystem.h c121bb6 
  kdecore/date/kcalendarsystem.cpp 35877b7 
  kdecore/date/kcalendarsystemcoptic.cpp 86d35a9 
  kdecore/date/kcalendarsystemcoptic_p.h 5287271 
  kdecore/date/kcalendarsystemcopticprivate_p.h 8ceb5ad 
  kdecore/date/kcalendarsystemethiopian.cpp 9bfc41f 
  kdecore/date/kcalendarsystemethiopian_p.h 4f8119e 
  kdecore/date/kcalendarsystemgregorian.cpp 18b7aef 
  kdecore/date/kcalendarsystemgregorian_p.h 8890643 
  kdecore/date/kcalendarsystemgregorianprivate_p.h 1208fe9 
  kdecore/date/kcalendarsystemhebrew.cpp 660cb6d 
  kdecore/date/kcalendarsystemhebrew_p.h 132e21f 
  kdecore/date/kcalendarsystemindiannational.cpp 7c4fe03 
  kdecore/date/kcalendarsystemindiannational_p.h 499d2fa 
  kdecore/date/kcalendarsystemislamiccivil.cpp abca3b5 
  kdecore/date/kcalendarsystemislamiccivil_p.h 6d4682f 
  kdecore/date/kcalendarsystemjalali.cpp 331f2b3 
  kdecore/date/kcalendarsystemjalali_p.h c88d304 
  kdecore/date/kcalendarsystemjapanese.cpp d8a870b 
  kdecore/date/kcalendarsystemjapanese_p.h 09bb4f4 
  kdecore/date/kcalendarsystemjulian.cpp d1b5864 
  kdecore/date/kcalendarsystemjulian_p.h 5940c27 
  kdecore/date/kcalendarsystemminguo.cpp 165c86f 
  kdecore/date/kcalendarsystemminguo_p.h 0a3b5d7 
  kdecore/date/kcalendarsystemprivate_p.h 43b486f 
  kdecore/date/kcalendarsystemweek.cpp PRE-CREATION 
  kdecore/tests/kcalendartest.h ea5b836 
  kdecore/tests/kcalendartest.cpp 5c4d438 

Diff: http://git.reviewboard.kde.org/r/107696/diff/


Testing
---

`make test` shows no regressions


Thanks,

Jon Severinsson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112032/#review40503
---


Any news about that patch? Hasn't seen activity in a while, it probably doesn't 
apply cleanly anymore.

- Kevin Ottens


On Aug. 12, 2013, 4:07 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112032/
> ---
> 
> (Updated Aug. 12, 2013, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax
> 
> Conversion was performed using a clang based tool I wrote
> (https://github.com/a-richardson/convert2qt5signalslot).
> Manual changes required were mostly reverting to the old syntax for
> Q_PRIVATE_SLOTS since not all of them use the "_k_" function name
> prefix. Also one case where disconnect was used (kcursor.cpp).
> 
> Command to perform this was:
> find tier1/kwidgetsaddons/ -iname "*.cpp" -print0 | xargs -0 
> convert2qt5signalslot -skip-prefix=_k_ -p ~/devel/build/kdelibsprint0 | xargs 
> -0 convert2qt5signalslot -skip-prefix=_k_ -p ~/devel/build/kdelibs
> 
> 
> Diffs
> -
> 
>   tier1/kwidgetsaddons/src/kacceleratormanager.cpp 
> f50057e8899b30ea2a5dfbe430e82a090299addb 
>   tier1/kwidgetsaddons/src/kactionmenu.cpp 
> dd1dce144aa028af41fb073a5d3636f4c9e8901b 
>   tier1/kwidgetsaddons/src/kactionselector.cpp 
> 879bb4918d85ee8360e72fab9b5750196c29ad6f 
>   tier1/kwidgetsaddons/src/kassistantdialog.cpp 
> 81d3828e48df6e8e09f91ce8d2056cc8294411ea 
>   tier1/kwidgetsaddons/src/kcursor.cpp 
> 9b0fe01358650a5a82cb9f9cd50edf9506034d4c 
>   tier1/kwidgetsaddons/src/keditlistwidget.cpp 
> 23637a5b60f3582097fb136dfa9adedb44e157e9 
>   tier1/kwidgetsaddons/src/kmessagebox.cpp 
> 1fff72f1df4703b0893396c097b05ebefebbc362 
>   tier1/kwidgetsaddons/src/kmessagewidget.cpp 
> a4f9975297a0177dfd5bf50ee480b240d60c1d47 
>   tier1/kwidgetsaddons/src/kpageview_p.cpp 
> 4e236f11dea25e280f5b5bf0040424cdb5e934a6 
>   tier1/kwidgetsaddons/src/kpagewidget.cpp 
> 2931623c5a176f1013d5dc15e59df0c6a7a26fb7 
>   tier1/kwidgetsaddons/src/kpassivepopup.cpp 
> 663f63af413b7660c9c1b21af3e3ae4d7c424bbe 
>   tier1/kwidgetsaddons/src/kpassworddialog.cpp 
> dfab3e9ead7d48b8941e4a44d17565c2ea7d4ddb 
>   tier1/kwidgetsaddons/src/kpixmapregionselectordialog.cpp 
> 76a52b56190079510e99bd056f7602499f015399 
>   tier1/kwidgetsaddons/src/kselectaction.cpp 
> b388df94baa042e8230f2795f35dd378117c6ab6 
>   tier1/kwidgetsaddons/src/ktoggleaction.cpp 
> 79616dbb37a18b08e9f8a316489cbc8aed8242ba 
>   tier1/kwidgetsaddons/src/ktoolbarpopupaction.cpp 
> af1fc2a9470444ba035d8babd9d6aad6a7c05e67 
>   tier1/kwidgetsaddons/tests/kassistantdialogtest.cpp 
> f6be3ef4376dff4f57ac62442e6c55e3a26e12ea 
>   tier1/kwidgetsaddons/tests/kcolorcombotest.cpp 
> 825f3a8ab273cbb43c03001d9eb158ad9211e034 
>   tier1/kwidgetsaddons/tests/keditlistwidgettest.cpp 
> 0a0a46b3139eab6441e685e12bd86ec4c8ac5f54 
>   tier1/kwidgetsaddons/tests/kledtest.cpp 
> ee45ab3ab82129f03c8b4a3ce7bda69d0c060dc0 
>   tier1/kwidgetsaddons/tests/kmessagewidgettest.cpp 
> 2d8ab453ebaa736fa7dbf04b10d80ca89ca8bd1b 
>   tier1/kwidgetsaddons/tests/kpagewidgettest.cpp 
> 3a10f73a8c481302863cbff52a17a56e167bc2f1 
>   tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 
> 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 
>   tier1/kwidgetsaddons/tests/kselectactiontest.cpp 
> f57f6c53098093d0056a1ba4ccfe9fb49338d186 
>   tier1/kwidgetsaddons/tests/ktoolbarlabelactiontest.cpp 
> 8e8cdf06cdaaa684f4659f63fec87d304837746a 
> 
> Diff: http://git.reviewboard.kde.org/r/112032/diff/
> 
> 
> Testing
> ---
> 
> Compiles and autotests work
> 
> 
> File Attachments
> 
> 
> Manual changes performed after tool run
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/08/12/manualChanges_1.diff
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 105863: Don't lose the original CMAKE_MODULE_PATH

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105863/
---

(Updated Sept. 23, 2013, 9:12 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Patrick Spendrin.


Description
---

Keep the paths already in CMAKE_MODULE_PATH when adding ECM_MODULE_PATH and 
other search-paths into it.


Diffs
-

  CMakeLists.txt f20069c 
  tier2/kconfig/CMakeLists.txt c4b2cf6 

Diff: http://git.reviewboard.kde.org/r/105863/diff/


Testing
---

Before this adjustment it was not possible to proceed with the build due to 
missing Find*.cmake (e.g.: FindKDEWin.cmake) files.


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108845/#review40505
---


Any reason why this patch isn't committed yet? Please do so ASAP.

- Kevin Ottens


On May 22, 2013, 3:31 p.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108845/
> ---
> 
> (Updated May 22, 2013, 3:31 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Patrick von Reth.
> 
> 
> Description
> ---
> 
> This change implements cpu feature checks for MSVC. While at it, I added 
> support SSSE3 and SSE4.2 to the InstructionSets. I took the new values from 
> http://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits .
> 
> 
> Diffs
> -
> 
>   tier1/solid/src/solid/processor.h ce4f0e1 
>   tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 
> 
> Diff: http://git.reviewboard.kde.org/r/108845/diff/
> 
> 
> Testing
> ---
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112367: Include the icon's theme in the cache key

[Kevin Ottens]

> On Aug. 31, 2013, 7:11 a.m., David Faure wrote:
> > I disagree. Making things slow to cover a really really corner case (mixing 
> > kde4 and kde5), while the solution already exists (clearing the cache when 
> > switching icon themes), doesn't seem very sensible to me.
> > 
> > The point is really that you can only use one icon theme at a time.
> 
> Àlex Fiestas wrote:
> While it is a corner case I think we should find a solution to make this 
> more solid.
> Perhaps we could set the theme name in the cache, and then check if it 
> has changed, if so remove cache.
> 
> What is a bug imho is that theme can be changed without the cache getting 
> cleaned somehow, corner case if you want but a bug.
> 
> David Faure wrote:
> There's a *lot* of things that break if you run two separate DBus 
> sessions and do things in one session and expect the other session to react. 
> IMHO it's actually a feature that this isn't the case ;)
> 
> But indeed we get into bugs when we have such "broken dbus communication" 
> because of using two sessions, but these two sessions share some files, e.g. 
> config files. Because then they see the changed files at some point, but 
> didn't get change notification.
> 
> However fixing all such occurences is a HUGE amount of work, and it's not 
> worth it IMHO.
> 
> But first, am I right that this is the case you're having? Different dbus 
> sessions between your kde4 and kde5 code, but shared config files? (or 
> symlinks, if the chosen icon theme is a symlink - I forgot how that works 
> exactly)
> 
> Àlex Fiestas wrote:
> I think it is much simpler than that:
> -Theme is changed but cache is not nuked, we get wrong icons.
> 
> My case is, KIconLoader should realize that the theme has changed and 
> nuke it without any external help.
> 
> What is happening is, that KSharedDataCache::deleteCache("icon-cache"); 
> is removing the cache from KDE4 (in /tmp/... I guess) instead of using the 
> new standard paths which is what it should do.

Are you sure about that? It uses QStandardPaths internally...


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112367/#review38986
---


On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112367/
> ---
> 
> (Updated Aug. 29, 2013, 8 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Michael Pyne.
> 
> 
> Description
> ---
> 
> If we make no difference between an icon from oxygen and an icon from
> gnome, when we change themes for example from oxygen to gnome, the
> icon will be found in the cache and won't be upgraded.
> 
> 
> Diffs
> -
> 
>   kdeui/icons/kiconloader.cpp ce6aeea 
> 
> Diff: http://git.reviewboard.kde.org/r/112367/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Frameworks Overview

[Sebastian Kügler]

Hey,

On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote:
> On Thursday 19 September 2013 Sebastian Kügler wrote:
> > 
> >
> > http://community.kde.org/Frameworks/Overview
> 
> I have put the data on Inqlude (see http://inqlude.org/edge.html).

Thanks. One issue though, we're duplicating incomplete information that is in 
flux. (For example, I know of at least one framework that has been added to 
tier2 (I think) since last week. The information will need constant updating 
for a few more months. Having it in to places doesn't make that easier.

Can I update the info on inqlude.org somehow, so we can ditch the wiki 
version?

> It would be nice, if we could improve the presentation of the different 
> libraries along with the code. The goal of Inqlude is to make them easily 
> accessible not only to us, but also to Qt developers who don't necessarily 
> know anything about KDE or might have (more or less founded) objections 
> against using KDE libraries. To reach this we'll need to present KF5 in a
> bit  more independent way, and make sure that each library can stand on its
> own.

Technically, this is the current focus. We're splitting kdelibs.

As to communication, it probably needs a bit of boilerplate. (Which the bits I 
wrote don't contain purposefully.) Otherwise, you're right, we need to work on 
the presentation side here.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112840: Port from kde4_add_plugin to add_library

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112840/
---

(Updated Sept. 23, 2013, 9:56 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.


Description
---

After the recent changes we can safely change kde4_add_plugin -> add_library


Diffs
-

  KDE5PORTING.html 65fcf6e 
  interfaces/kmediaplayer/kfileaudiopreview/CMakeLists.txt b32b816 
  kdewidgets/CMakeLists.txt b75f810 
  kfile/CMakeLists.txt 0475bf2 
  khtml/CMakeLists.txt bbaa4bb 
  khtml/java/CMakeLists.txt a9e5abf 
  khtml/kmultipart/CMakeLists.txt aa62156 
  kio/kssl/kcm/CMakeLists.txt 88f4479 
  kio/misc/kpac/CMakeLists.txt 8753923 
  kioslave/help/CMakeLists.txt 4a5f6ae 
  kioslave/http/CMakeLists.txt faf4b5a 
  kioslave/http/kcookiejar/CMakeLists.txt 62aa05e 
  kparts/tests/CMakeLists.txt 0e9b2b2 
  kross/kjs/CMakeLists.txt 22dec92 
  kross/modules/CMakeLists.txt fa5cc10 
  kross/qts/CMakeLists.txt d575c6d 
  staging/kde4support/src/kioslave/metainfo/CMakeLists.txt c96a3f6 
  staging/kemoticons/src/providers/adium/CMakeLists.txt 2a937f5 
  staging/kemoticons/src/providers/kde/CMakeLists.txt 02254f0 
  staging/kemoticons/src/providers/pidgin/CMakeLists.txt f98e137 
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt 54975e2 
  staging/kio/src/kssld/CMakeLists.txt e64f491 
  staging/kio/src/widgets/thumbcreator.h f18cd84 

Diff: http://git.reviewboard.kde.org/r/112840/diff/


Testing
---

Builds, nothing seem to have changed.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112840: Port from kde4_add_plugin to add_library

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112840/#review40509
---


This review has been submitted with commit 
90d8df909ab42b6caeb9dbd5dd0a812b062b998b by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 20, 2013, 3:06 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112840/
> ---
> 
> (Updated Sept. 20, 2013, 3:06 p.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
> 
> 
> Description
> ---
> 
> After the recent changes we can safely change kde4_add_plugin -> add_library
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html 65fcf6e 
>   interfaces/kmediaplayer/kfileaudiopreview/CMakeLists.txt b32b816 
>   kdewidgets/CMakeLists.txt b75f810 
>   kfile/CMakeLists.txt 0475bf2 
>   khtml/CMakeLists.txt bbaa4bb 
>   khtml/java/CMakeLists.txt a9e5abf 
>   khtml/kmultipart/CMakeLists.txt aa62156 
>   kio/kssl/kcm/CMakeLists.txt 88f4479 
>   kio/misc/kpac/CMakeLists.txt 8753923 
>   kioslave/help/CMakeLists.txt 4a5f6ae 
>   kioslave/http/CMakeLists.txt faf4b5a 
>   kioslave/http/kcookiejar/CMakeLists.txt 62aa05e 
>   kparts/tests/CMakeLists.txt 0e9b2b2 
>   kross/kjs/CMakeLists.txt 22dec92 
>   kross/modules/CMakeLists.txt fa5cc10 
>   kross/qts/CMakeLists.txt d575c6d 
>   staging/kde4support/src/kioslave/metainfo/CMakeLists.txt c96a3f6 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt 2a937f5 
>   staging/kemoticons/src/providers/kde/CMakeLists.txt 02254f0 
>   staging/kemoticons/src/providers/pidgin/CMakeLists.txt f98e137 
>   staging/kemoticons/src/providers/xmpp/CMakeLists.txt 54975e2 
>   staging/kio/src/kssld/CMakeLists.txt e64f491 
>   staging/kio/src/widgets/thumbcreator.h f18cd84 
> 
> Diff: http://git.reviewboard.kde.org/r/112840/diff/
> 
> 
> Testing
> ---
> 
> Builds, nothing seem to have changed.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 #764

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/#review40510
---


Tested the patch in my tree, works for caps lock too.

Now it highlights a dependency problem... We don't want a dependency on 
QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your 
proposed KX11Extras?


tier1/kguiaddons/CMakeLists.txt


This dependency is unwanted in kguiaddons.



tier1/kguiaddons/CMakeLists.txt


ditto.



tier1/kguiaddons/CMakeLists.txt


ditto.


- Kevin Ottens


On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112443/
> ---
> 
> (Updated Sept. 4, 2013, 6:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Ported to native event filter and to xcb-xkb by reimplementing the events. 
> Most parts are kept on xlib though as we don't have xkb.h to get proper 
> defines.
> 
> 
> Diffs
> -
> 
>   tier1/kguiaddons/CMakeLists.txt 3124c4d 
>   tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112443/diff/
> 
> 
> Testing
> ---
> 
> used kmodifierkeyinfotest application. Would appreciate if someone else could 
> run it as I don't have a caps lock.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112311/#review40511
---

Ship it!


Looks good. Any reason why it's not pushed yet? (got the first ship it two 
weeks ago).

- Kevin Ottens


On Sept. 2, 2013, 3:13 p.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112311/
> ---
> 
> (Updated Sept. 2, 2013, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Title says it all
> 
> 
> Diffs
> -
> 
>   kio/kio/kmimetypechooser.cpp 616b033 
> 
> Diff: http://git.reviewboard.kde.org/r/112311/diff/
> 
> 
> Testing
> ---
> 
> Tested by running kmimetypechoosertest, the behavior is same with or without 
> this patch.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112598/#review40512
---

Ship it!


Ship It!

- Kevin Ottens


On Sept. 9, 2013, 6:51 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112598/
> ---
> 
> (Updated Sept. 9, 2013, 6:51 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> The behavior to get a memory-only KConfig if file name is empty and the 
> SimpleConfig open flag is used got lost by always setting the file name to 
> the mainConfigName.
> 
> 
> Diffs
> -
> 
>   tier1/kconfig/src/core/ksharedconfig.cpp 3b53e32 
> 
> Diff: http://git.reviewboard.kde.org/r/112598/diff/
> 
> 
> Testing
> ---
> 
> a failing KWin unit test doesn't fail any more.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111938: Allow installing both qca2 and qca3

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111938/
---

(Updated Sept. 23, 2013, 10:24 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Ivan Romanov.


Description
---

Use qt5 suffix for files by default when installing a Qt5 version of QCA

This way coinstallation of Qt4 and Qt5 based QCA is possible by default


Diffs
-

  CMakeLists.txt 8cff977 
  src/CMakeLists.txt 037c9ff 
  src/config-qca.h.cmake PRE-CREATION 
  src/qca_plugin.cpp ad810b9 

Diff: http://git.reviewboard.kde.org/r/111938/diff/


Testing
---

Compiled and installed.
creating a Qt5 package for openSuSE works fine


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112757: kwindowsystem - remove unused dependencies

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112757/#review40513
---

Ship it!


Ship It!

- Kevin Ottens


On Sept. 16, 2013, 2:15 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112757/
> ---
> 
> (Updated Sept. 16, 2013, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Apart from a stray include, I did not find any reference to QtDBus or 
> QtNetwork. Also, QtTest is already specified in autotests/, so no need to 
> require it in the root.
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/CMakeLists.txt 984db7fc814bb4c2342835f9b7034055f06f93ca 
>   tier1/kwindowsystem/autotests/CMakeLists.txt 
> a1a7066f24aabb4e24b3920a462845e92a7ec5e4 
>   tier1/kwindowsystem/src/kwindowinfo_mac.cpp 
> 1bf0876435a6ebd48db145635a49f89199de848f 
>   tier1/kwindowsystem/src/kwindowinfo_x11.cpp 
> f382e9c0c580ec209bd75994fedd5f20584af5e2 
>   tier1/kwindowsystem/src/kwindowsystem_mac.cpp 
> 6133a0bf3c4ca5d000cb3499f486e126d60c0873 
> 
> Diff: http://git.reviewboard.kde.org/r/112757/diff/
> 
> 
> Testing
> ---
> 
> Builds and tests pass with QtDBus and QtNetwork not installed.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112755/#review40515
---

Ship it!


Not that I'm really qualified with xcb code, but it looks ok to me.

- Kevin Ottens


On Sept. 17, 2013, 5:42 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112755/
> ---
> 
> (Updated Sept. 17, 2013, 5:42 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Implements the createPixmapFromHandle by getting the image for the pixmaps 
> and using it as either the Pixmap or the bitmap mask.
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/src/kxutils.cpp 33bd678 
>   tier1/kwindowsystem/src/kxutils_p.h 84d639b 
> 
> Diff: http://git.reviewboard.kde.org/r/112755/diff/
> 
> 
> Testing
> ---
> 
> Adjusted KWin to take this codepath and say thanks to Iceweasel for having a 
> mask
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112792: Move itemviews to tier2

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112792/#review40516
---


Please update aiming at tier 1 since it's apparently possible now.

- Kevin Ottens


On Sept. 18, 2013, 2:50 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112792/
> ---
> 
> (Updated Sept. 18, 2013, 2:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move itemviews to tier2. Was waiting for the QCollator request (  
> https://git.reviewboard.kde.org/r/112717/ ) to go in before so that itemviews 
> could go to tier1, but it seems it is not going in, so let's go tier2 for now.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 7826b07 
>   staging/itemviews/CMakeLists.txt  
>   staging/itemviews/ItemViewsConfig.cmake.in  
>   staging/itemviews/autotests/CMakeLists.txt  
>   staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   staging/itemviews/src/CMakeLists.txt  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   staging/itemviews/src/kcategorizedview.h  
>   staging/itemviews/src/kcategorizedview.cpp  
>   staging/itemviews/src/kcategorizedview_p.h  
>   staging/itemviews/src/kcategorydrawer.h  
>   staging/itemviews/src/kcategorydrawer.cpp  
>   staging/itemviews/src/kextendableitemdelegate.h  
>   staging/itemviews/src/kextendableitemdelegate.cpp  
>   staging/itemviews/src/kfilterproxysearchline.h  
>   staging/itemviews/src/kfilterproxysearchline.cpp  
>   staging/itemviews/src/klistwidgetsearchline.h  
>   staging/itemviews/src/klistwidgetsearchline.cpp  
>   staging/itemviews/src/ktreewidgetsearchline.h  
>   staging/itemviews/src/ktreewidgetsearchline.cpp  
>   staging/itemviews/src/kwidgetitemdelegate.h  
>   staging/itemviews/src/kwidgetitemdelegate.cpp  
>   staging/itemviews/src/kwidgetitemdelegate_p.h  
>   staging/itemviews/src/kwidgetitemdelegatepool.cpp  
>   staging/itemviews/src/kwidgetitemdelegatepool_p.h  
>   staging/itemviews/tests/CMakeLists.txt  
>   staging/itemviews/tests/kcategorizedviewtest.cpp  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.h  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   superbuild/CMakeLists.txt c297be6 
>   tier2/CMakeLists.txt 6c98a7d 
> 
> Diff: http://git.reviewboard.kde.org/r/112792/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and standalone. The single auto test passes, manual 
> tests are running correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

[Martin Gräßlin]

> On Sept. 23, 2013, 12:27 p.m., Kevin Ottens wrote:
> > Not that I'm really qualified with xcb code, but it looks ok to me.

no, no. The issues mentioned by Fredrik should be fixed.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112755/#review40515
---


On Sept. 17, 2013, 7:42 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112755/
> ---
> 
> (Updated Sept. 17, 2013, 7:42 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Implements the createPixmapFromHandle by getting the image for the pixmaps 
> and using it as either the Pixmap or the bitmap mask.
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/src/kxutils.cpp 33bd678 
>   tier1/kwindowsystem/src/kxutils_p.h 84d639b 
> 
> Diff: http://git.reviewboard.kde.org/r/112755/diff/
> 
> 
> Testing
> ---
> 
> Adjusted KWin to take this codepath and say thanks to Iceweasel for having a 
> mask
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review40518
---


I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least 
partly.

- Kevin Ottens


On Sept. 17, 2013, 7:56 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112785/
> ---
> 
> (Updated Sept. 17, 2013, 7:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Alexander Neundorf.
> 
> 
> Description
> ---
> 
> It builds and installs, but doesn't seem to be usable from within kdelibs, 
> i.e. ki18n_wrap_ui in knewstuff/src/CMakeLists.txt fails with this. I suspect 
> one more thing is needed to make it work from within kdelibs builds.
> 
> 
> Diffs
> -
> 
>   tier2/ki18n/CMakeLists.txt d0ed448 
>   tier2/ki18n/KI18nConfig.cmake.in 18b6e2f 
>   tier2/ki18n/cmake/KI18NMacros.cmake PRE-CREATION 
>   tier2/ki18n/cmake/ki18nuic.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112785/diff/
> 
> 
> Testing
> ---
> 
> Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112811: Make kguiaddons build standalone

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112811/#review40519
---

Ship it!


Ship It!

- Kevin Ottens


On Sept. 19, 2013, 11:28 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112811/
> ---
> 
> (Updated Sept. 19, 2013, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Description
> ---
> 
> Add missing include() calls and mark it as tier1 in superbuild.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt c297be6 
>   tier1/kguiaddons/CMakeLists.txt 46877bd 
> 
> Diff: http://git.reviewboard.kde.org/r/112811/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and using superbuild.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review40520
---


Hmmm, why not bring it back in kde4support? We're talking about just reviving 
it temporarily for a couple of users who will ditch it as QCollator matures, 
right?

- Kevin Ottens


On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112797/
> ---
> 
> (Updated Sept. 18, 2013, 4:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.
> 
> 
> Description
> ---
> 
> Apparently there's people who still want to have it. Leave it in KCoreAddons 
> for the moment, until we decide that it can be replaced for good by QCollator.
> 
> 
> Diffs
> -
> 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 
> 
> Diff: http://git.reviewboard.kde.org/r/112797/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112814: kjs - remove unused dependencies

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112814/#review40521
---

Ship it!


Ship It!

- Kevin Ottens


On Sept. 19, 2013, 12:35 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112814/
> ---
> 
> (Updated Sept. 19, 2013, 12:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> QtWidgets is not required, and move QtTest to autotests.
> 
> 
> Diffs
> -
> 
>   tier1/kjs/CMakeLists.txt f67846499fcd08cbf69cab4c29fc625af607bd37 
>   tier1/kjs/autotests/CMakeLists.txt 2c8089fb432d1dafc0dcbaa9ff917d0696c00bf3 
> 
> Diff: http://git.reviewboard.kde.org/r/112814/diff/
> 
> 
> Testing
> ---
> 
> With QtWidgets not installed, build and tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/#review40522
---

Ship it!


Looks good.

- Kevin Ottens


On Sept. 19, 2013, 4:44 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112829/
> ---
> 
> (Updated Sept. 19, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move xmlgui to tier3, done all the checks.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 2a31994 
>   staging/xmlgui/CMakeLists.txt  
>   staging/xmlgui/TODO.xmlgui  
>   staging/xmlgui/XmlGuiConfig.cmake.in  
>   staging/xmlgui/autotests/CMakeLists.txt  
>   staging/xmlgui/autotests/kactioncategorytest.h  
>   staging/xmlgui/autotests/kactioncategorytest.cpp  
>   staging/xmlgui/autotests/kactioncollectiontest.h  
>   staging/xmlgui/autotests/kactioncollectiontest.cpp  
>   staging/xmlgui/autotests/kglobalshortcuttest.h  
>   staging/xmlgui/autotests/kglobalshortcuttest.cpp  
>   staging/xmlgui/autotests/kmainwindow_unittest.h  
>   staging/xmlgui/autotests/kmainwindow_unittest.cpp  
>   staging/xmlgui/autotests/ktoolbar_unittest.cpp  
>   staging/xmlgui/autotests/kxmlgui_unittest.h  
>   staging/xmlgui/autotests/kxmlgui_unittest.cpp  
>   staging/xmlgui/autotests/testguiclient.h  
>   staging/xmlgui/autotests/testxmlguiwindow.h  
>   staging/xmlgui/make_kdepackages.sh  
>   staging/xmlgui/make_kdepackages_updated.py  
>   staging/xmlgui/src/CMakeLists.txt b1d7d17 
>   staging/xmlgui/src/README  
>   staging/xmlgui/src/TODO  
>   staging/xmlgui/src/aboutkde.png  
>   staging/xmlgui/src/config-xmlgui.h.cmake  
>   staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake  
>   staging/xmlgui/src/kaboutapplicationdialog.h  
>   staging/xmlgui/src/kaboutapplicationdialog.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp  
>   staging/xmlgui/src/kaboutkdedialog_p.h  
>   staging/xmlgui/src/kaboutkdedialog_p.cpp  
>   staging/xmlgui/src/kactioncategory.h  
>   staging/xmlgui/src/kactioncategory.cpp  
>   staging/xmlgui/src/kactioncollection.h  
>   staging/xmlgui/src/kactioncollection.cpp  
>   staging/xmlgui/src/kactionconflictdetector.cpp  
>   staging/xmlgui/src/kbugreport.h  
>   staging/xmlgui/src/kbugreport.cpp  
>   staging/xmlgui/src/kcheckaccelerators.h  
>   staging/xmlgui/src/kcheckaccelerators.cpp  
>   staging/xmlgui/src/kdepackages.h  
>   staging/xmlgui/src/kedittoolbar.h  
>   staging/xmlgui/src/kedittoolbar.cpp  
>   staging/xmlgui/src/kedittoolbar_p.h  
>   staging/xmlgui/src/kglobalaccel.h  
>   staging/xmlgui/src/kglobalaccel.cpp  
>   staging/xmlgui/src/kglobalaccel_p.h  
>   staging/xmlgui/src/kglobalshortcutinfo.h  
>   staging/xmlgui/src/kglobalshortcutinfo.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_p.h  
>   staging/xmlgui/src/khelpclient.h  
>   staging/xmlgui/src/khelpclient.cpp  
>   staging/xmlgui/src/khelpmenu.h  
>   staging/xmlgui/src/khelpmenu.cpp  
>   staging/xmlgui/src/kkeysequencewidget.h  
>   staging/xmlgui/src/kkeysequencewidget.cpp  
>   staging/xmlgui/src/kkeysequencewidget_p.h  
>   staging/xmlgui/src/kmainwindow.h  
>   staging/xmlgui/src/kmainwindow.cpp  
>   staging/xmlgui/src/kmainwindow_p.h  
>   staging/xmlgui/src/kmainwindowiface.cpp  
>   staging/xmlgui/src/kmainwindowiface_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.cpp  
>   staging/xmlgui/src/kpartgui.dtd  
>   staging/xmlgui/src/kshortcuteditwidget.cpp  
>   staging/xmlgui/src/kshortcutschemeseditor.cpp  
>   staging/xmlgui/src/kshortcutschemeshelper.cpp  
>   staging/xmlgui/src/kshortcutschemeshelper_p.h  
>   staging/xmlgui/src/kshortcutsdialog.h  
>   staging/xmlgui/src/kshortcutsdialog.cpp  
>   staging/xmlgui/src/kshortcutsdialog.ui  
>   staging/xmlgui/src/kshortcutsdialog_p.h  
>   staging/xmlgui/src/kshortcutseditor.h  
>   staging/xmlgui/src/kshortcutseditor.cpp  
>   staging/xmlgui/src/kshortcutseditordelegate.cpp  
>   staging/xmlgui/src/kshortcutseditoritem.cpp  
>   staging/xmlgui/src/kshortcutwidget.h  
>   staging/xmlgui/src/kshortcutwidget.cpp  
>   staging/xmlgui/src/kshortcutwidget.ui  
>   staging/xmlgui/src/kswitchlanguagedialog_p.h  
>   staging/xmlgui/src/kswitchlanguagedialog_p.cpp  
>   staging/xmlgui/src/ktoggletoolbaraction.h  
>   staging/xmlgui/src/ktoggletoolbaraction.cpp  
>  

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review40523
---



modules/ECMAddUnitTest.cmake


I agree, it's about "automated" (vs "manual") tests here. We've no way when 
writing this macro to know if the user will make an automated unit test or 
integration test or...



modules/ECMAddUnitTest.cmake


I'd argue that "multiple_" isn't necessary here as we're using a plural 
form already.


- Kevin Ottens


On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> ---
> 
> (Updated Sept. 19, 2013, 3:57 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Description
> ---
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -
> 
>   modules/ECMAddUnitTest.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

[Martin Gräßlin]

> On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote:
> > Tested the patch in my tree, works for caps lock too.
> > 
> > Now it highlights a dependency problem... We don't want a dependency on 
> > QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to 
> > your proposed KX11Extras?

Then I would suggest to move this class to KWindowSystem for the moment. For 
the module KX11Extras I still need some code changes first (for some reason 
netwm is using KWindowSystem - it's wrong IMHO and needs fixing)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/#review40510
---


On Sept. 4, 2013, 8:37 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112443/
> ---
> 
> (Updated Sept. 4, 2013, 8:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Ported to native event filter and to xcb-xkb by reimplementing the events. 
> Most parts are kept on xlib though as we don't have xkb.h to get proper 
> defines.
> 
> 
> Diffs
> -
> 
>   tier1/kguiaddons/CMakeLists.txt 3124c4d 
>   tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112443/diff/
> 
> 
> Testing
> ---
> 
> used kmodifierkeyinfotest application. Would appreciate if someone else could 
> run it as I don't have a caps lock.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112830: Start splitting KParts

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112830/#review40526
---



khtml/java/CMakeLists.txt


Does it really need the kio lib? Or it could use one of the 
KIOCore/Gui/Widgets splitted libs?



khtml/java/tests/CMakeLists.txt


ditto.


- Kevin Ottens


On Sept. 19, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112830/
> ---
> 
> (Updated Sept. 19, 2013, 6:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Started reorganizing KParts, everything stopped compiling, that fixes it too.
> 
> Make string to QStrign casts explicit.
> KParts was exporting the "kio" linking, don't do it anymore.
> 
> 
> Diffs
> -
> 
>   interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
>   interfaces/terminal/example/CMakeLists.txt 57201fa 
>   kdewebkit/CMakeLists.txt cdc5835 
>   khtml/CMakeLists.txt bbaa4bb 
>   khtml/html/ksslkeygen.cpp a3118da 
>   khtml/html/ksslkeygen_p.h 95c1a71 
>   khtml/java/CMakeLists.txt a9e5abf 
>   khtml/java/tests/CMakeLists.txt 59bef3a 
>   khtml/kmultipart/CMakeLists.txt aa62156 
>   khtml/tests/CMakeLists.txt 99b3bdd 
>   kio/CMakeLists.txt aedded2 
>   kparts/CMakeLists.txt 6ab9391 
>   kparts/browserrun.h e758241 
>   kparts/tests/CMakeLists.txt 0e9b2b2 
>   kparts/tests/normalktm.cpp dcc3a5e 
>   kparts/tests/notepad.cpp b7c3778 
>   kparts/tests/openorsavequestion.cpp c080cfc 
>   kparts/tests/openorsavequestion_unittest.cpp 72285b1 
>   kparts/tests/parts.cpp ee198e3 
>   kparts/tests/parttest.h  
>   kparts/tests/parttest.cpp 828666f 
>   kparts/tests/partviewer.cpp eeeb63a 
>   kparts/tests/plugin_spellcheck.cpp 073144b 
>   kparts/tests/testmainwindow.cpp fd77af0 
>   kross/modules/CMakeLists.txt fa5cc10 
>   kross/ui/CMakeLists.txt 9e7806d 
>   kutils/CMakeLists.txt 0cb281d 
>   staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b 
> 
> Diff: http://git.reviewboard.kde.org/r/112830/diff/
> 
> 
> Testing
> ---
> 
> Builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112838: KIconThemes move to tier3

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112838/#review40530
---

Ship it!


Ship It!

- Kevin Ottens


On Sept. 20, 2013, 1:27 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112838/
> ---
> 
> (Updated Sept. 20, 2013, 1:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move the KIconThemes to tier3
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 5c52cbe 
>   staging/kiconthemes/CMakeLists.txt e5582aa 
>   staging/kiconthemes/KIconThemesConfig.cmake.in  
>   staging/kiconthemes/autotests/CMakeLists.txt  
>   staging/kiconthemes/autotests/kiconloader_unittest.cpp  
>   staging/kiconthemes/docs/DESIGN.iconloading  
>   staging/kiconthemes/src/CMakeLists.txt 0afc0d8 
>   staging/kiconthemes/src/kiconbutton.h  
>   staging/kiconthemes/src/kiconbutton.cpp  
>   staging/kiconthemes/src/kicondialog.h  
>   staging/kiconthemes/src/kicondialog.cpp  
>   staging/kiconthemes/src/kicondialog_p.h  
>   staging/kiconthemes/src/kiconeffect.h  
>   staging/kiconthemes/src/kiconeffect.cpp  
>   staging/kiconthemes/src/kiconengine.cpp  
>   staging/kiconthemes/src/kiconengine_p.h  
>   staging/kiconthemes/src/kiconloader.h  
>   staging/kiconthemes/src/kiconloader.cpp  
>   staging/kiconthemes/src/kicontheme.h  
>   staging/kiconthemes/src/kicontheme.cpp  
>   staging/kiconthemes/tests/CMakeLists.txt  
>   staging/kiconthemes/tests/kicondialogtest.cpp  
>   staging/kiconthemes/tests/kiconeffecttest.h  
>   staging/kiconthemes/tests/kiconeffecttest.cpp  
>   staging/kiconthemes/tests/kiconloadertest.cpp  
>   tier3/CMakeLists.txt fb4de8f 
> 
> Diff: http://git.reviewboard.kde.org/r/112838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112825: DNSSD: Adopt modules directory structure

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112825/#review40531
---



dnssd/src/CMakeLists.txt


Spurious space


- Kevin Ottens


On Sept. 20, 2013, 3:13 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112825/
> ---
> 
> (Updated Sept. 20, 2013, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Moves all code to src/.
> Adds forward includers so that it can keep including dnssd/*.
> Splits the CMakeLists.txt files in 2, the one in dnssd and the one in src.
> 
> 
> Diffs
> -
> 
>   dnssd/CMakeLists.txt eec325c 
>   dnssd/avahi-domainbrowser.cpp  
>   dnssd/avahi-domainbrowser_p.h  
>   dnssd/avahi-publicservice.cpp  
>   dnssd/avahi-publicservice_p.h  
>   dnssd/avahi-remoteservice.cpp  
>   dnssd/avahi-remoteservice_p.h  
>   dnssd/avahi-servicebrowser.cpp  
>   dnssd/avahi-servicebrowser_p.h  
>   dnssd/avahi-servicetypebrowser.cpp  
>   dnssd/avahi-servicetypebrowser_p.h  
>   dnssd/avahi_entrygroup_interface.h  
>   dnssd/avahi_entrygroup_interface.cpp  
>   dnssd/avahi_server_interface.h  
>   dnssd/avahi_server_interface.cpp  
>   dnssd/avahi_serviceresolver_interface.h  
>   dnssd/avahi_serviceresolver_interface.cpp  
>   dnssd/domainbrowser.h  
>   dnssd/domainmodel.h  
>   dnssd/domainmodel.cpp  
>   dnssd/dummy-domainbrowser.cpp  
>   dnssd/dummy-publicservice.cpp  
>   dnssd/dummy-remoteservice.cpp  
>   dnssd/dummy-servicebrowser.cpp  
>   dnssd/dummy-servicetypebrowser.cpp  
>   dnssd/kcm_kdnssd.kcfg  
>   dnssd/mdnsd-domainbrowser.cpp  
>   dnssd/mdnsd-domainbrowser_p.h  
>   dnssd/mdnsd-publicservice.cpp  
>   dnssd/mdnsd-remoteservice.cpp  
>   dnssd/mdnsd-responder.h  
>   dnssd/mdnsd-responder.cpp  
>   dnssd/mdnsd-sdevent.h  
>   dnssd/mdnsd-servicebrowser.cpp  
>   dnssd/mdnsd-servicebrowser_p.h  
>   dnssd/mdnsd-servicetypebrowser.cpp  
>   dnssd/mdnsd-servicetypebrowser_p.h  
>   dnssd/org.freedesktop.Avahi.DomainBrowser.xml  
>   dnssd/org.freedesktop.Avahi.ServiceBrowser.xml  
>   dnssd/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
>   dnssd/publicservice.h  
>   dnssd/remoteservice.h  
>   dnssd/servicebase.h  
>   dnssd/servicebase.cpp  
>   dnssd/servicebase_p.h  
>   dnssd/servicebrowser.h  
>   dnssd/servicemodel.h  
>   dnssd/servicemodel.cpp  
>   dnssd/servicetypebrowser.h  
>   dnssd/settings.kcfgc  
>   dnssd/src/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112825/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112882/#review40532
---



staging/kcmutils/CMakeLists.txt


KCMUTILS?



staging/kcmutils/KCMUtilsConfig.cmake.in


You should check on its dependencies, not just KCoreAddons. I'd expect 
something somewhat parallel to the target_link_libraries calls.



staging/kprintutils/CMakeLists.txt


KPRINTUTILS?



staging/kprintutils/KPrintUtilsConfig.cmake.in


I surely has other dependencies.


- Kevin Ottens


On Sept. 22, 2013, 12:32 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112882/
> ---
> 
> (Updated Sept. 22, 2013, 12:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Split remaining KUtils into kcmutils and kprintutils and move them to staging
> 
> --
> 
> There's still a few things that need doing before it's ready for moving into 
> a real tier. Those will come in a different commit/review.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4dff35d 
>   kutils/CMakeLists.txt 0cb281d 
>   kutils/Mainpage.dox  
>   kutils/TODO  
>   kutils/dummy.cpp 668f87b 
>   kutils/kcmodulecontainer.h  
>   kutils/kcmodulecontainer.cpp  
>   kutils/kcmoduleinfo.h  
>   kutils/kcmoduleinfo.cpp  
>   kutils/kcmoduleloader.h  
>   kutils/kcmoduleloader.cpp  
>   kutils/kcmoduleproxy.h  
>   kutils/kcmoduleproxy.cpp  
>   kutils/kcmoduleproxy_p.h  
>   kutils/kcmultidialog.h  
>   kutils/kcmultidialog.cpp  
>   kutils/kcmultidialog_p.h  
>   kutils/kdeglobals.kcfg  
>   kutils/kdeglobals.kcfgc  
>   kutils/kpluginselector.h  
>   kutils/kpluginselector.cpp  
>   kutils/kpluginselector_p.h  
>   kutils/kprintpreview.h  
>   kutils/kprintpreview.cpp  
>   kutils/ksettings/README.dox  
>   kutils/ksettings/TODO  
>   kutils/ksettings/componentsdialog.cpp  
>   kutils/ksettings/componentsdialog_p.h  
>   kutils/ksettings/dialog.h  
>   kutils/ksettings/dialog.cpp  
>   kutils/ksettings/dialog_p.h  
>   kutils/ksettings/dispatcher.h  
>   kutils/ksettings/dispatcher.cpp  
>   kutils/ksettings/dispatcher_p.h  
>   kutils/ksettings/pluginpage.h  
>   kutils/ksettings/pluginpage.cpp  
>   kutils/ksettingswidgetadaptor.h  
>   kutils/ksettingswidgetadaptor.cpp  
>   staging/CMakeLists.txt 5c52cbe 
>   staging/kcmutils/CMakeLists.txt PRE-CREATION 
>   staging/kcmutils/KCMUtilsConfig.cmake.in PRE-CREATION 
>   staging/kcmutils/src/CMakeLists.txt PRE-CREATION 
>   staging/kprintutils/CMakeLists.txt PRE-CREATION 
>   staging/kprintutils/KPrintUtilsConfig.cmake.in PRE-CREATION 
>   staging/kprintutils/src/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112882/diff/
> 
> 
> Testing
> ---
> 
> build + compiles
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

[Kevin Ottens]

> On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote:
> > Tested the patch in my tree, works for caps lock too.
> > 
> > Now it highlights a dependency problem... We don't want a dependency on 
> > QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to 
> > your proposed KX11Extras?
> 
> Martin Gräßlin wrote:
> Then I would suggest to move this class to KWindowSystem for the moment. 
> For the module KX11Extras I still need some code changes first (for some 
> reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing)

Well, if you remember it was my first choice to put KModifierKeyInfo in 
KWindowSystem, but you pushed back. :-)

I'm ok if you move it there then, looking forward to the patches. ;-)


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/#review40510
---


On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112443/
> ---
> 
> (Updated Sept. 4, 2013, 6:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Ported to native event filter and to xcb-xkb by reimplementing the events. 
> Most parts are kept on xlib though as we don't have xkb.h to get proper 
> defines.
> 
> 
> Diffs
> -
> 
>   tier1/kguiaddons/CMakeLists.txt 3124c4d 
>   tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112443/diff/
> 
> 
> Testing
> ---
> 
> used kmodifierkeyinfotest application. Would appreciate if someone else could 
> run it as I don't have a caps lock.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112825: DNSSD: Adopt modules directory structure

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112825/
---

(Updated Sept. 23, 2013, 11:22 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Moves all code to src/.
Adds forward includers so that it can keep including dnssd/*.
Splits the CMakeLists.txt files in 2, the one in dnssd and the one in src.


Diffs
-

  dnssd/CMakeLists.txt eec325c 
  dnssd/avahi-domainbrowser.cpp  
  dnssd/avahi-domainbrowser_p.h  
  dnssd/avahi-publicservice.cpp  
  dnssd/avahi-publicservice_p.h  
  dnssd/avahi-remoteservice.cpp  
  dnssd/avahi-remoteservice_p.h  
  dnssd/avahi-servicebrowser.cpp  
  dnssd/avahi-servicebrowser_p.h  
  dnssd/avahi-servicetypebrowser.cpp  
  dnssd/avahi-servicetypebrowser_p.h  
  dnssd/avahi_entrygroup_interface.h  
  dnssd/avahi_entrygroup_interface.cpp  
  dnssd/avahi_server_interface.h  
  dnssd/avahi_server_interface.cpp  
  dnssd/avahi_serviceresolver_interface.h  
  dnssd/avahi_serviceresolver_interface.cpp  
  dnssd/domainbrowser.h  
  dnssd/domainmodel.h  
  dnssd/domainmodel.cpp  
  dnssd/dummy-domainbrowser.cpp  
  dnssd/dummy-publicservice.cpp  
  dnssd/dummy-remoteservice.cpp  
  dnssd/dummy-servicebrowser.cpp  
  dnssd/dummy-servicetypebrowser.cpp  
  dnssd/kcm_kdnssd.kcfg  
  dnssd/mdnsd-domainbrowser.cpp  
  dnssd/mdnsd-domainbrowser_p.h  
  dnssd/mdnsd-publicservice.cpp  
  dnssd/mdnsd-remoteservice.cpp  
  dnssd/mdnsd-responder.h  
  dnssd/mdnsd-responder.cpp  
  dnssd/mdnsd-sdevent.h  
  dnssd/mdnsd-servicebrowser.cpp  
  dnssd/mdnsd-servicebrowser_p.h  
  dnssd/mdnsd-servicetypebrowser.cpp  
  dnssd/mdnsd-servicetypebrowser_p.h  
  dnssd/org.freedesktop.Avahi.DomainBrowser.xml  
  dnssd/org.freedesktop.Avahi.ServiceBrowser.xml  
  dnssd/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
  dnssd/publicservice.h  
  dnssd/remoteservice.h  
  dnssd/servicebase.h  
  dnssd/servicebase.cpp  
  dnssd/servicebase_p.h  
  dnssd/servicebrowser.h  
  dnssd/servicemodel.h  
  dnssd/servicemodel.cpp  
  dnssd/servicetypebrowser.h  
  dnssd/settings.kcfgc  
  dnssd/src/CMakeLists.txt PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112825/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112825: DNSSD: Adopt modules directory structure

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112825/#review40536
---


This review has been submitted with commit 
36ac309db4459f5bde7ff0a702ee367e7e0e258f by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 20, 2013, 3:13 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112825/
> ---
> 
> (Updated Sept. 20, 2013, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Moves all code to src/.
> Adds forward includers so that it can keep including dnssd/*.
> Splits the CMakeLists.txt files in 2, the one in dnssd and the one in src.
> 
> 
> Diffs
> -
> 
>   dnssd/CMakeLists.txt eec325c 
>   dnssd/avahi-domainbrowser.cpp  
>   dnssd/avahi-domainbrowser_p.h  
>   dnssd/avahi-publicservice.cpp  
>   dnssd/avahi-publicservice_p.h  
>   dnssd/avahi-remoteservice.cpp  
>   dnssd/avahi-remoteservice_p.h  
>   dnssd/avahi-servicebrowser.cpp  
>   dnssd/avahi-servicebrowser_p.h  
>   dnssd/avahi-servicetypebrowser.cpp  
>   dnssd/avahi-servicetypebrowser_p.h  
>   dnssd/avahi_entrygroup_interface.h  
>   dnssd/avahi_entrygroup_interface.cpp  
>   dnssd/avahi_server_interface.h  
>   dnssd/avahi_server_interface.cpp  
>   dnssd/avahi_serviceresolver_interface.h  
>   dnssd/avahi_serviceresolver_interface.cpp  
>   dnssd/domainbrowser.h  
>   dnssd/domainmodel.h  
>   dnssd/domainmodel.cpp  
>   dnssd/dummy-domainbrowser.cpp  
>   dnssd/dummy-publicservice.cpp  
>   dnssd/dummy-remoteservice.cpp  
>   dnssd/dummy-servicebrowser.cpp  
>   dnssd/dummy-servicetypebrowser.cpp  
>   dnssd/kcm_kdnssd.kcfg  
>   dnssd/mdnsd-domainbrowser.cpp  
>   dnssd/mdnsd-domainbrowser_p.h  
>   dnssd/mdnsd-publicservice.cpp  
>   dnssd/mdnsd-remoteservice.cpp  
>   dnssd/mdnsd-responder.h  
>   dnssd/mdnsd-responder.cpp  
>   dnssd/mdnsd-sdevent.h  
>   dnssd/mdnsd-servicebrowser.cpp  
>   dnssd/mdnsd-servicebrowser_p.h  
>   dnssd/mdnsd-servicetypebrowser.cpp  
>   dnssd/mdnsd-servicetypebrowser_p.h  
>   dnssd/org.freedesktop.Avahi.DomainBrowser.xml  
>   dnssd/org.freedesktop.Avahi.ServiceBrowser.xml  
>   dnssd/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
>   dnssd/publicservice.h  
>   dnssd/remoteservice.h  
>   dnssd/servicebase.h  
>   dnssd/servicebase.cpp  
>   dnssd/servicebase_p.h  
>   dnssd/servicebrowser.h  
>   dnssd/servicemodel.h  
>   dnssd/servicemodel.cpp  
>   dnssd/servicetypebrowser.h  
>   dnssd/settings.kcfgc  
>   dnssd/src/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112825/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting 2013-w39 Reminder

[Kevin Ottens]

Hello all,

Just a quick reminder:
The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris 
time.

See you there!

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

[Aleix Pol Gonzalez]

> On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote:
> > staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3
> > 
> >
> > I surely has other dependencies.

Most things in staging have faulty *Config.cmake.in files, I'd say we can 
iterate over those before moving to its own tier.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112882/#review40532
---


On Sept. 22, 2013, 12:32 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112882/
> ---
> 
> (Updated Sept. 22, 2013, 12:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Split remaining KUtils into kcmutils and kprintutils and move them to staging
> 
> --
> 
> There's still a few things that need doing before it's ready for moving into 
> a real tier. Those will come in a different commit/review.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4dff35d 
>   kutils/CMakeLists.txt 0cb281d 
>   kutils/Mainpage.dox  
>   kutils/TODO  
>   kutils/dummy.cpp 668f87b 
>   kutils/kcmodulecontainer.h  
>   kutils/kcmodulecontainer.cpp  
>   kutils/kcmoduleinfo.h  
>   kutils/kcmoduleinfo.cpp  
>   kutils/kcmoduleloader.h  
>   kutils/kcmoduleloader.cpp  
>   kutils/kcmoduleproxy.h  
>   kutils/kcmoduleproxy.cpp  
>   kutils/kcmoduleproxy_p.h  
>   kutils/kcmultidialog.h  
>   kutils/kcmultidialog.cpp  
>   kutils/kcmultidialog_p.h  
>   kutils/kdeglobals.kcfg  
>   kutils/kdeglobals.kcfgc  
>   kutils/kpluginselector.h  
>   kutils/kpluginselector.cpp  
>   kutils/kpluginselector_p.h  
>   kutils/kprintpreview.h  
>   kutils/kprintpreview.cpp  
>   kutils/ksettings/README.dox  
>   kutils/ksettings/TODO  
>   kutils/ksettings/componentsdialog.cpp  
>   kutils/ksettings/componentsdialog_p.h  
>   kutils/ksettings/dialog.h  
>   kutils/ksettings/dialog.cpp  
>   kutils/ksettings/dialog_p.h  
>   kutils/ksettings/dispatcher.h  
>   kutils/ksettings/dispatcher.cpp  
>   kutils/ksettings/dispatcher_p.h  
>   kutils/ksettings/pluginpage.h  
>   kutils/ksettings/pluginpage.cpp  
>   kutils/ksettingswidgetadaptor.h  
>   kutils/ksettingswidgetadaptor.cpp  
>   staging/CMakeLists.txt 5c52cbe 
>   staging/kcmutils/CMakeLists.txt PRE-CREATION 
>   staging/kcmutils/KCMUtilsConfig.cmake.in PRE-CREATION 
>   staging/kcmutils/src/CMakeLists.txt PRE-CREATION 
>   staging/kprintutils/CMakeLists.txt PRE-CREATION 
>   staging/kprintutils/KPrintUtilsConfig.cmake.in PRE-CREATION 
>   staging/kprintutils/src/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112882/diff/
> 
> 
> Testing
> ---
> 
> build + compiles
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1239

[KDE CI System]

See 

Changes:

[aleixpol] DNSSD: Adopt modules directory structure

--
[...truncated 21142 lines...]
-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Set runtime path of 
"
 to 
"/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64:/srv/jenkins/install/linux/x64_64/g++/qt5/qt5/dev/lib:/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/attica/master/lib64"
-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Set runtime path of 
"
 to 
"/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64:/srv/jenkins/install/linux/x64_64/g++/qt5/qt5/dev/lib:/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/strigi/libstreamanalyzer/master/lib64:/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/strigi/libstreams/master/lib64:/srv/jenkins/

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

[Kevin Ottens]

> On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote:
> > staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3
> > 
> >
> > I surely has other dependencies.
> 
> Aleix Pol Gonzalez wrote:
> Most things in staging have faulty *Config.cmake.in files, I'd say we can 
> iterate over those before moving to its own tier.

Sure, I probably won't catch them again though. :-)


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112882/#review40532
---


On Sept. 22, 2013, 12:32 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112882/
> ---
> 
> (Updated Sept. 22, 2013, 12:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Split remaining KUtils into kcmutils and kprintutils and move them to staging
> 
> --
> 
> There's still a few things that need doing before it's ready for moving into 
> a real tier. Those will come in a different commit/review.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4dff35d 
>   kutils/CMakeLists.txt 0cb281d 
>   kutils/Mainpage.dox  
>   kutils/TODO  
>   kutils/dummy.cpp 668f87b 
>   kutils/kcmodulecontainer.h  
>   kutils/kcmodulecontainer.cpp  
>   kutils/kcmoduleinfo.h  
>   kutils/kcmoduleinfo.cpp  
>   kutils/kcmoduleloader.h  
>   kutils/kcmoduleloader.cpp  
>   kutils/kcmoduleproxy.h  
>   kutils/kcmoduleproxy.cpp  
>   kutils/kcmoduleproxy_p.h  
>   kutils/kcmultidialog.h  
>   kutils/kcmultidialog.cpp  
>   kutils/kcmultidialog_p.h  
>   kutils/kdeglobals.kcfg  
>   kutils/kdeglobals.kcfgc  
>   kutils/kpluginselector.h  
>   kutils/kpluginselector.cpp  
>   kutils/kpluginselector_p.h  
>   kutils/kprintpreview.h  
>   kutils/kprintpreview.cpp  
>   kutils/ksettings/README.dox  
>   kutils/ksettings/TODO  
>   kutils/ksettings/componentsdialog.cpp  
>   kutils/ksettings/componentsdialog_p.h  
>   kutils/ksettings/dialog.h  
>   kutils/ksettings/dialog.cpp  
>   kutils/ksettings/dialog_p.h  
>   kutils/ksettings/dispatcher.h  
>   kutils/ksettings/dispatcher.cpp  
>   kutils/ksettings/dispatcher_p.h  
>   kutils/ksettings/pluginpage.h  
>   kutils/ksettings/pluginpage.cpp  
>   kutils/ksettingswidgetadaptor.h  
>   kutils/ksettingswidgetadaptor.cpp  
>   staging/CMakeLists.txt 5c52cbe 
>   staging/kcmutils/CMakeLists.txt PRE-CREATION 
>   staging/kcmutils/KCMUtilsConfig.cmake.in PRE-CREATION 
>   staging/kcmutils/src/CMakeLists.txt PRE-CREATION 
>   staging/kprintutils/CMakeLists.txt PRE-CREATION 
>   staging/kprintutils/KPrintUtilsConfig.cmake.in PRE-CREATION 
>   staging/kprintutils/src/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112882/diff/
> 
> 
> Testing
> ---
> 
> build + compiles
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112830: Start splitting KParts

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112830/
---

(Updated Sept. 23, 2013, noon)


Review request for KDE Frameworks.


Changes
---

removed dependencies to "kio" library.


Description
---

Started reorganizing KParts, everything stopped compiling, that fixes it too.

Make string to QStrign casts explicit.
KParts was exporting the "kio" linking, don't do it anymore.


Diffs (updated)
-

  interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
  interfaces/terminal/example/CMakeLists.txt 57201fa 
  kdewebkit/CMakeLists.txt cdc5835 
  khtml/CMakeLists.txt 4e1bb80 
  khtml/html/ksslkeygen.cpp a3118da 
  khtml/html/ksslkeygen_p.h 95c1a71 
  khtml/java/CMakeLists.txt ef1675c 
  khtml/java/tests/CMakeLists.txt 59bef3a 
  khtml/kmultipart/CMakeLists.txt 6a72fac 
  khtml/tests/CMakeLists.txt 99b3bdd 
  kio/CMakeLists.txt 25dc6d9 
  kparts/CMakeLists.txt 6ab9391 
  kparts/autotests/CMakeLists.txt PRE-CREATION 
  kparts/autotests/openorsavequestion_unittest.cpp PRE-CREATION 
  kparts/autotests/parttest.h PRE-CREATION 
  kparts/autotests/parttest.cpp PRE-CREATION 
  kparts/browserrun.h e758241 
  kparts/tests/CMakeLists.txt 83a97f1 
  kparts/tests/normalktm.cpp dcc3a5e 
  kparts/tests/notepad.cpp b7c3778 
  kparts/tests/openorsavequestion.cpp c080cfc 
  kparts/tests/openorsavequestion_unittest.cpp 72285b1 
  kparts/tests/parts.cpp ee198e3 
  kparts/tests/parttest.h 19f7651 
  kparts/tests/parttest.cpp 828666f 
  kparts/tests/partviewer.cpp eeeb63a 
  kparts/tests/plugin_spellcheck.cpp 073144b 
  kparts/tests/testmainwindow.cpp fd77af0 
  kross/modules/CMakeLists.txt b18c98b 
  kross/ui/CMakeLists.txt 9e7806d 
  kutils/CMakeLists.txt 0cb281d 
  staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b 

Diff: http://git.reviewboard.kde.org/r/112830/diff/


Testing
---

Builds


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112811: Make kguiaddons build standalone

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112811/#review40563
---


This review has been submitted with commit 
427e3d31863dcca9af501e36f5ce5dcbbb626286 by Aurélien Gâteau to branch 
frameworks.

- Commit Hook


On Sept. 19, 2013, 11:28 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112811/
> ---
> 
> (Updated Sept. 19, 2013, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Description
> ---
> 
> Add missing include() calls and mark it as tier1 in superbuild.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt c297be6 
>   tier1/kguiaddons/CMakeLists.txt 46877bd 
> 
> Diff: http://git.reviewboard.kde.org/r/112811/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and using superbuild.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112811: Make kguiaddons build standalone

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112811/
---

(Updated Sept. 23, 2013, 1:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Klapetek.


Description
---

Add missing include() calls and mark it as tier1 in superbuild.


Diffs
-

  superbuild/CMakeLists.txt c297be6 
  tier1/kguiaddons/CMakeLists.txt 46877bd 

Diff: http://git.reviewboard.kde.org/r/112811/diff/


Testing
---

Builds within kdelibs and using superbuild.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112896: Rework NETWM classes

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112896/
---

Review request for KDE Frameworks.


Description
---

This is a patch series, if needed I can push the branch.

The patches address the following topics:
* add unit tests for NETRootInfo and NETWinInfo which do not require a running 
window manager. Test coverage of netwm.h is:
  ** line coverage: 75 %
  ** functions coverage: 84 %
  ** branch coverage: 62 %
  The tests start their own Xvfb to have a clean state and not mess up with the 
Window Manager of a user or cause followint tests to fail on the CI system
* areas which are covered by unit tests are changed from XLib to XCB. This 
mostly affects changing and reading window properties
* API is changed from XLib types to XCB types. E.g. xcb_window_t instead of 
Window. Note: this is an API break, which I consider as necessary, given that 
especially the type "Window" is problematic.
* several bugs which were discovered through the added tests are fixed
* NETWinInfo2 is merged into NETWinInfo (marked as TODO KDE5)
* Small wrapper class for intern atom added to KXUtils. Similar code already in 
usage in KWin.


=
Commits:

commit 2e50845a5d0df436106aeb776e3936691c32a753
Author: Martin Gräßlin 
Date:   Mon Sep 23 14:31:42 2013 +0200

Use XCB for reading properties in NETRootInfo::update

Viewport handling was incorrect and is adjusted to be read correctly.

commit 23887726c03c49b4e0021c01f319653d3b9f36c5
Author: Martin Gräßlin 
Date:   Mon Sep 23 11:41:26 2013 +0200

Use XCB for reading properties in NETWinInfo::update

Those areas which are covered by unit tests are migrated from
XGetWindowProperty to the xcb variant.

BlocksCompositing had an incorrect read - it expected a string atom,
but actually uses a cardinal. This bug is fixed.

commit 2731ebbc85eddb885700232f98e0e429cb0e066b
Author: Martin Gräßlin 
Date:   Mon Sep 23 09:41:28 2013 +0200

Use XCB to change the Client dependent properties of NETWinInfo

Those properties for which we have unit tests are changed to XCB to
either change or delete the property.

commit 1bb85e440ec0004ef6b18b6fa1855c08c8f6697a
Author: Martin Gräßlin 
Date:   Fri Sep 20 09:58:09 2013 +0200

Unit test for Client aspect of NETWinInfo

Similar to the NETWinInfo test with WindowManager aspect, just
verifying the properties which can only be set by a Client.

The test found highlights a few possible problems:
 * for some window types a fallback type is specified, but the lenght
   is set to 1, thus the fallback type is not set at all
 * Fullscreen monitors property is not handled in the event function

commit 2731ebbc85eddb885700232f98e0e429cb0e066b
Author: Martin Gräßlin 
Date:   Mon Sep 23 09:41:28 2013 +0200

Use XCB to change the Client dependent properties of NETWinInfo

Those properties for which we have unit tests are changed to XCB to
either change or delete the property.

commit 1bb85e440ec0004ef6b18b6fa1855c08c8f6697a
Author: Martin Gräßlin 
Date:   Fri Sep 20 09:58:09 2013 +0200

Unit test for Client aspect of NETWinInfo

Similar to the NETWinInfo test with WindowManager aspect, just
verifying the properties which can only be set by a Client.

The test found highlights a few possible problems:
 * for some window types a fallback type is specified, but the lenght
   is set to 1, thus the fallback type is not set at all
 * Fullscreen monitors property is not handled in the event function

commit 448f200ecdd642d1a4c85522eaa7d28072cda873
Author: Martin Gräßlin 
Date:   Thu Sep 19 13:57:03 2013 +0200

Use XCB to change the WM dependent properties of NETWinInfo

Those properties for which we have unit tests are changed to XCB to
either change or delete the property.

commit 736024c6c6233a9c66a03972b9dbfbd2e6d383f4
Author: Martin Gräßlin 
Date:   Thu Sep 19 13:16:03 2013 +0200

Add unit test for window manager aspect of NETWinInfo

Similar to the test for NETRootInfo it tests setting the properties
which can only be set by the window manager. Also running in its own
Xvfb.

commit 480842406c2c070280a8be8ae3e4af93674369f3
Author: Martin Gräßlin 
Date:   Thu Sep 19 07:20:57 2013 +0200

Merge NETWinInfo2 into NETWinInfo

Class only existed for BIC changes and had a TODO remove KDE5 marker.

commit 4e71654d95715f5b44efef80fb95fa9bee295b6c
Author: Martin Gräßlin 
Date:   Thu Sep 19 07:16:00 2013 +0200

Drop desktop argument from NETRootInfo::(set)DesktopGeometry

The desktop argument was only there because of a different semantic in
an early draft of NETwm and completely unused. Doesn't make sense to
carry it into the next version.

commit 78a818af6937a01d0464b27c8256b05e9889f692
Author: Martin

Re: Review Request 112814: kjs - remove unused dependencies

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112814/
---

(Updated Sept. 23, 2013, 1:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

QtWidgets is not required, and move QtTest to autotests.


Diffs
-

  tier1/kjs/CMakeLists.txt f67846499fcd08cbf69cab4c29fc625af607bd37 
  tier1/kjs/autotests/CMakeLists.txt 2c8089fb432d1dafc0dcbaa9ff917d0696c00bf3 

Diff: http://git.reviewboard.kde.org/r/112814/diff/


Testing
---

With QtWidgets not installed, build and tests pass.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112814: kjs - remove unused dependencies

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112814/#review40564
---


This review has been submitted with commit 
4f074a30444dab33921bf8ec1a3530ffc674ce83 by Michael Palimaka to branch 
frameworks.

- Commit Hook


On Sept. 19, 2013, 12:35 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112814/
> ---
> 
> (Updated Sept. 19, 2013, 12:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> QtWidgets is not required, and move QtTest to autotests.
> 
> 
> Diffs
> -
> 
>   tier1/kjs/CMakeLists.txt f67846499fcd08cbf69cab4c29fc625af607bd37 
>   tier1/kjs/autotests/CMakeLists.txt 2c8089fb432d1dafc0dcbaa9ff917d0696c00bf3 
> 
> Diff: http://git.reviewboard.kde.org/r/112814/diff/
> 
> 
> Testing
> ---
> 
> With QtWidgets not installed, build and tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

[Fredrik Höglund]

> On Sept. 23, 2013, 10:27 a.m., Kevin Ottens wrote:
> > Not that I'm really qualified with xcb code, but it looks ok to me.
> 
> Martin Gräßlin wrote:
> no, no. The issues mentioned by Fredrik should be fixed.

Kevin, please don't take this the wrong way, but it would be enormously helpful 
if you didn't approve patches
you yourself claim to NOT be qualified to review, when others who ARE qualified 
have already reviewed them and
voiced concerns.

This is not the first time you have done this either.


- Fredrik


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112755/#review40515
---


On Sept. 17, 2013, 5:42 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112755/
> ---
> 
> (Updated Sept. 17, 2013, 5:42 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Implements the createPixmapFromHandle by getting the image for the pixmaps 
> and using it as either the Pixmap or the bitmap mask.
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/src/kxutils.cpp 33bd678 
>   tier1/kwindowsystem/src/kxutils_p.h 84d639b 
> 
> Diff: http://git.reviewboard.kde.org/r/112755/diff/
> 
> 
> Testing
> ---
> 
> Adjusted KWin to take this codepath and say thanks to Iceweasel for having a 
> mask
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112757: kwindowsystem - remove unused dependencies

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112757/#review40566
---


This review has been submitted with commit 
18d78a720672cc67a50bf88d782c337a66da3420 by Michael Palimaka to branch 
frameworks.

- Commit Hook


On Sept. 16, 2013, 2:15 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112757/
> ---
> 
> (Updated Sept. 16, 2013, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Apart from a stray include, I did not find any reference to QtDBus or 
> QtNetwork. Also, QtTest is already specified in autotests/, so no need to 
> require it in the root.
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/CMakeLists.txt 984db7fc814bb4c2342835f9b7034055f06f93ca 
>   tier1/kwindowsystem/autotests/CMakeLists.txt 
> a1a7066f24aabb4e24b3920a462845e92a7ec5e4 
>   tier1/kwindowsystem/src/kwindowinfo_mac.cpp 
> 1bf0876435a6ebd48db145635a49f89199de848f 
>   tier1/kwindowsystem/src/kwindowinfo_x11.cpp 
> f382e9c0c580ec209bd75994fedd5f20584af5e2 
>   tier1/kwindowsystem/src/kwindowsystem_mac.cpp 
> 6133a0bf3c4ca5d000cb3499f486e126d60c0873 
> 
> Diff: http://git.reviewboard.kde.org/r/112757/diff/
> 
> 
> Testing
> ---
> 
> Builds and tests pass with QtDBus and QtNetwork not installed.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112757: kwindowsystem - remove unused dependencies

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112757/
---

(Updated Sept. 23, 2013, 1:39 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Apart from a stray include, I did not find any reference to QtDBus or 
QtNetwork. Also, QtTest is already specified in autotests/, so no need to 
require it in the root.


Diffs
-

  tier1/kwindowsystem/CMakeLists.txt 984db7fc814bb4c2342835f9b7034055f06f93ca 
  tier1/kwindowsystem/autotests/CMakeLists.txt 
a1a7066f24aabb4e24b3920a462845e92a7ec5e4 
  tier1/kwindowsystem/src/kwindowinfo_mac.cpp 
1bf0876435a6ebd48db145635a49f89199de848f 
  tier1/kwindowsystem/src/kwindowinfo_x11.cpp 
f382e9c0c580ec209bd75994fedd5f20584af5e2 
  tier1/kwindowsystem/src/kwindowsystem_mac.cpp 
6133a0bf3c4ca5d000cb3499f486e126d60c0873 

Diff: http://git.reviewboard.kde.org/r/112757/diff/


Testing
---

Builds and tests pass with QtDBus and QtNetwork not installed.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/
---

(Updated Sept. 23, 2013, 1:45 p.m.)


Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.


Changes
---

Moves naturalCompare to kde4support/kdecore. The naturalCompare test goes 
together with it.


Description
---

Apparently there's people who still want to have it. Leave it in KCoreAddons 
for the moment, until we decide that it can be replaced for good by QCollator.


Diffs (updated)
-

  staging/kde4support/autotests/CMakeLists.txt 473bdba 
  staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION 
  staging/kde4support/src/CMakeLists.txt 5dc206d 
  staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION 
  staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION 
  tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
  tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
  tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 

Diff: http://git.reviewboard.kde.org/r/112797/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112897: Move itemviews to tier1

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112897/
---

Review request for KDE Frameworks.


Description
---

Move itemviews to tier1, now that we can use QCollator.

This is a refresh of https://git.reviewboard.kde.org/r/112792/ , for some 
reason Review Board did not accept the new diff as an update.


Diffs
-

  staging/CMakeLists.txt 5c52cbe 
  staging/itemviews/CMakeLists.txt fd28b10 
  staging/itemviews/ItemViewsConfig.cmake.in bf12be3 
  staging/itemviews/autotests/CMakeLists.txt  
  staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
  staging/itemviews/src/CMakeLists.txt  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
  staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
  staging/itemviews/src/kcategorizedview.h  
  staging/itemviews/src/kcategorizedview.cpp  
  staging/itemviews/src/kcategorizedview_p.h  
  staging/itemviews/src/kcategorydrawer.h  
  staging/itemviews/src/kcategorydrawer.cpp  
  staging/itemviews/src/kextendableitemdelegate.h  
  staging/itemviews/src/kextendableitemdelegate.cpp  
  staging/itemviews/src/kfilterproxysearchline.h  
  staging/itemviews/src/kfilterproxysearchline.cpp  
  staging/itemviews/src/klistwidgetsearchline.h  
  staging/itemviews/src/klistwidgetsearchline.cpp  
  staging/itemviews/src/ktreewidgetsearchline.h  
  staging/itemviews/src/ktreewidgetsearchline.cpp  
  staging/itemviews/src/kwidgetitemdelegate.h  
  staging/itemviews/src/kwidgetitemdelegate.cpp  
  staging/itemviews/src/kwidgetitemdelegate_p.h  
  staging/itemviews/src/kwidgetitemdelegatepool.cpp  
  staging/itemviews/src/kwidgetitemdelegatepool_p.h  
  staging/itemviews/tests/CMakeLists.txt  
  staging/itemviews/tests/kcategorizedviewtest.cpp  
  staging/itemviews/tests/ktreewidgetsearchlinetest.h  
  staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
  staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
  superbuild/CMakeLists.txt 3076b3b 
  tier1/CMakeLists.txt d97b39f 

Diff: http://git.reviewboard.kde.org/r/112897/diff/


Testing
---

Builds within kdelibs and standalone. The single auto test passes, manual tests 
are running correctly.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112792: Move itemviews to tier2

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112792/
---

(Updated Sept. 23, 2013, 4:09 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Description
---

Move itemviews to tier2. Was waiting for the QCollator request (  
https://git.reviewboard.kde.org/r/112717/ ) to go in before so that itemviews 
could go to tier1, but it seems it is not going in, so let's go tier2 for now.


Diffs
-

  staging/CMakeLists.txt 7826b07 
  staging/itemviews/CMakeLists.txt  
  staging/itemviews/ItemViewsConfig.cmake.in  
  staging/itemviews/autotests/CMakeLists.txt  
  staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
  staging/itemviews/src/CMakeLists.txt  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
  staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
  staging/itemviews/src/kcategorizedview.h  
  staging/itemviews/src/kcategorizedview.cpp  
  staging/itemviews/src/kcategorizedview_p.h  
  staging/itemviews/src/kcategorydrawer.h  
  staging/itemviews/src/kcategorydrawer.cpp  
  staging/itemviews/src/kextendableitemdelegate.h  
  staging/itemviews/src/kextendableitemdelegate.cpp  
  staging/itemviews/src/kfilterproxysearchline.h  
  staging/itemviews/src/kfilterproxysearchline.cpp  
  staging/itemviews/src/klistwidgetsearchline.h  
  staging/itemviews/src/klistwidgetsearchline.cpp  
  staging/itemviews/src/ktreewidgetsearchline.h  
  staging/itemviews/src/ktreewidgetsearchline.cpp  
  staging/itemviews/src/kwidgetitemdelegate.h  
  staging/itemviews/src/kwidgetitemdelegate.cpp  
  staging/itemviews/src/kwidgetitemdelegate_p.h  
  staging/itemviews/src/kwidgetitemdelegatepool.cpp  
  staging/itemviews/src/kwidgetitemdelegatepool_p.h  
  staging/itemviews/tests/CMakeLists.txt  
  staging/itemviews/tests/kcategorizedviewtest.cpp  
  staging/itemviews/tests/ktreewidgetsearchlinetest.h  
  staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
  staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
  superbuild/CMakeLists.txt c297be6 
  tier2/CMakeLists.txt 6c98a7d 

Diff: http://git.reviewboard.kde.org/r/112792/diff/


Testing
---

Builds within kdelibs and standalone. The single auto test passes, manual tests 
are running correctly.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112880: Added KColorSchemeToken class.

[Denis Kuplyakov]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
---

(Updated Sept. 23, 2013, 2:43 p.m.)


Review request for KDE Frameworks and kdelibs.


Description
---

It is wrapper to access KColorScheme's methods from QML code.
Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them 
accessible from QML code.

As it will be accepted, QML-clone of KgPopupItem will be posted for review to 
libkdegames, as it uses it to access KDE's color theme.

More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames 
mailinglists *

NEED TO FIX:
I can't include it like #include  at KReversi's code, only 
"kcolorschemetoken.h". Maybe I've missed something?


Diffs
-

  includes/CMakeLists.txt cdf0143 
  includes/KColorSchemeToken PRE-CREATION 
  kdeui/CMakeLists.txt b439e04 
  kdeui/colors/kcolorscheme.h 17570fd 
  kdeui/colors/kcolorscheme.cpp a6650ac 
  kdeui/colors/kcolorschemetoken.h PRE-CREATION 
  kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112880/diff/


Testing
---

I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.


Thanks,

Denis Kuplyakov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/#review40574
---


It does not build standalone for me, linking fails: 
http://paste.kde.org/p05c23fa6

I tried to do xmlgui last week, but realized it needs more work on the 
underlying frameworks first (which is why I switched to kconfigwidgets)

- Aurélien Gâteau


On Sept. 19, 2013, 6:44 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112829/
> ---
> 
> (Updated Sept. 19, 2013, 6:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move xmlgui to tier3, done all the checks.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 2a31994 
>   staging/xmlgui/CMakeLists.txt  
>   staging/xmlgui/TODO.xmlgui  
>   staging/xmlgui/XmlGuiConfig.cmake.in  
>   staging/xmlgui/autotests/CMakeLists.txt  
>   staging/xmlgui/autotests/kactioncategorytest.h  
>   staging/xmlgui/autotests/kactioncategorytest.cpp  
>   staging/xmlgui/autotests/kactioncollectiontest.h  
>   staging/xmlgui/autotests/kactioncollectiontest.cpp  
>   staging/xmlgui/autotests/kglobalshortcuttest.h  
>   staging/xmlgui/autotests/kglobalshortcuttest.cpp  
>   staging/xmlgui/autotests/kmainwindow_unittest.h  
>   staging/xmlgui/autotests/kmainwindow_unittest.cpp  
>   staging/xmlgui/autotests/ktoolbar_unittest.cpp  
>   staging/xmlgui/autotests/kxmlgui_unittest.h  
>   staging/xmlgui/autotests/kxmlgui_unittest.cpp  
>   staging/xmlgui/autotests/testguiclient.h  
>   staging/xmlgui/autotests/testxmlguiwindow.h  
>   staging/xmlgui/make_kdepackages.sh  
>   staging/xmlgui/make_kdepackages_updated.py  
>   staging/xmlgui/src/CMakeLists.txt b1d7d17 
>   staging/xmlgui/src/README  
>   staging/xmlgui/src/TODO  
>   staging/xmlgui/src/aboutkde.png  
>   staging/xmlgui/src/config-xmlgui.h.cmake  
>   staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake  
>   staging/xmlgui/src/kaboutapplicationdialog.h  
>   staging/xmlgui/src/kaboutapplicationdialog.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp  
>   staging/xmlgui/src/kaboutkdedialog_p.h  
>   staging/xmlgui/src/kaboutkdedialog_p.cpp  
>   staging/xmlgui/src/kactioncategory.h  
>   staging/xmlgui/src/kactioncategory.cpp  
>   staging/xmlgui/src/kactioncollection.h  
>   staging/xmlgui/src/kactioncollection.cpp  
>   staging/xmlgui/src/kactionconflictdetector.cpp  
>   staging/xmlgui/src/kbugreport.h  
>   staging/xmlgui/src/kbugreport.cpp  
>   staging/xmlgui/src/kcheckaccelerators.h  
>   staging/xmlgui/src/kcheckaccelerators.cpp  
>   staging/xmlgui/src/kdepackages.h  
>   staging/xmlgui/src/kedittoolbar.h  
>   staging/xmlgui/src/kedittoolbar.cpp  
>   staging/xmlgui/src/kedittoolbar_p.h  
>   staging/xmlgui/src/kglobalaccel.h  
>   staging/xmlgui/src/kglobalaccel.cpp  
>   staging/xmlgui/src/kglobalaccel_p.h  
>   staging/xmlgui/src/kglobalshortcutinfo.h  
>   staging/xmlgui/src/kglobalshortcutinfo.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_p.h  
>   staging/xmlgui/src/khelpclient.h  
>   staging/xmlgui/src/khelpclient.cpp  
>   staging/xmlgui/src/khelpmenu.h  
>   staging/xmlgui/src/khelpmenu.cpp  
>   staging/xmlgui/src/kkeysequencewidget.h  
>   staging/xmlgui/src/kkeysequencewidget.cpp  
>   staging/xmlgui/src/kkeysequencewidget_p.h  
>   staging/xmlgui/src/kmainwindow.h  
>   staging/xmlgui/src/kmainwindow.cpp  
>   staging/xmlgui/src/kmainwindow_p.h  
>   staging/xmlgui/src/kmainwindowiface.cpp  
>   staging/xmlgui/src/kmainwindowiface_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.cpp  
>   staging/xmlgui/src/kpartgui.dtd  
>   staging/xmlgui/src/kshortcuteditwidget.cpp  
>   staging/xmlgui/src/kshortcutschemeseditor.cpp  
>   staging/xmlgui/src/kshortcutschemeshelper.cpp  
>   staging/xmlgui/src/kshortcutschemeshelper_p.h  
>   staging/xmlgui/src/kshortcutsdialog.h  
>   staging/xmlgui/src/kshortcutsdialog.cpp  
>   staging/xmlgui/src/kshortcutsdialog.ui  
>   staging/xmlgui/src/kshortcutsdialog_p.h  
>   staging/xmlgui/src/kshortcutseditor.h  
>   staging/xmlgui/src/kshortcutseditor.cpp  
>   staging/xmlgui/src/kshortcutseditordelegate.cpp  
>   staging/xmlgui/src/kshortcutseditoritem.cpp  
>   staging/xmlgui/src/kshortcutwidget.h  
>   staging/xmlgui/src/kshortcutwidget.cpp  
>   staging/xmlgui/src/kshortcutwidget.

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

[Kevin Ottens]

> On Sept. 23, 2013, 10:27 a.m., Kevin Ottens wrote:
> > Not that I'm really qualified with xcb code, but it looks ok to me.
> 
> Martin Gräßlin wrote:
> no, no. The issues mentioned by Fredrik should be fixed.
> 
> Fredrik Höglund wrote:
> Kevin, please don't take this the wrong way, but it would be enormously 
> helpful if you didn't approve patches
> you yourself claim to NOT be qualified to review, when others who ARE 
> qualified have already reviewed them and
> voiced concerns.
> 
> This is not the first time you have done this either.
>

Yeah, that's one of the things I don't like with reviewboard... I've no way to 
vote that properly (I'm kind of used to the +1 vs +2 distinction in gerrit). 
There's more than one aspect to a patch, so although I'm not qualified for the 
XCB specific code I looked at the other aspects.

That's why I put a ship it, but adding the comment so that others with know how 
look at it... I looks heavy handed in reviewboard lingo indeed. Hm, I guess 
with reviewboard I should simply post a comment in those cases.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112755/#review40515
---


On Sept. 17, 2013, 5:42 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112755/
> ---
> 
> (Updated Sept. 17, 2013, 5:42 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Implements the createPixmapFromHandle by getting the image for the pixmaps 
> and using it as either the Pixmap or the bitmap mask.
> 
> 
> Diffs
> -
> 
>   tier1/kwindowsystem/src/kxutils.cpp 33bd678 
>   tier1/kwindowsystem/src/kxutils_p.h 84d639b 
> 
> Diff: http://git.reviewboard.kde.org/r/112755/diff/
> 
> 
> Testing
> ---
> 
> Adjusted KWin to take this codepath and say thanks to Iceweasel for having a 
> mask
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112897: Move itemviews to tier1

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112897/#review40576
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Sept. 23, 2013, 2:09 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112897/
> ---
> 
> (Updated Sept. 23, 2013, 2:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move itemviews to tier1, now that we can use QCollator.
> 
> This is a refresh of https://git.reviewboard.kde.org/r/112792/ , for some 
> reason Review Board did not accept the new diff as an update.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 5c52cbe 
>   staging/itemviews/CMakeLists.txt fd28b10 
>   staging/itemviews/ItemViewsConfig.cmake.in bf12be3 
>   staging/itemviews/autotests/CMakeLists.txt  
>   staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   staging/itemviews/src/CMakeLists.txt  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   staging/itemviews/src/kcategorizedview.h  
>   staging/itemviews/src/kcategorizedview.cpp  
>   staging/itemviews/src/kcategorizedview_p.h  
>   staging/itemviews/src/kcategorydrawer.h  
>   staging/itemviews/src/kcategorydrawer.cpp  
>   staging/itemviews/src/kextendableitemdelegate.h  
>   staging/itemviews/src/kextendableitemdelegate.cpp  
>   staging/itemviews/src/kfilterproxysearchline.h  
>   staging/itemviews/src/kfilterproxysearchline.cpp  
>   staging/itemviews/src/klistwidgetsearchline.h  
>   staging/itemviews/src/klistwidgetsearchline.cpp  
>   staging/itemviews/src/ktreewidgetsearchline.h  
>   staging/itemviews/src/ktreewidgetsearchline.cpp  
>   staging/itemviews/src/kwidgetitemdelegate.h  
>   staging/itemviews/src/kwidgetitemdelegate.cpp  
>   staging/itemviews/src/kwidgetitemdelegate_p.h  
>   staging/itemviews/src/kwidgetitemdelegatepool.cpp  
>   staging/itemviews/src/kwidgetitemdelegatepool_p.h  
>   staging/itemviews/tests/CMakeLists.txt  
>   staging/itemviews/tests/kcategorizedviewtest.cpp  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.h  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   superbuild/CMakeLists.txt 3076b3b 
>   tier1/CMakeLists.txt d97b39f 
> 
> Diff: http://git.reviewboard.kde.org/r/112897/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and standalone. The single auto test passes, manual 
> tests are running correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

[Aurélien Gâteau]

> On Sept. 23, 2013, 5:10 p.m., Aurélien Gâteau wrote:
> > It does not build standalone for me, linking fails: 
> > http://paste.kde.org/p05c23fa6
> > 
> > I tried to do xmlgui last week, but realized it needs more work on the 
> > underlying frameworks first (which is why I switched to kconfigwidgets)
> 
> Aleix Pol Gonzalez wrote:
> Building standalone is not one of the things required by 
> http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .
> 
> Also it's something we probably want to deal with at a later stage, when 
> we decide how each should be distributed.

That looks a bit backward to me: how can you be sure you get dependencies 
correctly if you can't build the framework on its own?


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/#review40574
---


On Sept. 19, 2013, 6:44 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112829/
> ---
> 
> (Updated Sept. 19, 2013, 6:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move xmlgui to tier3, done all the checks.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 2a31994 
>   staging/xmlgui/CMakeLists.txt  
>   staging/xmlgui/TODO.xmlgui  
>   staging/xmlgui/XmlGuiConfig.cmake.in  
>   staging/xmlgui/autotests/CMakeLists.txt  
>   staging/xmlgui/autotests/kactioncategorytest.h  
>   staging/xmlgui/autotests/kactioncategorytest.cpp  
>   staging/xmlgui/autotests/kactioncollectiontest.h  
>   staging/xmlgui/autotests/kactioncollectiontest.cpp  
>   staging/xmlgui/autotests/kglobalshortcuttest.h  
>   staging/xmlgui/autotests/kglobalshortcuttest.cpp  
>   staging/xmlgui/autotests/kmainwindow_unittest.h  
>   staging/xmlgui/autotests/kmainwindow_unittest.cpp  
>   staging/xmlgui/autotests/ktoolbar_unittest.cpp  
>   staging/xmlgui/autotests/kxmlgui_unittest.h  
>   staging/xmlgui/autotests/kxmlgui_unittest.cpp  
>   staging/xmlgui/autotests/testguiclient.h  
>   staging/xmlgui/autotests/testxmlguiwindow.h  
>   staging/xmlgui/make_kdepackages.sh  
>   staging/xmlgui/make_kdepackages_updated.py  
>   staging/xmlgui/src/CMakeLists.txt b1d7d17 
>   staging/xmlgui/src/README  
>   staging/xmlgui/src/TODO  
>   staging/xmlgui/src/aboutkde.png  
>   staging/xmlgui/src/config-xmlgui.h.cmake  
>   staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake  
>   staging/xmlgui/src/kaboutapplicationdialog.h  
>   staging/xmlgui/src/kaboutapplicationdialog.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp  
>   staging/xmlgui/src/kaboutkdedialog_p.h  
>   staging/xmlgui/src/kaboutkdedialog_p.cpp  
>   staging/xmlgui/src/kactioncategory.h  
>   staging/xmlgui/src/kactioncategory.cpp  
>   staging/xmlgui/src/kactioncollection.h  
>   staging/xmlgui/src/kactioncollection.cpp  
>   staging/xmlgui/src/kactionconflictdetector.cpp  
>   staging/xmlgui/src/kbugreport.h  
>   staging/xmlgui/src/kbugreport.cpp  
>   staging/xmlgui/src/kcheckaccelerators.h  
>   staging/xmlgui/src/kcheckaccelerators.cpp  
>   staging/xmlgui/src/kdepackages.h  
>   staging/xmlgui/src/kedittoolbar.h  
>   staging/xmlgui/src/kedittoolbar.cpp  
>   staging/xmlgui/src/kedittoolbar_p.h  
>   staging/xmlgui/src/kglobalaccel.h  
>   staging/xmlgui/src/kglobalaccel.cpp  
>   staging/xmlgui/src/kglobalaccel_p.h  
>   staging/xmlgui/src/kglobalshortcutinfo.h  
>   staging/xmlgui/src/kglobalshortcutinfo.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_p.h  
>   staging/xmlgui/src/khelpclient.h  
>   staging/xmlgui/src/khelpclient.cpp  
>   staging/xmlgui/src/khelpmenu.h  
>   staging/xmlgui/src/khelpmenu.cpp  
>   staging/xmlgui/src/kkeysequencewidget.h  
>   staging/xmlgui/src/kkeysequencewidget.cpp  
>   staging/xmlgui/src/kkeysequencewidget_p.h  
>   staging/xmlgui/src/kmainwindow.h  
>   staging/xmlgui/src/kmainwindow.cpp  
>   staging/xmlgui/src/kmainwindow_p.h  
>   staging/xmlgui/src/kmainwindowiface.cpp  
>   staging/xmlgui/src/kmainwindowiface_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.cpp  
>   staging/xmlgui/src/kpartgui.dtd  
>   staging/xmlgui/src/kshortcuteditwidget.cpp  
>   staging/xmlgui/src/kshortcutschemeseditor.cpp  
>   staging/xmlgui/src/kshortcutschemeshelper.cpp  
>   staging/xmlgui/src/kshortcutschemeshelper_p.h  
>   staging

Re: Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112598/#review40582
---


This review has been submitted with commit 
3690c92db64315b3e016ec669e3e11e59218b536 by Martin Gräßlin to branch frameworks.

- Commit Hook


On Sept. 9, 2013, 6:51 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112598/
> ---
> 
> (Updated Sept. 9, 2013, 6:51 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> The behavior to get a memory-only KConfig if file name is empty and the 
> SimpleConfig open flag is used got lost by always setting the file name to 
> the mainConfigName.
> 
> 
> Diffs
> -
> 
>   tier1/kconfig/src/core/ksharedconfig.cpp 3b53e32 
> 
> Diff: http://git.reviewboard.kde.org/r/112598/diff/
> 
> 
> Testing
> ---
> 
> a failing KWin unit test doesn't fail any more.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112897: Move itemviews to tier1

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112897/
---

(Updated Sept. 23, 2013, 4:17 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Move itemviews to tier1, now that we can use QCollator.

This is a refresh of https://git.reviewboard.kde.org/r/112792/ , for some 
reason Review Board did not accept the new diff as an update.


Diffs
-

  staging/CMakeLists.txt 5c52cbe 
  staging/itemviews/CMakeLists.txt fd28b10 
  staging/itemviews/ItemViewsConfig.cmake.in bf12be3 
  staging/itemviews/autotests/CMakeLists.txt  
  staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
  staging/itemviews/src/CMakeLists.txt  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
  staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
  staging/itemviews/src/kcategorizedview.h  
  staging/itemviews/src/kcategorizedview.cpp  
  staging/itemviews/src/kcategorizedview_p.h  
  staging/itemviews/src/kcategorydrawer.h  
  staging/itemviews/src/kcategorydrawer.cpp  
  staging/itemviews/src/kextendableitemdelegate.h  
  staging/itemviews/src/kextendableitemdelegate.cpp  
  staging/itemviews/src/kfilterproxysearchline.h  
  staging/itemviews/src/kfilterproxysearchline.cpp  
  staging/itemviews/src/klistwidgetsearchline.h  
  staging/itemviews/src/klistwidgetsearchline.cpp  
  staging/itemviews/src/ktreewidgetsearchline.h  
  staging/itemviews/src/ktreewidgetsearchline.cpp  
  staging/itemviews/src/kwidgetitemdelegate.h  
  staging/itemviews/src/kwidgetitemdelegate.cpp  
  staging/itemviews/src/kwidgetitemdelegate_p.h  
  staging/itemviews/src/kwidgetitemdelegatepool.cpp  
  staging/itemviews/src/kwidgetitemdelegatepool_p.h  
  staging/itemviews/tests/CMakeLists.txt  
  staging/itemviews/tests/kcategorizedviewtest.cpp  
  staging/itemviews/tests/ktreewidgetsearchlinetest.h  
  staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
  staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
  superbuild/CMakeLists.txt 3076b3b 
  tier1/CMakeLists.txt d97b39f 

Diff: http://git.reviewboard.kde.org/r/112897/diff/


Testing
---

Builds within kdelibs and standalone. The single auto test passes, manual tests 
are running correctly.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112897: Move itemviews to tier1

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112897/#review40587
---


This review has been submitted with commit 
b44217f33203c6632edd45740aef12000aa431f9 by Aurélien Gâteau to branch 
frameworks.

- Commit Hook


On Sept. 23, 2013, 2:09 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112897/
> ---
> 
> (Updated Sept. 23, 2013, 2:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move itemviews to tier1, now that we can use QCollator.
> 
> This is a refresh of https://git.reviewboard.kde.org/r/112792/ , for some 
> reason Review Board did not accept the new diff as an update.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 5c52cbe 
>   staging/itemviews/CMakeLists.txt fd28b10 
>   staging/itemviews/ItemViewsConfig.cmake.in bf12be3 
>   staging/itemviews/autotests/CMakeLists.txt  
>   staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   staging/itemviews/src/CMakeLists.txt  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   staging/itemviews/src/kcategorizedview.h  
>   staging/itemviews/src/kcategorizedview.cpp  
>   staging/itemviews/src/kcategorizedview_p.h  
>   staging/itemviews/src/kcategorydrawer.h  
>   staging/itemviews/src/kcategorydrawer.cpp  
>   staging/itemviews/src/kextendableitemdelegate.h  
>   staging/itemviews/src/kextendableitemdelegate.cpp  
>   staging/itemviews/src/kfilterproxysearchline.h  
>   staging/itemviews/src/kfilterproxysearchline.cpp  
>   staging/itemviews/src/klistwidgetsearchline.h  
>   staging/itemviews/src/klistwidgetsearchline.cpp  
>   staging/itemviews/src/ktreewidgetsearchline.h  
>   staging/itemviews/src/ktreewidgetsearchline.cpp  
>   staging/itemviews/src/kwidgetitemdelegate.h  
>   staging/itemviews/src/kwidgetitemdelegate.cpp  
>   staging/itemviews/src/kwidgetitemdelegate_p.h  
>   staging/itemviews/src/kwidgetitemdelegatepool.cpp  
>   staging/itemviews/src/kwidgetitemdelegatepool_p.h  
>   staging/itemviews/tests/CMakeLists.txt  
>   staging/itemviews/tests/kcategorizedviewtest.cpp  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.h  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   superbuild/CMakeLists.txt 3076b3b 
>   tier1/CMakeLists.txt d97b39f 
> 
> Diff: http://git.reviewboard.kde.org/r/112897/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and standalone. The single auto test passes, manual 
> tests are running correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt Dev Days Stuff

[John Layt]

On 19 September 2013 15:34, John Layt  wrote:

> Qt Dev Days is short on Lightning Talks, so if you have a Qt-related
> topic you want to present or demo for up to 10 minutes, please submit
> it at http://www.qtdeveloperdays.com/lightning-talks by tomorrow.

I've submitted a talk called "KDE and Qt" which I've provisionally put
my name down for.  I didn't register a separate KF5 talk because I
realised there was already an hour long talk scheduled :-)  However I
will mention KF5 and dirct people to teh talk for more info.

> And yes, we still have a couple of tickets available if you want to
> come and join in the fun.

Ditto...

Cheers!

John.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

[Aleix Pol Gonzalez]

> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote:
> > It does not build standalone for me, linking fails: 
> > http://paste.kde.org/p05c23fa6
> > 
> > I tried to do xmlgui last week, but realized it needs more work on the 
> > underlying frameworks first (which is why I switched to kconfigwidgets)
> 
> Aleix Pol Gonzalez wrote:
> Building standalone is not one of the things required by 
> http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .
> 
> Also it's something we probably want to deal with at a later stage, when 
> we decide how each should be distributed.
> 
> Aurélien Gâteau wrote:
> That looks a bit backward to me: how can you be sure you get dependencies 
> correctly if you can't build the framework on its own?

It should be the same libraries that are specified in LINK_PUBLIC. Either way, 
I guess we won't know for real until KF5 starts to be actually used after all.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/#review40574
---


On Sept. 19, 2013, 4:44 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112829/
> ---
> 
> (Updated Sept. 19, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move xmlgui to tier3, done all the checks.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 2a31994 
>   staging/xmlgui/CMakeLists.txt  
>   staging/xmlgui/TODO.xmlgui  
>   staging/xmlgui/XmlGuiConfig.cmake.in  
>   staging/xmlgui/autotests/CMakeLists.txt  
>   staging/xmlgui/autotests/kactioncategorytest.h  
>   staging/xmlgui/autotests/kactioncategorytest.cpp  
>   staging/xmlgui/autotests/kactioncollectiontest.h  
>   staging/xmlgui/autotests/kactioncollectiontest.cpp  
>   staging/xmlgui/autotests/kglobalshortcuttest.h  
>   staging/xmlgui/autotests/kglobalshortcuttest.cpp  
>   staging/xmlgui/autotests/kmainwindow_unittest.h  
>   staging/xmlgui/autotests/kmainwindow_unittest.cpp  
>   staging/xmlgui/autotests/ktoolbar_unittest.cpp  
>   staging/xmlgui/autotests/kxmlgui_unittest.h  
>   staging/xmlgui/autotests/kxmlgui_unittest.cpp  
>   staging/xmlgui/autotests/testguiclient.h  
>   staging/xmlgui/autotests/testxmlguiwindow.h  
>   staging/xmlgui/make_kdepackages.sh  
>   staging/xmlgui/make_kdepackages_updated.py  
>   staging/xmlgui/src/CMakeLists.txt b1d7d17 
>   staging/xmlgui/src/README  
>   staging/xmlgui/src/TODO  
>   staging/xmlgui/src/aboutkde.png  
>   staging/xmlgui/src/config-xmlgui.h.cmake  
>   staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake  
>   staging/xmlgui/src/kaboutapplicationdialog.h  
>   staging/xmlgui/src/kaboutapplicationdialog.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp  
>   staging/xmlgui/src/kaboutkdedialog_p.h  
>   staging/xmlgui/src/kaboutkdedialog_p.cpp  
>   staging/xmlgui/src/kactioncategory.h  
>   staging/xmlgui/src/kactioncategory.cpp  
>   staging/xmlgui/src/kactioncollection.h  
>   staging/xmlgui/src/kactioncollection.cpp  
>   staging/xmlgui/src/kactionconflictdetector.cpp  
>   staging/xmlgui/src/kbugreport.h  
>   staging/xmlgui/src/kbugreport.cpp  
>   staging/xmlgui/src/kcheckaccelerators.h  
>   staging/xmlgui/src/kcheckaccelerators.cpp  
>   staging/xmlgui/src/kdepackages.h  
>   staging/xmlgui/src/kedittoolbar.h  
>   staging/xmlgui/src/kedittoolbar.cpp  
>   staging/xmlgui/src/kedittoolbar_p.h  
>   staging/xmlgui/src/kglobalaccel.h  
>   staging/xmlgui/src/kglobalaccel.cpp  
>   staging/xmlgui/src/kglobalaccel_p.h  
>   staging/xmlgui/src/kglobalshortcutinfo.h  
>   staging/xmlgui/src/kglobalshortcutinfo.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_p.h  
>   staging/xmlgui/src/khelpclient.h  
>   staging/xmlgui/src/khelpclient.cpp  
>   staging/xmlgui/src/khelpmenu.h  
>   staging/xmlgui/src/khelpmenu.cpp  
>   staging/xmlgui/src/kkeysequencewidget.h  
>   staging/xmlgui/src/kkeysequencewidget.cpp  
>   staging/xmlgui/src/kkeysequencewidget_p.h  
>   staging/xmlgui/src/kmainwindow.h  
>   staging/xmlgui/src/kmainwindow.cpp  
>   staging/xmlgui/src/kmainwindow_p.h  
>   staging/xmlgui/src/kmainwindowiface.cpp  
>   staging/xmlgui/src/kmainwindowiface_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.cpp  
>   staging/xmlgui/src/kpartgui.dtd  
>   staging/xmlgui/src/k

Review Request 112900: Prepare KDNSSD for moving

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112900/
---

Review request for KDE Frameworks.


Description
---

Prepares the module to be moved to its own tier.

There's a rather uncommon case with this module because there's a dependency 
against KConfig, but it only applies to when it's compiled with the mdnsd 
backend (only when there's no Avahi but mDns instead). I guess this makes it 
tier 2, but I'm not all that sure about that.


Diffs
-

  dnssd/CMakeLists.txt a2dd8e6 
  dnssd/src/CMakeLists.txt 47587af 
  dnssd/src/avahi-publicservice.cpp 119c5a8 
  dnssd/src/mdnsd-publicservice.cpp 2a775fa 
  dnssd/src/servicemodel.cpp 348db57 
  staging/kde4support/CMakeLists.txt 24ee457 

Diff: http://git.reviewboard.kde.org/r/112900/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

[Aleix Pol Gonzalez]

> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote:
> > It does not build standalone for me, linking fails: 
> > http://paste.kde.org/p05c23fa6
> > 
> > I tried to do xmlgui last week, but realized it needs more work on the 
> > underlying frameworks first (which is why I switched to kconfigwidgets)
> 
> Aleix Pol Gonzalez wrote:
> Building standalone is not one of the things required by 
> http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .
> 
> Also it's something we probably want to deal with at a later stage, when 
> we decide how each should be distributed.
> 
> Aurélien Gâteau wrote:
> That looks a bit backward to me: how can you be sure you get dependencies 
> correctly if you can't build the framework on its own?
> 
> Aleix Pol Gonzalez wrote:
> It should be the same libraries that are specified in LINK_PUBLIC. Either 
> way, I guess we won't know for real until KF5 starts to be actually used 
> after all.
> 
> Aurélien Gâteau wrote:
> Building the framework standalone already lets you know for real if it is 
> missing any required library, no?

Yes


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/#review40574
---


On Sept. 19, 2013, 4:44 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112829/
> ---
> 
> (Updated Sept. 19, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move xmlgui to tier3, done all the checks.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 2a31994 
>   staging/xmlgui/CMakeLists.txt  
>   staging/xmlgui/TODO.xmlgui  
>   staging/xmlgui/XmlGuiConfig.cmake.in  
>   staging/xmlgui/autotests/CMakeLists.txt  
>   staging/xmlgui/autotests/kactioncategorytest.h  
>   staging/xmlgui/autotests/kactioncategorytest.cpp  
>   staging/xmlgui/autotests/kactioncollectiontest.h  
>   staging/xmlgui/autotests/kactioncollectiontest.cpp  
>   staging/xmlgui/autotests/kglobalshortcuttest.h  
>   staging/xmlgui/autotests/kglobalshortcuttest.cpp  
>   staging/xmlgui/autotests/kmainwindow_unittest.h  
>   staging/xmlgui/autotests/kmainwindow_unittest.cpp  
>   staging/xmlgui/autotests/ktoolbar_unittest.cpp  
>   staging/xmlgui/autotests/kxmlgui_unittest.h  
>   staging/xmlgui/autotests/kxmlgui_unittest.cpp  
>   staging/xmlgui/autotests/testguiclient.h  
>   staging/xmlgui/autotests/testxmlguiwindow.h  
>   staging/xmlgui/make_kdepackages.sh  
>   staging/xmlgui/make_kdepackages_updated.py  
>   staging/xmlgui/src/CMakeLists.txt b1d7d17 
>   staging/xmlgui/src/README  
>   staging/xmlgui/src/TODO  
>   staging/xmlgui/src/aboutkde.png  
>   staging/xmlgui/src/config-xmlgui.h.cmake  
>   staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake  
>   staging/xmlgui/src/kaboutapplicationdialog.h  
>   staging/xmlgui/src/kaboutapplicationdialog.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp  
>   staging/xmlgui/src/kaboutkdedialog_p.h  
>   staging/xmlgui/src/kaboutkdedialog_p.cpp  
>   staging/xmlgui/src/kactioncategory.h  
>   staging/xmlgui/src/kactioncategory.cpp  
>   staging/xmlgui/src/kactioncollection.h  
>   staging/xmlgui/src/kactioncollection.cpp  
>   staging/xmlgui/src/kactionconflictdetector.cpp  
>   staging/xmlgui/src/kbugreport.h  
>   staging/xmlgui/src/kbugreport.cpp  
>   staging/xmlgui/src/kcheckaccelerators.h  
>   staging/xmlgui/src/kcheckaccelerators.cpp  
>   staging/xmlgui/src/kdepackages.h  
>   staging/xmlgui/src/kedittoolbar.h  
>   staging/xmlgui/src/kedittoolbar.cpp  
>   staging/xmlgui/src/kedittoolbar_p.h  
>   staging/xmlgui/src/kglobalaccel.h  
>   staging/xmlgui/src/kglobalaccel.cpp  
>   staging/xmlgui/src/kglobalaccel_p.h  
>   staging/xmlgui/src/kglobalshortcutinfo.h  
>   staging/xmlgui/src/kglobalshortcutinfo.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_p.h  
>   staging/xmlgui/src/khelpclient.h  
>   staging/xmlgui/src/khelpclient.cpp  
>   staging/xmlgui/src/khelpmenu.h  
>   staging/xmlgui/src/khelpmenu.cpp  
>   staging/xmlgui/src/kkeysequencewidget.h  
>   staging/xmlgui/src/kkeysequencewidget.cpp  
>   staging/xmlgui/src/kkeysequencewidget_p.h  
>   staging/xmlgui/src/kmainwindow.h  
>   staging/xmlgui/src/kmainwindow.cpp  
>   staging/xmlgui/src/kmainwindow_p.h  
>   staging/xmlgui/src/kmainwindowiface.cpp  
>   staging

Review Request 112901: Remove weird cmake indirections

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/
---

Review request for Build System and KDE Frameworks.


Description
---

There were some un-reviewed cmake files where libraries would be defined with a 
${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that 
didn't follow through.

I propose to remove all the uses for the moment, it's not ever being set anyway.


Diffs
-

  interfaces/kimproxy/library/CMakeLists.txt 36e55ef 
  interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
  kdesu/CMakeLists.txt e526643 
  kdewebkit/CMakeLists.txt cdc5835 
  kfile/CMakeLists.txt e05137d 
  khtml/CMakeLists.txt 4e1bb80 
  kio/CMakeLists.txt 25dc6d9 
  kio/misc/kntlm/CMakeLists.txt fe70a8d 
  kjsembed/kjsembed/CMakeLists.txt 8ed55c1 
  knewstuff/src/CMakeLists.txt c313981 
  knotify/config/CMakeLists.txt 69e1c11 
  kparts/CMakeLists.txt 6ab9391 
  kpty/CMakeLists.txt 9a79827 
  kross/core/CMakeLists.txt 52cd3d4 
  kross/qts/CMakeLists.txt 1a30bd1 
  kross/ui/CMakeLists.txt 9e7806d 
  kutils/CMakeLists.txt 0cb281d 
  staging/kemoticons/src/core/CMakeLists.txt f7fb463 
  staging/ktextwidgets/src/CMakeLists.txt 4787c10 

Diff: http://git.reviewboard.kde.org/r/112901/diff/


Testing
---

Everything still builds


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112907: Move KEmoticons framework to tier3

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907/
---

(Updated Sept. 23, 2013, 5:41 p.m.)


Review request for KDE Frameworks.


Description
---

Move KEmoticons framework to tier3

Done:
-Adjust the CMakeLists.txt to the new location.
-Substitute kde_add_plugin to add_library.
-Substitute Qt5::Xml to Qt5Xml in target_link_libraries
-Substitute Qt5::Test to Qt5Test in target_link_libraries

TODO:
Modify API to make it more coherent


Diffs
-

  staging/CMakeLists.txt 5c52cbe 
  staging/kemoticons/CMakeLists.txt 0e5d935 
  staging/kemoticons/KEmoticonsConfig.cmake.in f394979 
  staging/kemoticons/autotests/CMakeLists.txt b7e890c 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input 795d3c7 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output 
795d3c7 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input 
6ddd0c7 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output 
6ddd0c7 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input 2571b16 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output 
2571b16 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input f5d8887 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output 
0d94eb9 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input 5b39691 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output 
5b39691 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input 379e01a 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output 
379e01a 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input a373402 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output 
a373402 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input 538c5b0 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output 
538c5b0 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input 
a5440d6 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output 
1f6d4aa 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input 
223ce5b 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output 
223ce5b 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input 
d685c09 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output 
e1b37c9 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input 
093690c 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output 
093690c 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input 
3994bf3 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output 
cba121a 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input 
2319ced 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output 
2319ced 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input 
d6e7e6c 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output 
d6e7e6c 
  staging/kemoticons/autotests/kemoticontest.h c79c193 
  staging/kemoticons/autotests/kemoticontest.cpp 083a804 
  staging/kemoticons/src/CMakeLists.txt 7b10087 
  staging/kemoticons/src/core/CMakeLists.txt f7fb463 
  staging/kemoticons/src/core/kemoticons.h 12b8308 
  staging/kemoticons/src/core/kemoticons.cpp 43dac65 
  staging/kemoticons/src/core/kemoticonsTheme.desktop 848ef2e 
  staging/kemoticons/src/core/kemoticonsprovider.h 85fc7ef 
  staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e 
  staging/kemoticons/src/core/kemoticonstheme.h b8b25f7 
  staging/kemoticons/src/core/kemoticonstheme.cpp ed3407c 
  staging/kemoticons/src/providers/CMakeLists.txt 445f721 
  staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be 
  staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267 
  staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0f 
  staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop 181f16a 
  staging/kemoticons/src/providers/kde/CMakeLists.txt e6d4243 
  staging/kemoticons/src/providers/kde/emoticonstheme_kde.desktop 144ee5c 
  staging/kemoticons/src/providers/kde/kde_emoticons.h 8cba6b1 
  staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a 
  staging/kemoticons/src/providers/pidgin/CMakeLists.txt 44ac2dd 
  staging/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop e334d3f 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 70bafa3 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89ee 
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt f034de0 
  staging/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop a6927e4 
  staging/kemoticons/src/providers/xmp

Re: Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112598/
---

(Updated Sept. 23, 2013, 3:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

The behavior to get a memory-only KConfig if file name is empty and the 
SimpleConfig open flag is used got lost by always setting the file name to the 
mainConfigName.


Diffs
-

  tier1/kconfig/src/core/ksharedconfig.cpp 3b53e32 

Diff: http://git.reviewboard.kde.org/r/112598/diff/


Testing
---

a failing KWin unit test doesn't fail any more.


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

[Aleix Pol Gonzalez]

> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote:
> > It does not build standalone for me, linking fails: 
> > http://paste.kde.org/p05c23fa6
> > 
> > I tried to do xmlgui last week, but realized it needs more work on the 
> > underlying frameworks first (which is why I switched to kconfigwidgets)

Building standalone is not one of the things required by 
http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .

Also it's something we probably want to deal with at a later stage, when we 
decide how each should be distributed.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/#review40574
---


On Sept. 19, 2013, 4:44 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112829/
> ---
> 
> (Updated Sept. 19, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move xmlgui to tier3, done all the checks.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 2a31994 
>   staging/xmlgui/CMakeLists.txt  
>   staging/xmlgui/TODO.xmlgui  
>   staging/xmlgui/XmlGuiConfig.cmake.in  
>   staging/xmlgui/autotests/CMakeLists.txt  
>   staging/xmlgui/autotests/kactioncategorytest.h  
>   staging/xmlgui/autotests/kactioncategorytest.cpp  
>   staging/xmlgui/autotests/kactioncollectiontest.h  
>   staging/xmlgui/autotests/kactioncollectiontest.cpp  
>   staging/xmlgui/autotests/kglobalshortcuttest.h  
>   staging/xmlgui/autotests/kglobalshortcuttest.cpp  
>   staging/xmlgui/autotests/kmainwindow_unittest.h  
>   staging/xmlgui/autotests/kmainwindow_unittest.cpp  
>   staging/xmlgui/autotests/ktoolbar_unittest.cpp  
>   staging/xmlgui/autotests/kxmlgui_unittest.h  
>   staging/xmlgui/autotests/kxmlgui_unittest.cpp  
>   staging/xmlgui/autotests/testguiclient.h  
>   staging/xmlgui/autotests/testxmlguiwindow.h  
>   staging/xmlgui/make_kdepackages.sh  
>   staging/xmlgui/make_kdepackages_updated.py  
>   staging/xmlgui/src/CMakeLists.txt b1d7d17 
>   staging/xmlgui/src/README  
>   staging/xmlgui/src/TODO  
>   staging/xmlgui/src/aboutkde.png  
>   staging/xmlgui/src/config-xmlgui.h.cmake  
>   staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake  
>   staging/xmlgui/src/kaboutapplicationdialog.h  
>   staging/xmlgui/src/kaboutapplicationdialog.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp  
>   staging/xmlgui/src/kaboutkdedialog_p.h  
>   staging/xmlgui/src/kaboutkdedialog_p.cpp  
>   staging/xmlgui/src/kactioncategory.h  
>   staging/xmlgui/src/kactioncategory.cpp  
>   staging/xmlgui/src/kactioncollection.h  
>   staging/xmlgui/src/kactioncollection.cpp  
>   staging/xmlgui/src/kactionconflictdetector.cpp  
>   staging/xmlgui/src/kbugreport.h  
>   staging/xmlgui/src/kbugreport.cpp  
>   staging/xmlgui/src/kcheckaccelerators.h  
>   staging/xmlgui/src/kcheckaccelerators.cpp  
>   staging/xmlgui/src/kdepackages.h  
>   staging/xmlgui/src/kedittoolbar.h  
>   staging/xmlgui/src/kedittoolbar.cpp  
>   staging/xmlgui/src/kedittoolbar_p.h  
>   staging/xmlgui/src/kglobalaccel.h  
>   staging/xmlgui/src/kglobalaccel.cpp  
>   staging/xmlgui/src/kglobalaccel_p.h  
>   staging/xmlgui/src/kglobalshortcutinfo.h  
>   staging/xmlgui/src/kglobalshortcutinfo.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_p.h  
>   staging/xmlgui/src/khelpclient.h  
>   staging/xmlgui/src/khelpclient.cpp  
>   staging/xmlgui/src/khelpmenu.h  
>   staging/xmlgui/src/khelpmenu.cpp  
>   staging/xmlgui/src/kkeysequencewidget.h  
>   staging/xmlgui/src/kkeysequencewidget.cpp  
>   staging/xmlgui/src/kkeysequencewidget_p.h  
>   staging/xmlgui/src/kmainwindow.h  
>   staging/xmlgui/src/kmainwindow.cpp  
>   staging/xmlgui/src/kmainwindow_p.h  
>   staging/xmlgui/src/kmainwindowiface.cpp  
>   staging/xmlgui/src/kmainwindowiface_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.h  
>   staging/xmlgui/src/kmenumenuhandler_p.cpp  
>   staging/xmlgui/src/kpartgui.dtd  
>   staging/xmlgui/src/kshortcuteditwidget.cpp  
>   staging/xmlgui/src/kshortcutschemeseditor.cpp  
>   staging/xmlgui/src/kshortcutschemeshelper.cpp  
>   staging/xmlgui/src/kshortcutschemeshelper_p.h  
>   staging/xmlgui/src/kshortcutsdialog.h  
>   staging/xmlgui/src/kshortcutsdialog.cpp  
>   staging/xmlgui/src/kshortcutsdialog.ui  
>   staging/xmlgui/src/kshortcutsdialog_p.h  
>   staging/xmlg

Re: Review Request 112907: Move KEmoticons framework to tier3

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907/#review40598
---


Can you provide a patch with --find-copies-harder?

It makes it much easier to read such patches where there are moves and changes.

Also, why did you change from Qt5::Xml to Qt5Xml?

- Aleix Pol Gonzalez


On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112907/
> ---
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move KEmoticons framework to tier3
> 
> Done:
> -Adjust the CMakeLists.txt to the new location.
> -Substitute kde_add_plugin to add_library.
> -Substitute Qt5::Xml to Qt5Xml in target_link_libraries
> -Substitute Qt5::Test to Qt5Test in target_link_libraries
> 
> TODO:
> Modify API to make it more coherent
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 5c52cbe 
>   staging/kemoticons/CMakeLists.txt 0e5d935 
>   staging/kemoticons/KEmoticonsConfig.cmake.in f394979 
>   staging/kemoticons/autotests/CMakeLists.txt b7e890c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input 
> 795d3c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output 
> 795d3c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input 
> 6ddd0c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output 
> 6ddd0c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input 
> 2571b16 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output 
> 2571b16 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input 
> f5d8887 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output 
> 0d94eb9 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input 
> 5b39691 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output 
> 5b39691 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input 
> 379e01a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output 
> 379e01a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input 
> a373402 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output 
> a373402 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input 
> 538c5b0 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output 
> 538c5b0 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input 
> a5440d6 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output 
> 1f6d4aa 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input 
> 223ce5b 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output 
> 223ce5b 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input 
> d685c09 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output 
> e1b37c9 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input 
> 093690c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output 
> 093690c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input 
> 3994bf3 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output 
> cba121a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input 
> 2319ced 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output 
> 2319ced 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input 
> d6e7e6c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output 
> d6e7e6c 
>   staging/kemoticons/autotests/kemoticontest.h c79c193 
>   staging/kemoticons/autotests/kemoticontest.cpp 083a804 
>   staging/kemoticons/src/CMakeLists.txt 7b10087 
>   staging/kemoticons/src/core/CMakeLists.txt f7fb463 
>   staging/kemoticons/src/core/kemoticons.h 12b8308 
>   staging/kemoticons/src/core/kemoticons.cpp 43dac65 
>   staging/kemoticons/src/core/kemoticonsTheme.desktop 848ef2e 
>   staging/kemoticons/src/core/kemoticonsprovider.h 85fc7ef 
>   staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e 
>   staging/kemoticons/src/core/kemoticonstheme.h b8b25f7 
>   staging/kemoticons/src/core/kemoticonstheme.cpp ed3407c 
>   staging/kemoticons/src/providers/CMakeLists.txt 445f721 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be 
>   staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267 
>   staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0f 
>   staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop 181f16a 
>   staging/kemoticons/src/providers/kde/CMakeLists.txt e

Re: Review Request 112907: Move KEmoticons framework to tier3

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907/#review40599
---


Can you provide a patch with --find-copies-harder?

It makes it much easier to read such patches where there are moves and changes.

Also, why did you change from Qt5::Xml to Qt5Xml?

- Aleix Pol Gonzalez


On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112907/
> ---
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move KEmoticons framework to tier3
> 
> Done:
> -Adjust the CMakeLists.txt to the new location.
> -Substitute kde_add_plugin to add_library.
> -Substitute Qt5::Xml to Qt5Xml in target_link_libraries
> -Substitute Qt5::Test to Qt5Test in target_link_libraries
> 
> TODO:
> Modify API to make it more coherent
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 5c52cbe 
>   staging/kemoticons/CMakeLists.txt 0e5d935 
>   staging/kemoticons/KEmoticonsConfig.cmake.in f394979 
>   staging/kemoticons/autotests/CMakeLists.txt b7e890c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input 
> 795d3c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output 
> 795d3c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input 
> 6ddd0c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output 
> 6ddd0c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input 
> 2571b16 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output 
> 2571b16 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input 
> f5d8887 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output 
> 0d94eb9 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input 
> 5b39691 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output 
> 5b39691 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input 
> 379e01a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output 
> 379e01a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input 
> a373402 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output 
> a373402 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input 
> 538c5b0 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output 
> 538c5b0 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input 
> a5440d6 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output 
> 1f6d4aa 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input 
> 223ce5b 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output 
> 223ce5b 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input 
> d685c09 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output 
> e1b37c9 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input 
> 093690c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output 
> 093690c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input 
> 3994bf3 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output 
> cba121a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input 
> 2319ced 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output 
> 2319ced 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input 
> d6e7e6c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output 
> d6e7e6c 
>   staging/kemoticons/autotests/kemoticontest.h c79c193 
>   staging/kemoticons/autotests/kemoticontest.cpp 083a804 
>   staging/kemoticons/src/CMakeLists.txt 7b10087 
>   staging/kemoticons/src/core/CMakeLists.txt f7fb463 
>   staging/kemoticons/src/core/kemoticons.h 12b8308 
>   staging/kemoticons/src/core/kemoticons.cpp 43dac65 
>   staging/kemoticons/src/core/kemoticonsTheme.desktop 848ef2e 
>   staging/kemoticons/src/core/kemoticonsprovider.h 85fc7ef 
>   staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e 
>   staging/kemoticons/src/core/kemoticonstheme.h b8b25f7 
>   staging/kemoticons/src/core/kemoticonstheme.cpp ed3407c 
>   staging/kemoticons/src/providers/CMakeLists.txt 445f721 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be 
>   staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267 
>   staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0f 
>   staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop 181f16a 
>   staging/kemoticons/src/providers/kde/CMakeLists.txt e

Re: Making KDocTools independent of KArchive

[Albert Astals Cid]

El Dilluns, 23 de setembre de 2013, a les 08:45:29, Kevin Ottens va escriure:
> On Saturday 21 September 2013 15:25:27 Albert Astals Cid wrote:
> > El Dissabte, 21 de setembre de 2013, a les 11:15:52, Stephen Kelly va
> > 
> > escriure:
> > > Albert Astals Cid wrote:
> > > >> No. I'm saying it can store and load .bin files which are processed
> > > >> with
> > > >> q{Unc,C}ompress.
> > > >> 
> > > >> There does not seem to be any need or reason for them to be .bz2.
> > > > 
> > > > There is no need for it to be a .bz2 other than "it is what it does
> > > > and
> > > > if
> > > > you change it you are going to break stuff that uses it". So yes, no
> > > > reason.
> > > 
> > > What would break? Everything that reads and writes those files is
> > > in-tree.
> > 
> > Right, i tought khelpcenter did some of the decoding, but it's done via
> > meinproc too.
> > 
> > > >> > Anyway as I was chatting with Aleix yesterday, kdoctools being a
> > > >> > tier1
> > > >> > framework "is not enough" since kconfig has docbook files (e.g. man
> > > >> > page of kconfig_compiler) so we need a tier0 here ;-)
> > > >> 
> > > >> Where is kconfig now?
> > > > 
> > > > Do I really need to do an ls for you?
> > > 
> > > What I was trying to get at is that you seem to be implying that kconfig
> > > depends on kdoctools (ie, a tier1 depends on a tier2), therefore
> > > kdoctools
> > > can't be tier1. I don't follow that logic.
> > 
> > Well, kconfig depends on kdoctools because as I said there is a docbook
> > for
> > the kconfig_compiler manpage.
> > 
> > So yes, there is a tier1 that depends on a tier2. That if as I understand
> > we plan to ship the kconfig_compiler manpage together with the kconfig
> > framework tarball.
> 
> Well, I'm not sure we want to do that. This docbook seems useful only
> because kconfig_compiler --help does a poor job at documenting itself. So
> what about completing kconfig_compiler --help output to make it useful and
> get rid of the docbook?

So we don't have a man page anymore? Debian will be happy :D

Also we're losing the i18n-zation side of the man page, which the current --
help does not have.

But anyway we seem to be cutting features here and there in sake of 
tierization, i guess this one is a minor one.

Since I'm not doing any meaningful frameworks work, O guess it's up to you 
guys if we want to have the features we had or settling for less is good 
enough.

Cheers,
  Albert

> 
> To me it looks like most of the docbook files in kdelibs are pretty much in
> the same situation and I'd favor proper --help support there than adding a
> dependency on kdoctool.
> 
> Regards.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

[Aurélien Gâteau]

> On Sept. 23, 2013, 5:10 p.m., Aurélien Gâteau wrote:
> > It does not build standalone for me, linking fails: 
> > http://paste.kde.org/p05c23fa6
> > 
> > I tried to do xmlgui last week, but realized it needs more work on the 
> > underlying frameworks first (which is why I switched to kconfigwidgets)
> 
> Aleix Pol Gonzalez wrote:
> Building standalone is not one of the things required by 
> http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .
> 
> Also it's something we probably want to deal with at a later stage, when 
> we decide how each should be distributed.
> 
> Aurélien Gâteau wrote:
> That looks a bit backward to me: how can you be sure you get dependencies 
> correctly if you can't build the framework on its own?
> 
> Aleix Pol Gonzalez wrote:
> It should be the same libraries that are specified in LINK_PUBLIC. Either 
> way, I guess we won't know for real until KF5 starts to be actually used 
> after all.

Building the framework standalone already lets you know for real if it is 
missing any required library, no?


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/#review40574
---


On Sept. 19, 2013, 6:44 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112829/
> ---
> 
> (Updated Sept. 19, 2013, 6:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move xmlgui to tier3, done all the checks.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 2a31994 
>   staging/xmlgui/CMakeLists.txt  
>   staging/xmlgui/TODO.xmlgui  
>   staging/xmlgui/XmlGuiConfig.cmake.in  
>   staging/xmlgui/autotests/CMakeLists.txt  
>   staging/xmlgui/autotests/kactioncategorytest.h  
>   staging/xmlgui/autotests/kactioncategorytest.cpp  
>   staging/xmlgui/autotests/kactioncollectiontest.h  
>   staging/xmlgui/autotests/kactioncollectiontest.cpp  
>   staging/xmlgui/autotests/kglobalshortcuttest.h  
>   staging/xmlgui/autotests/kglobalshortcuttest.cpp  
>   staging/xmlgui/autotests/kmainwindow_unittest.h  
>   staging/xmlgui/autotests/kmainwindow_unittest.cpp  
>   staging/xmlgui/autotests/ktoolbar_unittest.cpp  
>   staging/xmlgui/autotests/kxmlgui_unittest.h  
>   staging/xmlgui/autotests/kxmlgui_unittest.cpp  
>   staging/xmlgui/autotests/testguiclient.h  
>   staging/xmlgui/autotests/testxmlguiwindow.h  
>   staging/xmlgui/make_kdepackages.sh  
>   staging/xmlgui/make_kdepackages_updated.py  
>   staging/xmlgui/src/CMakeLists.txt b1d7d17 
>   staging/xmlgui/src/README  
>   staging/xmlgui/src/TODO  
>   staging/xmlgui/src/aboutkde.png  
>   staging/xmlgui/src/config-xmlgui.h.cmake  
>   staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake  
>   staging/xmlgui/src/kaboutapplicationdialog.h  
>   staging/xmlgui/src/kaboutapplicationdialog.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.h  
>   staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp  
>   staging/xmlgui/src/kaboutkdedialog_p.h  
>   staging/xmlgui/src/kaboutkdedialog_p.cpp  
>   staging/xmlgui/src/kactioncategory.h  
>   staging/xmlgui/src/kactioncategory.cpp  
>   staging/xmlgui/src/kactioncollection.h  
>   staging/xmlgui/src/kactioncollection.cpp  
>   staging/xmlgui/src/kactionconflictdetector.cpp  
>   staging/xmlgui/src/kbugreport.h  
>   staging/xmlgui/src/kbugreport.cpp  
>   staging/xmlgui/src/kcheckaccelerators.h  
>   staging/xmlgui/src/kcheckaccelerators.cpp  
>   staging/xmlgui/src/kdepackages.h  
>   staging/xmlgui/src/kedittoolbar.h  
>   staging/xmlgui/src/kedittoolbar.cpp  
>   staging/xmlgui/src/kedittoolbar_p.h  
>   staging/xmlgui/src/kglobalaccel.h  
>   staging/xmlgui/src/kglobalaccel.cpp  
>   staging/xmlgui/src/kglobalaccel_p.h  
>   staging/xmlgui/src/kglobalshortcutinfo.h  
>   staging/xmlgui/src/kglobalshortcutinfo.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp  
>   staging/xmlgui/src/kglobalshortcutinfo_p.h  
>   staging/xmlgui/src/khelpclient.h  
>   staging/xmlgui/src/khelpclient.cpp  
>   staging/xmlgui/src/khelpmenu.h  
>   staging/xmlgui/src/khelpmenu.cpp  
>   staging/xmlgui/src/kkeysequencewidget.h  
>   staging/xmlgui/src/kkeysequencewidget.cpp  
>   staging/xmlgui/src/kkeysequencewidget_p.h  
>   staging/xmlgui/src/kmainwindow.h  
>   staging/xmlgui/src/kmainwindow.cpp  
>   staging/xmlgui/src/kmainwindow_p.h  
>   staging/xmlgui/src/kmainwindowiface.cpp  
>   staging/xmlgui/src/kmainwindowiface_p.h  
> 

Review Request 112909: Remove KDE print stuff that has been ported to Qt5

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112909/
---

Review request for KDE Frameworks and John Layt.


Description
---

Most of the printing features are now part of Qt 5.2 and basically only 4 
features are left:
 - Page Label
 - Page Border
 - Mirror Pages
 - (Advanced) Job Options
 - Server-side paging

I've dropped Job Options as it was quite terrible way to edit/pass CUPS options 
directly. Server-side paging is actually just a convenient feature as with 
QPrintDialog, apps that can't do paging themselves need 2 lines of code to set 
the printing dialog up, thanks to KDEPrintDialog only one line is needed. The 
rest I've put under Page Options tab in the print dialog. To be honest I don't 
think they are that useful (or used, even) but we have the code and CUPS 
support already. If these options were to be dropped however, I'd drop the 
whole KDE Print support then as it would become just a convenient wrapper 
around QPrintDialog.


Diffs
-

  staging/kde4attic/src/CMakeLists.txt 4acf1b6 
  staging/kde4attic/src/kcupsoptionsjobwidget.ui 182b23e 
  staging/kde4attic/src/kcupsoptionsjobwidget_p.cpp 3c7913d 
  staging/kde4attic/src/kcupsoptionspageswidget.ui a68865d 
  staging/kde4attic/src/kcupsoptionspageswidget_p.h ede67e6 
  staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 79c6834 
  staging/kde4attic/src/kcupsoptionssettingswidget_p.cpp 7b58a37 
  staging/kde4attic/src/kdeprintdialog.cpp 4722f4c 

Diff: http://git.reviewboard.kde.org/r/112909/diff/


Testing
---

Tested with Konsole5.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112907: Move KEmoticons framework to tier3

[David Gil Oliva]

> On Sept. 23, 2013, 6:22 p.m., Aleix Pol Gonzalez wrote:
> > Can you provide a patch with --find-copies-harder?
> > 
> > It makes it much easier to read such patches where there are moves and 
> > changes.
> > 
> > Also, why did you change from Qt5::Xml to Qt5Xml?

> Also, why did you change from Qt5::Xml to Qt5Xml?

It didn't compile with Qt5::Xml and Qt5::Test, so I changed them to Qt5Xml and 
Qt5Test...


- David


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907/#review40599
---


On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112907/
> ---
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move KEmoticons framework to tier3
> 
> Done:
> -Adjust the CMakeLists.txt to the new location.
> -Substitute kde_add_plugin to add_library.
> -Substitute Qt5::Xml to Qt5Xml in target_link_libraries
> -Substitute Qt5::Test to Qt5Test in target_link_libraries
> 
> TODO:
> Modify API to make it more coherent
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 5c52cbe 
>   staging/kemoticons/CMakeLists.txt 0e5d935 
>   staging/kemoticons/KEmoticonsConfig.cmake.in f394979 
>   staging/kemoticons/autotests/CMakeLists.txt b7e890c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input 
> 795d3c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output 
> 795d3c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input 
> 6ddd0c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output 
> 6ddd0c7 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input 
> 2571b16 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output 
> 2571b16 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input 
> f5d8887 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output 
> 0d94eb9 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input 
> 5b39691 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output 
> 5b39691 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input 
> 379e01a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output 
> 379e01a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input 
> a373402 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output 
> a373402 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input 
> 538c5b0 
>   staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output 
> 538c5b0 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input 
> a5440d6 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output 
> 1f6d4aa 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input 
> 223ce5b 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output 
> 223ce5b 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input 
> d685c09 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output 
> e1b37c9 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input 
> 093690c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output 
> 093690c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input 
> 3994bf3 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output 
> cba121a 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input 
> 2319ced 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output 
> 2319ced 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input 
> d6e7e6c 
>   staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output 
> d6e7e6c 
>   staging/kemoticons/autotests/kemoticontest.h c79c193 
>   staging/kemoticons/autotests/kemoticontest.cpp 083a804 
>   staging/kemoticons/src/CMakeLists.txt 7b10087 
>   staging/kemoticons/src/core/CMakeLists.txt f7fb463 
>   staging/kemoticons/src/core/kemoticons.h 12b8308 
>   staging/kemoticons/src/core/kemoticons.cpp 43dac65 
>   staging/kemoticons/src/core/kemoticonsTheme.desktop 848ef2e 
>   staging/kemoticons/src/core/kemoticonsprovider.h 85fc7ef 
>   staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e 
>   staging/kemoticons/src/core/kemoticonstheme.h b8b25f7 
>   staging/kemoticons/src/core/kemoticonstheme.cpp ed3407c 
>   staging/kemoticons/src/providers/CMakeLists.txt 445f721 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be 
>   staging/kemoticons/src/providers/adium/adium_emoticons.h 03

Review Request 112907: Move KEmoticons framework to tier3

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907/
---

Review request for KDE Frameworks.


Changes
---

Use --find-copies-harder


Description
---

Move KEmoticons framework to tier3

Done:
-Adjust the CMakeLists.txt to the new location.
-Substitute kde_add_plugin to add_library.
-Substitute Qt5::Xml to Qt5Xml in target_link_libraries
-Substitute Qt5::Test to Qt5Test in target_link_libraries

TODO:
Modify API to make it more coherent


Diffs (updated)
-

  staging/CMakeLists.txt 5c52cbe 
  staging/kemoticons/CMakeLists.txt  
  staging/kemoticons/KEmoticonsConfig.cmake.in  
  staging/kemoticons/autotests/CMakeLists.txt b7e890c 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input  
  staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output  
  staging/kemoticons/autotests/kemoticontest.h  
  staging/kemoticons/autotests/kemoticontest.cpp  
  staging/kemoticons/src/CMakeLists.txt  
  staging/kemoticons/src/core/CMakeLists.txt  
  staging/kemoticons/src/core/kemoticons.h  
  staging/kemoticons/src/core/kemoticons.cpp  
  staging/kemoticons/src/core/kemoticonsTheme.desktop  
  staging/kemoticons/src/core/kemoticonsprovider.h  
  staging/kemoticons/src/core/kemoticonsprovider.cpp  
  staging/kemoticons/src/core/kemoticonstheme.h  
  staging/kemoticons/src/core/kemoticonstheme.cpp  
  staging/kemoticons/src/providers/CMakeLists.txt  
  staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be 
  staging/kemoticons/src/providers/adium/adium_emoticons.h  
  staging/kemoticons/src/providers/adium/adium_emoticons.cpp  
  staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop  
  staging/kemoticons/src/providers/kde/CMakeLists.txt e6d4243 
  staging/kemoticons/src/providers/kde/emoticonstheme_kde.desktop  
  staging/kemoticons/src/providers/kde/kde_emoticons.h  
  staging/kemoticons/src/providers/kde/kde_emoticons.cpp  
  staging/kemoticons/src/providers/pidgin/CMakeLists.txt  
  staging/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop  
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h  
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp  
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt f034de0 
  staging/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop  
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h  
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp  
  staging/kemoticons/tests/CMakeLists.txt  
  staging/kemoticons/tests/main.cpp  
  tier3/CMakeLists.txt fb4de8f 

Diff: http://git.reviewboard.kde.org/r/112907/diff/


Testing
---

It compiles, tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel ma

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

[Alexander Neundorf]

> On Sept. 23, 2013, 10:49 a.m., Kevin Ottens wrote:
> > modules/ECMAddUnitTest.cmake, line 23
> > 
> >
> > I agree, it's about "automated" (vs "manual") tests here. We've no way 
> > when writing this macro to know if the user will make an automated unit 
> > test or integration test or...

As I said, in cmake, a not-automated test is not a test. I.e. in cmake a test 
is created via add_test(). This implies that it can be automatically executed. 
Anything else is not a test in cmake.

How about ecm_add_tests()  ?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review40523
---


On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> ---
> 
> (Updated Sept. 19, 2013, 3:57 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Description
> ---
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -
> 
>   modules/ECMAddUnitTest.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112730: Make knewstuff build standalone

[Jeremy Whiting]

> On Sept. 17, 2013, 1:30 a.m., David Faure wrote:
> > knewstuff/CMakeLists.txt, line 9
> > 
> >
> > Does this really build when building all of kdelibs in one go? I 
> > thought we determined that find_package of kf5 components can't work as 
> > long as we build everything together? E.g. I see no 
> > find_package(KWindowSystem) in tier2/knotifications.
> > 
> > If you want it to build both ways I think you have to add if (NOT 
> > kdelibs_SOURCE_DIR) around the find_package(K*).

In looking at other libraries such as http://git.reviewboard.kde.org/r/112811/ 
it seems if (NOT kdelibs_SOURCE_DIR) isn't needed. why would 
find_package(KWindowSystem) need to be in teir2/knotifications ?


> On Sept. 17, 2013, 1:30 a.m., David Faure wrote:
> > knewstuff/src/CMakeLists.txt, line 72
> > 
> >
> > This can be improved:
> > 
> > use LINK_PUBLIC for libs whose classes appear in the knewstuff API, and 
> > LINK_PRIVATE for libs which are purely an implementation detail of 
> > knewstuff.
> > 
> > In addition, add a comment on each line about why the dependency is 
> > required, like
> >  ${KArchive_LIBRARIES} # for KZip
> > 
> > This helps spotting unnecessary deps, or spotting what could be done to 
> > reduce deps.

Ok, I'll do that for the next diff I upload


> On Sept. 17, 2013, 1:30 a.m., David Faure wrote:
> > knewstuff/src/downloaddialog.cpp, line 35
> > 
> >
> > to answer your question about why this is necessary, I typed "make 
> > downloaddialog.cpp.i" in my build (i.e. without this patch applied). This 
> > shows me the preprocessed file, which gets #include  
> > from ui_downloadwidget.h.
> > 
> > This is added there by staging/kde4support/src/kde4uic.cmake
> > 
> > So we have a problem. When not using kde4uic, we end up with tr() 
> > instead of i18n() (more precisely tr2i18n()) in uic-generated files.
> > This is a problem for libs and apps which use ki18n, since I think they 
> > need to use either one of the translation frameworks, but not mix them. 
> > Right, Chusslove? Albert? Anyone with a clue? :-)
> > 
> > Should we reintroduce kde4uic.cmake in the ki18n framework (with a 
> > better name), to have this work like in kde4?
> > 
> >

Yep, doing so in a different review.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112730/#review40193
---


On Sept. 17, 2013, 1:29 a.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112730/
> ---
> 
> (Updated Sept. 17, 2013, 1:29 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and 
> Chusslove Illich.
> 
> 
> Description
> ---
> 
> This makes it so I can mkdir build; cd build; cmake ../; make install from 
> knewstuff sources.
> It's still using KDE4_KIO_LIBS and find_package(KIO) since not all of the kio 
> libraries have been split out apparently.
> I'm not sure why sources had to be changed, but I had to add includes of 
> klocalizedstring where we didn't need them before somehow.
> 
> 
> Diffs
> -
> 
>   knewstuff/CMakeLists.txt 3fccbc6ee01a1cc8920321ee7125efb0bfc68412 
>   knewstuff/src/CMakeLists.txt c31398159459b79160ef76f193d6208d19953b4d 
>   knewstuff/src/downloaddialog.cpp 3294c7c04c7879320fc0949db0310868bd6fa4fa 
>   knewstuff/src/downloadwidget.cpp 64b7673d67b4e2f15007fc1a3f57d3da844d1dc0 
>   knewstuff/src/ui/entrydetailsdialog.cpp 
> 65b75d79941d9026f368f82c7b6df91d754e0925 
>   knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729 
> 
> Diff: http://git.reviewboard.kde.org/r/112730/diff/
> 
> 
> Testing
> ---
> 
> It builds and installs.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112901: Remove weird cmake indirections

[Alexander Neundorf]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/#review40612
---


This flag can be removed completely (instead of being replaced by "SHARED"), 
add_library() automatically builds shared libs if BUILD_SHARED_LIBS is set to 
true (which it is in KDECMakeSettings.cmake)


- Alexander Neundorf


On Sept. 23, 2013, 5:08 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112901/
> ---
> 
> (Updated Sept. 23, 2013, 5:08 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Description
> ---
> 
> There were some un-reviewed cmake files where libraries would be defined with 
> a ${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that 
> didn't follow through.
> 
> I propose to remove all the uses for the moment, it's not ever being set 
> anyway.
> 
> 
> Diffs
> -
> 
>   interfaces/kimproxy/library/CMakeLists.txt 36e55ef 
>   interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
>   kdesu/CMakeLists.txt e526643 
>   kdewebkit/CMakeLists.txt cdc5835 
>   kfile/CMakeLists.txt e05137d 
>   khtml/CMakeLists.txt 4e1bb80 
>   kio/CMakeLists.txt 25dc6d9 
>   kio/misc/kntlm/CMakeLists.txt fe70a8d 
>   kjsembed/kjsembed/CMakeLists.txt 8ed55c1 
>   knewstuff/src/CMakeLists.txt c313981 
>   knotify/config/CMakeLists.txt 69e1c11 
>   kparts/CMakeLists.txt 6ab9391 
>   kpty/CMakeLists.txt 9a79827 
>   kross/core/CMakeLists.txt 52cd3d4 
>   kross/qts/CMakeLists.txt 1a30bd1 
>   kross/ui/CMakeLists.txt 9e7806d 
>   kutils/CMakeLists.txt 0cb281d 
>   staging/kemoticons/src/core/CMakeLists.txt f7fb463 
>   staging/ktextwidgets/src/CMakeLists.txt 4787c10 
> 
> Diff: http://git.reviewboard.kde.org/r/112901/diff/
> 
> 
> Testing
> ---
> 
> Everything still builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Frameworks Overview

[Alexander Neundorf]

On Monday 23 September 2013, Sebastian Kügler wrote:
> Hey,
> 
> On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote:
> > On Thursday 19 September 2013 Sebastian Kügler wrote:
> > > http://community.kde.org/Frameworks/Overview
> > 
> > I have put the data on Inqlude (see http://inqlude.org/edge.html).
> 
> Thanks. One issue though, we're duplicating incomplete information that is
> in flux. (For example, I know of at least one framework that has been
> added to tier2 (I think) since last week. The information will need
> constant updating for a few more months. Having it in to places doesn't
> make that easier.
> 
> Can I update the info on inqlude.org somehow, so we can ditch the wiki
> version?
> 
> > It would be nice, if we could improve the presentation of the different
> > libraries along with the code. The goal of Inqlude is to make them easily
> > accessible not only to us, but also to Qt developers who don't
> > necessarily know anything about KDE or might have (more or less founded)
> > objections against using KDE libraries. To reach this we'll need to
> > present KF5 in a bit  more independent way, and make sure that each
> > library can stand on its own.
> 
> Technically, this is the current focus. We're splitting kdelibs.
> 
> As to communication, it probably needs a bit of boilerplate. (Which the
> bits I wrote don't contain purposefully.) Otherwise, you're right, we need
> to work on the presentation side here.

IMO, if projects.kde.org would have the wiki enabled, the project pages there 
could be an easy way to have simple homepages for all the frameworks:
https://projects.kde.org/projects/kdesupport/attica

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112907: Move KEmoticons framework to tier3

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907/
---

Review request for KDE Frameworks.


Description
---

Move KEmoticons framework to tier3

Done:
-Adjust the CMakeLists.txt to the new location.
-Substitute kde_add_plugin to add_library.
-Substitute Qt5::Xml to Qt5Xml in target_link_libraries
-Substitute Qt5::Test to Qt5Test in target_link_libraries

TODO:
Modify API to make it more coherent


Diffs
-

  staging/CMakeLists.txt 5c52cbe 
  staging/kemoticons/CMakeLists.txt 0e5d935 
  staging/kemoticons/KEmoticonsConfig.cmake.in f394979 
  staging/kemoticons/autotests/CMakeLists.txt b7e890c 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input 795d3c7 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output 
795d3c7 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input 
6ddd0c7 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output 
6ddd0c7 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input 2571b16 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output 
2571b16 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input f5d8887 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output 
0d94eb9 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input 5b39691 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output 
5b39691 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input 379e01a 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output 
379e01a 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input a373402 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output 
a373402 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input 538c5b0 
  staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output 
538c5b0 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input 
a5440d6 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output 
1f6d4aa 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input 
223ce5b 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output 
223ce5b 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input 
d685c09 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output 
e1b37c9 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input 
093690c 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output 
093690c 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input 
3994bf3 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output 
cba121a 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input 
2319ced 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output 
2319ced 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input 
d6e7e6c 
  staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output 
d6e7e6c 
  staging/kemoticons/autotests/kemoticontest.h c79c193 
  staging/kemoticons/autotests/kemoticontest.cpp 083a804 
  staging/kemoticons/src/CMakeLists.txt 7b10087 
  staging/kemoticons/src/core/CMakeLists.txt f7fb463 
  staging/kemoticons/src/core/kemoticons.h 12b8308 
  staging/kemoticons/src/core/kemoticons.cpp 43dac65 
  staging/kemoticons/src/core/kemoticonsTheme.desktop 848ef2e 
  staging/kemoticons/src/core/kemoticonsprovider.h 85fc7ef 
  staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e 
  staging/kemoticons/src/core/kemoticonstheme.h b8b25f7 
  staging/kemoticons/src/core/kemoticonstheme.cpp ed3407c 
  staging/kemoticons/src/providers/CMakeLists.txt 445f721 
  staging/kemoticons/src/providers/adium/CMakeLists.txt c94c0be 
  staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267 
  staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0f 
  staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop 181f16a 
  staging/kemoticons/src/providers/kde/CMakeLists.txt e6d4243 
  staging/kemoticons/src/providers/kde/emoticonstheme_kde.desktop 144ee5c 
  staging/kemoticons/src/providers/kde/kde_emoticons.h 8cba6b1 
  staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a 
  staging/kemoticons/src/providers/pidgin/CMakeLists.txt 44ac2dd 
  staging/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop e334d3f 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 70bafa3 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89ee 
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt f034de0 
  staging/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop a6927e4 
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 0873a63 
  staging/

Review Request 112902: Start cleanup for kdewebkit

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/
---

Review request for KDE Frameworks.


Description
---

Start to figure out the port of the cmake to KF5 standards.


Diffs
-

  kdewebkit/CMakeLists.txt cdc5835 
  kdewebkit/kwebpage.cpp 73dd5a7 
  staging/kde4support/CMakeLists.txt 24ee457 
  staging/kio/src/widgets/renamedialog.h 9a14451 

Diff: http://git.reviewboard.kde.org/r/112902/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112900: Prepare KDNSSD for moving

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112900/
---

(Updated Sept. 23, 2013, 5:29 p.m.)


Review request for KDE Frameworks.


Changes
---

Forgot to add a file, had a change that didn't belong to the patch.


Description
---

Prepares the module to be moved to its own tier.

There's a rather uncommon case with this module because there's a dependency 
against KConfig, but it only applies to when it's compiled with the mdnsd 
backend (only when there's no Avahi but mDns instead). I guess this makes it 
tier 2, but I'm not all that sure about that.


Diffs (updated)
-

  dnssd/CMakeLists.txt a2dd8e6 
  dnssd/KDNSSDConfig.cmake.in PRE-CREATION 
  dnssd/src/CMakeLists.txt 47587af 
  dnssd/src/avahi-publicservice.cpp 119c5a8 
  dnssd/src/mdnsd-publicservice.cpp 2a775fa 
  dnssd/src/servicemodel.cpp 348db57 
  staging/kde4support/CMakeLists.txt 24ee457 

Diff: http://git.reviewboard.kde.org/r/112900/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

[Jeremy Whiting]

> On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least 
> > partly.

well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files 
iirc). All I did was copy it and rename it. didn't look into making it use 
qt5_wrap_ui.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review40518
---


On Sept. 17, 2013, 1:56 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112785/
> ---
> 
> (Updated Sept. 17, 2013, 1:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Alexander Neundorf.
> 
> 
> Description
> ---
> 
> It builds and installs, but doesn't seem to be usable from within kdelibs, 
> i.e. ki18n_wrap_ui in knewstuff/src/CMakeLists.txt fails with this. I suspect 
> one more thing is needed to make it work from within kdelibs builds.
> 
> 
> Diffs
> -
> 
>   tier2/ki18n/CMakeLists.txt d0ed448 
>   tier2/ki18n/KI18nConfig.cmake.in 18b6e2f 
>   tier2/ki18n/cmake/KI18NMacros.cmake PRE-CREATION 
>   tier2/ki18n/cmake/ki18nuic.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112785/diff/
> 
> 
> Testing
> ---
> 
> Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: potential duplicate repositories for kwallet

[Valentin Rusu]

On 09/22/2013 09:43 AM, Treeve Jelbert wrote:
> There is a kwallet repo as a result of splitting kdeutils.
> 
> On my system,this installs:
> 
> /opt/qt4/bin/kwalletmanager
> /opt/qt4/lib/kde4/kcm_kwallet.so

These are from utils/kwallet, which is the "KDE Wallet Manager" tool.
This is not the KWallet API.

> 
> whereas the kwallet from kf5 installs:
> /opt/qt5/lib/libKWallet.so

This is the KWallet API, from KF5. The counter part was in kdelibs/kdeui.

> 
> Possibly the kf5 version should be renamed

No need to do that, AFAICT. Applications that need KWallet access should
switch to this new libKWallet library instead of using kdeui.

> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 
> 




signature.asc
Description: OpenPGP digital signature
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Frameworks Overview

[Ben Cooksley]

On Sep 24, 2013 7:33 AM, "Alexander Neundorf"  wrote:
>
> On Monday 23 September 2013, Sebastian Kügler wrote:
> > Hey,
> >
> > On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote:
> > > On Thursday 19 September 2013 Sebastian Kügler wrote:
> > > > http://community.kde.org/Frameworks/Overview
> > >
> > > I have put the data on Inqlude (see http://inqlude.org/edge.html).
> >
> > Thanks. One issue though, we're duplicating incomplete information that
is
> > in flux. (For example, I know of at least one framework that has been
> > added to tier2 (I think) since last week. The information will need
> > constant updating for a few more months. Having it in to places doesn't
> > make that easier.
> >
> > Can I update the info on inqlude.org somehow, so we can ditch the wiki
> > version?
> >
> > > It would be nice, if we could improve the presentation of the
different
> > > libraries along with the code. The goal of Inqlude is to make them
easily
> > > accessible not only to us, but also to Qt developers who don't
> > > necessarily know anything about KDE or might have (more or less
founded)
> > > objections against using KDE libraries. To reach this we'll need to
> > > present KF5 in a bit  more independent way, and make sure that each
> > > library can stand on its own.
> >
> > Technically, this is the current focus. We're splitting kdelibs.
> >
> > As to communication, it probably needs a bit of boilerplate. (Which the
> > bits I wrote don't contain purposefully.) Otherwise, you're right, we
need
> > to work on the presentation side here.
>
> IMO, if projects.kde.org would have the wiki enabled, the project pages
there
> could be an easy way to have simple homepages for all the frameworks:
> https://projects.kde.org/projects/kdesupport/attica

Due to maintenance and performance concerns, sysadmin would like to move
away from Chiliproject. Enabling the wiki would complicate this when a
replacement is found.

It would also create competition with the main wikis.
I'm open to suggestions though - perhaps something like the manifesto site
would work for this.

>
> Alex

Regards,
Ben

> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Frameworks Overview

[Cornelius Schumacher]

On Monday 23 September 2013 11:43:58 Sebastian Kügler wrote:
> On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote:
> > On Thursday 19 September 2013 Sebastian Kügler wrote:
> > > http://community.kde.org/Frameworks/Overview
> > 
> > I have put the data on Inqlude (see http://inqlude.org/edge.html).
> 
> Thanks. One issue though, we're duplicating incomplete information that is
> in flux. (For example, I know of at least one framework that has been
> added to tier2 (I think) since last week. The information will need
> constant updating for a few more months. Having it in to places doesn't
> make that easier.

Don't worry, I'm perfectly fine with maintaining the information on Inqlude, 
so if there is a reference location somewhere else, I'll take care of keeping 
them in sync.

> Can I update the info on inqlude.org somehow, so we can ditch the wiki
> version?

You can easily update the information. There are instructions on the web site.

We could also think about some automation depending on where it is most 
convenient to maintain the reference data.

One way would be to include some machine-readable meta data in the git 
repository, so we could generate other representations from that, be it a 
dedicated web site or the info on Inqlude, or something different.

-- 
Cornelius Schumacher 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making KDocTools independent of KArchive

[Nicolás Alvarez]

On Monday, September 23, 2013, Kevin Ottens wrote:

> On Saturday 21 September 2013 15:25:27 Albert Astals Cid wrote:
> > El Dissabte, 21 de setembre de 2013, a les 11:15:52, Stephen Kelly va
> >
> > escriure:
> > > Albert Astals Cid wrote:



> > > >> > Anyway as I was chatting with Aleix yesterday, kdoctools being a
> > > >> > tier1
> > > >> > framework "is not enough" since kconfig has docbook files (e.g.
> man
> > > >> > page of kconfig_compiler) so we need a tier0 here ;-)
> > > >>
> > > >> Where is kconfig now?
> > > >
> > > > Do I really need to do an ls for you?
> > >
> > > What I was trying to get at is that you seem to be implying that
> kconfig
> > > depends on kdoctools (ie, a tier1 depends on a tier2), therefore
> kdoctools
> > > can't be tier1. I don't follow that logic.
> >
> > Well, kconfig depends on kdoctools because as I said there is a docbook
> for
> > the kconfig_compiler manpage.
> >
> > So yes, there is a tier1 that depends on a tier2. That if as I
> understand we
> > plan to ship the kconfig_compiler manpage together with the kconfig
> > framework tarball.
>
> Well, I'm not sure we want to do that. This docbook seems useful only
> because
> kconfig_compiler --help does a poor job at documenting itself. So what
> about
> completing kconfig_compiler --help output to make it useful and get rid of
> the
> docbook?
>
> To me it looks like most of the docbook files in kdelibs are pretty much in
> the same situation and I'd favor proper --help support there than adding a
> dependency on kdoctool.
>

I assume making it an optional dependency (if not present, don't build the
manpage) doesn't help, because the current tiers fully allow having
kdoctools depend on kconfig, which would cause a circular dependency.

What does kdoctools buy us here? Maybe we can use a third-party docbook


-- 
Nicolás
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making KDocTools independent of KArchive

[Nicolás Alvarez]

On Monday, September 23, 2013, Nicolás Alvarez wrote:

> On Monday, September 23, 2013, Kevin Ottens wrote:
>
>> On Saturday 21 September 2013 15:25:27 Albert Astals Cid wrote:
>> > El Dissabte, 21 de setembre de 2013, a les 11:15:52, Stephen Kelly va
>> >
>> > escriure:
>> > > Albert Astals Cid wrote:
>
>
>
>> > > >> > Anyway as I was chatting with Aleix yesterday, kdoctools being a
>> > > >> > tier1
>> > > >> > framework "is not enough" since kconfig has docbook files (e.g.
>> man
>> > > >> > page of kconfig_compiler) so we need a tier0 here ;-)
>> > > >>
>> > > >> Where is kconfig now?
>> > > >
>> > > > Do I really need to do an ls for you?
>> > >
>> > > What I was trying to get at is that you seem to be implying that
>> kconfig
>> > > depends on kdoctools (ie, a tier1 depends on a tier2), therefore
>> kdoctools
>> > > can't be tier1. I don't follow that logic.
>> >
>> > Well, kconfig depends on kdoctools because as I said there is a docbook
>> for
>> > the kconfig_compiler manpage.
>> >
>> > So yes, there is a tier1 that depends on a tier2. That if as I
>> understand we
>> > plan to ship the kconfig_compiler manpage together with the kconfig
>> > framework tarball.
>>
>> Well, I'm not sure we want to do that. This docbook seems useful only
>> because
>> kconfig_compiler --help does a poor job at documenting itself. So what
>> about
>> completing kconfig_compiler --help output to make it useful and get rid
>> of the
>> docbook?
>>
>> To me it looks like most of the docbook files in kdelibs are pretty much
>> in
>> the same situation and I'd favor proper --help support there than adding a
>> dependency on kdoctool.
>>
>
> I assume making it an optional dependency (if not present, don't build the
> manpage) doesn't help, because the current tiers fully allow having
> kdoctools depend on kconfig, which would cause a circular dependency.
>
> What does kdoctools buy us here? Maybe we can use a third-party docbook
>

The Gmail mobile app is amazingly bad.

Maybe we can use a third-party docbook-to-manpage conversion tool. On Linux
it would be easy to install, and on Windows it wouldn't be needed ("what's
a manpage?"). And still leave it optional everywhere...

-- 
Nicolás


-- 
Nicolás
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Frameworks Overview

[Jos Poortvliet]

On Mon, Sep 23, 2013 at 11:43 AM, Sebastian Kügler  wrote:
>
> Technically, this is the current focus. We're splitting kdelibs.
>
> As to communication, it probably needs a bit of boilerplate. (Which the bits I
> wrote don't contain purposefully.) Otherwise, you're right, we need to work on
> the presentation side here.

Anything I can help with? Having some time off so I can do some
writing or even hacking on a site* where it makes sense ;-)


* I can handle some web stuff provided it ain't too complicated
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112830: Start splitting KParts

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112830/#review40629
---

Ship it!


Ship It!

- Kevin Ottens


On Sept. 23, 2013, noon, Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112830/
> ---
> 
> (Updated Sept. 23, 2013, noon)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Started reorganizing KParts, everything stopped compiling, that fixes it too.
> 
> Make string to QStrign casts explicit.
> KParts was exporting the "kio" linking, don't do it anymore.
> 
> 
> Diffs
> -
> 
>   interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
>   interfaces/terminal/example/CMakeLists.txt 57201fa 
>   kdewebkit/CMakeLists.txt cdc5835 
>   khtml/CMakeLists.txt 4e1bb80 
>   khtml/html/ksslkeygen.cpp a3118da 
>   khtml/html/ksslkeygen_p.h 95c1a71 
>   khtml/java/CMakeLists.txt ef1675c 
>   khtml/java/tests/CMakeLists.txt 59bef3a 
>   khtml/kmultipart/CMakeLists.txt 6a72fac 
>   khtml/tests/CMakeLists.txt 99b3bdd 
>   kio/CMakeLists.txt 25dc6d9 
>   kparts/CMakeLists.txt 6ab9391 
>   kparts/autotests/CMakeLists.txt PRE-CREATION 
>   kparts/autotests/openorsavequestion_unittest.cpp PRE-CREATION 
>   kparts/autotests/parttest.h PRE-CREATION 
>   kparts/autotests/parttest.cpp PRE-CREATION 
>   kparts/browserrun.h e758241 
>   kparts/tests/CMakeLists.txt 83a97f1 
>   kparts/tests/normalktm.cpp dcc3a5e 
>   kparts/tests/notepad.cpp b7c3778 
>   kparts/tests/openorsavequestion.cpp c080cfc 
>   kparts/tests/openorsavequestion_unittest.cpp 72285b1 
>   kparts/tests/parts.cpp ee198e3 
>   kparts/tests/parttest.h 19f7651 
>   kparts/tests/parttest.cpp 828666f 
>   kparts/tests/partviewer.cpp eeeb63a 
>   kparts/tests/plugin_spellcheck.cpp 073144b 
>   kparts/tests/testmainwindow.cpp fd77af0 
>   kross/modules/CMakeLists.txt b18c98b 
>   kross/ui/CMakeLists.txt 9e7806d 
>   kutils/CMakeLists.txt 0cb281d 
>   staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b 
> 
> Diff: http://git.reviewboard.kde.org/r/112830/diff/
> 
> 
> Testing
> ---
> 
> Builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review40632
---


Probably needs some porting notes in KDE5PORTING to point to QCollator.

- Kevin Ottens


On Sept. 23, 2013, 1:45 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112797/
> ---
> 
> (Updated Sept. 23, 2013, 1:45 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.
> 
> 
> Description
> ---
> 
> Apparently there's people who still want to have it. Leave it in KCoreAddons 
> for the moment, until we decide that it can be replaced for good by QCollator.
> 
> 
> Diffs
> -
> 
>   staging/kde4support/autotests/CMakeLists.txt 473bdba 
>   staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION 
>   staging/kde4support/src/CMakeLists.txt 5dc206d 
>   staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION 
>   staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 
> 
> Diff: http://git.reviewboard.kde.org/r/112797/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making KDocTools independent of KArchive

[Kevin Ottens]

On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote:
> Maybe we can use a third-party docbook-to-manpage conversion tool. On Linux
> it would be easy to install, and on Windows it wouldn't be needed ("what's
> a manpage?"). And still leave it optional everywhere...

Thats a very good question. Maybe in that case kdoctools is indeed overkill. 
Someone would have to investigate if something else could be used though.

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112880: Added KColorSchemeToken class.

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40635
---


I'm not sure we can let that in for kdelibs 4.x / kdeui... David? Any opinion?

If we ignore that point for the moment, and think in terms of KF5, ATM it would 
go with KColorScheme in KConfigWidgets. I'm not quite sold on the "Token" name 
though. It comes from the fact that it attempts to be the QML API but provided 
as a C++ API, shouldn't it be in a declarative import plugin with no C++ API? 
That'd put less pressure on the class name.


kdeui/colors/kcolorscheme.cpp


We generally do that at the end of the file.



kdeui/colors/kcolorschemetoken.cpp


Use "" for this include.


- Kevin Ottens


On Sept. 23, 2013, 2:43 p.m., Denis Kuplyakov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> ---
> 
> (Updated Sept. 23, 2013, 2:43 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Description
> ---
> 
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them 
> accessible from QML code.
> 
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to 
> libkdegames, as it uses it to access KDE's color theme.
> 
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames 
> mailinglists *
> 
> NEED TO FIX:
> I can't include it like #include  at KReversi's code, only 
> "kcolorschemetoken.h". Maybe I've missed something?
> 
> 
> Diffs
> -
> 
>   includes/CMakeLists.txt cdf0143 
>   includes/KColorSchemeToken PRE-CREATION 
>   kdeui/CMakeLists.txt b439e04 
>   kdeui/colors/kcolorscheme.h 17570fd 
>   kdeui/colors/kcolorscheme.cpp a6650ac 
>   kdeui/colors/kcolorschemetoken.h PRE-CREATION 
>   kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
> 
> 
> Testing
> ---
> 
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112902: Start cleanup for kdewebkit

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/#review40642
---



staging/kde4support/CMakeLists.txt


How is it related to the rest of the patch?



staging/kio/src/widgets/renamedialog.h


How is it related to the rest of the patch?


- Kevin Ottens


On Sept. 23, 2013, 5:27 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112902/
> ---
> 
> (Updated Sept. 23, 2013, 5:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Start to figure out the port of the cmake to KF5 standards.
> 
> 
> Diffs
> -
> 
>   kdewebkit/CMakeLists.txt cdc5835 
>   kdewebkit/kwebpage.cpp 73dd5a7 
>   staging/kde4support/CMakeLists.txt 24ee457 
>   staging/kio/src/widgets/renamedialog.h 9a14451 
> 
> Diff: http://git.reviewboard.kde.org/r/112902/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel